RE: [RFC] eal_debug: do not use malloc in rte_dump_stack

> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Saturday, 29 January 2022 02.11 > > The glibc backtrace_symbols() calls malloc which makes it > dangerous to use rte_dump_stack() in a signal handler that > is handling errors that maybe due to memory corruption. Yes. We have e

RE: [PATCH] vhost: fix data-plane access to released vq

Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, January 27, 2022 6:47 PM > To: Wang, YuanX ; Xia, Chenbo > > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > ; Ma, WenwuX ; Ling, > WeiX > Subject: Re: [PATCH] vhost: fix data-plane access to released vq > > Hi, > >

[PATCH] crypto/ipsec_mb: fix null pointer dereference

Adjust memory check and use in a proper order to avoid null pointer dereference. Fixes: 918fd2f1466b ("crypto/ipsec_mb: move aesni_mb PMD") Signed-off-by: Weiguo Li --- drivers/crypto/ipsec_mb/ipsec_mb_private.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypt

[PATCH v2 0/5] Add JSON vector set support to fips validation

Adds a very basic introduction to JSON vector sets in the fips validation example application. This patch set will only introduce the AES-GCM test using a JSON request file because the other algorithms need more information than what is given in the new JSON format. Brandon Lo (5): examples/fips

[PATCH v2 1/5] examples/fips_validation: add jansson dependency

Added a check for RTE_HAS_JANSSON into the meson configuration file for JSON support. Signed-off-by: Brandon Lo --- examples/fips_validation/meson.build | 4 1 file changed, 4 insertions(+) diff --git a/examples/fips_validation/meson.build b/examples/fips_validation/meson.build index 7eef

[PATCH v2 2/5] examples/fips_validation: add json info to header

Added json-specific functions and other information needed to test the new FIPS test vectors. Signed-off-by: Brandon Lo --- v2: * fix type of prefix to suffix examples/fips_validation/fips_validation.h | 48 -- 1 file changed, 44 insertions(+), 4 deletions(-) diff --git a/

[PATCH v2 3/5] examples/fips_validation: add json parsing

Added functions to parse the required information from a vector set given in the new json format. Signed-off-by: Brandon Lo --- v2: * fix for loop initialization examples/fips_validation/fips_validation.c | 90 +- 1 file changed, 87 insertions(+), 3 deletions(-) diff --git

[PATCH v2 4/5] examples/fips_validation: allow json file as input

Added the ability to use the json format as the input and output of the example application. Signed-off-by: Brandon Lo --- v2: * remove use_json variable examples/fips_validation/main.c | 190 +++- 1 file changed, 187 insertions(+), 3 deletions(-) diff --git a/examp

[PATCH v2 5/5] examples/fips_validation: add json to gcm test

Adds json-specific testing and writeback function. Allows the user to test AES-GCM vector sets. Signed-off-by: Brandon Lo --- .../fips_validation/fips_validation_gcm.c | 149 ++ 1 file changed, 149 insertions(+) diff --git a/examples/fips_validation/fips_validation_gcm.c b/

[PATCH] vdpa/sfc: fix null pointer dereference

When sva is null, sfc_vdpa_info(sva, ...) will cause a null dereference. Use SFC_VDPA_GENERIC_LOG() to avoid that. See macros sfc_vdpa_info and SFC_VDPA_GENERIC_LOG defined in drivers/vdpa/sfc/sfc_vdpa_log.h for detail. Fixes: 5e7596ba7cb3 ("vdpa/sfc: introduce Xilinx vDPA driver") Signed-off-by:

[PATCH] vdpa/sfc: fix null dereference

Fixes: b11961363b4a ("vdpa/sfc: support device configure and close") Signed-off-by: Weiguo Li --- drivers/vdpa/sfc/sfc_vdpa_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vdpa/sfc/sfc_vdpa_ops.c b/drivers/vdpa/sfc/sfc_vdpa_ops.c index c4ce4474ef..183834189c 100

[PATCH v3 0/5] Add JSON vector set support to fips validation

Adds a very basic introduction to JSON vector sets in the fips validation example application. This patch set will only introduce the AES-GCM test using a JSON request file because the other algorithms need more information than what is given in the new JSON format. Brandon Lo (5): examples/fips

[PATCH v3 1/5] examples/fips_validation: add jansson dependency

Added a check for RTE_HAS_JANSSON into the meson configuration file for JSON support. Signed-off-by: Brandon Lo --- examples/fips_validation/meson.build | 4 1 file changed, 4 insertions(+) diff --git a/examples/fips_validation/meson.build b/examples/fips_validation/meson.build index 7eef

[PATCH v3 2/5] examples/fips_validation: add json info to header

Added json-specific functions and other information needed to test the new FIPS test vectors. Signed-off-by: Brandon Lo --- v2: * fix type of prefix to suffix examples/fips_validation/fips_validation.h | 48 -- 1 file changed, 44 insertions(+), 4 deletions(-) diff --git a/e

[PATCH v3 3/5] examples/fips_validation: add json parsing

Added functions to parse the required information from a vector set given in the new json format. Signed-off-by: Brandon Lo --- v3: * fix checkpatch warnings v2: * fix for loop initialization examples/fips_validation/fips_validation.c | 96 +- 1 file changed, 93 insertions(

[PATCH v3 4/5] examples/fips_validation: allow json file as input

Added the ability to use the json format as the input and output of the example application. Signed-off-by: Brandon Lo --- v3: * fix checkpatch warnings v2: * remove use_json variable examples/fips_validation/main.c | 195 +++- 1 file changed, 192 insertions(+), 3 d

[PATCH v3 5/5] examples/fips_validation: add json to gcm test

Adds json-specific testing and writeback function. Allows the user to test AES-GCM vector sets. Signed-off-by: Brandon Lo --- v3: * fix checkpatch warnings .../fips_validation/fips_validation_gcm.c | 150 ++ 1 file changed, 150 insertions(+) diff --git a/examples/fips_valid

[PATCH v2] vdpa/sfc: fix null dereference

Fixes: b11961363b4a ("vdpa/sfc: support device configure and close") Signed-off-by: Weiguo Li --- drivers/vdpa/sfc/sfc_vdpa_ops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vdpa/sfc/sfc_vdpa_ops.c b/drivers/vdpa/sfc/sfc_vdpa_ops.c index c4ce4474ef..b3d9b6cd56

Re: [PATCH v2 01/83] lib: update documentation of XXX_free() functions

28/01/2022 23:51, Stephen Hemminger: > On Fri, 28 Jan 2022 22:47:15 +0100 > Thomas Monjalon wrote: > > > 24/01/2022 18:45, Stephen Hemminger: > > > These functions all behave like libc free() and do > > > nothing if handed a NULL pointer. The code is already doing > > > this, this patch just docu

[PATCH] vhost: fix null pointer dereference

Fixes: 155ee3542fb1 ("vhost: improve vhost-user layer logs") Signed-off-by: Weiguo Li --- lib/vhost/vhost_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c index e8297a09eb..d032998488 100644 --- a/lib/vhost/vhost_user.c ++

RE: [PATCH v2 1/1] net/ixgbe: check ixgbe filter init failure

> -Original Message- > From: Wang, Haiyue > Sent: Thursday, December 30, 2021 1:33 PM > To: Yunjian Wang ; dev@dpdk.org > Cc: dingxiaoxi...@huawei.com; xudin...@huawei.com; sta...@dpdk.org > Subject: RE: [PATCH v2 1/1] net/ixgbe: check ixgbe filter init failure > > > -Original Mess