Re: [PATCH] test/mbuf: fix mbuf data content check

2022-02-10 Thread David Marchand
On Thu, Feb 3, 2022 at 10:47 AM Olivier Matz wrote: > > On Thu, Feb 03, 2022 at 10:39:12AM +0100, David Marchand wrote: > > When allocating a mbuf, its data content is most of the time zero'd but > > nothing ensures this. This is especially wrong when building with > > RTE_MALLOC_DEBUG, where data

Re: [PATCH v3] app/test-fib: fix possible division by zero

2022-02-10 Thread David Marchand
On Fri, Jan 28, 2022 at 6:44 PM Kevin Traynor wrote: > > On 27/01/2022 18:08, Vladimir Medvedkin wrote: > > This patch fixes the division by 0, > > which occurs if the number of routes is less than 10. > > Can be triggered by passing -n argument with value < 10: > > > > ./dpdk-test-fib -- -n 9 > >

Re: [dpdk-dev] [PATCH 1/1] mem: check allocation in dynamic hugepage init

2022-02-10 Thread David Marchand
On Sat, Feb 5, 2022 at 6:29 PM David Marchand wrote: > > On Tue, Dec 14, 2021 at 2:30 PM Yunjian Wang wrote: > > > > The function malloc() could return NULL, the return value > > need to be checked. > > > > Fixes: 694161b7e065 ("mem: extract common dynamic memory allocation") That's actually int

Re: [dpdk-dev] [PATCH v2] eal/arm: remove CASP constraints for GCC

2022-02-10 Thread David Marchand
On Tue, Nov 16, 2021 at 3:56 PM David Marchand wrote: > > > GCC now assigns even register pairs for CASP, the fix has also been > > > backported to all stable releases of older GCC versions. > > > Removing the manual register allocation allows GCC to inline the functions > > > and pick optimal reg

[PATCH v2 2/2] net/iavf: support L2TPv2 for AVF FDIR

2022-02-10 Thread Jie Wang
Add support for L2TPv2(include PPP over L2TPv2) protocols FDIR based on outer MAC src/dst address and L2TPv2 session ID. Add support for PPPoL2TPv2oUDP protocols FDIR based on inner IP src/dst address and UDP/TCP src/dst port. Patterns are listed below: eth/ipv4(6)/udp/l2tpv2 eth/ipv4(6)/udp/l2tp

[PATCH v2 1/2] net/iavf: support L2TPv2 for AVF HASH

2022-02-10 Thread Jie Wang
Add support for PPP over L2TPv2 over UDP protocol and L2TPv2 protocol RSS hash based on outer MAC src/dst address and L2TPv2 session ID. Patterns are listed below: eth/ipv4/udp/l2tpv2 eth/ipv4/udp/l2tpv2/ppp eth/ipv6/udp/l2tpv2 eth/ipv6/udp/l2tpv2/ppp Signed-off-by: Jie Wang --- doc/guides/rel_

[PATCH v2 0/2] support L2TPv2 for AVF RSS hash and FDIR

2022-02-10 Thread Jie Wang
Support IAVF L2TPv2(include PPP over L2tpv2) RSS hash and flow director. Required to distribute packets based on outer MAC src/dst address and L2TPv2 session ID. Support IAVF PPPoL2TPv2oUDP flow director. Required to distribute packets based on inner IP src+dest address and TCP/UDP src+dest port.

RE: [PATCH v4] net/af_xdp: re-enable secondary process support

2022-02-10 Thread Loftus, Ciara
> > On 2/10/2022 5:47 PM, Loftus, Ciara wrote: > >> Subject: Re: [PATCH v4] net/af_xdp: re-enable secondary process support > >> > >> On 2/10/2022 3:40 PM, Loftus, Ciara wrote: > Subject: Re: [PATCH v4] net/af_xdp: re-enable secondary process > support > > On 2/9/2022 9:48 AM, Ciara

Re: [PATCH] mempool/cnxk: fix bug in batch alloc issue failure path

2022-02-10 Thread Jerin Jacob
On Thu, Feb 10, 2022 at 5:19 PM Ashwin Sekhar T K wrote: > > Fix bug in batch alloc issue failure path. Please specify what is the bug and what is the fix. > > Fixes: 91531e63f4 ("mempool/cnxk: add cn10k batch dequeue") > > Signed-off-by: Ashwin Sekhar T K > --- > drivers/mempool/cnxk/cn10k_me

[PATCH] eal/linux: fix fail to stop device monitor error

2022-02-10 Thread wenxuanx . wu
From: Wenxuan Wu The ret value stands for whether the device monitor has been successfully closed, and has nothing to do with rte_intr_callback_unregister funcs once it return a value greater than 0 .So if the closure procedure has gone to the right exit point ,we should set this value to 0. Als

Re: [PATCH] app/testpmd : fix testpmd quit error

2022-02-10 Thread Singh, Aman Deep
Hi Wenxuan Wu, On 2/9/2022 4:12 PM, wenxuanx...@intel.com wrote: From: Wenxuan Wu when testpmd startup with pf and vfs, it is ok when running, while exiting, it will result in heap-free-after-use which means pf is released but vf is still accessing. Change the logic of func port_is_bonding_sla

[PATCH v3] net/ice: fix missing clock initialization

2022-02-10 Thread Simei Su
Rx PHY timer init value is not same as primary timer init value when power up which will lead Rx timestamp always have big gap compared with PTP timestamp. This patch adds PHC init time in initializing PTP hardware clock. Fixes: 646dcbe6c701 ("net/ice: support IEEE 1588 PTP") Cc: sta...@dpdk.org

RE: [PATCH v4 1/2] gpudev: expose GPU memory to CPU

2022-02-10 Thread Wang, Haiyue
From: Elena Agostini Sent: Thursday, February 10, 2022 18:38 To: Wang, Haiyue ; dev@dpdk.org Subject: Re: [PATCH v4 1/2] gpudev: expose GPU memory to CPU > From: Wang, Haiyue > Date: Thursday, 27 January 2022 at 07:56 > To: Elena Agostini

RE: [PATCH v5 1/2] eventdev/crypto_adapter: move crypto ops to circular buffer

2022-02-10 Thread Gujjar, Abhinandan S
Acked-by: Abhinandan Gujjar > -Original Message- > From: Kundapura, Ganapati > Sent: Thursday, February 10, 2022 11:11 PM > To: Jayatheerthan, Jay ; > jerinjac...@gmail.com; Gujjar, Abhinandan S > ; dev@dpdk.org > Subject: [PATCH v5 1/2] eventdev/crypto_adapter: move crypto ops to > circ

RE: [PATCH v5 2/2] eventdev: update crypto caps get to return SW cap

2022-02-10 Thread Gujjar, Abhinandan S
Acked-by: Abhinandan Gujjar > -Original Message- > From: Kundapura, Ganapati > Sent: Thursday, February 10, 2022 11:11 PM > To: Jayatheerthan, Jay ; > jerinjac...@gmail.com; Gujjar, Abhinandan S > ; dev@dpdk.org > Subject: [PATCH v5 2/2] eventdev: update crypto caps get to return SW cap

RE: Questions on i40e TX path

2022-02-10 Thread Honnappa Nagarahalli
> > > > Thank you for your input. Please see few comments inline. > > > > > > Subject: Questions on i40e TX path > > > > > > > > Hi Beilei, > > > > I want to make sure my understanding of the TX path is correct. > > > > Following is my understanding. > > > > > > > > 1) The RS bit must be

RE: [PATCH v2 2/2] examples/l3fwd: make RX and TX queue size configurable

2022-02-10 Thread Honnappa Nagarahalli
> > On Fri, 11 Feb 2022 00:26:07 + > Honnappa Nagarahalli wrote: > > > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index > > acd186ab7d..afe94cd1d7 100644 > > --- a/examples/l3fwd/main.c > > +++ b/examples/l3fwd/main.c > > @@ -341,6 +341,8 @@ print_usage(const char *prgname)

RE: [PATCH v2 2/2] examples/l3fwd: make RX and TX queue size configurable

2022-02-10 Thread Honnappa Nagarahalli
> > On Fri, 11 Feb 2022 00:26:07 + > Honnappa Nagarahalli wrote: > > > +static void > > +parse_rx_queue_size(const char *rx_queue_size_arg) { > > + char *end = NULL; > > + uint32_t rx_queue_size; > > + > > + /* parse decimal string */ > > + rx_queue_size = strtoul(rx_queue_size_arg

RE: [PATCH v2 0/2] vhost: fix async address mapping

2022-02-10 Thread Ding, Xuan
Hi Maxime & Kevin, > -Original Message- > From: Maxime Coquelin > Sent: 2022年2月4日 18:57 > To: Ding, Xuan ; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Wang, YuanX > > Subject: Re: [PATCH v2 0/2] vhost: fix async address mapping > > > > On 1/19/22 16:10, xuan.d...@intel.com wrote: > >

RE: Questions on i40e TX path

2022-02-10 Thread Xing, Beilei
> -Original Message- > From: Honnappa Nagarahalli > Sent: Thursday, February 10, 2022 12:38 PM > To: Xing, Beilei ; dev@dpdk.org > Cc: Feifei Wang ; Ruifeng Wang > ; Yigit, Ferruh ; Richardson, > Bruce ; nd ; nd > Subject: RE: Questions on i40e TX path > > > > Thank you for your inp

[PATCH v5 10/10] app/testpmd: add async indirect actions creation/destruction

2022-02-10 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_q_action_handle API. Provide the command line interface for operations dequeue. Usage example: flow queue 0 indirect_action 0 create action_id 9 ingress postpone yes action rss / end flow queue 0 indirect_action 0 update action_id 9 action queue inde

[PATCH v5 09/10] app/testpmd: add flow queue pull operation

2022-02-10 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_q_pull API. Provide the command line interface for pulling operations results. Usage example: flow pull 0 queue 0 Signed-off-by: Alexander Kozyrev Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 56 +++- app/test-pmd/config.c

[PATCH v5 08/10] app/testpmd: add flow queue push operation

2022-02-10 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_q_push API. Provide the command line interface for pushing operations. Usage example: flow queue 0 push 0 Signed-off-by: Alexander Kozyrev Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 56 - app/test-pmd/config.c

[PATCH v5 05/10] app/testpmd: add flow template management

2022-02-10 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_pattern_template and rte_flow_actions_template APIs. Provide the command line interface for the template creation/destruction. Usage example: testpmd> flow pattern_template 0 create pattern_template_id 2 template eth dst is 00:16:3e:31:15:c3 / end

[PATCH v5 07/10] app/testpmd: add async flow create/destroy operations

2022-02-10 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_q_create/rte_flow_q_destroy API. Provide the command line interface for enqueueing flow creation/destruction operations. Usage example: testpmd> flow queue 0 create 0 postpone no template_table 6 pattern_template 0 actions_template 0 patt

[PATCH v5 06/10] app/testpmd: add flow table management

2022-02-10 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_table API. Provide the command line interface for the flow table creation/destruction. Usage example: testpmd> flow template_table 0 create table_id 6 group 9 priority 4 ingress mode 1 rules_number 64 pattern_template 2 actions_template 4 testpmd> fl

[PATCH v5 04/10] app/testpmd: add flow engine configuration

2022-02-10 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_configure API. Provide the command line interface for the Flow management. Usage example: flow configure 0 queues_number 8 queues_size 256 Implement rte_flow_info_get API to get available resources: Usage example: flow info 0 Signed-off-by: Alexander Kozyrev

[PATCH v5 01/10] ethdev: introduce flow pre-configuration hints

2022-02-10 Thread Alexander Kozyrev
The flow rules creation/destruction at a large scale incurs a performance penalty and may negatively impact the packet processing when used as part of the datapath logic. This is mainly because software/hardware resources are allocated and prepared during the flow rule creation. In order to optimi

[PATCH v5 03/10] ethdev: bring in async queue-based flow rules operations

2022-02-10 Thread Alexander Kozyrev
A new, faster, queue-based flow rules management mechanism is needed for applications offloading rules inside the datapath. This asynchronous and lockless mechanism frees the CPU for further packet processing and reduces the performance impact of the flow rules creation/destruction on the datapath.

[PATCH v5 02/10] ethdev: add flow item/action templates

2022-02-10 Thread Alexander Kozyrev
Treating every single flow rule as a completely independent and separate entity negatively impacts the flow rules insertion rate. Oftentimes in an application, many flow rules share a common structure (the same item mask and/or action list) so they can be grouped and classified together. This knowl

[PATCH v5 00/10] ethdev: datapath-focused flow rules management

2022-02-10 Thread Alexander Kozyrev
Three major changes to a generic RTE Flow API were implemented in order to speed up flow rule insertion/destruction and adapt the API to the needs of a datapath-focused flow rules management applications: 1. Pre-configuration hints. Application may give us some hints on what type of resources are

[PATCH 2/2] net/iavf: support L2TPv2 for AVF FDIR

2022-02-10 Thread Jie Wang
Add support for L2TPv2(include PPP over L2TPv2) protocols FDIR based on outer MAC src/dst address and L2TPv2 session ID. Add support for PPPoL2TPv2oUDP protocols FDIR based on inner IP src/dst address and UDP/TCP src/dst port. Patterns are listed below: eth/ipv4(6)/udp/l2tpv2 eth/ipv4(6)/udp/l2tp

[PATCH 1/2] net/iavf: support L2TPv2 for AVF HASH

2022-02-10 Thread Jie Wang
Add support for PPP over L2TPv2 over UDP protocol and L2TPv2 protocol RSS hash based on outer MAC src/dst address and L2TPv2 session ID. Patterns are listed below: eth/ipv4/udp/l2tpv2 eth/ipv4/udp/l2tpv2/ppp eth/ipv6/udp/l2tpv2 eth/ipv6/udp/l2tpv2/ppp Signed-off-by: Jie Wang --- doc/guides/rel_

[PATCH 0/2] support L2TPv2 for AVF RSS hash and FDIR

2022-02-10 Thread Jie Wang
Support IAVF L2TPv2(include PPP over L2tpv2) RSS hash and flow director. Required to distribute packets based on outer MAC src/dst address and L2TPv2 session ID. Support IAVF PPPoL2TPv2oUDP flow director. Required to distribute packets based on inner IP src+dest address and TCP/UDP src+dest port.

Re:Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data

2022-02-10 Thread Huichao Cai
A small problem.Why is the content of the email just sent to you not visible at Patchwork (this patch).

Re:Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data

2022-02-10 Thread Huichao Cai
Hi,Konstantin Thank you for your reply! >As a nit, why not 'uint8_t *', to keep style the same through all file? Yes,I can use 'uint8_t *.Thank you for your correction. >We already done such calculation in rte_ipv4_fragment_packet(), >so can re-use header_len value here. Yes,I can re-use hea

RE: [PATCH v2 08/12] net/ngbe: fix debug log

2022-02-10 Thread Jiawen Wu
On February 10, 2022 6:16 PM, Ferruh Yigit wrote: > On 2/10/2022 9:49 AM, Jiawen Wu wrote: > > On February 10, 2022 5:03 PM, Ferruh Yigit wrote: > >> On 2/10/2022 8:03 AM, Jiawen Wu wrote: > >>> On February 10, 2022 3:07 AM, Ferruh Yigit wrote: > On 2/9/2022 10:42 AM, Jiawen Wu wrote: > >

[v2 4/4] net/mlx5: support matching optional fields of GRE

2022-02-10 Thread Sean Zhang
This patch adds matching on the optional fields (checksum/key/sequence) of GRE header. The matching of checksum and sequence fields requests support from rdma-core with capability of misc5 and tunner_header 0-3. For patterns without checksum and sequence specified, keep using misc for matching as

[v2 3/4] app/testpmd: add gre_option item command

2022-02-10 Thread Sean Zhang
Add gre_option command for matching optional fields(checksum/key/sequence) in GRE header. The item must follow gre item, and the item does not change the flags in gre item, the application should set the flags in gre item correspondingly. Application can still use gre_key item 'gre_key value is xx'

[v2 2/4] ethdev: support GRE optional fields

2022-02-10 Thread Sean Zhang
Add flow pattern items and header format for matching optional fields (checksum/key/sequence) in GRE header. And the flags in gre item should be correspondingly set with the new added items. Signed-off-by: Sean Zhang --- doc/guides/prog_guide/rte_flow.rst | 17 + doc/guides/r

[v2 1/4] lib: add optional fields in GRE header

2022-02-10 Thread Sean Zhang
There are optional fields in GRE header(checksum/key/sequence), this patch adds definition of structures of the optional fields. Signed-off-by: Sean Zhang --- lib/net/rte_gre.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/lib/net/rte_gre.h b/lib/net/rte_gre.h index

[v2 0/4] Add support for GRE optional fields matching

2022-02-10 Thread Sean Zhang
This patch set adds support for matching optional fields of GRE header. The optional fields are checksum, key and sequence number. Currently, key field is supported with pattern gre_key item '.. / gre / gre_key value is xx / ..' with field gre_key in misc, but misc does not support matching of chec

RE: [PATCH v5 4/6] common/iavf: add session ID fields for L2TPv2

2022-02-10 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Jie1X > Sent: Wednesday, February 9, 2022 5:39 PM > To: dev@dpdk.org > Cc: Yang, SteveX ; or...@nvidia.com; Singh, Aman > Deep ; Yigit, Ferruh ; > tho...@monjalon.net; andrew.rybche...@oktetlabs.ru; Wu, Jingjing > ; Xing, Beilei ; Zhang, Qi Z > ; olivi

e1000 forced 1G support?

2022-02-10 Thread Bly, Mike
Hello, This is in regards to the DPDK E1000 driver used for the i350 [8086:1521] NIC. I am looking to see if we can get forced speed == 1000Mb (1Gb) support working on this NIC. The current DPDK driver does not appear to have support for forcing the NIC to 1G (1000M) speed. It only supports set

RE: [PATCH v2] net/iavf: initialize large VF setting at startup

2022-02-10 Thread Zhang, Qi Z
> -Original Message- > From: Xu, Ting > Sent: Thursday, February 10, 2022 10:17 PM > To: Ghalem Boudour ; Wu, Jingjing > ; Xing, Beilei > Cc: dev@dpdk.org; Thibaut Collet ; Olivier Matz > > Subject: RE: [PATCH v2] net/iavf: initialize large VF setting at startup > > > -Original M

RE: [PATCH v3] net/ice: fix pattern check logic in FDIR

2022-02-10 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Junfeng > Sent: Tuesday, February 8, 2022 3:09 PM > To: Zhang, Qi Z ; Wu, Jingjing > ; Xing, Beilei > Cc: dev@dpdk.org; sta...@dpdk.org; Guo, Junfeng > Subject: [PATCH v3] net/ice: fix pattern check logic in FDIR > > Mask for IPv4/UDP/TCP/SCTP addr/p

Re: [PATCH v2 2/2] examples/l3fwd: make RX and TX queue size configurable

2022-02-10 Thread Stephen Hemminger
On Fri, 11 Feb 2022 00:26:07 + Honnappa Nagarahalli wrote: > +static void > +parse_rx_queue_size(const char *rx_queue_size_arg) > +{ > + char *end = NULL; > + uint32_t rx_queue_size; > + > + /* parse decimal string */ > + rx_queue_size = strtoul(rx_queue_size_arg, &end, 10); >

Re: [PATCH v2 2/2] examples/l3fwd: make RX and TX queue size configurable

2022-02-10 Thread Stephen Hemminger
On Fri, 11 Feb 2022 00:26:07 + Honnappa Nagarahalli wrote: > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c > index acd186ab7d..afe94cd1d7 100644 > --- a/examples/l3fwd/main.c > +++ b/examples/l3fwd/main.c > @@ -341,6 +341,8 @@ print_usage(const char *prgname) > " [-

[PATCH v2 2/2] examples/l3fwd: make RX and TX queue size configurable

2022-02-10 Thread Honnappa Nagarahalli
Make RX and TX queue sizes configurable from the command line. This helps DTS write better test cases. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Kathleen Capella Reviewed-by: Ruifeng Wang Acked-by: Bruce Richardson --- examples/l3fwd/main.c | 56

[PATCH v2 1/2] examples/l3fwd: use single set of variables throughout the code

2022-02-10 Thread Honnappa Nagarahalli
nb_rxd and nb_txd are used in polling mode and event mode of operation. nb_rxd and nb_txd are already global in polling mode but are not visible to event mode code. Make them visible to all parts of the application. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Kathleen Capella Reviewed-by: R

[PATCH 3/3] app/dumpcap: check for failure to set promiscious

2022-02-10 Thread Stephen Hemminger
If the rte_eth_promiscious_enable() fails, then log the error and continue. Coverity issue: 373662 Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff

[PATCH 2/3] app/test_bpf: don't print eBPF program if NULL

2022-02-10 Thread Stephen Hemminger
If conversion of cBPF to eBPF fails (in rte_bpf_convert) then the test should not try and print the result. Coverity issue: 373661 Fixes: 2eccf6afbea9 ("bpf: add function to convert classic BPF to DPDK BPF") Signed-off-by: Stephen Hemminger --- app/test/test_bpf.c | 6 -- 1 file changed, 4 i

[PATCH 1/3] pcapng: handle rte_ethlink_get failing

2022-02-10 Thread Stephen Hemminger
If rte_ethlink_get fails, the code can just not add speed to the pcap file. Coverity issue: 373664 Fixes: 8d23ce8f5ee9 ("pcapng: add new library for writing pcapng files") Signed-off-by: Stephen Hemminger --- lib/pcapng/rte_pcapng.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 0/3] small fixes suggested by Coverity scan

2022-02-10 Thread Stephen Hemminger
Fix some simple bugs. Stephen Hemminger (3): pcapng: handle rte_ethlink_get failing app/test_bpf: don't print eBPF program if NULL app/dumpcap: check for failure to set promiscious app/dumpcap/main.c | 9 +++-- app/test/test_bpf.c | 6 -- lib/pcapng/rte_pcapng.c | 4 ++--

Re: [dpdk-dev] [PATCH v7 1/4] ethdev: support device reset and recovery events

2022-02-10 Thread Thomas Monjalon
03/02/2022 21:28, Ajit Khaparde: > On Tue, Feb 1, 2022 at 5:20 AM Ferruh Yigit wrote: > > On 2/1/2022 1:09 PM, Kalesh Anakkur Purayil wrote: > > > On Tue, Feb 1, 2022 at 5:41 PM Ferruh Yigit > > > wrote: > > > On 1/28/2022 12:48 PM, Kalesh A P wrote: > > >

RE: [EXT] [PATCH v6 0/5] crypto: improve asym session usage

2022-02-10 Thread Akhil Goyal
> This patchset includes improvements for the asymmetric session. > The main change is to the session structure, which is now a single > mempool object, rather than having pointers to private data elsewhere. > This session structure is now hidden in an internal header, > so the app will never use

Re: [dpdk-dev] [PATCH v7 1/4] ethdev: support device reset and recovery events

2022-02-10 Thread Thomas Monjalon
02/02/2022 12:44, Ray Kinsella: > Ferruh Yigit writes: > > On 1/28/2022 12:48 PM, Kalesh A P wrote: > >> --- a/lib/ethdev/rte_ethdev.h > >> +++ b/lib/ethdev/rte_ethdev.h > >> @@ -3818,6 +3818,24 @@ enum rte_eth_event_type { > >>RTE_ETH_EVENT_DESTROY, /**< port is released */ > >>RTE_ETH_E

Re: [PATCH v4 0/7] Verify C++ compatibility of public headers

2022-02-10 Thread Thomas Monjalon
10/02/2022 16:42, Bruce Richardson: > Bruce Richardson (7): > eal: fix header build with C++ > eventdev: fix header build with C++ > graph: fix missing explicit cast for C++ build > ipsec: fix missing explicit cast for C++ build > table: fix missing explicit casts for C++ build > vhost:

Re: [PATCH v1] drivers/net: use internal API to get eth dev from name

2022-02-10 Thread Owen Hilyard
The latest script in CI correctly selects 'next-net' for this patch. >

Re: [PATCH v4 7/7] buildtools/chkincs: test headers for C++ compatibility

2022-02-10 Thread Thomas Monjalon
10/02/2022 16:42, Bruce Richardson: > +executable('chkincs-cpp', cpp_sources, > +cpp_args: ['-include', 'rte_config.h', cflags], > +link_args: dpdk_extra_ldflags, > +include_directories: includes, > +dependencies: deps, > +link_whole: dpdk_static_libraries +

Re: [PATCH] vhost: fix null pointer dereference

2022-02-10 Thread Maxime Coquelin
On 1/29/22 20:07, Weiguo Li wrote: Fixes: 155ee3542fb1 ("vhost: improve vhost-user layer logs") Signed-off-by: Weiguo Li --- lib/vhost/vhost_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c index e8297a09eb..d032998

RE: [EXT] [PATCH v2 4/4] crypto: reorganize endianness comments, add crypto uint

2022-02-10 Thread Akhil Goyal
Hi Fan, > Hi Akhil, > > I assume everything in asym crypto is under experimental tag at the moment > right? > The goal is to have them updated and fixed before DPDK 22.11 so the > experimental tag can be removed. > Asymmetric crypto APIs are marked as experimental, but the structures are not expl

Re: [PATCH v4 1/1] vhost: integrate dmadev in asynchronous data-path

2022-02-10 Thread Maxime Coquelin
On 2/10/22 21:50, Ferruh Yigit wrote: On 2/9/2022 12:51 PM, Jiayu Hu wrote: Since dmadev is introduced in 21.11, to avoid the overhead of vhost DMA abstraction layer and simplify application logics, this patch integrates dmadev in asynchronous data path. Signed-off-by: Jiayu Hu Signed-off-b

Re: [PATCH v4 1/1] vhost: integrate dmadev in asynchronous data-path

2022-02-10 Thread Maxime Coquelin
Hi Ferruh, On 2/10/22 21:56, Ferruh Yigit wrote: On 2/9/2022 12:51 PM, Jiayu Hu wrote: Since dmadev is introduced in 21.11, to avoid the overhead of vhost DMA abstraction layer and simplify application logics, this patch integrates dmadev in asynchronous data path. Signed-off-by: Jiayu Hu Sign

Re: [PATCH v4 1/1] vhost: integrate dmadev in asynchronous data-path

2022-02-10 Thread Ferruh Yigit
On 2/9/2022 12:51 PM, Jiayu Hu wrote: Since dmadev is introduced in 21.11, to avoid the overhead of vhost DMA abstraction layer and simplify application logics, this patch integrates dmadev in asynchronous data path. Signed-off-by: Jiayu Hu Signed-off-by: Sunil Pai G Patch gives a build error

Re: [PATCH v4 1/1] vhost: integrate dmadev in asynchronous data-path

2022-02-10 Thread Ferruh Yigit
On 2/9/2022 12:51 PM, Jiayu Hu wrote: Since dmadev is introduced in 21.11, to avoid the overhead of vhost DMA abstraction layer and simplify application logics, this patch integrates dmadev in asynchronous data path. Signed-off-by: Jiayu Hu Signed-off-by: Sunil Pai G CI not run on this patch

RE: [PATCH v1] drivers/net: use internal API to get eth dev from name

2022-02-10 Thread Yigit, Ferruh
Hi Owen, I can’t open the link. But it was initially applied to the main repo, later I manually re-run it on next-net. Compile error also verifies this [1], ‘rte_eth_dev_get_by_name()’ was added in next-net and missing in the main repo, error is related to API being missing. Anyway, if the lat

Open Coverity defects in DPDK

2022-02-10 Thread Mcnamara, John
Folks, If your email is on the "To" list then you have an open defect in the DPDK Coverity database. Due to an issue with an automated emailer you may not have received an email notifying you about this. We will try to send them again. In the meantime you can see the defects against your email

Re: [PATCH v4] net/af_xdp: re-enable secondary process support

2022-02-10 Thread Ferruh Yigit
On 2/10/2022 5:47 PM, Loftus, Ciara wrote: Subject: Re: [PATCH v4] net/af_xdp: re-enable secondary process support On 2/10/2022 3:40 PM, Loftus, Ciara wrote: Subject: Re: [PATCH v4] net/af_xdp: re-enable secondary process support On 2/9/2022 9:48 AM, Ciara Loftus wrote: Secondary process supp

[PATCH] pipeline: fix table state memory allocation

2022-02-10 Thread Cristian Dumitrescu
The regular tables, selector tables and learner tables are all sharing the table state array. The locations in this array were computed incorrectly, leading to memory corruption issues. Signed-off-by: Cristian Dumitrescu Signed-off-by: Harshad Narayane Signed-off-by: Kamalakannan R Signed-off-b

Re: [PATCH] ethdev: introduce generic dummy packet burst function

2022-02-10 Thread Thomas Monjalon
10/02/2022 17:30, Stephen Hemminger: > On Thu, 10 Feb 2022 13:58:43 + > Ferruh Yigit wrote: > > On 2/8/2022 7:44 PM, Ferruh Yigit wrote: > > > --- a/drivers/net/mlx5/mlx5.c > > > +++ b/drivers/net/mlx5/mlx5.c > > > @@ -1559,8 +1559,8 @@ mlx5_dev_close(struct rte_eth_dev *dev) > > > m

Re: [PATCH v4 00/10] ethdev: datapath-focused flow rules management

2022-02-10 Thread Ajit Khaparde
On Thu, Feb 10, 2022 at 8:00 AM Ferruh Yigit wrote: > > On 2/9/2022 9:37 PM, Alexander Kozyrev wrote: > > Three major changes to a generic RTE Flow API were implemented in order > > to speed up flow rule insertion/destruction and adapt the API to the > > needs of a datapath-focused flow rules mana

DPDK Release Status Meeting 2022-02-10

2022-02-10 Thread Mcnamara, John
Release status meeting minutes 2022-02-10 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * ARM * Debian * Intel * Marvell * Nvidia * Red Hat Release Dates - The following are the proposed dates for 22.03

RE: [PATCH v4] net/af_xdp: re-enable secondary process support

2022-02-10 Thread Loftus, Ciara
> Subject: Re: [PATCH v4] net/af_xdp: re-enable secondary process support > > On 2/10/2022 3:40 PM, Loftus, Ciara wrote: > >> Subject: Re: [PATCH v4] net/af_xdp: re-enable secondary process support > >> > >> On 2/9/2022 9:48 AM, Ciara Loftus wrote: > >>> Secondary process support had been disabled

RE: [PATCH v4 1/2] eventdev/crypto_adapter: move crypto ops to circular buffer

2022-02-10 Thread Kundapura, Ganapati
Hi Abhi, > -Original Message- > From: Gujjar, Abhinandan S > Sent: 10 February 2022 20:37 > To: Kundapura, Ganapati ; Jayatheerthan, > Jay ; jerinjac...@gmail.com; dev@dpdk.org > Subject: RE: [PATCH v4 1/2] eventdev/crypto_adapter: move crypto ops to > circular buffer > > Hi Ganapati, >

[PATCH v5 2/2] eventdev: update crypto caps get to return SW cap

2022-02-10 Thread Ganapati Kundapura
update rte_event_crypto_adapter_caps_get() to return SW_CAP if PMD callback is not registered. Signed-off-by: Ganapati Kundapura diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c index 79b9ea3..6988bf1 100644 --- a/lib/eventdev/rte_eventdev.c +++ b/lib/eventdev/rte_eventdev.

[PATCH v5 1/2] eventdev/crypto_adapter: move crypto ops to circular buffer

2022-02-10 Thread Ganapati Kundapura
Move crypto ops to circular buffer to retain crypto ops when cryptodev/eventdev are temporarily full Signed-off-by: Ganapati Kundapura --- v5: * Add branch prediction to if conditions v4: * Retain the non enqueued crypto ops in circular buffer to process later and stop the dequeue from eventd

[PATCH] devargs: Fix rte_devargs_parse uninitialized calls

2022-02-10 Thread Gaetan Rivet
The function rte_devargs_parse() previously was safe to call with non-initialized devargs structure as parameter. When adding the support for the global device syntax, this assumption was broken. Restore it by forcing memset as part of the call itself. Bugzilla Id: 933 Fixes: b344eb5d941a ("devar

Re: [PATCH v3 2/2] net/ice: support drop any and steer all to queue

2022-02-10 Thread Ferruh Yigit
On 1/26/2022 3:57 PM, Yuying Zhang wrote: This patch supports drop any and steer all to queue in switch filter. Support new rte_flow pattern any to handle all packets. The usage is listed below. 1. drop any: flow create 0 ingress pattern any / end actions drop / end All packets received in port

Re: [PATCH v5] eal: fix unaligned loads/stores in rte_memcpy_generic

2022-02-10 Thread Luc Pelletier
Hi Konstantin, > > Thanks for your input Konstantin. Much appreciated. Just to make sure > > I understand, can you please confirm that we do not want to fix the > > fact that unaligned access in C is undefined behaviour? > > Yes, I don't think it is a real problem in that particular case. Perfect

RE: [EXT] [PATCH v2 4/4] crypto: reorganize endianness comments, add crypto uint

2022-02-10 Thread Zhang, Roy Fan
Hi Akhil, I assume everything in asym crypto is under experimental tag at the moment right? The goal is to have them updated and fixed before DPDK 22.11 so the experimental tag can be removed. Regards, Fan > -Original Message- > From: Akhil Goyal > Sent: Thursday, February 10, 2022 10

RE: [PATCH v6 1/5] doc: replace asym crypto code with literal includes

2022-02-10 Thread Zhang, Roy Fan
> -Original Message- > From: Power, Ciara > Sent: Thursday, February 10, 2022 3:54 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; gak...@marvell.com; > ano...@marvell.com; m...@ashroe.eu; Power, Ciara > ; Doherty, Declan > Subject: [PATCH v6 1/5] doc: replace asym crypto code with literal i

Re: [PATCH v2] config/arm: add armv7 native config

2022-02-10 Thread Thomas Monjalon
25/01/2022 11:08, Juraj Linkeš: > Armv7 native build fails with this error: > ../config/meson.build:364:1: ERROR: Problem encountered: > Number of CPU cores not specified. > > This is because RTE_MAX_LCORE is not set. We also need to set > RTE_MAX_NUMA_NODES in armv7 native builds. > > Fixes: 8ef

RE: [PATCH v4 00/10] ethdev: datapath-focused flow rules management

2022-02-10 Thread Suanming Mou
Hi, I wish the PMD part is not too late. You can find the series here: https://patches.dpdk.org/project/dpdk/cover/20220210162926.20436-1-suanmi...@nvidia.com/ Thanks, Suanming Mou > -Original Message- > From: Asaf Penso > Sent: Friday, February 11, 2022 12:12 AM > To: Ferruh Yigit ; A

[PATCH 11/13] net/mlx5: add mark action

2022-02-10 Thread Suanming Mou
The mark action is covered by tag action internally. While it is added the HW will add a tag to the packet. The mark value can be set as fixed or dynamic as the action mask indicates. Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5.h | 3 ++ drivers/net/mlx5/mlx5_flow.h| 1 +

[PATCH 13/13] net/mlx5: add header reformat action

2022-02-10 Thread Suanming Mou
HW steering header reformat action can work under bulk mode. In this case, when create the table, bulk size of header reformat actions will be allocated in low level. Afterwards, when create flow, just simply specify the action index in the bulk and the encapsulation data to the action will be enou

Re: [PATCH] ethdev: introduce generic dummy packet burst function

2022-02-10 Thread Stephen Hemminger
On Thu, 10 Feb 2022 13:58:43 + Ferruh Yigit wrote: > On 2/8/2022 7:44 PM, Ferruh Yigit wrote: > > diff --git a/drivers/net/mlx5/linux/mlx5_os.c > > b/drivers/net/mlx5/linux/mlx5_os.c > > index aecdc5a68abb..bbe05bb837e0 100644 > > --- a/drivers/net/mlx5/linux/mlx5_os.c > > +++ b/drivers/net/

[PATCH 12/13] net/mlx5: add indirect action

2022-02-10 Thread Suanming Mou
HW steering can support indirect action as well. With indirect action, the flow can be created with more flexible shared RSS action selection. This will can save the action template with different RSS actions. This commit adds the flow queue operation callback for: rte_flow_q_action_handle_create(

[PATCH 10/13] net/mlx5: add queue and RSS action

2022-02-10 Thread Suanming Mou
This commit adds the queue and RSS action. Similar to the jump action, dynamic ones will be added to the action construct list. Due to the queue and RSS action in template should not be destroyed during port restart, the actions are created with standalone indirect table as indirect action does. W

[PATCH 09/13] net/mlx5: add flow jump action

2022-02-10 Thread Suanming Mou
Jump action connects different level of flow tables as a complete data flow. A new action construct data struct is also added in this commit to help handle the dynamic actions. Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_flow.h| 25 ++- dri

[PATCH 08/13] net/mlx5: add flow flush function

2022-02-10 Thread Suanming Mou
In case port restarting, all created flows should be flushed. This commit adds the flow flush helper function. Signed-off-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow.c| 8 +++ drivers/net/mlx5/mlx5_flow_hw.c | 117 2 files changed, 125 insertions(+) di

[PATCH 07/13] net/mlx5: add basic flow queue operation

2022-02-10 Thread Suanming Mou
The HW steering uses queue-based flow rules management mechanism. The matcher and part of the actions have been prepared during flow table creation. Some left actions will be constructed during flow creation if needed. A flow postpone attribute bit decribles if flow creation/destruction should be

[PATCH 05/13] net/mlx5: add action template management

2022-02-10 Thread Suanming Mou
The action template holds a list of action types that will be used together on the same rule. The template's actions instances will be created only when the template bind to the dedicated group. And the created actions will be saved to each individual group in order for best performance. The action

[PATCH 04/13] net/mlx5: add pattern template management

2022-02-10 Thread Suanming Mou
The pattern template defines flows that have the same matching fields but with different matching values. For example, matching on 5 tuple TCP flow, the template will be (eth(null) + IPv4(source + dest) + TCP(s_port + d_port) while the values for each rule will be different. Due to the pattern tem

[PATCH 06/13] net/mlx5: add table management

2022-02-10 Thread Suanming Mou
Flow table is a group of flows with the same matching criteria and the same actions defined for them. The table defines rules that have the same matching fields but with different matching values. For example, matching on 5 tuple, the table will be (IPv4 source + IPv4 dest + s_port + d_port + next_

[PATCH 01/13] net/mlx5: introduce hardware steering operation

2022-02-10 Thread Suanming Mou
A new hardware based steering operation is going to be introduced for high insertion rate. This commit adds the basic driver operation. Signed-off-by: Suanming Mou --- drivers/net/mlx5/linux/mlx5_flow_os.h | 1 + drivers/net/mlx5/meson.build | 1 + drivers/net/mlx5/mlx5_flow.c

[PATCH 02/13] net/mlx5: introduce hardware steering enable routine

2022-02-10 Thread Suanming Mou
As the new hardware steering operation will be implemented under the new rte_flow_q APIs. This is not compatible with the existing rte_flow PMD's Direct Rules flow operation routine. This commit introduces an extra dv_flow_en = 2 to specify the new flow operation initialize routine. Signed-off-by

[PATCH 03/13] net/mlx5: add port flow configuration

2022-02-10 Thread Suanming Mou
The hardware steering is backend to support rte_flow_q API in mlx5 PMD. The port configuration function creates the queues and needed flow management resources. The PMD layer configuration function allocates the queues' context and per-queue job descriptor. The job descriptor size is equal to the

[PATCH 00/13] net/mlx5: add hardware steering

2022-02-10 Thread Suanming Mou
As the new queue-based flow rules management mechanism is introduced to the rte_flow. A new steering mode PMD code is also developed to take advantage of the new API. The HW steering prepares the required flow resources in advanced from the hints when create template table. That means the matcher

RE: [PATCH v4 00/10] ethdev: datapath-focused flow rules management

2022-02-10 Thread Asaf Penso
Thanks, Ferruh. The pmd part is being updated according to the previous API comments. @Suanming Mou is working on it and will send it once ready, before the weekend. Regards, Asaf Penso >-Original Message- >From: Ferruh Yigit >Sent: Thursday, February 10, 2022 6:00 PM >To: Alexander Kozy

  1   2   3   >