[PATCH] doc: update Mellanox drivers download link in mlx5 guide

2022-02-25 Thread Zhiheng Chen
The original download link is invalid. Signed-off-by: Zhiheng Chen --- doc/guides/nics/mlx5.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index c3cc0c0f41..625d8a2382 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc

RE: [PATCH] net/mlx5: support matching optional fields of GRE

2022-02-25 Thread Sean Zhang (Networking SW)
Thanks Thomas. > -Original Message- > From: Thomas Monjalon > Sent: Friday, February 25, 2022 11:32 PM > To: Sean Zhang (Networking SW) > Cc: Matan Azrad ; Slava Ovsiienko > ; dev@dpdk.org; Asaf Penso > Subject: Re: [PATCH] net/mlx5: support matching optional fields of GRE > > External

[PATCH v4 3/3] net/ixgbe: Fix SFP detection and linking on hotplug

2022-02-25 Thread Jeff Daly
Currently the ixgbe driver does not ID any SFP except for the first one plugged in. This can lead to no-link, or incorrect speed conditions. For example: * If link is initially established with a 1G SFP, and later a 1G/10G multispeed part is later installed, then the MAC link setup functions are

Re: [EXT] [PATCH] crypto: fix misspelled key in qt format

2022-02-25 Thread Ray Kinsella
Thomas Monjalon writes: > 18/02/2022 07:11, Kusztal, ArkadiuszX: >> From: Akhil Goyal >> > Fix ABI warning. >> > Add libabigail.abiignore rule. >> >> I think what is worth noticing is a fact that after "random 'k' patch" >> addition of >> [suppress_type] >> name = rte_crypto_asym_op

Re: [PATCH v3 1/6] common/mlx5: consider local functions as internal

2022-02-25 Thread Ferruh Yigit
On 2/25/2022 6:38 PM, Thomas Monjalon wrote: 25/02/2022 19:01, Ferruh Yigit: On 2/24/2022 11:25 PM, Michael Baum wrote: The functions which are not explicitly marked as internal were exported because the local catch-all rule was missing in the version script. After adding the missing rule, all

Re: [PATCH] doc: add GRE option flow item to feature list

2022-02-25 Thread Ferruh Yigit
On 2/25/2022 6:41 PM, Thomas Monjalon wrote: 25/02/2022 19:27, Ferruh Yigit: 'gre_option' flow item was missing in the feature list, adding it. Fixes: f61490bdf218 ("ethdev: support GRE optional fields") Signed-off-by: Ferruh Yigit Acked-by: Thomas Monjalon Applied to dpdk-next-net/main

Re: [PATCH] doc: add GRE option flow item to feature list

2022-02-25 Thread Thomas Monjalon
25/02/2022 19:27, Ferruh Yigit: > 'gre_option' flow item was missing in the feature list, adding it. > > Fixes: f61490bdf218 ("ethdev: support GRE optional fields") > > Signed-off-by: Ferruh Yigit Acked-by: Thomas Monjalon

Re: [PATCH v3 1/6] common/mlx5: consider local functions as internal

2022-02-25 Thread Thomas Monjalon
25/02/2022 19:01, Ferruh Yigit: > On 2/24/2022 11:25 PM, Michael Baum wrote: > > The functions which are not explicitly marked as internal > > were exported because the local catch-all rule was missing in the > > version script. > > After adding the missing rule, all local functions are hidden. > >

Re: [v4] net/mlx5: support matching optional fields of GRE

2022-02-25 Thread Thomas Monjalon
25/02/2022 18:55, Ferruh Yigit: > On 2/25/2022 1:14 AM, Sean Zhang wrote: > > This patch adds matching on the optional fields (checksum/key/sequence) > > of GRE header. The matching on checksum and sequence fields requests > > support from rdma-core with the capability of misc5 and tunnel_header 0-

[PATCH] doc: add GRE option flow item to feature list

2022-02-25 Thread Ferruh Yigit
'gre_option' flow item was missing in the feature list, adding it. Fixes: f61490bdf218 ("ethdev: support GRE optional fields") Signed-off-by: Ferruh Yigit --- Cc: xiazh...@nvidia.com --- doc/guides/nics/features/default.ini | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/nics/fea

[PATCH] doc/guides/cryptodev/features: add missing newline at eof

2022-02-25 Thread Stephen Hemminger
Even these are ini files, they should still have new line at end of file. Signed-off-by: Stephen Hemminger --- doc/guides/cryptodevs/features/aesni_mb.ini | 2 +- doc/guides/cryptodevs/features/armv8.ini| 2 +- doc/guides/cryptodevs/features/bcmfs.ini| 2 +- doc/guides/cryptodevs/feature

Re: [PATCH v3 1/6] common/mlx5: consider local functions as internal

2022-02-25 Thread Ferruh Yigit
On 2/24/2022 11:25 PM, Michael Baum wrote: The functions which are not explicitly marked as internal were exported because the local catch-all rule was missing in the version script. After adding the missing rule, all local functions are hidden. The function mlx5_get_device_guid is used in anothe

Re: [EXT] [PATCH] crypto: fix misspelled key in qt format

2022-02-25 Thread Thomas Monjalon
18/02/2022 07:11, Kusztal, ArkadiuszX: > From: Akhil Goyal > > Fix ABI warning. > > Add libabigail.abiignore rule. > > I think what is worth noticing is a fact that after "random 'k' patch" > addition of > [suppress_type] > name = rte_crypto_asym_op > this problem does not show up. > >

Re: [v4] net/mlx5: support matching optional fields of GRE

2022-02-25 Thread Ferruh Yigit
On 2/25/2022 1:14 AM, Sean Zhang wrote: This patch adds matching on the optional fields (checksum/key/sequence) of GRE header. The matching on checksum and sequence fields requests support from rdma-core with the capability of misc5 and tunnel_header 0-3. For patterns without checksum and sequen

[PATCH 2/2] examples: add missing newline at eof

2022-02-25 Thread Stephen Hemminger
The text file did not end with newline. Signed-off-by: Stephen Hemminger --- examples/flow_classify/ipv4_rules_file.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/flow_classify/ipv4_rules_file.txt b/examples/flow_classify/ipv4_rules_file.txt index dfa0631fcc09.

[PATCH 1/2] remove extra blank line at eof

2022-02-25 Thread Stephen Hemminger
These source files all had unnecessary blank line at end of file. Signed-off-by: Stephen Hemminger --- drivers/common/iavf/iavf_adminq.c | 1 - drivers/common/mlx5/mlx5_common_log.h | 1 - drivers/net/cxgbe/smt.h | 1 - drivers/net/dpaa2/mc/dpni.c | 1 - drivers/net/h

Re: [PATCH v3 0/6] mlx5: external RxQ support

2022-02-25 Thread Thomas Monjalon
> Michael Baum (6): > common/mlx5: consider local functions as internal > common/mlx5: glue device and PD importation > common/mlx5: add remote PD and CTX support > net/mlx5: optimize RxQ/TxQ control structure > net/mlx5: add external RxQ mapping API > net/mlx5: support queue/RSS action

Re: [dpdk-dev v6] crypto/openssl: openssl 3.0 support on sym crypto routine

2022-02-25 Thread Stephen Hemminger
On Fri, 25 Feb 2022 23:13:56 +0800 Kai Ji wrote: > +cflags += ['-DOPENSSL_API_COMPAT=0x1010L'] > \ No newline at end of file All files in DPDK should have newline at end of file. How did this sneak in?

Re: [PATCH v3] app/pdump: check lcore is not the maximum core

2022-02-25 Thread Stephen Hemminger
On Tue, 22 Feb 2022 11:02:24 + Reshma Pattan wrote: > Check lcore id value is not the maximum core supported. > Using lcore id without this check might cause > out of bound access inside the rte_eal_wait_lcore. > > Coverity issue: 375841 > Fixes: b2854d5317e8 ("app/pdump: support multi-core

Re: [PATCH] app/testpmd: fix build without drivers

2022-02-25 Thread Ferruh Yigit
On 2/25/2022 4:53 PM, Ajit Khaparde wrote: On Fri, Feb 25, 2022 at 7:50 AM Bruce Richardson wrote: On Fri, Feb 25, 2022 at 04:26:53PM +0100, Thomas Monjalon wrote: When ixgbe and bnxt are disabled, compilation was failing: app/test-pmd/cmdline.c:9396:11: error: variable 'vf_rxmode' se

Re: [PATCH] app/testpmd: fix build without drivers

2022-02-25 Thread Ajit Khaparde
On Fri, Feb 25, 2022 at 7:50 AM Bruce Richardson wrote: > > On Fri, Feb 25, 2022 at 04:26:53PM +0100, Thomas Monjalon wrote: > > When ixgbe and bnxt are disabled, compilation was failing: > > > > app/test-pmd/cmdline.c:9396:11: error: > > variable 'vf_rxmode' set but not used > > > > Fixes:

Re: [PATCH] app/testpmd: fix build without drivers

2022-02-25 Thread Thomas Monjalon
25/02/2022 16:50, Bruce Richardson: > On Fri, Feb 25, 2022 at 04:26:53PM +0100, Thomas Monjalon wrote: > > When ixgbe and bnxt are disabled, compilation was failing: > > > > app/test-pmd/cmdline.c:9396:11: error: > > variable 'vf_rxmode' set but not used > > > > Fixes: 4cfe399f6550 ("net/bnxt

[PATCH v7] eal: fix rte_memcpy strict aliasing/alignment bugs

2022-02-25 Thread Luc Pelletier
Calls to rte_memcpy for 1 < n < 16 could result in unaligned loads/stores, which is undefined behaviour according to the C standard, and strict aliasing violations. The code was changed to use a packed structure that allows aliasing (using the __may_alias__ attribute) to perform the load/store ope

Re: [PATCH] eal: fix unaligned loads/stores in rte_memcpy_aligned

2022-02-25 Thread Luc Pelletier
Hi, This patch can be abandoned. As indicated in another thread (http://mails.dpdk.org/archives/dev/2022-February/234889.html), there is no requirement/desire to make this change. Thanks. Le sam. 15 janv. 2022 à 14:39, Luc Pelletier a écrit : > > Calls to rte_memcpy_aligned could result in unal

[PATCH v6] eal: fix rte_memcpy strict aliasing/alignment bugs

2022-02-25 Thread Luc Pelletier
Calls to rte_memcpy for 1 < n < 16 could result in unaligned loads/stores, which is undefined behaviour according to the C standard, and strict aliasing violations. The code was changed to use a packed structure that allows aliasing (using the __may_alias__ attribute) to perform the load/store ope

Re: [PATCH] app/testpmd: fix build without drivers

2022-02-25 Thread Bruce Richardson
On Fri, Feb 25, 2022 at 04:26:53PM +0100, Thomas Monjalon wrote: > When ixgbe and bnxt are disabled, compilation was failing: > > app/test-pmd/cmdline.c:9396:11: error: > variable 'vf_rxmode' set but not used > > Fixes: 4cfe399f6550 ("net/bnxt: support to set VF rxmode") > Cc: sta...@dpdk.o

Re: [PATCH] app/testpmd: fix raw encap of GENEVE option

2022-02-25 Thread Ferruh Yigit
On 2/24/2022 7:02 AM, Bing Zhao wrote: The structure "rte_flow_item_geneve_opt" is not a protocol header of geneve tunnel option from rfc8926. The field "data" is a pointer which points to the actual variable-length option data. So the structure is not packed. There is 4 bytes hole before the po

Re: [v4] net/mlx5: support matching optional fields of GRE

2022-02-25 Thread Thomas Monjalon
25/02/2022 02:14, Sean Zhang: > This patch adds matching on the optional fields (checksum/key/sequence) > of GRE header. The matching on checksum and sequence fields requests > support from rdma-core with the capability of misc5 and tunnel_header 0-3. > > For patterns without checksum and sequence

Re: [PATCH] net/mlx5: support matching optional fields of GRE

2022-02-25 Thread Thomas Monjalon
21/02/2022 04:00, Sean Zhang (Networking SW): > Hi Thomas, > > > -Original Message- > > From: Thomas Monjalon > > Sent: Thursday, February 17, 2022 4:34 PM > > To: Matan Azrad ; Slava Ovsiienko > > ; Sean Zhang (Networking SW) > > > > Cc: dev@dpdk.org > > Subject: Re: [PATCH] net/mlx5: s

[PATCH] app/testpmd: fix build without drivers

2022-02-25 Thread Thomas Monjalon
When ixgbe and bnxt are disabled, compilation was failing: app/test-pmd/cmdline.c:9396:11: error: variable 'vf_rxmode' set but not used Fixes: 4cfe399f6550 ("net/bnxt: support to set VF rxmode") Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon --- app/test-pmd/cmdline.c | 1 + 1 file

[dpdk-dev v6] crypto/openssl: openssl 3.0 support on sym crypto routine

2022-02-25 Thread Kai Ji
This patch setup OPENSSL_API_COMPAT to suppress deprecated compile warning messages in ccp, openssl and qat PMDs, also update the symmetric EVP routine in crypto openssl pmd to adopt openssl 3.0 library. Signed-off-by: Kai Ji Acked-by: Fan Zhang --- drivers/common/qat/meson.build

[PATCH] raw/cnxk_gpio: stop device once tests are complete

2022-02-25 Thread Tomasz Duszynski
Started device should eventually be stopped. Fixes: 0e6557b448fa ("raw/cnxk_gpio: add self test") Signed-off-by: Tomasz Duszynski Reviewed-by: Jerin Jacob Kollanukkaran --- drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/raw/cnxk_gpio/cnxk

Re: [PATCH v3] net/i40e: fix unintentional integer overflow

2022-02-25 Thread Ferruh Yigit
On 2/25/2022 2:39 AM, Steve Yang wrote: Cast 1 to type uint64_t to avoid overflow. CID 375812 (#1 of 1): Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) overflow_before_widen: Potentially overflowing expression 1 << 2 * i + 1 with type int (32 bits, signed) is evaluated using 32-bit arith

RE: [PATCH v3] ip_frag: add IPv4 options fragment and test data

2022-02-25 Thread Ananyev, Konstantin
Ho Huichao, > According to RFC791,the options may appear or not in datagrams. > They must be implemented by all IP modules (host and gateways). > What is optional is their transmission in any particular datagram, > not their implementation.So we have to deal with it during the > fragmenting pro

Re: [PATCH v3] net/ice/base: support E824S and E825 devices

2022-02-25 Thread Ferruh Yigit
On 2/25/2022 2:00 AM, Robin Zhang wrote: Add support for E824S and E825 family devices. This will be documented later in release notes due to we don't have mature product now. Signed-off-by: Robin Zhang Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.

RE: [EXT] [dpdk-dev v5] crypto/openssl: openssl 3.0 support on sym crypto routine

2022-02-25 Thread Zhang, Roy Fan
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Friday, February 25, 2022 10:40 AM > To: Ji, Kai ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [dpdk-dev v5] crypto/openssl: openssl 3.0 support on sym > crypto routine > > Hi Kai, > > > > The warning messages are dep

RE: [PATCH v5 0/2] Add config file support for l3fwd

2022-02-25 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Friday, 25 February 2022 11.40 > > On Fri, Feb 25, 2022 at 10:36:29AM +, Ananyev, Konstantin wrote: > > > > > On Thu, Feb 24, 2022 at 02:46:24PM +0100, Thomas Monjalon wrote: > > > > 24/02/2022 12:06, Ananyev, Konstantin: > >

RE: [PATCH v5 0/2] Add config file support for l3fwd

2022-02-25 Thread Ananyev, Konstantin
> > > > > > > > > > > > > >> Or have a generic library for reading LPM entries. > > > > > > > > > > > > > >> L3fwd is supposed > > > > > > > > > > > > > >> to be as small as possible (it no longer is), and > > > > > > > > > > > > > >> the real work should > > > > > > > > > > > > > >> be done b

Re: [PATCH v1] power: add wakeup log

2022-02-25 Thread Burakov, Anatoly
On 24-Feb-22 2:38 AM, Li, Miao wrote: Hi, -Original Message- From: Hunt, David Sent: Wednesday, February 23, 2022 12:32 AM To: Li, Miao ; dev@dpdk.org Cc: Wang, Yinan ; step...@networkplumber.org Subject: Re: [PATCH v1] power: add wakeup log On 22/2/2022 1:52 PM, Miao Li wrote: This

RE: [EXT] [dpdk-dev v5] crypto/openssl: openssl 3.0 support on sym crypto routine

2022-02-25 Thread Ji, Kai
HI Akhil, > > When DPDK is compiled with openssl 3.0. I am seeing these errors in > compilation. > So, compilation is broken and we cannot take this patch as is. > We have few options, > - fix all of these errors, > - add exception in meson.build for ignoring these errors. > - disable/skip compi

Re: [PATCH v5 0/2] Add config file support for l3fwd

2022-02-25 Thread Bruce Richardson
On Fri, Feb 25, 2022 at 10:36:29AM +, Ananyev, Konstantin wrote: > > > On Thu, Feb 24, 2022 at 02:46:24PM +0100, Thomas Monjalon wrote: > > > 24/02/2022 12:06, Ananyev, Konstantin: > > > > > > > > > > > > >> Or have a generic library for reading LPM entries. > > > > > > > > > > > > >> L3fwd

RE: [EXT] [dpdk-dev v5] crypto/openssl: openssl 3.0 support on sym crypto routine

2022-02-25 Thread Akhil Goyal
Hi Kai, > > The warning messages are deprecated APIs warnings from openssl , not > compiler warnings from gcc, the integrity of DPDK remain the same. > Alongside openssl pmd, the ccp and qat pmd also raise the same type of > warnings once openssl 3.0 installed. > > In the current intel roadmap,

RE: [PATCH v5 0/2] Add config file support for l3fwd

2022-02-25 Thread Ananyev, Konstantin
> On Thu, Feb 24, 2022 at 02:46:24PM +0100, Thomas Monjalon wrote: > > 24/02/2022 12:06, Ananyev, Konstantin: > > > > > > > > > > > >> Or have a generic library for reading LPM entries. > > > > > > > > > > > >> L3fwd is supposed > > > > > > > > > > > >> to be as small as possible (it no longer

Re: [dpdk-dev] [PATCH v2] common/cnxk: support CNF95xx B0 variant

2022-02-25 Thread Jerin Jacob
On Fri, Feb 25, 2022 at 4:04 PM Tomasz Duszynski wrote: > > Add CNF95xx B0 variant to the list of supported models. > > Signed-off-by: Tomasz Duszynski > Reviewed-by: Jerin Jacob > --- > v2: > - Update release notes for new device support (Ferruh) Applied to dpdk-next-net-mrvl/for-next-net. Th

[dpdk-dev] [PATCH v2] common/cnxk: support CNF95xx B0 variant

2022-02-25 Thread Tomasz Duszynski
Add CNF95xx B0 variant to the list of supported models. Signed-off-by: Tomasz Duszynski Reviewed-by: Jerin Jacob --- v2: - Update release notes for new device support (Ferruh) doc/guides/rel_notes/release_22_03.rst | 1 + drivers/common/cnxk/roc_model.c| 1 + drivers/common/cnxk/roc_mo

Re: [dpdk-dev] [PATCH] net/ice: fix wrong data path selection in secondary process

2022-02-25 Thread Navin Srinivas
Thanks, I noticed it in the release and took the LTS version. I do not see the previously noticed VF crash now on 20.11.4 Navin On Tue, Feb 22, 2022 at 2:51 PM Kevin Traynor wrote: > On 22/02/2022 04:30, Zhang, Qi Z wrote: > > Hi Srinivas: > > > > This is the fix for PF driver only, for VF we h

Re: [dpdk-dev] [PATCH v5] net/ice: fix function pointer in multi-process

2022-02-25 Thread Navin Srinivas
Hi Qi, Thank you for your reply and confirmation. Regards, Navin Srinivas On Fri, Feb 25, 2022 at 7:04 AM Zhang, Qi Z wrote: > We need a separate fix for AVF which is ongoing. > > And DPDK 20.11.4 LTS by default will only backport all the fix that during > DPDK 21.11 dev cycle, so you may need

Re: [PATCH v2 5/5] doc: update doorbell mapping parameter name in mlx5 guide

2022-02-25 Thread Ferruh Yigit
On 2/25/2022 12:01 AM, Michael Baum wrote: On 2/23/2022 11:48 PM, Ferruh Yigit wrote: On 2/23/2022 1:48 PM, Michael Baum wrote: The "tx_db_nc" devarg forces doorbell register mapping to non-cached region eliminating the extra write memory barrier. This argument was used in creating the UAR for

RE: [EXT] [dpdk-dev v5] crypto/openssl: openssl 3.0 support on sym crypto routine

2022-02-25 Thread Ji, Kai
The warning messages are deprecated APIs warnings from openssl , not compiler warnings from gcc, the integrity of DPDK remain the same. Alongside openssl pmd, the ccp and qat pmd also raise the same type of warnings once openssl 3.0 installed. In the current intel roadmap, we will try to suppo

Re: [PATCH] common/cnxk: support B0 variant

2022-02-25 Thread Ferruh Yigit
On 2/24/2022 8:35 PM, Jerin Jacob wrote: On Thu, Feb 24, 2022 at 4:13 PM Tomasz Duszynski wrote: Add B0 variant to the list of supported models. Signed-off-by: Tomasz Duszynski Reviewed-by: Jerin Jacob Kollanukkaran Updated the git commit as follows and applied to dpdk-next-net-mrvl/for-n

RE: [PATCH v3] app/pdump: check lcore is not the maximum core

2022-02-25 Thread Pattan, Reshma
> -Original Message- > From: Pattan, Reshma Hi Stephen, Can you take a look and ack the patch. Thanks, Reshma

[PATCH v3 2/2] efd: fix uninitialized structure

2022-02-25 Thread Pablo de Lara
Coverity flags that both elements of efd_online_group_entry are used uninitialized. This is OK because this structure is initially used for starting values, so any value is OK. Coverity ID: 375868 Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") Cc: pablo.de.lara.gua...@intel.com

[PATCH v3 1/2] test/efd: fix size of constant

2022-02-25 Thread Pablo de Lara
Constant value 1 has a size of 32 bits, and shifting it more than 32 bits to the left overflows. 1ULL is needed to be able to get a 64-bit value. Coverity ID: 375846 Fixes: 8751a7e9832b ("efd: allow more CPU sockets in table creation") Cc: pablo.de.lara.gua...@intel.com Cc: sta...@dpdk.org Signed

Re: [PATCH 1/1] net/cnxk: make inline inbound device usage default

2022-02-25 Thread Jerin Jacob
On Fri, Feb 25, 2022 at 12:24 PM Vamsi Attunuru wrote: > > Currently inline inbound device usage is not default for eventdev, > patch renames force_inl_dev dev arg to no_inl_dev and enables inline > inbound device by default. > > Signed-off-by: Vamsi Attunuru Acked-by: Jerin Jacob Applied to dp