[v1] net/mlx5: support represented port item

2022-04-01 Thread Sean Zhang
Add support for represented_port item in pattern. And if the spec and mask both are NULL, translate function will not add source vport to matcher. For example, testpmd starts with PF, VF-rep0 and VF-rep1, below command will redirect packets from VF0 and VF1 to wire: testpmd> flow create 0 ingress

Re: [RFC] Telemetry enhancements and Windows support

2022-04-01 Thread Dmitry Kozlyuk
2022-04-02 01:59 (UTC+0300), Dmitry Kozlyuk: > Telemetry today (talking only about v2): > > * Telemetry library starts a thread to listen for connections. > It is affinitized to the main lcore. Should be: "to the control thread CPU set". > A thread is spawned to serve each client connection.

Re: [PATCH v2] eal: add seqlock

2022-04-01 Thread Stephen Hemminger
On Thu, 31 Mar 2022 13:51:32 + Mattias Rönnblom wrote: > > > > Regarding naming, you should also consider renaming > > rte_seqlock_write_begin/end() to rte_seqlock_write_lock/unlock(), > > following the naming convention of the other locks. This could > > prepare for future extensions, such

Re: [PATCH v2] eal: add seqlock

2022-04-01 Thread Stephen Hemminger
On Thu, 31 Mar 2022 16:53:00 +0200 Ola Liljedahl wrote: > From: Ola Liljedahl > To: Mattias Rönnblom , "dev@dpdk.org" > Cc: Thomas Monjalon , David > Marchand , Onar Olsen > , "honnappa.nagaraha...@arm.com" > , "n...@arm.com" , > "konstantin.anan...@intel.com" , > "m...@smartsharesystems.c

Re: [PATCH v2] eal: add seqlock

2022-04-01 Thread Stephen Hemminger
On Wed, 30 Mar 2022 16:26:02 +0200 Mattias Rönnblom wrote: > + __atomic_store_n(&seqlock->sn, sn, __ATOMIC_RELAXED); > + > + /* __ATOMIC_RELEASE to prevent stores after (in program > order) > + * from happening before the sn store. > + */ > + rte_atomic_thread_fence(__ATOMIC

RE: [PATCH v3] eal: add seqlock

2022-04-01 Thread Honnappa Nagarahalli
Hi Mattias, Few comments inline. > -Original Message- > From: Mattias Rönnblom > Sent: Friday, April 1, 2022 10:08 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; David Marchand ; > onar.ol...@ericsson.com; Honnappa Nagarahalli > ; nd ; > konstantin.anan...@intel.com; m...@smarts

[RFC] Telemetry enhancements and Windows support

2022-04-01 Thread Dmitry Kozlyuk
Vipin from AMD expressed demand for telemetry support on Windows in order to collect port statistics. Implementing a PoC, he stumbled several issues. Together we have designed a solution that eliminates these issues. It affects telemetry operation for all platforms, at least code-wise, We would lik

Re: [PATCH 3/3] doc: rewrite shell scripts in Python

2022-04-01 Thread Dmitry Kozlyuk
2022-04-01 17:31 (UTC+0100), Bruce Richardson: > On Fri, Apr 01, 2022 at 12:28:30AM +0300, Dmitry Kozlyuk wrote: [...] > > +if is_source or name == 'meson.meson.build': > > duplicate "meson." Thanks! > > +path = os.path.join(root, name) > > +if is_so

[PATCH v2] ci: add Fedora 35 container in GHA

2022-04-01 Thread David Marchand
Build DPDK with Fedora 35 containers. GHA container support does not allow caching images and docker hub seems to limit image pulls. On the other hand, the Fedora project hub does not seem to limit them, so prefer this hub. Nevertheless, let's try to be good citizens and cache (once a day) a prepa

Re: [PATCH 3/3] doc: rewrite shell scripts in Python

2022-04-01 Thread Bruce Richardson
On Fri, Apr 01, 2022 at 12:28:30AM +0300, Dmitry Kozlyuk wrote: > Shell used in documentation generation could not run on Windows. > Rewrite scripts in Python. > New scripts use proper path separators and handle paths with spaces. > > Signed-off-by: Dmitry Kozlyuk > --- Generally looks ok to me,

Re: [PATCH v5] dmadev: add telemetry support

2022-04-01 Thread Kevin Laatz
On 01/04/2022 16:01, Sean Morrissey wrote: Telemetry commands are now registered through the dmadev library for the gathering of DSA stats. The corresponding callback functions for listing dmadevs and providing info and stats for a specific dmadev are implemented in the dmadev library. An exampl

i40e QinQ Offload w/ NVM 8.40 not working

2022-04-01 Thread Ben Magistro
Hello, We recently needed to apply a firmware upgrade for some XXV710s to resolve a FEC issue (I'd have to find the details in email) but applied this same firmware to other nics (XL710s) to maintain a consistent baseline. In testing we have seen the NVM 8.40 resolve the FEC issue but it introduc

[PATCH v3] eal: add seqlock

2022-04-01 Thread Mattias Rönnblom
A sequence lock (seqlock) is synchronization primitive which allows for data-race free, low-overhead, high-frequency reads, especially for data structures shared across many cores and which are updated with relatively infrequently. A seqlock permits multiple parallel readers. The variant of seqloc

[PATCH v5] dmadev: add telemetry support

2022-04-01 Thread Sean Morrissey
Telemetry commands are now registered through the dmadev library for the gathering of DSA stats. The corresponding callback functions for listing dmadevs and providing info and stats for a specific dmadev are implemented in the dmadev library. An example usage can be seen below: Connecting to /va

[PATCH v4] dmadev: add telemetry support

2022-04-01 Thread Sean Morrissey
Telemetry commands are now registered through the dmadev library for the gathering of DSA stats. The corresponding callback functions for listing dmadevs and providing info and stats for a specific dmadev are implemented in the dmadev library. An example usage can be seen below: Connecting to /va

Re: 19.11.12 patches review and test

2022-04-01 Thread Kalesh Anakkur Purayil
Hi Christian, Testing with dpdk v19.11.12-rc1 from Broadcom looks good. Tested with the fix for Bug 977 on top of 19.11.12-rc1. - Basic functionality: Send and receive multiple types of traffic. - Changing/checking link status through testpmd. - RSS tests with tunnel and non-tunnel packets - T

[PATCH 0/3] add eal functions for thread affinity

2022-04-01 Thread Tyler Retzlaff
this series provides basic dependencies for additional eal thread api additions. series includes basic error handling, initial get/set thread affinity functions and minimal unit test. Tyler Retzlaff (3): eal/windows: translate Windows errors to errno-style errors eal: implement functions for g

[PATCH 3/3] test/threads: add unit test for thread API

2022-04-01 Thread Tyler Retzlaff
Establish unit test for testing thread api. Initial unit tests for rte_thread_{get,set}_affinity_by_id(). Signed-off-by: Narcisa Vasile Signed-off-by: Tyler Retzlaff --- app/test/meson.build| 2 ++ app/test/test_threads.c | 83 + 2 files chan

[PATCH 2/3] eal: implement functions for get/set thread affinity

2022-04-01 Thread Tyler Retzlaff
Implement functions for getting/setting thread affinity. Threads can be pinned to specific cores by setting their affinity attribute. Signed-off-by: Narcisa Vasile Signed-off-by: Tyler Retzlaff --- lib/eal/include/rte_thread.h | 45 ++ lib/eal/unix/rte_thread.c| 16 l

[PATCH 1/3] eal/windows: translate Windows errors to errno-style errors

2022-04-01 Thread Tyler Retzlaff
Add function to translate Windows error codes to errno-style error codes. The possible return values are chosen so that we have as much semantical compatibility between platforms as possible. Signed-off-by: Narcisa Vasile Signed-off-by: Tyler Retzlaff --- lib/eal/windows/rte_thread.c | 48 +

Re: [PATCH v3] dmadev: add telemetry support

2022-04-01 Thread Bruce Richardson
On Fri, Apr 01, 2022 at 01:58:49PM +0100, Morrissey, Sean wrote: > > On 01/04/2022 12:00, Walsh, Conor wrote: > > > From: Bruce Richardson > > > Sent: Friday 1 April 2022 11:50 > > > To: Morrissey, Sean > > > Cc: Chengwen Feng ; Laatz, Kevin > > > ; dev@dpdk.org; Pai G, Sunil > > > > > > Subjec

Re: [PATCH v3] dmadev: add telemetry support

2022-04-01 Thread Morrissey, Sean
On 01/04/2022 12:00, Walsh, Conor wrote: From: Bruce Richardson Sent: Friday 1 April 2022 11:50 To: Morrissey, Sean Cc: Chengwen Feng ; Laatz, Kevin ; dev@dpdk.org; Pai G, Sunil Subject: Re: [PATCH v3] dmadev: add telemetry support On Fri, Apr 01, 2022 at 10:24:02AM +, Sean Morrissey wr

RE: [PATCH v3] dmadev: add telemetry support

2022-04-01 Thread Walsh, Conor
> From: Bruce Richardson > Sent: Friday 1 April 2022 11:50 > To: Morrissey, Sean > Cc: Chengwen Feng ; Laatz, Kevin > ; dev@dpdk.org; Pai G, Sunil > > Subject: Re: [PATCH v3] dmadev: add telemetry support > > On Fri, Apr 01, 2022 at 10:24:02AM +, Sean Morrissey wrote: > > Telemetry commands

Re: [PATCH v3] dma/idxd: add generic option for queue config

2022-04-01 Thread Bruce Richardson
On Fri, Apr 01, 2022 at 11:35:00AM +0100, Kevin Laatz wrote: > The device config script currently uses some defaults to configure > devices in a generic way. > > With the addition of this option, users have more control over how > queues are configured. > > Signed-off-by: Kevin Laatz > --- Revie

Re: [PATCH v3] dmadev: add telemetry support

2022-04-01 Thread Bruce Richardson
On Fri, Apr 01, 2022 at 10:24:02AM +, Sean Morrissey wrote: > Telemetry commands are now registered through the dmadev library > for the gathering of DSA stats. The corresponding callback > functions for listing dmadevs and providing info and stats for a > specific dmadev are implemented in the

[Bug 990] mlx5 pmd crashing when trying to free mbuf from secondary process when mprq is enabled

2022-04-01 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=990 Bug ID: 990 Summary: mlx5 pmd crashing when trying to free mbuf from secondary process when mprq is enabled Product: DPDK Version: 21.11 Hardware: x86 OS: Linux

[PATCH v3] dma/idxd: add generic option for queue config

2022-04-01 Thread Kevin Laatz
The device config script currently uses some defaults to configure devices in a generic way. With the addition of this option, users have more control over how queues are configured. Signed-off-by: Kevin Laatz --- drivers/dma/idxd/dpdk_idxd_cfg.py | 34 +-- 1 file ch

[PATCH v3] dmadev: add telemetry support

2022-04-01 Thread Sean Morrissey
Telemetry commands are now registered through the dmadev library for the gathering of DSA stats. The corresponding callback functions for listing dmadevs and providing info and stats for a specific dmadev are implemented in the dmadev library. An example usage can be seen below: Connecting to /va

21.11.1 patches review and test

2022-04-01 Thread Kevin Traynor
Hi all, Here is a list of patches targeted for stable release 21.11.1. Please try and complete validation by April 13th. Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported validations w

[PATCH v2] eal/linux: enable the hugepage mem dump

2022-04-01 Thread Li Feng
These hugepages include important structures. we should dump these hugepages into a coredump file for debugging when generating a coredump. Signed-off-by: Li Feng --- lib/eal/linux/eal_memalloc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/eal/linux/eal_memalloc.c b/lib/eal/linux/e

Re: [PATCH] eal/linux: enable the hugepage mem dump

2022-04-01 Thread Li Feng
On Thu, Mar 31, 2022 at 10:47 PM Burakov, Anatoly wrote: > > On 08-Mar-22 9:41 AM, Li Feng wrote: > > These hugepages include important structures. We should dump these > > hugepages into a coredump file for debugging when generating a coredump. > > > > Signed-off-by: Li Feng > > --- > > lib/ea

Re: [PATCH v2] dma/idxd: add generic option for queue config

2022-04-01 Thread Bruce Richardson
On Thu, Mar 31, 2022 at 06:21:12PM +0100, Kevin Laatz wrote: > The device config script currently uses some defaults to configure > devices in a generic way. > > With the addition of this option, users have more control over how > queues are configured. > > Signed-off-by: Kevin Laatz > --- > dr

RE: [PATCH v2] app/testpmd: change a magic number to macro

2022-04-01 Thread Zhang, Yuying
Hi Mingxia, LGTM. > -Original Message- > From: Liu, Mingxia > Sent: Thursday, March 31, 2022 10:34 AM > To: dev@dpdk.org > Cc: Li, Xiaoyun ; Singh, Aman Deep > ; Zhang, Yuying ; > Liu, Mingxia ; sta...@dpdk.org > Subject: [PATCH v2] app/testpmd: change a magic number to macro > > From:

[PATCH v2 2/2] eal: factorize lcore main loop

2022-04-01 Thread David Marchand
All OS implementations provide the same main loop. Introduce helpers (shared for Linux and FreeBSD) to handle synchronisation between main and threads and factorize the rest as common code. Thread id are now logged as string in a common format across OS. Signed-off-by: David Marchand Acked-by: Mo

[PATCH v2 1/2] eal: cleanup lcore ID hand-over

2022-04-01 Thread David Marchand
So far, a worker thread has been using its thread_id to discover which lcore has been assigned to it. On the other hand, as noted by Tyler, the pthread API does not strictly guarantee that a new thread won't start running eal_thread_loop before pthread_create writes to &lcore_config[xx].thread_id.

Re: [PATCH v2] dmadev: add telemetry support

2022-04-01 Thread Bruce Richardson
On Thu, Mar 31, 2022 at 06:39:46PM +, Sean Morrissey wrote: > Telemetry commands are now registered through the dmadev library > for the gathering of DSA stats. The corresponding callback > functions for listing dmadevs and providing info and stats for a > specific dmadev are implemented in the

Minutes of meeting 2022-02-23

2022-04-01 Thread Hemant Agrawal
Tech Board Attendees: Aaron, Ferruh, Hemant (Chair), Honnappa, Kevin, Konstantin, Maxime, Olivier, Stephen, Thomas Agenda Items -- * Userspace event * Venue booking is yet to happen. * Brainstorming on DPDK project ecosystem health * Easy support in the echo system.