Re: 21.11.1 patches review and test

2022-04-10 Thread Christian Ehrhardt
On Fri, Apr 1, 2022 at 12:22 PM Kevin Traynor wrote: > > Hi all, > > Here is a list of patches targeted for stable release 21.11.1. Hi Kevin, this breaks on me at build time due to symbol changes. It is a wild mix of Base->Internal/Experimental, a few new symbols, and even just removed ones (in g

[PATCH v3 1/1] net/bonding: fix rss key configuration when the key length is 52

2022-04-10 Thread Ke Zhang
when creating a bonding device, if the slave device's rss key length = standard_rss_key length + extended_hash_key length, then bonding device will be same as slave, in function bond_ethdev_configure(), the default_rss_key length is 40, it is not matched, so it should calculate a new key for bondin

[PATCH] vhost: support sync copy when data buffer is small

2022-04-10 Thread Wenwu Ma
In async datapath, if the length of data buffer is less than 256, the data will be copied by CPU instead of DMA. Signed-off-by: Wenwu Ma --- lib/vhost/vhost.h | 6 ++- lib/vhost/virtio_net.c | 96 ++ 2 files changed, 73 insertions(+), 29 deletions(-)

[PATCH v6] ip_frag: add IPv4 options fragment and test data

2022-04-10 Thread Huichao Cai
According to RFC791,the options may appear or not in datagrams. They must be implemented by all IP modules (host and gateways). What is optional is their transmission in any particular datagram, not their implementation.So we have to deal with it during the fragmenting process.Add some test data fo

[PATCH v2 1/1] net/bonding: fix rss key configuration when the key length is 52

2022-04-10 Thread Ke Zhang
when creating a bonding device, if the slave device's rss key length is 52, then bonding device will be same as slave, in function bond_ethdev_configure(), the default_rss_key length is 40, it is not matched, so it should calculate a new key for bonding device if the deault key could not be used.

RE: [PATCH] net/bonding: fix rss key configuration when the key length is 52

2022-04-10 Thread Zhang, Ke1X
> -Original Message- > From: Min Hu (Connor) > Sent: Friday, April 8, 2022 10:33 AM > To: Zhang, Ke1X ; ch...@att.com; dev@dpdk.org > Subject: Re: [PATCH] net/bonding: fix rss key configuration when the key > length is 52 > > Hi, > > 在 2022/4/7 17:36, Ke Zhang 写道: > > when creating a

Re: 21.11.1 patches review and test

2022-04-10 Thread Pei Zhang
cc Yanghang Liu from RedHat, he will do this testing soon :) Best regards, Pei On Fri, Apr 1, 2022 at 6:22 PM Kevin Traynor wrote: > Hi all, > > Here is a list of patches targeted for stable release 21.11.1. > > Please try and complete validation by April 13th. > > Please help with testing and

[PATCH] event/dlb2: add ldb port specific COS support

2022-04-10 Thread Timothy McDaniel
DLB supports 4 class of service domains, to aid in managing the device bandwidth across ldb ports. This commit allows specifying which ldb ports will participate in the COS scheme, which class they are a part of, and the specific bandwidth percentage associated with each class. The cumulative bandw

[PATCH v2] event/dlb2: add CQ weight support

2022-04-10 Thread Timothy McDaniel
Enabling the weight limit on a CQ allows the enqueued QEs' 2-bit weight value (representing weights of 1, 2, 4, and 8) to factor into whether a CQ is full. If the sum of the weights of the QEs in the CQ meet or exceed its weight limit, DLB will stop scheduling QEs to it (until software pops enough

[PATCH] ethdev: prohibit polling of a stopped queue

2022-04-10 Thread Dmitry Kozlyuk
Whether it is allowed to call Rx/Tx functions for a stopped queue was undocumented. Some PMDs make this behavior a no-op either by explicitly checking the queue state or by the way how their routines are implemented or HW works. No-op behavior may be convenient for application developers. But it a

RE: [PATCH] app/testpmd: fix use of indirect action after port close

2022-04-10 Thread Dmitry Kozlyuk
Hi Aman, > From: Dmitry Kozlyuk > Sent: Thursday, March 31, 2022 1:57 AM > [...] > > From: Singh, Aman Deep > > Sent: Wednesday, March 30, 2022 5:24 PM > > [...] > > On 3/7/2022 10:18 PM, Dmitry Kozlyuk wrote: > > > When a port was closed, indirect actions could remain > > > with their handles n

Re: [RFC 1/3] eal: add macro to warn for unused function return values

2022-04-10 Thread Mattias Rönnblom
On 2022-04-10 20:02, Stephen Hemminger wrote: > On Sun, 10 Apr 2022 15:51:38 +0200 > Mattias Rönnblom wrote: > >> This patch adds a wrapper macro __rte_warn_unused_result for the >> warn_unused_result function attribute. >> >> Marking a function __rte_warn_unused_result will make the compiler >>

[RFC] compress/mlx5: add support for LZ4 decompress

2022-04-10 Thread Raja Zidane
LZ4 decompress will be supported starting from BlueField3. Add LZ4 params struct to RTE XFORM struct. Add case to check for LZ4 algo, and pass params from RTE XFORM. Signed-off-by: Raja Zidane --- drivers/common/mlx5/mlx5_prm.h| 6 + drivers/compress/mlx5/mlx5_compress.c | 29 +

Re: [RFC 1/3] eal: add macro to warn for unused function return values

2022-04-10 Thread Stephen Hemminger
On Sun, 10 Apr 2022 15:51:38 +0200 Mattias Rönnblom wrote: > This patch adds a wrapper macro __rte_warn_unused_result for the > warn_unused_result function attribute. > > Marking a function __rte_warn_unused_result will make the compiler > emit a warning in case the caller does not use the funct

[RFC 3/3] examples/bond: fix invalid use of trylock

2022-04-10 Thread Mattias Rönnblom
The conditional rte_spinlock_trylock() was used as if it is an unconditional lock operation in a number of places. Fixes: cc7e8ae84faa ("examples/bond: add example application for link bonding mode 6") Cc: michalx.k.jastrzeb...@intel.com Signed-off-by: Mattias Rönnblom --- examples/bond/main.c

[RFC 2/3] eal: emit warning for unused trylock return value

2022-04-10 Thread Mattias Rönnblom
Mark the trylock family of spinlock functions with __rte_warn_unused_result. Signed-off-by: Mattias Rönnblom --- lib/eal/include/generic/rte_spinlock.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/eal/include/generic/rte_spinlock.h b/lib/eal/include/generic/rte_spinlock.h index 4

[RFC 1/3] eal: add macro to warn for unused function return values

2022-04-10 Thread Mattias Rönnblom
This patch adds a wrapper macro __rte_warn_unused_result for the warn_unused_result function attribute. Marking a function __rte_warn_unused_result will make the compiler emit a warning in case the caller does not use the function's return value. Signed-off-by: Mattias Rönnblom --- lib/eal/incl

RE: [PATCH] app/eventdev_dump: introduce eventdev_dump application

2022-04-10 Thread McDaniel, Timothy
> -Original Message- > From: Jerin Jacob > Sent: Sunday, April 10, 2022 1:49 AM > To: McDaniel, Timothy ; Maryam Tahhan > ; Pattan, Reshma > Cc: Jerin Jacob ; dpdk-dev > Subject: Re: [PATCH] app/eventdev_dump: introduce eventdev_dump > application > > On Sat, Apr 9, 2022 at 9:01 PM Ti

[PATCH 2/2] net/mlx5: add support for set and get MTU in Windows

2022-04-10 Thread Adham Masarwah
Mlx5Devx library has new API's for setting and getting MTU. Added new glue functions that wrap the new mlx5devx lib API's. Implemented the os_ethdev callbacks to use the new glue functions in Windows. Signed-off-by: Adham Masarwah Tested-by: Idan Hackmon Acked-by: Matan Azard --- drivers/commo

[PATCH 1/2] net/mlx5: add support for set promiscuous modes in Windows

2022-04-10 Thread Adham Masarwah
Support of the set promiscuous modes by calling the new API In Mlx5DevX Lib. Added new glue API for Windows which will be used to communicate with Windows driver to enable/disable PROMISC or ALLMC. Signed-off-by: Adham Masarwah Tested-by: Idan Hackmon Acked-by: Matan Azard --- drivers/common/m

[PATCH 0/2] net/mlx5: support missing functionality for Windows

2022-04-10 Thread Adham Masarwah
Adding support for set promiscuous modes and for MTU set/get Adham Masarwah (2): net/mlx5: add support for set promiscuous modes in Windows net/mlx5: add support for set and get MTU in Windows drivers/common/mlx5/windows/mlx5_glue.c | 86 +++ drivers/common/mlx5

[PATCH 0/2] net/mlx5: support missing functionality for Windows

2022-04-10 Thread Adham Masarwah
Adding support for set promiscuous modes and for MTU set/get Adham Masarwah (2): net/mlx5: add support for set promiscuous modes in Windows net/mlx5: add support for set and get MTU in Windows drivers/common/mlx5/windows/mlx5_glue.c | 86 +++ drivers/common/mlx5

[PATCH 3/3] net/mlx5: optimize Rx is hairpin function

2022-04-10 Thread Michael Baum
The mlx5_rxq_is_hairpin() function checks whether RxQ type is Hairpin. It is done by reading a flag in Rx control structure coming from mlx5_rxq_ctrl_get() function. The function verifies that the queue index is valid even though it has been checked within the mlx5_rxq_ctrl_get() function. This p

[PATCH 2/3] net/mlx5: fix reading invalid index in RxQ array

2022-04-10 Thread Michael Baum
The mlx5_rxq_get() function gets RxQ index and return RxQ priv accordingly. When it gets an invalid index, it accesses out of array bounds which might cause undefined behavior. This patch adds a check for invalid indexes before accessing to array. Fixes: 0cedf34da78f ("net/mlx5: move Rx queue re

[PATCH 1/3] net/mlx5: fix setting flags to external RxQ

2022-04-10 Thread Michael Baum
The flow_drv_rxq_flags_set sets the Rx queue flags (Mark/Flag and Tunnel Ptypes) according to the device flow. It tries to get the RxQ control structure to update its ptype. however, external RxQs don't have control structure to update and it may cause a crash. This patch add check whether this Q

[PATCH 0/3] net/mlx5: some RSS fixes

2022-04-10 Thread Michael Baum
Some RxQ management fixes affecting RSS flow rules. Michael Baum (3): net/mlx5: fix setting flags to external RxQ net/mlx5: fix reading invalid index in RxQ array net/mlx5: optimize Rx is hairpin function drivers/net/mlx5/mlx5_flow.c | 10 -- drivers/net/mlx5/mlx5_rxq.c | 22 +