RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on hotplug

2022-04-13 Thread Wang, Haiyue
> -Original Message- > From: Morten Brørup > Sent: Wednesday, April 13, 2022 14:58 > To: Wang, Haiyue ; Daly, Jeff ; > dev@dpdk.org > Cc: sta...@dpdk.org; Stephen Douthit ; Yang, Qiming > > Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on > hotplug > > > From: W

Re: [PATCH v2 1/4] eal/windows: translate Windows errors to errno-style errors

2022-04-13 Thread Tyler Retzlaff
On Tue, Apr 12, 2022 at 10:26:27AM -0700, Menon, Ranjit wrote: > Hi, Tyler > > On 4/12/2022 3:43 AM, Tyler Retzlaff wrote: > >Add function to translate Windows error codes to errno-style error > >codes. The possible return values are chosen so that we have as > >much semantical compatibility betwe

RE: [PATCH 1/1] common/cnxk: added new macros to platform layer

2022-04-13 Thread Morten Brørup
> From: Srikanth Yalavarthi [mailto:syalavar...@marvell.com] > Sent: Tuesday, 12 April 2022 19.42 > > Added new macros for pointer operations, bitwise operations, > spinlocks and 32 bit read and write. > > Signed-off-by: Srikanth Yalavarthi > --- > drivers/common/cnxk/roc_bits.h | 12 ++

RE: [PATCH 1/2] security: introduce per session event metadata

2022-04-13 Thread Akhil Goyal
Hi Abhinandan and others, > + @Jayatheerthan, Jay & @Vangati, Narender > > > This change would be an ABI breakage. So to avoid that, we are planning to > > Propose a better solution compared to this patch. > > We plan to add a new cryptodev op to set the event metadata. A single API > > which can

RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on hotplug

2022-04-13 Thread Morten Brørup
> From: Wang, Haiyue [mailto:haiyue.w...@intel.com] > Sent: Wednesday, 13 April 2022 09.02 > > > From: Morten Brørup > > Sent: Wednesday, April 13, 2022 14:58 > > > > > From: Wang, Haiyue [mailto:haiyue.w...@intel.com] > > > Sent: Wednesday, 13 April 2022 04.47 > > > To: Daly, Jeff; dev@dpdk.org

RE: [PATCH] net/ice: fix missing Tx burst mode name

2022-04-13 Thread Zhang, Qi Z
> -Original Message- > From: Michael Pfeiffer > Sent: Monday, April 4, 2022 10:42 PM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; sta...@dpdk.org; Michael Pfeiffer ilmenau.de>; Lu, Wenzhuo ; Michael Rossberg > > Subject: [PATCH] net/ice: fix missing Tx burst mode name > >

RE: [PATCH v3] net/ice: refact parser API usage

2022-04-13 Thread Xu, Ting
> -Original Message- > From: Zhang, Qi Z > Sent: Friday, April 8, 2022 12:06 AM > To: Guo, Junfeng ; Xu, Ting > Cc: dev@dpdk.org; Yang, Qiming ; Zhang, Qi Z > ; sta...@dpdk.org > Subject: [PATCH v3] net/ice: refact parser API usage > > Not necessary to create / destroy a parser instance

Re: 21.11.1 patches review and test

2022-04-13 Thread Christian Ehrhardt
On Mon, Apr 11, 2022 at 8:58 AM Christian Ehrhardt wrote: > > On Fri, Apr 1, 2022 at 12:22 PM Kevin Traynor wrote: > > > > Hi all, > > > > Here is a list of patches targeted for stable release 21.11.1. > > Hi Kevin, > this breaks on me at build time due to symbol changes. > It is a wild mix of Ba

Re: [PATCH v2 3/4] eal: implement functions for get/set thread affinity

2022-04-13 Thread Tyler Retzlaff
On Tue, Apr 12, 2022 at 03:43:39AM -0700, Tyler Retzlaff wrote: > diff --git a/lib/eal/windows/eal_lcore.c b/lib/eal/windows/eal_lcore.c > index 476c2d2..4f2224e 100644 > --- a/lib/eal/windows/eal_lcore.c > +++ b/lib/eal/windows/eal_lcore.c ... snip ... > int > eal_create_cpu_map(void) > { >

[PATCH] vmbus: get current rte_vmbus_bus struct

2022-04-13 Thread Abdelfattah Chehab
Hi All, FOREACH_DEVICE_ON_VMBUS needs rte_vmbus_bus to work on If static link to libdpdk.a : no issues If dynamic link to *.so: linker issue, global variable not found. I suggest this patch to get a current rte_vmbus_bus struct: Thanks. diff --git a/dpdk-20.11/drivers/bus/vmbus/rte_bus_vmbus.h

RE: [PATCH v3] net/ice: refact parser API usage

2022-04-13 Thread Zhang, Qi Z
> -Original Message- > From: Xu, Ting > Sent: Wednesday, April 13, 2022 3:23 PM > To: Zhang, Qi Z ; Guo, Junfeng > > Cc: dev@dpdk.org; Yang, Qiming ; > sta...@dpdk.org > Subject: RE: [PATCH v3] net/ice: refact parser API usage > > > -Original Message- > > From: Zhang, Qi Z >

[PATCH v3 0/4] add eal functions for thread affinity and self

2022-04-13 Thread Tyler Retzlaff
this series provides basic dependencies for additional eal thread api additions. series includes * basic platform error number conversion. * function to get current thread identifier. * functions to get and set affinity with platform agnostic thread identifier. * minimal unit test of get and set

[PATCH v3 1/4] eal/windows: translate Windows errors to errno-style errors

2022-04-13 Thread Tyler Retzlaff
Add function to translate Windows error codes to errno-style error codes. The possible return values are chosen so that we have as much semantical compatibility between platforms as possible. Signed-off-by: Narcisa Vasile Signed-off-by: Tyler Retzlaff --- lib/eal/windows/rte_thread.c | 49 +

[PATCH v3 3/4] eal: implement functions for get/set thread affinity

2022-04-13 Thread Tyler Retzlaff
Implement functions for getting/setting thread affinity. Threads can be pinned to specific cores by setting their affinity attribute. note: rte_convert_cpuset_to_affinity has a limitation that all cpus of the set belong to the same processor group. Signed-off-by: Narcisa Vasile Signed-off-by: Ty

[PATCH v3 2/4] eal: add basic thread ID and current thread identifier API

2022-04-13 Thread Tyler Retzlaff
Provide a portable type-safe thread identifier. Provide rte_thread_self for obtaining current thread identifier. Signed-off-by: Narcisa Vasile Signed-off-by: Tyler Retzlaff --- lib/eal/include/rte_thread.h | 22 ++ lib/eal/unix/rte_thread.c| 11 +++ lib/eal/versi

[PATCH v3 4/4] test/threads: add unit test for thread API

2022-04-13 Thread Tyler Retzlaff
Establish unit test for testing thread api. Initial unit tests for rte_thread_{get,set}_affinity_by_id(). Signed-off-by: Narcisa Vasile Signed-off-by: Tyler Retzlaff --- app/test/meson.build| 2 ++ app/test/test_threads.c | 89 + 2 files chan

Re: rte_memzone_reserve and invalid socket id

2022-04-13 Thread Tyler Retzlaff
On Mon, Mar 28, 2022 at 11:04:36PM -0700, Tyler Retzlaff wrote: > hi, > > there is a repeatable test failure in test_memzone when running > dpdk-test.exe --no-huge for memzone_autotest > > it's clear why the test fails but what isn't clear if what > rte_memzone_reserve is doing when provided an i

[PATCH v2 00/33] support full function of DCF

2022-04-13 Thread Kevin Liu
These functions have been customized and implemented on DPDK-20.11, Now it's time to migrate the function to DPDK-22.07. v2: * remove patch: 1.net/iavf: support checking if device is an MDCF instance 2.net/ice: support MDCF(multi-DCF) instance 3.net/ice/base: support custom

[PATCH v2 01/33] net/ice: enable RSS RETA ops for DCF hardware

2022-04-13 Thread Kevin Liu
From: Steve Yang RSS RETA should be updated and queried by application, Add related ops ('.reta_update', '.reta_query') for DCF. Signed-off-by: Steve Yang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf.c| 2 +- drivers/net/ice/ice_dcf.h| 1 + drivers/net/ice/ice_dcf_et

[PATCH v2 02/33] net/ice: enable RSS HASH ops for DCF hardware

2022-04-13 Thread Kevin Liu
From: Steve Yang RSS HASH should be updated and queried by application, Add related ops ('.rss_hash_update', '.rss_hash_conf_get') for DCF. Because DCF doesn't support configure RSS HASH, only HASH key can be updated within ops '.rss_hash_update'. Signed-off-by: Steve Yang Signed-off-by: Kevin

[PATCH v2 03/33] net/ice: cleanup Tx buffers

2022-04-13 Thread Kevin Liu
From: Robin Zhang Add support for ops rte_eth_tx_done_cleanup in dcf Signed-off-by: Robin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c index ccad7fc30

[PATCH v2 04/33] net/ice: add ops MTU-SET to dcf

2022-04-13 Thread Kevin Liu
From: Jie Wang add API "mtu_set" to dcf, and it can configure the port mtu through cmdline. Signed-off-by: Jie Wang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 14 ++ drivers/net/ice/ice_dcf_ethdev.h | 6 ++ 2 files changed, 20 insertions(+) diff --git a/

[PATCH v2 05/33] net/ice: add ops dev-supported-ptypes-get to dcf

2022-04-13 Thread Kevin Liu
From: Jie Wang add API "dev_supported_ptypes_get" to dcf, that dcf pmd can get ptypes through the new API. Signed-off-by: Jie Wang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 80 +++- 1 file changed, 49 insertions(+), 31 deletions(-) diff --git

[PATCH v2 06/33] net/ice: support dcf promisc configuration

2022-04-13 Thread Kevin Liu
From: Alvin Zhang Support configuration of unicast and multicast promisc on dcf. Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 77 ++-- drivers/net/ice/ice_dcf_ethdev.h | 3 ++ 2 files changed, 76 insertions(+), 4 delet

[PATCH v2 07/33] net/ice: support dcf MAC configuration

2022-04-13 Thread Kevin Liu
Below PMD ops are supported in this patch: .mac_addr_add = dcf_dev_add_mac_addr .mac_addr_remove = dcf_dev_del_mac_addr .set_mc_addr_list = dcf_set_mc_addr_list .mac_addr_set = dcf_dev_set_default_mac_addr Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- driv

[PATCH v2 08/33] net/ice: support dcf VLAN filter and offload configuration

2022-04-13 Thread Kevin Liu
From: Alvin Zhang Below PMD ops are supported in this patch: .vlan_filter_set = dcf_dev_vlan_filter_set .vlan_offload_set = dcf_dev_vlan_offload_set Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 101 +++ 1 file

Re: [PATCH] vmbus: get current rte_vmbus_bus struct

2022-04-13 Thread David Marchand
On Wed, Apr 13, 2022 at 9:32 AM Abdelfattah Chehab wrote: > > Hi All, > > FOREACH_DEVICE_ON_VMBUS needs rte_vmbus_bus to work on > > If static link to libdpdk.a : no issues > > If dynamic link to *.so: linker issue, global variable not found. Not sure I really get your usecase, but this probably

[PATCH v2 09/33] net/ice: support DCF new VLAN capabilities

2022-04-13 Thread Kevin Liu
From: Alvin Zhang The new VLAN virtchnl opcodes introduce new capabilities like VLAN filtering, stripping and insertion. The DCF needs to query the VLAN capabilities based on current device configuration firstly. DCF is able to configure inner VLAN filter when port VLAN is enabled base on negot

[PATCH v2 10/33] net/ice: enable CVL DCF device reset API

2022-04-13 Thread Kevin Liu
From: Dapeng Yu Enable CVL DCF device reset API. Signed-off-by: Dapeng Yu Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf.c | 24 drivers/net/ice/ice_dcf.h | 1 + 2 files changed, 25 insertions(+) diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf

[PATCH v2 11/33] net/ice/base: add VXLAN support for switch filter

2022-04-13 Thread Kevin Liu
From: Junfeng Guo 1. Add profile rule for VXLAN on Switch Filter, including pattern_eth_ipv4_udp_vxlan_any pattern_eth_ipv6_udp_vxlan_any pattern_eth_ipv4_udp_vxlan_eth_ipv4 pattern_eth_ipv4_udp_vxlan_eth_ipv6 pattern_eth_ipv6_udp_vxlan_eth_ipv4 pat

[PATCH v2 14/33] net/ice/base: fix ethertype filter input set

2022-04-13 Thread Kevin Liu
From: Alvin Zhang Add destination and source MAC as the input sets to ethertype filter. For example: flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 type is 0x802 / end actions queue index 2 / end This flow will result in all the matched ingress packets be forwarded to queue 2.

[PATCH v2 15/33] net/ice/base: support IPv6 GRE UDP pattern

2022-04-13 Thread Kevin Liu
From: Alvin Zhang Add supports(trainer packet and it's offsets, definitions, pattern matching) for IPv6 GRE UDP pattern. Signed-off-by: Junfeng Guo Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/base/ice_protocol_type.h | 1 + drivers/net/ice/base/ice_switch.c

[PATCH v2 16/33] net/ice: support IPv6 NVGRE tunnel

2022-04-13 Thread Kevin Liu
From: Alvin Zhang Add protocol definition and pattern matching for IPv6 NVGRE tunnel. Signed-off-by: Junfeng Guo Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_switch_filter.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ice/ice_switch_fil

[PATCH v2 17/33] net/ice: support new pattern of IPv4

2022-04-13 Thread Kevin Liu
From: Alvin Zhang Add definition and pattern entry for IPv4 pattern: MAC/VLAN/IPv4 Signed-off-by: Junfeng Guo Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_switch_filter.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ice/ice_switch_filter.c

[PATCH v2 18/33] net/ice/base: support new patterns of TCP and UDP

2022-04-13 Thread Kevin Liu
From: Alvin Zhang Find training packets for below TCP and UDP patterns: MAC/VLAN/IPv4/TCP MAC/VLAN/IPv4/UDP Signed-off-by: Junfeng Guo Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/base/ice_switch.c | 12 1 file changed, 12 insertions(+) diff --git a/d

[PATCH v2 19/33] net/ice: support new patterns of TCP and UDP

2022-04-13 Thread Kevin Liu
From: Alvin Zhang Add definitions and pattern entries for below TCP and UDP patterns: MAC/VLAN/IPv4/TCP MAC/VLAN/IPv4/UDP Signed-off-by: Junfeng Guo Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_switch_filter.c | 6 ++ 1 file changed, 6 insertions(+) diff -

[PATCH v2 20/33] net/ice/base: support IPv4 GRE tunnel

2022-04-13 Thread Kevin Liu
From: Alvin Zhang Add definitions, trainer packets and routine path for IPv4 GRE tunnel. Ref: https://www.ietf.org/rfc/rfc1701.html Signed-off-by: Junfeng Guo Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/base/ice_flex_pipe.c | 37 ++- drivers/net/ice/base/ice_

[PATCH v2 12/33] net/ice: add VXLAN support for switch filter

2022-04-13 Thread Kevin Liu
From: Junfeng Guo 1. Add profile rule for VXLAN on Switch Filter, including pattern_eth_ipv4_udp_vxlan_any pattern_eth_ipv6_udp_vxlan_any pattern_eth_ipv4_udp_vxlan_eth_ipv4 pattern_eth_ipv4_udp_vxlan_eth_ipv6 pattern_eth_ipv6_udp_vxlan_eth_ipv4 pat

[PATCH v2 13/33] common/iavf: support flushing rules and reporting DCF id

2022-04-13 Thread Kevin Liu
From: Alvin Zhang Add virtual channel opcode for DCF flushing rules. Add virtual channel event for PF reporting DCF id. Signed-off-by: Steven Zou Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- drivers/common/iavf/virtchnl.h | 13 + 1 file changed, 13 insertions(+) diff

[PATCH v2 21/33] net/ice: support IPv4 GRE raw pattern type

2022-04-13 Thread Kevin Liu
From: Alvin Zhang Add definitions, matching entries, parsers for below patterns: ETH/IPV4/GRE/RAW/IPV4 ETH/IPV4/GRE/RAW/IPV4/UDP ETH/IPV4/GRE/RAW/IPV4/TCP Signed-off-by: Steven Zou Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_generic_flow.c | 27 + dri

[PATCH v2 22/33] net/ice: treat unknown package as OS default package

2022-04-13 Thread Kevin Liu
From: Alvin Zhang In order to use custom package, unknown package should be treated as OS default package. Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_ethdev.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/ice/ice

[PATCH v2 23/33] net/ice/base: update Profile ID table for VXLAN

2022-04-13 Thread Kevin Liu
From: Junfeng Guo Update Profile ID table for VXLAN to align with Tencent customed DDP. Signed-off-by: Junfeng Guo Signed-off-by: Kevin Liu --- drivers/net/ice/base/ice_switch.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/ice/base/ice_swi

[PATCH v2 24/33] net/ice/base: update Protocol ID table to match DVM DDP

2022-04-13 Thread Kevin Liu
From: Junfeng Guo The ice kernel driver and DDP is working in Double VLAN Mode (DVM), but the DVM is not supported on this PMD. Thus update the SW to HW Protocol ID table for VLAN to support common switch filtering with single VLAN layer. Signed-off-by: Junfeng Guo Signed-off-by: Kevin Liu ---

[PATCH v2 25/33] net/ice: handle virtchnl event message without interrupt

2022-04-13 Thread Kevin Liu
From: Steve Yang Currently, VF can only handle virtchnl event message by calling interrupt. It is not available in two cases: 1. If the event message comes during VF initialization before interrupt is enabled, this message will not be handled correctly. 2. Some virtchnl commands need to receive t

[PATCH v2 26/33] net/ice: add DCF request queues function

2022-04-13 Thread Kevin Liu
From: Steve Yang Add a new virtchnl function to request additional queues from PF. Current default queue pairs number is 16. In order to support up to 256 queue pairs DCF port, enable this request queues function. Signed-off-by: Steve Yang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf.

[PATCH v2 27/33] net/ice: negotiate large VF and request more queues

2022-04-13 Thread Kevin Liu
From: Steve Yang Negotiate large VF capability with PF during VF initialization. If large VF is supported and the number of queues larger than 16 is required, VF requests additional queues from PF. Mark the state that large VF is supported. If the allocated queues number is larger than 16, the m

[PATCH v2 28/33] net/ice: enable multiple queues configurations for large VF

2022-04-13 Thread Kevin Liu
From: Steve Yang Since the adminq buffer size has a 4K limitation, the current virtchnl command VIRTCHNL_OP_CONFIG_VSI_QUEUES cannot send the message only once to configure up to 256 queues. In this patch, we send the messages multiple times to make sure that the buffer size is less than 4K each

[PATCH v2 29/33] net/ice: enable IRQ mapping configuration for large VF

2022-04-13 Thread Kevin Liu
From: Steve Yang The current IRQ mapping configuration only supports max 16 queues and 16 MSIX vectors. Change the queue vector mapping structure to indicate up to 256 queues. A new opcode is used to handle the case with large number of queues. To avoid adminq buffer size limitation, we support t

[PATCH v2 30/33] net/ice: add enable/disable queues for DCF large VF

2022-04-13 Thread Kevin Liu
The current virtchnl structure for enable/disable queues only supports max 32 queue pairs. Use a new opcode and structure to indicate up to 256 queue pairs, in order to enable/disable queues in large VF case. Signed-off-by: Steve Yang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf.c

[PATCH v2 31/33] net/ice: fix DCF ACL flow engine

2022-04-13 Thread Kevin Liu
From: Alvin Zhang ACL is not a necessary feature for DCF, it may not be supported by the ice kernel driver, so in this patch the program does not return the ACL initiation fails to high level functions, as substitute it prints some error logs, cleans the related resources and unregisters the ACL

[PATCH v2 32/33] testpmd: force flow flush

2022-04-13 Thread Kevin Liu
From: Qi Zhang For mdcf, rte_flow_flush is still need to be invoked even there are no flows be created in current instance. Signed-off-by: Qi Zhang Signed-off-by: Kevin Liu --- app/test-pmd/config.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/config.

[PATCH v2 33/33] net/ice: fix DCF reset

2022-04-13 Thread Kevin Liu
After the PF triggers the VF reset, before the VF PMD can perform any operations on the hardware, it must reinitialize the all resources. This patch adds a flag to indicate whether the VF has been reset by PF, and update the DCF resetting operations according to this flag. Fixes: 1a86f4dbdf42 ("n

Re: 21.11.1 patches review and test

2022-04-13 Thread Kevin Traynor
On 13/04/2022 08:26, Christian Ehrhardt wrote: On Mon, Apr 11, 2022 at 8:58 AM Christian Ehrhardt wrote: On Fri, Apr 1, 2022 at 12:22 PM Kevin Traynor wrote: Hi all, Here is a list of patches targeted for stable release 21.11.1. Hi Kevin, this breaks on me at build time due to symbol cha

[PATCH v3 00/22] support full function of DCF

2022-04-13 Thread Kevin Liu
v3: * remove patch: 1.net/ice/base: add VXLAN support for switch filter 2.net/ice: add VXLAN support for switch filter 3.common/iavf: support flushing rules and reporting DCF id 4.net/ice/base: fix ethertype filter input set 5.net/ice/base: support IPv6 GRE U

[PATCH v3 01/22] net/ice: enable RSS RETA ops for DCF hardware

2022-04-13 Thread Kevin Liu
From: Steve Yang RSS RETA should be updated and queried by application, Add related ops ('.reta_update', '.reta_query') for DCF. Signed-off-by: Steve Yang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf.c| 2 +- drivers/net/ice/ice_dcf.h| 1 + drivers/net/ice/ice_dcf_et

[PATCH v3 02/22] net/ice: enable RSS HASH ops for DCF hardware

2022-04-13 Thread Kevin Liu
From: Steve Yang RSS HASH should be updated and queried by application, Add related ops ('.rss_hash_update', '.rss_hash_conf_get') for DCF. Because DCF doesn't support configure RSS HASH, only HASH key can be updated within ops '.rss_hash_update'. Signed-off-by: Steve Yang Signed-off-by: Kevin

[PATCH v3 03/22] net/ice: cleanup Tx buffers

2022-04-13 Thread Kevin Liu
From: Robin Zhang Add support for ops rte_eth_tx_done_cleanup in dcf Signed-off-by: Robin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c index ccad7fc30

[PATCH v3 04/22] net/ice: add ops MTU-SET to dcf

2022-04-13 Thread Kevin Liu
From: Jie Wang add API "mtu_set" to dcf, and it can configure the port mtu through cmdline. Signed-off-by: Jie Wang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 14 ++ drivers/net/ice/ice_dcf_ethdev.h | 6 ++ 2 files changed, 20 insertions(+) diff --git a/

[PATCH v3 05/22] net/ice: add ops dev-supported-ptypes-get to dcf

2022-04-13 Thread Kevin Liu
From: Jie Wang add API "dev_supported_ptypes_get" to dcf, that dcf pmd can get ptypes through the new API. Signed-off-by: Jie Wang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 80 +++- 1 file changed, 49 insertions(+), 31 deletions(-) diff --git

[PATCH v3 06/22] net/ice: support dcf promisc configuration

2022-04-13 Thread Kevin Liu
From: Alvin Zhang Support configuration of unicast and multicast promisc on dcf. Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 77 ++-- drivers/net/ice/ice_dcf_ethdev.h | 3 ++ 2 files changed, 76 insertions(+), 4 delet

[PATCH v3 07/22] net/ice: support dcf MAC configuration

2022-04-13 Thread Kevin Liu
Below PMD ops are supported in this patch: .mac_addr_add = dcf_dev_add_mac_addr .mac_addr_remove = dcf_dev_del_mac_addr .set_mc_addr_list = dcf_set_mc_addr_list .mac_addr_set = dcf_dev_set_default_mac_addr Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- driv

[PATCH v3 08/22] net/ice: support dcf VLAN filter and offload configuration

2022-04-13 Thread Kevin Liu
From: Alvin Zhang Below PMD ops are supported in this patch: .vlan_filter_set = dcf_dev_vlan_filter_set .vlan_offload_set = dcf_dev_vlan_offload_set Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 101 +++ 1 file

[PATCH v3 10/22] net/ice: enable CVL DCF device reset API

2022-04-13 Thread Kevin Liu
From: Dapeng Yu Enable CVL DCF device reset API. Signed-off-by: Dapeng Yu Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf.c | 24 drivers/net/ice/ice_dcf.h | 1 + 2 files changed, 25 insertions(+) diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf

[PATCH v3 09/22] net/ice: support DCF new VLAN capabilities

2022-04-13 Thread Kevin Liu
From: Alvin Zhang The new VLAN virtchnl opcodes introduce new capabilities like VLAN filtering, stripping and insertion. The DCF needs to query the VLAN capabilities based on current device configuration firstly. DCF is able to configure inner VLAN filter when port VLAN is enabled base on negot

[PATCH v3 12/22] net/ice: support new pattern of IPv4

2022-04-13 Thread Kevin Liu
From: Alvin Zhang Add definition and pattern entry for IPv4 pattern: MAC/VLAN/IPv4 Signed-off-by: Junfeng Guo Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_switch_filter.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ice/ice_switch_filter.c

[PATCH v3 11/22] net/ice: support IPv6 NVGRE tunnel

2022-04-13 Thread Kevin Liu
From: Alvin Zhang Add protocol definition and pattern matching for IPv6 NVGRE tunnel. Signed-off-by: Junfeng Guo Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_switch_filter.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ice/ice_switch_fil

[PATCH v3 13/22] net/ice: treat unknown package as OS default package

2022-04-13 Thread Kevin Liu
From: Alvin Zhang In order to use custom package, unknown package should be treated as OS default package. Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_ethdev.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/ice/ice

[PATCH v3 14/22] net/ice: handle virtchnl event message without interrupt

2022-04-13 Thread Kevin Liu
From: Steve Yang Currently, VF can only handle virtchnl event message by calling interrupt. It is not available in two cases: 1. If the event message comes during VF initialization before interrupt is enabled, this message will not be handled correctly. 2. Some virtchnl commands need to receive t

[PATCH v3 15/22] net/ice: add DCF request queues function

2022-04-13 Thread Kevin Liu
From: Steve Yang Add a new virtchnl function to request additional queues from PF. Current default queue pairs number is 16. In order to support up to 256 queue pairs DCF port, enable this request queues function. Signed-off-by: Steve Yang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf.

[PATCH v3 16/22] net/ice: negotiate large VF and request more queues

2022-04-13 Thread Kevin Liu
From: Steve Yang Negotiate large VF capability with PF during VF initialization. If large VF is supported and the number of queues larger than 16 is required, VF requests additional queues from PF. Mark the state that large VF is supported. If the allocated queues number is larger than 16, the m

[PATCH v3 17/22] net/ice: enable multiple queues configurations for large VF

2022-04-13 Thread Kevin Liu
From: Steve Yang Since the adminq buffer size has a 4K limitation, the current virtchnl command VIRTCHNL_OP_CONFIG_VSI_QUEUES cannot send the message only once to configure up to 256 queues. In this patch, we send the messages multiple times to make sure that the buffer size is less than 4K each

[PATCH v3 18/22] net/ice: enable IRQ mapping configuration for large VF

2022-04-13 Thread Kevin Liu
From: Steve Yang The current IRQ mapping configuration only supports max 16 queues and 16 MSIX vectors. Change the queue vector mapping structure to indicate up to 256 queues. A new opcode is used to handle the case with large number of queues. To avoid adminq buffer size limitation, we support t

[PATCH v3 19/22] net/ice: add enable/disable queues for DCF large VF

2022-04-13 Thread Kevin Liu
The current virtchnl structure for enable/disable queues only supports max 32 queue pairs. Use a new opcode and structure to indicate up to 256 queue pairs, in order to enable/disable queues in large VF case. Signed-off-by: Steve Yang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf.c

[PATCH v3 20/22] net/ice: fix DCF ACL flow engine

2022-04-13 Thread Kevin Liu
From: Alvin Zhang ACL is not a necessary feature for DCF, it may not be supported by the ice kernel driver, so in this patch the program does not return the ACL initiation fails to high level functions, as substitute it prints some error logs, cleans the related resources and unregisters the ACL

[PATCH v3 21/22] testpmd: force flow flush

2022-04-13 Thread Kevin Liu
From: Qi Zhang For mdcf, rte_flow_flush is still need to be invoked even there are no flows be created in current instance. Signed-off-by: Qi Zhang Signed-off-by: Kevin Liu --- app/test-pmd/config.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/config.

[PATCH v3 22/22] net/ice: fix DCF reset

2022-04-13 Thread Kevin Liu
After the PF triggers the VF reset, before the VF PMD can perform any operations on the hardware, it must reinitialize the all resources. This patch adds a flag to indicate whether the VF has been reset by PF, and update the DCF resetting operations according to this flag. Fixes: 1a86f4dbdf42 ("n

Re: 21.11.1 patches review and test

2022-04-13 Thread Kevin Traynor
Hi Christian/Thomas/Ori, On 11/04/2022 07:58, Christian Ehrhardt wrote: On Fri, Apr 1, 2022 at 12:22 PM Kevin Traynor wrote: Hi all, Here is a list of patches targeted for stable release 21.11.1. Hi Kevin, this breaks on me at build time due to symbol changes. It is a wild mix of Base->Inter

RE: [PATCH v2] kni: optimize alloc queue release

2022-04-13 Thread Kundapura, Ganapati
Hi Harish > -Original Message- > From: Naga Harish K S V > Sent: 13 April 2022 11:19 > To: Yigit, Ferruh > Cc: Jayatheerthan, Jay ; dev@dpdk.org > Subject: [PATCH v2] kni: optimize alloc queue release > > the kni alloc queue is filled with physical addresses of mbufs for kernel > consum

[PATCH 0/3] BNXT changes

2022-04-13 Thread Ruifeng Wang
This patch set includes changes proposed for BNXT PMD. Found these in code review. Ruifeng Wang (3): net/bnxt: defer completion index update net/bnxt: remove redundant ifdefs net/bnxt: fix risk in Rx descriptor read in NEON path drivers/net/bnxt/bnxt_rxr.c | 2 +- drivers/net/bn

[PATCH 1/3] net/bnxt: defer completion index update

2022-04-13 Thread Ruifeng Wang
When no packet is received, there is no need to update completion raw cons. Moved update down to remove unnecessary store in this case. Signed-off-by: Ruifeng Wang --- drivers/net/bnxt/bnxt_rxr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_rxr.c b/dr

[PATCH 2/3] net/bnxt: remove redundant ifdefs

2022-04-13 Thread Ruifeng Wang
NEON vector path is built only when Arm platform is 64-bit. The ifdefs in NEON path are of no use, hence remove. Signed-off-by: Ruifeng Wang --- drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_neon.c b/drivers/net/bnxt/

[PATCH 3/3] net/bnxt: fix risk in Rx descriptor read in NEON path

2022-04-13 Thread Ruifeng Wang
Rx descriptor contains a valid bit which indicates readiness of the rest of descriptor words. Hence, the word contains valid bit must be read prior to other words. In NEON vector path, two contiguous 8B descriptor are loaded to a single NEON register. Given vector load ensures no 16B atomicity, re

[PATCH 0/2] support to clear in-flight packets for async

2022-04-13 Thread Yuan Wang
These patches support to clear in-flight packets for async dequeue and introduce thread-safe version of this function. note: The patches depend on the following patches (https://patches.dpdk.org/project/dpdk/patch/20220411100032.114434-5-xuan.d...@intel.com/) (https://patches.dpdk.org/project/dpdk

[PATCH 1/2] vhost: support clear in-flight packets for async dequeue

2022-04-13 Thread Yuan Wang
rte_vhost_clear_queue_thread_unsafe() supports to clear in-flight packets for async enqueue only. But after supporting async dequeue, this API should support async dequeue too. This patch also adds the thread-safe version of this API, the difference between the two API is that thread safety uses l

[PATCH 2/2] example/vhost: support to clear in-flight packets for async dequeue

2022-04-13 Thread Yuan Wang
This patch allows vring_state_changed() to clear in-flight dequeue packets. Signed-off-by: Yuan Wang --- examples/vhost/main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index d26e40ab73..04e7821322 100644 --- a/examples/vhost/main.c +++ b

[Bug 993] [build][21.11] build failure using meson 0.62.0

2022-04-13 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=993 Bug ID: 993 Summary: [build][21.11] build failure using meson 0.62.0 Product: DPDK Version: 21.11 Hardware: All OS: FreeBSD Status: UNCONFIRMED Severity: normal

[PATCH] net/mlx5: fix gtp handling in header modify action

2022-04-13 Thread Dariusz Sosnowski
GTP items were ignored during conversion of modify header actions. This caused modify TTL action to generate a wrong modify header command when tunnel and inner headers used different IP versions. This patch adds GTP item handling to modify header action conversion. Fixes: 04233f36c712 ("net/mlx5

[PATCH] devtools: fix null test for NUMA systems

2022-04-13 Thread David Marchand
On NUMA systems, default cores (0 and 1) might be on different memory nodes. Double the amount of memory. Cc: sta...@dpdk.org Signed-off-by: David Marchand --- devtools/test-null.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/devtools/test-null.sh b/devtools/test-null.

RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on hotplug

2022-04-13 Thread Wang, Haiyue
> -Original Message- > From: Morten Brørup > Sent: Wednesday, April 13, 2022 15:20 > To: Wang, Haiyue ; Daly, Jeff ; > dev@dpdk.org > Cc: sta...@dpdk.org; Stephen Douthit ; Yang, Qiming > > Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on > hotplug > > > From: W

Re: [PATCH] mbuf: expose outer vlan in mbuf dump

2022-04-13 Thread Thomas Monjalon
12/04/2022 18:11, Ben Magistro: > Was there a consensus on if this should be re-drafted as a bug and fixes or > left as a backportable feature/improvement? I am good either way, just > wanted to clarify if I had an additional action at this time. There is no consensus but that's a detail. In any

Re: [PATCH v2] common/sff_module: add telemetry command to dump module EEPROM

2022-04-13 Thread Thomas Monjalon
11/04/2022 11:13, Bruce Richardson: > On Mon, Apr 11, 2022 at 09:13:47AM +0100, Zhang, RobinX wrote: > > Hi Bruce, > > > > > -Original Message- > > > From: Richardson, Bruce > > > Sent: Friday, April 8, 2022 7:27 PM > > > To: Zhang, RobinX > > > Cc: dev@dpdk.org; Yang, Qiming ; Zhang, Qi

Re: [PATCH v1 0/4] [RFC] Testpmd RPC API

2022-04-13 Thread Owen Hilyard
> > If so, I think, gRPC service would be along with existing > testpmd functions, like start_packet_forwarding(). It was my intention to re-use existing functions. I used the ACL tests as an example because they are more self-contained then Testpmd, which made creating the proof of concept much

RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on hotplug

2022-04-13 Thread Morten Brørup
> From: Wang, Haiyue [mailto:haiyue.w...@intel.com] > Sent: Wednesday, 13 April 2022 13.49 > > > From: Morten Brørup > > Sent: Wednesday, April 13, 2022 15:20 > > > > > From: Wang, Haiyue [mailto:haiyue.w...@intel.com] > > > Sent: Wednesday, 13 April 2022 09.02 > > > > > > > From: Morten Brørup

RE: [PATCH] mbuf: expose outer vlan in mbuf dump

2022-04-13 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, 13 April 2022 14.03 > > 12/04/2022 18:11, Ben Magistro: > > Was there a consensus on if this should be re-drafted as a bug and > fixes or > > left as a backportable feature/improvement? I am good either way, > just > > wanted

Re: 21.11.1 patches review and test

2022-04-13 Thread Kevin Traynor
On 11/04/2022 12:00, Ali Alnubani wrote: -Original Message- From: Kevin Traynor Sent: Friday, April 1, 2022 1:22 PM To: sta...@dpdk.org Cc: dev@dpdk.org; Abhishek Marathe ; Ali Alnubani ; benjamin.wal...@intel.com; David Christensen ; hariprasad.govindhara...@intel.com; Hemant Agrawal ;

Re: 21.11.1 patches review and test

2022-04-13 Thread Kevin Traynor
On 12/04/2022 09:58, Jiang, YuX wrote: -Original Message- From: Kevin Traynor Sent: Friday, April 1, 2022 6:22 PM To: sta...@dpdk.org Cc: dev@dpdk.org; Abhishek Marathe ; Ali Alnubani ; Walker, Benjamin ; David Christensen ; hariprasad.govindhara...@intel.com; Hemant Agrawal ; Stokes, Ia

Re: 21.11.1 patches review and test

2022-04-13 Thread Kevin Traynor
On 13/04/2022 05:06, YangHang Liu wrote: Hi Kevin, The dpdk 21.11.1-rc1 test result from Red Hat looks good. We tested below 17 scenarios and all got PASS on RHEL8: - Guest with device assignment(PF) throughput testing(1G hugepage size): PASS - Guest with device assignment(PF) thro

Re: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices

2022-04-13 Thread Thomas Monjalon
Please, could we have a review of this patch? +Cc new ixgbe maintainers 07/03/2022 23:34, je...@silicom-usa.com: > From: Stephen Douthit > > 1G Cu SFPs are not officially supported on the X552/X553 family of devices > but treat them as 1G SX modules since they usually work. Print a warning > t

[PATCH v2 0/2] cryptodev: add dh verify option

2022-04-13 Thread Arek Kusztal
This patchset adds verify and padding option to Cryptodev Diffie-Hellman op. Verify - obligatory in all mainstream protocols, in Cryptodev only Weierstrass Elliptic-Curve point verification was included. FFDH or curves 448/25519 verification is easy enough to be done by the user. Padding - differe

[PATCH v2 1/2] cryptodev: add dh verify option

2022-04-13 Thread Arek Kusztal
For some elliptic curves public point in DH exchange needs to be checked, if lays on the curve. Modular exponentiation needs certain checks as well, though mathematically much easier. This commit adds verify option to asym_op operations. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_a

  1   2   >