RE: [RFC] eal: add bus cleanup to eal cleanup

2022-04-19 Thread Morten Brørup
> From: Kevin Laatz [mailto:kevin.la...@intel.com] > Sent: Tuesday, 19 April 2022 18.15 > > During EAL init, all buses are probed and the devices found are > initialized. On eal_cleanup(), the inverse does not happen, meaning any > allocated memory and other configuration will not be cleaned up >

[dpdk-dev] [PATCH] common/cnxk: fix unaligned access to device memory

2022-04-19 Thread psatheesh
From: Satheesh Paul Use mbox_memcpy() instead of memcpy() to prevent unaligned access. Fixes: 1f66919817e ("common/cnxk: improve MCAM entries management") Cc: sta...@dpdk.org Signed-off-by: Satheesh Paul --- drivers/common/cnxk/roc_npc_utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: 21.11.1 patches review and test

2022-04-19 Thread Christian Ehrhardt
On Fri, Apr 1, 2022 at 12:22 PM Kevin Traynor wrote: > > Hi all, > > Here is a list of patches targeted for stable release 21.11.1. > > Please try and complete validation by April 13th. > > Please help with testing and validation of your use cases and report > any issues/results with reply-all to

[PATCH] kni: update kernel API to receive packets

2022-04-19 Thread Gagandeep Singh
API 'netif_rx_ni()' has been removed in kernel with commit: baebdf48c3600 ("net: dev: Makes sure netif_rx() can be invoked in any context.") The API netif_rx() can be used for any context to receive packets from device drivers. This patch replaces the API netif_rx_ni() with netif_rx() for kernel

RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on hotplug

2022-04-19 Thread Wang, Haiyue
> -Original Message- > From: Jeff Daly > Sent: Wednesday, April 20, 2022 01:34 > To: Wang, Haiyue ; dev@dpdk.org > Cc: sta...@dpdk.org; Yang, Qiming > Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on > hotplug > > > > > -Original Message- > > From: Wang,

Re: DPDK:20.11.1: net/ena crash while fetching xstats

2022-04-19 Thread Stephen Hemminger
On Tue, 19 Apr 2022 22:27:32 +0200 Michał Krawczyk wrote: > Thanks Stephen, indeed the issue reproduces in the secondary process. > > Basically ENA v2.2.1 is not MP aware, meaning it cannot be used safely > from the secondary process. The main obstacle is the admin queue which > is used for proc

Re: DPDK:20.11.1: net/ena crash while fetching xstats

2022-04-19 Thread Stephen Hemminger
On Tue, 19 Apr 2022 22:27:32 +0200 Michał Krawczyk wrote: > wt., 19 kwi 2022 o 17:01 Stephen Hemminger > napisał(a): > > > > On Tue, 19 Apr 2022 14:10:23 +0200 > > Michał Krawczyk wrote: > > > > > pon., 18 kwi 2022 o 17:19 Amiya Mohakud > > > napisał(a): > > > > > > > > + Megha, Sharad and

[Bug 996] DPDK:20.11.1: net/ena crash while fetching xstats

2022-04-19 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=996 Michal Krawczyk (m...@semihalf.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|

Re: DPDK:20.11.1: net/ena crash while fetching xstats

2022-04-19 Thread Michał Krawczyk
wt., 19 kwi 2022 o 17:01 Stephen Hemminger napisał(a): > > On Tue, 19 Apr 2022 14:10:23 +0200 > Michał Krawczyk wrote: > > > pon., 18 kwi 2022 o 17:19 Amiya Mohakud > > napisał(a): > > > > > > + Megha, Sharad and Eswar. > > > > > > On Mon, Apr 18, 2022 at 2:03 PM Amiya Mohakud > > > wrote: > >

RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on hotplug

2022-04-19 Thread Jeff Daly
> -Original Message- > From: Wang, Haiyue > Sent: Monday, April 18, 2022 10:05 PM > To: Jeff Daly ; dev@dpdk.org > Cc: sta...@dpdk.org; Yang, Qiming > Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on > hotplug > > Caution: This is an external email. Please take

Re: [RFC] eal: add bus cleanup to eal cleanup

2022-04-19 Thread Stephen Hemminger
On Tue, 19 Apr 2022 17:14:38 +0100 Kevin Laatz wrote: > + RTE_LOG(INFO, EAL, > + "Clean up PCI driver: %s (%x:%x) device: > "PCI_PRI_FMT" (socket %i)\n", > + drv->driver.name, dev->id.vendor_id, > dev->id.device_id, > +

Re: [PATCH 2/5] dma/idxd: fix memory leak due to free on incorrect pointer

2022-04-19 Thread Kevin Laatz
On 08/04/2022 15:52, Bruce Richardson wrote: On Fri, Apr 08, 2022 at 03:15:01PM +0100, Kevin Laatz wrote: During PCI device close, any allocated memory needs to be free'd. Currently, one of the free's is being called on an incorrect idxd_dmadev struct member, namely 'batch_idx_ring', causing a m

Re: [PATCH 3/5] app/test: close dma devices during cleanup

2022-04-19 Thread Kevin Laatz
On 08/04/2022 15:55, Bruce Richardson wrote: On Fri, Apr 08, 2022 at 03:15:02PM +0100, Kevin Laatz wrote: DMA devices are created during PCI probe of EAL init. These devices need to be closed in order to perform necessary cleanup for those devices. This patch adds the call to close() for all D

[RFC] eal: add bus cleanup to eal cleanup

2022-04-19 Thread Kevin Laatz
During EAL init, all buses are probed and the devices found are initialized. On eal_cleanup(), the inverse does not happen, meaning any allocated memory and other configuration will not be cleaned up appropriately on exit. Currently, in order for device cleanup to take place, applications must cal

Re: [PATCH] net/ice: promote dynflag API

2022-04-19 Thread Ray Kinsella
peng1x.zh...@intel.com writes: > From: Peng Zhang > > Promote dynflag APIs to be stable. > > Signed-off-by: Peng Zhang > --- > drivers/net/ice/rte_pmd_ice.h | 1 - > drivers/net/ice/version.map | 15 +-- > 2 files changed, 9 insertions(+), 7 deletions(-) > > diff --git a/driver

Re: [PATCH] doc: fix typos 'depreciated' instead of 'deprecated'

2022-04-19 Thread Ray Kinsella
Stephen Coleman writes: > From 1871ee6f7b98ef89b7c4893d90b5ea264660c201 Mon Sep 17 00:00:00 2001 > From: youcai > Date: Tue, 19 Apr 2022 14:38:36 +0800 > Subject: [PATCH] doc: fix typos 'depreciated' instead of 'deprecated' > Cc: Ray Kinsella > > Same issue was fixed in ABI policy in ec5c0f8,

Re: [PATCH v2 3/4] lib/power: add get and set API for scaling freq min and max with pstate mode

2022-04-19 Thread Ray Kinsella
Kevin Laatz writes: > Add new get/set API to allow the user or application to set the minimum > and maximum frequencies to use when scaling. > Previously, the frequency range was determined by the HW capabilities of > the CPU. With this new API, the user or application can constrain this > if r

Re: [PATCH v2 2/4] lib/power: add get and set API for pause duration

2022-04-19 Thread Ray Kinsella
Kevin Laatz writes: > Add new get/set API for configuring 'pause_duration' which used to adjust > the pause mode callback duration. > > Signed-off-by: Kevin Laatz > --- > lib/power/rte_power_pmd_mgmt.c | 26 -- > lib/power/rte_power_pmd_mgmt.h | 31

Re: [PATCH v2 1/4] lib/power: add get and set API for emptypoll max

2022-04-19 Thread Ray Kinsella
Kevin Laatz writes: > Add new get/set APIs to configure emptypoll max which is used to > determine when a queue can go into sleep state. > > Signed-off-by: Kevin Laatz > --- > lib/power/rte_power_pmd_mgmt.c | 21 ++--- > lib/power/rte_power_pmd_mgmt.h | 27

Re: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes

2022-04-19 Thread Ray Kinsella
Akhil Goyal writes: >> > Time expiry means after x seconds SA will expire. >> > Packet expiry means after x packets processing SA will expire. >> > Byte expiry means after x bytes of packet processing SA will expire. >> >> I think you should use the syntax @ref packets_soft_limit >> so it is c

Re: DPDK:20.11.1: net/ena crash while fetching xstats

2022-04-19 Thread Stephen Hemminger
On Tue, 19 Apr 2022 14:10:23 +0200 Michał Krawczyk wrote: > pon., 18 kwi 2022 o 17:19 Amiya Mohakud > napisał(a): > > > > + Megha, Sharad and Eswar. > > > > On Mon, Apr 18, 2022 at 2:03 PM Amiya Mohakud > > wrote: > >> > >> Hi Michal/DPDK-Experts, > >> > >> I am facing one issue in net/ena d

Re: [PATCH v4 09/14] bus/vmbus: open subchannels

2022-04-19 Thread Stephen Hemminger
On Mon, 18 Apr 2022 09:59:10 +0530 Srikanth Kaka wrote: > diff --git a/drivers/bus/vmbus/version.map b/drivers/bus/vmbus/version.map > index 3cadec7fae..3509d4fc14 100644 > --- a/drivers/bus/vmbus/version.map > +++ b/drivers/bus/vmbus/version.map > @@ -23,6 +23,7 @@ DPDK_22 { > rte_vmbus_su

Re: [PATCH v4 11/14] bus/vmbus: get subchannel info

2022-04-19 Thread Stephen Hemminger
On Mon, 18 Apr 2022 09:59:12 +0530 Srikanth Kaka wrote: > ice; > + char sysctlBuffer[PATH_MAX], sysctlVar[PATH_MAX]; nit. please avoid using camelCase variable names.

Re: [PATCH v4 01/14] bus/vmbus: move independent code from Linux

2022-04-19 Thread Stephen Hemminger
On Mon, 18 Apr 2022 09:59:02 +0530 Srikanth Kaka wrote: > Move the OS independent code from Linux dir in-order to be used > by FreeBSD > > Signed-off-by: Srikanth Kaka > Signed-off-by: Vag Singh > Signed-off-by: Anand Thulasiram > --- > drivers/bus/vmbus/linux/vmbus_bus.c | 13 +---

Re: [PATCH 1/7] examples/ipsec-secgw: disable Tx chksum offload for inline

2022-04-19 Thread Nithin Kumar Dabilpuram
Hi Konstantin, Please see inline. On 4/14/22 7:37 PM, Ananyev, Konstantin wrote: Hi Nithin, Enable Tx IPv4 checksum offload only when Tx inline crypto, lookaside crypto/protocol or cpu crypto is needed. For Tx Inline protocol offload, checksum computation is implicitly taken care by HW. Th

RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices

2022-04-19 Thread Wang, Haiyue
> -Original Message- > From: Morten Brørup > Sent: Tuesday, April 19, 2022 17:12 > To: Thomas Monjalon ; Daly, Jeff > ; Stephen Hemminger > > Cc: Wang, Haiyue ; dev@dpdk.org; Zhang, Qi Z > ; Mcnamara, > John > Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 device

RE: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes

2022-04-19 Thread Akhil Goyal
> > Time expiry means after x seconds SA will expire. > > Packet expiry means after x packets processing SA will expire. > > Byte expiry means after x bytes of packet processing SA will expire. > > I think you should use the syntax @ref packets_soft_limit > so it is clear where the event come from

Re: DPDK:20.11.1: net/ena crash while fetching xstats

2022-04-19 Thread Michał Krawczyk
pon., 18 kwi 2022 o 17:19 Amiya Mohakud napisał(a): > > + Megha, Sharad and Eswar. > > On Mon, Apr 18, 2022 at 2:03 PM Amiya Mohakud > wrote: >> >> Hi Michal/DPDK-Experts, >> >> I am facing one issue in net/ena driver while fetching extended stats >> (xstats). The DPDK seems to segfault with be

Re: [PATCH 1/4] lib/power: add get and set API for emptypoll max

2022-04-19 Thread Kevin Laatz
On 15/04/2022 15:43, Ray Kinsella wrote: Kevin Laatz writes: Add new get/set APIs to configure emptypoll max which is used to determine when a queue can go into sleep state. Signed-off-by: Kevin Laatz --- lib/power/rte_power_pmd_mgmt.c | 21 ++--- lib/power/rte_power_pmd_m

[PATCH v2 3/4] lib/power: add get and set API for scaling freq min and max with pstate mode

2022-04-19 Thread Kevin Laatz
Add new get/set API to allow the user or application to set the minimum and maximum frequencies to use when scaling. Previously, the frequency range was determined by the HW capabilities of the CPU. With this new API, the user or application can constrain this if required. Signed-off-by: Kevin Laa

[PATCH v2 2/4] lib/power: add get and set API for pause duration

2022-04-19 Thread Kevin Laatz
Add new get/set API for configuring 'pause_duration' which used to adjust the pause mode callback duration. Signed-off-by: Kevin Laatz --- lib/power/rte_power_pmd_mgmt.c | 26 -- lib/power/rte_power_pmd_mgmt.h | 31 +++ lib/power/version.map

[PATCH v2 4/4] examples/l3fwd_power: add cli for configurable options

2022-04-19 Thread Kevin Laatz
Add CLI options to l3fwd_power to utilize the new power APIs introduced in this patchset. These CLI options allow the user to configure the heuritstics made available through the new API via the l3fwd_power application options. Signed-off-by: Kevin Laatz --- v2: add doc update for l3fwd-power --

[PATCH v2 0/4] Add APIs for configurable power options

2022-04-19 Thread Kevin Laatz
The power library contains some variables which are currently set by defines, hard-coded values or set using sysfs values. In order to configure these, code changes and recompiles are required, making configuring these variables tedious. This patchset introduces some new get/set APIs which allow u

[PATCH v2 1/4] lib/power: add get and set API for emptypoll max

2022-04-19 Thread Kevin Laatz
Add new get/set APIs to configure emptypoll max which is used to determine when a queue can go into sleep state. Signed-off-by: Kevin Laatz --- lib/power/rte_power_pmd_mgmt.c | 21 ++--- lib/power/rte_power_pmd_mgmt.h | 27 +++ lib/power/version.map

Re: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes

2022-04-19 Thread Thomas Monjalon
19/04/2022 12:14, Akhil Goyal: > Hi Thomas, > > > 16/04/2022 21:25, Akhil Goyal: > > > --- a/lib/ethdev/rte_ethdev.h > > > +++ b/lib/ethdev/rte_ethdev.h > > > @@ -3828,6 +3828,12 @@ enum rte_eth_event_ipsec_subtype { > > > RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY, > > > /** Soft byte expiry of SA */

RE: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes

2022-04-19 Thread Anoob Joseph
Hi Thomas, Yes. The comments need to be fixed. I'll push a patch for that. Thanks for pointing out. Thanks, Anoob > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 19, 2022 4:08 PM > To: Anoob Joseph > Cc: Akhil Goyal ; dev@dpdk.org; > david.march...@redhat.com; hema

Re: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes

2022-04-19 Thread Thomas Monjalon
19/04/2022 12:19, Anoob Joseph: > Hi Thomas, Akhil, > > > Is there a reference explaining what exactly is a "soft packet expiry"? > > The SA lifetime/expiry is described in security library. > https://elixir.bootlin.com/dpdk/latest/source/lib/security/rte_security.h#L295 The comment you are refe

RE: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes

2022-04-19 Thread Anoob Joseph
Hi Thomas, Akhil, > Is there a reference explaining what exactly is a "soft packet expiry"? The SA lifetime/expiry is described in security library. https://elixir.bootlin.com/dpdk/latest/source/lib/security/rte_security.h#L295 Thanks, Anoob > -Original Message- > From: Akhil Goyal > S

RE: [EXT] Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes

2022-04-19 Thread Akhil Goyal
Hi Thomas, > 16/04/2022 21:25, Akhil Goyal: > > --- a/lib/ethdev/rte_ethdev.h > > +++ b/lib/ethdev/rte_ethdev.h > > @@ -3828,6 +3828,12 @@ enum rte_eth_event_ipsec_subtype { > > RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY, > > /** Soft byte expiry of SA */ > > RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY

[PATCH] doc: fix typos 'depreciated' instead of 'deprecated'

2022-04-19 Thread Stephen Coleman
>From 1871ee6f7b98ef89b7c4893d90b5ea264660c201 Mon Sep 17 00:00:00 2001 From: youcai Date: Tue, 19 Apr 2022 14:38:36 +0800 Subject: [PATCH] doc: fix typos 'depreciated' instead of 'deprecated' Cc: Ray Kinsella Same issue was fixed in ABI policy in ec5c0f8, but more of this misuse persist in comm

[PATCH v4 14/14] bus/vmbus: update MAINTAINERS and docs

2022-04-19 Thread Srikanth Kaka
updated MAINTAINERS and doc files for FreeBSD support Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- MAINTAINERS| 2 ++ doc/guides/nics/netvsc.rst | 11 +++ 2 files changed, 13 insertions(+) diff --git a/MAINTAINERS b/MAINTAI

[PATCH v4 13/14] bus/vmbus: add meson support for FreeBSD

2022-04-19 Thread Srikanth Kaka
add meson support for FreeBSD OS Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/bus/vmbus/meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/bus/vmbus/meson.build b/drivers/bus/vmbus/meson.build index

[PATCH v4 12/14] net/netvsc: moving hotplug retry to OS dir

2022-04-19 Thread Srikanth Kaka
Moved netvsc_hotplug_retry to respective OS dir as it contains OS dependent code. For Linux, it is copied as is and for FreeBSD it is not supported yet. Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/netvsc/freebsd/hn_os.c | 5 ++ drivers

[PATCH v4 11/14] bus/vmbus: get subchannel info

2022-04-19 Thread Srikanth Kaka
Using sysctl, all the subchannel's attributes are fetched Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/bus/vmbus/freebsd/vmbus_uio.c | 73 +++ 1 file changed, 73 insertions(+) diff --git a/drivers/bus/vmbus/freebsd/v

[PATCH v4 10/14] net/netvsc: make IOCTL call to open subchannels

2022-04-19 Thread Srikanth Kaka
make IOCTL call to open subchannels Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/netvsc/hn_ethdev.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c index 8b1e07b775.

[PATCH v4 09/14] bus/vmbus: open subchannels

2022-04-19 Thread Srikanth Kaka
In FreeBSD, unlike Linux there is no sub-channel open callback that could be called by HV_UIO driver upon their grant by the hypervisor. Thus the PMD makes an IOCTL to the HV_UIO to open the sub-channels On Linux, the vmbus_uio_subchan_open() will always return success as the Linux HV_UIO opens th

[PATCH v4 08/14] bus/vmbus: add sub-channel mapping support

2022-04-19 Thread Srikanth Kaka
To map the subchannels, an mmap request is directly made after determining the subchan memory offset Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/bus/vmbus/freebsd/vmbus_uio.c | 48 +++ 1 file changed, 48 insertions(+

[PATCH v4 07/14] net/netvsc: make event monitor OS dependent

2022-04-19 Thread Srikanth Kaka
- Event monitoring is not yet supported on FreeBSD, hence moving it to the OS specific files - Add meson support to OS environment Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/netvsc/freebsd/hn_os.c | 16 drivers/net

[PATCH v4 06/14] bus/vmbus: get device resource values using sysctl

2022-04-19 Thread Srikanth Kaka
The UIO device's attribute (relid, monitor id, etc) values are retrieved using following sysctl variables: $ sysctl dev.hv_uio.0 dev.hv_uio.0.send_buf.gpadl: 925241 dev.hv_uio.0.send_buf.size: 16777216 dev.hv_uio.0.recv_buf.gpadl: 925240 dev.hv_uio.0.recv_buf.size: 32505856 dev.hv_uio.0.monitor_pag

[PATCH v4 05/14] bus/vmbus: handle mapping of device resources

2022-04-19 Thread Srikanth Kaka
All resource values are published by HV_UIO driver as sysctl key value pairs and they are read at a later point of the code flow Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/bus/vmbus/freebsd/vmbus_bus.c | 18 ++ 1 file chang

[PATCH v4 04/14] bus/vmbus: scan and get the network device on FreeBSD

2022-04-19 Thread Srikanth Kaka
Using sysctl, all the devices on the VMBUS are identified by the PMD. On finding the Network device's device id, it is added to VMBUS dev list. Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/bus/vmbus/freebsd/vmbus_bus.c | 268

[PATCH v4 03/14] bus/vmbus: move OS independent UIO functions

2022-04-19 Thread Srikanth Kaka
Moved all Linux independent UIO functions to OSI dir. Split the vmbus_uio_map_subchan() by keeping OS dependent code in vmbus_uio_map_subchan_os() function Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/bus/vmbus/linux/vmbus_uio.c | 292 +---

[PATCH v4 02/14] bus/vmbus: move independent bus functions

2022-04-19 Thread Srikanth Kaka
move independent Linux bus functions to OSI file Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/bus/vmbus/linux/vmbus_bus.c | 15 --- drivers/bus/vmbus/osi/vmbus_osi_bus.c | 17 + 2 files changed, 17 insertions(+)

[PATCH v4 01/14] bus/vmbus: move independent code from Linux

2022-04-19 Thread Srikanth Kaka
Move the OS independent code from Linux dir in-order to be used by FreeBSD Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/bus/vmbus/linux/vmbus_bus.c | 13 + drivers/bus/vmbus/meson.build | 5 + drivers/bus/vmbus/osi

[PATCH v4 00/14] add FreeBSD support to VMBUS & NetVSC PMDs

2022-04-19 Thread Srikanth Kaka
This patchset requires FreeBSD VMBus kernel changes and HV_UIO driver. Both are currently under review at https://reviews.freebsd.org/D32184 Changelog: v4: - moved OS independent code out of Linux v3: - split the patches into further logical parts - updated docs v2: - replaced strncpy with mem

RE: [PATCH] vmbus: get current rte_vmbus_bus struct

2022-04-19 Thread Abdelfattah Chehab
The global variable is not accessible from libdpdk.so I don't really see how the linker can find it in this case. -Original Message- From: David Marchand Sent: 13 April 2022 10:11 To: Abdelfattah Chehab Cc: dev@dpdk.org; sta...@dpdk.org Subject: Re: [PATCH] vmbus: get current rte_vmbus_

Re: [PATCH v3 00/15] add FreeBSD support to VMBUS & NetVSC PMDs

2022-04-19 Thread Srikanth K
Got it, thanks! The next patchset is in progress with the fix and it also removes common code between Linux and FreeBSD. It will be submitted soon. On Thu, 14 Apr 2022, 2:24 pm Thomas Monjalon, wrote: > 17/02/2022 17:05, Srikanth Kaka: > > This patch series adds support to VMBUS & NetVSC PMDs

Re: [PATCH] net/virtio: restore some optimisations with AVX512

2022-04-19 Thread Maxime Coquelin
Hi Marvin, On 4/11/22 17:04, David Marchand wrote: Those optimisations were only enabled with make builds, fix the meson part. Fixes: 77d66da83834 ("net/virtio: add vectorized packed ring Rx") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/virtio/meson.build | 6 +++---

RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices

2022-04-19 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, 14 April 2022 19.07 > > 14/04/2022 17:43, Stephen Hemminger: > > On Thu, 14 Apr 2022 15:11:46 + > > Jeff Daly wrote: > > > From: Thomas Monjalon > > > > 14/04/2022 14:13, Wang, Haiyue: > > > > > From: Thomas Monjalon > >

Re: [PATCH] vhost: support sync copy when data buffer is small

2022-04-19 Thread Maxime Coquelin
Hi Wenwu, On 4/11/22 15:38, Wenwu Ma wrote: In async datapath, if the length of data buffer is less than 256, the data will be copied by CPU instead of DMA. Signed-off-by: Wenwu Ma --- lib/vhost/vhost.h | 6 ++- lib/vhost/virtio_net.c | 96 ++

Re: [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes

2022-04-19 Thread Thomas Monjalon
16/04/2022 21:25, Akhil Goyal: > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -3828,6 +3828,12 @@ enum rte_eth_event_ipsec_subtype { > RTE_ETH_EVENT_IPSEC_SA_TIME_EXPIRY, > /** Soft byte expiry of SA */ > RTE_ETH_EVENT_IPSEC_SA_BYTE_EXPIRY, > + /** Soft p

Re: [PATCH v2 3/4] examples/dma: support enqueue drop statistic

2022-04-19 Thread Bruce Richardson
On Sat, Apr 16, 2022 at 02:19:24PM +0800, fengchengwen wrote: > DMA is a memcopy engine, and from that perspective, I think it's appropriate > to use copy_failures when dma_enqueue fails. > > The newly added enqueue_failures is mainly used for rte_ring_enqueue_burst > failures. > > Since the app

[PATCH] net/nfp: fix the issue about set the vlan strip offload off

2022-04-19 Thread Peng Zhang
When set the vlan_strip_offload off, it doesn't work. Because we can't update the msg in the nic. This patch will fix this error. Fixes: d4a27a3b092a ("nfp: add basic features") Cc: sta...@dpdk.org Signed-off-by: Peng Zhang Signed-off-by: Yong Xu Signed-off-by: Chaoyong He --- drivers/net/nf

[PATCH v2] common/cnxk: add CNF950_A0 support

2022-04-19 Thread Tomasz Duszynski
Add PCI IDs which match CNF95O_A0 SoC. Signed-off-by: Tomasz Duszynski --- drivers/common/cnxk/roc_constants.h | 1 + drivers/event/cnxk/cn9k_eventdev.c | 2 ++ drivers/mempool/cnxk/cnxk_mempool.c | 2 ++ drivers/net/cnxk/cn9k_ethdev.c | 3 +++ 4 files changed, 8 insertions(+) diff --git

[dpdk-dev] [PATCH] examples/ipsec-secgw: support more flow patterns and actions

2022-04-19 Thread psatheesh
From: Satheesh Paul Added support to create flows with count, mark and security actions and mark pattern. The flow configuration can be done with these pattern and actions in the below format in the configuration file. flow [mark ] [eth] [ipv4 | ipv6] | \ port queue \ [count] [secur

[PATCH v4 2/2] net/ice: fix DCF reset

2022-04-19 Thread Kevin Liu
After the PF triggers the VF reset, before the VF PMD can perform any operations on the hardware, it must reinitialize the all resources. This patch adds a flag to indicate whether the VF has been reset by PF, and update the DCF resetting operations according to this flag. Fixes: 1a86f4dbdf42 ("n

[PATCH v4 1/2] net/ice: fix DCF ACL flow engine

2022-04-19 Thread Kevin Liu
From: Alvin Zhang ACL is not a necessary feature for DCF, it may not be supported by the ice kernel driver, so in this patch the program does not return the ACL initiation fails to high level functions, as substitute it prints some error logs, cleans the related resources and unregisters the ACL

[PATCH v4 0/2] fix DCF function defect

2022-04-19 Thread Kevin Liu
Some modifications of associated complete common VF features for DCF. v4: Transfer the fix patch from the feature cover-letter to here. v3: * remove patch: 1.net/ice/base: add VXLAN support for switch filter 2.net/ice: add VXLAN support for switch filter 3.common/iavf: sup

[PATCH v4 23/23] doc: update for ice DCF datapath configuration

2022-04-19 Thread Kevin Liu
Update "ice_dcf" driver feature list. Signed-off-by: Kevin Liu --- doc/guides/nics/features/ice_dcf.ini | 15 +++ 1 file changed, 15 insertions(+) diff --git a/doc/guides/nics/features/ice_dcf.ini b/doc/guides/nics/features/ice_dcf.ini index 54073f0b88..2f3e14a24e 100644 --- a/doc/

[PATCH v4 22/23] net/ice: implement power management

2022-04-19 Thread Kevin Liu
Implement support for the power management API by implementing a 'get_monitor_addr' function that will return an address of an RX ring's status bit. Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ice/ice_dcf_ethdev.c

[PATCH v4 21/23] net/ice: support queue information getting

2022-04-19 Thread Kevin Liu
Add below ops, rxq_info_get txq_info_get Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c index a4f0ec36a1..02d9bd0fa7 100644 --- a/drivers/net/ice/ice_dcf_ethde

[PATCH v4 20/23] net/ice: add extended stats

2022-04-19 Thread Kevin Liu
Add implementation of xstats() functions in DCF PMD. Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf.h| 23 +- drivers/net/ice/ice_dcf_ethdev.c | 75 2 files changed, 97 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_dcf.h b/d

[PATCH v4 19/23] net/ice: add enable/disable queues for DCF large VF

2022-04-19 Thread Kevin Liu
The current virtchnl structure for enable/disable queues only supports max 32 queue pairs. Use a new opcode and structure to indicate up to 256 queue pairs, in order to enable/disable queues in large VF case. Signed-off-by: Steve Yang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf.c

[PATCH v4 18/23] net/ice: enable IRQ mapping configuration for large VF

2022-04-19 Thread Kevin Liu
From: Steve Yang The current IRQ mapping configuration only supports max 16 queues and 16 MSIX vectors. Change the queue vector mapping structure to indicate up to 256 queues. A new opcode is used to handle the case with large number of queues. To avoid adminq buffer size limitation, we support t

[PATCH v4 17/23] net/ice: enable multiple queues configurations for large VF

2022-04-19 Thread Kevin Liu
From: Steve Yang Since the adminq buffer size has a 4K limitation, the current virtchnl command VIRTCHNL_OP_CONFIG_VSI_QUEUES cannot send the message only once to configure up to 256 queues. In this patch, we send the messages multiple times to make sure that the buffer size is less than 4K each

[PATCH v4 16/23] net/ice: negotiate large VF and request more queues

2022-04-19 Thread Kevin Liu
From: Steve Yang Negotiate large VF capability with PF during VF initialization. If large VF is supported and the number of queues larger than 16 is required, VF requests additional queues from PF. Mark the state that large VF is supported. If the allocated queues number is larger than 16, the m

[PATCH v4 15/23] net/ice: add DCF request queues function

2022-04-19 Thread Kevin Liu
From: Steve Yang Add a new virtchnl function to request additional queues from PF. Current default queue pairs number is 16. In order to support up to 256 queue pairs DCF port, enable this request queues function. Signed-off-by: Steve Yang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf.

[PATCH v4 14/23] net/ice: handle virtchnl event message without interrupt

2022-04-19 Thread Kevin Liu
From: Steve Yang Currently, VF can only handle virtchnl event message by calling interrupt. It is not available in two cases: 1. If the event message comes during VF initialization before interrupt is enabled, this message will not be handled correctly. 2. Some virtchnl commands need to receive t

[PATCH v4 13/23] net/ice: treat unknown package as OS default package

2022-04-19 Thread Kevin Liu
From: Alvin Zhang In order to use custom package, unknown package should be treated as OS default package. Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_ethdev.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/ice/ice

[PATCH v4 12/23] net/ice: support new pattern of IPv4

2022-04-19 Thread Kevin Liu
From: Alvin Zhang Add definition and pattern entry for IPv4 pattern: MAC/VLAN/IPv4 Signed-off-by: Junfeng Guo Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_switch_filter.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ice/ice_switch_filter.c

[PATCH v4 11/23] net/ice: support IPv6 NVGRE tunnel

2022-04-19 Thread Kevin Liu
From: Alvin Zhang Add protocol definition and pattern matching for IPv6 NVGRE tunnel. Signed-off-by: Junfeng Guo Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_switch_filter.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/ice/ice_switch_fil

[PATCH v4 10/23] net/ice: enable CVL DCF device reset API

2022-04-19 Thread Kevin Liu
From: Dapeng Yu Enable CVL DCF device reset API. Signed-off-by: Dapeng Yu Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf.c | 24 drivers/net/ice/ice_dcf.h | 1 + 2 files changed, 25 insertions(+) diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf

[PATCH v4 09/23] net/ice: support DCF new VLAN capabilities

2022-04-19 Thread Kevin Liu
From: Alvin Zhang The new VLAN virtchnl opcodes introduce new capabilities like VLAN filtering, stripping and insertion. The DCF needs to query the VLAN capabilities based on current device configuration firstly. DCF is able to configure inner VLAN filter when port VLAN is enabled base on negot

[PATCH v4 08/23] net/ice: support dcf VLAN filter and offload configuration

2022-04-19 Thread Kevin Liu
From: Alvin Zhang Below PMD ops are supported in this patch: .vlan_filter_set = dcf_dev_vlan_filter_set .vlan_offload_set = dcf_dev_vlan_offload_set Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 101 +++ 1 file

[PATCH v4 07/23] net/ice: support dcf MAC configuration

2022-04-19 Thread Kevin Liu
Below PMD ops are supported in this patch: .mac_addr_add = dcf_dev_add_mac_addr .mac_addr_remove = dcf_dev_del_mac_addr .set_mc_addr_list = dcf_set_mc_addr_list .mac_addr_set = dcf_dev_set_default_mac_addr Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- driv

[PATCH v4 06/23] net/ice: support dcf promisc configuration

2022-04-19 Thread Kevin Liu
From: Alvin Zhang Support configuration of unicast and multicast promisc on dcf. Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 77 ++-- drivers/net/ice/ice_dcf_ethdev.h | 3 ++ 2 files changed, 76 insertions(+), 4 delet

[PATCH v4 05/23] net/ice: add ops dev-supported-ptypes-get to dcf

2022-04-19 Thread Kevin Liu
From: Jie Wang add API "dev_supported_ptypes_get" to dcf, that dcf pmd can get ptypes through the new API. Signed-off-by: Jie Wang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 80 +++- 1 file changed, 49 insertions(+), 31 deletions(-) diff --git

[PATCH v4 04/23] net/ice: add ops MTU-SET to dcf

2022-04-19 Thread Kevin Liu
From: Jie Wang add API "mtu_set" to dcf, and it can configure the port mtu through cmdline. Signed-off-by: Jie Wang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 14 ++ drivers/net/ice/ice_dcf_ethdev.h | 6 ++ 2 files changed, 20 insertions(+) diff --git a/

[PATCH v4 03/23] net/ice: cleanup Tx buffers

2022-04-19 Thread Kevin Liu
From: Robin Zhang Add support for ops rte_eth_tx_done_cleanup in dcf Signed-off-by: Robin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c index ccad7fc30

[PATCH v4 02/23] net/ice: enable RSS HASH ops for DCF hardware

2022-04-19 Thread Kevin Liu
From: Steve Yang RSS HASH should be updated and queried by application, Add related ops ('.rss_hash_update', '.rss_hash_conf_get') for DCF. Because DCF doesn't support configure RSS HASH, only HASH key can be updated within ops '.rss_hash_update'. Signed-off-by: Steve Yang Signed-off-by: Kevin

[PATCH v4 01/23] net/ice: enable RSS RETA ops for DCF hardware

2022-04-19 Thread Kevin Liu
From: Steve Yang RSS RETA should be updated and queried by application, Add related ops ('.reta_update', '.reta_query') for DCF. Signed-off-by: Steve Yang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf.c| 2 +- drivers/net/ice/ice_dcf.h| 1 + drivers/net/ice/ice_dcf_et

[PATCH v4 00/23] complete common VF features for DCF

2022-04-19 Thread Kevin Liu
The DCF PMD support the below dev ops, dev_supported_ptypes_get dev_link_update xstats_get xstats_get_names xstats_reset promiscuous_enable promiscuous_disable allmulticast_enable allmulticast_disable mac_addr_add mac_addr_remove set_mc_addr_list vlan_filter_set vlan_offload_set mac_addr_set reta_u

[RFC v2] add support for async vhost packed ring dequeue

2022-04-19 Thread Cheng Jiang
This RFC patch implements packed ring dequeue data path for asynchronous vhost. Signed-off-by: Cheng Jiang --- It's based on the patch set: http://patchwork.dpdk.org/project/dpdk/cover/20220419034323.92820-1-xuan.d...@intel.com/ lib/vhost/virtio_net.c | 219 -