Re: [PATCH v2 1/4] eal/windows: translate Windows errors to errno-style errors

2022-04-25 Thread David Marchand
On Tue, Apr 12, 2022 at 12:44 PM Tyler Retzlaff wrote: > > Add function to translate Windows error codes to errno-style error > codes. The possible return values are chosen so that we have as > much semantical compatibility between platforms as possible. > > Signed-off-by: Narcisa Vasile > Signed

Re: [PATCH v3 2/4] eal: add basic thread ID and current thread identifier API

2022-04-25 Thread David Marchand
On Wed, Apr 13, 2022 at 9:43 AM Tyler Retzlaff wrote: > > Provide a portable type-safe thread identifier. > Provide rte_thread_self for obtaining current thread identifier. > > Signed-off-by: Narcisa Vasile > Signed-off-by: Tyler Retzlaff > --- > lib/eal/include/rte_thread.h | 22 ++

Re: [PATCH v3 3/4] eal: implement functions for get/set thread affinity

2022-04-25 Thread David Marchand
On Wed, Apr 13, 2022 at 9:43 AM Tyler Retzlaff wrote: > > Implement functions for getting/setting thread affinity. > Threads can be pinned to specific cores by setting their > affinity attribute. > > note: rte_convert_cpuset_to_affinity has a limitation that all cpus of > the set belong to the sam

Re: [PATCH v3] eal/windows: set Windows main lcore affinitization

2022-04-25 Thread David Marchand
On Thu, Apr 14, 2022 at 3:08 PM David Marchand wrote: > > On Thu, Apr 14, 2022 at 2:43 PM Tyler Retzlaff > wrote: > > > > Add missing code to affinitize main_lcore from lcore configuration. > > > > Signed-off-by: Tyler Retzlaff > Reviewed-by: David Marchand Applied, thanks. -- David Marchan

Re: [PATCH] ethdev: prohibit polling of a stopped queue

2022-04-25 Thread Thomas Monjalon
10/04/2022 23:35, Dmitry Kozlyuk: > Whether it is allowed to call Rx/Tx functions for a stopped queue > was undocumented. Some PMDs make this behavior a no-op > either by explicitly checking the queue state > or by the way how their routines are implemented or HW works. > > No-op behavior may be c

[PATCH] net/iavf: when E810 VF interrupt disable, only receive 4 packets once, fix 4 to 1.

2022-04-25 Thread Ke Zhang
For Rx-Queue Interrupt Setting, when vf rx interrupt disable(INTENA=0), there are two ways to write back descriptor to host memory: 1)Set WB_ON_ITR bit 0 to Interrupt Dynamic Control Register: Completed descriptors are posted to host memory according to the internal descriptor cache policy (in oth

Re: [PATCH v2 1/4] eal/windows: translate Windows errors to errno-style errors

2022-04-25 Thread Tyler Retzlaff
On Mon, Apr 25, 2022 at 10:25:30AM +0200, David Marchand wrote: > On Tue, Apr 12, 2022 at 12:44 PM Tyler Retzlaff > wrote: > > > > Add function to translate Windows error codes to errno-style error > > codes. The possible return values are chosen so that we have as > > much semantical compatibilit

Re: [PATCH v3 2/4] eal: add basic thread ID and current thread identifier API

2022-04-25 Thread Tyler Retzlaff
On Mon, Apr 25, 2022 at 10:26:42AM +0200, David Marchand wrote: > On Wed, Apr 13, 2022 at 9:43 AM Tyler Retzlaff > wrote: > > > > Provide a portable type-safe thread identifier. > > Provide rte_thread_self for obtaining current thread identifier. > > > > Signed-off-by: Narcisa Vasile > > Signed-o

Re: [PATCH v3 3/4] eal: implement functions for get/set thread affinity

2022-04-25 Thread Tyler Retzlaff
On Mon, Apr 25, 2022 at 10:26:58AM +0200, David Marchand wrote: > On Wed, Apr 13, 2022 at 9:43 AM Tyler Retzlaff > wrote: > > > > Implement functions for getting/setting thread affinity. > > Threads can be pinned to specific cores by setting their > > affinity attribute. > > > > note: rte_convert_

RE: [v4 1/3] ethdev: introduce protocol type based header split

2022-04-25 Thread Ding, Xuan
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Wednesday, April 20, 2022 10:40 PM > To: Ding, Xuan ; Jerin Jacob ; > Wu, WenxuanX > Cc: Thomas Monjalon ; Li, Xiaoyun > ; Singh, Aman Deep ; > Zhang, Yuying ; Zhang, Qi Z > ; dpdk-dev ; Stephen Hemminger > ; Morten Brørup

[PATCH 0/2] net/mlx5: LRO fixes

2022-04-25 Thread Michael Baum
Independent fixes about LRO supporting. Michael Baum (2): net/mlx5: fix miss LRO validation in RxQ setup net/mlx5: fix LRO configuration in drop RxQ drivers/net/mlx5/mlx5_devx.c | 5 +++-- drivers/net/mlx5/mlx5_rxq.c | 8 2 files changed, 11 insertions(+), 2 deletions(-) -- 2.25.

[PATCH 1/2] net/mlx5: fix miss LRO validation in RxQ setup

2022-04-25 Thread Michael Baum
The mlx5_rx_queue_setup() gets from user the LRO offload. When LRO is configured, the LRO flag in rxq_data is set to 1. This patch adds validation to make sure the LRO is supported. Fixes: 17ed314 ("net/mlx5: allow LRO per Rx queue") Cc: ma...@mellanox.com Cc: sta...@dpdk.org Signed-off-by: Mic

[PATCH 2/2] net/mlx5: fix LRO configuration in drop RxQ

2022-04-25 Thread Michael Baum
The driver wrongly set the LRO configurations to the TIR of the DevX drop queue even when LRO is not supported. Actually, the LRO configuration is not relevant to the drop queue at all. This causes failure in the initialization of the device, which doesn't support LRO where the drop queue is creat

RE: [PATCH 1/3] ethdev: fix telemetry xstats return null with some PMDs

2022-04-25 Thread Morten Brørup
> From: fengchengwen [mailto:fengcheng...@huawei.com] > Sent: Sunday, 24 April 2022 05.45 > > The root cause is: when the xstats is NULL and n less than required > number of > elements is zero, the return value of rte_eth_xstats_get is ambiguous > from > rte_ethdev.h's declaration. > > But the im

RE: [PATCH v2 3/5] net/vhost: move to Vhost library stats API

2022-04-25 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, March 24, 2022 8:47 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com; i.maxim...@ovn.org > Cc: Maxime Coquelin > Subject: [PATCH v2 3/5] net/vhost: move to Vhost library stats API > > Now that we h

RE: [PATCH v2 4/5] vhost: add statistics for guest notifications

2022-04-25 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Thursday, March 24, 2022 8:47 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com; i.maxim...@ovn.org > Cc: Maxime Coquelin > Subject: [PATCH v2 4/5] vhost: add statistics for guest notifications > > This patch adds a new

RE: [PATCH v2 5/5] vhost: add statistics for IOTLB

2022-04-25 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, March 24, 2022 8:47 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com; i.maxim...@ovn.org > Cc: Maxime Coquelin > Subject: [PATCH v2 5/5] vhost: add statistics for IOTLB > > This patch adds statisti

RE: [PATCH v4 00/10] app/test: add inline IPsec and reassembly cases

2022-04-25 Thread Poczatek, Jakub
Hi everyone, When running inline_ipsec_autotest, tests should be marked as "skipped" rather than "failed". Kind Regards, Jakub Poczatek -Original Message- From: Akhil Goyal Sent: Saturday 16 April 2022 20:25 To: dev@dpdk.org Cc: tho...@monjalon.net; david.march...@redhat.com; heman

RE: [PATCH v6 03/16] vhost: add vhost msg support

2022-04-25 Thread Xia, Chenbo
Hi Andy, > -Original Message- > From: Pei, Andy > Sent: Thursday, April 21, 2022 4:34 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng > Subject: [PATCH v6 03/16] vhost: add vhost msg support > > Add support for VHOST_USER_GET_CONFIG and

[PATCH 1/2] vhost: remove unneeded max enums

2022-04-25 Thread David Marchand
Move message handler description and callbacks into a single array and remove unneeded VHOST_USER_MAX and VHOST_SLAVE_MAX enums. Signed-off-by: David Marchand --- drivers/net/virtio/virtio_user/vhost_user.c | 1 - examples/vhost_blk/blk_spec.h | 1 - lib/vhost/vhost_user.c

[PATCH 2/2] vhost: validate fds attached to messages

2022-04-25 Thread David Marchand
Some message handlers do not expect any file descriptor attached as ancillary data. Provide a common way to enforce this by adding a accepts_fd boolean in the message handler structure. When a message handler sets accepts_fd to true, it is responsible for calling validate_msg_fds with a right expec

RE: [PATCH v6 05/16] vdpa/ifc: add vDPA interrupt for blk device

2022-04-25 Thread Xia, Chenbo
Hi Andy, > -Original Message- > From: Pei, Andy > Sent: Thursday, April 21, 2022 4:34 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng > Subject: [PATCH v6 05/16] vdpa/ifc: add vDPA interrupt for blk device > > For the block device type,

Re: [PATCH v6 03/16] vhost: add vhost msg support

2022-04-25 Thread David Marchand
On Thu, Apr 21, 2022 at 11:20 AM Andy Pei wrote: > diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c > index 1d39067..3780804 100644 > --- a/lib/vhost/vhost_user.c > +++ b/lib/vhost/vhost_user.c > @@ -80,6 +80,8 @@ > [VHOST_USER_NET_SET_MTU] = "VHOST_USER_NET_SET_MTU", >

RE: [PATCH v6 06/16] vdpa/ifc: add block device SW live-migration

2022-04-25 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Thursday, April 21, 2022 4:34 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng > Subject: [PATCH v6 06/16] vdpa/ifc: add block device SW live-migration > > Add SW live-migration support to bl

RE: [PATCH v2 5/7] vdpa/mlx5: cache and reuse hardware resources

2022-04-25 Thread Xueming(Steven) Li
Hi Maxime, Thanks for the suggestion, I'll send out a new version. Regards, Xueming Li > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, April 20, 2022 11:03 PM > To: Xueming(Steven) Li ; dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > Subject: Re: [PATCH v2 5/7] vdpa/

RE: [PATCH v6 07/16] examples/vdpa: add vDPA blk support in example

2022-04-25 Thread Xia, Chenbo
Hi Andy, > -Original Message- > From: Pei, Andy > Sent: Thursday, April 21, 2022 4:34 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng > Subject: [PATCH v6 07/16] examples/vdpa: add vDPA blk support in example > > Add virtio blk device s

Re: 21.11.1 patches review and test

2022-04-25 Thread Kevin Traynor
On 20/04/2022 06:50, Christian Ehrhardt wrote: On Fri, Apr 1, 2022 at 12:22 PM Kevin Traynor wrote: Hi all, Here is a list of patches targeted for stable release 21.11.1. Please try and complete validation by April 13th. Please help with testing and validation of your use cases and report an

RE: [PATCH v6 08/16] usertools: add support for virtio blk device

2022-04-25 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Thursday, April 21, 2022 4:34 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng > Subject: [PATCH v6 08/16] usertools: add support for virtio blk device > > Add virtio blk device support to de

[Bug 992] [dpdk 21.11.1-rc1] drivers/net/cnxk/cnxk_ethdev_mtr meson build failed with cflag param optimization=1 on Ubuntu20.04 with GCC10.3

2022-04-25 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=992 Kevin Traynor (ktray...@redhat.com) changed: What|Removed |Added Resolution|--- |FIXED Status|UNC

RE: [v4 1/3] ethdev: introduce protocol type based header split

2022-04-25 Thread Ding, Xuan
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Wednesday, April 20, 2022 11:48 PM > To: Ding, Xuan ; Wu, WenxuanX > ; tho...@monjalon.net; Li, Xiaoyun > ; Singh, Aman Deep ; > Zhang, Yuying ; Zhang, Qi Z > Cc: dev@dpdk.org; step...@networkplumber.org; > m...@smartshares

Re: 21.11.1 patches review and test

2022-04-25 Thread Kevin Traynor
On 14/04/2022 05:58, Jiang, YuX wrote: -Original Message- From: Jiang, YuX Sent: Tuesday, April 12, 2022 4:59 PM To: Kevin Traynor ; sta...@dpdk.org Cc: dev@dpdk.org; Abhishek Marathe ; Ali Alnubani ; Walker, Benjamin ; David Christensen ; hariprasad.govindhara...@intel.com; Hemant Agrawa

RE: [v4 1/3] ethdev: introduce protocol type based header split

2022-04-25 Thread Ding, Xuan
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Thursday, April 21, 2022 6:28 PM > To: Andrew Rybchenko ; Wu, WenxuanX > ; Li, Xiaoyun ; Singh, > Aman Deep ; Zhang, Yuying > ; Zhang, Qi Z ; > dev@dpdk.org > Cc: dev@dpdk.org; step...@networkplumber.org; > m...@smartsharesys

OVS DPDK DMA-Dev library/Design Discussion

2022-04-25 Thread Mcnamara, John
BEGIN:VCALENDAR METHOD:REQUEST PRODID:Microsoft Exchange Server 2010 VERSION:2.0 BEGIN:VTIMEZONE TZID:GMT Standard Time BEGIN:STANDARD DTSTART:16010101T02 TZOFFSETFROM:+0100 TZOFFSETTO:+ RRULE:FREQ=YEARLY;INTERVAL=1;BYDAY=-1SU;BYMONTH=10 END:STANDARD BEGIN:DAYLIGHT DTSTART:16010101T01 T

Re: [PATCH 2/2] app/testpmd: fix incorrect MTU verification

2022-04-25 Thread Singh, Aman Deep
On 4/6/2022 2:15 PM, Min Hu (Connor) wrote: From: Huisong Li The macro RTE_ETHER_MIN_LEN isn't the minimum value of MTU. But testpmd used it when execute 'port config mtu 0 xx' cmd. This patch fix it. Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length") Cc: sta...@dpdk.org Signed-off-by

Minutes of Technical Board Meeting, 2022-April-20

2022-04-25 Thread Ananyev, Konstantin
Minutes of Technical Board Meeting, 2022-April-20 Members Attending --- -Aaron -Bruce -Hemant -Honnappa -Jerin -Konstantin (chair) -Maxime -Stephen -Thomas NOTE: The technical board meetings are on every second Wednesday at https://meet.jit.si/DPDK at 3 pm UTC. Meetings

Re: OVS DPDK DMA-Dev library/Design Discussion

2022-04-25 Thread Ilya Maximets
On 4/20/22 18:41, Mcnamara, John wrote: >> -Original Message- >> From: Ilya Maximets >> Sent: Friday, April 8, 2022 10:58 AM >> To: Hu, Jiayu ; Maxime Coquelin >> ; Van Haaren, Harry >> ; Morten Brørup ; >> Richardson, Bruce >> Cc: i.maxim...@ovn.org; Pai G, Sunil ; Stokes, Ian >> ; Ferri

[Bug 992] [dpdk 21.11.1-rc1] drivers/net/cnxk/cnxk_ethdev_mtr meson build failed with cflag param optimization=1 on Ubuntu20.04 with GCC10.3

2022-04-25 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=992 gaodaxue (daxuex@intel.com) changed: What|Removed |Added Status|VERIFIED|UNCONFIRMED Resolution|F

[Bug 992] [dpdk 21.11.1-rc1] drivers/net/cnxk/cnxk_ethdev_mtr meson build failed with cflag param optimization=1 on Ubuntu20.04 with GCC10.3

2022-04-25 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=992 gaodaxue (daxuex@intel.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

RE: [RFC 0/6] net/mlx5: introduce limit watermark and host shaper

2022-04-25 Thread Spike Du
Hi Jerin, Thanks for your comments and sorry for the late response. For case one, I think I can refine the design and add LWM(limit watermark) in rte_eth_rxconf, and add a new rte_eth_event_type event. For case two(host shaper), I think we can't use RX meter, becau

[PATCH v5 0/5] add telemetry command for show module EEPROM

2022-04-25 Thread Robin Zhang
Introduce a new telemetry command /ethdev/module_eeprom to show module EEPROM for each port. The format of module EEPROM information follows the SFF(Small Form Factor) Committee specifications. Current the format support SFP(Small Formfactor Pluggable)/SFP+/ QSFP+(Quad Small Formfactor Pluggable)/

[PATCH v5 1/5] ethdev: add telemetry command for module EEPROM

2022-04-25 Thread Robin Zhang
Add a new telemetry command /ethdev/module_eeprom to dump the module EEPROM of each port. The format of module EEPROM information follows the SFF(Small Form Factor) Committee specifications. Current the format support SFP(Small Formfactor Pluggable)/SFP+/ QSFP+(Quad Small Formfactor Pluggable)/QSF

[PATCH v5 2/5] ethdev: common utilities for different SFF specs

2022-04-25 Thread Robin Zhang
This patch implements SFF-8024 Rev 4.0 of pluggable I/O configuration and some common utilities for SFF-8436/8636 and SFF-8472/8079. Signed-off-by: Robin Zhang --- lib/ethdev/meson.build | 1 + lib/ethdev/sff_common.c | 326 lib/ethdev/sff_common.h | 1

[PATCH v5 3/5] ethdev: format module EEPROM for SFF-8079

2022-04-25 Thread Robin Zhang
This patch implements format module EEPROM information for SFF-8079 Rev 1.7 Signed-off-by: Robin Zhang --- lib/ethdev/ethdev_sff_telemetry.c | 3 + lib/ethdev/meson.build| 1 + lib/ethdev/sff_8079.c | 407 ++ 3 files changed, 411 insertions

[PATCH v5 4/5] ethdev: format module EEPROM for SFF-8472

2022-04-25 Thread Robin Zhang
This patch implements format module EEPROM information for SFF-8472 Rev 12.0 Signed-off-by: Robin Zhang --- lib/ethdev/ethdev_sff_telemetry.c | 4 + lib/ethdev/meson.build| 1 + lib/ethdev/sff_8472.c | 287 ++ 3 files changed, 292 insertion

[PATCH v5 5/5] ethdev: format module EEPROM for SFF-8636

2022-04-25 Thread Robin Zhang
This patch implements format module EEPROM information for SFF-8636 Rev 2.7 Signed-off-by: Robin Zhang --- lib/ethdev/ethdev_sff_telemetry.c | 4 + lib/ethdev/meson.build| 1 + lib/ethdev/sff_8636.c | 775 ++ lib/ethdev/sff_8636.h

[PATCH] eventdev/timer_adapter: add telemetry support

2022-04-25 Thread Ankur Dwivedi
Adds telemetry support to get timer adapter info and timer adapter statistics. Signed-off-by: Ankur Dwivedi Reviewed-by: Jerin Jacob Kollanukkaran --- lib/eventdev/rte_event_timer_adapter.c | 91 ++ 1 file changed, 91 insertions(+) diff --git a/lib/eventdev/rte_event_ti

RE: [PATCH v6 08/16] usertools: add support for virtio blk device

2022-04-25 Thread Pei, Andy
Hi Chenbo, Thanks for your reply. I will send out a new version, and put blk device into misc devices. > -Original Message- > From: Xia, Chenbo > Sent: Monday, April 25, 2022 9:53 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng ; david.mar

[PATCH] doc: update matching versions in ice guide

2022-04-25 Thread Qiming Yang
Add recommended matching list for ice PMD in DPDK 22.03. Cc: sta...@dpdk.org Signed-off-by: Qiming Yang --- doc/guides/nics/ice.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index a1780c46c3..6b903b9bbc 100644 --- a/doc/guides/nics/i

[PATCH] doc: update matching versions in i40e guide

2022-04-25 Thread Qiming Yang
Add recommended matching list for i40e PMD in DPDK 21.05, 21.08, 21.11 and 22.03. Cc: sta...@dpdk.org Signed-off-by: Qiming Yang --- doc/guides/nics/i40e.rst | 16 1 file changed, 16 insertions(+) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index ef91b3a1a

Re: [PATCH v2] test/bpf: skip test if libpcap is unavailable

2022-04-25 Thread Tyler Retzlaff
On Tue, Mar 22, 2022 at 11:50:33AM +, Ananyev, Konstantin wrote: > Acked-by: Konstantin Ananyev > Acked-by: Stephen Hemminger is there something more being requested here? the patch has been acked with no further comments for more than a month. this patch is blocking enablement of the UT f