回复: [PATCH v1 3/5] ethdev: add API for direct rearm mode

2022-04-28 Thread Feifei Wang
> -邮件原件- > 发件人: Stephen Hemminger > 发送时间: Thursday, April 21, 2022 10:58 PM > 收件人: Feifei Wang > 抄送: tho...@monjalon.net; Ferruh Yigit ; Andrew > Rybchenko ; Ray Kinsella > ; dev@dpdk.org; nd ; Honnappa > Nagarahalli ; Ruifeng Wang > > 主题: Re: [PATCH v1 3/5] ethdev: add API for direct

回复: [PATCH v1 3/5] ethdev: add API for direct rearm mode

2022-04-28 Thread Feifei Wang
> -邮件原件- > 发件人: Andrew Rybchenko > 发送时间: Wednesday, April 20, 2022 6:41 PM > 收件人: Feifei Wang ; tho...@monjalon.net; > Ferruh Yigit ; Ray Kinsella > 抄送: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; Ruifeng Wang > 主题: Re: [PATCH v1 3/5] ethdev: add API for direct rearm mode > > On 4/20/

RE: [EXT] [PATCH v4 0/3] cryptodev: move dh type from xform to dh op

2022-04-28 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Wednesday, April 27, 2022 5:58 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v4 0/3] cryptodev: move dh type from xform to dh op > > Hi Arek, > > Operation type (PUBLIC_KEY_GENERATION, SHAR

[dpdk-dev][PATCH] test/crypto-perf: extend asymmetric crypto throughput test

2022-04-28 Thread kirankumark
From: Kiran Kumar K Extended support for asymmetric crypto perf throughput test. Added support for new modulus lengths. Added new parameter --modex-len. Supported lengths are 60, 128, 255, 448. Default length is 128. Signed-off-by: Kiran Kumar K --- app/test-crypto-perf/cperf_ops.c

RE: [PATCH 2/2] app/crypto-perf: add vector file for AES-GCM

2022-04-28 Thread Akhil Goyal
> Subject: [PATCH 2/2] app/crypto-perf: add vector file for AES-GCM > > Added test vector file for AES-128-GCM for > 64B and 512B length buffers. > > Signed-off-by: Archana Muniganti >From where are these vectors taken?

RE: [PATCH 1/2] app/crypto-perf: populate mbuf in latency test

2022-04-28 Thread Akhil Goyal
> Subject: [PATCH 1/2] app/crypto-perf: populate mbuf in latency test > > For decrypt, ICV mismatch can come as data is dummy and > latency will be calculated for error path. Hence populate > mbuf with test vector data. > > Signed-off-by: Archana Muniganti Acked-by: Akhil Goyal

RE: [RFC 0/6] net/mlx5: introduce limit watermark and host shaper

2022-04-28 Thread Spike Du
Hi Jerin, Thanks for your comments and sorry for the late response. For case one, I think I can refine the design and add LWM(limit watermark) in rte_eth_rxconf, and add a new rte_eth_event_type event. For case two(host shaper), I think we can't use RX meter, becau

RE: [PATCH] ci: do not dump error logs in GHA containers

2022-04-28 Thread Honnappa Nagarahalli
> > On Tue, Apr 26, 2022 at 5:05 PM Aaron Conole > wrote: > > > > > > TBH, I did not test Travis by lack of interest (plus I don't want to > > > be bothered with their ui / credit stuff). > > > We could consider dropping Travis in the near future. > > > > > > Opinions? > > > > I think it makes

RE: [PATCH] doc: describe ixgbe devargs fiber_sdp3_no_tx_disable

2022-04-28 Thread Zhang, Qi Z
> -Original Message- > From: Jeff Daly > Sent: Wednesday, April 27, 2022 10:21 PM > To: Wang, Haiyue > Cc: dev@dpdk.org > Subject: [PATCH] doc: describe ixgbe devargs fiber_sdp3_no_tx_disable > > The devargs option for the IXGBE driver is introduced in order to inform the > driver to

RE: [PATCH v3 0/3] net/iavf: support Rx timestamp on flex descriptor

2022-04-28 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Thursday, April 28, 2022 4:14 PM > To: Zhang, Qi Z ; Yang, Qiming > Cc: dev@dpdk.org; Wu, Wenjun1 ; Su, Simei > > Subject: [PATCH v3 0/3] net/iavf: support Rx timestamp on flex descriptor > > [PATCH v3 1/3] add related ops and structure

回复: [PATCH v1 3/5] ethdev: add API for direct rearm mode

2022-04-28 Thread Feifei Wang
> -邮件原件- > 发件人: Morten Brørup > 发送时间: Wednesday, April 20, 2022 5:59 PM > 收件人: Feifei Wang ; tho...@monjalon.net; > Ferruh Yigit ; Andrew Rybchenko > ; Ray Kinsella > 抄送: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; Ruifeng Wang > 主题: RE: [PATCH v1 3/5] ethdev: add API for direct rearm

RE: [PATCH v7 00/12] complete common VF features for DCF

2022-04-28 Thread Zhang, Qi Z
> -Original Message- > From: Liu, KevinX > Sent: Friday, April 29, 2022 5:20 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Yang, SteveX ; Liu, KevinX > > Subject: [PATCH v7 00/12] complete common VF features for DCF > > The DCF PMD support the below dev ops, > dev_support

[PATCH v7 12/12] net/ice: support DCF new VLAN capabilities

2022-04-28 Thread Kevin Liu
From: Alvin Zhang The new VLAN virtchnl opcodes introduce new capabilities like VLAN filtering, stripping and insertion. The DCF needs to query the VLAN capabilities based on current device configuration firstly. DCF is able to configure inner VLAN filter when port VLAN is enabled base on negot

[PATCH v7 11/12] net/ice: add implement power management

2022-04-28 Thread Kevin Liu
Implement support for the power management API by implementing a 'get_monitor_addr' function that will return an address of an RX ring's status bit. Signed-off-by: Kevin Liu --- doc/guides/nics/features/ice_dcf.ini | 1 + drivers/net/ice/ice_dcf_ethdev.c | 1 + 2 files changed, 2 insertions(

[PATCH v7 08/12] net/ice: support dcf VLAN filter and offload configuration

2022-04-28 Thread Kevin Liu
From: Alvin Zhang Below PMD ops are supported in this patch: .vlan_filter_set = dcf_dev_vlan_filter_set .vlan_offload_set = dcf_dev_vlan_offload_set Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- doc/guides/nics/features/ice_dcf.ini | 2 + doc/guides/rel_notes/release_22

[PATCH v7 10/12] net/ice: support queue information getting

2022-04-28 Thread Kevin Liu
Add below ops, rxq_info_get txq_info_get Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c index 6503700e02..9217392d04 100644 --- a/drivers/net/ice/ice_dcf_ethde

[PATCH v7 09/12] net/ice: add extended stats

2022-04-28 Thread Kevin Liu
Add implementation of xstats() functions in DCF PMD. Signed-off-by: Kevin Liu --- doc/guides/nics/features/ice_dcf.ini | 1 + drivers/net/ice/ice_dcf.h| 22 drivers/net/ice/ice_dcf_ethdev.c | 75 3 files changed, 98 insertions(+) diff --git

[PATCH v7 07/12] net/ice: support dcf MAC configuration

2022-04-28 Thread Kevin Liu
Below PMD ops are supported in this patch: .mac_addr_add = dcf_dev_add_mac_addr .mac_addr_remove = dcf_dev_del_mac_addr .set_mc_addr_list = dcf_set_mc_addr_list .mac_addr_set = dcf_dev_set_default_mac_addr Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- doc/

[PATCH v7 06/12] net/ice: support dcf promisc configuration

2022-04-28 Thread Kevin Liu
From: Alvin Zhang Support configuration of unicast and multicast promisc on dcf. Signed-off-by: Alvin Zhang Signed-off-by: Kevin Liu --- doc/guides/nics/features/ice_dcf.ini | 2 + doc/guides/rel_notes/release_22_07.rst | 1 + drivers/net/ice/ice_dcf_ethdev.c | 77 ++

[PATCH v7 05/12] net/ice: add ops dev-supported-ptypes-get to dcf

2022-04-28 Thread Kevin Liu
From: Jie Wang add API "dev_supported_ptypes_get" to dcf, that dcf pmd can get ptypes through the new API. Signed-off-by: Jie Wang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 80 +++- 1 file changed, 49 insertions(+), 31 deletions(-) diff --git

[PATCH v7 04/12] net/ice: support for MTU configure in DCF mode

2022-04-28 Thread Kevin Liu
From: Jie Wang add API "mtu_set" to dcf, and it can configure the port mtu through cmdline. Signed-off-by: Jie Wang Signed-off-by: Kevin Liu --- doc/guides/nics/features/ice_dcf.ini | 1 + doc/guides/rel_notes/release_22_07.rst | 1 + drivers/net/ice/ice_dcf_ethdev.c | 14 ++

[PATCH v7 03/12] net/ice: support cleanup Tx buffers in DCF mode

2022-04-28 Thread Kevin Liu
From: Robin Zhang Add support for ops rte_eth_tx_done_cleanup in dcf Signed-off-by: Robin Zhang Signed-off-by: Kevin Liu --- drivers/net/ice/ice_dcf_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c index ccad7fc30

[PATCH v7 02/12] net/ice: support for RSS HASH configure in DCF mode

2022-04-28 Thread Kevin Liu
From: Steve Yang RSS HASH should be updated and queried by application, Add related ops ('.rss_hash_update', '.rss_hash_conf_get') for DCF. Because DCF doesn't support configure RSS HASH, only HASH key can be updated within ops '.rss_hash_update'. Signed-off-by: Steve Yang Signed-off-by: Kevin

[PATCH v7 01/12] net/ice: support for RSS RETA configure in DCF mode

2022-04-28 Thread Kevin Liu
From: Steve Yang RSS RETA should be updated and queried by application, Add related ops ('.reta_update', '.reta_query') for DCF. Signed-off-by: Steve Yang Signed-off-by: Kevin Liu --- doc/guides/nics/features/ice_dcf.ini | 1 + doc/guides/rel_notes/release_22_07.rst | 3 + drivers/net/ice

[PATCH v7 00/12] complete common VF features for DCF

2022-04-28 Thread Kevin Liu
The DCF PMD support the below dev ops, dev_supported_ptypes_get dev_link_update xstats_get xstats_get_names xstats_reset promiscuous_enable promiscuous_disable allmulticast_enable allmulticast_disable mac_addr_add mac_addr_remove set_mc_addr_list vlan_filter_set vlan_offload_set mac_addr_set reta_u

RE: [PATCH] examples/ipsec-secgw: fix promiscuous mode option

2022-04-28 Thread Akhil Goyal
> Currently default value of promiscuous mode flag is true and > even there is command line argument to set it to true. > So it never is in non-promiscuous mode. Fix it by > changing default value to false. > > Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application") > Cc: sergio

Re: librte_bpf: roadmap or any specific plans for this library

2022-04-28 Thread Konstantin Ananyev
Hi Bjorn, > Hi all, > I hope this is the correct maillist for this topic. > > DPDK provides the nice library `librte_bpf` to load and execute eBPF bytecode > and we would like to broaden our usage of this library. Great to hear :) > Today there are hints that this library might have been purp

RE: [EXT] [dpdk-dev] [PATCH v1 1/1] compress/octeontx: add octeontx2 SoC family support

2022-04-28 Thread Ashish Gupta
> -Original Message- > From: Mahipal Challa > Sent: Monday, February 28, 2022 9:11 AM > To: dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya > Subject: [EXT] [dpdk-dev] [PATCH v1 1/1] compress/octeontx: add octeontx2 > SoC family support > > External Email

[PATCH V4] net/mlx5: support ESP SPI match and RSS hash

2022-04-28 Thread Raja Zidane
In packets with ESP header, The Inner IP will be encrypted, and its fields cannot be used for RSS hashing. So, ESP packets can be hashed only by the outer IP layer. So, when using RSS on ESP packets, hashing may not be efficient, because the fields used by the hash functions are only the Outer IPs,

[PATCH] examples/ipsec-secgw: fix promiscuous mode option

2022-04-28 Thread Nithin Dabilpuram
Currently default value of promiscuous mode flag is true and even there is command line argument to set it to true. So it never is in non-promiscuous mode. Fix it by changing default value to false. Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application") Cc: sergio.gonzalez.mon.

RE: [PATCH v3 6/7] test/event: add asymmetric cases for crypto adapter

2022-04-28 Thread Gujjar, Abhinandan S
This is failing with asym changes. Please look into this. root@xdp-dev:/home/intel/abhi/dpdk-next-eventdev/abhi# ./app/test/dpdk-test EAL: Detected CPU lcores: 96 EAL: Detected NUMA nodes: 2 EAL: Detected static linkage of DPDK EAL: Multi-process socket /var/run/dpdk/rte/mp_socket EAL: Selected IO

Re: Undefined reference to symbol while compiling DPPD-PROX

2022-04-28 Thread Stephen Hemminger
On Thu, 28 Apr 2022 06:32:14 + "Avijit Pandey" wrote: > I have OS: Ubuntu 20.04 with kernel: 5.4.0-42-generic > > Built DPDK from the following steps: > > cd /opt > export RTE_SDK="/opt/dpdk" > export RTE_TARGET="x86_64-native-linuxapp-gcc" > export PKG_CONFIG_PATH="/usr/local/lib/x86_64-l

RE: [PATCH v3 5/7] eventdev: use new API to get event crypto metadata

2022-04-28 Thread Gujjar, Abhinandan S
Acked-by: Abhinandan Gujjar > -Original Message- > From: Akhil Goyal > Sent: Thursday, April 21, 2022 8:07 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; jer...@marvell.com; Gujjar, Abhinandan S > ; Jayatheerthan, Jay > ; Vangati, Narender > ; vfia...@marvell.com; Akhil Goyal > > Subje

[PATCH v3 7/7] examples/ipsec-secgw: add poll mode worker for inline proto

2022-04-28 Thread Nithin Dabilpuram
Add separate worker thread when all SA's are of type inline protocol offload and librte_ipsec is enabled in order to make it more optimal for that case. Current default worker supports all kinds of SA leading to doing lot of per-packet checks and branching based on SA type which can be of 5 types o

[PATCH v3 6/7] examples/ipsec-secgw: update eth header during route lookup

2022-04-28 Thread Nithin Dabilpuram
Update ethernet header during route lookup instead of doing way later while performing Tx burst. Advantages to doing is at route lookup is that no additional IP version checks based on packet data are needed and packet data is already in cache as route lookup is already consuming that data. This i

[PATCH v3 5/7] examples/ipsec-secgw: get security context from lcore conf

2022-04-28 Thread Nithin Dabilpuram
Store security context pointer in lcore Rx queue config and get it from there in fast path for better performance. Currently rte_eth_dev_get_sec_ctx() which is meant to be control path API is called per packet basis. For every call to that API, ethdev port status is checked. Signed-off-by: Nithin

[PATCH v3 4/7] examples/ipsec-secgw: allow larger burst size for vectors

2022-04-28 Thread Nithin Dabilpuram
Allow larger burst size of vector event mode instead of restricting to 32. Also restructure traffic type struct to have num pkts first so that it is always in first cacheline. Also cache align traffic type struct. Since MAX_PKT_BURST is not used by vector event mode worker, define another macro for

[PATCH v3 3/7] examples/ipsec-secgw: use HW parsed packet type in poll mode

2022-04-28 Thread Nithin Dabilpuram
Use HW parsed packet type when ethdev supports necessary protocols. If packet type is not supported, then register ethdev callbacks for parse packet in SW. This is better for performance as it effects fast path. Signed-off-by: Nithin Dabilpuram --- examples/ipsec-secgw/ipsec-secgw.c | 157 +

[PATCH v3 2/7] examples/ipsec-secgw: disable Tx chksum offload for inline

2022-04-28 Thread Nithin Dabilpuram
Enable Tx IPv4 checksum offload only when Tx inline crypto, lookaside crypto/protocol or cpu crypto is needed. For Tx Inline protocol offload, checksum computation is implicitly taken care by HW. Signed-off-by: Nithin Dabilpuram --- examples/ipsec-secgw/ipsec-secgw.c | 3 --- examples/ipsec-sec

[PATCH v3 1/7] examples/ipsec-secgw: move fast path helper functions

2022-04-28 Thread Nithin Dabilpuram
Move fast path helper functions to header file for easy access. Signed-off-by: Nithin Dabilpuram --- v3: - In patch 7/7, in Inline Protocol single sa mode's worker thread, further reduce processing by getting the proto from the Single outbound SA flags. Keep processing as minimal as possible

RE: [PATCH v3 4/7] test/event: use new API to set event crypto metadata

2022-04-28 Thread Gujjar, Abhinandan S
Acked-by: Abhinandan Gujjar > -Original Message- > From: Akhil Goyal > Sent: Thursday, April 21, 2022 8:07 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; jer...@marvell.com; Gujjar, Abhinandan S > ; Jayatheerthan, Jay > ; Vangati, Narender > ; vfia...@marvell.com; Akhil Goyal > > Subje

RE: [PATCH v3 1/7] cryptodev: add APIs to get/set event metadata

2022-04-28 Thread Gujjar, Abhinandan S
> -Original Message- > From: Akhil Goyal > Sent: Thursday, April 21, 2022 8:07 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; jer...@marvell.com; Gujjar, Abhinandan S > ; Jayatheerthan, Jay > ; Vangati, Narender > ; vfia...@marvell.com; Akhil Goyal > > Subject: [PATCH v3 1/7] cryptode

RE: [PATCH v3 0/7] Add new cryptodev op for event metadata

2022-04-28 Thread Gujjar, Abhinandan S
Acked-by: Abhinandan Gujjar > -Original Message- > From: Akhil Goyal > Sent: Thursday, April 21, 2022 8:07 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; jer...@marvell.com; Gujjar, Abhinandan S > ; Jayatheerthan, Jay > ; Vangati, Narender > ; vfia...@marvell.com; Akhil Goyal > > Subje

Re: OVS DPDK DMA-Dev library/Design Discussion

2022-04-28 Thread Bruce Richardson
On Thu, Apr 28, 2022 at 02:59:37PM +0200, Ilya Maximets wrote: > On 4/27/22 22:34, Bruce Richardson wrote: > > On Mon, Apr 25, 2022 at 11:46:01PM +0200, Ilya Maximets wrote: > >> On 4/20/22 18:41, Mcnamara, John wrote: > -Original Message- > From: Ilya Maximets > Sent: Frida

RE: [PATCH 1/3] ethdev: fix telemetry xstats return null with some PMDs

2022-04-28 Thread Morten Brørup
> From: fengchengwen [mailto:fengcheng...@huawei.com] > Sent: Thursday, 28 April 2022 15.39 > > On 2022/4/25 18:16, Morten Brørup wrote: > >> From: fengchengwen [mailto:fengcheng...@huawei.com] > >> Sent: Sunday, 24 April 2022 05.45 > >> > >> The root cause is: when the xstats is NULL and n less t

Re: OVS DPDK DMA-Dev library/Design Discussion

2022-04-28 Thread Ilya Maximets
On 4/27/22 22:34, Bruce Richardson wrote: > On Mon, Apr 25, 2022 at 11:46:01PM +0200, Ilya Maximets wrote: >> On 4/20/22 18:41, Mcnamara, John wrote: -Original Message- From: Ilya Maximets Sent: Friday, April 8, 2022 10:58 AM To: Hu, Jiayu ; Maxime Coquelin ; Van H

Re: [PATCH 1/2] ci: switch to Ubuntu 20.04

2022-04-28 Thread David Marchand
On Tue, Apr 26, 2022 at 11:14 AM Ruifeng Wang wrote: > > > -Original Message- > > From: David Marchand > > Sent: Tuesday, April 26, 2022 3:18 PM > > To: dev@dpdk.org > > Cc: Aaron Conole ; Michael Santana > > ; Ruifeng Wang ; > > Jan Viktorin ; Bruce Richardson > > ; David Christensen >

Re: [PATCH] interrupts: add uio type to support multiple interrupt vector

2022-04-28 Thread David Marchand
On Thu, Apr 7, 2022 at 8:45 AM Tianli Lai wrote: > > vmxnet3 device use MSI-X interrupt type. > vmxnet3 driver configure the hardware to generate MSI-X interrupts > would fail when call rte_intr_cap_multiple function return zero. Iiuc, the issue is that you are using vmxnet3 devices bound to igb_

Re: [RFC PATCH v3 1/8] eal: annotate spinlock and rwlock

2022-04-28 Thread David Marchand
On Thu, Apr 21, 2022 at 3:48 PM Maxime Coquelin wrote: > > Hi David, > > On 4/11/22 13:00, David Marchand wrote: > > clang offers some thread safety checks, statically verifying that locks > > are taken and released in the code. > > To use those checks, the full code leading to taking or releasing

Re: [PATCH] ci: run more checks in private repositories

2022-04-28 Thread David Marchand
On Fri, Mar 25, 2022 at 3:32 PM Aaron Conole wrote: > David Marchand writes: > > > Though devtools/checkpatches.sh is run as part of our CI, some other > > (not well known) checks could help when run in private repositories > > before submitting to the mailing list and even when run from the > >

Re: [PATCH v2] eal/linux: skip attaching to external memory chunk

2022-04-28 Thread David Marchand
On Thu, Apr 21, 2022 at 11:36 AM Deepak Khandelwal wrote: > > Currently, EAL init in secondary processes will attach all fbarrays > in the memconfig to have access to primary process' page tables. > However, fbarrays corresponding to external memory segments should > not be attached at initializat

[PATCH] app/testpmd: fix help of create meter command

2022-04-28 Thread Jin liu
The help message of create meter command is incomplete, lack of policy_id param, update help string. Fixes: f29fa2c59b85 ("app/testpmd: support policy actions per color") Cc: haif...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Jin liu Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund

[PATCH] app/testpmd: fix help of create meter command

2022-04-28 Thread Jin liu
The help message of create meter command is incomplete, lack of policy_id param, update help string. Fixes: f29fa2c59b85 ("app/testpmd: support policy actions per color") Cc: haif...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Jin liu Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund

Re: Reuse Of lcore after returning from its worker thread

2022-04-28 Thread Ansar Kannankattil
But how the state is changed to WAIT once the worker thread function returned On Tue, 26 Apr, 2022, 8:26 pm Stephen Hemminger, wrote: > On Wed, 20 Apr 2022 17:52:20 +0530 > Ansar Kannankattil wrote: > > > Hi, > > As per my understanding "*rte_eal_wait_lcore" *is a blocking call in case > > of l

RE: Does ACL support field size of 8 bytes?

2022-04-28 Thread Ananyev, Konstantin
Hi Ido, > I've lots of good experience with ACL but can't make it work with u64 values > I know it can be split to 2xu32 fields, but it makes it more complex to use > and a wastes double number of fields (we hit the > RTE_ACL_MAX_FIELDS 64 limit) Wow, that's a lot of fields... > According to

[PATCH v2 14/14] common/dpaax: fix short MAC-I IV calculation for zuc

2022-04-28 Thread Gagandeep Singh
Fixing the IV caluclation for zuc based short MAC-I as per the HW security engine guidelines. Fixes: 73a24060cd70 ("crypto/dpaa2_sec: add sample PDCP descriptor APIs") Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh --- drivers/common/dpaax/caamflib/desc/pdcp.h | 2 +- 1 file changed, 1 inse

[PATCH v2 13/14] crypto/dpaa_sec: move cdb prepration to session create

2022-04-28 Thread Gagandeep Singh
Driver is preparing the shared descriptor of session while attaching the session to a queue pair. It should be prepared on session create. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa_sec/dpaa_sec.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/d

[PATCH v2 12/14] bus/dpaa: remove unused thread specific variables

2022-04-28 Thread Gagandeep Singh
There are some crypto driver related thread specific variables which are no longer used, so removing them. Signed-off-by: Gagandeep Singh --- drivers/bus/dpaa/rte_dpaa_bus.h| 8 +--- drivers/crypto/dpaa_sec/dpaa_sec.c | 4 2 files changed, 1 insertion(+), 11 deletions(-) diff --git

[PATCH v2 11/14] crypto/dpaa2_sec: fix operation status for simple FD

2022-04-28 Thread Gagandeep Singh
Driver is not filling the operation status on dequeue in case the FD is simple. So setting the status as per the results. Fixes: 0a23d4b6f4c2 ("crypto/dpaa2_sec: support protocol offload IPsec") Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c

[PATCH v2 10/14] crypto/dpaa2_sec: fix crypto op pointer value

2022-04-28 Thread Gagandeep Singh
Driver is filling the crypto_op variable with an invalid value for atomic and ordered events which can results into segmentation fault. This patch assigning the correct crypto_op and event buffer pointers by extracting from FD. Fixes: a77db24643b7 ("crypto/dpaa2_sec: support atomic queues") Fixes

[PATCH v2 09/14] crypto/dpaa2_sec: per queue pair fle pool

2022-04-28 Thread Gagandeep Singh
Driver is creating a fle pool with a fixed number of buffers for all queue pairs of a DPSECI object. These fle buffers are equivalent to the number of descriptors. In this patch, creating the fle pool for each queue pair so that user can control the number of descriptors of a queue pair using API

[PATCH v2 08/14] crypto/dpaa_sec: fix secondary process probe

2022-04-28 Thread Gagandeep Singh
From: Vanshika Shukla DPAA hardware supports non-i/o performing secondary applications only. So we do not have to probe crypto devices in secondary applications. Fixes: c3e85bdcc6e6 ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform") Cc: sta...@dpdk.org Signed-off-by: Vanshika Shukla

[PATCH v2 07/14] common/dpaax: remove obsolete code

2022-04-28 Thread Gagandeep Singh
Remove sec era 1 to 7 IPsec and caam operations code as none of the NXP platform use it. Signed-off-by: Gagandeep Singh --- drivers/common/dpaax/caamflib/desc/ipsec.h| 34 +++- .../dpaax/caamflib/rta/fifo_load_store_cmd.h | 15 --- .../common/dpaax/caamflib/rta/header_cmd.h

[PATCH v2 06/14] crypto/dpaa_sec: replace use of old build macros

2022-04-28 Thread Gagandeep Singh
Use the newer security macros defined by meson. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa_sec/dpaa_sec_raw_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec_raw_dp.c b/drivers/crypto/dpaa_sec/dpaa_sec_raw_dp.c index 29f4e6

[PATCH v2 05/14] crypto/dpaa_sec: physically enable QI

2022-04-28 Thread Gagandeep Singh
To perform crypto operations on DPAA platform, QI interface of HW must be enabled. Earlier DPAA crypto driver was dependent on kernel for QI enable. Now with this patch there is no such dependency on kernel. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa_sec/dpaa_sec.c | 30 +

[PATCH v2 04/14] crypto/dpaa2_sec: fix length for chain FD in raw sec driver

2022-04-28 Thread Gagandeep Singh
DPAA2 sec raw driver is calculating the wrong lengths while creating the FD for chain. This patch fixes lengths for chain FD. Fixes: aa6ec1fd8443 ("crypto/dpaa2_sec: support authenc with raw buffer API") Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_r

[PATCH v2 03/14] crypto/dpaa_sec: fix length for chain FD in raw sec driver

2022-04-28 Thread Gagandeep Singh
DPAA sec raw driver is calculating the wrong lengths while creating the FD for chain. This patch fixes lengths for chain FD. Fixes: 78156d38e112 ("crypto/dpaa_sec: support authonly and chain with raw API") Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa_sec/dpaa_sec_r

[PATCH v2 02/14] crypto/dpaa2_sec: fix buffer pool ID check

2022-04-28 Thread Gagandeep Singh
Simple fd rely on bpid of the buffers whereas other FD types can support buffers without bpid of pool. So moving the bpid check to simple fd to mbuf conversion function. Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation") Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh --- dr

[PATCH v2 01/14] crypto/dpaa2_sec: fix fle buffer leak

2022-04-28 Thread Gagandeep Singh
Driver allocates a fle buffer for each packet before enqueue and free the buffer on dequeue. But in case if there are enqueue failures, then code should free the fle buffers. Fixes: 4562de326d30 ("crypto/dpaa2_sec: support ordered queue") Fixes: 3ffce51a1f04 ("crypto/dpaa2_sec: add enqueue retry t

[PATCH v2 00/14] DPAA1 and DPAA2 crypto drivers changes

2022-04-28 Thread Gagandeep Singh
Change-log: Fixed git log issues. Gagandeep Singh (13): crypto/dpaa2_sec: fix fle buffer leak crypto/dpaa2_sec: fix buffer pool ID check crypto/dpaa_sec: fix length for chain FD in raw sec driver crypto/dpaa2_sec: fix length for chain FD in raw sec driver crypto/dpaa_sec: physically enab

[PATCH] net/i40e: fix max frmame size config at port level

2022-04-28 Thread wenxuanx . wu
From: Wenxuan Wu Previously, max frame size can only be set when link is up, and the wait time is 1 sec. But for nic media type of I40E_10G_BASET would consume longer time which is too short to up would result in error. Acctually, max frame size of media type I40E_MEDIA_TYPE_BASET can be set reg

Re: [PATCH] app/test: fix buffer overflow in table unit tests

2022-04-28 Thread David Marchand
On Tue, Apr 26, 2022 at 4:04 PM Dumitrescu, Cristian wrote: > > > > This patch fixes stack buffer overflow reported by ASAN. > > > > Bugzilla ID: 820 > > Fixes: 5205954791cb ("app/test: packet framework unit tests") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Vladimir Medvedkin > Acked-by: Cri

Re: librte_bpf: roadmap or any specific plans for this library

2022-04-28 Thread David Marchand
Hello, On Tue, Apr 26, 2022 at 10:34 AM Björn Svensson A wrote: > > Hi all, > I hope this is the correct maillist for this topic. Yes it is. I copied the maintainer and people that might be interested in this topic. > > DPDK provides the nice library `librte_bpf` to load and execute eBPF bytec

Re: [PATCH v4] eal: add seqlock

2022-04-28 Thread David Marchand
Hello Mattias, On Fri, Apr 8, 2022 at 4:25 PM Mattias Rönnblom wrote: > > A sequence lock (seqlock) is synchronization primitive which allows > for data-race free, low-overhead, high-frequency reads, especially for > data structures shared across many cores and which are updated > relatively infr

RE: [EXT] [PATCH] test/crypto-perf: extend asymmetric crypto throughput test

2022-04-28 Thread Akhil Goyal
Hi Kiran, > From: Kiran Kumar K > > Extended support for asymmetric crypto perf throughput test. > Added support for new modulus lengths. > Added new parameter --modex-len. > Supported lengths are 60, 128, 255, 448. Default length is 128. > > Signed-off-by: Kiran Kumar K > --- > app/test-cryp

RE: [EXT] [dpdk-dev] [PATCH v1 1/1] compress/octeontx: add octeontx2 SoC family support

2022-04-28 Thread Akhil Goyal
> The octeontx2 9xxx SoC family support is added. > > Signed-off-by: Mahipal Challa > --- > drivers/compress/octeontx/include/zip_regs.h | 12 > drivers/compress/octeontx/otx_zip.c | 6 +- > drivers/compress/octeontx/otx_zip.h | 1 + > drivers/compress/octeon

RE: [EXT] [PATCH] crypto/mlx5: fix login cleanup

2022-04-28 Thread Akhil Goyal
> In case of a probing failure caused by wrong devarg provided, > login isn't destroyed when exiting. > > Destroy login on failure. > > Fixes: ba707cdb6da2 ("crypto/mlx5: fix queue size configuration") > > Signed-off-by: Raja Zidane > Acked-by: Matan Azrad Cc: sta...@dpdk.org Applied to dpdk-

[PATCH] mempool/cnxk: avoid batch op free for empty mempools

2022-04-28 Thread Ashwin Sekhar T K
Batch op data is initialized inside mempool alloc. But in case of empty mempools, the alloc function is not called and hence the initialization of batch op data is also not done. So ensure the validity of batch op data inside mempool free. Signed-off-by: Ashwin Sekhar T K --- drivers/mempool/cnx

Re: [PATCH] ci: do not dump error logs in GHA containers

2022-04-28 Thread David Marchand
On Tue, Apr 26, 2022 at 5:05 PM Aaron Conole wrote: > > > > TBH, I did not test Travis by lack of interest (plus I don't want to > > be bothered with their ui / credit stuff). > > We could consider dropping Travis in the near future. > > > > Opinions? > > I think it makes sense. We haven't had tr

RE: [PATCH 2/5] crypto/cnxk: support AES-GMAC

2022-04-28 Thread Akhil Goyal
> > Update in .ini files missing. > > [Anoob] The .ini file is only listing symmetric & asymmetric capabilities. > This > patch is adding AES-GMAC with IPsec (ie, lookaside protocol). AES-GMAC with > lookaside crypto is already supported and ini file reflects the same as well. > > https://elixir

RE: [EXT] [PATCH 01/14] crypto/dpaa2_sec: fix fle buffer leak

2022-04-28 Thread Akhil Goyal
> > You should use check-git-log > > $ ./devtools/check-git-log.sh -14 > > Wrong headline format: > > crypto/dpaa_sec : fix secondary process probe Wrong headline prefix: > > dpaax/caamflib: remove obsolete code > > crypto/dpaa2_sec: per queue pair fle pool > > crypt

Re: know more about the LLDP agent

2022-04-28 Thread Ferruh Yigit
On 4/28/2022 8:59 AM, xing zhang wrote: Dear:     I am writting to want to know more about the below two patches.     I see the first patch that stopping the LLDP agent is to avoid diagnostic:  default dcb config fails. err = -53, aq_err = 1. So stop the LLDP agent before we attempt to call

RE: [EXT] [PATCH 01/14] crypto/dpaa2_sec: fix fle buffer leak

2022-04-28 Thread Gagandeep Singh
Hi, > -Original Message- > From: Akhil Goyal > Sent: Thursday, April 28, 2022 12:46 PM > To: Gagandeep Singh ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [EXT] [PATCH 01/14] crypto/dpaa2_sec: fix fle buffer leak > > > Driver allocates a fle buffer for each packet before enqueue an

RE: [PATCH 2/5] crypto/cnxk: support AES-GMAC

2022-04-28 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Thursday, April 28, 2022 2:00 PM > To: Anoob Joseph ; Jerin Jacob Kollanukkaran > > Cc: Archana Muniganti ; Tejasree Kondoj > ; dev@dpdk.org > Subject: RE: [PATCH 2/5] crypto/cnxk: support AES-G

RE: [PATCH 2/5] crypto/cnxk: support AES-GMAC

2022-04-28 Thread Akhil Goyal
> Subject: [PATCH 2/5] crypto/cnxk: support AES-GMAC > > From: Archana Muniganti > > Added lookaside IPsec AES-GMAC support in CNXK PMD. > > Signed-off-by: Archana Muniganti > Acked-by: Anoob Joseph > --- > doc/guides/cryptodevs/cnxk.rst| 2 ++ Update in .ini files missi

[PATCH v3 3/3] net/iavf: improve performance of Rx timestamp offload

2022-04-28 Thread Simei Su
In this patch, We use CPU ticks instead of HW register to determine whether low 32 bits timestamp has turned over. It can avoid requesting register value frequently and improve receiving performance. Signed-off-by: Wenjun Wu --- drivers/net/iavf/iavf.h| 1 + drivers/net/iavf/iavf_ethdev

[PATCH v3 2/3] net/iavf: enable Rx timestamp on Flex Descriptor

2022-04-28 Thread Simei Su
Dump Rx timestamp value into dynamic mbuf field by flex descriptor. This feature is turned on by dev config "enable-rx-timestamp". Currently, it's only supported under scalar path. Signed-off-by: Simei Su --- doc/guides/nics/features/iavf.ini | 1 + doc/guides/rel_notes/release_22_07.rst

[PATCH v3 1/3] common/iavf: support Rx timestamp in virtual channel

2022-04-28 Thread Simei Su
Add new ops and structures to support VF to support Rx timestamp on flex descriptor. "VIRTCHNL_OP_1588_PTP_GET_CAPS" ops is sent by the VF to request PTP capabilities and responded by the PF with capabilities enabled for that VF. "VIRTCHNL_OP_1588_PTP_GET_TIME" ops is sent by the VF to request th

[PATCH v3 0/3] net/iavf: support Rx timestamp on flex descriptor

2022-04-28 Thread Simei Su
[PATCH v3 1/3] add related ops and structure for Rx timestamp in virtual channel. [PATCH v3 2/3] add support for Rx timestamp on flex descriptor in driver. [PATCH v3 3/3] improve performance with Rx timestamp enabled. v3: * Rebase code. * Fix compile warning. v2: * Add release notes and doc upda

[PATCH] driver/i40e: enable max frame at port level

2022-04-28 Thread wenxuanx . wu
From: Wenxuan Wu This fix resolve max frame size can only be set when link is up. hw.type would result in different behavior: For X710, max frame size can be set regardless of link status. For X722, link up should be guaranteed. Fixes: a4ba77367923 Cc: sta...@dpdk.org Signed-off-by: Wenxuan Wu

know more about the LLDP agent

2022-04-28 Thread xing zhang
Dear: I am writting to want to know more about the below two patches. I see the first patch that stopping the LLDP agent is to avoid diagnostic: default dcb config fails. err = -53, aq_err = 1. So stop the LLDP agent before we attempt to call i40e_set_dcb_config. https://git.dpdk.org/d

RE: [PATCH] security: fix comments

2022-04-28 Thread Akhil Goyal
> Subject: [PATCH] security: fix comments > > Fix comments to reflect the field. > > Fixes: ad7515a39f2a ("security: add SA lifetime configuration") > Cc: ano...@marvell.com > > Reported-by: Thomas Monjalon > Signed-off-by: Anoob Joseph Applied to dpdk-next-crypto Cc: sta...@dpdk.org

RE: [EXT] [PATCH 01/14] crypto/dpaa2_sec: fix fle buffer leak

2022-04-28 Thread Akhil Goyal
> Driver allocates a fle buffer for each packet > before enqueue and free the buffer on dequeue. But in case if > there are enqueue failures, then code should free the fle buffers. > > Fixes: b15cbf5b2d88 ("crypto/dpaa2_sec: fix fle buffer leak") > Cc: sta...@dpdk.org > > Signed-off-by: Gagandeep