Lgtm scan of DPDK

2022-05-27 Thread Stephen Hemminger
I just discovered that there is another tool similar to Coverity for scanning. It gives different results, and might be useful. The scans of github open source projects is already done. See: https://lgtm.com/projects/g/DPDK/dpdk Shows 19 errors, 263 warnings and 111 recommendations. Of course, s

Re: [PATCH v2 2/2] lpm: add a scalar version of lookupx4 function

2022-05-27 Thread Stephen Hemminger
On Fri, 27 May 2022 20:18:22 +0200 Stanislaw Kardach wrote: > +static inline void > +rte_lpm_lookupx4(const struct rte_lpm *lpm, xmm_t ip, uint32_t hop[4], > + uint32_t defv) > +{ > + uint32_t nh; > + int i, ret; > + > + for (i = 0; i < 4; i++) { > + ret = rte_

[PATCH v2 2/2] lpm: add a scalar version of lookupx4 function

2022-05-27 Thread Stanislaw Kardach
From: Michal Mazurek Add an implementation of the rte_lpm_lookupx4() function for platforms without support for vector operations. This will be useful in the upcoming RISC-V port as well as any platform which may want to start with a basic level of LPM support. Signed-off-by: Michal Mazurek Si

[PATCH v2 1/2] lpm: add const to lpm arg of rte_lpm_lookup

2022-05-27 Thread Stanislaw Kardach
All other rte_lpm_lookup* functions take lpm argument as a const. As the basic rte_lpm_lookup() performs the same function, it should also do that. As this function is inline, no API/ABI change happens. Signed-off-by: Stanislaw Kardach --- lib/lpm/rte_lpm.h | 2 +- 1 file changed, 1 insertion(+

Re: [PATCH v2 2/2] doc/howto: add code example to virtio-user exception path doc

2022-05-27 Thread Stephen Hemminger
On Fri, 27 May 2022 17:36:43 +0100 Bruce Richardson wrote: > The HOWTO guide for using virtio-user as an exception path to the kernel > only provided an example of how testpmd may be used for that purpose. > However, a real application wanting to use virtio-user as exception path > would likely w

[PATCH] doc: fix readability in lib vhost prog guide

2022-05-27 Thread Herakliusz Lipiec
fix grammar issues and readbility in vhost library programmer guide Fixes: 768274ebbd5e ("vhost: avoid populate guest memory") Signed-off-by: Herakliusz Lipiec Cc: sta...@dpdk.org --- doc/guides/prog_guide/vhost_lib.rst | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) di

[PATCH v2 2/2] doc/howto: add code example to virtio-user exception path doc

2022-05-27 Thread Bruce Richardson
The HOWTO guide for using virtio-user as an exception path to the kernel only provided an example of how testpmd may be used for that purpose. However, a real application wanting to use virtio-user as exception path would likely want to create such devices from code within the app itself. Therefore

[PATCH v2 1/2] doc/howto: rework section on virtio-user as exception path

2022-05-27 Thread Bruce Richardson
This patch extensively reworks the howto guide on using virtio-user for exception packets. Changes include: * rename "exceptional path" to "exception path" * remove references to uio and just reference vfio-pci * simplify testpmd command-lines, giving a basic usage example first before adding on

[PATCH 2/2] doc/howto: add code example to virtio-user exception path doc

2022-05-27 Thread Bruce Richardson
The HOWTO guide for using virtio-user as an exception path to the kernel only provided an example of how testpmd may be used for that purpose. However, a real application wanting to use virtio-user as exception path would likely want to create such devices from code within the app itself. Therefore

[PATCH 1/2] doc/howto: rework section on virtio-user as exception path

2022-05-27 Thread Bruce Richardson
This patch extensively reworks the howto guide on using virtio-user for exception packets. Changes include: * rename "exceptional path" to "exception path" * remove references to uio and just reference vfio-pci * simplify testpmd command-lines, giving a basic usage example first before adding on

Re: [PATCH v4 0/4] Add APIs for configurable power options

2022-05-27 Thread Burakov, Anatoly
On 24-May-22 2:14 PM, Kevin Laatz wrote: The power library contains some variables which are currently set by defines, hard-coded values or set using sysfs values. In order to configure these, code changes and recompiles are required, making configuring these variables tedious. This patchset int

Re: [PATCH] doc: remove reference to pcapng init function

2022-05-27 Thread Stephen Hemminger
On Fri, 27 May 2022 13:21:42 + Cian Ferriter wrote: > The rte_pcapng_init function doesn't exist, so remove it from the docs. > > Also fix minor mistakes in the file. > > Signed-off-by: Cian Ferriter > > --- > > The rte_pcapng_init function existed in earlier versions of patches for > th

Re: [PATCH 3/4] net/hns3: support Rx/Tx bd dump

2022-05-27 Thread Stephen Hemminger
On Fri, 27 May 2022 10:33:50 +0800 "Min Hu (Connor)" wrote: > + for (i = 0; i < HNS3_BD_DW_NUM; i++) { > + /* > + * For the sake of security, first 8 bytes of BD which stands > + * for physical address of packet should not be shown. > + */ >

Re: [PATCH 1/4] ethdev: introduce ethdev HW desc dump PI

2022-05-27 Thread Stephen Hemminger
On Fri, 27 May 2022 10:33:48 +0800 "Min Hu (Connor)" wrote: > Added the ethdev HW Rx desc dump API which provides functions for query > HW descriptor from device. HW descriptor info differs in different NICs. > The information demonstrates I/O process which is important for debug. > As the inform

[PATCH 2/2] docs: improve ordering and remove old header titles

2022-05-27 Thread Harry van Haaren
Move the "source_org" page to after overview, where it fits better to explain the source-code layout of DPDK, before getting into details of specific libraries such as EAL. Also removes the older titles from the 3 documents which still had them. Signed-off-by: Harry van Haaren --- doc/guides/p

[PATCH 1/2] docs/bpf: fix formatting and link

2022-05-27 Thread Harry van Haaren
Small improvements to the documentation based on Sphinx HTML doc output. Signed-off-by: Harry van Haaren --- Cc: konstantin.v.anan...@yandex.ru --- doc/guides/prog_guide/bpf_lib.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/guides/prog_guide/bpf_lib.rst

[PATCH] doc: remove reference to pcapng init function

2022-05-27 Thread Cian Ferriter
The rte_pcapng_init function doesn't exist, so remove it from the docs. Also fix minor mistakes in the file. Signed-off-by: Cian Ferriter --- The rte_pcapng_init function existed in earlier versions of patches for this file on the mailing list, but was dropped in favour of RTE_INIT(pcapng_init

Re: [PATCH 1/1] lpm: add a scalar version of lookupx4 function

2022-05-27 Thread Medvedkin, Vladimir
Hi Stanislaw, On 27/05/2022 12:16, Stanisław Kardach wrote: On Tue, May 24, 2022 at 6:28 PM Stanisław Kardach wrote: That said I wonder why do we have different const requirements for rte_lpm_lookup() and rte_lpm_lookupx4(): static inline int rte_lpm_lookup(struct rte_lpm *lpm, uint32_t ip

RE: [dpdk-dev v5] crypto/qat: use intel-ipsec-mb for partial hash & aes

2022-05-27 Thread Zhang, Roy Fan
> -Original Message- > From: Ji, Kai > Sent: Friday, May 27, 2022 9:55 AM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Richardson, Bruce > ; gak...@marvell.com; Ji, Kai > Subject: [dpdk-dev v5] crypto/qat: use intel-ipsec-mb for partial hash & aes > > Since openssl 3.0 now deprecates the lo

Re: [EXT] Re: [PATCH] examples/ipsec-secgw: add support of NEON with poll mode

2022-05-27 Thread Konstantin Ananyev
-Original Message- From: Konstantin Ananyev Sent: Wednesday, May 25, 2022 4:30 AM To: Rahul Bhansali ; dev@dpdk.org; Radu Nicolau ; Akhil Goyal ; Ruifeng Wang Cc: Jerin Jacob Kollanukkaran Subject: [EXT] Re: [PATCH] examples/ipsec-secgw: add support of NEON with poll mode Externa

Re: [PATCH v1 5/5] examples/l3fwd: enable direct rearm mode

2022-05-27 Thread Konstantin Ananyev
25/05/2022 01:24, Honnappa Nagarahalli пишет: From: Konstantin Ananyev 20/04/2022 09:16, Feifei Wang пишет: Enable direct rearm mode. The mapping is decided in the data plane based on the first packet received. Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei Wang Reviewed-by:

Re: [PATCH 1/1] lpm: add a scalar version of lookupx4 function

2022-05-27 Thread Stanisław Kardach
On Tue, May 24, 2022 at 6:28 PM Stanisław Kardach wrote: > That said I wonder why do we have different const requirements for > rte_lpm_lookup() and rte_lpm_lookupx4(): > static inline int rte_lpm_lookup(struct rte_lpm *lpm, uint32_t ip, > uint32_t *next_hop) > static inline void rte_lpm_look

Re: [PATCH v3 1/2] eal: get/set thread priority per thread identifier

2022-05-27 Thread Tyler Retzlaff
On Thu, May 26, 2022 at 08:21:27AM -0700, Stephen Hemminger wrote: > > Thanks for clarifying. > Is there any analog for SCHED_DEADLINE worth considering? i hadn't considered it. for now i probably won't since this patch is just a blocker for getting the thread lifetime series up. which is higher

[Bug 1019] Cannot Rx after DPDK 22.03 version with iavf

2022-05-27 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1019 Bug ID: 1019 Summary: Cannot Rx after DPDK 22.03 version with iavf Product: DPDK Version: 22.03 Hardware: All OS: All Status: UNCONFIRMED Severity: major

[dpdk-dev v5] crypto/qat: use intel-ipsec-mb for partial hash & aes

2022-05-27 Thread Kai Ji
Since openssl 3.0 now deprecates the low level API QAT required to perform partial hash & aes operation when creating the session. This patch add in qat_ipsec_mb_lib driver parameter to allow QAT PMD to switch APIs between openssl and intel ipsec-mb library. Signed-off-by: Kai Ji Signed-off-by: F

Re: [RFC] bus/fslmc: fix invalid use of default vfio config

2022-05-27 Thread Romain Delhomel
On Fri, May 27, 2022 at 10:34 AM Romain Delhomel wrote: > > > On Fri, May 27, 2022 at 10:28 AM Romain Delhomel < > romain.delho...@6wind.com> wrote: > >> At device probe, the fslmc bus driver calls rte_vfio_get_group_fd() to >> get a fd associated to a vfio group. This function first checks if th

Re: [RFC] bus/fslmc: fix invalid use of default vfio config

2022-05-27 Thread Romain Delhomel
On Fri, May 27, 2022 at 10:28 AM Romain Delhomel wrote: > At device probe, the fslmc bus driver calls rte_vfio_get_group_fd() to > get a fd associated to a vfio group. This function first checks if the > group is already opened, else it opens /dev/vfio/%u, and increases the > number of active gro

[RFC] bus/fslmc: fix invalid use of default vfio config

2022-05-27 Thread Romain Delhomel
At device probe, the fslmc bus driver calls rte_vfio_get_group_fd() to get a fd associated to a vfio group. This function first checks if the group is already opened, else it opens /dev/vfio/%u, and increases the number of active groups in default_vfio_cfg (which references the default vfio contain

[PATCH v4 5/5] guides/rawdevs: add description of ofs in ifpga doc

2022-05-27 Thread Wei Huang
OFS (Open FPGA Stack) specification is introduced briefly. Signed-off-by: Wei Huang Reviewed-by: Rosen Xu --- v2: update description per Tianfei's comment --- doc/guides/rawdevs/ifpga.rst | 105 ++- 1 file changed, 104 insertions(+), 1 deletion(-) diff -

[PATCH v4 4/5] raw/ifpga: support ofs card probe

2022-05-27 Thread Wei Huang
PAC N6000 is the first OFS platform, its device id is added to ifpga device support list. Previous FPGA platform like Intel PAC N3000 and N5000, FME DFL (Device Feature List) starts from BAR0 by default, port DFL location is indicated in PORTn_OFFSET register in FME. In OFS implementation, FME DFL

[PATCH v4 3/5] raw/ifpga: unregister interrupt in ifpga close function

2022-05-27 Thread Wei Huang
There is an API rte_pmd_ifpga_cleanup provided by ifpga driver to free the software resource used by ifpga card. The function call of rte_pmd_ifpga_cleanup is list below. rte_pmd_ifpga_cleanup() ifpga_rawdev_cleanup() rte_rawdev_pmd_release() rte_rawdev_close() ifpga_rawdev_c

[PATCH v4 2/5] raw/ifpga: remove vdev when ifpga is closed

2022-05-27 Thread Wei Huang
Virtual devices created on ifpga raw device will not be removed when ifpga device has closed. To avoid resource leak problem, this patch introduces an ifpga virtual device remove function, virtual devices will be destroyed after the ifpga raw device closed. Fixes: ef1e8ede3da5 ("raw/ifpga: add Int

[PATCH v4 1/5] raw/ifpga: remove experimental tag from ifpga APIs

2022-05-27 Thread Wei Huang
These APIs are introduced in DPDK 21.05 and have been tested in several release, experimental tag can be formally removed. Signed-off-by: Wei Huang Acked-by: Tianfei Zhang Reviewed-by: Rosen Xu --- drivers/raw/ifpga/rte_pmd_ifpga.h | 48 --- drivers/raw/ifpg

[PATCH v4 0/5] Support OFS card

2022-05-27 Thread Wei Huang
Changes from v3: 1. replace constant with PCI_PRI_STR_SIZE per Rosen's comment. 2. update commit log with more explanations about the function call. 3. fix typo and coding style issue. 4. update ifpga documentation per Tianfei's comment. Wei Huang (5): raw/ifpga: remove experimental tag from ifp

[PATCH] net/ice: fix the outer l4 cksum flag when AVX is disabled

2022-05-27 Thread Wenjing Qiao
In scalar datapath, ol_flag shows RTE_MBUF_F_RX_OUTER_L4_CKSUM_UNKNOWN which is error, therefore fixing this bug. Fixes: 94005e4640a7 ("net/ice: fix build with 16-byte Rx descriptor") Cc: sta...@dpdk.org Signed-off-by: Wenjing Qiao Reported-by: Xiao Wang --- drivers/net/ice/ice_rxtx.c | 4 +++-

[PATCH v6 1/1] ethdev: introduce protocol header based buffer split

2022-05-27 Thread xuan . ding
From: Wenxuan Wu Currently, Rx buffer split supports length based split. With Rx queue offload RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT enabled and Rx packet segment configured, PMD will be able to split the received packets into multiple segments. However, length based buffer split is not suitable for N

[PATCH v6 0/1] ethdev: introduce protocol based buffer split

2022-05-27 Thread xuan . ding
From: Xuan Ding Protocol based buffer split consists of splitting a received packet into several separate segments based on the packet content. It is useful in some scenarios, such as GPU acceleration. The splitting will help to enable true zero copy and hence improve the performance significantl

[PATCH v6] ethdev: introduce protocol header based buffer split

2022-05-27 Thread xuan . ding
From: Wenxuan Wu Currently, Rx buffer split supports length based split. With Rx queue offload RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT enabled and Rx packet segment configured, PMD will be able to split the received packets into multiple segments. However, length based buffer split is not suitable for N

RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform

2022-05-27 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Anoob Joseph > Sent: Friday, May 27, 2022 9:28 AM > To: Kusztal, ArkadiuszX ; Akhil Goyal > ; dev@dpdk.org; Kiran Kumar Kokkilagadda > > Cc: Zhang, Roy Fan ; Umesh Kartha > ; Ramkumar Balu > Subject: RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto ne

RE: [EXT] [PATCH 11/40] cryptodev: remove asym crypto next xform

2022-05-27 Thread Anoob Joseph
Hi Arek, Please see inline. Thanks, Anoob > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Friday, May 27, 2022 12:26 PM > To: Anoob Joseph ; Akhil Goyal ; > dev@dpdk.org; Kiran Kumar Kokkilagadda > Cc: Zhang, Roy Fan ; Umesh Kartha > ; Ramkumar Balu > Subject: RE: [EXT] [PATC