>
>
> Enable Virtual Functions
> @@ -167,14 +172,14 @@ queues, priorities, load balance, bandwidth and other
> settings necessary for the
> device to perform FEC functions.
>
> This configuration needs to be executed at least once after reboot or PCI FLR
> and can
> -be achieved by using the
On Fri, May 27, 2022 at 01:15:20PM -0700, Stephen Hemminger wrote:
> On Fri, 27 May 2022 20:18:22 +0200
> Stanislaw Kardach wrote:
>
> > +static inline void
> > +rte_lpm_lookupx4(const struct rte_lpm *lpm, xmm_t ip, uint32_t hop[4],
> > + uint32_t defv)
> > +{
> > + uint32_t nh;
> > +
> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> Sent: Monday, 30 May 2022 09.52
>
> On Fri, May 27, 2022 at 01:15:20PM -0700, Stephen Hemminger wrote:
> > On Fri, 27 May 2022 20:18:22 +0200
> > Stanislaw Kardach wrote:
> >
> > > +static inline void
> > > +rte_lpm_lookupx4(const str
On Sun, May 29, 2022 at 06:36:21AM -0500, Lewis Donzis wrote:
> Apparently FreeBSD 13.1 changed the syntax of the CPUSET macros, so DPDK no
> longer compiles.
>
> For example, here's one definition on FreeBSD 13.0 and prior:
>
>CPU_OR(cpuset_t *dst, cpuset_t *src);
>
> and here it is in
28/05/2022 10:53, lihuisong (C):
>
> 在 2022/5/23 22:36, Thomas Monjalon 写道:
> > 23/05/2022 11:51, David Marchand:
> >> On Sat, May 21, 2022 at 8:57 AM Min Hu (Connor) wrote:
> >>> From: Huisong Li
> >>>
> >>> The 'state' in struct rte_eth_dev may be used to update some information
> >>> when app
Added new API to enable or disable TC over subscription for best
effort traffic class at subport level.
Added changes after review and increased throughput.
By default TC OV is disabled.
History:
- v1 - TC OV disabled by default
- v2 - throughput improvements
- v3, v4, v5 - changes from comments
-
"Min Hu (Connor)" writes:
> Added the ethdev HW Rx desc dump API which provides functions for query
> HW descriptor from device. HW descriptor info differs in different NICs.
> The information demonstrates I/O process which is important for debug.
> As the information is different between NICs,
Fixed some bugs for ngbe and txgbe, and support a new PHY ID.
Jiawen Wu (9):
net/ngbe: fix to set force speed
net/ngbe: add support for yt8531s PHY
net/ngbe: fix occasional failure of reading PHY ID
net/ngbe: fix external PHY to power down
net/ngbe: fix to read M88E1512 PHY mode
net/ng
Since the bit of ETH_LINK_SPEED_FIXED was set for the force link
speed, it conflicts with '~allowed_speeds'.
Fixes: 3518df5774c7 ("net/ngbe: support device start/stop")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/ngbe_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 dele
Add support for yt8531s PHY.
Signed-off-by: Jiawen Wu
---
doc/guides/rel_notes/release_22_07.rst | 4
drivers/net/ngbe/base/ngbe_phy.c | 3 ++-
drivers/net/ngbe/base/ngbe_phy_yt.h| 3 ++-
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/doc/guides/rel_notes/release_2
Change to check low ID register to determine the valid PHY address,
for yt8521s PHY with high ID register value 0. And fix polling
register when expect value is 0, to complete MDIO read.
Fixes: 44e97550ca68 ("net/ngbe: identify and reset PHY")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
dr
For M88E1512 PHY mixed mode, PXE driver overrides PHY mode at load
time. To workaround this problem, change to read PHY mode from flash
instead of register.
Fixes: 1c44384fce76 ("net/ngbe: support custom PHY interfaces")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/base/ngb
When using mailbox to request firmware to enable or disable PCIe bus
master, there is a small probability that mailbox cannot respond.
Change to use rte_pci_read_config() and rte_pci_write_config(), to
avoid this problem.
Fixes: ac6c5e9af56a ("net/ngbe: fix Tx hang on queue disable")
Cc: sta...@dp
External PHY cannot power down after LAN reset, so need to manually
power down when device stopped.
Fixes: 3d0af7066759 ("net/ngbe: setup PHY link")
Fixes: 1c44384fce76 ("net/ngbe: support custom PHY interfaces")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/ngbe/base/ngbe_dummy.
Add to read efuse values from flash, and disable EEE to improve signal
quality. Remove PHY semaphore to access PHY registers faster. And remove
unnecessary page selection where quick access is required.
When rte_eth_link_get_nowait() is called frequently with LSC disabled by
self-developed applica
Fix SGMII mode to link up.
Fixes: 01c3cf5c85a7 ("net/txgbe: add autoneg control read and write")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/base/txgbe_phy.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/net/txgbe/base/txgbe_phy.
Hardware restrictions require a maximum of 4 queues for every pool.
Fixes: a6712cd029a4 ("net/txgbe: add PF module init and uninit for SRIOV")
Cc: sta...@dpdk.org
Signed-off-by: Jiawen Wu
---
drivers/net/txgbe/txgbe_pf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driver
TIMER_MILLISECOND is defined as the number of cpu cycles per millisecond,
current definition is correct for cores with frequency of 2GHZ, for cores
with different frequency, it caused different periods between refresh,
(i.e. the definition is about 14ms on ARM cores).
Use dpdk API to get CPU frequ
xuan.d...@intel.com writes:
> From: Wenxuan Wu
>
> Currently, Rx buffer split supports length based split. With Rx queue
> offload RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT enabled and Rx packet segment
> configured, PMD will be able to split the received packets into
> multiple segments.
>
> However, le
Hi Chenbo,
> -Original Message-
> From: Xia, Chenbo
> Sent: Monday, May 30, 2022 10:49 AM
> To: Wang, YuanX ; maxime.coque...@redhat.com
> Cc: dev@dpdk.org; Hu, Jiayu ; He, Xingguang
>
> Subject: RE: [PATCH] net/virtio: unmap PCI device in secondary process
>
> > -Original Message--
Since openssl 3.0 now deprecates the low level API QAT required to
perform partial hash & aes operation when creating the session. This
patch add in qat_ipsec_mb_lib driver parameter to allow QAT PMD to
switch APIs between openssl and intel ipsec-mb library.
Signed-off-by: Kai Ji
Signed-off-by: F
Hi Connor,
On 5/30/2022 11:31 AM, Min Hu (Connor) wrote:
Hi, all,
any comments for this patch?
在 2022/3/24 11:00, Min Hu (Connor) 写道:
From: Huisong Li
Currently, some eth devices are added to bond device, these devices
are not
released when the quit command is executed in testpmd. This
> -Original Message-
> From: Danilewicz, MarcinX
> Sent: Monday, May 30, 2022 9:45 AM
> To: dev@dpdk.org; Singh, Jasvinder ;
> Dumitrescu, Cristian
> Cc: Ajmera, Megha
> Subject: [PATCH v6] sched: enable traffic class oversubscription conditionally
>
> Added new API to enable or disa
Support rte_eth_dev_set_mtu by pcap vdevs
Enforce mtu on rx/tx
Bugzilla ID: 961
Signed-off-by: Ido Goshen
---
v3:
Preserve pcap behavior to support max size packets by default
alternative to v2 in order to limit the code change to pcap only and
avoid abi change.
Enforce mtu only in case rte_eth_
https://bugs.dpdk.org/show_bug.cgi?id=1020
Bug ID: 1020
Summary: Can not detect E810-CQDA2 on Ubuntu 20.04
Product: DPDK
Version: 22.03
Hardware: x86
OS: Linux
Status: UNCONFIRMED
Severity: normal
On Mon, May 30, 2022 at 10:00:34AM +0200, Morten Brørup wrote:
> > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > Sent: Monday, 30 May 2022 09.52
> >
> > On Fri, May 27, 2022 at 01:15:20PM -0700, Stephen Hemminger wrote:
> > > On Fri, 27 May 2022 20:18:22 +0200
> > > Stanislaw Kard
On 5/27/2022 6:14 AM, Huzaifa Rahman wrote:
[CAUTION: External Email]
Hi,
The following tests are failing but my patch is not related to anything
related to these. Please re-run the tests.
Failed Tests:
- mtu_update
- scatter
Hi Huzaifa,
Agree, it looks unr
On 5/27/2022 3:30 AM, lihuisong (C) wrote:
CAUTION: This message has originated from an External Source. Please use
proper judgment and caution when opening attachments, clicking links, or
responding to this email.
在 2022/5/26 1:37, Ferruh Yigit 写道:
When supported RSS offload flow types are
On 5/26/2022 10:39 PM, Ben Magistro wrote:
[CAUTION: External Email]
This may simply be a docs and signature mismatch (or macro wasn't
available at the time, didn't check that aspect) but the function
rte_ipv4_udptcp_cksum_verify() is marked as experimental in the
signature but not in the asso
Hi Marcin,
Comments inline below.
> @@ -2403,8 +2481,16 @@ grinder_schedule(struct rte_sched_port *port,
> uint32_t pkt_len = pkt->pkt_len + port->frame_overhead;
> uint32_t be_tc_active;
>
> - if (!grinder_credits_check(port, subport, pos))
> - return 0;
> + sw
> -Original Message-
> From: Danilewicz, MarcinX
> Sent: Monday, May 30, 2022 9:45 AM
> To: dev@dpdk.org; Singh, Jasvinder ;
> Dumitrescu, Cristian
> Cc: Ajmera, Megha
> Subject: [PATCH v6] sched: enable traffic class oversubscription conditionally
>
> Added new API to enable or disa
Hi, wenxu
I'm sorry, it seems the mlx5_flow_tunnel_validate() routine had been
already refactored and fixed, this patch is no longer relevant,
With best regards,
Slava
> -Original Message-
> From: dev On Behalf Of we...@ucloud.cn
> Sent: Monday, August 9, 2021 8:44
> To: Gregory Etels
On 5/30/2022 9:28 AM, Thomas Monjalon wrote:
[CAUTION: External Email]
28/05/2022 10:53, lihuisong (C):
在 2022/5/23 22:36, Thomas Monjalon 写道:
23/05/2022 11:51, David Marchand:
On Sat, May 21, 2022 at 8:57 AM Min Hu (Connor) wrote:
From: Huisong Li
The 'state' in struct rte_eth_dev may be
"Min Hu (Connor)" writes:
> Hi, Ray,
>
> 在 2022/5/30 17:17, Ray Kinsella 写道:
>> "Min Hu (Connor)" writes:
>>
>>> Added the ethdev HW Rx desc dump API which provides functions for query
>>> HW descriptor from device. HW descriptor info differs in different NICs.
>>> The information demonstrate
> -Original Message-
> From: Danilewicz, MarcinX
> Sent: Thursday, May 12, 2022 2:11 PM
> To: dev@dpdk.org; Singh, Jasvinder ;
> Dumitrescu, Cristian
> Cc: Ajmera, Megha
> Subject: [PATCH v2] sched: enable CMAN at runtime
>
> Added changes to enable CMAN (RED or PIE) at init
> from p
On Mon, May 30, 2022 at 12:42 PM Bruce Richardson
wrote:
>
> On Mon, May 30, 2022 at 10:00:34AM +0200, Morten Brørup wrote:
> > > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > > Sent: Monday, 30 May 2022 09.52
> > >
> > > On Fri, May 27, 2022 at 01:15:20PM -0700, Stephen Hemminger
Hi Marcin,
Comments inline below.
> -Original Message-
> From: Danilewicz, MarcinX
> Sent: Thursday, May 12, 2022 2:11 PM
> To: dev@dpdk.org; Singh, Jasvinder ;
> Dumitrescu, Cristian
> Cc: Ajmera, Megha
> Subject: [PATCH v2] sched: enable CMAN at runtime
>
> Added changes to enable C
Remove unimplemented function call be wrapped by
RTE_LIBRTE_IAVF_DEBUG_TX_DESC_RING
Fixes: 1e728b01120c ("net/iavf: rework Tx path")
Cc: sta...@dpdk.org
Signed-off-by: Qi Zhang
---
drivers/net/iavf/iavf_rxtx.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/net/iavf/iavf_rxtx.c
Tested with IOAT and IDXD, both pass unit tests.
Tested-by: Kevin Laatz
On 27/05/2022 04:40, Chengwen Feng wrote:
If no DMA request is completed, the ring_idx of the last completed
operation need returned by last_idx parameter. This patch adds
testcase for it.
Signed-off-by: Chengwen Feng
--
> -Original Message-
> From: Yang, Qiming
> Sent: Monday, May 30, 2022 1:35 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z ; Yang, Qiming
> ; sta...@dpdk.org
> Subject: [PATCH v2] net/iavf: increase the reset complete wait count
>
> Kernel iavf driver has sent patch to increase the completion
> -Original Message-
> From: Stephen Hemminger
> Sent: Thursday, May 26, 2022 9:27 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger ; Dumitrescu,
> Cristian ; Singh, Jasvinder
> ; Wojciech Liguzinski
>
> Subject: [PATCH v5 2/3] rte_pie: remove unnecessary floating point
>
> The qdelay va
> -Original Message-
> From: Stephen Hemminger
> Sent: Thursday, May 26, 2022 9:27 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger ; Dumitrescu,
> Cristian ; Singh, Jasvinder
> ; Wojciech Liguzinski
>
> Subject: [PATCH v5 3/3] rte_pie: fix incorrect floating point math
>
> The function
Added new flag to enable or disable TC oversubscription for best
effort traffic class at subport level.
By default TC OV is disabled.
Signed-off-by: Marcin Danilewicz
History:
- v1 - TC OV disabled by default
- v2 - throughput improvements
- v3, v4, v5 - changes from comments
- v6 - removed rte
Hi Cristian,
Thank you for comments. Please find my response inline.
> > Signed-off-by: Marcin Danilewicz
> > ---
> > lib/sched/rte_sched.c | 96
> > +--
> > 1 file changed, 93 insertions(+), 3 deletions(-)
> >
> This latest version of your patch only con
Hi Cristian,
>
> Using a switch statement for a binary condition instead of if-else does not
> make sense to me. I know you mention you saw better performance with the
> switch, but I am pretty sure it is not the switch providing the performance
> increase. You are using if-else for testing the
Hi Cristian,
> > By default TC OV is disabled.
> > History:
> > - v1 - TC OV disabled by default
> > - v2 - throughput improvements
> > - v3, v4, v5 - changes from comments
> > - v6 - removed rte_sched_subport_tc_ov_config declaration and map
>
> The place of the history log is not here. If you
On 5/26/2022 11:21 AM, Thomas Monjalon wrote:
[CAUTION: External Email]
25/05/2022 19:44, Ferruh Yigit:
On 5/3/2022 11:02 AM, Min Hu (Connor) wrote:
Currently, 'dev_started' is always set to be 0 when dev stop, whether
it succeeded or failed. This is unreasonable and this patch fixed it.
Fixe
Hi Marcin,
Comments inline below.
> -Original Message-
> From: Danilewicz, MarcinX
> Sent: Monday, May 30, 2022 12:55 PM
> To: dev@dpdk.org; Singh, Jasvinder ;
> Dumitrescu, Cristian
> Cc: Ajmera, Megha
> Subject: [PATCH v7] sched: enable traffic class oversubscription conditionally
>
Adds a very basic introduction to JSON vector sets in
the fips validation example application. This patch set
will only introduce the AES-GCM test using a JSON request
file because the other algorithms need more information
than what is given in the new JSON format.
v8:
* Fixed overlapped places f
From: Brandon Lo
Added a check for RTE_HAS_JANSSON into the meson
configuration file for JSON support.
Signed-off-by: Brandon Lo
Acked-by: Gowrishankar Muthukrishnan
---
examples/fips_validation/meson.build | 4
1 file changed, 4 insertions(+)
diff --git a/examples/fips_validation/meson
From: Brandon Lo
Added json-specific functions and other information needed to
test the new FIPS test vectors.
Signed-off-by: Brandon Lo
Signed-off-by: Gowrishankar Muthukrishnan
---
v7:
* fix switch clause for info.file_type.
v5:
* fix typo in macro name for prefixes.
v2:
* fix type of pref
From: Brandon Lo
Added functions to parse the required information from a vector set
given in the new json format.
Signed-off-by: Brandon Lo
Signed-off-by: Gowrishankar Muthukrishnan
---
v7:
* pulled json_info define from next patch.
v3:
* fix checkpatch warnings
v2:
* fix for loop initializ
From: Brandon Lo
Added the ability to use the json format as the input
and output of the example application.
Signed-off-by: Brandon Lo
Signed-off-by: Gowrishankar Muthukrishnan
--
v8:
* dont steal refcount on write_set using _new as latter is updated
subsequently in same function.
* fix fip
From: Brandon Lo
Adds json-specific testing and writeback function. Allows
the user to test AES-GCM vector sets.
Signed-off-by: Brandon Lo
Acked-by: Gowrishankar Muthukrishnan
---
v8:
* reset IV generation var in every test group as initialization.
v3:
* fix checkpatch warnings
---
examples/
From: Brandon Lo
Adds JSON support for the HMAC algorithm.
Signed-off-by: Brandon Lo
Acked-by: Gowrishankar Muthukrishnan
---
examples/fips_validation/fips_validation.c| 2 +
examples/fips_validation/fips_validation.h| 6 ++
.../fips_validation/fips_validation_hmac.c| 93 +++
From: Brandon Lo
Implemented JSON support for the CMAC test.
Signed-off-by: Brandon Lo
Signed-off-by: Gowrishankar Muthukrishnan
---
v5:
* parser_read_cmac_direction_str is static.
---
examples/fips_validation/fips_validation.h| 3 +
.../fips_validation/fips_validation_cmac.c| 80 +++
From: Brandon Lo
Added function to parse algorithm for CMAC test.
Signed-off-by: Brandon Lo
Signed-off-by: Gowrishankar Muthukrishnan
--
v5:
* parser_read_cmac_direction_str implementation moved to static.
---
examples/fips_validation/fips_validation.c | 19 ---
examples/fips_
Added function to parse algorithm for AES_CBC test.
Signed-off-by: Gowrishankar Muthukrishnan
--
v6:
* fixed local variable initialization in fips_mct_aes_test.
---
examples/fips_validation/fips_validation.c| 8 +-
examples/fips_validation/fips_validation.h| 4 +
.../fips_validation/
Add notes on algorithms supported for ACVP validation.
Signed-off-by: Gowrishankar Muthukrishnan
---
doc/guides/sample_app_ug/fips_validation.rst | 30 +++-
1 file changed, 23 insertions(+), 7 deletions(-)
diff --git a/doc/guides/sample_app_ug/fips_validation.rst
b/doc/guides/s
On Mon, May 30, 2022 at 01:20:50PM +0200, Stanisław Kardach wrote:
> On Mon, May 30, 2022 at 12:42 PM Bruce Richardson
> wrote:
> >
> > On Mon, May 30, 2022 at 10:00:34AM +0200, Morten Brørup wrote:
> > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > > > Sent: Monday, 30 May 202
On 5/30/2022 12:36 PM, Qi Zhang wrote:
Remove unimplemented function call be wrapped by
RTE_LIBRTE_IAVF_DEBUG_TX_DESC_RING
Fixes: 1e728b01120c ("net/iavf: rework Tx path")
Cc: sta...@dpdk.org
Signed-off-by: Qi Zhang
---
Acked-by: Radu Nicolau
- On May 30, 2022, at 3:09 AM, Bruce Richardson bruce.richard...@intel.com
wrote:
> On Sun, May 29, 2022 at 06:36:21AM -0500, Lewis Donzis wrote:
>> Apparently FreeBSD 13.1 changed the syntax of the CPUSET macros, so DPDK no
>> longer compiles.
>>
>> For example, here's one definition on
Tx adapter allocate data during eth_tx_adapter_queue_add() call and
it's only cleaned but not freed during eth_tx_adapter_queue_del().
Implemented eth_tx_adapter_free() callback to free adapter data.
Signed-off-by: Volodymyr Fialko
Change-Id: I72480c5ac8a65688aa790d4ad66a2f5b0c3148a9
---
drivers
On 5/30/2022 1:32 PM, lihuisong (C) wrote:
CAUTION: This message has originated from an External Source. Please use
proper judgment and caution when opening attachments, clicking links, or
responding to this email.
在 2022/5/30 18:43, Ferruh Yigit 写道:
On 5/27/2022 3:30 AM, lihuisong (C) wrote
On Mon, May 30, 2022 at 07:50:19AM -0500, Lewis Donzis wrote:
>
>
> - On May 30, 2022, at 3:09 AM, Bruce Richardson
> bruce.richard...@intel.com wrote:
>
> > On Sun, May 29, 2022 at 06:36:21AM -0500, Lewis Donzis wrote:
> >> Apparently FreeBSD 13.1 changed the syntax of the CPUSET macros, s
From: Jerin Jacob
NIC HW controllers often come with congestion management support on
various HW objects such as Rx queue depth or mempool queue depth.
Also, it can support various modes of operation such as RED
(Random early discard), WRED etc on those HW objects.
This patch adds a framework t
Tx adapter allocate data during eth_tx_adapter_queue_add() call and
it's only cleaned but not freed during eth_tx_adapter_queue_del().
Implemented eth_tx_adapter_free() callback to free adapter data.
Signed-off-by: Volodymyr Fialko
---
drivers/event/cnxk/cn10k_eventdev.c | 3 +++
drivers/e
> -Original Message-
> From: Nicolau, Radu
> Sent: Monday, May 30, 2022 8:49 PM
> To: Zhang, Qi Z
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [PATCH] net/iavf: remove unimplemented function call
>
>
> On 5/30/2022 12:36 PM, Qi Zhang wrote:
> > Remove unimplemented function call
> -Original Message-
> From: Zhang, Qi Z
> Sent: Sunday, May 29, 2022 6:49 PM
> To: Jeff Daly ; dev@dpdk.org
> Cc: Stephen Douthit ; Yang, Qiming
> ; Wu, Wenjun1
> Subject: RE: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550
> devices
>
> Caution: This is an external email
Hi Cristian,
Please find inline answers:
> > History:
> > - v1 - TC OV disabled by default
> > - v2 - throughput improvements
> > - v3, v4, v5 - changes from comments
> > - v6 - removed rte_sched_subport_tc_ov_config declaration and map
> > - v7 - changes from comments on v6
>
> I see you moved
Added new flag to enable or disable TC oversubscription for best
effort traffic class at subport level.
By default TC OV is disabled.
Signed-off-by: Marcin Danilewicz
---
History:
- v1 - TC OV disabled by default
- v2 - throughput improvements
- v3, v4, v5 - changes from comments
- v6 - removed
Enable ability to run inline security tests using event
API(rte_event_eth_tx_adapter_enqueue/rte_event_dequeue_burst).
New test command - event_inline_ipsec_autotest will run same list of
test cases as inline_ipsec_autotest, but packets will go through eventdev.
Signed-off-by: Volodymyr Fialko
--
> -Original Message-
> From: Zhang, Qi Z
> Sent: Sunday, May 29, 2022 7:25 PM
> To: Jeff Daly ; dev@dpdk.org; Yang, Qiming
> ; Wu, Wenjun1
> Cc: Stephen Douthit
> Subject: RE: [PATCH 1/3] ixgbe: make link update thread periodic
>
> Caution: This is an external email. Please take care
> -Original Message-
> From: Jeff Daly
> Sent: Monday, May 30, 2022 9:33 PM
> To: Zhang, Qi Z ; dev@dpdk.org
> Cc: Stephen Douthit ; Yang, Qiming
> ; Wu, Wenjun1
> Subject: RE: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550
> devices
>
>
>
> > -Original Message-
Hi Marcin,
> >
> > Still only changes in rte_sched.c and no change in rte_sched.h for the API
> to
> > configure this feature?
>
> Yes, because you said to remove whole
> rte_sched_subport_tc_ov_config(struct rte_sched_port *port,
> uint32_t subport_id,
> bool tc_ov_enable)
> here
Using DPDK 21.11.1 on FreeBSD 13.1, calling rte_eth_link_get_nowait() appears
to hang waiting for the link to come up on an XL710 or 82599 based NIC.
This call eventually makes its way to ixgbe_dev_link_update_share() with
wait_to_complete set to false.
Inside that function, there is this code:
Hi Cristian,
> Can you please explain why you need to add the new
> RTE_SCHED_CMAN_NONE value to this enumeration and what is the ABI
> breakage that you are trying to avoid?
>
> The library expects the struct rte_sched_subport_params:: cman_params to
> be NULL when the CMAN is disabled, why i
Hi Cristian,
> Nope, it looks like we have a misunderstanding here. Looking back at my
> comments from V3: What I meant is that the configuration values related to
> this feature (all the tc_ov configuration values) should be computed at
> initialization regardless of whether this feature is enabl
Building on RISC-V results in an error
cc: error: ‘-march=native’: ISA string must begin with rv32 or rv64
As GCC does not support -march=native on RISC-V avoid this argument.
Signed-off-by: Heinrich Schuchardt
---
meson.build | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff
> -Original Message-
> From: Jeff Daly
> Sent: Monday, May 30, 2022 9:47 PM
> To: Zhang, Qi Z ; dev@dpdk.org; Yang, Qiming
> ; Wu, Wenjun1
> Cc: Stephen Douthit
> Subject: RE: [PATCH 1/3] ixgbe: make link update thread periodic
>
>
>
> > -Original Message-
> > From: Zhang, Q
> -Original Message-
> From: Zhang, Qi Z
> Sent: Monday, May 30, 2022 10:21 PM
> To: Daly, Jeff ; dev@dpdk.org; Yang, Qiming
> ; Wu, Wenjun1
> Cc: Stephen Douthit
> Subject: RE: [PATCH 1/3] ixgbe: make link update thread periodic
>
>
>
> > -Original Message-
> > From: Jeff D
This patchset introduces some of changes discussed on mailing list for 22.07
release in cryptodev asym.
Key changes:
- It fixes API for RSA (expescially signature paddings)
- Adds Elliptic-Curve Diffie-Hellman
- Adds Eliiptic-Curve point verification
- Adds RSA missing padding fields
- Adds asym
- EC enum was renamed to rte_crypto_curve_id.
Elliptic curve enum name was incorrectly associated
with a group (it comes from the current tls registry name).
- Clarified comments about TLS deprecation.
Some curves included are deprecated with TLS 1.3.
Comments to address it were added.
- Clarified
- Separated key exchange enum from asym op type.
Key exchange and asymmetric crypto operations like signatures,
encryption/decryption should not share same operation enum as
its use cases are unrelated and mutually exclusive.
Therefore op_type was separate into:
1) operation type
2) key exchange op
- Removed comment that stated DSA can be used with Diffie
Hellman ephemeral key.
DH and DSA integration allowed to use ephemeral keys for
random integer, but not for private keys.
Signed-off-by: Arek Kusztal
---
lib/cryptodev/rte_crypto_asym.h | 8 +---
1 file changed, 1 insertion(+), 7 dele
- Clarified usage of private key in Diffie-Hellman.
CSRNG capable device should generate private key and then
use it for public key generation.
Signed-off-by: Arek Kusztal
---
lib/cryptodev/rte_crypto_asym.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/lib/cryptodev/rte_crypto_asym.h
- Moved dh operation type to dh operation struct.
Operation type (PUBLIC_KEY_GENERATION, SHARED_SECRET) should
be free to choose for any operation. One xform/session should
be enough to perform both DH operations, if op_type would be xform
member, session would have to be to be created twice for th
- Added elliptic curve Diffie-Hellman parameters.
Point multiplication allows the user to process every phase of
ECDH, but for phase 1, user should not really care about the generator.
The user does not even need to know what the generator looks like,
therefore setting ec xform would make this work
- Added key exchange public key verify option.
For some elliptic curves public point in DH exchange
needs to be checked, if it lays on the curve.
Modular exponentiation needs certain checks as well, though
mathematically much easier.
This commit adds verify option to asym_op operations.
Signed-off
- Added flags to rte_crypto_asym_op struct.
It may be shared between different algorithms.
- Added Diffie-Hellman padding flags.
Diffie-Hellman padding is used in certain protocols,
in others, leading zero bytes need to be stripped.
Even same protocol may use a different approach - most
glaring exa
- Clarified usage of RSA padding hash.
It was not specified how to use hash for PKCS1_5
padding. This could lead to incorrect implementation.
Signed-off-by: Arek Kusztal
---
lib/cryptodev/rte_crypto_asym.h | 25 ++---
1 file changed, 22 insertions(+), 3 deletions(-)
diff --g
- move RSA padding into separate struct.
More padding members should be added into padding,
therefore having separate struct for padding parameters will
make this more readable.
Signed-off-by: Arek Kusztal
---
app/test/test_cryptodev_asym.c | 10 ++--
drivers/common/cpt/cpt_ucode_as
- Clarified where should output be stored of signature
decryption with padding none.
PMD is not able to know what padding algorithm was used,
therefore decrypted signature should be returned to the user.
- Removed incorrect big-endian constraints.
Not all data in RSA can be treated as big endian in
- Added salt length and optional label.
Common parameters to PSS and OAEP padding for RSA.
- Changed RSA hash padding fields names.
Now it corresponds to the RSA documents.
Signed-off-by: Arek Kusztal
---
lib/cryptodev/rte_crypto_asym.h | 19 +--
1 file changed, 17 insertions(+),
Adds a very basic introduction to JSON vector sets in
the fips validation example application. This patch set
will only introduce the AES-GCM test using a JSON request
file because the other algorithms need more information
than what is given in the new JSON format.
v9:
* doc update.
v8:
* Fixed
From: Brandon Lo
Added a check for RTE_HAS_JANSSON into the meson
configuration file for JSON support.
Signed-off-by: Brandon Lo
Acked-by: Gowrishankar Muthukrishnan
---
examples/fips_validation/meson.build | 4
1 file changed, 4 insertions(+)
diff --git a/examples/fips_validation/meson
From: Brandon Lo
Added json-specific functions and other information needed to
test the new FIPS test vectors.
Signed-off-by: Brandon Lo
Signed-off-by: Gowrishankar Muthukrishnan
---
v7:
* fix switch clause for info.file_type.
v5:
* fix typo in macro name for prefixes.
v2:
* fix type of pref
From: Brandon Lo
Added functions to parse the required information from a vector set
given in the new json format.
Signed-off-by: Brandon Lo
Signed-off-by: Gowrishankar Muthukrishnan
---
v7:
* pulled json_info define from next patch.
v3:
* fix checkpatch warnings
v2:
* fix for loop initializ
From: Brandon Lo
Added the ability to use the json format as the input
and output of the example application.
Signed-off-by: Brandon Lo
Signed-off-by: Gowrishankar Muthukrishnan
--
v8:
* dont steal refcount on write_set using _new as latter is updated
subsequently in same function.
* fix fip
From: Brandon Lo
Adds json-specific testing and writeback function. Allows
the user to test AES-GCM vector sets.
Signed-off-by: Brandon Lo
Acked-by: Gowrishankar Muthukrishnan
---
v8:
* reset IV generation var in every test group as initialization.
v3:
* fix checkpatch warnings
---
examples/
1 - 100 of 134 matches
Mail list logo
