Re: [PATCH v2 0/4] clean up zero-length arrays

2022-06-02 Thread Hemant Agrawal
Series- Acked-by:  Hemant Agrawal On 6/2/2022 9:43 PM, Bruce Richardson wrote: This patchset adds a coccinelle script to clean-up zero-length arrays in structures. The final patches are the result of running that script on the DPDK repository. V2: rebased to fix apply conflict Bruce Richards

Re: [PATCH] maintainers: update for nxp devices

2022-06-02 Thread Hemant Agrawal
Acked-by:  Hemant Agrawal On 6/3/2022 11:20 AM, nipun.gu...@nxp.com wrote: From: Nipun Gupta Update and add maintainers for NXP devices and RAW device API Signed-off-by: Nipun Gupta --- MAINTAINERS | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/MAINTAI

[PATCH] maintainers: update for nxp devices

2022-06-02 Thread nipun . gupta
From: Nipun Gupta Update and add maintainers for NXP devices and RAW device API Signed-off-by: Nipun Gupta --- MAINTAINERS | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index f34f6fa2e9..030100ebc7 100644 --- a/MAINTAINERS +++ b/MA

[PATCH] common/cnxk: alloc link map array if HWS is available

2022-06-02 Thread Shijith Thotton
Link map array is required only if work slots are available. Signed-off-by: Shijith Thotton --- drivers/common/cnxk/roc_sso.c | 45 +++ 1 file changed, 25 insertions(+), 20 deletions(-) diff --git a/drivers/common/cnxk/roc_sso.c b/drivers/common/cnxk/roc_sso.c in

[dpdk-dev] [PATCH] common/cnxk: add ROC API to free MCAM entry

2022-06-02 Thread psatheesh
From: Satheesh Paul Add ROC API to free the given MCAM entry. If the MCAM entry has flow counter associated, this API will clear and free the flow counter. Signed-off-by: Satheesh Paul Reviewed-by: Jerin Jacob Kollanukkaran --- drivers/common/cnxk/roc_npc.c | 63 +++-

[dpdk-dev] [PATCH v3] examples/ipsec-secgw: support more flow patterns and actions

2022-06-02 Thread psatheesh
From: Satheesh Paul Added support to create flow rules with count, mark and security actions and mark pattern. Signed-off-by: Satheesh Paul --- v3: * Fixed IPv4 and IPv6 dst addr setting in flow pattern spec v2: * Updated documentation in ipsec_secgw.rst doc/guides/sample_app_ug/ipsec_secgw.r

Re: [PATCH v5] app/testpmd: add help messages for multi-process

2022-06-02 Thread Ferruh Yigit
On 6/2/2022 3:24 AM, Min Hu (Connor) wrote: Hi, all,    any comments? 在 2022/3/7 9:04, Min Hu (Connor) 写道: From: Huisong Li This patch adds help messages for multi-process. --num-procs=N: set the total number of multi-process instances --proc-id=id:  set the id of the current process from mu

Re: [PATCH 14/14] net/nfp: modify RSS logic

2022-06-02 Thread Ferruh Yigit
On 6/2/2022 2:53 AM, Jin Liu wrote: Modify RSS-related interface functions, as the NFDK firmware support feature NFP_NET_CFG_CTRL_RSS2 rather than NFP_NET_CFG_CTRL_RSS. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas

Re: [PATCH 08/14] net/nfp: structure adjustment

2022-06-02 Thread Ferruh Yigit
On 6/2/2022 2:52 AM, Jin Liu wrote: Add and modify the nfp PMD struct and macro that will be used by NFDK firmware. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund <...> @@ -114,9 +166,14 @@ struct nfp

Re: [PATCH 07/14] net/nfp: support NFDK firmware

2022-06-02 Thread Ferruh Yigit
On 6/2/2022 2:52 AM, Jin Liu wrote: Modify nfp driver logic, add firmware version (NFD3 or NFDK) judgment, will according to the firmware version, mount different driver functions. Creating a new set of dev_ops for new FW is a way and it works, but it looks like it creates some duplication of

Re: [PATCH 06/14] net/nfp: support NFP3800 card

2022-06-02 Thread Ferruh Yigit
On 6/2/2022 2:52 AM, Jin Liu wrote: Add support for a new type of NIC NFP3800 card, and update some network card data acquisition interface functions. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- drive

Re: [PATCH 01/14] net/nfp: change the coding style

2022-06-02 Thread Ferruh Yigit
On 6/2/2022 2:52 AM, Jin Liu wrote: From: Chaoyong He Change the coding style of some logics, to make it more compatible with the DPDK coding style. Signed-off-by: Chaoyong He Signed-off-by: Jin Liu Signed-off-by: Niklas Söderlund <...> @@ -404,9 +403,8 @@ nfp_net_init(struct rte_eth_de

Re: [PATCH 00/14] Add support of NFP3800 chip and firmware with NFDk

2022-06-02 Thread Ferruh Yigit
On 6/2/2022 2:52 AM, Jin Liu wrote: NFD is part of NFP firmware, and there only exist a NFD3 version before this patch series. This patch series mainly add the support of the new NFP3800 chip use firmware with NFD3/NFDk. Hi Jin, This set requires some documentation update. Current driver doc

[RFC] dpaa2: replace system("echo ...") with file i/o

2022-06-02 Thread Stephen Hemminger
Using system() is a bad idea in driver code because it introduces a number of potential security issues. The codeql analysis tool flags this a potential security issue. Instead just use normal stdio to do the same thing. Compile test only, do not have this hardware and therefore can not test this

Re: [PATCH v4 1/2] lpm: add const to lpm arg of rte_lpm_lookup

2022-06-02 Thread Thomas Monjalon
01/06/2022 13:15, Stanislaw Kardach: > All other rte_lpm_lookup* functions take lpm argument as a const. As the > basic rte_lpm_lookup() performs the same function, it should also do > that. > > As this function is inline, no API/ABI change happens. It is an API change and should be noted in the

Re: [PATCH 12/12] test/ipsec: fix build with GCC 12

2022-06-02 Thread Medvedkin, Vladimir
Hi David, On 18/05/2022 11:16, David Marchand wrote: GCC 12 raises the following warning: In function ‘_mm256_loadu_si256’, inlined from ‘rte_mov32’ at ../lib/eal/x86/include/rte_memcpy.h:319:9, inlined from ‘rte_mov128’ at ../lib/eal/x86/include/rte_memcpy.h:344:2,

RE: [PATCH v7 1/6] baseband/acc100: update companion PF configure function

2022-06-02 Thread Chautru, Nicolas
Hi Kevin, > -Original Message- > From: Kevin Traynor > Sent: Thursday, June 2, 2022 2:50 AM > To: Chautru, Nicolas ; dev@dpdk.org; > gak...@marvell.com; t...@redhat.com; maxime.coque...@redhat.com > Cc: tho...@monjalon.net; Kinsella, Ray ; > Richardson, Bruce ; > hemant.agra...@nxp.com;

Re: dumpcap w/ pcapng produces out of order/negative times

2022-06-02 Thread Ben Magistro
In case others wind up here, the issue described here appears to be addressed by "libpcapng: fix timestamp wrapping in output files". Thanks for the patch! https://patches.dpdk.org/project/dpdk/patch/20220517100115.157888-1-quen...@armitage.org.uk/ On Fri, Jan 14, 2022 at 11:15 AM Stephen Hemmin

[PATCH v2 4/4] app: examples: replace zero-length arrays with undimensioned ones

2022-06-02 Thread Bruce Richardson
This patch replaces instances of zero-sized arrays i.e. those at the end of structures with "[0]" with the more standard syntax of "[]". Replacement was done using coccinelle script, with some cleanup of whitespace afterwards. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup Acked-by: Ste

[PATCH v2 3/4] lib: replace zero-length arrays with undimensioned ones

2022-06-02 Thread Bruce Richardson
This patch replaces instances of zero-sized arrays i.e. those at the end of structures with "[0]" with the more standard syntax of "[]". Replacement was done using coccinelle script, with some cleanup of whitespace afterwards. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup Acked-by: Ste

[PATCH v2 2/4] drivers: replace zero-length arrays with undimensioned ones

2022-06-02 Thread Bruce Richardson
This patch replaces instances of zero-sized arrays i.e. those at the end of structures with "[0]" with the more standard syntax of "[]". Replacement was done using coccinelle script, with some cleanup of whitespace afterwards. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup Acked-by: Ste

[PATCH v2 1/4] cocci: add script for zero-length arrays in structs

2022-06-02 Thread Bruce Richardson
Add script to replace [0] with [] when used at the end of a struct. The script also includes an additional struct member to match against so as to avoid issues with arrays with only a single zero-length element. Signed-off-by: Bruce Richardson Acked-by: Morten Brørup Acked-by: Stephen Hemminger

[PATCH v2 0/4] clean up zero-length arrays

2022-06-02 Thread Bruce Richardson
This patchset adds a coccinelle script to clean-up zero-length arrays in structures. The final patches are the result of running that script on the DPDK repository. V2: rebased to fix apply conflict Bruce Richardson (4): cocci: add script for zero-length arrays in structs drivers: replace zer

Re: [PATCH 0/4] clean up zero-length arrays

2022-06-02 Thread Stephen Hemminger
On Thu, 2 Jun 2022 16:08:30 +0100 Bruce Richardson wrote: > This patchset adds a coccinelle script to clean-up zero-length > arrays in structures. The final patches are the result of running > that script on the DPDK repository. > > Bruce Richardson (4): > cocci: add script for zero-length ar

Re: [PATCH] kni: fix device address set

2022-06-02 Thread Stephen Hemminger
On Wed, 6 Apr 2022 16:22:13 +0800 "Min Hu (Connor)" wrote: > Currently, run KNI APP When Kernel version is 5.17. When quit the APP, > dmesg buffer get calltrace, info like: > [ 5965.847401] rte_kni: Creating kni... > [ 6225.627205] vEth0 (unregistered): Current addr: 70 fd 45 d0 72 a7 00.. > [ 6

RE: [PATCH 0/4] clean up zero-length arrays

2022-06-02 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Thursday, 2 June 2022 17.09 > > This patchset adds a coccinelle script to clean-up zero-length > arrays in structures. The final patches are the result of running > that script on the DPDK repository. > > Bruce Richardson (4): >

[PATCH v6 3/4] lib/power: add get and set API for scaling freq min and max with pstate mode

2022-06-02 Thread Kevin Laatz
Add new get/set API to allow the user or application to set the minimum and maximum frequencies to use when scaling. Previously, the frequency range was determined by the HW capabilities of the CPU. With this new API, the user or application can constrain this if required. Signed-off-by: Kevin Laa

[PATCH v6 4/4] examples/l3fwd_power: add cli for configurable options

2022-06-02 Thread Kevin Laatz
Add CLI options to l3fwd_power to utilize the new power APIs introduced in this patchset. These CLI options allow the user to configure the heuritstics made available through the new API via the l3fwd_power application options. Signed-off-by: Kevin Laatz Acked-by: Anatoly Burakov --- v3: move s

[PATCH v6 2/4] lib/power: add get and set API for pause duration

2022-06-02 Thread Kevin Laatz
Add new get/set API for configuring 'pause_duration' which used to adjust the pause mode callback duration. Signed-off-by: Kevin Laatz Acked-by: Ray Kinsella Acked-by: Anatoly Burakov Tested-by: David Hunt --- v6: fix unit of pause duration in doc v5: add doc entry for new API v3: changed pri

[PATCH v6 1/4] lib/power: add get and set API for emptypoll max

2022-06-02 Thread Kevin Laatz
Add new get/set APIs to configure emptypoll max which is used to determine when a queue can go into sleep state. Signed-off-by: Kevin Laatz Acked-by: Ray Kinsella Tested-by: David Hunt --- v5: add doc entry for new API --- doc/guides/prog_guide/power_man.rst | 6 ++ lib/power/rte_power_p

[PATCH v6 0/4] Add APIs for configurable power options

2022-06-02 Thread Kevin Laatz
The power library contains some variables which are currently set by defines, hard-coded values or set using sysfs values. In order to configure these, code changes and recompiles are required, making configuring these variables tedious. This patchset introduces some new get/set APIs which allow u

[PATCH 4/4] app: examples: replace zero-length arrays with undimensioned ones

2022-06-02 Thread Bruce Richardson
This patch replaces instances of zero-sized arrays i.e. those at the end of structures with "[0]" with the more standard syntax of "[]". Replacement was done using coccinelle script, with some cleanup of whitespace afterwards. Signed-off-by: Bruce Richardson --- app/test/test_table_tables.c |

[PATCH 3/4] lib: replace zero-length arrays with undimensioned ones

2022-06-02 Thread Bruce Richardson
This patch replaces instances of zero-sized arrays i.e. those at the end of structures with "[0]" with the more standard syntax of "[]". Replacement was done using coccinelle script, with some cleanup of whitespace afterwards. Signed-off-by: Bruce Richardson --- lib/cryptodev/cryptodev_pmd.h

[PATCH 2/4] drivers: replace zero-length arrays with undimensioned ones

2022-06-02 Thread Bruce Richardson
This patch replaces instances of zero-sized arrays i.e. those at the end of structures with "[0]" with the more standard syntax of "[]". Replacement was done using coccinelle script, with some cleanup of whitespace afterwards. Signed-off-by: Bruce Richardson --- drivers/bus/dpaa/include/netcfg.h

[PATCH 1/4] cocci: add script for zero-length arrays in structs

2022-06-02 Thread Bruce Richardson
Add script to replace [0] with [] when used at the end of a struct. The script also includes an additional struct member to match against so as to avoid issues with arrays with only a single zero-length element. Signed-off-by: Bruce Richardson --- devtools/cocci/zero_length_array.cocci | 21

[PATCH 0/4] clean up zero-length arrays

2022-06-02 Thread Bruce Richardson
This patchset adds a coccinelle script to clean-up zero-length arrays in structures. The final patches are the result of running that script on the DPDK repository. Bruce Richardson (4): cocci: add script for zero-length arrays in structs drivers: replace zero-length arrays with undimensioned

Re: [PATCH v5 2/4] lib/power: add get and set API for pause duration

2022-06-02 Thread Kevin Laatz
On 02/06/2022 15:01, Burakov, Anatoly wrote: On 31-May-22 10:59 AM, Kevin Laatz wrote: Add new get/set API for configuring 'pause_duration' which used to adjust the pause mode callback duration. Signed-off-by: Kevin Laatz Acked-by: Ray Kinsella Acked-by: Anatoly Burakov Tested-by: David Hun

RE: [EXT] [PATCH v5 06/12] cryptodev: add elliptic curve diffie hellman

2022-06-02 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Thursday, June 2, 2022 4:25 PM > To: Ray Kinsella > Cc: Kusztal, ArkadiuszX ; dev@dpdk.org; Zhang, > Roy Fan > Subject: RE: [EXT] [PATCH v5 06/12] cryptodev: add elliptic curve diffie > hellman > > > > > Akhil Goyal writes: > > > > >

RE: [EXT] [PATCH v5 06/12] cryptodev: add elliptic curve diffie hellman

2022-06-02 Thread Akhil Goyal
> > Akhil Goyal writes: > > >> - Added elliptic curve Diffie-Hellman parameters. > >> Point multiplication allows the user to process every phase of > >> ECDH, but for phase 1, user should not really care about the generator. > >> The user does not even need to know what the generator looks like

Re: [EXT] [PATCH v5 06/12] cryptodev: add elliptic curve diffie hellman

2022-06-02 Thread Ray Kinsella
Akhil Goyal writes: >> - Added elliptic curve Diffie-Hellman parameters. >> Point multiplication allows the user to process every phase of >> ECDH, but for phase 1, user should not really care about the generator. >> The user does not even need to know what the generator looks like, >> therefor

Re: [PATCH v5 2/4] lib/power: add get and set API for pause duration

2022-06-02 Thread Burakov, Anatoly
On 31-May-22 10:59 AM, Kevin Laatz wrote: Add new get/set API for configuring 'pause_duration' which used to adjust the pause mode callback duration. Signed-off-by: Kevin Laatz Acked-by: Ray Kinsella Acked-by: Anatoly Burakov Tested-by: David Hunt --- v5: add doc entry for new API v3: chang

Re: [PATCH v4 1/2] ethdev: fix one address occupies two indexes in MAC addrs

2022-06-02 Thread Andrew Rybchenko
Cc more driver maintainers On 6/2/22 06:16, lihuisong (C) wrote: 在 2022/6/2 1:49, Andrew Rybchenko 写道: On 6/1/22 09:39, Min Hu (Connor) wrote: From: Huisong Li The dev->data->mac_addrs[0] will be changed to a new MAC address when applications modify the default MAC address by rte_eth_dev_de

RE: [PATCH v8 1/3] ethdev: introduce protocol header based buffer split

2022-06-02 Thread Ding, Xuan
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Thursday, June 2, 2022 9:21 PM > To: Wu, WenxuanX ; tho...@monjalon.net; Li, > Xiaoyun ; ferruh.yi...@xilinx.com; Singh, Aman Deep > ; dev@dpdk.org; Zhang, Yuying > ; Zhang, Qi Z ; > jerinjac...@gmail.com > Cc: step...@netwo

RE: [EXT] [PATCH v5 06/12] cryptodev: add elliptic curve diffie hellman

2022-06-02 Thread Akhil Goyal
> - Added elliptic curve Diffie-Hellman parameters. > Point multiplication allows the user to process every phase of > ECDH, but for phase 1, user should not really care about the generator. > The user does not even need to know what the generator looks like, > therefore setting ec xform would make

Re: [dpdk-dev] [PATCH v1] build: ccache support for cross build

2022-06-02 Thread Bruce Richardson
On Thu, Jun 02, 2022 at 05:30:36PM +0530, Jerin Jacob wrote: > On Thu, Jun 2, 2022 at 4:25 PM Thomas Monjalon wrote: > > > > 02/06/2022 11:43, Jerin Jacob: > > > On Thu, Jun 2, 2022 at 3:11 PM Bruce Richardson > > > wrote: > > > > > > > > On Thu, Jun 02, 2022 at 02:53:55PM +0530, jer...@marvell.c

Re: [PATCH v3 0/4] support HW Rx/Tx descriptor dump

2022-06-02 Thread Andrew Rybchenko
On 6/1/22 21:26, Andrew Rybchenko wrote: Again, please, add maintainers using --cc-cmd or --to-cmd to patches. Also, don't forget to keep in Cc participants of the discussion. On 6/1/22 10:49, Min Hu (Connor) wrote: This patch set support HW Rx/Tx descriptor dump by using procinfo tool. One m

Re: [PATCH v8 1/3] ethdev: introduce protocol hdr based buffer split

2022-06-02 Thread Andrew Rybchenko
Is it the right one since it is listed in patchwork? On 6/1/22 16:50, wenxuanx...@intel.com wrote: From: Wenxuan Wu Currently, Rx buffer split supports length based split. With Rx queue offload RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT enabled and Rx packet segment configured, PMD will be able to split

Re: [PATCH v8 1/3] ethdev: introduce protocol header based buffer split

2022-06-02 Thread Andrew Rybchenko
There are two v8 1/3 patches in my mailbox. Which one is the right one? On 6/1/22 16:50, wenxuanx...@intel.com wrote: From: Wenxuan Wu Currently, Rx buffer split supports length based split. With Rx queue offload RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT enabled and Rx packet segment configured, PMD wil

Re: [PATCH v8 0/3] ethdev: introduce protocol type based header split

2022-06-02 Thread Andrew Rybchenko
On 6/1/22 16:50, wenxuanx...@intel.com wrote: From: Wenxuan Wu Buffer split consists of splitting a received packet into two separate 'two' is misleading above. Buffer split supports many segments. regions based on the packet content. As far as I know buffer split is not based on packet c

RE: [v1 0/4] Add support for modifying ECN in IPv4/IPv6 header

2022-06-02 Thread Sean Zhang (Networking SW)
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, June 2, 2022 7:45 PM > To: Sean Zhang (Networking SW) ; Matan Azrad > ; Slava Ovsiienko > Cc: dev@dpdk.org > Subject: Re: [v1 0/4] Add support for modifying ECN in IPv4/IPv6 header > > External email: Use caution opening links

[PATCH] net/mlx5: support ESP item on Windows

2022-06-02 Thread Raja Zidane
ESP item is not supported on windows, yet it is expanded from the expansion graph when trying to create default flow to RSS all packets. Support ESP item match (without ability to match on SPI field on windows). Split ESP validation per OS. Signed-off-by: Raja Zidane Acked-by: Matan Azrad ---

[PATCH] app/testpmd: fix packets segments allocation

2022-06-02 Thread Raja Zidane
When --mbuf-size cmdln parameter is specified, the segments to scatter packets on are allocated sequentially from these extra memory pools (the mbuf for the first segment is allocated from the first pool, the second one from the second pool, and so on, if segment number is greater then pool’s the m

Re: [EXT] Re: [PATCH v7 3/6] baseband/acc100: remove RTE prefix for internal macro

2022-06-02 Thread Maxime Coquelin
Hi Akhil, On 6/1/22 19:15, Akhil Goyal wrote: Hi Maxime, Reviewed-by: Maxime Coquelin Do you have any more comments on other patches of this series? If not, please ack other patches as well. I'm done with my review of the series. Regards Maxime

[PATCH] examples/pipeline: fix build

2022-06-02 Thread Ali Alnubani
This patch fixes the following build failure seen on Ubuntu 16.04 with gcc 5.4.0 because of uninitialized variable: [..] examples/pipeline/cli.c:2853:9: error: 'session_id' may be used uninitialized in this function [-Werror=maybe-uninitialized] [..] Fixes: 172254555f9f ("examples/pipeli

Re: [PATCH v7 4/6] baseband/acc100: introduce PMD for ACC101

2022-06-02 Thread Maxime Coquelin
On 6/1/22 00:31, Nicolas Chautru wrote: Support for ACC101 as a derivative of ACC100. Integrated in unified driver and reusing existing code when possible. Signed-off-by: Nicolas Chautru --- MAINTAINERS | 1 + doc/guides/bbdevs/acc100.rst | 37 +

Re: [dpdk-dev] [PATCH v1] build: ccache support for cross build

2022-06-02 Thread Jerin Jacob
On Thu, Jun 2, 2022 at 4:25 PM Thomas Monjalon wrote: > > 02/06/2022 11:43, Jerin Jacob: > > On Thu, Jun 2, 2022 at 3:11 PM Bruce Richardson > > wrote: > > > > > > On Thu, Jun 02, 2022 at 02:53:55PM +0530, jer...@marvell.com wrote: > > > > From: Jerin Jacob > > > > > > > > By default, ccache is

[PATCH] app/test-eventdev: wait for workers before cryptodev destroy

2022-06-02 Thread Shijith Thotton
Destroying cryptodev resources before exiting workers are not safe. Moved cryptodev destroy after worker thread exit in main thread. Fixes: de2bc16e1bd1 ("app/eventdev: add crypto producer mode") Signed-off-by: Shijith Thotton --- app/test-eventdev/evt_main.c | 6 +++--- 1 file changed, 3 inser

Re: [v1 1/4] ethdev: add IPv4/IPv6 ECN header rewrite action

2022-06-02 Thread Ferruh Yigit
On 6/2/2022 6:48 AM, Ori Kam wrote: -Original Message- From: Ferruh Yigit Sent: Wednesday, June 1, 2022 9:51 PM To: Sean Zhang (Networking SW) ; Ori Kam ; Xiaoyun Li ; Aman Singh ; Yuying Zhang ; NBU-Contact-Thomas Monjalon (EXTERNAL) ; Andrew Rybchenko Cc: dev@dpdk.org; Jiawei(Jon

Re: [v1 0/4] Add support for modifying ECN in IPv4/IPv6 header

2022-06-02 Thread Ferruh Yigit
On 6/1/2022 7:51 PM, Ferruh Yigit wrote: On 4/2/2022 8:11 AM, Sean Zhang wrote: This patch set adds support for modifying ECN fields in IPv4/IPv6 header, and also adds support for modify_filed action in meter. Jiawei Wang (1):    ethdev: add IPv4/IPv6 ECN header rewrite action Sean Zhang (3):

Re: [dpdk-dev] [PATCH] ethdev: promote port ownership API as stable

2022-06-02 Thread Ferruh Yigit
On 10/28/2021 9:55 AM, Andrew Rybchenko wrote: On 10/28/21 11:37 AM, Kinsella, Ray wrote: On 28/10/2021 09:34, Thomas Monjalon wrote: The port ownership concept was introduced in ethdev in DPDK 18.02. Not sure it is used by applications except those using failsafe or netvsc. It can also be

[PATCH] net/mlx5: fix entry size in HWS construct data ipool

2022-06-02 Thread Michael Baum
The mlx5_action_construct_data structure memory is managed by ipool named acts_ipool. The size of one entry in this ipool is mistakenly defined as size of rte_flow_hw structure. This size is used to reset in the allocated part. When the size is incorrect it resets memory that does not belong to it

Re: [dpdk-dev] [PATCH v1] build: ccache support for cross build

2022-06-02 Thread Thomas Monjalon
02/06/2022 11:43, Jerin Jacob: > On Thu, Jun 2, 2022 at 3:11 PM Bruce Richardson > wrote: > > > > On Thu, Jun 02, 2022 at 02:53:55PM +0530, jer...@marvell.com wrote: > > > From: Jerin Jacob > > > > > > By default, ccache is not used for cross build[1]. > > > Update all cross files to use ccache i

Re: [RFC v2 2/2] ethdev: queue-based flow aged report

2022-06-02 Thread Jack Min
On 6/2/22 14:10, Ori Kam wrote: Hi, Hello, -Original Message- From: Andrew Rybchenko Sent: Wednesday, June 1, 2022 9:21 PM Subject: Re: [RFC v2 2/2] ethdev: queue-based flow aged report Again, summary must not be a statement. On 6/1/22 10:39, Xiaoyu Min wrote: When application use

Re: [PATCH 11/12] app/flow-perf: fix build with GCC 12

2022-06-02 Thread Bruce Richardson
On Wed, May 18, 2022 at 12:16:56PM +0200, David Marchand wrote: > GCC 12 raises the following warning: > > ../app/test-flow-perf/main.c: In function ‘start_forwarding’: > ../app/test-flow-perf/main.c:1737:28: error: ‘sprintf’ may write a > terminating nul past the end of the destination >

Re: [PATCH 10/12] vhost/crypto: fix build with GCC 12

2022-06-02 Thread Bruce Richardson
On Wed, May 18, 2022 at 12:16:55PM +0200, David Marchand wrote: > GCC 12 raises the following warning: > > In file included from ../lib/mempool/rte_mempool.h:46, > from ../lib/mbuf/rte_mbuf.h:38, > from ../lib/vhost/vhost_crypto.c:7: > ../lib/vhost/vhost_crypto.c:

RE: [EXT] [PATCH v5 00/12] cryptodev: rsa, dh, ecdh changes

2022-06-02 Thread Akhil Goyal
> This patchset introduces some of changes discussed on mailing list for 22.07 > release in cryptodev asym. > > Key changes: > > - It fixes API for RSA (expescially signature paddings) > - Adds Elliptic-Curve Diffie-Hellman > - Adds Eliiptic-Curve point verification > - Adds RSA missing padding f

RE: [PATCH v2] sched: enable CMAN at runtime

2022-06-02 Thread Danilewicz, MarcinX
+this time to dpdk.org , to test removal of automatic footer Hi Cristian, < snip > > > +++ b/lib/sched/rte_sched.h > > @@ -128,6 +128,8 @@ extern "C" { > > enum rte_sched_cman_mode { > > RTE_SCHED_CMAN_RED, /**< Random Early Detection (RED) */ > > RTE_SCHED_CMAN_PIE, /**< Proportional I

[Bug 1024] [dpdk-22.07][meson test] driver-tests/link_bonding_mode4_autotest bond handshake failed

2022-06-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1024 Bug ID: 1024 Summary: [dpdk-22.07][meson test] driver-tests/link_bonding_mode4_autotest bond handshake failed Product: DPDK Version: unspecified Hardware: All

Re: [PATCH 03/12] crypto/ipsec_mb: fix build with GCC 12

2022-06-02 Thread Bruce Richardson
On Wed, May 18, 2022 at 12:16:48PM +0200, David Marchand wrote: > GCC 12 raises the following warning: > > In function ‘__rte_ring_enqueue_elems_64’, > inlined from ‘__rte_ring_enqueue_elems’ at > ../lib/ring/rte_ring_elem_pvt.h:130:3, > inlined from ‘__rte_ring_do_hts_enqueue_elem

Re: [PATCH v7 1/6] baseband/acc100: update companion PF configure function

2022-06-02 Thread Kevin Traynor
Hi Nicolas, On 31/05/2022 23:31, Nicolas Chautru wrote: Update of the device configuration function from PF used for bbdev-test to latest sequence for ACC199 PRQ device and matching version in pf_bb_config 22.03. Fixes: b17d70922d5d ("baseband/acc100: add configure function") Cc:sta...@dpdk.org

Re: [dpdk-dev] [PATCH v1] build: ccache support for cross build

2022-06-02 Thread Jerin Jacob
On Thu, Jun 2, 2022 at 3:11 PM Bruce Richardson wrote: > > On Thu, Jun 02, 2022 at 02:53:55PM +0530, jer...@marvell.com wrote: > > From: Jerin Jacob > > > > By default, ccache is not used for cross build[1]. > > Update all cross files to use ccache if it is available > > in build machine. > > > >

Re: [dpdk-dev] [PATCH v1] build: ccache support for cross build

2022-06-02 Thread Bruce Richardson
On Thu, Jun 02, 2022 at 02:53:55PM +0530, jer...@marvell.com wrote: > From: Jerin Jacob > > By default, ccache is not used for cross build[1]. > Update all cross files to use ccache if it is available > in build machine. > > [1] > https://mesonbuild.com/Machine-files.html > > Signed-off-by: Jer

Re: [RFC v2 2/2] ethdev: queue-based flow aged report

2022-06-02 Thread Jack Min
On 6/2/22 02:21, Andrew Rybchenko wrote: Again, summary must not be a statement. I'l re-phrase it. On 6/1/22 10:39, Xiaoyu Min wrote: When application use queue-based flow rule management and operate the same flow rule on the same queue, e.g create/destroy/query, API of querying aged flow rule

Re: [RFC v2 1/2] ethdev: port flags for pre-configuration flow hints

2022-06-02 Thread Jack Min
On 6/2/22 02:20, Andrew Rybchenko wrote: Summary must not be a statement. May be: ethdev: add strict queue to pre-configuration flow hints Ok, I'll change to this. On 6/1/22 10:39, Xiaoyu Min wrote: The data-path focused flow rule management can manage flow rules in more optimized way than tr

[dpdk-dev] [PATCH v1] build: ccache support for cross build

2022-06-02 Thread jerinj
From: Jerin Jacob By default, ccache is not used for cross build[1]. Update all cross files to use ccache if it is available in build machine. [1] https://mesonbuild.com/Machine-files.html Signed-off-by: Jerin Jacob --- config/arm/arm32_armv8_linux_gcc | 4 ++-- config/arm/arm64_arm

Re: [PATCH v2 1/1] vfio: add page-by-page mapping API

2022-06-02 Thread Ray Kinsella
Anatoly Burakov writes: > Currently, there is no way to map memory for DMA in a way that allows > unmapping it partially later, because some IOMMU's do not support > partial unmapping. There is a workaround of mapping all of these > segments separately, but this is inconvenient and silly, so th

[PATCH] ip_frag: add IPv4 fast fragment switch and test data

2022-06-02 Thread Huichao Cai
Some NIC drivers support DEV_TX_OFFLOAD_MBUF_FAST_FREE offload( Device supports optimization for fast release of mbufs.When set application must guarantee that per-queue all mbufs comes from the same mempool and has refcnt = 1).In order to adapt to this offload function,we need to modify the existi

Re: [PATCH 6/6] net/vhost: perform SW checksum in Tx path

2022-06-02 Thread Maxime Coquelin
Hi Wenwu, Sorry, I missed your review. On 5/7/22 05:20, Ma, WenwuX wrote: -Original Message- From: Maxime Coquelin Sent: 2022年5月5日 18:27 To: dev@dpdk.org; jasow...@redhat.com; Xia, Chenbo ; david.march...@redhat.com; olivier.m...@6wind.com Cc: sta...@dpdk.org; Maxime Coquelin Subjec

RE: [PATCH] net/mlx5: fix linux stats gathering function

2022-06-02 Thread Matan Azrad
From: Geoffrey Le Gourriérec > This patch encompasses a few fixes carried by a previous patch that aimed to > support bonding device stats counting. > > - If mlx5_os_read_dev_stat fails, it returns 1 instead of a > negative value, causing mlx5_xstats_get to return an invalid > number of coun

Re: [PATCH v7 6/6] baseband/acc100: configuration of ACC101 from PF

2022-06-02 Thread Maxime Coquelin
On 6/1/22 00:31, Nicolas Chautru wrote: Adding companion function common to ACC100/ACC101 which can be called from bbdev-test when running from PF. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 6 +- drivers/baseband/acc100/rte_acc100_cfg.h | 4 +- dri

RE: [PATCH] net/vhost: add flag to control wait queuing

2022-06-02 Thread Ling, WeiX
> -Original Message- > From: Yuan Wang > Sent: Wednesday, June 1, 2022 10:26 PM > To: maxime.coque...@redhat.com; Xia, Chenbo ; > dev@dpdk.org > Cc: Hu, Jiayu ; He, Xingguang > ; Wang, YuanX ; > sta...@dpdk.org > Subject: [PATCH] net/vhost: add flag to control wait queuing > > update_queu

Re: [dpdk-dev] [PATCH v2 1/1] vfio: add page-by-page mapping API

2022-06-02 Thread David Marchand
Hello Anatoly, On Tue, Nov 2, 2021 at 4:54 PM Burakov, Anatoly wrote: > > On 28-Oct-21 3:09 PM, Anatoly Burakov wrote: > > Currently, there is no way to map memory for DMA in a way that allows > > unmapping it partially later, because some IOMMU's do not support > > partial unmapping. There is a

RE: [PATCH v3] lib/eal: fix segfaults due to thread exit order

2022-06-02 Thread Zeng, ZhichaoX
Hi Stephen: > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, May 31, 2022 12:29 AM > To: Zeng, ZhichaoX > Cc: dev@dpdk.org; Yang, Qiming ; Richardson, Bruce > ; hka...@marvell.com; david.march...@redhat.com; > acon...@redhat.com; Matz, Olivier > > ; > tho...@monjalon.n

Re: [PATCH v7 2/6] baseband/acc100: add protection for some negative scenario

2022-06-02 Thread Maxime Coquelin
On 6/1/22 00:31, Nicolas Chautru wrote: Catch exception in PMD in case of invalid input parameter. Fixes: 5ad5060f8f7a ("baseband/acc100: add LDPC processing functions") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 6 ++ 1 file cha

Re: [PATCH 00/20] fix memory leaks in error handling

2022-06-02 Thread David Marchand
On Tue, Feb 22, 2022 at 7:18 PM Weiguo Li wrote: > > This series fix some memory leaks in error handling. > > I write a coccinelle script to detect these issues, and > fix them after exclude a small number of false positives. > > FYI, the script is as follows: > // > // Find possible memory leaks

Re: [PATCH 13/20] net/ice: fix memory leaks in error handlings

2022-06-02 Thread David Marchand
On Tue, Feb 22, 2022 at 7:20 PM Weiguo Li wrote: > @@ -713,21 +714,28 @@ ice_hash_parse_raw_pattern(struct ice_adapter *ad, > msk_buf[j] = tmp_val * 16 + tmp_c - '0'; > } > > - if (ice_parser_create(&ad->hw, &psr)) > - return -rte_errno; > -

Re: [PATCH] examples/l2fwd: add check of Rx packets count

2022-06-02 Thread Jerin Jacob
On Wed, May 25, 2022 at 2:44 PM Rahul Bhansali wrote: > > An additional check is added to avoid extra processing if > receive packets are 0. > > Performance impact: with Marvell OCTEON TX2 platform, observed an > improvement by ~14%. > > Signed-off-by: Rahul Bhansali Acked-by: Jerin Jacob > -

Re: [PATCH v3] doc: update Linux core isolation guide

2022-06-02 Thread Jerin Jacob
On Wed, May 18, 2022 at 1:30 AM wrote: > > From: Pavan Nikhilesh > > Update Linux core isolation guide to include isolation from > timers, rcu processing and IRQs. rcu-> RCU > > Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob > --- > v3 Changes: > - Add additional information links f

Re: [PATCH] examples/l3fwd: fix issue with MTU set on event mode

2022-06-02 Thread Jerin Jacob
On Thu, Apr 21, 2022 at 7:47 PM Nithin Dabilpuram wrote: > > MTU configuration is missing for ethdev when using eventmode > when user provides it via "--max-pkt-len" config. It is only > done in poll mode setup. Fix the event mode setup code to > do the same. > > Fixes: 1bb4a528c41f ("ethdev: fix