RE: [PATCH v8 4/5] vhost: support async dequeue for split ring

2022-06-16 Thread Ding, Xuan
Hi David, > -Original Message- > From: David Marchand > Sent: Thursday, June 16, 2022 10:40 PM > To: Ding, Xuan > Cc: Maxime Coquelin ; Xia, Chenbo > ; dev ; Hu, Jiayu > ; Jiang, Cheng1 ; Pai G, Sunil > ; lian...@liangbit.com; Wang, YuanX > ; Mcnamara, John > Subject: Re: [PATCH v8 4/5]

[PATCH 2/2] crypto/cnxk: fix compilation with GCC 12

2022-06-16 Thread Ankur Dwivedi
The following warning is observed with GCC 12 compilation: In file included from ../drivers/crypto/cnxk/cn10k_cryptodev_ops.c:17: In function ‘fill_sg_comp_from_iov’, inlined from ‘cpt_pdcp_chain_alg_prep’ at ../drivers/crypto/cnxk/cnxk_se.h:1194:8, inlined from ‘cpt_fc_enc_hmac_pr

[PATCH 1/2] common/cpt: fix compilation with GCC 12

2022-06-16 Thread Ankur Dwivedi
The following warning is observed with GCC 12 compilation: In function ‘fill_sg_comp_from_iov’, inlined from ‘cpt_zuc_snow3g_enc_prep’ at ../drivers/common/cpt/cpt_ucode.h:1672:9, inlined from ‘cpt_fc_enc_hmac_prep’ at ../drivers/common/cpt/cpt_ucode.h:2472:3, inlined f

[PATCH 0/2] fix compilation with GCC 12

2022-06-16 Thread Ankur Dwivedi
This patch series resolves compilation warning observed with GCC 12, in common/cpt and crypto/cnxk. Ankur Dwivedi (2): common/cpt: fix compilation with GCC 12 crypto/cnxk: fix compilation with GCC 12 drivers/common/cpt/cpt_mcode_defines.h | 2 +- drivers/common/cpt/cpt_ucode.h | 21

Re: dpdk address sanitizer

2022-06-16 Thread David Marchand
Hello, On Fri, Jun 17, 2022 at 6:08 AM Juan Pablo L. wrote: > > Hello, I am new to dpdk ... i would like to trace memory usage and detect > memory leaks, valgrind as well as address sanitizer (gcc) report some memory > loss at application end. For the life of me, i cannot figure it out ... i >

[PATCH] vhost: fix log for async dequeue

2022-06-16 Thread David Marchand
Since the commit 02798b073520 ("vhost: improve virtio-net layer logs"), vhost logs contain the socket path as a prefix. Async dequeue path was copied from the sync dequeue path but a log was incorrect. Fixes: 84d5204310d7 ("vhost: support async dequeue for split ring") Signed-off-by: David Marcha

Re: [PATCH v2] vhost: fix missing statistics update

2022-06-16 Thread David Marchand
On Thu, Jun 16, 2022 at 11:47 AM wrote: > > From: Xuan Ding > > This patch adds missing per-virtqueue statistics in async dequeue path. This would not happen if the async code was better integrated with the sync code. > > Fixes: 84d5204310d7("vhost: support async dequeue for split ring") > > Si

[PATCH] net/mlx5: fix RSS expansion for patterns with ICMP item

2022-06-16 Thread Gregory Etelson
MLX5 PMD RSS expansion implementation added L4 UDP or TCP headers after ICMP. For example: ETH / IPv4 / ICMP expanded into ETH / IPv4 / ICMP / {UDP | TCP} ETH / IPv6 / ICMPv6 expanded into ETH / IPv6 / ICMPv6 / {UDP | TCP} The patch updates PMD expansion scheme to handle ICMP and ICMPv6 types as

RE: [PATCH v2] vhost: fix missing statistics update

2022-06-16 Thread Ling, WeiX
> -Original Message- > From: xuan.d...@intel.com > Sent: Thursday, June 16, 2022 5:45 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Ma, WenwuX > ; Ding, Xuan > Subject: [PATCH v2] vhost: fix missing statistics update > > From: Xuan Ding > > This patc

[PATCH v2 3/3] net/ixgbe: move bypass init in a testpmd command

2022-06-16 Thread David Marchand
Introduce a new command and remove the last part of specific port init from testpmd. Signed-off-by: David Marchand --- app/test-pmd/meson.build | 1 - app/test-pmd/testpmd.c| 4 -- doc/guides/nics/ixgbe.rst | 7 +++ drivers/net/ixgbe/ixgbe_testpmd.c | 82 +

[PATCH v2 2/3] net/ixgbe: move testpmd commands

2022-06-16 Thread David Marchand
Move related specific testpmd commands into this driver directory. The bypass init is left in testpmd at this point and can be moved later. While at it, fix checkpatch warnings. Signed-off-by: David Marchand --- Changes since v1: - rebased on next-net, - updated link in documentation to directly

[PATCH v2 1/3] app/testpmd: restore ixgbe bypass commands

2022-06-16 Thread David Marchand
Since the switch to meson, ixgbe bypass commands were ineffective as the RTE_LIBRTE_IXGBE_BYPASS build flag was not set, even though the net/ixgbe driver had this feature compiled in. Fixes: 16ade738fd0d ("app/testpmd: build with meson") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- app

[PATCH v2] net/bonding: move testpmd commands

2022-06-16 Thread David Marchand
Move related specific testpmd commands into this driver directory. While at it, fix checkpatch warnings. Signed-off-by: David Marchand --- Changes since v1: - rebased on next-net, - updated link in documentation to directly point at commands, Changes since RFC v2: - renamed file in net/bonding,

Re: [PATCH] ice/base: fix gcc 12 warning stringop-overflow

2022-06-16 Thread David Marchand
On Fri, Jun 17, 2022 at 3:29 AM Wu, WenxuanX wrote: > > Thanks, do I need to send a new version to resolve formatting issues? You are not a new contributor, please pay attention to such details. To answer your question, I don't think there is a need for a new version unless someone has a better

RE: [PATCH v2 13/19] rawdev: remove unneeded header includes

2022-06-16 Thread Hemant Agrawal
Acked-by: Hemant Agrawal > -Original Message- > From: Sean Morrissey > Sent: Thursday, June 16, 2022 8:47 PM > To: Sachin Saxena (OSS) ; Hemant Agrawal > > Cc: dev@dpdk.org; Sean Morrissey > Subject: [PATCH v2 13/19] rawdev: remove unneeded header includes > Importance: High > > Thes

Re:Re: [PATCH v7] ip_frag: add IPv4 options fragment and test data

2022-06-16 Thread Huichao Cai
Hi,Stephen There are some things I don't quite understand.Hope you can answer that. This will help me avoid similar errors in subsequent patch submissions.Thanks! There are places where rte_memcpy functions are used: In test_ipfrag.c: from func test_

Re: [PATCH] net/virtio: fix socket nonblocking mode affects initialization

2022-06-16 Thread Stephen Hemminger
On Fri, 17 Jun 2022 10:42:29 +0800 Yuan Wang wrote: > The virtio-user initialization requires unix socket to receive backend > messages in block mode. However, vhost_user_update_link_state() sets > the same socket to nonblocking via fcntl, which affects all threads. > Enabling the rxq interrupt c

[PATCH] net/virtio: fix socket nonblocking mode affects initialization

2022-06-16 Thread Yuan Wang
The virtio-user initialization requires unix socket to receive backend messages in block mode. However, vhost_user_update_link_state() sets the same socket to nonblocking via fcntl, which affects all threads. Enabling the rxq interrupt can causes both of these behaviors to occur concurrently, with

RE: [PATCH v2 00/15] mlx5/vdpa: optimize live migration time

2022-06-16 Thread Li Zhang
Hi Maxime, Are there any comments about the patch? Please let me know and thanks help review it. Regards, Li Zhang > -Original Message- > From: Maxime Coquelin > Sent: Thursday, June 16, 2022 5:02 PM > To: Li Zhang ; Ori Kam ; Slava > Ovsiienko ; Matan Azrad ; > Shahaf Shuler > Cc: dev

RE: [PATCH] ice/base: fix gcc 12 warning stringop-overflow

2022-06-16 Thread Wu, WenxuanX
Thanks, do I need to send a new version to resolve formatting issues? > -Original Message- > From: David Marchand > Sent: 2022年6月16日 22:29 > To: Wu, WenxuanX > Cc: Yang, Qiming ; Zhang, Qi Z > ; dev ; Thomas Monjalon > ; Stephen Hemminger > ; dpdk stable > Subject: Re: [PATCH] ice/base:

[PATCH v4 2/2] event/dlb2: add ldb port specific COS support

2022-06-16 Thread Timothy McDaniel
DLB supports 4 class of service domains, to aid in managing the device bandwidth across ldb ports. This commit allows specifying which ldb ports will participate in the COS scheme, which class they are a part of, and the specific bandwidth percentage associated with each class. The cumulative bandw

[PATCH v4 1/2] event/dlb2: add CQ weight support

2022-06-16 Thread Timothy McDaniel
Enabling the weight limit on a CQ allows the enqueued QEs' 2-bit weight value (representing weights of 1, 2, 4, and 8) to factor into whether a CQ is full. If the sum of the weights of the QEs in the CQ meet or exceed its weight limit, DLB will stop scheduling QEs to it (until software pops enough

[PATCH v4 0/2] Rebase DLB2 port_cos and cq_weight patches

2022-06-16 Thread Timothy McDaniel
This patch rebases the following previously submitted patches against the latest dpdk-next-eventdev (for-main) branch, and organizes them in a patch series instead of individually. Changes since V3: Fix a CentOS79-64 build error Changes since V2: Fix a misleading if statement (guard error) C

[PATCH v3 2/2] event/dlb2: add ldb port specific COS support

2022-06-16 Thread Timothy McDaniel
DLB supports 4 class of service domains, to aid in managing the device bandwidth across ldb ports. This commit allows specifying which ldb ports will participate in the COS scheme, which class they are a part of, and the specific bandwidth percentage associated with each class. The cumulative bandw

[PATCH v3 1/2] event/dlb2: add CQ weight support

2022-06-16 Thread Timothy McDaniel
Enabling the weight limit on a CQ allows the enqueued QEs' 2-bit weight value (representing weights of 1, 2, 4, and 8) to factor into whether a CQ is full. If the sum of the weights of the QEs in the CQ meet or exceed its weight limit, DLB will stop scheduling QEs to it (until software pops enough

[PATCH v3 0/2] Rebase DLB2 port_cos and cq_weight patches

2022-06-16 Thread Timothy McDaniel
This patch rebases the following previously submitted patches against the latest dpdk-next-eventdev (for-main) branch. Rebase DLB2 port_cos and cq_weight patches Changes since V2: Fix a misleading if statement (guard error) Changes since V1: Fixed a bug in the port-specific cos patch where we we

[PATCH v2 2/2] event/dlb2: add ldb port specific COS support

2022-06-16 Thread Timothy McDaniel
DLB supports 4 class of service domains, to aid in managing the device bandwidth across ldb ports. This commit allows specifying which ldb ports will participate in the COS scheme, which class they are a part of, and the specific bandwidth percentage associated with each class. The cumulative bandw

[PATCH v2 1/2] event/dlb2: add CQ weight support

2022-06-16 Thread Timothy McDaniel
Enabling the weight limit on a CQ allows the enqueued QEs' 2-bit weight value (representing weights of 1, 2, 4, and 8) to factor into whether a CQ is full. If the sum of the weights of the QEs in the CQ meet or exceed its weight limit, DLB will stop scheduling QEs to it (until software pops enough

[PATCH v2 0/2] Rebase DLB2 port_cos and cq_weight patches

2022-06-16 Thread Timothy McDaniel
This patch simply rebases the following previously submitted patches against the latest dpdk-next-eventdev (for-main) branch. Rebase DLB2 port_cos and cq_weight patches This patch simply rebases the following previously submitted patches against the latest dpdk-next-eventdev (for-main) branch. C

[PATCH v3 1/1] net/iavf: add vector PMD for Arm for basic Rx path

2022-06-16 Thread Kathleen Capella
This patch adds the basic NEON Rx path to the iavf driver. It does not include scatter or flex varieties. Tested on N1SDP platform with Intel XL710 NIC and 40G connection. Tested with a single core and testpmd rxonly mode. Saw no significant performance difference between scalar and Arm vPMD paths

[PATCH v3 0/1] net/iavf: add vector PMD for Arm for basic Rx path

2022-06-16 Thread Kathleen Capella
This patch adds the basic NEON Rx path to iavf driver, including the main Rx function (_recv_raw_pkts_vec) and the functions it depends on. Also, NEON vector path has been added to iavf_set_rx_function. Functional testing with testpmd (rxonly and mac forwarding) and l3fwd have been done on N1SDP pl

RE: [PATCH v2 1/1] net/iavf: add vector PMD for Arm for basic Rx path

2022-06-16 Thread Kathleen Capella
> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, June 7, 2022 3:56 AM > To: Zhang, Qi Z ; Kathleen Capella > ; Wu, Jingjing ; Xing, > Beilei ; Ruifeng Wang > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; Dharmik Thakkar > > Subject: RE: [PATCH v2 1/1] net/iavf: add vector P

DTS WG Meeting Minutes - 5/15

2022-06-16 Thread Owen Hilyard
This meeting had a lot of book-keeping. In previous meetings we've had to skip reviewing some action items due to time constraints. This meeting we had time to review most of them, so we have a larger-than-normal "Review Action Items" section. Attendees - Owen Hilyard - Juraj Linke

[PATCH v2 2/2] app/testpmd: fix GTP PSC raw processing

2022-06-16 Thread Gregory Etelson
Use generic GTP PSC header definition in raw handler. Fixes: 9213c50e36fa ("app/testpmd: support GTP PSC option in raw sets") cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Reviewed-by: Viacheslav Ovsiienko --- v2: fix raw GTP PSC object creation. --- app/test-pmd/cmdline_flow.c | 20 +

[PATCH v2 1/2] net: fix GTP PSC headers

2022-06-16 Thread Gregory Etelson
Fix bitmap fields order in little endian section of GTP PSC headers. Fixes: e8ca1479cdc4 ("net: add extension header for GTP PSC") cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Reviewed-by: Viacheslav Ovsiienko --- v2: --- lib/net/rte_gtp.h | 17 + 1 file changed, 9 insert

[PATCH v2 1/2] app/testpmd: add test for remote PD and CTX

2022-06-16 Thread Michael Baum
Add mlx5 internal option in testpmd run-time function "port attach" to add another parameter named "mlx5_socket" for attaching port and add 2 devargs before. The arguments are "cmd_fd" and "pd_handle" using to import device created out of PMD. Testpmd application import it using IPC, and updates t

[PATCH v2 2/2] app/testpmd: add test for external RxQ

2022-06-16 Thread Michael Baum
Add mlx5 internal test for map and unmap external RxQs. This patch adds to Testpmd app a runtime function to test the mapping API. For insert mapping use this command: testpmd> port (port_id) ext_rxq map (rte_queue_id) (hw_queue_id) For insert mapping use this command: testpmd> port (port_i

[PATCH v2 0/2] mlx5/testpmd: external RxQ tests

2022-06-16 Thread Michael Baum
Recently [1] mlx5 PMD added support for external queues, in the following patches add internal tests for in Testpmd application. [1] https://patchwork.dpdk.org/project/dpdk/cover/20220224232511.3238707-1-michae...@nvidia.com/ Depends-on: series=112853 ("introduce per-queue available descriptor th

Re: [dpdk-dev] [PATCH 8/8] net/bnxt: fix the check for autoneg enablement in the PHY FW

2022-06-16 Thread Ferruh Yigit
On 6/15/2022 3:57 PM, Kalesh A P wrote: From: Somnath Kotur The current combination of checks to determine whether autoneg is enabled in the card is a bit convoluted and may become incorrect as well in the future as one of the fields being used - auto_link_speed might become deprecated. Switch

Re: [dpdk-dev] [PATCH 4/8] net/bnxt: allow Tx only or Rx only configs in PMD

2022-06-16 Thread Ferruh Yigit
On 6/15/2022 3:56 PM, Kalesh A P wrote: From: Damodharam Ammepalli Currently, we fail the init/probe of pmd if eth_dev->data->nb_tx_queues or eth_dev->data->nb_rx_queues is 0. We are removing this check. Is there a valid usecase for Rx only or Tx only config? I assume testpmd doesn't suppo

Re: [dpdk-dev] [PATCH 1/8] net/bnxt: remove assert for zero data len in Tx path

2022-06-16 Thread Ferruh Yigit
On 6/15/2022 3:56 PM, Kalesh A P wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. From: Somnath Kotur Currently the PMD tries to detect a potential 0 byte DMA by

[PATCH] net/qede: fix build with GCC 13

2022-06-16 Thread Ferruh Yigit
Reproduced with "gcc (GCC) 13.0.0 20220616 (experimental)" Build error: In file included from ../drivers/net/qede/qede_debug.c:9: ../drivers/net/qede/qede_debug.c: In function ‘qed_grc_dump_addr_range’: ../drivers/net/qede/base/ecore.h:95:17: warning: overflow in conversion fro

Re: [PATCH v2] app/testpmd: add throughput stats for forward streams

2022-06-16 Thread Singh, Aman Deep
Hi Junfeng, Thanks for the patch. On 6/6/2022 3:09 PM, Junfeng Guo wrote: 1. add throughput statistics (in pps) for forward streams. 2. display the forward statistics for every forward stream. v2: add parameter descriptions and fix commit title. Signed-off-by: Xiao Wang Signed-off-by: Junfe

Re: [PATCH v7] ip_frag: add IPv4 options fragment and test data

2022-06-16 Thread Stephen Hemminger
On Thu, 16 Jun 2022 17:10:46 +0200 David Marchand wrote: > On Fri, Apr 15, 2022 at 5:27 AM Huichao Cai wrote: > > > > According to RFC791,the options may appear or not in datagrams. > > They must be implemented by all IP modules (host and gateways). > > What is optional is their transmission in

[PATCH v2 19/19] vhost: remove unneeded header includes

2022-06-16 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/vhost/vhost.h | 2 -- lib/vhost/vhost_user.h | 1 - 2 files changed, 3 deletions(-) diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h index 14235aaf81..4ebcb7448a 100644 --- a/lib/v

[PATCH v2 18/19] timer: remove unneeded header includes

2022-06-16 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/timer/rte_timer.c | 2 -- lib/timer/rte_timer.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/lib/timer/rte_timer.c b/lib/timer/rte_timer.c index c51a393e5c..d914fcbf60 100644 ---

[PATCH v2 17/19] table: remove unneeded header includes

2022-06-16 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/table/rte_swx_table_learner.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/table/rte_swx_table_learner.c b/lib/table/rte_swx_table_learner.c index f7f8e8aea9..3502cbd2a4 100644

[PATCH v2 16/19] stack: remove unneeded header includes

2022-06-16 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/stack/rte_stack.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/stack/rte_stack.h b/lib/stack/rte_stack.h index 91fc570767..af8c3804f3 100644 --- a/lib/stack/rte_stack.h +++ b/lib

[PATCH v2 15/19] sched: remove unneeded header includes

2022-06-16 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/sched/rte_pie.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/sched/rte_pie.c b/lib/sched/rte_pie.c index d37b79e6dd..c84f75a18c 100644 --- a/lib/sched/rte_pie.c +++ b/lib/sched/r

[PATCH v2 14/19] regexdev: remove unneeded header includes

2022-06-16 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/regexdev/rte_regexdev.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/regexdev/rte_regexdev.h b/lib/regexdev/rte_regexdev.h index 3bce8090f6..ce3dba5c10 100644 --- a/lib/regexdev/

[PATCH v2 13/19] rawdev: remove unneeded header includes

2022-06-16 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/rawdev/rte_rawdev.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/rawdev/rte_rawdev.h b/lib/rawdev/rte_rawdev.h index 14e8eb972f..66080eae9e 100644 --- a/lib/rawdev/rte_rawdev.h +

[PATCH v2 12/19] power: remove unneeded header includes

2022-06-16 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/power/power_pstate_cpufreq.c | 1 - lib/power/rte_power_empty_poll.h | 3 --- lib/power/rte_power_pmd_mgmt.c | 2 -- lib/power/rte_power_pmd_mgmt.h | 5 - 4 files changed, 11 delet

[PATCH v2 11/19] net: remove unneeded header includes

2022-06-16 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/net/rte_net.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/net/rte_net.h b/lib/net/rte_net.h index 53a7f4d360..56611fc8f9 100644 --- a/lib/net/rte_net.h +++ b/lib/net/rte_net.h @

[PATCH v2 10/19] meter: remove unneeded header includes

2022-06-16 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/meter/rte_meter.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/meter/rte_meter.c b/lib/meter/rte_meter.c index da01429a8b..4549b97d36 100644 --- a/lib/meter/rte_meter.c +++ b/

[PATCH v2 09/19] mempool: remove unneeded header includes

2022-06-16 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/mempool/rte_mempool.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h index 3ada37cb86..8d6554fbae 100644 --- a/lib/mempool/rte_mem

[PATCH v2 08/19] jobstats: remove unneeded header includes

2022-06-16 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/jobstats/rte_jobstats.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/jobstats/rte_jobstats.h b/lib/jobstats/rte_jobstats.h index 023d9dd15c..45b460e603 100644 --- a/lib/jobstats/

[PATCH v2 07/19] ip_frag: remove unneeded header includes

2022-06-16 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/ip_frag/ip_frag_internal.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/ip_frag/ip_frag_internal.c b/lib/ip_frag/ip_frag_internal.c index b436a4c931..043b0ffba3 100644 --- a/lib/

[PATCH v2 06/19] hash: remove unneeded header includes

2022-06-16 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/hash/rte_cuckoo_hash.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c index 490f94af4b..de7d941638 100644 --- a/lib/hash/rte_

[PATCH v2 05/19] gso: remove unneeded header includes

2022-06-16 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/gso/gso_common.c | 1 - lib/gso/gso_common.h | 1 - lib/gso/gso_tcp4.h| 1 - lib/gso/gso_tunnel_tcp4.h | 1 - lib/gso/gso_tunnel_udp4.h | 1 - lib/gso/gso_udp4.h|

[PATCH v2 04/19] gpudev: remove unneeded header includes

2022-06-16 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/gpudev/gpudev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/gpudev/gpudev.c b/lib/gpudev/gpudev.c index 56033f4a5f..ee3ae80f82 100644 --- a/lib/gpudev/gpudev.c +++ b/lib/gpudev/

[PATCH v2 03/19] ethdev: remove unneeded header includes

2022-06-16 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/ethdev/rte_class_eth.c | 2 -- lib/ethdev/rte_ethdev.c| 9 - lib/ethdev/rte_ethdev.h| 1 - lib/ethdev/rte_flow.c | 2 -- lib/ethdev/rte_flow.h | 3 --- lib/ethdev

[PATCH v2 02/19] eal: remove unneeded header includes

2022-06-16 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/eal/common/eal_common_config.c | 1 - lib/eal/common/eal_common_launch.c | 1 - lib/eal/common/eal_common_log.c| 1 - lib/eal/linux/eal.c| 1 - lib/eal/linux/eal_thread

[PATCH v2 01/19] cmdline: remove unneeded header includes

2022-06-16 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/cmdline/cmdline_cirbuf.h| 1 - lib/cmdline/cmdline_parse_num.c | 3 --- lib/cmdline/cmdline_socket.c| 4 lib/cmdline/cmdline_socket.h| 1 - 4 files changed, 9 deletions(-)

[PATCH v2 00/19] remove IWYU flagged headers

2022-06-16 Thread Sean Morrissey
This patchset removes unused header includes flagged by the IWYU tool for the 22.07 release. V2: * Fix various build issues. Sean Morrissey (19): cmdline: remove unneeded header includes eal: remove unneeded header includes ethdev: remove unneeded header includes gpudev: remove unneeded h

Re: [PATCH v7] ip_frag: add IPv4 options fragment and test data

2022-06-16 Thread David Marchand
On Fri, Apr 15, 2022 at 5:27 AM Huichao Cai wrote: > > According to RFC791,the options may appear or not in datagrams. > They must be implemented by all IP modules (host and gateways). > What is optional is their transmission in any particular datagram, > not their implementation.So we have to dea

Re: [PATCH v2 00/15] Add support of NFP3800 chip and firmware with NFDk

2022-06-16 Thread Ferruh Yigit
On 6/16/2022 3:39 AM, Jin Liu wrote: NFD is part of NFP firmware, and there only exist a NFD3 version before this patch series. This patch series mainly add the support of the new NFP3800 chip use firmware with NFD3/NFDk. * Changes since v1 - Added updated documentation for NFP to cover NFD. - D

Re: [PATCH v2 08/15] net/nfp: support NFP3800 card

2022-06-16 Thread Ferruh Yigit
On 6/16/2022 3:39 AM, Jin Liu wrote: Add support for a new type of NIC NFP3800 card, and update some network card data acquisition interface functions. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund ---

Re: [PATCH v2 02/15] doc: update nfp documentation

2022-06-16 Thread Ferruh Yigit
On 6/16/2022 3:39 AM, Jin Liu wrote: This set patches add support for a new type of NFP nic NFP3800 and the firmware with NFDk. Signed-off-by: Jin Liu Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- doc/guides/nics/nfp.rst | 10 ++ 1 file changed, 6 insertions(+), 4

Re: [PATCH v2 01/15] doc: update release note

2022-06-16 Thread Ferruh Yigit
On 6/16/2022 3:39 AM, Jin Liu wrote: Add support for a new type NFP NIC NFP3800 and firmware with NFDk. Signed-off-by: Jin Liu Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- doc/guides/rel_notes/release_22_07.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/gu

Re: [PATCH v2] vhost/crypto: fix build with GCC 12

2022-06-16 Thread David Marchand
On Thu, Jun 16, 2022 at 11:32 AM David Marchand wrote: > > GCC 12 raises the following warning: > > In file included from ../lib/mempool/rte_mempool.h:46, > from ../lib/mbuf/rte_mbuf.h:38, > from ../lib/vhost/vhost_crypto.c:7: > ../lib/vhost/vhost_crypto.c: In fun

[PATCH v3] vhost/crypto: fix build with GCC 12

2022-06-16 Thread David Marchand
GCC 12 raises the following warning: In file included from ../lib/mempool/rte_mempool.h:46, from ../lib/mbuf/rte_mbuf.h:38, from ../lib/vhost/vhost_crypto.c:7: ../lib/vhost/vhost_crypto.c: In function ‘rte_vhost_crypto_fetch_requests’: ../lib/eal/x86/include/rte_m

[Bug 1038] Illegal instruction found when running dpdk-test (built with GCC 12.1) on CPU has no AVX instruction set

2022-06-16 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1038 Bug ID: 1038 Summary: Illegal instruction found when running dpdk-test (built with GCC 12.1) on CPU has no AVX instruction set Product: DPDK Version: 21.11 Hard

Re: [PATCH v8 4/5] vhost: support async dequeue for split ring

2022-06-16 Thread David Marchand
On Thu, Jun 16, 2022 at 4:38 PM David Marchand wrote: > > On Mon, May 16, 2022 at 1:16 PM wrote: > > +static __rte_always_inline uint16_t > > +virtio_dev_tx_async_split(struct virtio_net *dev, struct vhost_virtqueue > > *vq, > > + struct rte_mempool *mbuf_pool, struct rte_mbuf **pk

Re: [PATCH v8 4/5] vhost: support async dequeue for split ring

2022-06-16 Thread David Marchand
On Mon, May 16, 2022 at 1:16 PM wrote: > +static __rte_always_inline uint16_t > +virtio_dev_tx_async_split(struct virtio_net *dev, struct vhost_virtqueue *vq, > + struct rte_mempool *mbuf_pool, struct rte_mbuf **pkts, > uint16_t count, > + int16_t dma_id, uint16_t vcha

RE: [Bug 1035] __rte_raw_cksum() crash with misaligned pointer

2022-06-16 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Thursday, 16 June 2022 15.58 > > On 2022-06-16 08:44, Morten Brørup wrote: > > +CC Olivier Matz , Network Headers maintainer > > > >> -Original Message- > >> From: Morten Brørup > >> Sent: den 15 juni 2022 16:41 > >> To: Emil

Re: [PATCH] ice/base: fix gcc 12 warning stringop-overflow

2022-06-16 Thread David Marchand
Title should start with net/ice/base:. On Thu, Jun 16, 2022 at 12:35 PM wrote: > > From: Wenxuan Wu > > Gcc with -O2 flag, would retrieve the value in one time. > This patch changed the type of fv_idx in struct ice_recp_grp_entry to > align with its callers which is also u8 type. > > When u8 idx

RE: [dpdk-dev] [RFC PATCH v2] raw/ptdma: introduce ptdma driver

2022-06-16 Thread Sebastian, Selwin
[AMD Official Use Only - General] We were having issues with iommu. Now we will try to push the patch without iommu enabled. Will split patch into smaller ones and submit soon. Thanks, Selwin -Original Message- From: Thomas Monjalon Sent: Wednesday, June 15, 2022 8:06 PM To: Sebastian

[PATCH 2/2] event/dlb2: add ldb port specific COS support

2022-06-16 Thread Timothy McDaniel
DLB supports 4 class of service domains, to aid in managing the device bandwidth across ldb ports. This commit allows specifying which ldb ports will participate in the COS scheme, which class they are a part of, and the specific bandwidth percentage associated with each class. The cumulative bandw

[PATCH 1/2] event/dlb2: add CQ weight support

2022-06-16 Thread Timothy McDaniel
Enabling the weight limit on a CQ allows the enqueued QEs' 2-bit weight value (representing weights of 1, 2, 4, and 8) to factor into whether a CQ is full. If the sum of the weights of the QEs in the CQ meet or exceed its weight limit, DLB will stop scheduling QEs to it (until software pops enough

[PATCH 0/2] Rebase DLB2 port_cos and cq_weight patches

2022-06-16 Thread Timothy McDaniel
This patch simply rebases the following previously submitted patches against the latest dpdk-next-eventdev (for-main) branch. Timothy McDaniel (2): event/dlb2: add CQ weight support event/dlb2: add ldb port specific COS support drivers/event/dlb2/dlb2.c | 323 ++

[PATCH] pipeline: rework optimization pattern for header generation

2022-06-16 Thread Cristian Dumitrescu
The P4 language requires marking a header as valid before any of the header fields are written as opposed to after the writes are done. Hence, the optimization of replacing the sequence of instructions to generate a header by reading it from the table action data with a single DMA internal instruct

RE: Vector optimized IP checksum

2022-06-16 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Thursday, 16 June 2022 15.46 > > On 2022-06-16 09:07, Morten Brørup wrote: > > Hi Jasvinder, > > > > As the Packet CRC maintainer, have you considered adding vector > > optimized variants of the rte_raw_cksum() function? > > > > The

Re: [Bug 1035] __rte_raw_cksum() crash with misaligned pointer

2022-06-16 Thread Mattias Rönnblom
On 2022-06-16 08:32, Emil Berg wrote: I've been sketching on an efficient solution to this. What about something along the way below? I've run it with the combinations of: even buf, even len even buf, odd len odd buf, even len odd buf, odd len and it seems to give the same results as the older

Re: [Bug 1035] __rte_raw_cksum() crash with misaligned pointer

2022-06-16 Thread Mattias Rönnblom
On 2022-06-16 08:44, Morten Brørup wrote: +CC Olivier Matz , Network Headers maintainer -Original Message- From: Morten Brørup Sent: den 15 juni 2022 16:41 To: Emil Berg ; bugzi...@dpdk.org Cc: dev@dpdk.org Subject: RE: [Bug 1035] __rte_raw_cksum() crash with misaligned pointer From:

Re: Vector optimized IP checksum

2022-06-16 Thread Mattias Rönnblom
On 2022-06-16 09:07, Morten Brørup wrote: Hi Jasvinder, As the Packet CRC maintainer, have you considered adding vector optimized variants of the rte_raw_cksum() function? The current implementation is vectorized by the compiler. In my experience, hand-crafting it using SIMD intrinsics doe

Re: [PATCH] app: fix gcc 12 array bounds warning

2022-06-16 Thread David Marchand
On Thu, Jun 16, 2022 at 12:40 PM wrote: > > From: Wenxuan Wu > > when n == 1000, and it would overflow the array size of 4 bytes with > nul terminator. Change the logic to avoid this warning. > > Fixes: 15c431864000 ("app/flow-perf: add packet forwarding support") > Cc: sta...@dpdk.org > Signed-o

RE: [EXT] Re: [PATCH 01/12] common/cpt: fix build with GCC 12

2022-06-16 Thread Ankur Dwivedi
Hi David, >-Original Message- >From: David Marchand >Sent: Thursday, June 16, 2022 3:00 PM >To: Ankur Dwivedi ; Jerin Jacob Kollanukkaran > >Cc: Anoob Joseph ; Thomas Monjalon >; Ferruh Yigit ; dpdk stable >; dev ; Akhil Goyal >Subject: Re: [EXT] Re: [PATCH 01/12] common/cpt: fix build w

Re: [PATCH] common/cnxk: update extra stats for inline device

2022-06-16 Thread Jerin Jacob
On Mon, Jun 13, 2022 at 3:20 PM Rakesh Kudurumalla wrote: > > inline device NIX RX and RQ stats are updated > on PKTIO extra stats > > Signed-off-by: Rakesh Kudurumalla Updated the git commit as follows and applied to dpdk-next-net-mrvl/for-next-net. Thanks common/cnxk: update extra stats f

[PATCH v3 2/2] net/cnxk: support ops to update precolor VLAN table

2022-06-16 Thread skori
From: Sunil Kumar Kori Implement API to update VLAN table for pre-coloring for incoming packet per nixlf for CN10K platform. Depends-on: patch-23516 ("app/testpmd: support different input color method") Signed-off-by: Sunil Kumar Kori --- v2..v3: - Fix dscp table runtime update error. v1..v2

[PATCH v3 1/2] common/cnxk: update precolor table setup for VLAN

2022-06-16 Thread skori
From: Sunil Kumar Kori As per new spec in DPDK, VLAN priority is supported for precoloring of input packet. Depends-on: patch-23516 ("app/testpmd: support different input color method") Signed-off-by: Sunil Kumar Kori --- v2..v3: - No changes. v1..v2: - Aligned with latest input color spec.

RE: [Bug 1035] __rte_raw_cksum() crash with misaligned pointer

2022-06-16 Thread Emil Berg
I've been sketching on an efficient solution to this. What about something along the way below? I've run it with the combinations of: even buf, even len even buf, odd len odd buf, even len odd buf, odd len and it seems to give the same results as the older version of __rte_raw_cksum, before 21.0

RE: [Bug 1035] __rte_raw_cksum() crash with misaligned pointer

2022-06-16 Thread Emil Berg
Hi! We want the B option, i.e. the 6 bytes option. Perhaps adding alignment detection to __rte_raw_cksum() is a good idea. A minor comment but I think buf & 1 won't work since buf isn't an integral type, but something along that way. I'm starting to think about an efficient way to do this. Th

[PATCH] app: fix gcc 12 array bounds warning

2022-06-16 Thread wenxuanx . wu
From: Wenxuan Wu when n == 1000, and it would overflow the array size of 4 bytes with nul terminator. Change the logic to avoid this warning. Fixes: 15c431864000 ("app/flow-perf: add packet forwarding support") Cc: sta...@dpdk.org Signed-off-by: Wenxuan Wu --- app/test-flow-perf/main.c | 2 +-

[PATCH] ice/base: fix gcc 12 warning stringop-overflow

2022-06-16 Thread wenxuanx . wu
From: Wenxuan Wu Gcc with -O2 flag, would retrieve the value in one time. This patch changed the type of fv_idx in struct ice_recp_grp_entry to align with its callers which is also u8 type. When u8 idx[5] = a value u16 index[4], gcc12 would give this warning, because it is not big enough to stor

DPDK Release Status Meeting 2022-06-16

2022-06-16 Thread Mcnamara, John
Release status meeting minutes 2022-06-16 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * ARM * Intel * Marvell * Nvidia * Red Hat * Xilinx/AMD Release Dates - The following are the proposed current dat

Re: [PATCH v2 12/12] event/cnxk: offset timestamp data only if enabled on port

2022-06-16 Thread Nithin Kumar Dabilpuram
Please ignore this particular patch 12/12. It is already part of other patch. https://patchwork.dpdk.org/project/dpdk/patch/20220612175612.3101-1-pbhagavat...@marvell.com/ Thanks Nithin On 2022-06-16 2:54 PM, Nithin Dabilpuram wrote: Offset timestamp data only when enabled on the port instead

[PATCH] app: fix gcc 12 array bounds warning

2022-06-16 Thread wenxuanx . wu
From: Wenxuan Wu when n == 1000, and it would be overflow the array size of 4 bytes with nul terminator. Change the logic to avoid this warning. Fixes: 15c431864000 ("app/flow-perf: add packet forwarding support") Cc: sta...@dpdk.org Signed-off-by: Wenxuan Wu --- app/test-flow-perf/main.c | 2

[PATCH 1/2] app: fix gcc 12 array bounds warning

2022-06-16 Thread wenxuanx . wu
From: Wenxuan Wu when n == 1000, and it would be overflow the array size of 4 bytes with nul terminator. Change the logic to avoid this warning. Fixes: 15c431864000 ("app/flow-perf: add packet forwarding support") Cc: sta...@dpdk.org Signed-off-by: Wenxuan Wu --- app/test-flow-perf/main.c | 2

[PATCH v2 2/2] net/cnxk: support ops to update precolor VLAN table

2022-06-16 Thread skori
From: Sunil Kumar Kori Implement API to update VLAN table for pre-coloring for incoming packet per nixlf for CN10K platform. Depends-on: patch-23516 ("app/testpmd: support different input color method") Signed-off-by: Sunil Kumar Kori --- v1..v2: - Aligned with latest input color spec. driv

[PATCH v2 1/2] common/cnxk: update precolor table setup for VLAN

2022-06-16 Thread skori
From: Sunil Kumar Kori As per new spec in DPDK, VLAN priority is supported for precoloring of input packet. Depends-on: patch-23516 ("app/testpmd: support different input color method") Signed-off-by: Sunil Kumar Kori --- v1..v2: - Aligned with latest input color spec. drivers/common/cnxk/r

  1   2   >