Re: dpdk address sanitizer

Thank you very much, I will try that. Get Outlook for Android From: David Marchand Sent: Thursday, June 16, 2022 11:45:33 PM To: Juan Pablo L. Cc: us...@dpdk.org ; Burakov, Anatoly ; Dmitry Kozlyuk ; dev ; c...@dpdk.org Subject: Re: dpd

[PATCH v3 18/18] vhost: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/vhost/vhost.h | 2 -- lib/vhost/vhost_user.h | 1 - 2 files changed, 3 deletions(-) diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h index 14235aaf81..4ebcb7448a 100644 --- a/lib/v

[PATCH v3 17/18] timer: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/timer/rte_timer.c | 2 -- lib/timer/rte_timer.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/lib/timer/rte_timer.c b/lib/timer/rte_timer.c index c51a393e5c..d914fcbf60 100644 ---

[PATCH v3 16/18] table: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/table/rte_swx_table_learner.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/table/rte_swx_table_learner.c b/lib/table/rte_swx_table_learner.c index f7f8e8aea9..3502cbd2a4 100644

[PATCH v3 15/18] stack: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/stack/rte_stack.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/stack/rte_stack.h b/lib/stack/rte_stack.h index 91fc570767..af8c3804f3 100644 --- a/lib/stack/rte_stack.h +++ b/lib

[PATCH v3 14/18] sched: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/sched/rte_pie.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/sched/rte_pie.c b/lib/sched/rte_pie.c index d37b79e6dd..c84f75a18c 100644 --- a/lib/sched/rte_pie.c +++ b/lib/sched/r

[PATCH v3 13/18] regexdev: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/regexdev/rte_regexdev.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/regexdev/rte_regexdev.h b/lib/regexdev/rte_regexdev.h index 3bce8090f6..ce3dba5c10 100644 --- a/lib/regexdev/

[PATCH v3 12/18] rawdev: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Acked-by: Hemant Agrawal --- lib/rawdev/rte_rawdev.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/rawdev/rte_rawdev.h b/lib/rawdev/rte_rawdev.h index 14e8eb972f..66080eae9e 100644 --- a

[PATCH v3 11/18] power: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/power/rte_power_empty_poll.h | 3 --- lib/power/rte_power_pmd_mgmt.c | 2 -- lib/power/rte_power_pmd_mgmt.h | 4 3 files changed, 9 deletions(-) diff --git a/lib/power/rte_power_

[PATCH v3 10/18] net: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/net/rte_net.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/net/rte_net.h b/lib/net/rte_net.h index 53a7f4d360..56611fc8f9 100644 --- a/lib/net/rte_net.h +++ b/lib/net/rte_net.h @

[PATCH v3 09/18] meter: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/meter/rte_meter.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/meter/rte_meter.c b/lib/meter/rte_meter.c index da01429a8b..4549b97d36 100644 --- a/lib/meter/rte_meter.c +++ b/

[PATCH v3 08/18] jobstats: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/jobstats/rte_jobstats.h | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/jobstats/rte_jobstats.h b/lib/jobstats/rte_jobstats.h index 023d9dd15c..45b460e603 100644 --- a/lib/jobstats/

[PATCH v3 07/18] ip_frag: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/ip_frag/ip_frag_internal.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/ip_frag/ip_frag_internal.c b/lib/ip_frag/ip_frag_internal.c index b436a4c931..043b0ffba3 100644 --- a/lib/

[PATCH v3 06/18] hash: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/hash/rte_cuckoo_hash.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c index 490f94af4b..de7d941638 100644 --- a/lib/hash/rte_

[PATCH v3 05/18] gso: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/gso/gso_common.c | 1 - lib/gso/gso_common.h | 1 - lib/gso/gso_tcp4.h| 1 - lib/gso/gso_tunnel_tcp4.h | 1 - lib/gso/gso_tunnel_udp4.h | 1 - lib/gso/gso_udp4.h|

[PATCH v3 04/18] gpudev: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/gpudev/gpudev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/gpudev/gpudev.c b/lib/gpudev/gpudev.c index 56033f4a5f..ee3ae80f82 100644 --- a/lib/gpudev/gpudev.c +++ b/lib/gpudev/

[PATCH v3 03/18] ethdev: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/ethdev/rte_class_eth.c | 2 -- lib/ethdev/rte_ethdev.c| 9 - lib/ethdev/rte_ethdev.h| 1 - lib/ethdev/rte_flow.c | 2 -- lib/ethdev/rte_flow.h | 3 --- lib/ethdev

[PATCH v3 02/18] eal: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/eal/common/eal_common_config.c | 1 - lib/eal/common/eal_common_launch.c | 1 - lib/eal/common/eal_common_log.c| 1 - lib/eal/linux/eal_thread.c | 6 -- lib/eal/unix/eal_fi

[PATCH v3 01/18] cmdline: remove unneeded header includes

These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/cmdline/cmdline_cirbuf.h| 1 - lib/cmdline/cmdline_parse_num.c | 3 --- lib/cmdline/cmdline_socket.c| 4 lib/cmdline/cmdline_socket.h| 1 - 4 files changed, 9 deletions(-)

[PATCH v3 00/18] remove IWYU flagged headers

This patchset removes unused header includes flagged by the IWYU tool for the 22.07 release. V3: * Fix more linux build issues. V2: * Fix various build issues. Sean Morrissey (18): cmdline: remove unneeded header includes eal: remove unneeded header includes ethdev: remove unneeded header i

Re: [PATCH] app/testpmd: fix quit testpmd with vfs and pf

On 3/28/2022 11:06 AM, Singh, Aman Deep wrote: On 3/22/2022 12:48 PM, Ke Zhang wrote: When testpmd startups with pf and vfs,this error occurs when quitting, results in pf is released before vfs ,so the vf would access an freed heap memory. The solution is two steps: 1. Fetch the valid port va

[PATCH v2 5/5] bbdev: add new operation for FFT processing

Extension of bbdev operation to support FFT based operations. Signed-off-by: Nicolas Chautru Acked-by: Hemant Agrawal --- doc/guides/prog_guide/bbdev.rst | 130 +++ lib/bbdev/rte_bbdev.c | 11 ++- lib/bbdev/rte_bbdev.h | 76

[PATCH v2 4/5] drivers/baseband: update PMDs to expose queue per operation

Add support in existing bbdev PMDs for the explicit number of queue and priority for each operation type configured on the device. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 29 +- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c

[PATCH v2 3/5] bbdev: add device info on queue topology

Adding more options in the API to expose the number of queues exposed and related priority. Signed-off-by: Nicolas Chautru --- lib/bbdev/rte_bbdev.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h index 29c3cd4..9fd7fb0 100644 --- a/lib/bbdev

[PATCH v2 2/5] bbdev: add device status info

Added device status information, so that the PMD can expose information related to the underlying accelerator device status. Minor order change in structure to fit into padding hole. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 1 + drivers/baseband/fp

[PATCH v2 1/5] bbdev: allow operation type enum for growth

Updating the enum for rte_bbdev_op_type to allow to keep ABI compatible for enum insertion while adding padded maximum value for array need. Removing RTE_BBDEV_OP_TYPE_COUNT and instead exposing RTE_BBDEV_OP_TYPE_PADDED_MAX. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev.c | 2

[PATCH v2 0/5] bbdev changes for 22.11

Hi, Agregating together in a single serie a number of bbdev api changes previously submitted over the last few months and all targeted for 22.11 (4 different series detailed below). Related deprecation notice being pushed in 22.07 in parallel. * bbdev: add device status info * bbdev: add new o

[PATCH v4 1/1] net/iavf: add vector PMD for Arm for basic Rx path

This patch adds the basic NEON Rx path to the iavf driver. It does not include scatter or flex varieties. Tested on N1SDP platform with Intel XL710 NIC and 40G connection. Tested with a single core and testpmd rxonly mode. Saw no significant performance difference between scalar and Arm vPMD paths

[PATCH v4 0/1] net/iavf: add vector PMD for Arm for basic Rx path

This patch adds the basic NEON Rx path to iavf driver, including the main Rx function (_recv_raw_pkts_vec) and the functions it depends on. Also, NEON vector path has been added to iavf_set_rx_function. Functional testing with testpmd (rxonly and mac forwarding) and l3fwd have been done on N1SDP pl

[PATCH] test/ipsec: fix performance test failure

This patch initializes with 0 rte_ipsec_sa_prm inside the ipsec_sa struct. Before it was passed uninitialized to rte_ipsec_sa_init(), which does not check whether prm->ipsec_xform.esn.value is greater than sa->sqn_mask. Bugzilla ID: 1023 Fixes: f7f3ac6dcbe2 ("test/ipsec: add performance cases") Cc

Re: [PATCH v2 2/4] usertools: add option to change mount point owner

On Fri, Jun 17, 2022 at 02:25:06PM +0300, Dmitry Kozlyuk wrote: > Per mount(8), the previous owner and mode of the mount point > become invisible as long as this filesystem remains mounted. > Because dpdk-hugepages.py must be run as root, > the new owner would be root. > This is undesirable if the

RE: [PATCH v3 4/4] raw/ifpga/base: add PMCI sensor driver

Hi, > -Original Message- > From: Huang, Wei > Sent: Friday, June 17, 2022 15:20 > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH v3 4/4] raw/ifpga/base

RE: [PATCH] test/crypto: add key exchange dh tests

Hi Fan, > -Original Message- > From: Zhang, Roy Fan > Sent: Friday, June 17, 2022 2:35 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: gak...@marvell.com > Subject: RE: [PATCH] test/crypto: add key exchange dh tests > > Hi Arek, > > The patch cannot compile. > Looks like there are som

Re: [PATCH v2 1/4] usertools: add option to select hugetlbfs directory

On Fri, Jun 17, 2022 at 02:25:05PM +0300, Dmitry Kozlyuk wrote: > dpdk-hugepages.py had /dev/hugepages hardcoded as the mount point. > It may be desirable to setup hugepage directory at another path, > for example, when using hugepages of multiple sizes in different > directories or when granting d

[PATCH] crypto/qat: fix missing copy guards in asym mod

This commit fixes missing guards for size of memcpy, it is needed to prevent faulty access when incorrect length passed from the user. Fixes: 3b78aa7b2317 ("crypto/qat: refactor asymmetric crypto functions") Signed-off-by: Arek Kusztal --- drivers/crypto/qat/qat_asym.c | 8 1 file chan

RE: [PATCH v3 3/4] raw/ifpga/base: update flash operation interface

Hi, > -Original Message- > From: Huang, Wei > Sent: Friday, June 17, 2022 15:20 > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH v3 3/4] raw/ifpga/base

RE: [PATCH] crypto/qat: add ec point verify function

This one too should be superseded. > -Original Message- > From: Zhang, Roy Fan > Sent: Friday, June 17, 2022 2:39 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: gak...@marvell.com > Subject: RE: [PATCH] crypto/qat: add ec point verify function > > > -Original Message- > > From

[PATCH] dma/idxd: fix AVX2 code in non-datapath functions

While all systems which will use the idxd driver for hardware will support AVX2, if the driver is present the initialization functions e.g. to register logs, will be called on all systems - irrespective of HW support. This can cause issues if the system running DPDK does not have AVX2, and the comp

RE: [PATCH v3 1/4] raw/ifpga/base: add PMCI base driver

Hi, > -Original Message- > From: Huang, Wei > Sent: Friday, June 17, 2022 15:20 > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH v3 1/4] raw/ifpga/base

RE: [PATCH] crypto/qat: add ecdh key exchange algorithm

> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Thursday, April 7, 2022 3:38 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX > Subject: [PATCH] crypto/qat: add ecdh key exchange algorithm > > This commit adds Elliptic Curve Diffie-Hellman >

[PATCH] dma/idxd: fix missing default for workqueue options

When no --wq-option flag is passed to dpdk_idxd_cfg.py script, the default value used by argparse is None. This leads to later errors which are expecting an array value: TypeError: 'NoneType' object is not iterable This is fixed by specifying that the empty array should be the default if

RE: [PATCH 2/2] crypto/qat: add gen4 ecpm functions

> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Friday, April 8, 2022 8:58 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX > Subject: [PATCH 2/2] crypto/qat: add gen4 ecpm functions > > This commit adds functions to use ecpm named > curves.

Re: [PATCH v2 1/5] telemetry: escape special char when tel string

On Fri, 17 Jun 2022 12:25:04 +0100 Bruce Richardson wrote: > On Fri, Jun 17, 2022 at 01:16:08PM +0200, Morten Brørup wrote: > > > From: Chengwen Feng [mailto:fengcheng...@huawei.com] > > > Sent: Friday, 17 June 2022 11.46 > > > > > > This patch supports escape special characters (including: \",\

RE: [PATCH v3 2/4] raw/ifpga/base: update board information

Hi, > -Original Message- > From: Huang, Wei > Sent: Friday, June 17, 2022 15:20 > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH v3 2/4] raw/ifpga/base

Re: [PATCH v2 3/4] doc: give specific instructions for running as non-root

On Fri, Jun 17, 2022 at 02:25:07PM +0300, Dmitry Kozlyuk wrote: > The guide to run DPDK applications as non-root in Linux > did not provide specific instructions to configure the required access > and did not explain why each bit is needed. > The latter is important because running as non-root > is

RE: [PATCH] crypto/qat: fix cleanup function default behaviour

> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, June 15, 2022 6:58 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX > Subject: [PATCH] crypto/qat: fix cleanup function default behaviour > > Full cookie data should be cleared by de

RE: [PATCH] test/crypto: add key exchange dh tests

Hi Arek, The patch cannot compile. Looks like there are some inconsistency between the merged asym crypto change and your test code. Can you rebase? Regards, Fan > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Thursday, April 7, 2022 9:07 AM > To: dev@dpdk.org > Cc: gak...@ma

Re: [PATCH v2 1/5] telemetry: escape special char when tel string

On Fri, Jun 17, 2022 at 05:46:20PM +0800, Chengwen Feng wrote: > This patch supports escape special characters (including: \",\\,/,\b, > /f,/n,/r,/t) when telemetry string. > This patch is used to support telemetry xxx-dump commands which the > string may include special characters. > > Signed-off

RE: [PATCH v1] bbdev: allow operation type enum for growth

> From: Thomas Monjalon > > This solution is what I proposed to the techboard some years ago, but the > preference was to completely remove the MAX values. > Thanks, good to see you had similar thought! I don't believe there is an actual recommendation captured in term of how to remove compl

RE: [PATCH v4] doc: announce changes in bbdev related to enum extension

Hi Thomas, Can this one be applied based on your review? Thanks Nic > -Original Message- > From: Maxime Coquelin > Sent: Thursday, June 9, 2022 12:54 AM > To: Chautru, Nicolas ; dev@dpdk.org; > gak...@marvell.com; tho...@monjalon.net > Cc: t...@redhat.com; Kinsella, Ray ; Richardson, Br

RE: [PATCH v4] sched: enable CMAN at runtime

> -Original Message- > From: Danilewicz, MarcinX > Sent: Monday, June 13, 2022 10:09 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v4] sched: enable CMAN at runtime > > Added changes to enable CMAN (RED or PIE) at init > from p

Re: [PATCH v2 1/5] telemetry: escape special char when tel string

On Fri, Jun 17, 2022 at 01:16:08PM +0200, Morten Brørup wrote: > > From: Chengwen Feng [mailto:fengcheng...@huawei.com] > > Sent: Friday, 17 June 2022 11.46 > > > > This patch supports escape special characters (including: \",\\,/,\b, > > /f,/n,/r,/t) when telemetry string. > > This patch is used

Re: [PATCH v7] ip_frag: add IPv4 options fragment and test data

On Fri, 17 Jun 2022 11:52:25 +0800 (CST) "Huichao Cai" wrote: > Hi,Stephen > > > There are some things I don't quite understand.Hope you can answer that. > This will help me avoid similar errors in subsequent patch submissions.Thanks! > > > There are places where rte_memcpy functions are used

Re: dpdk address sanitizer

On Fri, 17 Jun 2022 07:45:33 +0200 David Marchand wrote: > Hello, > > On Fri, Jun 17, 2022 at 6:08 AM Juan Pablo L. > wrote: > > > > Hello, I am new to dpdk ... i would like to trace memory usage and detect > > memory leaks, valgrind as well as address sanitizer (gcc) report some > > memory l

Re: [PATCH v2 06/15] vdpa/mlx5: pre-create virtq in the prob

I would rename the title to something like: "vdpa/mlx5: pre-create virtq at probe time" On 6/16/22 04:30, Li Zhang wrote: dev_config operation is called in LM progress. LM time is very critical because all the VM packets are dropped directly at that time. Move the virtq creation to probe time

Re: [PATCH v2 05/15] common/mlx5: extend virtq modifiable fields

On 6/16/22 04:30, Li Zhang wrote: A virtq configuration can be modified after the virtq creation. Added the following modifiable fields: 1.address fields: desc_addr/used_addr/available_addr 2.hw_available_index 3.hw_used_index 4.virtio_q_type 5.version type 6.queue mkey 7.feature bit mask: tso

Re: [PATCH v2 03/15] common/mlx5: add DevX API to move QP to reset state

On 6/16/22 04:30, Li Zhang wrote: From: Yajun Wu Support set QP to RESET state. Signed-off-by: Yajun Wu Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 7 +++ drivers/common/mlx5/mlx5_prm.h | 17 + 2 files changed, 24 insertions(+) Review

Re: [PATCH v2 02/15] vdpa/mlx5: support pre create virtq resource

On 6/16/22 04:29, Li Zhang wrote: From: Yajun Wu The motivation of this change is to reduce vDPA device queue creation time by create some queue resource in vDPA device probe stage. s/create/creating/ In VM live migration scenario, this can reduce 0.8ms for each queue creation, thus red

Re: [PATCH v2] net/nfp: initialize the flbufsz

On 6/15/2022 11:14 AM, Peng Zhang wrote: When the testpmd start-up, it will check MTU range, if MTU > flubfsz, it will lead testpmd start fail. Because the hw->flbufsz doesn't have the initialized value, so it will lead the bug. Fixes: 97a30c4d4c7b ("net/nfp: make sure MTU is never larger than m

Re: [PATCH v2 01/15] vdpa/mlx5: fix usage of capability for max number of virtqs

On 6/16/22 04:29, Li Zhang wrote: The driver wrongly takes the capability value for the number of virtq pairs instead of just the number of virtqs. Adjust all the usages of it to be the number of virtqs. Fixes: c2eb33a ("vdpa/mlx5: manage virtqs by array") Cc: sta...@dpdk.org Signed-off-by:

Re: [PATCH] vhost: fix log for async dequeue

On 6/17/22 07:40, David Marchand wrote: Since the commit 02798b073520 ("vhost: improve virtio-net layer logs"), vhost logs contain the socket path as a prefix. Async dequeue path was copied from the sync dequeue path but a log was incorrect. Fixes: 84d5204310d7 ("vhost: support async dequeue

Re: [PATCH v2] vhost: fix missing statistics update

On 6/16/22 11:44, xuan.d...@intel.com wrote: From: Xuan Ding This patch adds missing per-virtqueue statistics in async dequeue path. Fixes: 84d5204310d7("vhost: support async dequeue for split ring") Signed-off-by: Xuan Ding --- v2: * Since this issue was introduced and fixed in same rel

Re: [PATCH] vhost: rename number of available entries

On 6/16/22 10:20, Maxime Coquelin wrote: This patchs renames the local variables free_entries to avail_entries in the dequeue path. Indeed, this variable represents the number of new packets available in the Virtio transmit queue, so these entries are actually used, not free. Signed-off-by:

Re: [PATCH v3] vdpa/mlx5: workaround var offset within page

On 6/15/22 12:02, Yajun Wu wrote: vDPA driver first uses kernel driver to allocate doorbell(VAR) area for each device. Then uses var->mmap_off and var->length to mmap uverbs device file as doorbell userspace virtual address. Current kernel driver provides var->mmap_off equal to page start of

Re: [PATCH v2] vdpa/ifc: fix null pointer dereference

On 6/15/22 08:23, Andy Pei wrote: Fix null pointer dereference reported in coverity scan. Coverity issue: 378882 Fixes: 5d75517beffe ("vdpa/ifc/base: access correct register for blk device") Signed-off-by: Andy Pei Acked-by: Xiao Wang --- drivers/vdpa/ifc/base/ifcvf.c | 9 + 1 f

Re: [PATCH v5 0/2] support to clear in-flight packets for async

On 6/9/22 19:34, Yuan Wang wrote: These patches support to clear in-flight packets for async dequeue and introduce thread-safe version of this function. v5: - Add dma_id check v4: - Rebase to latest DPDK v3: - Rebase to latest DPDK v2: - Use the thread-safe version in destroy_device v1: -

Re: [PATCH v2 0/6] Vhost checksum offload improvements

On 6/8/22 14:49, Maxime Coquelin wrote: This series aims at improving Vhost checksum offloading support. The first patch reverts overwritting MAC address in testpmd CSUM forward mode. This is required to be able to test checksum offloading with real traffic. MAC forwarding mode should be used

Re: [PATCH] vhost: fix log for async dequeue

On 6/17/22 07:40, David Marchand wrote: Since the commit 02798b073520 ("vhost: improve virtio-net layer logs"), vhost logs contain the socket path as a prefix. Async dequeue path was copied from the sync dequeue path but a log was incorrect. Fixes: 84d5204310d7 ("vhost: support async dequeue

Re: [PATCH v3] vhost/crypto: fix build with GCC 12

On 6/16/22 16:46, David Marchand wrote: GCC 12 raises the following warning: In file included from ../lib/mempool/rte_mempool.h:46, from ../lib/mbuf/rte_mbuf.h:38, from ../lib/vhost/vhost_crypto.c:7: ../lib/vhost/vhost_crypto.c: In function ‘rte_vhost_crypt

RE: [PATCH] net: fix checksum with unaligned buffer

> -Original Message- > From: Morten Brørup > Sent: den 17 juni 2022 11:07 > To: Emil Berg > Cc: sta...@dpdk.org; bugzi...@dpdk.org; hof...@lysator.liu.se; > olivier.m...@6wind.com; dev@dpdk.org > Subject: RE: [PATCH] net: fix checksum with unaligned buffer > > > From: Morten Brørup [mail

Re: [PATCH] vhost: rename number of available entries

On Thu, Jun 16, 2022 at 10:20 AM Maxime Coquelin wrote: > > This patchs renames the local variables free_entries to > avail_entries in the dequeue path. > > Indeed, this variable represents the number of new packets > available in the Virtio transmit queue, so these entries > are actually used, no

[PATCH v2 2/2] crypto/cnxk: fix compilation with GCC 12

The following warning is observed with GCC 12 compilation: In file included from ../drivers/crypto/cnxk/cn10k_cryptodev_ops.c:17: In function ‘fill_sg_comp_from_iov’, inlined from ‘cpt_pdcp_chain_alg_prep’ at ../drivers/crypto/cnxk/cnxk_se.h:1194:8, inlined from ‘cpt_fc_enc_hmac_pr

[PATCH v2 1/2] common/cpt: fix compilation with GCC 12

The following warning is observed with GCC 12 compilation: In function ‘fill_sg_comp_from_iov’, inlined from ‘cpt_zuc_snow3g_enc_prep’ at ../drivers/common/cpt/cpt_ucode.h:1672:9, inlined from ‘cpt_fc_enc_hmac_prep’ at ../drivers/common/cpt/cpt_ucode.h:2472:3, inlined f

[PATCH v2 0/2] fix compilation with GCC 12

This patch series resolves compilation warning observed with GCC 12, in common/cpt and crypto/cnxk. --- v2: - Add Bugzilla ID in patch 1. - Remove empty line between Fixes: and Cc:. Ankur Dwivedi (2): common/cpt: fix compilation with GCC 12 crypto/cnxk: fix compilation with GCC 12 drivers/c

Re: [PATCH v3 00/13] Add support of NFP3800 chip and firmware with NFDk

On 6/17/2022 10:34 AM, Jin Liu wrote: NFD is part of NFP firmware, and there only exist a NFD3 version before this patch series. This patch series mainly add the support of the new NFP3800 chip use firmware with NFD3/NFDk. * Changes since v1 - Added updated documentation for NFP to cover NF

Re: [PATCH] add support for async vhost packed ring dequeue

Hi Cheng, On 6/13/22 10:21, Cheng Jiang wrote: This patch implements packed ring dequeue data path for asynchronous vhost. Signed-off-by: Cheng Jiang Reviewed-by: Maxime Coquelin --- lib/vhost/virtio_net.c | 218 - 1 file changed, 192 insertions(+),

Re: [PATCH v2 2/2] common/cnxk: add include for macro definition

On Wed, Jun 15, 2022 at 10:41 PM Bruce Richardson wrote: > > The header file "roc_io.h" uses the "__plt_always_inline" macro but > don't include "roc_platform.h" to get the definition of it. This > inclusion is not necessary for compilation, but the lack of it can > confuse some indexers - such as

RE: [PATCH] crypto/qat: add ecdh key exchange algorithm

Sorry for the confusion - unack the patch as it needs rebasing. > -Original Message- > From: Zhang, Roy Fan > Sent: Friday, June 17, 2022 1:37 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: gak...@marvell.com > Subject: RE: [PATCH] crypto/qat: add ecdh key exchange algorithm > > >

Re: [dpdk-dev] [PATCH v2] common/cnxk: add ROC API to free MCAM entry

On Wed, Jun 15, 2022 at 7:29 PM wrote: > > From: Satheesh Paul > > Add ROC API to free the given MCAM entry. If the MCAM > entry has flow counter associated, this API will clear > and free the flow counter. > > Signed-off-by: Satheesh Paul > Reviewed-by: Jerin Jacob Applied to dpdk-next-net-mr

Re: [PATCH v2 1/6] Revert "app/testpmd: modify mac in csum forwarding"

On 6/13/22 14:24, Singh, Aman Deep wrote: Hi Maxime, On 6/8/2022 6:19 PM, Maxime Coquelin wrote: This patch reverts commit 10f4620f02e1 ("app/testpmd: modify mac in csum forwarding"), as the checksum forwarding is expected to only perform checksum and not also overwrites the source and dest

Re: [PATCH v2] vdpa/ifc: fix null pointer dereference

On 6/15/22 08:23, Andy Pei wrote: Fix null pointer dereference reported in coverity scan. Coverity issue: 378882 Fixes: 5d75517beffe ("vdpa/ifc/base: access correct register for blk device") Signed-off-by: Andy Pei Acked-by: Xiao Wang --- drivers/vdpa/ifc/base/ifcvf.c | 9 + 1 f

RE: [PATCH] crypto/qat: add ec point verify function

> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Thursday, April 7, 2022 5:45 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Kusztal, > ArkadiuszX > Subject: [PATCH] crypto/qat: add ec point verify function > > This commit adds elliptic curve point verification

RE: [EXT] Re: [PATCH 1/2] common/cpt: fix compilation with GCC 12

Hi David, >-Original Message- >From: David Marchand >Sent: Friday, June 17, 2022 5:38 PM >To: Ankur Dwivedi >Cc: dev ; Anoob Joseph ; Akhil Goyal >; Tejasree Kondoj ; Jerin >Jacob Kollanukkaran ; dpdk stable >Subject: [EXT] Re: [PATCH 1/2] common/cpt: fix compilation with GCC 12 > >Exte

[PATCH v2 2/2] app/eventdev: increase number of qp descriptors

Increase number of cryptodev queue pair descriptors by default. Current size of 128 descriptors does not satisfying minimal requirements of crypto drivers. Signed-off-by: Volodymyr Fialko --- app/test-eventdev/test_perf_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v2 1/2] app/eventdev: add null checks for cop allocations

Crypto operation allocation may fail in case when total size of queue pairs are bigger then the pool size. Signed-off-by: Volodymyr Fialko --- app/test-eventdev/test_perf_common.c | 40 ++-- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/app/test-eventdev/

[PATCH v2 0/2] app/eventdev: fix issues with cop alloc and qp size

- Handle cop allocation failures and count them. - QP default size increased, previous size of 128 was too small for most of the cases --- v2: - resolve issues with the patch description Volodymyr Fialko (2): app/eventdev: add null checks for cop allocations app/eventdev: increase number of

Re: [PATCH v2] common/cnxk: add cnf10kb support

On Mon, Jun 13, 2022 at 5:15 PM Harman Kalra wrote: > > Support for cnf10kb soc by adding its PCI device ID > > Signed-off-by: Harman Kalra Updated the git commit as follows and applied to dpdk-next-net-mrvl/for-next-net. Thanks common/cnxk: support CNF10KB SoC Support for CNF10KB SoC

Re: [PATCH 1/2] common/cpt: fix compilation with GCC 12

On Fri, Jun 17, 2022 at 8:15 AM Ankur Dwivedi wrote: > > The following warning is observed with GCC 12 compilation: > > In function ‘fill_sg_comp_from_iov’, > inlined from ‘cpt_zuc_snow3g_enc_prep’ at > ../drivers/common/cpt/cpt_ucode.h:1672:9, > inlined from ‘cpt_fc_enc_hmac_prep’

Re: [PATCH 1/2] app/eventdev: add null checks for cop allocations

On Fri, Jun 17, 2022 at 3:32 PM Volodymyr Fialko wrote: > > Crypto operation allocation may fail in case when total size of queue > pairs is bigger then pool size. ^^^ ^^^ pairs are bigger than the pool size. Acked-by: Jerin Jacob Please send v2 with other changes in 1/2

Re: [PATCH v2] test/ipsec: fix build with GCC 12

On Thu, Jun 16, 2022 at 11:33 AM David Marchand wrote: > > GCC 12 raises the following warning: > > In function ‘_mm256_loadu_si256’, > inlined from ‘rte_mov32’ at > ../lib/eal/x86/include/rte_memcpy.h:319:9, > inlined from ‘rte_mov128’ at > ../lib/eal/x86/include/rte_memcp

Re: [PATCH 2/2] app/eventdev: increase number of qp descriptors

On Fri, Jun 17, 2022 at 3:32 PM Volodymyr Fialko wrote: > > Increase number of cryptodev queue pair descriptors by default. Please add more details for the reason for the change > > Signed-off-by: Volodymyr Fialko > --- > app/test-eventdev/test_perf_common.c | 2 +- > 1 file changed, 1 inserti

Re: [PATCH] net/qede: fix build with GCC 13

On Thu, Jun 16, 2022 at 10:32 PM Ferruh Yigit wrote: > > Reproduced with "gcc (GCC) 13.0.0 20220616 (experimental)" > > Build error: > In file included from ../drivers/net/qede/qede_debug.c:9: > ../drivers/net/qede/qede_debug.c: In function ‘qed_grc_dump_addr_range’: > ../drivers/net/qede/base/eco

Re: [PATCH] common/cnxk: update CN103XX subsystem device ID

On Mon, Jun 13, 2022 at 4:59 PM Rahul Bhansali wrote: > > Updates the subsystem device ID for CN103XX. > > Signed-off-by: Rahul Bhansali Updated the git commit as follows and applied to dpdk-next-net-mrvl/for-next-net. Thanks common/cnxk: fix CN103XX subsystem device ID Fix the subsys

Re: [PATCH 0/2] fix compilation with GCC 12

On Fri, Jun 17, 2022 at 8:15 AM Ankur Dwivedi wrote: > > This patch series resolves compilation warning observed with GCC 12, > in common/cpt and crypto/cnxk. > > Ankur Dwivedi (2): > common/cpt: fix compilation with GCC 12 > crypto/cnxk: fix compilation with GCC 12 > Two small nits in commit

Re: [PATCH v4] gro: bug fix in identifying fragmented packets

> -Original Message- > From: Kumara Parameshwaran > Sent: Wednesday, June 8, 2022 5:57 PM > To: Hu, Jiayu > Cc: dev@dpdk.org; Kumara Parameshwaran > ; sta...@dpdk.org > Subject: [PATCH v4] gro: bug fix in identifying fragmented packets > > From: Kumara Parameshwaran > > A packet with RTE

RE: [PATCH 4/4] doc: update instructions for running as non-root for MLX5

> From: Stephen Hemminger > Sent: Wednesday, June 8, 2022 3:14 AM > [...] > This change needs additional changes to make it correct English > grammar. Thank you for the useful comments to this and other patches. I hope you don't mind that I took some sentences almost verbatim for v2. > [...] > >

RE: [dpdk-dev v7] crypto/qat: use intel-ipsec-mb for partial hash & aes

Hi Kai, > -Original Message- > From: Kai Ji > Sent: Monday 13 June 2022 18:03 > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai ; Zhang, Roy Fan > > Subject: [dpdk-dev v7] crypto/qat: use intel-ipsec-mb for partial hash & aes > > Since openssl 3.0 now deprecates the low level API QAT

[PATCH v2 4/4] doc: update instructions for running as non-root for MLX5

Reference the common guide for generic setup. Remove excessive capabilities from the recommended list. Cc: sta...@dpdk.org Signed-off-by: Dmitry Kozlyuk --- doc/guides/platform/mlx5.rst | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/doc/gui

[PATCH v2 3/4] doc: give specific instructions for running as non-root

The guide to run DPDK applications as non-root in Linux did not provide specific instructions to configure the required access and did not explain why each bit is needed. The latter is important because running as non-root is one of the ways to tighten security and grant minimal permissions. Cc: s

[PATCH v2 2/4] usertools: add option to change mount point owner

Per mount(8), the previous owner and mode of the mount point become invisible as long as this filesystem remains mounted. Because dpdk-hugepages.py must be run as root, the new owner would be root. This is undesirable if the hugepage directory is being set up by the administrator for an unprivilege

  1   2   >