RE: [PATCH v10 0/6] introduce per-queue available descriptor threshold and host shaper

2022-06-19 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Spike Du > Sent: Thursday, June 16, 2022 11:42 AM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) > Cc: andrew.rybche...@oktetlabs.ru; step...@networkplumber.org; > m...@smartsharesystems.com; dev@dpdk.org; Rasl

[PATCH v7 0/3] pcap: support MTU set for linux interfaces

2022-06-19 Thread Ido Goshen
Support rte_eth_dev_set_mtu for pcap ifaces vdevs by setting the underlying OS network interface's MTU. Support is for pcap ifaces only and not for pcap files. Support is for Linux only. patch series: [PATCH v7 1/3] pcap: support MTU set for linux interfaces [PATCH v7 2/3] pcap: support MTU set fo

[PATCH v7 1/3] pcap: support MTU set for linux interfaces

2022-06-19 Thread Ido Goshen
Support rte_eth_dev_set_mtu for pcap ifaces vdevs by setting the underlying OS network interface's MTU. Support is for pcap ifaces only and not for pcap files. Support is for Linux only. Bugzilla ID: 961 Signed-off-by: Ido Goshen --- doc/guides/rel_notes/release_22_07.rst | 3 ++ drivers/net/pc

[PATCH v7 2/3] pcap: support MTU set for linux interfaces TX enhancment

2022-06-19 Thread Ido Goshen
Drop only the oversized packets and not its entrie burst mbuf will be freed and will be counted as oerror Signed-off-by: Ido Goshen --- drivers/net/pcap/pcap_ethdev.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap/

[PATCH v7 3/3] pcap: support MTU set for linux interfaces count ierrors

2022-06-19 Thread Ido Goshen
Count oversized packets that are dropped by the interface Signed-off-by: Ido Goshen --- drivers/net/pcap/pcap_ethdev.c | 74 +- 1 file changed, 45 insertions(+), 29 deletions(-) diff --git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap/pcap_ethdev.c index ff

RE: [V2] common/iavf:replace zero-length arrays with flexible ones

2022-06-19 Thread Zhang, Qi Z
> -Original Message- > From: 835703...@qq.com <835703...@qq.com> > Sent: Thursday, June 16, 2022 1:42 AM > To: Wu, Jingjing > Cc: dev@dpdk.org; Shiqi Liu <835703...@qq.com> > Subject: [V2] common/iavf:replace zero-length arrays with flexible ones > > From: Shiqi Liu <835703...@qq.com>

RE: [PATCH v4 1/1] net/iavf: add vector PMD for Arm for basic Rx path

2022-06-19 Thread Zhang, Qi Z
> -Original Message- > From: Kathleen Capella > Sent: Saturday, June 18, 2022 2:22 AM > To: Wu, Jingjing ; Xing, Beilei > ; > Ruifeng Wang > Cc: dev@dpdk.org; n...@arm.com; honnappa.nagaraha...@arm.com; > dharmik.thak...@arm.com; Kathleen Capella > Subject: [PATCH v4 1/1] net/iavf: a

RE: [PATCH] ice/base: fix gcc 12 warning stringop-overflow

2022-06-19 Thread Zhang, Qi Z
> -Original Message- > From: Wu, WenxuanX > Sent: Thursday, June 16, 2022 6:33 PM > To: Yang, Qiming ; Zhang, Qi Z > ; dev@dpdk.org; tho...@monjalon.net > Cc: step...@networkplumber.org; Wu, WenxuanX ; > sta...@dpdk.org > Subject: [PATCH] ice/base: fix gcc 12 warning stringop-overflow >

Re: [dpdk-dev] [PATCH 1/8] net/bnxt: remove assert for zero data len in Tx path

2022-06-19 Thread Ajit Khaparde
On Thu, Jun 16, 2022 at 10:03 AM Ferruh Yigit wrote: > > On 6/15/2022 3:56 PM, Kalesh A P wrote: > > CAUTION: This message has originated from an External Source. Please use > > proper judgment and caution when opening attachments, clicking links, or > > responding to this email. > > > > > > Fro

Re: [dpdk-dev] [PATCH 8/8] net/bnxt: fix the check for autoneg enablement in the PHY FW

2022-06-19 Thread Ajit Khaparde
On Thu, Jun 16, 2022 at 10:04 AM Ferruh Yigit wrote: > > On 6/15/2022 3:57 PM, Kalesh A P wrote: > > > > From: Somnath Kotur > > > > The current combination of checks to determine whether autoneg is > > enabled in the card is a bit convoluted and may become incorrect > > as well in the future as o

RE: [PATCH] ice/base: fix gcc 12 warning stringop-overflow

2022-06-19 Thread Wu, WenxuanX
Hi all, The warning below gcc 12 : inlined from ‘ice_add_adv_recipe’ at ../drivers/net/ice/base/ice_switch.c:7951:11, inlined from ‘ice_add_adv_rule’ at ../drivers/net/ice/base/ice_switch.c:8911:11: ../drivers/net/ice/base/ice_switch.c:7220:61: error: writing 1 byte into a region of s

RE: [PATCH v3 18/18] vhost: remove unneeded header includes

2022-06-19 Thread Xia, Chenbo
> -Original Message- > From: Morrissey, Sean > Sent: Saturday, June 18, 2022 3:09 AM > To: Maxime Coquelin ; Xia, Chenbo > > Cc: dev@dpdk.org; Morrissey, Sean > Subject: [PATCH v3 18/18] vhost: remove unneeded header includes > > These header includes have been flagged by the iwyu_tool

RE: [PATCH] doc: update async enqueue API usage

2022-06-19 Thread Hu, Jiayu
Hi Xuan, > -Original Message- > From: Ding, Xuan > Sent: Friday, June 17, 2022 5:34 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > > Subject: [PATCH] doc: update async enqueue API usage > > From: Xuan Ding > > This patch updates the corr

RE: [PATCH 2/3] doc: update vhost sample app docs

2022-06-19 Thread Xia, Chenbo
Hi Herakliusz, Thanks for the clean-up! Comments inline. > -Original Message- > From: Lipiec, Herakliusz > Sent: Tuesday, June 7, 2022 7:49 PM > To: maxime.coque...@redhat.com; Xia, Chenbo ; > Richardson, Bruce > Cc: dev@dpdk.org; Lipiec, Herakliusz > Subject: [PATCH 2/3] doc: update v

RE: [PATCH 3/3] examples/vhost: update vhost usage message

2022-06-19 Thread Xia, Chenbo
> -Original Message- > From: Lipiec, Herakliusz > Sent: Tuesday, June 7, 2022 7:49 PM > To: maxime.coque...@redhat.com; Xia, Chenbo ; > Richardson, Bruce > Cc: dev@dpdk.org; Lipiec, Herakliusz > Subject: [PATCH 3/3] examples/vhost: update vhost usage message > > updating vhost usage mes

RE: [PATCH] doc: update async enqueue API usage

2022-06-19 Thread Ding, Xuan
Hi Jiayu, > -Original Message- > From: Hu, Jiayu > Sent: Monday, June 20, 2022 9:43 AM > To: Ding, Xuan ; maxime.coque...@redhat.com; Xia, > Chenbo > Cc: dev@dpdk.org > Subject: RE: [PATCH] doc: update async enqueue API usage > > Hi Xuan, > > > -Original Message- > > From: Ding

RE: [PATCH] doc: update async enqueue API usage

2022-06-19 Thread Hu, Jiayu
Hi Xuan, > -Original Message- > From: Hu, Jiayu > Sent: Monday, June 20, 2022 9:43 AM > To: Ding, Xuan ; maxime.coque...@redhat.com; Xia, > Chenbo > Cc: dev@dpdk.org > Subject: RE: [PATCH] doc: update async enqueue API usage > > Hi Xuan, > > > -Original Message- > > From: Ding,

RE: [PATCH v4] gro: bug fix in identifying fragmented packets

2022-06-19 Thread Hu, Jiayu
Hi Kumara, IMO, TCP GSO will not use the flag. UDP GSO is the same as IP fragmentation, and UDP fragments are treated as IP fragments. Except the first fragment, the following fragments don’t have L4 header. RTE_PTYPE_L4_FRAG is set to recognize them as IP fragments fast. TCP GSO is different wit

RE: [PATCH v2] examples/vhost: fix retry logic on eth rx path

2022-06-19 Thread Xia, Chenbo
> -Original Message- > From: Wang, YuanX > Sent: Friday, June 17, 2022 3:02 PM > To: maxime.coque...@redhat.com; Xia, Chenbo ; > dev@dpdk.org > Cc: Hu, Jiayu ; He, Xingguang ; > Wang, YuanX ; sta...@dpdk.org; Ling, WeiX > > Subject: [PATCH v2] examples/vhost: fix retry logic on eth rx pat

RE: [PATCH v2] net/virtio: unmap PCI device in secondary process

2022-06-19 Thread Xia, Chenbo
> -Original Message- > From: Wang, YuanX > Sent: Monday, June 6, 2022 11:56 PM > To: maxime.coque...@redhat.com; Xia, Chenbo ; > dev@dpdk.org > Cc: Hu, Jiayu ; He, Xingguang ; > Ling, WeiX ; Wang, YuanX ; > sta...@dpdk.org > Subject: [PATCH v2] net/virtio: unmap PCI device in secondary pro

RE: [PATCH] dma/idxd: fix missing default for workqueue options

2022-06-19 Thread Pai G, Sunil
> From: Richardson, Bruce > Sent: Friday, June 17, 2022 4:48 PM > To: dev@dpdk.org > Cc: Laatz, Kevin ; Pai G, Sunil > ; Richardson, Bruce > Subject: [PATCH] dma/idxd: fix missing default for workqueue options > > When no --wq-option flag is passed to dpdk_idxd_cfg.py script, the default > value

RE: [PATCH] ice/base: fix gcc 12 warning stringop-overflow

2022-06-19 Thread Wu, WenxuanX
> -Original Message- > From: Wu, WenxuanX > Sent: 2022年6月20日 9:39 > To: Zhang, Qi Z ; Yang, Qiming > ; dev@dpdk.org; tho...@monjalon.net > Cc: step...@networkplumber.org; sta...@dpdk.org > Subject: RE: [PATCH] ice/base: fix gcc 12 warning stringop-overflow > > Hi all, > > The warning

RE: [dpdk-dev] [PATCH 1/1] net/mlx5: fix stack buffer overflow of hrxq's rss_key

2022-06-19 Thread Slava Ovsiienko
Hi, Yunjian My sincere apologies for the review delay. I think patch is OK, thank you for finding this. Just of curiosity - did you observe a real crash? Or just found by sanitizer? Acked-by: Viacheslav Ovsiienko With best regards, Slava

Re: [PATCH v4] gro: bug fix in identifying fragmented packets

2022-06-19 Thread kumaraparameshwaran rathinavel
Thanks Jiyau for the detailed explanation. I will make the changes as per your comments. Thanks, Kumara On Mon, Jun 20, 2022 at 8:27 AM Hu, Jiayu wrote: > Hi Kumara, > > > > IMO, TCP GSO will not use the flag. UDP GSO is the same as IP > fragmentation, > > and UDP fragments are treated as IP fr

RE: [PATCH] net/mlx5: fix risk in Rx descriptor read in NEON vector path

2022-06-19 Thread Slava Ovsiienko
Hi, Ruifeng My apologies for review delay. As far I understand the hypothetical problem scenario is: - CPU core reorders reading of qwords of 16B vector - core reads the second 8B of CQE (old CQE values) - CQE update - core reads the first 8B of CQE (new CQE values) How the re-reading of CQEs ca

RE: [PATCH v2 2/4] usertools: add option to change mount point owner

2022-06-19 Thread Dmitry Kozlyuk
> From: Bruce Richardson > Sent: Friday, June 17, 2022 6:53 PM > [...] > > +if owner: > > +uid, gid = owner.split(':', maxsplit=1) > > +cmd += ' -o uid={},gid={}'.format(uid, gid) > > I'm not sure about forcing the user to always provide a "user:group" > format parameter. How

RE: [PATCH v2 3/4] doc: give specific instructions for running as non-root

2022-06-19 Thread Dmitry Kozlyuk
> From: Bruce Richardson > Sent: Friday, June 17, 2022 7:38 PM > > [...] > > +If the driver requires using physical addresses (PA), > > +the executable file must be granted additional capabilities: > > + > > +* ``SYS_ADMIN`` to read ``/proc/self/pagemaps`` > > +* ``IPC_LOCK`` to lock hugepages in

[Bug 1039] [dpdk 22.07-rc0] drivers/vdpa/ifc meson build failed with gcc12.1.1 on Fedora36/64

2022-06-19 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1039 Bug ID: 1039 Summary: [dpdk 22.07-rc0] drivers/vdpa/ifc meson build failed with gcc12.1.1 on Fedora36/64 Product: DPDK Version: unspecified Hardware: All OS: All