Re: [PATCH v8 1/4] ethdev: support device error recovery notification

2022-06-21 Thread Thomas Monjalon
21/06/2022 03:38, fengchengwen: > Hi Thomas, > > On 2022/6/21 1:42, Thomas Monjalon wrote: > > 16/06/2022 11:41, Chengwen Feng: > >> --- a/lib/ethdev/rte_ethdev.h > >> +++ b/lib/ethdev/rte_ethdev.h > >> @@ -3928,6 +3928,12 @@ enum rte_eth_event_type { > >> * @see rte_eth_rx_avail_thresh_set()

RE: [EXT] Re: [PATCH v3 2/2] net/cnxk: support ops to update precolor VLAN table

2022-06-21 Thread Sunil Kumar Kori
> -Original Message- > From: Jerin Jacob > Sent: Monday, June 20, 2022 11:14 PM > To: Sunil Kumar Kori > Cc: Nithin Kumar Dabilpuram ; Kiran Kumar > Kokkilagadda ; Satha Koteswara Rao Kottidi > ; dpdk-dev > Subject: [EXT] Re: [PATCH v3 2/2] net/cnxk: support ops to update precolor > VLAN

[PATCH v2] doc: update async enqueue API usage

2022-06-21 Thread xuan . ding
From: Xuan Ding This patch updates the correct usage for async enqueue APIs. The rte_vhost_poll_enqueue_completed() needs to be called in time to notify the guest of completed packets and avoid packet loss. Signed-off-by: Xuan Ding --- v2: * refine doc and commit log --- doc/guides/prog_guide/

RE: [EXT] Re: [v9, 00/10] Add JSON vector set support to fips validation

2022-06-21 Thread Gowrishankar Muthukrishnan
Hi David, Do you mean this patch ? - https://patches.dpdk.org/project/dpdk/patch/20220607100203.1611166-1-david.march...@redhat.com/ I have acked this. @Akhil Goyal could this be merged ?. Thanks, Gowrishankar > -Original Message- > From: David Marchand > Sent: Monday, June 13, 2022 5:2

[PATCH v4 1/2] common/cnxk: update precolor table setup for VLAN

2022-06-21 Thread skori
From: Sunil Kumar Kori As per new spec in DPDK, VLAN priority is supported for precoloring of input packet. Signed-off-by: Sunil Kumar Kori --- v3..v4: - Remove Depends On tag from commit message. v2..v3: - No changes. v1..v2: - Aligned with latest input color spec. drivers/common/cnxk/ro

[PATCH v4 2/2] net/cnxk: support ops to update precolor VLAN table

2022-06-21 Thread skori
From: Sunil Kumar Kori Implement API to update VLAN table for pre-coloring for incoming packet per nixlf for CN10K platform. Signed-off-by: Sunil Kumar Kori --- v3..v4: - Remove Depends On tag from commit log. - Rebase on top of dpdk-next-net/main. - Fix clang build failures. v2..v3: - Fix

Re: [EXT] Re: [v9, 00/10] Add JSON vector set support to fips validation

2022-06-21 Thread David Marchand
Hello, On Tue, Jun 21, 2022 at 9:29 AM Gowrishankar Muthukrishnan wrote: > Do you mean this patch ? - > https://patches.dpdk.org/project/dpdk/patch/20220607100203.1611166-1-david.march...@redhat.com/ > I have acked this. @Akhil Goyal could this be merged ?. Indeed, I had forgotten about it. Akh

RE: [EXT] Re: [v9, 00/10] Add JSON vector set support to fips validation

2022-06-21 Thread Akhil Goyal
> Hello, > > On Tue, Jun 21, 2022 at 9:29 AM Gowrishankar Muthukrishnan > wrote: > > Do you mean this patch ? - > > https://patches.dpdk.org/project/dpdk/patch/20220607100203.1611166-1-david.march...@redhat.com/ > > I have acked this. @Akhil Goyal could this be merged ?. > > Indeed, I had forgo

Re: [EXT] Re: [v9, 00/10] Add JSON vector set support to fips validation

2022-06-21 Thread David Marchand
On Tue, Jun 21, 2022 at 9:40 AM Akhil Goyal wrote: > > > Do you mean this patch ? - > > > https://patches.dpdk.org/project/dpdk/patch/20220607100203.1611166-1-david.march...@redhat.com/ > > > I have acked this. @Akhil Goyal could this be merged ?. > > > > Indeed, I had forgotten about it. > > Akh

Re: [PATCH V3 app/testpmd 4/4] app/testpmd: remove duplicated flow type to string table

2022-06-21 Thread Ferruh Yigit
On 6/21/2022 3:18 AM, lihuisong (C) wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. 在 2022/6/20 20:38, Ferruh Yigit 写道: On 6/9/2022 4:26 AM, lihuisong (C) wrote:

Re: [dpdk-dev] [PATCH 4/8] net/bnxt: allow Tx only or Rx only configs in PMD

2022-06-21 Thread Ferruh Yigit
On 6/21/2022 5:54 AM, Damodharam Ammepalli wrote: Hi Ferruh, Please see my inline responses [Damo]; Thanks Damo *From:*Kalesh Anakkur Purayil *Sent:* Monday, June 20, 2022 9:47 PM *To:* Ferruh Yigit ; Damodharam Ammepalli *Cc:* Ajit Kumar Khaparde ; dpdk-dev *Subject:* Re: [dpdk-dev] [PA

RE: [PATCH] net: fix checksum with unaligned buffer

2022-06-21 Thread Morten Brørup
+TO: @Bruce and @Stephen: You signed off on the 16 bit alignment requirement. We need background info on this. > From: Emil Berg [mailto:emil.b...@ericsson.com] > Sent: Tuesday, 21 June 2022 09.17 > > > From: Morten Brørup > > Sent: den 20 juni 2022 12:58 > > > > > From: Emil Berg [mailto:emil.

[PATCH 00/12] preparation for the rte_flow offload of nfp PMD

2022-06-21 Thread Chaoyong He
This is the first patch series to add the support of rte_flow offload for nfp PMD, includes: Add the support of flower firmware Add the support of representor port Add the flower service infrastructure Add the cmsg interactive channels between pmd and fw Chaoyong He (12): net/nfp: move app speci

[PATCH 01/12] net/nfp: move app specific attributes to own struct

2022-06-21 Thread Chaoyong He
The NFP Card can load different firmware applications. Currently only the CoreNIC application is supported. This commit makes needed infrastructure changes in order to support other firmware applications too. Clearer separation is made between the PF device and any application specific concepts. T

[PATCH 02/12] net/nfp: simplify initialization and remove dead code

2022-06-21 Thread Chaoyong He
Calling nfp_net_init() is only done for the corenic firmware flavor and it is guaranteed to always be called from the primary process, so the explicit check for RTE_PROC_PRIMARY can be dropped. The calling graph of nfp_net_init() already guaranteed the free of resources when it fail, so remove the

[PATCH 03/12] net/nfp: move app specific init logic to own function

2022-06-21 Thread Chaoyong He
The NFP card can load different firmware applications. This commit move the init logic of corenic app of the secondary process into its own function. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_ethdev.c | 91 +--- 1 fi

[PATCH 04/12] net/nfp: add initial flower firmware support

2022-06-21 Thread Chaoyong He
This commits adds the basic probing infrastructure to support the flower firmware. This firmware is geared towards offloading OVS and can generally be found in /lib/firmware/netronome/flower. It is also used by the NFP kernel driver when OVS offload with TC is desired. This commit also adds the ba

[PATCH 05/12] net/nfp: add flower PF setup and mempool init logic

2022-06-21 Thread Chaoyong He
This commit adds the vNIC initialization logic for the flower PF vNIC. The flower firmware exposes this vNIC for the purposes of fallback traffic in the switchdev use-case. The logic of setting up this vNIC is similar to the logic seen in nfp_net_init() and nfp_net_start(). This commit also adds m

[PATCH 06/12] net/nfp: add flower PF related routines

2022-06-21 Thread Chaoyong He
This commit adds the start/stop/close routine of the flower PF vNIC. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/flower/nfp_flower.c | 193 1 file changed, 193 insertions(+) diff --git a/drivers/net/nfp/flower/nfp_flower.c

[PATCH 07/12] net/nfp: add flower ctrl VNIC related logics

2022-06-21 Thread Chaoyong He
This commit adds the setup/start logic for the ctrl vNIC. This vNIC is used by the PMD and flower firmware as a communication channel between driver and firmware. In the case of OVS it is also used to communicate flow statistics from hardware to the driver. A rte_eth device is not exposed to DPDK

[PATCH 08/12] net/nfp: move common rxtx function for flower use

2022-06-21 Thread Chaoyong He
This commit move some common Rx and Tx logic to the rxtx header file so that they can be re-used by flower tx and rx logic. Signed-off-by: Chaoyong He Signed-off-by: Heinrich Kuhn Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_rxtx.c | 32 +--- drivers/net/nf

[PATCH 09/12] net/nfp: add flower ctrl VNIC rxtx logic

2022-06-21 Thread Chaoyong He
Add a Rx and Tx function for the control vNIC. The logic is mostly identical to the normal Rx and Tx functionality of the NFP PMD. This commit also makes use of the ctrl vNIC service logic to service the ctrl vNIC Rx path. Signed-off-by: Chaoyong He Signed-off-by: Heinrich Kuhn Reviewed-by: Nik

[PATCH 10/12] net/nfp: add flower representor framework

2022-06-21 Thread Chaoyong He
This commit adds the framework to support flower representors. The number of VF representors are parsed from the command line. For physical port representors the current logic aims to create a representor for each physical port present on the hardware. A eth_dev is created for each phyport and VF,

[PATCH 11/12] net/nfp: move rxtx function to header file

2022-06-21 Thread Chaoyong He
Flower makes use of the same Rx and Tx checksum logic as the normal PMD. Expose it so that flower can make use of it. Signed-off-by: Chaoyong He Signed-off-by: Heinrich Kuhn Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_common.c| 2 +- drivers/net/nfp/nfp_ethdev.c| 2 +- driv

[PATCH 12/12] net/nfp: add flower PF rxtx logic

2022-06-21 Thread Chaoyong He
This commit implements the flower Rx logic. Fallback packets are multiplexed to the correct representor port based on the prepended metadata. The Rx poll is set to run on the existing service infrastructure. For Tx the existing NFP Tx logic is duplicated to keep the Tx two paths distinct. Flower f

[PATCH v6] sched: enable CMAN at runtime

2022-06-21 Thread Marcin Danilewicz
Added changes to enable CMAN (RED or PIE) at init from profile configuration file. By default CMAN code is enable but not in use, when there is no RED or PIE profile configured. Signed-off-by: Marcin Danilewicz --- Log: v2 change in rte_sched.h to avoid ABI breakage. v3 changes from comment

RE: [PATCH v5 2/3] rte_pie: remove unnecessary floating point

2022-06-21 Thread Singh, Jasvinder
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, May 26, 2022 9:27 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Dumitrescu, > Cristian ; Singh, Jasvinder > ; Wojciech Liguzinski > > Subject: [PATCH v5 2/3] rte_pie: remove unnecessary floating point > > The qdelay va

RE: [PATCH v5 3/3] rte_pie: fix incorrect floating point math

2022-06-21 Thread Singh, Jasvinder
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, May 26, 2022 9:27 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Dumitrescu, > Cristian ; Singh, Jasvinder > ; Wojciech Liguzinski > > Subject: [PATCH v5 3/3] rte_pie: fix incorrect floating point math > > The function

RE: [PATCH v5] ched: enable CMAN at runtime

2022-06-21 Thread Danilewicz, MarcinX
> > Subject: [PATCH v5] ched: enable CMAN at runtime > > > > Title: ched -> sched Indeed! BR, /Marcin

Re: [PATCH] net: fix checksum with unaligned buffer

2022-06-21 Thread Bruce Richardson
On Tue, Jun 21, 2022 at 10:05:15AM +0200, Morten Brørup wrote: > +TO: @Bruce and @Stephen: You signed off on the 16 bit alignment requirement. > We need background info on this. > > > From: Emil Berg [mailto:emil.b...@ericsson.com] > > Sent: Tuesday, 21 June 2022 09.17 > > > > > From: Morten Brø

[PATCH v2] event/cnxk: add eth port specific PTP enable

2022-06-21 Thread pbhagavatula
From: Pavan Nikhilesh Add support to enable PTP per ethernet device when that specific ethernet device is connected to event device via Rx adapter. Signed-off-by: Pavan Nikhilesh Signed-off-by: Nithin Dabilpuram --- v2 Changes: - Rebase on next-net drivers/common/cnxk/roc_io.h

Re: [PATCH] examples/distributor: fix syntax on single core rx and distributor

2022-06-21 Thread Hunt, David
Hi Ferruh, On 20/06/2022 18:10, Ferruh Yigit wrote: On 6/20/2022 5:31 PM, Abdullah Ömer Yamaç wrote: This patch fixes the syntax error when using the single-core for both rx and distributor functions. Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core") Cc: sta...@dpdk.org Signed-

Re: [PATCH v8 0/5] introduce AFU PMD driver of FPGA

2022-06-21 Thread Thomas Monjalon
16/06/2022 05:00, Wei Huang: > The first patch implements the framework of the AFU PMD driver based on raw > device interfaces. > The subsequent patches implement the driver of some AFUs. > > Changes from v7: > 1. move driver description to ifpga.rst per Rosen comment. > 2. rename function name ac

RE: [PATCH v9 0/4] add an api to support proto based buffer split

2022-06-21 Thread Ding, Xuan
Hi Andrew, > -Original Message- > From: wenxuanx...@intel.com > Sent: Monday, June 13, 2022 6:26 PM > To: tho...@monjalon.net; andrew.rybche...@oktetlabs.ru; Li, Xiaoyun > ; ferruh.yi...@xilinx.com; Singh, Aman Deep > ; dev@dpdk.org; Zhang, Yuying > ; Zhang, Qi Z ; > jerinjac...@gmail.com

Re: [PATCH v3 2/4] eal: fix errno not set if strftime return zero

2022-06-21 Thread David Marchand
On Fri, Jun 17, 2022 at 4:35 AM Chengwen Feng wrote: > > The trace_session_name_generate() takes errno as the return value, but > the errno was not set if strftime return zero, the previously set errno > is returned in this case, this will result in inaccurate prompting. > > This patch sets errno

Re: [PATCH v2 3/3] test: support trace-autotest when enable trace

2022-06-21 Thread David Marchand
On Fri, Jun 17, 2022 at 4:43 AM fengchengwen wrote: > > Hi David, thanks for your review. > > On 2022/6/15 22:00, David Marchand wrote: > > On Tue, Jun 14, 2022 at 8:06 AM Chengwen Feng > > wrote: > >> > >> There are a bug[1] when exit application while enable tracing, this > >> bug has not been

RE: [PATCH v7 2/3] pcap: support MTU set for linux interfaces TX enhancment

2022-06-21 Thread Ido Goshen
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, 21 June 2022 1:53 > To: Ido Goshen > Cc: ferruh.yi...@xilinx.com; dev@dpdk.org > Subject: Re: [PATCH v7 2/3] pcap: support MTU set for linux interfaces TX > enhancment > > On Sun, 19 Jun 2022 12:30:33 +0300 > Ido Goshen wro

Re: [PATCH v3 4/4] test: introduce trace-autotest with traces enabled

2022-06-21 Thread David Marchand
On Fri, Jun 17, 2022 at 4:35 AM Chengwen Feng wrote: > > Currently trace_autotest unit test is executed with traces disabled. > This patch introduces trace_autotest unit test with traces enabled, > and the traces file is written to the directory where dpdk-test is > located. > > > Signed-off-by: C

Re: [PATCH v3 0/4] bugfix for trace

2022-06-21 Thread David Marchand
On Fri, Jun 17, 2022 at 4:35 AM Chengwen Feng wrote: > > This patch contains three bugfix for trace and one test patch. > > --- > v3: > * address David Marchand's comments. > * add xxx-by from David Marchand and Jerin Jacob. > v2: > * add test-by from Jerin Jacob for the 1/3 patch. > * add freebsd

[PATCH v2] app/testpmd: fix quit testpmd with vfs and pf

2022-06-21 Thread Ke Zhang
When testpmd startups with pf and vfs,this error occurs when quitting, results in pf is released before vfs ,so the vf would access an freed heap memory. The solution is two steps: 1. Fetch the valid port value from RTE_ETH_FOREACH_DEV. 2. free the port in reverse order. Fixes: 08fd782b8454 ("app

Re: [PATCH v2 2/2] app/testpmd: fix GTP PSC raw processing

2022-06-21 Thread Singh, Aman Deep
On 6/16/2022 11:31 PM, Gregory Etelson wrote: Use generic GTP PSC header definition in raw handler. Fixes: 9213c50e36fa ("app/testpmd: support GTP PSC option in raw sets") cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Reviewed-by: Viacheslav Ovsiienko Acked-by: Aman Singh

Re: [PATCH v2] app/testpmd: fix quit testpmd with vfs and pf

2022-06-21 Thread Ferruh Yigit
On 6/21/2022 10:03 AM, Ke Zhang wrote: When testpmd startups with pf and vfs,this error occurs when quitting, results in pf is released before vfs ,so the vf would access an freed heap memory. The solution is two steps: 1. Fetch the valid port value from RTE_ETH_FOREACH_DEV. 2. free the port in

RE: [EXT] [dpdk-dev v4 1/4] crypto/openssl: 3.0 EVP update on HMAC routine

2022-06-21 Thread Akhil Goyal
> Subject: [EXT] [dpdk-dev v4 1/4] crypto/openssl: 3.0 EVP update on HMAC > routine Title should be Crypto/openssl: update HMAC routine with 3.0 EVP API > > This patch update the symmetric HMAC routine in crypto openssl > pmd to adopt openssl 3.0 EVP apis. > > Signed-off-by: Kai Ji > --- > dr

RE: [PATCH v2 0/2] mlx5/testpmd: external RxQ tests

2022-06-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Michael Baum > Sent: Thursday, June 16, 2022 8:10 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko > Subject: [PATCH v2 0/2] mlx5/testpmd: external RxQ tests > > Recently [1] mlx5 PMD added support for external queues, in th

Re: [PATCH v4 00/15] mlx5/vdpa: optimize live migration time

2022-06-21 Thread Maxime Coquelin
On 6/18/22 11:02, Li Zhang wrote: Allow the driver to use internal threads to obtain fast configuration. All the threads will be open on the same core of the event completion queue scheduling thread. Add max_conf_threads parameter to configure the maximum number of internal threads in additio

RE: [EXT] [dpdk-dev v4 2/4] crypto/openssl: 3.0 EVP update on RSA routine

2022-06-21 Thread Akhil Goyal
> This patch updates asymmetric RSA routine in crypto openssl pmd > to adopt openssl 3.0 EVP apis. > > Signed-off-by: Kai Ji > --- > drivers/crypto/openssl/openssl_pmd_private.h | 7 + > drivers/crypto/openssl/rte_openssl_pmd.c | 149 +++ > drivers/crypto/openssl/rte_openss

Re: [PATCH 0/3] Fix xmm_t to rte_xmm_t scalar conversion

2022-06-21 Thread Stanisław Kardach
On Tue, Jun 21, 2022 at 12:54 AM David Christensen wrote: > > > On Thu, Jun 9, 2022 at 2:17 PM Stanislaw Kardach wrote: > >> > >> As David noticed in [1] there is an issue with C++ compilation of the > >> rte_vect.h header in RISC-V. Upon closer inspection, the problem appears on > >> all archite

Re: [PATCH v3] vhost/crypto: fix build with GCC 12

2022-06-21 Thread Maxime Coquelin
On 6/16/22 16:46, David Marchand wrote: GCC 12 raises the following warning: In file included from ../lib/mempool/rte_mempool.h:46, from ../lib/mbuf/rte_mbuf.h:38, from ../lib/vhost/vhost_crypto.c:7: ../lib/vhost/vhost_crypto.c: In function ‘rte_vhost_crypt

[PATCH v2] app/testpmd: fix quit testpmd with vfs and pf

2022-06-21 Thread Ke Zhang
When testpmd startups with pf and vfs,this error occurs when quitting, results in pf is released before vfs ,so the vf would access an freed heap memory. The solution is two steps: 1. Fetch the valid port value from RTE_ETH_FOREACH_DEV. 2. free the port in reverse order. Fixes: 08fd782b8454 ("app

RE: [PATCH] net: fix checksum with unaligned buffer

2022-06-21 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Tuesday, 21 June 2022 10.23 > > On Tue, Jun 21, 2022 at 10:05:15AM +0200, Morten Brørup wrote: > > +TO: @Bruce and @Stephen: You signed off on the 16 bit alignment > requirement. We need background info on this. > > > > > From: E

Re: [PATCH 0/3] Fix xmm_t to rte_xmm_t scalar conversion

2022-06-21 Thread Bruce Richardson
On Tue, Jun 21, 2022 at 11:30:32AM +0200, Stanisław Kardach wrote: > On Tue, Jun 21, 2022 at 12:54 AM David Christensen > wrote: > > > > > On Thu, Jun 9, 2022 at 2:17 PM Stanislaw Kardach > > > wrote: > > >> > > >> As David noticed in [1] there is an issue with C++ compilation of the > > >> rte_

Re: [PATCH 0/3] Fix xmm_t to rte_xmm_t scalar conversion

2022-06-21 Thread Stanisław Kardach
On Tue, Jun 21, 2022 at 11:39 AM Bruce Richardson wrote: > > Generally the "cpp" binary is not the c-plus-plus one, but the C > preprocessor one. Perhaps the original files are incorrect here, and should > all refer to g++. > > /Bruce > That does make sense. I'll submit a separate patchset fixing

Re: [PATCH 0/3] Fix xmm_t to rte_xmm_t scalar conversion

2022-06-21 Thread Bruce Richardson
On Tue, Jun 21, 2022 at 11:42:55AM +0200, Stanisław Kardach wrote: > On Tue, Jun 21, 2022 at 11:39 AM Bruce Richardson > wrote: > > > > Generally the "cpp" binary is not the c-plus-plus one, but the C > > preprocessor one. Perhaps the original files are incorrect here, and should > > all refer to

RE: [EXT] [dpdk-dev v4 0/4] crypto/openssl: EVP api update for 3.0 lib

2022-06-21 Thread Akhil Goyal
> This patch set update openssl pmd deprecated APIs to EVP > APIs where supported in openssl 3.0 lib > > --- > v4: > - compilation issue fix > > v3: > - rebase to 22.07 rc1 > > v2: > - addin DSA routine > > --- > > Kai Ji (4): > crypto/openssl: 3.0 EVP update on HMAC routine > crypto/opens

Re: [PATCH 0/3] Fix xmm_t to rte_xmm_t scalar conversion

2022-06-21 Thread Thomas Monjalon
21/06/2022 11:49, Bruce Richardson: > On Tue, Jun 21, 2022 at 11:42:55AM +0200, Stanisław Kardach wrote: > > On Tue, Jun 21, 2022 at 11:39 AM Bruce Richardson > > wrote: > > > > > > Generally the "cpp" binary is not the c-plus-plus one, but the C > > > preprocessor one. Perhaps the original files

RE: [EXT] [PATCH] examples/fips_validation: fix link to libjansson

2022-06-21 Thread Akhil Goyal
> > When compiling this example out of DPDK, linking the executable fails > > with: > > > > ## Building fips_validation > > /usr/bin/ld: /tmp/ccQjeHBg.o: in function `fips_test_init': > > fips_validation.c:(.text+0x7ab): undefined reference to `json_loadf' > > /usr/bin/ld: /tmp/ccQjeHBg.o:

RE: [PATCH] crypto/qat: fix cleanup function default behaviour

2022-06-21 Thread Akhil Goyal
> > Full cookie data should be cleared by default if not algorithm > > specified. This is protection in case algorithm specific cleanup > > is not implemented. > > > > Fixes: 3b78aa7b2317 ("crypto/qat: refactor asymmetric crypto functions") > > > > Signed-off-by: Arek Kusztal > > --- > Acked-by: F

Re: [PATCH] examples/distributor: fix syntax on single core rx and distributor

2022-06-21 Thread Ferruh Yigit
On 6/21/2022 9:44 AM, Hunt, David wrote: Hi Ferruh, On 20/06/2022 18:10, Ferruh Yigit wrote: On 6/20/2022 5:31 PM, Abdullah Ömer Yamaç wrote: This patch fixes the syntax error when using the single-core for both rx and distributor functions. Fixes: 4a7f40c0ff9a ("examples/distributor: add de

[PATCH v2 00/12] preparation for the rte_flow offload of nfp PMD

2022-06-21 Thread Chaoyong He
This is the first patch series to add the support of rte_flow offload for nfp PMD, includes: Add the support of flower firmware Add the support of representor port Add the flower service infrastructure Add the cmsg interactive channels between pmd and fw * Changes since v1 - Fix the compile error

[PATCH v2 01/12] net/nfp: move app specific attributes to own struct

2022-06-21 Thread Chaoyong He
The NFP Card can load different firmware applications. Currently only the CoreNIC application is supported. This commit makes needed infrastructure changes in order to support other firmware applications too. Clearer separation is made between the PF device and any application specific concepts. T

[PATCH v2 02/12] net/nfp: simplify initialization and remove dead code

2022-06-21 Thread Chaoyong He
Calling nfp_net_init() is only done for the corenic firmware flavor and it is guaranteed to always be called from the primary process, so the explicit check for RTE_PROC_PRIMARY can be dropped. The calling graph of nfp_net_init() already guaranteed the free of resources when it fail, so remove the

[PATCH v2 03/12] net/nfp: move app specific init logic to own function

2022-06-21 Thread Chaoyong He
The NFP card can load different firmware applications. This commit move the init logic of corenic app of the secondary process into its own function. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_ethdev.c | 93 +--- 1 fi

[PATCH v2 04/12] net/nfp: add initial flower firmware support

2022-06-21 Thread Chaoyong He
This commits adds the basic probing infrastructure to support the flower firmware. This firmware is geared towards offloading OVS and can generally be found in /lib/firmware/netronome/flower. It is also used by the NFP kernel driver when OVS offload with TC is desired. This commit also adds the ba

[PATCH v2 05/12] net/nfp: add flower PF setup and mempool init logic

2022-06-21 Thread Chaoyong He
This commit adds the vNIC initialization logic for the flower PF vNIC. The flower firmware exposes this vNIC for the purposes of fallback traffic in the switchdev use-case. The logic of setting up this vNIC is similar to the logic seen in nfp_net_init() and nfp_net_start(). This commit also adds m

[PATCH v2 06/12] net/nfp: add flower PF related routines

2022-06-21 Thread Chaoyong He
This commit adds the start/stop/close routine of the flower PF vNIC. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/flower/nfp_flower.c | 193 1 file changed, 193 insertions(+) diff --git a/drivers/net/nfp/flower/nfp_flower.c

[PATCH v2 07/12] net/nfp: add flower ctrl VNIC related logics

2022-06-21 Thread Chaoyong He
This commit adds the setup/start logic for the ctrl vNIC. This vNIC is used by the PMD and flower firmware as a communication channel between driver and firmware. In the case of OVS it is also used to communicate flow statistics from hardware to the driver. A rte_eth device is not exposed to DPDK

[PATCH v2 08/12] net/nfp: move common rxtx function for flower use

2022-06-21 Thread Chaoyong He
This commit move some common Rx and Tx logic to the rxtx header file so that they can be re-used by flower tx and rx logic. Signed-off-by: Chaoyong He Signed-off-by: Heinrich Kuhn Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_rxtx.c | 32 +--- drivers/net/nf

[PATCH v2 09/12] net/nfp: add flower ctrl VNIC rxtx logic

2022-06-21 Thread Chaoyong He
Add a Rx and Tx function for the control vNIC. The logic is mostly identical to the normal Rx and Tx functionality of the NFP PMD. This commit also makes use of the ctrl vNIC service logic to service the ctrl vNIC Rx path. Signed-off-by: Chaoyong He Signed-off-by: Heinrich Kuhn Reviewed-by: Nik

[PATCH v2 10/12] net/nfp: add flower representor framework

2022-06-21 Thread Chaoyong He
This commit adds the framework to support flower representors. The number of VF representors are parsed from the command line. For physical port representors the current logic aims to create a representor for each physical port present on the hardware. A eth_dev is created for each phyport and VF,

[PATCH v2 11/12] net/nfp: move rxtx function to header file

2022-06-21 Thread Chaoyong He
Flower makes use of the same Rx and Tx checksum logic as the normal PMD. Expose it so that flower can make use of it. Signed-off-by: Chaoyong He Signed-off-by: Heinrich Kuhn Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_common.c| 2 +- drivers/net/nfp/nfp_ethdev.c| 2 +- driv

[PATCH v2 12/12] net/nfp: add flower PF rxtx logic

2022-06-21 Thread Chaoyong He
This commit implements the flower Rx logic. Fallback packets are multiplexed to the correct representor port based on the prepended metadata. The Rx poll is set to run on the existing service infrastructure. For Tx the existing NFP Tx logic is duplicated to keep the Tx two paths distinct. Flower f

RE: [PATCH] crypto/scheduler: fix qp_id in scheduler failover

2022-06-21 Thread Akhil Goyal
> > Subject: [PATCH] crypto/scheduler: fix qp_id in scheduler failover > > > > This commit fixes wrong qp_id value in cryptodev scheduler in failover mode. > > > > Fixes: 37f075dad1e9 ("crypto/scheduler: add fail-over scheduling mode") > > Cc: roy.fan.zh...@intel.com > > > > Signed-off-by: Jakub Wy

Re: [PATCH v6] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-06-21 Thread Thomas Monjalon
20/06/2022 10:35, David Marchand: > On Tue, May 24, 2022 at 9:52 PM Don Wallwork wrote: > > > > Add support for using hugepages for worker lcore stack memory. The > > intent is to improve performance by reducing stack memory related TLB > > misses and also by using memory local to the NUMA node o

Re: [PATCH v2] app/testpmd: fix quit testpmd with vfs and pf

2022-06-21 Thread Ferruh Yigit
On 6/21/2022 10:24 AM, Ke Zhang wrote: When testpmd startups with pf and vfs,this error occurs when quitting, results in pf is released before vfs ,so the vf would access an freed heap memory. The solution is two steps: 1. Fetch the valid port value from RTE_ETH_FOREACH_DEV. 2. free the port in

Re: [PATCH 0/3] Fix xmm_t to rte_xmm_t scalar conversion

2022-06-21 Thread Stanisław Kardach
On Tue, Jun 21, 2022 at 12:22 PM Thomas Monjalon wrote: > > 21/06/2022 11:49, Bruce Richardson: > > On Tue, Jun 21, 2022 at 11:42:55AM +0200, Stanisław Kardach wrote: > > > On Tue, Jun 21, 2022 at 11:39 AM Bruce Richardson > > > wrote: > > > > > > > > Generally the "cpp" binary is not the c-plus

RE: [EXT] [PATCH] test/ipsec: fix performance test failure

2022-06-21 Thread Akhil Goyal
> This patch initializes with 0 rte_ipsec_sa_prm inside the ipsec_sa struct. > Before it was passed uninitialized to rte_ipsec_sa_init(), > which does not check whether prm->ipsec_xform.esn.value is greater > than sa->sqn_mask. > > Bugzilla ID: 1023 > Fixes: f7f3ac6dcbe2 ("test/ipsec: add performa

RE: [PATCH] crypto/qat: fix missing copy guards in asym mod

2022-06-21 Thread Akhil Goyal
> > This commit fixes missing guards for size of memcpy, > > it is needed to prevent faulty access when incorrect length > > passed from the user. > > > > Fixes: 3b78aa7b2317 ("crypto/qat: refactor asymmetric crypto functions") > > > > Signed-off-by: Arek Kusztal > > --- > Acked-by: Fan Zhang Ap

Re: [PATCH] examples/distributor: fix syntax on single core rx and distributor

2022-06-21 Thread Omer Yamac
On 21.06.2022 13:26, Ferruh Yigit wrote: On 6/21/2022 9:44 AM, Hunt, David wrote: Hi Ferruh, On 20/06/2022 18:10, Ferruh Yigit wrote: On 6/20/2022 5:31 PM, Abdullah Ömer Yamaç wrote: This patch fixes the syntax error when using the single-core for both rx and distributor functions. Fixes: 4

Re: [PATCH] examples/distributor: fix syntax on single core rx and distributor

2022-06-21 Thread Ferruh Yigit
On 6/21/2022 12:18 PM, Omer Yamac wrote: On 21.06.2022 13:26, Ferruh Yigit wrote: On 6/21/2022 9:44 AM, Hunt, David wrote: Hi Ferruh, On 20/06/2022 18:10, Ferruh Yigit wrote: On 6/20/2022 5:31 PM, Abdullah Ömer Yamaç wrote: This patch fixes the syntax error when using the single-core for bo

RE: [PATCH 0/3] support new full context firmware

2022-06-21 Thread Akhil Goyal
> This series adds support for new full context > microcode in cn9k IPsec PMD. > > Anoob Joseph (1): > crypto/cnxk: improvements to fastpath handling > > Tejasree Kondoj (1): > crypto/cnxk: add anti-replay as per new firmware > > Vidya Sagar Velumuri (1): > crypto/cnxk: move IPsec SA creat

[PATCH] test/crypto: fix cipher offset for ZUC tests

2022-06-21 Thread Ciara Power
The cipher offset in bits was not being used in ZUC encryption test functions when creating the operation, it was hardcoded to 0. This is fixed to use the offset from the test vector as intended. Fixes: fd01a9be38d5 ("test/crypto: move IV to crypto op private data") Cc: pablo.de.lara.gua...@intel.

Re: [PATCH 0/3] Fix xmm_t to rte_xmm_t scalar conversion

2022-06-21 Thread Thomas Monjalon
21/06/2022 13:05, Stanisław Kardach: > On Tue, Jun 21, 2022 at 12:22 PM Thomas Monjalon wrote: > > > > 21/06/2022 11:49, Bruce Richardson: > > > On Tue, Jun 21, 2022 at 11:42:55AM +0200, Stanisław Kardach wrote: > > > > On Tue, Jun 21, 2022 at 11:39 AM Bruce Richardson > > > > wrote: > > > > > >

[PATCH 1/3] examples/vhost: update makefile to match meson build system

2022-06-21 Thread Herakliusz Lipiec
Meson build system creates a vhost binary but Makefile and docs reference same as vhost-switch. Updating makefile to match meson and the docs accordingly. Signed-off-by: Herakliusz Lipiec Acked-by: Bruce Richardson --- V2: * Moving relevant doc updates here from second patch as per Bruces su

[PATCH v2 1/3] examples/vhost: update makefile to match meson build system

2022-06-21 Thread Herakliusz Lipiec
Meson build system creates a vhost binary but Makefile and docs reference same as vhost-switch. Updating makefile to match meson and the docs accordingly. Signed-off-by: Herakliusz Lipiec Acked-by: Bruce Richardson --- V2: * Moving relevant doc updates here from second patch as per Bruces su

[PATCH v2 2/3] doc: update vhost sample app docs

2022-06-21 Thread Herakliusz Lipiec
Vhost sample app documentation describes parameters that are not in the code and omits parameters that exist. Also switching the order of sections on running vhost and VM, since the --client parameter in the sample line requires a socket to be created by VM. Removing uio references and updating wit

[PATCH v2 3/3] examples/vhost: update vhost usage message

2022-06-21 Thread Herakliusz Lipiec
updating vhost usage message to be aligned with the documentation. Signed-off-by: Herakliusz Lipiec Reviewed-by: Chenbo Xia --- examples/vhost/main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index c4d46de1c5..

Re: [PATCH 1/7] net/txgbe: support OEM subsystem vendor ID

2022-06-21 Thread Ferruh Yigit
On 6/20/2022 8:55 AM, Jiawen Wu wrote: Add support for OEM subsystem vendor ID. Signed-off-by: Jiawen Wu --- doc/guides/rel_notes/release_22_07.rst | 4 +++ drivers/net/txgbe/base/txgbe_hw.c | 37 ++ drivers/net/txgbe/base/txgbe_hw.h | 2 ++ drivers/net/

Re: [PATCH 2/7] net/ngbe: support OEM subsystem vendor ID

2022-06-21 Thread Ferruh Yigit
On 6/20/2022 8:55 AM, Jiawen Wu wrote: Add support for OEM subsystem vendor ID. Signed-off-by: Jiawen Wu --- doc/guides/rel_notes/release_22_07.rst | 1 + drivers/net/ngbe/ngbe_ethdev.c | 13 - 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/doc/guides/re

Re: [PATCH 3/7] net/txgbe: fix register polling

2022-06-21 Thread Ferruh Yigit
On 6/20/2022 8:55 AM, Jiawen Wu wrote: Fix to poll some specific registers, which expect bit 0. Fixes: 24a4c76aff4d ("net/txgbe: add error types and registers") Cc: sta...@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/base/txgbe_regs.h | 11 --- 1 file changed, 8 insertion

Re: [PATCH 0/7] Fixes and supports for Wangxun NICs

2022-06-21 Thread Ferruh Yigit
On 6/20/2022 8:55 AM, Jiawen Wu wrote: Fix the remaining bugs, support more OEM devices. Jiawen Wu (7): net/txgbe: support OEM subsystem vendor ID net/ngbe: support OEM subsystem vendor ID net/txgbe: fix register polling net/ngbe: add more packet statistics net/ngbe: fix YT PHY UT

[PATCH 0/2] fix C++ include checks in cross-compilation

2022-06-21 Thread Stanislaw Kardach
Meson detects the C++ cross-compiler during configuration and based on that reports whether C++ language is available or not. The C++ include check target (buildtools/chkincs/chkincs-cpp) is only built when C++ language is available. There are 2 issues that currently prevent those checks to be run

[PATCH 1/2] config: Use G++ as C++ compiler

2022-06-21 Thread Stanislaw Kardach
Through some mixup all cross-files for PowerPC and ARM platforms were using C Preprocessor (cpp) instead of GCC (g++). This caused meson to fail detecting the C++ compiler presence and therefore disabling some targets (i.e. C++ include file checks). Signed-off-by: Stanislaw Kardach --- config/ar

[PATCH 2/2] ci: use crossbuild-essential packages

2022-06-21 Thread Stanislaw Kardach
The crossbuild-essential- packages contain all necessary dependencies to cross-compile binaries for a given architecture including C and C++ compilers. Therefore use those instead of listing packages directly. This way C++ compiler is also installed and C++ include checks will be checked in CI for

[PATCH] config/riscv: name the cross file properly

2022-06-21 Thread Stanislaw Kardach
Since the riscv64_linux_gcc was in fact a Ubuntu-specific cross-file, rename it. Signed-off-by: Stanislaw Kardach --- .ci/linux-build.sh | 2 +- config/riscv/{riscv64_linux_gcc => riscv64_linux_gcc_ubuntu} | 0 devtools/test-meson-builds.sh

Re: [PATCH v6] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-06-21 Thread Don Wallwork
On 6/21/2022 6:37 AM, Thomas Monjalon wrote: 20/06/2022 10:35, David Marchand: On Tue, May 24, 2022 at 9:52 PM Don Wallwork wrote: Add support for using hugepages for worker lcore stack memory. The intent is to improve performance by reducing stack memory related TLB misses and also by using

RE: [PATCH v2 0/3] support stream cipher chained operations

2022-06-21 Thread Akhil Goyal
> This series adds support for zuc, snow3g and > aes-ctr-cmac chained operations in cn9k PMD. > > v2: > * Split autotest patch into separate series > > Tejasree Kondoj (3): > crypto/cnxk: fix CMAC IV > crypto/cnxk: support stream cipher chained operations > crypto/cnxk: support scatter gath

Re: [PATCH 0/3] Fix xmm_t to rte_xmm_t scalar conversion

2022-06-21 Thread Stanisław Kardach
On Tue, Jun 21, 2022 at 1:53 PM Thomas Monjalon wrote: > > If it is made intentionally hard, it is just a wrong design. > A toolchain prefix is just a name. > We can have 2 toolchains compiled with the same name and different behaviours. > And we can have 2 similar toolchains with a different nam

RE: [PATCH] crypto/cnxk: add CPT hardware flow control checks

2022-06-21 Thread Akhil Goyal
> Add hardware supported flow control checks before enqueueing to CPT. > Since both poll mode and event mode can be used at the same time, add > hardware flow control checks to make sure s/w doesn't over submit to > hardware queues. For cn9k, queue depth usage is not high and so FC check > is omitt

RE: [PATCH v2] app/test: add additional stream cipher tests

2022-06-21 Thread Akhil Goyal
> Adding zuc, snow3g and aes-ctr-cmac auth-cipher > test vectors with same auth and cipher offsets > and total digest data encrypted. > Existing tests have different cipher and > auth offsets and partial or no digest encrypted. > > Signed-off-by: Tejasree Kondoj > --- Acked-by: Akhil Goyal @Cia

RE: [dpdk-dev] [PATCH v4] examples/ipsec-secgw: support more flow patterns and actions

2022-06-21 Thread Akhil Goyal
> > From: Satheesh Paul > > Added support to create flow rules with count, mark and > security actions and mark pattern. > > Signed-off-by: Satheesh Paul > --- Acked-by: Akhil Goyal

  1   2   >