Re: [PATCH v2] vhost: fix avail idx update error when desc copy failed

2022-07-01 Thread Gaoxiang Liu
Hi,Chenbo If vhost driver receives a mbuf list,the mbuf list has two mbuf, and the pkt_len of the first mbuf in the mbuf list is the sum of data_len of all mbuf,and the pkt_len of the second mbuf is 0. When desc_to_mbuf failed,i added 1 and last_avail_idx added i. It may cause the first mbuf to

Re: release candidate 22.07-rc2

2022-07-01 Thread Thinh Tran
Hi IBM - Power Systems DPDK v22.07-rc2 * Basic PF on Mellanox: No new issues or regressions were seen. * Performance: not tested. * OS: RHEL 8.5 kernel: 4.18.0-372.9.1.el8.ppc64le with gcc version 8.5.0 20210514 (Red Hat 8.5.0-10) RHEL 9.0 kernel: 5.14.0-70.13.1.el9_0.ppc64le

RE: Service core statistics MT safety

2022-07-01 Thread Morten Brørup
> From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Friday, 1 July 2022 20.38 > > > > > > > > > > > > At the time of the read operation (in the global counter > solution), > > > > there may well be cycles consumed or calls having been made, but > not > > > > yet posted. Th

RE: [PATCH v4] net: fix checksum with unaligned buffer

2022-07-01 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, 1 July 2022 19.05 > > On Fri, 1 Jul 2022 18:50:34 +0200 > Morten Brørup wrote: > > > But I guess it is something else. > > > > Anyway, this function has ugly alignment problems (also before the > patch), and has gone t

RE: [PATCH v1 0/5] Direct re-arming of buffers on receive side

2022-07-01 Thread Morten Brørup
> From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Friday, 1 July 2022 21.31 > > > > > > > > > > > > > 16/05/2022 07:10, Feifei Wang пишет: > > > > > > > > > > > >>> Currently, the transmit side frees the buffers into the > > > lcore > > > > > >>> ca

RE: [PATCH 01/17] net/mana: add basic driver, build environment and doc

2022-07-01 Thread Long Li
> Subject: Re: [PATCH 01/17] net/mana: add basic driver, build environment and > doc > > On Fri, 1 Jul 2022 02:02:31 -0700 > lon...@linuxonhyperv.com wrote: > > > diff --git a/drivers/net/mana/meson.build > > b/drivers/net/mana/meson.build new file mode 100644 index > > 00..7ab34c253c >

RE: [PATCH v1 0/5] Direct re-arming of buffers on receive side

2022-07-01 Thread Honnappa Nagarahalli
> > > > > > > > 16/05/2022 07:10, Feifei Wang пишет: > > > > > > > > > >>> Currently, the transmit side frees the buffers into the > > lcore > > > > >>> cache and the receive side allocates buffers from the > > > > >>> lcore > > > > cache. > > > > >>> The transmit si

RE: [EXT] [dpdk-dev v1] crypto/openssl: EVP_PKEY routine update in rsa op

2022-07-01 Thread Akhil Goyal
> EVP_PKEY function need to be called twice for rsa sign and verify > operations. This patch also remove the OPENSSL_API_COMPAT as all > the deprecated APIs are avoid if 3.0 lib is present. > > Fixes: d7bd42f6db19 ("crypto/openssl: update RSA routine with 3.0 EVP API") > Cc: kai...@intel.com No ne

RE: [PATCH v1] examples/fips_validation: fix print for zero length payload

2022-07-01 Thread Akhil Goyal
> Subject: [PATCH v1] examples/fips_validation: fix print for zero length > payload > > NIST GCM decrypt result vectors expects to have following print > for zero length payload instead of having no print. > "pt" = "" > > Fixes: b09aac2d6e2b ("examples/fips_validation: add JSON to GCM test") >

RE: [EXT] Re: [PATCH v2] examples/ipsec-secgw: fix fallback session create

2022-07-01 Thread Akhil Goyal
> Tested-by: Vladimir Medvedkin > > On 30/06/2022 12:45, Radu Nicolau wrote: > > Fix fallback session create for inline sessions. > > > > Fixes: a8ade12123c3 ("examples/ipsec-secgw: create lookaside sessions at > init") > > Cc: vfia...@marvell.com > > > > Signed-off-by: Radu Nicolau Acked-by: Ak

RE: [EXT] [PATCH v2] doc/qat: update QAT driver location

2022-07-01 Thread Akhil Goyal
> This commit removes any references to the old QAT > driver location 01.org in the documentation and > replaces them with the updated location intel.com. Replaced intel.com with IDZ > > This commit also adds a note to the docs to alert > users of a possible error when building the new QAT > dri

RE: [EXT] [PATCH v1] doc/l2_forward_crypto: fixed grammar and parameters

2022-07-01 Thread Akhil Goyal
> > Doc was updated with fixed grammar in most cases. These > > include adding periods to ends of sentences and capitalizing > > some words. Some instances of "a" were changed to "an". The > > option "-n 4" has also been removed from the example of > > running the application. > > > > Fixes: ba7

RE: [PATCH] doc/compressdev: fix grammar and formatting

2022-07-01 Thread Akhil Goyal
> > Subject: [PATCH] doc/compressdev: fix grammar and formatting Title updated while merging. doc: fix grammar and formatting in compressdev guide > > > > Small improvements made to the compressdev programmer's guide. > > This includes rephrasing some sentences, fixing grammar, > > and aligning fo

RE: Service core statistics MT safety

2022-07-01 Thread Honnappa Nagarahalli
> > > > > > At the time of the read operation (in the global counter solution), > > > there may well be cycles consumed or calls having been made, but not > > > yet posted. The window between call having been made, and global > > > counter having been incremented (and thus made globally visible

RE: [EXT] [PATCH] crypto/qat: fix secure session check

2022-07-01 Thread Akhil Goyal
> Currently when running the dpdk-perf-test with docsis > security sessions, a segmentation fault occurs. This > is due to the check being made that the session is not > equal to op->sym->sec_session. This check passes the > first time but on the second iteration fails and doesn't > create the buil

[PATCH v2] doc/qat: update QAT driver location

2022-07-01 Thread Rebecca Troy
This commit removes any references to the old QAT driver location 01.org in the documentation and replaces them with the updated location intel.com. This commit also adds a note to the docs to alert users of a possible error when building the new QAT driver and provides the patch needed to resolve

Re: [PATCH v4] net: fix checksum with unaligned buffer

2022-07-01 Thread Stephen Hemminger
On Fri, 1 Jul 2022 18:50:34 +0200 Morten Brørup wrote: > But I guess it is something else. > > Anyway, this function has ugly alignment problems (also before the patch), > and has gone through a couple of iterations to silence warnings from the > compiler. These warnings should have been addre

Re: [PATCH v2 1/2] net/memif: add a Rx fast path

2022-07-01 Thread Stephen Hemminger
On Fri, 1 Jul 2022 10:28:14 + Joyce Kong wrote: > n_slots = last_slot - cur_slot; > + if (likely(mbuf_size >= pmd->cfg.pkt_buffer_size)) { > + while (n_slots && n_rx_pkts < nb_pkts) { > + mbuf_head = rte_pktmbuf_alloc(mq->mempool); > +

RE: [PATCH v4] net: fix checksum with unaligned buffer

2022-07-01 Thread Morten Brørup
> From: Emil Berg [mailto:emil.b...@ericsson.com] > Sent: Friday, 1 July 2022 06.11 > > > From: Stephen Hemminger > > Sent: den 30 juni 2022 19:46 > > > > On Thu, 23 Jun 2022 14:39:00 +0200 > > Morten Brørup wrote: > > > > > + /* if buffer is unaligned, keeping it byte order independent */ > > >

Re: [PATCH 01/17] net/mana: add basic driver, build environment and doc

2022-07-01 Thread Stephen Hemminger
On Fri, 1 Jul 2022 02:02:31 -0700 lon...@linuxonhyperv.com wrote: > diff --git a/drivers/net/mana/meson.build b/drivers/net/mana/meson.build > new file mode 100644 > index 00..7ab34c253c > --- /dev/null > +++ b/drivers/net/mana/meson.build > @@ -0,0 +1,34 @@ > +# SPDX-License-Identifier:

Re: [PATCH 01/17] net/mana: add basic driver, build environment and doc

2022-07-01 Thread Stephen Hemminger
On Fri, 1 Jul 2022 02:02:31 -0700 lon...@linuxonhyperv.com wrote: > + uint64_t max_mr_size; > + rte_rwlock_tmr_list_lock; > +}; Reader/Writer locks are slower for the usual uncontended case. Unless you have a reader holding onto the lock for a long time, better to use spin lock. Thi

Re: [PATCH 01/17] net/mana: add basic driver, build environment and doc

2022-07-01 Thread Stephen Hemminger
On Fri, 1 Jul 2022 02:02:31 -0700 lon...@linuxonhyperv.com wrote: > + > +struct mana_priv { > + struct rte_eth_dev_data *dev_data; > + struct mana_process_priv *process_priv; > + int num_queues; > + > + /* DPDK port */ > + int port_id; > + > + /* IB device port */ > +

Re: [PATCH 01/17] net/mana: add basic driver, build environment and doc

2022-07-01 Thread Stephen Hemminger
On Fri, 1 Jul 2022 02:02:31 -0700 lon...@linuxonhyperv.com wrote: > + while (fgets(line, sizeof(line), file) == line) { > + size_t len = strlen(line); > + int ret; > + > + /* Truncate long lines. */ > + if (len == (sizeof(line) - 1)) > +

Re: [PATCH 13/17] net/mana: add function to start/stop RX queues

2022-07-01 Thread Stephen Hemminger
On Fri, 1 Jul 2022 02:02:43 -0700 lon...@linuxonhyperv.com wrote: > + > +static uint8_t mana_rss_hash_key_default[TOEPLITZ_HASH_KEY_SIZE_IN_BYTES] = { > + 0x2c, 0xc6, 0x81, 0xd1, > + 0x5b, 0xdb, 0xf4, 0xf7, > + 0xfc, 0xa2, 0x83, 0x19, > + 0xdb, 0x1a, 0x3e, 0x94, > + 0x6b, 0x9e

Re: [PATCH 12/17] net/mana: add function to start/stop TX queues

2022-07-01 Thread Stephen Hemminger
On Fri, 1 Jul 2022 02:02:42 -0700 lon...@linuxonhyperv.com wrote: > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#in

Re: [PATCH 11/17] net/mana: implement the hardware layer operations

2022-07-01 Thread Stephen Hemminger
On Fri, 1 Jul 2022 02:02:41 -0700 lon...@linuxonhyperv.com wrote: > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include This is including everything and much of this no

Re: [PATCH 10/17] net/mana: implement memory registration

2022-07-01 Thread Stephen Hemminger
On Fri, 1 Jul 2022 02:02:40 -0700 lon...@linuxonhyperv.com wrote: > +int new_pmd_mr(struct mana_mr_btree *local_tree, struct mana_priv *priv, > +struct rte_mempool *pool); > +void remove_all_mr(struct mana_priv *priv); > +void del_pmd_mr(struct mana_mr_cache *mr); Please use one pref

Re: [PATCH 02/17] net/mana: add device configuration and stop

2022-07-01 Thread Stephen Hemminger
On Fri, 1 Jul 2022 02:02:32 -0700 lon...@linuxonhyperv.com wrote: > + > + if (txmode->offloads & ~BNIC_DEV_TX_OFFLOAD_SUPPORT) { > + DRV_LOG(ERR, "Unsupported TX offload: %lx", txmode->offloads); > + return -EINVAL; > + } > + > + if (rxmode->offloads & ~BNIC_DE

Re: [PATCH 01/17] net/mana: add basic driver, build environment and doc

2022-07-01 Thread Stephen Hemminger
On Fri, 1 Jul 2022 02:02:31 -0700 lon...@linuxonhyperv.com wrote: > diff --git a/doc/guides/nics/features/mana.ini > b/doc/guides/nics/features/mana.ini > new file mode 100644 > index 00..9d8676089b > --- /dev/null > +++ b/doc/guides/nics/features/mana.ini > @@ -0,0 +1,10 @@ > +; > +; Su

[PATCH] doc: announce changes to rte_eth_set_queue_rate_limit api

2022-07-01 Thread skoteshwar
From: Satha Rao rte_eth_set_queue_rate_limit argument rate modified to uint64_t to support more than 64Gbps. Signed-off-by: Satha Rao --- doc/guides/rel_notes/deprecation.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/d

RE: [PATCH] app/testpmd: fix GTP PSC raw processing

2022-07-01 Thread Gregory Etelson
Hello, > > --- a/app/test-pmd/cmdline_flow.c > > +++ b/app/test-pmd/cmdline_flow.c > > @@ -11030,10 +11030,12 @@ cmd_set_raw_parsed(const struct buffer > *in) > > const struct rte_flow_item_gtp_psc > > *opt = item->spec; > >

Re: release candidate 22.07-rc2

2022-07-01 Thread Ferruh Yigit
On 6/27/2022 3:15 AM, Thomas Monjalon wrote: A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v22.07-rc2 There are 317 new patches in this snapshot. Release notes: https://doc.dpdk.org/guides/rel_notes/release_22_07.html There were a lot of u

RE: [PATCH v2] vhost: fix unchecked return value

2022-07-01 Thread Hu, Jiayu
> -Original Message- > From: Maxime Coquelin > Sent: Friday, July 1, 2022 10:00 PM > To: Hu, Jiayu ; dev@dpdk.org > Cc: Xia, Chenbo ; sta...@dpdk.org > Subject: Re: [PATCH v2] vhost: fix unchecked return value > > > > On 6/29/22 11:07, Jiayu Hu wrote: > > This patch checks the return

Re: [PATCH v2 0/4] Vhost logs fixes and improvement

2022-07-01 Thread Maxime Coquelin
On 7/1/22 09:55, David Marchand wrote: Here is a series that fixes log messages (with one regression being fixed in patch 2) and changes the VHOST_LOG_* helpers to enforce that vhost log messages will always have some context/prefix to help debugging on setups with many vhost ports. The first

Re: [PATCH v3] vhost: prefix logs with context

2022-07-01 Thread Maxime Coquelin
On 7/1/22 15:20, David Marchand wrote: We recently improved the log messages in the vhost library, adding some context that helps filtering for a given vhost-user device. However, some parts of the code were missed, and some later code changes broke this new convention (fixes were sent previou

Re: [PATCH v2] vhost: fix unchecked return value

2022-07-01 Thread Maxime Coquelin
On 6/29/22 11:07, Jiayu Hu wrote: This patch checks the return value of rte_dma_info_get() called in rte_vhost_async_dma_configure(). Coverity issue: 379066 Fixes: 53d3f4778c1d ("vhost: integrate dmadev in asynchronous data-path") Cc: sta...@dpdk.org Signed-off-by: Jiayu Hu Reviewed-by: Che

Re: [PATCH v2] vdpa/sfc: handle sync issue between qemu and vhost-user

2022-07-01 Thread Maxime Coquelin
On 6/28/22 07:29, abhimanyu.sa...@xilinx.com wrote: From: Abhimanyu Saini When DPDK app is running in the VF, it sometimes rings the doorbell before dev_config has had a chance to complete and hence it misses the event. As workaround, ring the doorbell when vDPA reports the notify_area to QE

Re: [PATCH v2] net/vhost: fix deadlock on vring state change

2022-07-01 Thread Maxime Coquelin
On 6/27/22 07:51, Yuan Wang wrote: If vring state changes after pmd starts working, the locked vring notifies pmd, thus calling update_queuing_status(), the latter will wait for pmd to finish accessing vring, while pmd is also waiting for vring to be unlocked, thus causing deadlock. Actually,

Re: [PATCH] vdpa/mlx5: add ConnectX-6 LX device ID

2022-07-01 Thread Maxime Coquelin
On 6/23/22 11:00, Wisam Jaddo wrote: This adds ConnectX-6 LX to the list of supported Mellanox devices that run the MLX5 vdpa PMD. Signed-off-by: Wisam Jaddo --- drivers/vdpa/mlx5/mlx5_vdpa.c | 4 1 file changed, 4 insertions(+) Applied to dpdk-next-virtio/main. Thanks, Maxime

Re: [PATCH v4] examples/vhost: fix retry logic on eth rx path

2022-07-01 Thread Maxime Coquelin
On 6/22/22 11:25, Yuan Wang wrote: drain_eth_rx() uses rte_vhost_avail_entries() to calculate the available entries to determine if a retry is required. However, this function only works with split rings, and calculating packed rings will return the wrong value and cause unnecessary retries re

Re: [PATCH] vhost: fix sync dequeue offload

2022-07-01 Thread Maxime Coquelin
On 6/24/22 07:38, xuan.d...@intel.com wrote: From: Xuan Ding This patch fixes the missing virtio net header copy in sync dequeue path caused by refactoring, which affects dequeue offloading. Fixes: 6d823bb302c7("vhost: prepare sync for descriptor to mbuf refactoring") Signed-off-by: Xuan D

Re: [PATCH v3] doc: clean vhost async path doc

2022-07-01 Thread Maxime Coquelin
On 6/22/22 03:45, xuan.d...@intel.com wrote: From: Xuan Ding This patch moves the 'Recommended IOVA mode in async datapath' section under 'Vhost asynchronous data path' as a sub-section, which makes the doc cleaner. Signed-off-by: Xuan Ding Reviewed-by: Jiayu Hu --- v3: * add Reviewd-by

Re: [PATCH] vhost: fix virtio blk vDPA live migration IO drop

2022-07-01 Thread Maxime Coquelin
On 6/22/22 09:47, Andy Pei wrote: In the virtio blk vDPA live migration use case, before the live migration process, QEMU will set call fd to vDPA back-end. QEMU and vDPA back-end stand by until live migration starts. During live migration process, QEMU sets kick fd and a new call fd. However,

Re: [PATCH] vdpa/ifc: fix vhost message size check issue

2022-07-01 Thread Maxime Coquelin
On 6/21/22 15:46, Andy Pei wrote: For vhost message VHOST_USER_GET_CONFIG, we do not check payload size in vhost lib, we check payload size in driver specific ops. For ifc vdpa driver, we just need to make sure payload size is not smaller than sizeof(struct virtio_blk_config). Fixes: 856d03bc

Re: [PATCH v2] doc: update async enqueue API usage

2022-07-01 Thread Maxime Coquelin
On 6/21/22 09:21, xuan.d...@intel.com wrote: From: Xuan Ding This patch updates the correct usage for async enqueue APIs. The rte_vhost_poll_enqueue_completed() needs to be called in time to notify the guest of completed packets and avoid packet loss. Signed-off-by: Xuan Ding --- v2: * ref

Re: [PATCH] net/virtio: fix socket nonblocking mode affects initialization

2022-07-01 Thread Maxime Coquelin
On 6/17/22 04:42, Yuan Wang wrote: The virtio-user initialization requires unix socket to receive backend messages in block mode. However, vhost_user_update_link_state() sets the same socket to nonblocking via fcntl, which affects all threads. Enabling the rxq interrupt can causes both of thes

Re: [PATCH v3 3/3] examples/vhost: update vhost usage message

2022-07-01 Thread Maxime Coquelin
On 6/21/22 17:20, Herakliusz Lipiec wrote: updating vhost usage message to be aligned with the documentation. Signed-off-by: Herakliusz Lipiec Reviewed-by: Chenbo Xia --- examples/vhost/main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Applied to dpdk-next-vir

Re: [PATCH v3 2/3] doc: update vhost sample app docs

2022-07-01 Thread Maxime Coquelin
On 6/21/22 17:20, Herakliusz Lipiec wrote: Vhost sample app documentation describes parameters that are not in the code and omits parameters that exist. Also switching the order of sections on running vhost and VM, since the --client parameter in the sample line requires a socket to be created

Re: [PATCH v3 1/3] examples/vhost: update makefile to match meson build system

2022-07-01 Thread Maxime Coquelin
On 6/21/22 17:20, Herakliusz Lipiec wrote: Meson build system creates a vhost binary but Makefile and docs reference same as vhost-switch. Updating makefile to match meson and the docs accordingly. Signed-off-by: Herakliusz Lipiec Acked-by: Bruce Richardson --- V2: * Moving relevant doc u

Re: [PATCH v2] doc/prog_guide: fix readability in lib vhost prog guide

2022-07-01 Thread Maxime Coquelin
On 6/23/22 15:57, Herakliusz Lipiec wrote: fix grammar issues and readbility in vhost library programmer guide Fixes: 768274ebbd5e ("vhost: avoid populate guest memory") Cc: sta...@dpdk.org Signed-off-by: Herakliusz Lipiec --- doc/guides/prog_guide/vhost_lib.rst | 18 +-

Re: [PATCH] app/testpmd: fix GTP PSC raw processing

2022-07-01 Thread Singh, Aman Deep
Hi Gregory, On 6/30/2022 6:20 PM, Gregory Etelson wrote: Fix GTP PSP extension size initialization. Clear input buffer. cc: sta...@dpdk.org Fixes: c65282c9aa31 ("app/testpmd: fix GTP PSC raw processing") Signed-off-by: Gregory Etelson --- app/test-pmd/cmdline_flow.c | 6 -- 1 file cha

Re: [PATCH v3 1/3] examples/vhost: update makefile to match meson build system

2022-07-01 Thread Maxime Coquelin
On 6/21/22 17:20, Herakliusz Lipiec wrote: Meson build system creates a vhost binary but Makefile and docs reference same as vhost-switch. Updating makefile to match meson and the docs accordingly. Signed-off-by: Herakliusz Lipiec Acked-by: Bruce Richardson --- V2: * Moving relevant doc u

[PATCH v3] vhost: prefix logs with context

2022-07-01 Thread David Marchand
We recently improved the log messages in the vhost library, adding some context that helps filtering for a given vhost-user device. However, some parts of the code were missed, and some later code changes broke this new convention (fixes were sent previous to this patch). Change the VHOST_LOG_CONF

RE: [PATCH v3 2/3] doc: update vhost sample app docs

2022-07-01 Thread Xia, Chenbo
> -Original Message- > From: Lipiec, Herakliusz > Sent: Tuesday, June 21, 2022 11:21 PM > To: maxime.coque...@redhat.com; Xia, Chenbo ; > Richardson, Bruce > Cc: dev@dpdk.org; Lipiec, Herakliusz > Subject: [PATCH v3 2/3] doc: update vhost sample app docs > > Vhost sample app documentati

RE: [PATCH v2] vhost: fix avail idx update error when desc copy failed

2022-07-01 Thread Xia, Chenbo
> -Original Message- > From: Gaoxiang Liu > Sent: Wednesday, June 22, 2022 9:20 AM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; liugaoxi...@huawei.com; Gaoxiang Liu > ; sta...@dpdk.org > Subject: [PATCH v2] vhost: fix avail idx update error when desc copy > failed >

Re: [PATCH v3 1/4] doc/howto: rework section on virtio-user as exception path

2022-07-01 Thread Maxime Coquelin
On 6/10/22 17:35, Bruce Richardson wrote: This patch extensively reworks the howto guide on using virtio-user for exception packets. Changes include: * rename "exceptional path" to "exception path" * remove references to uio and just reference vfio-pci * simplify testpmd command-lines, giving

[PATCH] net/cnxk: fix to display extended stats

2022-07-01 Thread Rakesh Kudurumalla
This fix replaces the usage of roc_nix_num_xstats_get() which is compile time api with runtime api roc_nix_xstats_names_get() resolving xstat count difference for cn9k and cn10k while displaying xstats for dpdk ports Fixes: 825bd1d9d8e6 ("common/cnxk: update extra stats for inline device") Signed

RE: [PATCH v2] net/vhost: fix deadlock on vring state change

2022-07-01 Thread Xia, Chenbo
> -Original Message- > From: Wang, YuanX > Sent: Monday, June 27, 2022 1:51 PM > To: maxime.coque...@redhat.com; Xia, Chenbo ; > dev@dpdk.org > Cc: Hu, Jiayu ; He, Xingguang ; > Jiang, Cheng1 ; Ling, WeiX ; > Wang, YuanX ; sta...@dpdk.org > Subject: [PATCH v2] net/vhost: fix deadlock on vr

Re: [PATCH] mbuf: add mbuf physical address field to dynamic field

2022-07-01 Thread Shijith Thotton
>> If all devices are configured to run in IOVA mode as VA, physical >> address field of mbuf (buf_iova) won't be used. In such cases, buf_iova >> space is free to use as a dynamic field. So a new dynamic field member >> (dynfield2) is added in mbuf structure to make use of that space. >> >> A new

Re: [PATCH] mbuf: add mbuf physical address field to dynamic field

2022-07-01 Thread Shijith Thotton

Re: [PATCH] vdpa/ifc: fix vhost message size check issue

2022-07-01 Thread Maxime Coquelin
On 6/21/22 15:46, Andy Pei wrote: For vhost message VHOST_USER_GET_CONFIG, we do not check payload size in vhost lib, we check payload size in driver specific ops. For ifc vdpa driver, we just need to make sure payload size is not smaller than sizeof(struct virtio_blk_config). Fixes: 856d03bc

Re: [PATCH] vhost: fix virtio blk vDPA live migration IO drop

2022-07-01 Thread Maxime Coquelin
On 6/22/22 09:47, Andy Pei wrote: In the virtio blk vDPA live migration use case, before the live migration process, QEMU will set call fd to vDPA back-end. QEMU and vDPA back-end stand by until live migration starts. During live migration process, QEMU sets kick fd and a new call fd. However,

RE: [EXT] Re: [PATCH] mbuf: add mbuf physical address field to dynamic field

2022-07-01 Thread Shijith Thotton
> >On Thu, Jun 30, 2022 at 05:55:21PM +0100, Bruce Richardson wrote: >> On Thu, Jun 30, 2022 at 09:55:16PM +0530, Shijith Thotton wrote: >> > If all devices are configured to run in IOVA mode as VA, physical >> > address field of mbuf (buf_iova) won't be used. In such cases, buf_iova >> > space is

[PATCH] common/cnxk: allow changing PTP mode on 10k platforms

2022-07-01 Thread Tomasz Duszynski
Since firmware has added support for toggling PTP mode on 10k platforms userspace code should allow doing that as well. Cc: sta...@dpdk.org Signed-off-by: Tomasz Duszynski Reviewed-by: Jerin Jacob Kollanukkaran --- drivers/common/cnxk/roc_bphy_cgx.c | 3 --- 1 file changed, 3 deletions(-) dif

RE: [PATCH] mbuf: add mbuf physical address field to dynamic field

2022-07-01 Thread Slava Ovsiienko
Hi, Just to note, some PMDs do not use physical address field at all. As an example - mlx5 PMD (and it is far from being the only one) could take an advantage from this patch. Nonetheless, I tend to agree - for the whole DPDK framework it looks risky. I had the similar thoughts about removing iova

RE: [PATCH] app/testpmd: fix secondary process cannot dump packet

2022-07-01 Thread Zhang, Peng1X
Hi, In fact, the patch is aim to fix this issue that secondary process cannot dump packet after start testpmd. This issue is induced by commit id is 3c4426db54fc ("app/testpmd: do not poll stopped queues"). After secondary process start, the default value of Rx/Tx queue state maintained by tes

[PATCH] docs: change the doc to highlight the allowed multicast addresses

2022-07-01 Thread huzaifa.rahman
Bugzilla ID: 802 The ipv4_multicast example does not work with any multicast IPs. Only a selected few IPs are allowed to send pakcets. These IPs are listed in an mcast_group_table array along with their respective port masks. A normal user would not know about this behaviour since there is no ment

[PATCH v2 2/2] net/memif: add a Tx fast path

2022-07-01 Thread Joyce Kong
For memif non-zero-copy mode, there is a branch to compare the mbuf and memif buffer size during memory copying. If all mbufs come from the same mempool, and memif buf size >= mbuf size, add a fast Tx memory copy path without the comparing branch and with mbuf bulk free, otherwise still run the ori

[PATCH v2 1/2] net/memif: add a Rx fast path

2022-07-01 Thread Joyce Kong
For memif non-zero-copy mode, there is a branch to compare the mbuf and memif buffer size during memory copying. Add a fast memory copy path by removing this branch with mbuf and memif buffer size defined at compile time. The removal of the branch leads to considerable performance uplift. The Rx fa

[PATCH v2 0/2] add a fast path for memif Rx/Tx

2022-07-01 Thread Joyce Kong
For memif non-zero-copy mode, there is a branch to compare the mbuf and memif buffer size during memory copying. Add a fast memory copy path by removing this branch with mbuf and memif buffer size defined at compile time. And for Tx fast path, bulk free the mbufs which come from the same mempool.

RE: [PATCH] net/virtio: fix socket nonblocking mode affects initialization

2022-07-01 Thread Xia, Chenbo
> -Original Message- > From: Wang, YuanX > Sent: Friday, June 17, 2022 10:42 AM > To: maxime.coque...@redhat.com; Xia, Chenbo ; > dev@dpdk.org > Cc: Hu, Jiayu ; He, Xingguang ; > Wang, YuanX ; sta...@dpdk.org > Subject: [PATCH] net/virtio: fix socket nonblocking mode affects > initializati

RE: [PATCH] vhost: fix sync dequeue offload

2022-07-01 Thread Xia, Chenbo
> -Original Message- > From: Ding, Xuan > Sent: Friday, June 24, 2022 1:38 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Ling, WeiX > ; Ding, Xuan > Subject: [PATCH] vhost: fix sync dequeue offload > > From: Xuan Ding > > This patch fixes the missing

Re: [PATCH] mbuf: add mbuf physical address field to dynamic field

2022-07-01 Thread Olivier Matz
Hi, On Thu, Jun 30, 2022 at 05:55:21PM +0100, Bruce Richardson wrote: > On Thu, Jun 30, 2022 at 09:55:16PM +0530, Shijith Thotton wrote: > > If all devices are configured to run in IOVA mode as VA, physical > > address field of mbuf (buf_iova) won't be used. In such cases, buf_iova > > space is fr

RE: [PATCH v2] raw/ntb: add PPD status check for SPR

2022-07-01 Thread Wu, Jingjing
> -Original Message- > From: Guo, Junfeng > Sent: Thursday, June 30, 2022 4:56 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Guo, Junfeng > Subject: [PATCH v2] raw/ntb: add PPD status check for SPR > > Add PPD (PCIe Port Definition) status check for SPR (Sapphire Rapids). > > Note that

RE: [PATCH] app/testpmd: fix secondary process cannot dump packet

2022-07-01 Thread Zhang, Yuying
Hi, > -Original Message- > From: Zhang, Peng1X > Sent: Friday, June 24, 2022 2:15 AM > To: dev@dpdk.org > Cc: Singh, Aman Deep ; Zhang, Yuying > ; Zhang, Peng1X ; > sta...@dpdk.org > Subject: [PATCH] app/testpmd: fix secondary process cannot dump packet > > From: Peng Zhang > > The ori

[PATCH 17/17] net/mana: add function to report queue stats

2022-07-01 Thread longli
From: Long Li Report packet statistics. Signed-off-by: Long Li --- doc/guides/nics/features/mana.ini | 2 + drivers/net/mana/mana.c | 77 +++ 2 files changed, 79 insertions(+) diff --git a/doc/guides/nics/features/mana.ini b/doc/guides/nics/features/man

[PATCH 16/17] net/mana: add function to start/stop device

2022-07-01 Thread longli
From: Long Li Add support for starting/stopping the device. Signed-off-by: Long Li --- drivers/net/mana/mana.c | 70 + 1 file changed, 70 insertions(+) diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c index 0ffa2882e0..b919d86500 100644 --

[PATCH 15/17] net/mana: add function to send packets

2022-07-01 Thread longli
From: Long Li With all the TX queues created, MANA can send packets over those queues. Signed-off-by: Long Li --- doc/guides/nics/features/mana.ini | 1 + drivers/net/mana/mana.c | 1 + drivers/net/mana/mana.h | 65 drivers/net/mana/mp.c | 1 + d

[PATCH 14/17] net/mana: add function to receive packets

2022-07-01 Thread longli
From: Long Li With all the RX queues created, MANA can use those queues to receive packets. Signed-off-by: Long Li --- doc/guides/nics/features/mana.ini | 2 + drivers/net/mana/mana.c | 2 + drivers/net/mana/mana.h | 37 +++ drivers/net/mana/mp.c |

[PATCH 13/17] net/mana: add function to start/stop RX queues

2022-07-01 Thread longli
From: Long Li MANA allocates device queues through the IB layer when starting RX queues. When device is stopped all the queues are unmapped and freed. Signed-off-by: Long Li --- drivers/net/mana/mana.h | 5 + drivers/net/mana/meson.build | 1 + drivers/net/mana/rx.c| 369 +

[PATCH 12/17] net/mana: add function to start/stop TX queues

2022-07-01 Thread longli
From: Long Li MANA allocate device queues through the IB layer when starting TX queues. When device is stopped all the queues are unmapped and freed. Signed-off-by: Long Li --- doc/guides/nics/features/mana.ini | 1 + drivers/net/mana/mana.h | 4 + drivers/net/mana/meson.build

[PATCH 11/17] net/mana: implement the hardware layer operations

2022-07-01 Thread longli
From: Long Li The hardware layer of MANA understands the device queue and doorbell formats. Those functions are implemented for use by packet RX/TX code. Signed-off-by: Long Li --- drivers/net/mana/gdma.c | 309 +++ drivers/net/mana/mana.h | 183 ++

[PATCH 10/17] net/mana: implement memory registration

2022-07-01 Thread longli
From: Long Li MANA hardware has iommu built-in, that provides hardware safe access to user memory through memory registration. Since memory registration is an expensive operation, this patch implements a two level memory registartion cache mechanisum for each queue and for each port. Signed-off-

[PATCH 09/17] net/mana: add function to configure TX queues

2022-07-01 Thread longli
From: Long Li TX hardware queue is allocated when starting the queue, this is for pre configuration. Signed-off-by: Long Li --- drivers/net/mana/mana.c | 65 + 1 file changed, 65 insertions(+) diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana

[PATCH 08/17] net/mana: add function to configure RX queues

2022-07-01 Thread longli
From: Long Li RX hardware queue is allocated when starting the queue. This function is for queue configuration pre starting. Signed-off-by: Long Li --- drivers/net/mana/mana.c | 68 + 1 file changed, 68 insertions(+) diff --git a/drivers/net/mana/mana.c

[PATCH 07/17] net/mana: add function to configure RSS

2022-07-01 Thread longli
From: Long Li Currently this PMD supports RSS configuration when the device is stopped. Configuring RSS in running state will be supported in the future. Signed-off-by: Long Li --- doc/guides/nics/features/mana.ini | 1 + drivers/net/mana/mana.c | 61 +++

[PATCH 06/17] net/mana: add device info

2022-07-01 Thread longli
From: Long Li Add the function to get device info. Signed-off-by: Long Li --- doc/guides/nics/features/mana.ini | 1 + drivers/net/mana/mana.c | 82 +++ 2 files changed, 83 insertions(+) diff --git a/doc/guides/nics/features/mana.ini b/doc/guides/nics/f

[PATCH 05/17] net/mana: add function for device removal interrupts

2022-07-01 Thread longli
From: Long Li MANA supports PCI hot plug events. Add this interrupt to DPDK core so its parent PMD can detect device removal during Azure servicing or live migration. Signed-off-by: Long Li --- doc/guides/nics/features/mana.ini | 1 + drivers/net/mana/mana.c | 97 +++

[PATCH 04/17] net/mana: add link update

2022-07-01 Thread longli
From: Long Li The carrier state is managed by the Azure host. MANA runs as a VF and always reports UP. Signed-off-by: Long Li --- doc/guides/nics/features/mana.ini | 1 + drivers/net/mana/mana.c | 17 + 2 files changed, 18 insertions(+) diff --git a/doc/guides/nics/

[PATCH 03/17] net/mana: add function to report support ptypes

2022-07-01 Thread longli
From: Long Li Report supported protocol types. Signed-off-by: Long Li --- drivers/net/mana/mana.c | 16 drivers/net/mana/mana.h | 2 -- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c index 882a38d7df..77796ce4

[PATCH 02/17] net/mana: add device configuration and stop

2022-07-01 Thread longli
From: Long Li MANA defines its memory allocation functions to override IB layer default functions to allocate device queues. This patch adds the code for device configuration and stop. Signed-off-by: Long Li --- drivers/net/mana/mana.c | 87 - drivers/ne

[PATCH 01/17] net/mana: add basic driver, build environment and doc

2022-07-01 Thread longli
From: Long Li MANA is a PCI device. It uses IB verbs to access hardware through the kernel RDMA layer. This patch introduces build environment and basic device probe functions. Signed-off-by: Long Li --- MAINTAINERS | 6 + doc/guides/nics/features/mana.ini | 10 + doc/

[PATCH 00/17] Introduce Microsoft Azure Network Adatper (MANA) PMD

2022-07-01 Thread longli
From: Long Li MANA is a network interface card to be used in the Azure cloud environment. MANA provides safe access to user memory through memory registration. It has IOMMU built into the hardware. MANA uses IB verbs and RDMA layer to configure hardware resources. It requires the corresponding R

[PATCH] crypto/qat: fix secure session check

2022-07-01 Thread Rebecca Troy
Currently when running the dpdk-perf-test with docsis security sessions, a segmentation fault occurs. This is due to the check being made that the session is not equal to op->sym->sec_session. This check passes the first time but on the second iteration fails and doesn't create the build_request.

Re: [PATCH] doc: announce some raw/ifpga API removal

2022-07-01 Thread David Marchand
On Fri, Jul 1, 2022 at 10:32 AM Huang, Wei wrote: > > > > > > 2. Get pci_dev by specified PCI address, and remove it > > > > > > TAILQ_FOREACH(pci_dev, &pci_bus->device_list, next) { > > > > > > if (!rte_pci_addr_cmp(&pci_dev->addr, &addr)) > > > > > > return pci_dev; >

Re: [PATCH] vdpa/mlx5: fix leak on event thread creation

2022-07-01 Thread Maxime Coquelin
On 7/1/22 10:30, David Marchand wrote: On Mon, Jun 20, 2022 at 3:11 PM David Marchand wrote: As stated in the manual, pthread_attr_init return value should be checked. Besides, a pthread_attr_t should be destroyed once unused. In practice, we may have no leak (from what I read in glibc cur

RE: [PATCH] doc: announce some raw/ifpga API removal

2022-07-01 Thread Huang, Wei
> -Original Message- > From: David Marchand > Sent: Friday, July 1, 2022 16:15 > To: Huang, Wei > Cc: Xu, Rosen ; Zhang, Tianfei ; > dev@dpdk.org; Ray Kinsella > Subject: Re: [PATCH] doc: announce some raw/ifpga API removal > > On Fri, Jul 1, 2022 at 10:09 AM David Marchand > wrote:

Re: [PATCH] vdpa/mlx5: fix leak on event thread creation

2022-07-01 Thread David Marchand
On Mon, Jun 20, 2022 at 3:11 PM David Marchand wrote: > > As stated in the manual, pthread_attr_init return value should be > checked. > Besides, a pthread_attr_t should be destroyed once unused. > > In practice, we may have no leak (from what I read in glibc current code), > but this may change i

Re: [PATCH] doc: add deprecation notice for kni example

2022-07-01 Thread David Marchand
On Thu, Jun 30, 2022 at 6:50 PM Bruce Richardson wrote: > > As agreed by DPDK Technical Board, the KNI example app is due to be > removed from the repository to discourage use in future projects, given > that better alternatives exist. > > Signed-off-by: Bruce Richardson Acked-by: David Marchand

Re: [PATCH] doc: announce some raw/ifpga API removal

2022-07-01 Thread David Marchand
On Fri, Jul 1, 2022 at 10:09 AM David Marchand wrote: > > > > 2. Get pci_dev by specified PCI address, and remove it > > > > TAILQ_FOREACH(pci_dev, &pci_bus->device_list, next) { > > > > if (!rte_pci_addr_cmp(&pci_dev->addr, &addr)) > > > > return pci_dev; > > > > }

  1   2   >