On 7/5/22 07:43, Hemant Agrawal wrote:
Acked-by: Hemant Agrawal
On 7/4/2022 7:59 PM, Kevin Laatz wrote:
On 30/06/2022 10:41, David Marchand wrote:
rte_bus is unnecessarily exposed in the public API/ABI.
Besides, we had cases where extending rte_bus was necessary.
Announce that rte_bus will b
From: Satheesh Paul
Changed log level from info to debug for a log message
printed during MCAM allocation.
Fixes: 1f66919817ee ("common/cnxk: improve MCAM entries management")
Cc: sta...@dpdk.org
Signed-off-by: Satheesh Paul
Reviewed-by: Kiran Kumar Kokkilagadda
---
drivers/common/cnxk/roc_n
Hi Dmitry,
> alloc_sz = RTE_ALIGN_CEIL(RTE_ALIGN_CEIL(elt_size, align) +
> MALLOC_ELEM_OVERHEAD, pg_sz);
>
I am submitting a patch regarding this
> 2. Alignment calculation depends on whether we allocated new pages or not:
>
> malloc_heap_alloc_on_heap_id(align = 0) ->
> heap_allo
Acked-by: Hemant Agrawal
On 7/4/2022 7:59 PM, Kevin Laatz wrote:
On 30/06/2022 10:41, David Marchand wrote:
rte_bus is unnecessarily exposed in the public API/ABI.
Besides, we had cases where extending rte_bus was necessary.
Announce that rte_bus will be made opaque in the public API and mark
> -Original Message-
> From: Kevin Liu
> Sent: Tuesday, July 5, 2022 6:42 PM
> To: dev@dpdk.org
> Cc: Xing, Beilei ; Zhang, Yuying
> ; Liu, KevinX
> Subject: [PATCH] doc: fix missing title underline
>
> Title underline too short. Fill title underline.
>
> Fixes: ae97b8b89826 ("net/i4
Title underline too short. Fill title underline.
Fixes: ae97b8b89826 ("net/i40e: fix error disable double VLAN")
Signed-off-by: Kevin Liu
---
doc/guides/nics/i40e.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst
index 0f8
> -Original Message-
> From: Hunt, David
> Sent: Monday, July 4, 2022 8:32 PM
> To: Khan, Hamza ; Carew, Alan
> ; De Lara Guarch, Pablo
>
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [PATCH 2/2] examples/vm_power_manager: use safe version of
> list iterator
>
>
> On 01/06/2022 11:
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Monday, 4 July 2022 18.33
>
> On Sun, 3 Jul 2022 20:38:21 +0100
> Konstantin Ananyev wrote:
>
> > >
> > > The base/existing design for DPDK was done with one particular HW
> architecture in mind where there was an abundance of
30/06/2022 12:38, Kai Ji:
> EVP_PKEY function need to be called twice for rsa sign and verify
> operations. This patch also remove the OPENSSL_API_COMPAT as all
> the deprecated APIs are avoid if 3.0 lib is present.
I prefer not pulling this patch for now because it is not clear.
1/ What is fixed
> Subject: RE: [PATCH v3] examples/fips_validation: fix memory leak in sha test
>
> > Subject: [PATCH v3] examples/fips_validation: fix memory leak in sha test
> >
> > There is wrong size used for allocation of digest buffer which in
> > some cases cause memory corruption. Also, fixed places where
On Sun, 3 Jul 2022 07:56:18 +
Long Li wrote:
> > Subject: Re: [PATCH 01/17] net/mana: add basic driver, build environment and
> > doc
> >
> > On Fri, 1 Jul 2022 02:02:31 -0700
> > lon...@linuxonhyperv.com wrote:
> >
> > > + uint64_t max_mr_size;
> > > + rte_rwlock_tmr_list_lock;
> >
On Sun, 3 Jul 2022 07:56:18 +
Long Li wrote:
> > Subject: Re: [PATCH 01/17] net/mana: add basic driver, build environment and
> > doc
> >
> > On Fri, 1 Jul 2022 02:02:31 -0700
> > lon...@linuxonhyperv.com wrote:
> >
> > > + uint64_t max_mr_size;
> > > + rte_rwlock_tmr_list_lock;
> >
On Sun, 3 Jul 2022 20:38:21 +0100
Konstantin Ananyev wrote:
> >
> > The base/existing design for DPDK was done with one particular HW
> > architecture in mind where there was an abundance of resources.
> > Unfortunately, that HW architecture is fast evolving and DPDK is adopted in
> > use cas
Hi,
> -Original Message-
> From: Gregory Etelson
> Sent: Monday, July 4, 2022 1:12 PM
> To: dev@dpdk.org
> Cc: Gregory Etelson ; Matan Azrad
> ; Raslan Darawsheh ; Raja
> Zidane ; sta...@dpdk.org; Slava Ovsiienko
>
> Subject: [PATCH v4] net/mlx5: reject negative integrity item configurat
Hi,
> -Original Message-
> From: Dmitry Kozlyuk
> Sent: Thursday, June 30, 2022 1:08 AM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh ; sta...@dpdk.org; Matan
> Azrad ; Slava Ovsiienko
> Subject: [PATCH v2] common/mlx5: fix non-expandable global MR cache
>
> The number of memory regions (MR
On Sun, Jul 3, 2022 at 1:05 AM Timothy McDaniel
wrote:
>
> This commit updates the dlb2.rst eventdev guide to document the
> new DLB2 features that were added to dpdk 22.07.
> 1) CQ Weight
> 2) Port COS
> 3) Maximum CQ depth
> 4) Maximum enqueue depth
>
> Signed-off-by: Timothy McDaniel
Update
On Sat, Jul 2, 2022 at 9:53 PM Timothy McDaniel
wrote:
>
> Fix cos initialization, handling the default case too.
>
> Substitute the semicolon for the comma
> that was expected in the cos_bw command line override.
> Commas are not allowed within a multifield option.
> The new format is cos_bw=%d:%
On Thu, Jun 23, 2022 at 8:29 PM Jayatheerthan, Jay
wrote:
>
> Looks good to me.
>
> Acked-by: Jay Jayatheerthan
Applied to dpdk-next-net-eventdev/for-main. Thanks
>
> -Jay
>
>
>
> > -Original Message-
> > From: Naga Harish K, S V
> > Sent: Thursday, June 23, 2022 3:35 PM
> > To: Jayat
On Mon, Jul 04, 2022 at 04:27:49PM +0100, Kevin Laatz wrote:
> ASAN reports a memory leak for the 'pci' pointer in the 'idxd_dmadev'
> struct.
>
> This is fixed by free'ing the struct when the last queue on the PCI
> device is being closed.
>
> Fixes: 9449330a8458 ("dma/idxd: create dmadev instan
The 'info' struct was being declared as a NULL pointer. If a NULL
pointer is passed to 'rte_dma_info_get', EINVAL is returned and the
struct is not populated. This subsequently causes a segfault when
dereferencing 'info'.
This patch fixes the issue by simply declaring 'info' on the stack and
passi
During PCI device close, any allocated memory needs to be free'd.
Currently, one of the free's is being called on an incorrect idxd_dmadev
struct member, namely 'batch_idx_ring'.
At device creation, memory is allocated for both 'batch_comp_ring' and
'batch_idx_ring' simultaeneously. Calling free o
ASAN reports a memory leak for the 'pci' pointer in the 'idxd_dmadev'
struct.
This is fixed by free'ing the struct when the last queue on the PCI
device is being closed.
Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe")
Cc: sta...@dpdk.org
Cc: bruce.richard...@intel.com
Repo
This patchset addresses the device close for IDXD PCI devices.
Initially, there was a memory leak reported by ASAN for the 'pci' member
of the 'idxd_dmadev' struct due to a missing free. In addition, this
patch set corrects the behaviour of the device close function to ensure
the cleanup is complet
23/06/2022 11:38, Rahul Bhansali:
> +#ifndef _PORT_GROUP_H_
> +#define _PORT_GROUP_H_
No need of underscores at begin and end.
> +
> +#include "pkt_group.h"
> +
> +/*
> + * Group consecutive packets with the same destination port in bursts of 4.
> + * Suppose we have array of destination ports:
>
> -Original Message-
> From: Ashwin Sekhar T K
> Sent: Thursday, June 30, 2022 4:41 PM
> To: dev@dpdk.org; Zhang, Roy Fan ; De Lara Guarch,
> Pablo
> Cc: jer...@marvell.com; sk...@marvell.com; skotesh...@marvell.com;
> pbhagavat...@marvell.com; kirankum...@marvell.com;
> psathe...@marvell
On 30/06/2022 10:41, David Marchand wrote:
rte_bus is unnecessarily exposed in the public API/ABI.
Besides, we had cases where extending rte_bus was necessary.
Announce that rte_bus will be made opaque in the public API and mark
associated API as internal.
Signed-off-by: David Marchand
---
A RF
From: Dmitry Kozlyuk
> Sent: Thursday, June 30, 2022 1:08 AM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh ; sta...@dpdk.org; Matan
> Azrad ; Slava Ovsiienko
> Subject: [PATCH v2] common/mlx5: fix non-expandable global MR cache
>
> The number of memory regions (MR) that MLX5 PMD can use was limite
04/07/2022 14:49, Rahul Bhansali:
> From: Thomas Monjalon
> > 23/06/2022 11:38, Rahul Bhansali:
> > > This will make the packet grouping function common, so that other
> > > examples can utilize as per need.
> > >
> > > For each architecture sse/neon/altivec, port group headers will be
> > > creat
On Sun, Jul 03, 2022 at 09:31:01AM +0200, Morten Brørup wrote:
> > From: Shijith Thotton [mailto:sthot...@marvell.com]
> > Sent: Friday, 1 July 2022 14.25
> >
> > >> If all devices are configured to run in IOVA mode as VA, physical
> > >> address field of mbuf (buf_iova) won't be used.
>
> Will s
On Mon, Jul 04, 2022 at 02:34:31PM +0100, Kevin Laatz wrote:
> On 04/07/2022 14:19, Bruce Richardson wrote:
> > On Sun, Jul 03, 2022 at 01:22:41PM +0100, Kevin Laatz wrote:
> > > ASAN reports a memory leak for the 'pci' pointer in the 'idxd_dmadev'
> > > struct.
> > >
> > > This is fixed by free'i
On 04/07/2022 14:19, Bruce Richardson wrote:
On Sun, Jul 03, 2022 at 01:22:41PM +0100, Kevin Laatz wrote:
ASAN reports a memory leak for the 'pci' pointer in the 'idxd_dmadev'
struct.
This is fixed by free'ing the struct when the last queue on the PCI
device is being closed.
Fixes: 9449330a845
On Mon, Jul 04, 2022 at 02:23:38PM +0100, Bruce Richardson wrote:
> On Sun, Jul 03, 2022 at 01:22:42PM +0100, Kevin Laatz wrote:
> > During PCI device close, any allocated memory needs to be free'd.
> > Currently, one of the free's is being called on an incorrect idxd_dmadev
> > struct member, name
On Sun, Jul 03, 2022 at 01:22:43PM +0100, Kevin Laatz wrote:
> The 'info' struct was being declared as a NULL pointer. If a NULL
> pointer is passed to 'rte_dma_info_get', EINVAL is returned and the
> struct is not populated. This subsequently causes a segfault when
> dereferencing 'info'.
>
> Thi
On Sun, Jul 03, 2022 at 01:22:42PM +0100, Kevin Laatz wrote:
> During PCI device close, any allocated memory needs to be free'd.
> Currently, one of the free's is being called on an incorrect idxd_dmadev
> struct member, namely 'batch_idx_ring', causing a memleak from the
> pointer that should have
On Sun, Jul 03, 2022 at 01:22:41PM +0100, Kevin Laatz wrote:
> ASAN reports a memory leak for the 'pci' pointer in the 'idxd_dmadev'
> struct.
>
> This is fixed by free'ing the struct when the last queue on the PCI
> device is being closed.
>
> Fixes: 9449330a8458 ("dma/idxd: create dmadev instan
On Fri, Jul 1, 2022 at 6:21 PM Rakesh Kudurumalla
wrote:
>
> This fix replaces the usage of roc_nix_num_xstats_get()
> which is compile time api with runtime api
> roc_nix_xstats_names_get() resolving xstat count
> difference for cn9k and cn10k while displaying xstats
> for dpdk ports
>
> Fixes: 8
On Fri, Jun 24, 2022 at 5:02 PM Nithin Dabilpuram
wrote:
>
> Add list of environment variables used by cnxk drivers.
>
> Signed-off-by: Nithin Dabilpuram
Applied to dpdk-next-net-mrvl/for-next-net. Thanks
> ---
> doc/guides/platform/cnxk.rst | 15 +++
> 1 file changed, 15 inserti
On Thu, Jun 23, 2022 at 9:14 AM wrote:
>
> From: Satheesh Paul
>
> After parsing GRE tunnel, parse subsequent protocols
> (for example, TCP or UDP) as tunneled versions.
>
> Fixes: c34ea71b878 ("common/cnxk: add NPC parsing API")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Satheesh Paul
> Reviewed-
Hi,
> -Original Message-
> From: Thomas Monjalon
> Sent: Monday, July 4, 2022 3:10 AM
> To: Rahul Bhansali
> Cc: dev@dpdk.org; David Christensen ; Ruifeng Wang
> ; Bruce Richardson ;
> Konstantin Ananyev ; Jerin Jacob
> Kollanukkaran ; Akhil Goyal ;
> david.march...@redhat.com
> Subject:
On 01/06/2022 11:54, Hamza Khan wrote:
Currently, when vm_power_manager exits, we are using a LIST_FOREACH
macro to iterate over VM info structures while freeing them. This
leads to use-after-free error. To address this, use the newly added
LIST_FOREACH_SAFE macro.
Fixes: e8ae9b662506 ("exampl
Does anyone here remember why the __rte_ring_enqueue/dequeue_elems_64/128()
functions support unaligned object arrays, when the
__rte_ring_enqueue/dequeue_elems_32() functions require 4 byte aligned object
arrays?
I'm wondering if the compiler could do better with a simpler implementation
than
https://bugs.dpdk.org/show_bug.cgi?id=1034
Vladimir (vladimir.medved...@intel.com) changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
Resolu
> Subject: [PATCH v3] examples/fips_validation: fix memory leak in sha test
>
> There is wrong size used for allocation of digest buffer which in
> some cases cause memory corruption. Also, fixed places where memory
> leak is observed. This fix would enable sha 384 and 512 NIST vectors
> be suppor
From: Raja Zidane
Negative integrity item refers to condition when the item value mask
is set, but value spec is cleared:
... integrity value mask l4_ok value spec 0 ...
RTE library defines integrity bits `l3_ok` and `l4_ok` as accumulators
for all hardware L3 and L4 integrity verifications
> -Original Message-
> From: Jiang, YuX
> Sent: Thursday, June 30, 2022 4:32 PM
> To: Thomas Monjalon ; dev (dev@dpdk.org)
>
> Cc: Devlin, Michelle ; Mcnamara, John
> ; Qi Z Zhang (qi.z.zh...@intel.com)
>
> Subject: RE: release candidate 22.07-rc2
>
> > -Original Message-
> > Fr
There is wrong size used for allocation of digest buffer which in
some cases cause memory corruption. Also, fixed places where memory
leak is observed. This fix would enable sha 384 and 512 NIST vectors
be supported fully.
Signed-off-by: Gowrishankar Muthukrishnan
---
v3:
- addes fixes for sugge
Added changes to enable CMAN (RED or PIE) at init
from profile configuration file.
By default CMAN code is enable but not in use, when
there is no RED or PIE profile configured.
Signed-off-by: Marcin Danilewicz
---
Log: v2 change in rte_sched.h to avoid ABI breakage.
v3 changes from comment
On 6/30/2022 6:20 PM, Gregory Etelson wrote:
Fix GTP PSP extension size initialization.
Clear input buffer.
cc: sta...@dpdk.org
Fixes: c65282c9aa31 ("app/testpmd: fix GTP PSC raw processing")
Signed-off-by: Gregory Etelson
Acked-by: Aman Singh
---
On 7/4/22 09:04, Yuan Wang wrote:
The callfds[] array stores eventfds sequentially for Rx and Tx vq.
Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle")
Cc: sta...@dpdk.org
Signed-off-by: Yuan Wang
---
drivers/net/virtio/virtio_user/virtio_user_dev.c | 2 +-
1 file
04/07/2022 09:50, Akhil Goyal:
> > On Sat, Jul 2, 2022 at 4:59 PM Gowrishankar Muthukrishnan
> > wrote:
> > >
> > > There is wrong size used for allocation of digest buffer which in
> > > some cases cause memory corruption. Also, fixed places where memory
> > > leak is observed. This fix would ena
Upon creation of a flow, testpmd assigns it a flow ID. Later, the flow
ID is used for flow operations (query, destroy, dump).
The testpmd application allows to manage flow rules with its IDs.
The flow ID is known only when the flow is created.
In order to prepare a complete sequence of testpmd com
> vec.cipher_auth.digest.len * 8);
> > + if (vec.cipher_auth.digest.val)
> > + free(vec.cipher_auth.digest.val);
>
> Unneeded if().
>
Ack.
> We just did a tree-wide cleanup to avoid these.
> Please don't reintroduce some.
>
>
> > +
> > +
Hi Gaoxiang,
Please reply in plain text next time.
> From: Gaoxiang Liu
> Sent: Saturday, July 2, 2022 11:00 AM
> To: Xia, Chenbo
> Cc: maxime.coque...@redhat.com; dev@dpdk.org; liugaoxi...@huawei.com;
> sta...@dpdk.org
> Subject: Re: [PATCH v2] vhost: fix avail idx update error when desc cop
> On Sat, Jul 2, 2022 at 4:59 PM Gowrishankar Muthukrishnan
> wrote:
> >
> > There is wrong size used for allocation of digest buffer which in
> > some cases cause memory corruption. Also, fixed places where memory
> > leak is observed. This fix would enable sha 384 and 512 NIST vectors
> > be sup
On Sat, Jul 2, 2022 at 4:59 PM Gowrishankar Muthukrishnan
wrote:
>
> There is wrong size used for allocation of digest buffer which in
> some cases cause memory corruption. Also, fixed places where memory
> leak is observed. This fix would enable sha 384 and 512 NIST vectors
> be supported fully.
On Mon, Jul 4, 2022 at 9:11 AM Yuan Wang wrote:
>
> The callfds[] array stores eventfds sequentially for Rx and Tx vq.
>
> Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Yuan Wang
Good catch...
This is what I had fixed in 848e9
The callfds[] array stores eventfds sequentially for Rx and Tx vq.
Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle")
Cc: sta...@dpdk.org
Signed-off-by: Yuan Wang
---
drivers/net/virtio/virtio_user/virtio_user_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
> Subject: [PATCH v2] examples/fips_validation: fix memory leak in sha test
>
> There is wrong size used for allocation of digest buffer which in
> some cases cause memory corruption. Also, fixed places where memory
> leak is observed. This fix would enable sha 384 and 512 NIST vectors
> be suppor
58 matches
Mail list logo
