Re: [EXT] Re: [PATCH 1/2] doc: add enqueue depth for new event type

2022-07-15 Thread Mattias Rönnblom
On 2022-07-14 16:44, Pavan Nikhilesh Bhagavatula wrote: > > >> -Original Message- >> From: Mattias Rönnblom >> Sent: Thursday, July 14, 2022 4:24 PM >> To: Van Haaren, Harry ; Pavan Nikhilesh >> Bhagavatula ; Thomas Monjalon >> >> Cc: Jerin Jacob Kollanukkaran ; Ray Kinsella >> ; dev@dp

RE: [EXT] Re: [PATCH 1/2] doc: add enqueue depth for new event type

2022-07-15 Thread Van Haaren, Harry
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Thursday, July 14, 2022 7:01 PM > To: Van Haaren, Harry ; mattias.ronnblom > ; Thomas Monjalon > Cc: Jerin Jacob Kollanukkaran ; Ray Kinsella > ; > dev@dpdk.org; McDaniel, Timothy ; Hemant > Agrawal ; sachin.sax...@oss.nxp.

Re: [EXT] Re: [PATCH 1/2] doc: add enqueue depth for new event type

2022-07-15 Thread Mattias Rönnblom
On 2022-07-14 18:42, Pavan Nikhilesh Bhagavatula wrote: > > >> -Original Message- >> From: Mattias Rönnblom >> Sent: Thursday, July 14, 2022 4:13 PM >> To: Pavan Nikhilesh Bhagavatula ; Thomas >> Monjalon >> Cc: Jerin Jacob Kollanukkaran ; Ray Kinsella >> ; dev@dpdk.org; timothy.mcdan..

RE: release candidate 22.07-rc4

2022-07-15 Thread Jiang, YuX
> -Original Message- > From: Jiang, YuX > Sent: Thursday, July 14, 2022 4:18 PM > To: Xia, Chenbo ; Thomas Monjalon > ; dev (dev@dpdk.org) ; Maxime > Coquelin > Cc: Devlin, Michelle ; Mcnamara, John > ; Ferruh Yigit > Subject: RE: release candidate 22.07-rc4 > > > -Original Message-

Re:Re: [PATCH v2] ip_frag: add IPv4 fragment copy packet API

2022-07-15 Thread Huichao Cai
Hi Konstantin, I've been busy lately, sorry to reply to you late. > Instead of implicitly assuming that output mbufs will be allocated > from pkt_in pool, it would be better to have output_pool as explicit > parameter for that function. > In a same way we have it for rte_ipv4_fragment_

Re: [EXT] Re: [PATCH 1/2] doc: add enqueue depth for new event type

2022-07-15 Thread Mattias Rönnblom
On 2022-07-14 18:57, Van Haaren, Harry wrote: >> -Original Message- >> From: Van Haaren, Harry >> Sent: Thursday, July 14, 2022 5:54 PM >> To: Pavan Nikhilesh Bhagavatula ; mattias.ronnblom >> ; Thomas Monjalon >> Cc: Jerin Jacob Kollanukkaran ; Ray Kinsella >> ; >> dev@dpdk.org; McDaniel

RE: [PATCH] doc: announce header split deprecation

2022-07-15 Thread Ding, Xuan
Hi, > -Original Message- > From: Slava Ovsiienko > Sent: Friday, July 15, 2022 12:56 AM > To: Ferruh Yigit ; Ding, Xuan > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; andrew.rybche...@oktetlabs.ru > Cc: m...@ashroe.eu; dev@dpdk.org; step...@networkplumber.org; > m...@smartsharesystems.com

RE: [PATCH] doc: announce header split deprecation

2022-07-15 Thread Ding, Xuan
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Friday, July 15, 2022 12:03 AM > To: Ding, Xuan ; Thomas Monjalon > ; andrew.rybche...@oktetlabs.ru; Viacheslav > Ovsiienko > Cc: m...@ashroe.eu; dev@dpdk.org; step...@networkplumber.org; > m...@smartsharesystems.com; Zhang, Qi

[PATCH v4] net/i40e: fix the issue caused by PF and VF release order

2022-07-15 Thread Ke Zhang
A segmentation fault occurs when testpmd exit. This is due to fetching the device name from PF, PF is freed firstly and then VF representor is called later. This commit fixes the bug by fetching the device name from VF representor not PF. Fixes: e391a7b7f815 ("net/i40e: fix multi-process shared

Re: DPDK 19.11.3 with multi processes and external physical memory: unable to receive traffic in the secondary processes

2022-07-15 Thread Burakov, Anatoly
On 14-Jul-22 11:41 AM, Asaf Sinai wrote: As calling rte_mem_virt2iova() returns RTE_BAD_IOVA, tried to supply the correct matching physical addresses in iova_addrs[], but it did not help either: secondary processes still get null data in rte_mempool_lookup(). How does secondary process get inf

Re: [PATCH] doc: announce header split deprecation

2022-07-15 Thread Ferruh Yigit
On 7/15/2022 9:28 AM, Ding, Xuan wrote: Hi, -Original Message- From: Slava Ovsiienko Sent: Friday, July 15, 2022 12:56 AM To: Ferruh Yigit ; Ding, Xuan ; NBU-Contact-Thomas Monjalon (EXTERNAL) ; andrew.rybche...@oktetlabs.ru Cc: m...@ashroe.eu; dev@dpdk.org; step...@networkplumber.org;

RE: [EXT] Re: [PATCH] build: enable static analyzer

2022-07-15 Thread Amit Prakash Shukla
Thanks Bruce for the review. Please find my comments in-line. > -Original Message- > From: Bruce Richardson > Sent: Thursday, July 14, 2022 4:31 PM > To: Amit Prakash Shukla > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > tho...@monjalon.net; david.march...@redhat.com; > dmitry.kozl...

Re: [PATCH] doc: announce header split deprecation

2022-07-15 Thread Andrew Rybchenko
On 7/14/22 16:25, Thomas Monjalon wrote: 14/07/2022 14:54, Ding, Xuan: Hi, From: Thomas Monjalon 14/07/2022 07:50, Ding, Xuan: From: Thomas Monjalon 23/05/2022 16:20, xuan.d...@intel.com: From: Xuan Ding RTE_ETH_RX_OFFLOAD_HEADER_SPLIT offload was introduced some time ago to substitu

RE: [PATCH] doc: announce header split deprecation

2022-07-15 Thread Ding, Xuan
> -Original Message- > From: Ferruh Yigit > Sent: Friday, July 15, 2022 7:34 PM > To: Ding, Xuan ; Slava Ovsiienko > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; andrew.rybche...@oktetlabs.ru > Cc: m...@ashroe.eu; dev@dpdk.org; step...@networkplumber.org; > m...@smartsharesystems.com; Zh

RE: [PATCH] doc: announce header split deprecation

2022-07-15 Thread Ding, Xuan
Hi, > -Original Message- > From: Andrew Rybchenko > Sent: Friday, July 15, 2022 8:14 PM > To: Thomas Monjalon ; Ding, Xuan > ; ferruh.yi...@xilinx.com > Cc: m...@ashroe.eu; dev@dpdk.org; step...@networkplumber.org; > m...@smartsharesystems.com; Zhang, Qi Z ; > asek...@marvell.com; pbhagav

RE: [EXT] Re: [PATCH 1/2] doc: add enqueue depth for new event type

2022-07-15 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Van Haaren, Harry > Sent: Friday, July 15, 2022 1:20 PM > To: Pavan Nikhilesh Bhagavatula ; > mattias.ronnblom ; Thomas Monjalon > > Cc: Jerin Jacob Kollanukkaran ; Ray Kinsella > ; dev@dpdk.org; McDaniel, Timothy > ; Hemant Agrawal > ; sachin.sax...@oss.nxp

[PATCH v1 1/2] eal: add lcore busyness telemetry

2022-07-15 Thread Anatoly Burakov
Currently, there is no way to measure lcore busyness in a passive way, without any modifications to the application. This patch adds a new EAL API that will be able to passively track core busyness. The busyness is calculated by relying on the fact that most DPDK API's will poll for packets. Empty

[PATCH v1 2/2] eal: add cpuset lcore telemetry entries

2022-07-15 Thread Anatoly Burakov
Expose per-lcore cpuset information to telemetry. Signed-off-by: Anatoly Burakov --- lib/eal/common/eal_common_lcore_telemetry.c | 47 + 1 file changed, 47 insertions(+) diff --git a/lib/eal/common/eal_common_lcore_telemetry.c b/lib/eal/common/eal_common_lcore_telemetry.c i

[20.11 PATCH v1 1/2] eal: add lcore busyness telemetry

2022-07-15 Thread Anatoly Burakov
Currently, there is no way to measure lcore busyness in a passive way, without any modifications to the application. This patch adds a new EAL API that will be able to passively track core busyness. The busyness is calculated by relying on the fact that most DPDK API's will poll for packets. Empty

[20.11 PATCH v1 2/2] eal: add cpuset lcore telemetry entries

2022-07-15 Thread Anatoly Burakov
Expose per-lcore cpuset information to telemetry. Signed-off-by: Anatoly Burakov --- .../common/eal_common_lcore_telemetry.c | 47 +++ 1 file changed, 47 insertions(+) diff --git a/lib/librte_eal/common/eal_common_lcore_telemetry.c b/lib/librte_eal/common/eal_common_lcore

Re: [20.11 PATCH v1 1/2] eal: add lcore busyness telemetry

2022-07-15 Thread Burakov, Anatoly
On 15-Jul-22 2:12 PM, Anatoly Burakov wrote: Currently, there is no way to measure lcore busyness in a passive way, without any modifications to the application. This patch adds a new EAL API that will be able to passively track core busyness. The busyness is calculated by relying on the fact th

RE: [EXT] Re: [PATCH 1/2] doc: add enqueue depth for new event type

2022-07-15 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Mattias Rönnblom > Sent: Friday, July 15, 2022 1:26 PM > To: Pavan Nikhilesh Bhagavatula ; Thomas > Monjalon > Cc: Jerin Jacob Kollanukkaran ; Ray Kinsella > ; dev@dpdk.org; timothy.mcdan...@intel.com; Hemant > Agrawal ; sachin.sax...@oss.nxp.com; > lian...@

[PATCH v3] doc: announce changes to rte_eth_set_queue_rate_limit API

2022-07-15 Thread skoteshwar
From: Satha Rao rte_eth_set_queue_rate_limit argument rate modified to uint32_t to support more than 64Gbps. Signed-off-by: Satha Rao Acked-by: Jerin Jacob --- v2: Modified rate to uint32_t as per review comments v3: api in subject line changed to API --- doc/guides/rel_notes/deprecation.r

Re: [PATCH v1] doc: update release notes for 22.07

2022-07-15 Thread Thomas Monjalon
14/07/2022 18:19, John McNamara: > Fix grammar, spelling and formatting of DPDK 22.07 release notes. > > Signed-off-by: John McNamara > --- > > Note, I haven't removed the empty sections or the boilerplate text. I've removed the boilerplate. > * **Updated HiSilicon hns3 driver.** > > + Upd

Re: [PATCH v1 1/2] eal: add lcore busyness telemetry

2022-07-15 Thread Burakov, Anatoly
On 15-Jul-22 2:12 PM, Anatoly Burakov wrote: Currently, there is no way to measure lcore busyness in a passive way, without any modifications to the application. This patch adds a new EAL API that will be able to passively track core busyness. The busyness is calculated by relying on the fact th

Re: [PATCH v1 1/2] eal: add lcore busyness telemetry

2022-07-15 Thread Jerin Jacob
On Fri, Jul 15, 2022 at 6:42 PM Anatoly Burakov wrote: > > Currently, there is no way to measure lcore busyness in a passive way, > without any modifications to the application. This patch adds a new EAL > API that will be able to passively track core busyness. > > The busyness is calculated by re

Re: [PATCH v1 1/2] eal: add lcore busyness telemetry

2022-07-15 Thread Bruce Richardson
On Fri, Jul 15, 2022 at 07:16:17PM +0530, Jerin Jacob wrote: > On Fri, Jul 15, 2022 at 6:42 PM Anatoly Burakov > wrote: > > > > Currently, there is no way to measure lcore busyness in a passive way, > > without any modifications to the application. This patch adds a new EAL > > API that will be ab

Re: release candidate 22.07-rc4

2022-07-15 Thread Thinh Tran
IBM - Power Systems DPDK v22.07-rc4-1-gb3c781dbde * Basic PF on Mellanox: No new issues or regressions were seen. * Performance: not tested. * OS: RHEL 8.5 kernel: 4.18.0-372.9.1.el8.ppc64le with gcc version 8.5.0 20210514 (Red Hat 8.5.0-10) RHEL 9.0 kernel: 5.14.0-70.13.1.el9_0.

Re: [PATCH v1 1/2] eal: add lcore busyness telemetry

2022-07-15 Thread Burakov, Anatoly
On 15-Jul-22 2:46 PM, Jerin Jacob wrote: On Fri, Jul 15, 2022 at 6:42 PM Anatoly Burakov wrote: Currently, there is no way to measure lcore busyness in a passive way, without any modifications to the application. This patch adds a new EAL API that will be able to passively track core busyness.

Re: [PATCH v3] doc: announce changes to rte_eth_set_queue_rate_limit API

2022-07-15 Thread Andrew Rybchenko
On 7/15/22 16:25, skotesh...@marvell.com wrote: From: Satha Rao rte_eth_set_queue_rate_limit argument rate modified to uint32_t to support more than 64Gbps. Signed-off-by: Satha Rao Acked-by: Jerin Jacob --- v2: Modified rate to uint32_t as per review comments v3: api in subject line change

[PATCH v11] sched: enable CMAN at runtime

2022-07-15 Thread Marcin Danilewicz
Added changes to enable CMAN (RED or PIE) at init from profile configuration file. By default CMAN code is enable but not in use, when there is no RED or PIE profile configured. Signed-off-by: Marcin Danilewicz --- Log: v2 change in rte_sched.h to avoid ABI breakage. v3 changes from comment

Re: [PATCH v4] doc: announce KNI deprecation

2022-07-15 Thread Thomas Monjalon
14/07/2022 17:03, Ferruh Yigit: > On 7/14/2022 3:50 PM, Ferruh Yigit wrote: > > On 7/14/2022 10:20 AM, Bruce Richardson wrote: > >> On Wed, Jul 13, 2022 at 06:10:47PM +0200, Thomas Monjalon wrote: > >>> From: Ferruh Yigit > >>> > >>> Announce the deprecation plan for KNI kernel module, library and

Re: [PATCH v4] doc: announce KNI deprecation

2022-07-15 Thread Thomas Monjalon
13/07/2022 21:51, Thomas Monjalon: > 13/07/2022 18:10, Thomas Monjalon: > > From: Ferruh Yigit > > > > Announce the deprecation plan for KNI kernel module, library and example. > > > > Signed-off-by: Ferruh Yigit > > Signed-off-by: Thomas Monjalon > > --- > > Squashed and updated 2 deprecation

[Bug 1050] Burst packet receive from Mellanox gives "Segmentation fault" on CQE decompression

2022-07-15 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1050 Omer (omer.ya...@ceng.metu.edu.tr) changed: What|Removed |Added Resolution|--- |INVALID Status|U

[Bug 1053] ConnectX6 / mlx5 DPDK - bad RSS/ rte_flow performance on mixed traffic ( rxq_cqe_comp_en=4 )

2022-07-15 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1053 Bug ID: 1053 Summary: ConnectX6 / mlx5 DPDK - bad RSS/ rte_flow performance on mixed traffic ( rxq_cqe_comp_en=4 ) Product: DPDK Version: 21.11 Hardware: x86 OS: L

Re: [PATCH] doc: announce behavior change for device NUMA node field

2022-07-15 Thread Thomas Monjalon
13/07/2022 17:50, Olivier Matz: > The dev->device.numa_node field is set by the bus driver for each device > it manages to indicate on which NUMA node this device lies. > > When this information is unknown, the assigned value is not consistent > across the bus drivers. In v22.11, the value will be

Re: [PATCH] doc: announce marking bus object as internal

2022-07-15 Thread Thomas Monjalon
30/06/2022 11:41, David Marchand: > rte_bus is unnecessarily exposed in the public API/ABI. > Besides, we had cases where extending rte_bus was necessary. > Announce that rte_bus will be made opaque in the public API and mark > associated API as internal. > > Signed-off-by: David Marchand Ac

Re: [PATCH] doc: announce marking device and driver objects as internal

2022-07-15 Thread Thomas Monjalon
10/07/2022 08:17, David Marchand: > rte_driver and rte_device are unnecessarily exposed in the public API/ABI. > Announce that they will be made opaque in the public API and mark > associated API as internal. > This impacts all bus, as their driver registration mechanism will be > made internal. >

Re: config files profile.cfg in examples/qos_sched

2022-07-15 Thread Thomas Monjalon
+Cc maintainers of this part Do not hesitate to submit a patch to fix the issue you found. 12/07/2022 10:22, Theo MARGUERET: > Hello , > I worked on the qos_sched application and I think, there may be an error in > the config file. > It seems that the allocation of the pipe profile mapping :

Re: [PATCH v3] doc: announce changes to rte_eth_set_queue_rate_limit API

2022-07-15 Thread Ajit Khaparde
On Fri, Jul 15, 2022 at 7:23 AM Andrew Rybchenko wrote: > > On 7/15/22 16:25, skotesh...@marvell.com wrote: > > From: Satha Rao > > > > rte_eth_set_queue_rate_limit argument rate modified to uint32_t > > to support more than 64Gbps. > > > > Signed-off-by: Satha Rao > > Acked-by: Jerin Jacob > >

Re: [PATCH v3] doc: add deprecation for restrictions in telemetry naming

2022-07-15 Thread Thomas Monjalon
12/07/2022 11:09, Bruce Richardson: > Following discussion on-list [1], we will look to limited the allowed > characters in names for items in telemetry. This will simplify the > escaping needed for json output, or any future output formats. The lists > will initially be minimal, since expansion to

[PATCH v2] doc: announce header split deprecation

2022-07-15 Thread xuan . ding
From: Xuan Ding RTE_ETH_RX_OFFLOAD_HEADER_SPLIT offload was introduced some time ago to substitute bit-field header_split in struct rte_eth_rxmode. It allows to enable per-port header split offload with the header size controlled using split_hdr_size in the same structure. Right now, no single P

RE: [RFC PATCH v1] net/i40e: put mempool cache out of API

2022-07-15 Thread Honnappa Nagarahalli
> >> > >> > >>> Refer to "i40e_tx_free_bufs_avx512", this patch puts mempool cache > >>> out of API to free buffers directly. There are two changes different > >>> with previous version: > >>> 1. change txep from "i40e_entry" to "i40e_vec_entry" > >>> 2. put cache out of "mempool_bulk" API to copy

RE: [RFC PATCH v1] net/i40e: put mempool cache out of API

2022-07-15 Thread Honnappa Nagarahalli
> >> > >> > >>> Refer to "i40e_tx_free_bufs_avx512", this patch puts mempool cache > >>> out of API to free buffers directly. There are two changes different > >>> with previous version: > >>> 1. change txep from "i40e_entry" to "i40e_vec_entry" > >>> 2. put cache out of "mempool_bulk" API to copy

RE: [PATCH v1 1/2] eal: add lcore busyness telemetry

2022-07-15 Thread Morten Brørup
> From: Anatoly Burakov [mailto:anatoly.bura...@intel.com] > Sent: Friday, 15 July 2022 15.13 > > Currently, there is no way to measure lcore busyness in a passive way, > without any modifications to the application. This patch adds a new EAL > API that will be able to passively track core busynes