Re: [PATCH v3] ip_frag: add IPv4 fragment copy packet API

2022-07-22 Thread Konstantin Ananyev
22/07/2022 17:14, Morten Brørup пишет: From: Huichao Cai [mailto:chcch...@163.com] Sent: Friday, 22 July 2022 17.59 At 2022-07-22 23:52:28, "Morten Brørup" wrote: From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Friday, 22 July 2022 16.49 On Fri, 22 Jul 2022 21:01:50 +0800 H

[PATCH 11/11] cxgbe: replace 'or or' in comment

2022-07-22 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- drivers/net/cxgbe/sge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cxgbe/sge.c b/drivers/net/cxgbe/sge.c index 5d91355c9ab1..1a767dabf59c 100644 --- a/drivers/net/cxgbe/sge.c +++ b/drivers/net/cxgbe/sge.c @@ -65,7 +65,7 @@

[PATCH 10/11] ethdev: fix repeated word in comment

2022-07-22 Thread Stephen Hemminger
Replace 'of of' Signed-off-by: Stephen Hemminger --- lib/ethdev/rte_ethdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index de9e970d4d11..701eac328fe6 100644 --- a/lib/ethdev/rte_ethdev.h +++ b/lib/ethdev/rte_ethdev.h @

[PATCH 09/11] distrubutor: fix repeated word in comment

2022-07-22 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- lib/distributor/rte_distributor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/distributor/rte_distributor.c b/lib/distributor/rte_distributor.c index 3035b7a99925..967e27d35a49 100644 --- a/lib/distributor/rte_distributor.c +++ b/l

[PATCH 08/11] bnx2x, pcap: replace only only

2022-07-22 Thread Stephen Hemminger
Duplicate word in comments. Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x.c | 2 +- drivers/net/pcap/pcap_ethdev.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index 74e3018eab6f..29c16bb207c7 100

[PATCH 07/11] i40e,igc: fix duplicate word than

2022-07-22 Thread Stephen Hemminger
Another obvious typo. Signed-off-by: Stephen Hemminger --- drivers/net/i40e/i40e_fdir.c | 2 +- drivers/net/igc/base/igc_mac.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c index 8caedea14eaa..3b7714217405 100

[PATCH 06/11] ring: fix repeated word in comment

2022-07-22 Thread Stephen Hemminger
Replace this this. Signed-off-by: Stephen Hemminger --- lib/ring/rte_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ring/rte_ring.c b/lib/ring/rte_ring.c index cddaf6b2876f..a42767b75d9c 100644 --- a/lib/ring/rte_ring.c +++ b/lib/ring/rte_ring.c @@ -280,7 +280,7 @

[PATCH 05/11] fix repeated words 'in in'

2022-07-22 Thread Stephen Hemminger
Multiple files are incorrectly using 'in in' Signed-off-by: Stephen Hemminger --- drivers/common/sfc_efx/base/efx_types.h | 2 +- drivers/event/sw/sw_evdev.c | 2 +- drivers/net/hns3/hns3_ethdev.c | 2 +- drivers/net/mlx5/mlx5_flow.c| 2 +- drivers/net/sfc/sfc_ef

[PATCH 04/11] Remove repeated word 'on on'

2022-07-22 Thread Stephen Hemminger
Found in a couple of places. Signed-off-by: Stephen Hemminger --- drivers/net/bonding/rte_eth_bond_8023ad.h | 2 +- examples/vm_power_manager/channel_monitor.h | 2 +- examples/vm_power_manager/oob_monitor.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net

[PATCH 03/11] mvnet,mvpp2: remove duplicate word

2022-07-22 Thread Stephen Hemminger
The word 'same' is duplicated in comment. Signed-off-by: Stephen Hemminger --- drivers/net/mvneta/mvneta_ethdev.c | 2 +- drivers/net/mvpp2/mrvl_ethdev.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/net/mvneta/mvneta_ethd

[PATCH 02/11] remove duplicate words 'is is'

2022-07-22 Thread Stephen Hemminger
Found by scanning for duplicate words. Signed-off-by: Stephen Hemminger --- drivers/common/sfc_efx/base/efx_regs_mcdi.h | 2 +- lib/net/rte_ether.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/sfc_efx/base/efx_regs_mcdi.h b/driver

[PATCH 01/11] remove duplicated 'to to' in messages and comments

2022-07-22 Thread Stephen Hemminger
Found by doing duplicate word scan. Signed-off-by: Stephen Hemminger --- app/test/test_resource.c | 2 +- drivers/common/sfc_efx/base/siena_nvram.c | 2 +- lib/pipeline/rte_swx_ctl.c| 2 +- lib/power/guest_channel.c | 2 +- 4 files changed, 4 inse

[PATCH 00/11] Fix repeated words in comments and messages

2022-07-22 Thread Stephen Hemminger
Reading netdev, noticed lots of places in Linux kernel with bad comments being fixed. Use similar kind of scanning to look for repeated words in DPDK. Stephen Hemminger (11): remove duplicated 'to to' in messages and comments remove duplicate words 'is is' mvnet,mvpp2: remove duplicate word

Re: [PATCH v1 00/10] baseband/acc200

2022-07-22 Thread Tom Rix
Hernan The changes I requested in v4, were not addressed in v5. Can you make these changes for v6? Tom On 7/22/22 11:29 AM, Vargas, Hernan wrote: Hi Tom, The patch series for the ACC200 can wait until Nic's back. Our priority are the changes for the bbdev API here: https://patches.dpdk.org/

RE: [PATCH v1 00/10] baseband/acc200

2022-07-22 Thread Vargas, Hernan
Hi Tom, The patch series for the ACC200 can wait until Nic's back. Our priority are the changes for the bbdev API here: https://patches.dpdk.org/project/dpdk/list/?series=23912 Thanks, Hernan -Original Message- From: Tom Rix Sent: Sunday, July 17, 2022 8:08 AM To: Vargas, Hernan ; Max

RE: RE: [PATCH v3] ip_frag: add IPv4 fragment copy packet API

2022-07-22 Thread Morten Brørup
From: Huichao Cai [mailto:chcch...@163.com] Sent: Friday, 22 July 2022 17.59 > At 2022-07-22 23:52:28, "Morten Brørup" wrote: > >> From: Stephen Hemminger [mailto:step...@networkplumber.org] > >> Sent: Friday, 22 July 2022 16.49 > >> > >> On Fri, 22 Jul 2022 21:01:50 +0800 > >> Huichao Cai wro

Re:RE: [PATCH v3] ip_frag: add IPv4 fragment copy packet API

2022-07-22 Thread Huichao Cai
At 2022-07-22 23:52:28, "Morten Brørup" wrote: >> From: Stephen Hemminger [mailto:step...@networkplumber.org] >> Sent: Friday, 22 July 2022 16.49 >> >> On Fri, 22 Jul 2022 21:01:50 +0800 >> Huichao Cai wrote: >> >> > Some NIC drivers support MBUF_FAST_FREE(Device supports opt

RE: [PATCH v3] ip_frag: add IPv4 fragment copy packet API

2022-07-22 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, 22 July 2022 16.49 > > On Fri, 22 Jul 2022 21:01:50 +0800 > Huichao Cai wrote: > > > Some NIC drivers support MBUF_FAST_FREE(Device supports optimization > > for fast release of mbufs. When set application must guarant

Re: RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE requirements

2022-07-22 Thread Olivier Matz
Hi Morten, Yes, you are right. These 2 conditions are also needed if one wants to use rte_mbuf_raw_free() or rte_mempool_put*() functions to free the mbufs. Olivier On Thu, Jul 14, 2022 at 12:46:24PM +0200, Morten Brørup wrote: > Looking at rte_pktmbuf_prefree_seg() [1], the list of described re

Re: [PATCH 1/2] vhost: keep a reference to virtqueue index

2022-07-22 Thread David Marchand
On Fri, Jul 22, 2022 at 3:54 PM David Marchand wrote: > @@ -607,32 +594,20 @@ init_vring_queue(struct virtio_net *dev, uint32_t > vring_idx) > #endif > vq->numa_node = numa_node; > > - vhost_user_iotlb_init(dev, vring_idx); > + vhost_user_iotlb_init(dev, vq); Erm, it won't f

[Bug 1057] Unable to use flow rules on VF

2022-07-22 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1057 Bug ID: 1057 Summary: Unable to use flow rules on VF Product: DPDK Version: 21.11 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority:

[PATCH v4] ip_frag: add IPv4 fragment copy packet API

2022-07-22 Thread Huichao Cai
Some NIC drivers support MBUF_FAST_FREE(Device supports optimization for fast release of mbufs. When set application must guarantee that per-queue all mbufs comes from the same mempool and has refcnt = 1) offload. In order to adapt to this offload function, add this API. Add some test data for this

Re: [PATCH v3] ip_frag: add IPv4 fragment copy packet API

2022-07-22 Thread Stephen Hemminger
On Fri, 22 Jul 2022 21:01:50 +0800 Huichao Cai wrote: > Some NIC drivers support MBUF_FAST_FREE(Device supports optimization > for fast release of mbufs. When set application must guarantee that > per-queue all mbufs comes from the same mempool and has refcnt = 1) > offload. In order to adapt to

RE: [PATCH v3] ip_frag: add IPv4 fragment copy packet API

2022-07-22 Thread Morten Brørup
> From: Huichao Cai [mailto:chcch...@163.com] > Sent: Friday, 22 July 2022 15.02 > To: dev@dpdk.org > Cc: konstantin.v.anan...@yandex.ru > Subject: [PATCH v3] ip_frag: add IPv4 fragment copy packet API > > Some NIC drivers support MBUF_FAST_FREE(Device supports optimization > for fast release of m

Re: [PATCH 1/2] vhost: keep a reference to virtqueue index

2022-07-22 Thread David Marchand
On Fri, Jul 22, 2022 at 3:54 PM David Marchand wrote: > > Having a back reference to the index of the vq in the dev->virtqueue[] > array makes it possible to unify the internal API with only passing dev > and vq. > It also allows displaying the vq index in log messages. Fwiw, this conflicts with

[PATCH 1/2] vhost: keep a reference to virtqueue index

2022-07-22 Thread David Marchand
Having a back reference to the index of the vq in the dev->virtqueue[] array makes it possible to unify the internal API with only passing dev and vq. It also allows displaying the vq index in log messages. Remove virtqueue index checks were unneeded (like in static helpers called from a loop on a

[PATCH 2/2] vhost: stop using mempool for IOTLB

2022-07-22 Thread David Marchand
A mempool consumes 3 memzones (with the default ring mempool driver). Default DPDK configuration allows RTE_MAX_MEMZONE (2560) memzones. Assuming there is no other memzones (well, there is always other memzones in a DPDK application), that means that we can have a maximum of 853 mempools. The IOT

[PATCH v3] ip_frag: add IPv4 fragment copy packet API

2022-07-22 Thread Huichao Cai
Some NIC drivers support MBUF_FAST_FREE(Device supports optimization for fast release of mbufs. When set application must guarantee that per-queue all mbufs comes from the same mempool and has refcnt = 1) offload. In order to adapt to this offload function, add this API. Add some test data for this

RE: [RFC v2] non-temporal memcpy

2022-07-22 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.v.anan...@yandex.ru] > Sent: Friday, 22 July 2022 01.20 > > Hi Morten, > > > This RFC proposes a set of functions optimized for non-temporal > memory copy. > > > > At this stage, I am asking for feedback on the concept. > > > > Applications sometimes

Re: [PATCH 0/6] app/procinfo: add some extended features

2022-07-22 Thread David Marchand
On Fri, Jul 22, 2022 at 11:13 AM Dongdong Liu wrote: > > [PATCH 1/6 2/6 3/6] support ethdev info about firmware version, RSS reta info, > and module info, from the below link [1] that have been sent out in the > earlier, wait for review. > [PATCH 4/6] add dump of Rx/tx burst mode. > [PATCH 5/6] f

Re: rte_eth_fdir_conf deprecation to be processed in 22.11

2022-07-22 Thread Thomas Monjalon
21/07/2022 14:16, Andrew Rybchenko: > Hi all, > > we have the following deprecation waiting for more than 2 years already: > > * ethdev: The flow director API, including ``rte_eth_conf.fdir_conf`` field, >and the related structures (``rte_fdir_*`` and ``rte_eth_fdir_*``), >will be removed

[PATCH] net/iavf: fix processing vlan tci in vector path

2022-07-22 Thread zhichaox . zeng
From: Zhichao Zeng The vector RX path does not process vlan tci correctly when it's stored in L2TAG2, so that the vlan tci could not be extracted from descriptor, then would not be put into mbuf also. Add processing when vlan tci is stored in L2TAG2. Fixes: 1162f5a0ef31 ("net/iavf: support flex

[Bug 1056] [dpdk-19.11.13-rc1] unit_tests_eal/link_bonding_rssconf: link_bonding_rssconf_autotest test failed

2022-07-22 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1056 Bug ID: 1056 Summary: [dpdk-19.11.13-rc1] unit_tests_eal/link_bonding_rssconf: link_bonding_rssconf_autotest test failed Product: DPDK Version: 19.11 Hardware:

[PATCH] net/iavf: fix processing vlan tci in vector path

2022-07-22 Thread zhichaox . zeng
From: Zhichao Zeng The vector RX path does not process vlan tci correctly when it's stored in L2TAG2, so that the vlan tci could not be extracted from descriptor, then would not be put into mbuf also. Add processing when vlan tci is stored in L2TAG2. Fixes: 1162f5a0ef31 ("net/iavf: support flex

[PATCH v2] net/af_xdp: improve documentation

2022-07-22 Thread Shibin Koikkara Reeny
From: Ciara Loftus Instead of a one-liner describing each vdev argument, add a description and example for each. Move the information describing preferred busy polling from the "Limitations" section to the "Options" section where it is better placed. Also make general grammar improvements. Signe

GRO Enhancement Proposal

2022-07-22 Thread kumaraparameshwaran rathinavel
Hi Everyone, I am thinking of a few enhancements to the existing GRO library and I have listed them below, 1. The current implementation for the TCP in GRO disregards the PSH flag and delivers it immediately in the current burst. But this would lead to reordering of packets if there wer

REMINDER: DPDK Userspace submissions due July 22

2022-07-22 Thread Jill Lovato
DPDK Community, This is a reminder that the 2022 DPDK Userspace Call For Proposals closes tomorrow, July 22, at 11:59 pm PT. Please get your submissions in now if you have not already: https://linuxfoundation.smapply.io/prog/dpdk_userspace_summit_2022/ *DPDK Userspace 2022 / September 6-8 / Arc

High Level DPDK Governing Board Meeting Minutes - 7/12/22

2022-07-22 Thread Nathan Southern
Dear DPDK Community, Our governing board endeavors to keep the community updated on our activities. In recent months we've admittedly done an inadequate job of this, and would like to rectify this moving forward. The following is a high-level summary of the minutes from our last Governing Board Me