Re: 19.11.13 patches review and test

2022-08-18 Thread YangHang Liu
Hi Christian, The dpdk 19.11.13-rc3 test result from Red Hat looks good. We tested below 17 scenarios and all got PASS on RHEL8: - Guest with device assignment(PF) throughput testing(1G hugepage size): PASS - Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS

[PATCH v2] app/testpmd: fix incorrect queues state of secondary process

2022-08-18 Thread peng1x . zhang
From: Peng Zhang Primary process could set up queues state correctly when starting port, but under multi-process scenario, "stream_init" function would get wrong queues state for secondary process. This commit is to get queues state from ethdev which is located in shared memory. Fixes: 3c4426db

RE: [PATCH v3] net/ice: refactor proto_ext to remove global variable

2022-08-18 Thread Jiang, YuX
> -Original Message- > From: Kevin Liu > Sent: 2022年8月5日 18:41 > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Yang, SteveX ; Liu, KevinX > > Subject: [PATCH v3] net/ice: refactor proto_ext to remove global variable > > The ice has the feature to extract protocol fields into flex

RE: [PATCH] net/i40e: fix single VLAN cannot work normal

2022-08-18 Thread Jiale, SongX
> -Original Message- > From: Kevin Liu > Sent: Friday, August 19, 2022 12:04 AM > To: dev@dpdk.org > Cc: Zhang, Yuying ; Xing, Beilei > ; Yang, SteveX ; Liu, KevinX > > Subject: [PATCH] net/i40e: fix single VLAN cannot work normal > > After disable QinQ, single VLAN can not work normal.

[PATCH] examples: add eventdev_producer_consumer example

2022-08-18 Thread Timothy McDaniel
The eventdev-producer-consumer application is a single-stage producer-worker-consumer pipeline sample to mimic real-world applications. It is useful in measuring performance impact when any eventdev configuration is changed. Unlike test-eventdev, it allows configuring a load balanced queue between

Re: [PATCH 1/3] eventdev: add element offset to event vector

2022-08-18 Thread Mattias Rönnblom
On 2022-08-16 17:49, pbhagavat...@marvell.com wrote: From: Pavan Nikhilesh Add ``elem_offset:12`` bit field event vector structure the bits are taken from ``rsvd:15``. The element offset defines the offset into the vector array at which valid elements start. The valid elements count will be equ

RE: 19.11.13 patches review and test

2022-08-18 Thread Ali Alnubani
> -Original Message- > From: christian.ehrha...@canonical.com > > Sent: Thursday, August 4, 2022 11:22 AM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Ali Alnubani ; benjamin.wal...@intel.com; David > Christensen ; Hemant Agrawal > ; Ian Stokes ; Jerin > Jacob ; John McNa

[Bug 1068] [20.11] creating a rule with a shared action after port restart causes a segfault

2022-08-18 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1068 Dmitry Kozlyuk (dkozl...@nvidia.com) changed: What|Removed |Added Resolution|--- |WONTFIX Status

[Bug 1068] [20.11] creating a rule with a shared action after port restart causes a segfault

2022-08-18 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1068 Bug ID: 1068 Summary: [20.11] creating a rule with a shared action after port restart causes a segfault Product: DPDK Version: 20.11 Hardware: All OS: All

Re: [PATCH] app/proc-info: add rte_eal_cleanup() to avoid memory leak

2022-08-18 Thread Stephen Hemminger
On Thu, 18 Aug 2022 16:37:42 +0500 Fidaullah Noonari wrote: > when app is launched with -m proc-info exit without > rte_eal_cleanup() causing memory leakage. This commit resolves the > memory leakage issue and closes app properly. > > Bugzilla id: 898 > > Signed-off-by: Fidaullah Noonari > ---

RE: [PATCH v4 4/4] test/event: update periodic event timer tests

2022-08-18 Thread Carrillo, Erik G
> -Original Message- > From: Naga Harish K, S V > Sent: Friday, August 12, 2022 11:07 AM > To: Carrillo, Erik G ; jer...@marvell.com > Cc: pbhagavat...@marvell.com; sthot...@marvell.com; dev@dpdk.org > Subject: [PATCH v4 4/4] test/event: update periodic event timer tests > > This patch up

RE: [PATCH v4 3/4] timer: fix function to stop all timers

2022-08-18 Thread Carrillo, Erik G
> -Original Message- > From: Naga Harish K, S V > Sent: Friday, August 12, 2022 11:08 AM > To: Carrillo, Erik G > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH v4 3/4] timer: fix function to stop all timers > > There is a possibility of deadlock in this API, as same spinlock is tri

RE: [PATCH v4 1/4] eventdev/timer: add periodic event timer support

2022-08-18 Thread Carrillo, Erik G
> -Original Message- > From: Naga Harish K, S V > Sent: Friday, August 12, 2022 11:07 AM > To: Carrillo, Erik G ; jer...@marvell.com > Cc: pbhagavat...@marvell.com; sthot...@marvell.com; dev@dpdk.org > Subject: [PATCH v4 1/4] eventdev/timer: add periodic event timer support > > This patch

[PATCH] mlx5: initially reading xstats does not cause seg fault

2022-08-18 Thread huzaifa.rahman
Bugzilla ID: 296 the size of counters array in mlx5_xstats_get() was smaller than the memory we are setting for this array in mlx5_os_read_dev_counters(). due to which the extra memory is corrupted and thus corrupting the seemingly unrelated variables. this happens at the first run only because th

Re: [PATCH] ethdev: rte_eth_rx_queue_count is a dataplane function

2022-08-18 Thread Ferruh Yigit
On 8/18/2022 10:37 AM, Morten Brørup wrote: Applications may use rte_eth_rx_queue_count() in the RX stage of the dataplane, so only check the function parameters if built with RTE_ETHDEV_DEBUG_RX. Signed-off-by: Morten Brørup I don't remember if those checks done by default intentionally, but

[PATCH 6/6] pipeline: configure the hash function for learner tables

2022-08-18 Thread Cristian Dumitrescu
Make the hash function configurable for the learner pipeline tables. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R. --- lib/pipeline/rte_swx_pipeline.c | 12 lib/pipeline/rte_swx_pipeline.h | 6 lib/pipeline/rte_swx_pipeline_internal.h | 1 +

[PATCH 5/6] table: configure the hash function for learner tables

2022-08-18 Thread Cristian Dumitrescu
Make the hash function configurable. The internal hash function that was not configurable, mask-based and limited to 64 bytes is removed. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R. --- lib/table/rte_swx_table_learner.c | 220 -- lib/table/rte_s

[PATCH 4/6] pipeline: configure the hash function for regular tables

2022-08-18 Thread Cristian Dumitrescu
Make the hash function configurable for the regular pipeline tables. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R. --- lib/pipeline/rte_swx_ctl.c | 1 + lib/pipeline/rte_swx_ctl.h | 3 ++ lib/pipeline/rte_swx_pipeline.c | 10 +++ li

[PATCH 2/6] table: add key comparison functions

2022-08-18 Thread Cristian Dumitrescu
Add key comparison functions to be used by the exact match and the learner table types as part of the performance critical lookup operation. Since the key size is fixed, it is possible to select a specialized memory copy function as opposed to using the variable size version, resulting in a perform

[PATCH 1/6] table: add hash function prototype

2022-08-18 Thread Cristian Dumitrescu
Add hash function prototype to be used by the exact match and the learner table types. The hash function is not mask-based, so the table key fields have to be contiguous in memory. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R. --- lib/table/meson.build | 1 + lib/ta

[PATCH 3/6] table: configure the hash function for regular tables

2022-08-18 Thread Cristian Dumitrescu
Make the hash function configurable. The internal hash function that was not configurable, mask-based and limited to 64 bytes is removed. Signed-off-by: Cristian Dumitrescu Signed-off-by: Kamalakannan R. --- lib/table/rte_swx_table.h| 8 ++ lib/table/rte_swx_table_em.c | 266 ++---

[PATCH 0/6] pipeline: make the hash function configurable per table

2022-08-18 Thread Cristian Dumitrescu
The exact match and learner tables use a hash function for the lookup operation. This patch set makes the hash function configurable and removes some limitations. The hash function previously used by these table types had the following limitations: a) Not configurable: An internally hardcoded vers

[PATCH] app/proc-info: add rte_eal_cleanup() to avoid memory leak

2022-08-18 Thread Fidaullah Noonari
when app is launched with -m proc-info exit without rte_eal_cleanup() causing memory leakage. This commit resolves the memory leakage issue and closes app properly. Bugzilla id: 898 Signed-off-by: Fidaullah Noonari --- app/proc-info/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/

RE: [PATCH] net/mlx5: fix condition to avoid Tx failure

2022-08-18 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Slava Ovsiienko > Sent: Wednesday, August 17, 2022 5:15 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Dmitry Kozlyuk ; Raja Zidane > ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix condition to avoid Tx failure > > From: Raja Zidane >

RE: [PATCH] net/mlx5: fix the inline length exceeding descriptor limit

2022-08-18 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Slava Ovsiienko > Sent: Wednesday, August 17, 2022 5:14 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Dmitry Kozlyuk ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix the inline length exceeding descriptor limit > > The hardware descri

DPDK Release Status Meeting 2022-08-18

2022-08-18 Thread Mcnamara, John
Release status meeting minutes 2022-08-18 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * ARM * Canonical [No] * Debian/Microsoft [No] * Intel * Marvell * Nvidia * Red Hat [No] * Xilinx/AMD [No] Release Dates --

Re: [PATCH] ethtool: remove a redundant call to rte_eth_dev_stop()

2022-08-18 Thread Usman Tanveer
Hi, Can you please have a look and update the status? On Wed, Jul 6, 2022 at 2:49 PM Usman Tanveer wrote: > > It has been there since the file was added (2015). I'm not able to > find any purpose for this. > > Although, it's misleading the messages it shows upon calling > rte_ethtool_net_open()

[PATCH] ethdev: rte_eth_rx_queue_count is a dataplane function

2022-08-18 Thread Morten Brørup
Applications may use rte_eth_rx_queue_count() in the RX stage of the dataplane, so only check the function parameters if built with RTE_ETHDEV_DEBUG_RX. Signed-off-by: Morten Brørup --- lib/ethdev/rte_ethdev.h | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/li

RE: [PATCH] sched: Fix subport profile id not set correctly.

2022-08-18 Thread Singh, Jasvinder
> -Original Message- > From: Ajmera, Megha > Sent: Thursday, August 18, 2022 7:03 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Subject: [PATCH] sched: Fix subport profile id not set correctly. > > In rte_sched_subport_config() API, subport_profile_id is not set c

RE: [PATCH 0/1] Add security perf application

2022-08-18 Thread Akhil Goyal
Hi Anoob, > Subject: [PATCH 0/1] Add security perf application > > Add performance application to test security session create & destroy > rates supported by the security enabled cryptodev PMD. The > application would create specified number of sessions and captures the > time taken for the same b

RE: [PATCH v2 4/5] app/test: update L2 header based on tunnel IP version

2022-08-18 Thread Akhil Goyal
> Subject: [PATCH v2 4/5] app/test: update L2 header based on tunnel IP version > > Update L2 header based on tunnel IP version. > > Signed-off-by: Nithin Dabilpuram Description need to be reworded. It is not clear why the change is done. Apart from that Acked-by: Akhil Goyal

[PATCH 2/2] cryptodev: add ec point verification

2022-08-18 Thread Arek Kusztal
This addition complements point verification in ECDH operation. This will allow to use point verification in other situations than pure ECDH. Signed-off-by: Arek Kusztal --- doc/guides/cryptodevs/features/default.ini | 1 + lib/cryptodev/rte_crypto_asym.h| 11 +++ 2 files ch

[PATCH 1/2] cryptodev: add option to use ec base point in ecpm

2022-08-18 Thread Arek Kusztal
Add option to use elliptic curve generator point instead of setting it manually. It corresponds to the public point generation in EC Diffie-Hellman key exchange. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[PATCH 0/2] cryptodev: extend elliptic curves operations

2022-08-18 Thread Arek Kusztal
This pathset adds two new capabilities in asym cryptodev: 1) Base point instead of manual point can be used with point multiplication too. 2) Point verify can be used without ECDH, now it will be possible to use point verification for other ec operations. Arek Kusztal (2): cryptodev: add option

[PATCH v2] app/testpmd: fix incorrect queues state of secondary process

2022-08-18 Thread peng1x . zhang
From: Peng Zhang Primary process could set up queues state correctly when starting port, but under multi-process scenario, "stream_init" function would get wrong queues state for secondary process. This commit is to get queues state from ethdev which is located in shared memory. Fixes: 3c4426db

RE: [PATCH v2 5/5] examples/ipsec-secgw: update ether type using tunnel info

2022-08-18 Thread Akhil Goyal
> Subject: [PATCH v2 5/5] examples/ipsec-secgw: update ether type using tunnel > info > > Update ether type for outbound SA processing based on tunnel header > information in both NEON functions for poll mode and event mode worker > functions. > > Signed-off-by: Nithin Dabilpuram > --- Acked-by:

RE: [RFC 1/2] vhost: add ingress API for port mirroring datapath

2022-08-18 Thread Morten Brørup
> From: Jiang, Cheng1 [mailto:cheng1.ji...@intel.com] > Sent: Thursday, 18 August 2022 08.58 > > Hi, > > > -Original Message- > > From: Stephen Hemminger > > Sent: Sunday, August 14, 2022 10:58 PM > > > > On Sun, 14 Aug 2022 12:49:19 + > > Cheng Jiang wrote: > > > > > From: Wenwu Ma

[PATCH] sched: Support to config 100G rate to subport/pipe

2022-08-18 Thread Megha Ajmera
Currently in hqos tc rates, tb sizes can be configured upto 25G. Signed-off-by: Megha Ajmera --- examples/qos_sched/cfg_file.c | 64 +-- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/examples/qos_sched/cfg_file.c b/examples/qos_sched/cfg_file.c i

[PATCH] net/i40e: fix single VLAN cannot work normal

2022-08-18 Thread Kevin Liu
After disable QinQ, single VLAN can not work normal. The reason is that QinQ is not disabled correctly. Before configuring QinQ, need to back up and clean MAC/VLAN filters of all ports. After configuring QinQ, restore MAC/VLAN filters of all ports. When disable QinQ, need to set valid_flags to 0x0

RE: [PATCH v2 5/5] examples/ipsec-secgw: update ether type using tunnel info

2022-08-18 Thread Ruifeng Wang
> -Original Message- > From: Nithin Dabilpuram > Sent: Thursday, August 18, 2022 3:12 AM > To: Ruifeng Wang ; Radu Nicolau > ; Akhil > Goyal > Cc: jer...@marvell.com; dev@dpdk.org; Nithin Dabilpuram > > Subject: [PATCH v2 5/5] examples/ipsec-secgw: update ether type using tunnel > inf

RE: mlx5_common failed errno=121

2022-08-18 Thread Raslan Darawsheh
Hi Panagiotis, Can you check if this will solve this issue? http://patches.dpdk.org/project/dpdk/patch/20220710160244.2934-1-getel...@nvidia.com/ Kindest regards, Raslan Darawsheh From: Panagiotis Famelis Sent: Wednesday, August 17, 2022 10:54 AM To: dev@dpdk.org Subject: mlx5_common failed err

[PATCH 2/2] test/crypto: add ecdh tests

2022-08-18 Thread Arek Kusztal
This commit adds ECDH test cases based on rfc5114. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_asym.c | 357 + app/test/test_cryptodev_ecdh_vectors.h | 144 + 2 files changed, 501 insertions(+) create mode 100644 app/test/test_cryp

[PATCH 1/2] test/crypto: add ecdsa qat test cases

2022-08-18 Thread Arek Kusztal
This commit adds ECDSA test cases to Intel QuickAssist Technology testsuite. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_asym.c | 196 + 1 file changed, 196 insertions(+) diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_as

[PATCH 0/2] test: add elliptic curve tests

2022-08-18 Thread Arek Kusztal
This patchset adds new test cases that can be used to verify elliptic curve algorithms like ECDSA, ECDH, etc. Depends-on: series-24333 ("crypto/qat: extend asymmetric crypto pmd") Arek Kusztal (2): test/crypto: add ecdsa qat test cases test/crypto: add ecdh tests app/test/test_cryptodev_asy