RE: [EXT] Re: [PATCH] crypto/ccp: Check for the NULL pointer after calling rte_malloc

2022-08-22 Thread Namburu, Chandu-babu
[Public] + sunil -Original Message- From: Akhil Goyal Sent: Tuesday, August 16, 2022 9:31 PM To: Namburu, Chandu-babu ; 835703...@qq.com Cc: dev@dpdk.org; David Marchand Subject: RE: [EXT] Re: [PATCH] crypto/ccp: Check for the NULL pointer after calling rte_malloc Hi, Could you pleas

RE: [EXT] [PATCH v3 0/3] net/octeon_ep: rename driver and add features

2022-08-22 Thread Veerasenareddy Burru
> -Original Message- > From: Sathesh Edara > Sent: Monday, August 22, 2022 2:10 AM > To: Satananda Burla ; Jerin Jacob Kollanukkaran > ; Sathesh B Edara > Cc: dev@dpdk.org > Subject: [EXT] [PATCH v3 0/3] net/octeon_ep: rename driver and add > features > > External Email > > --

[PATCH 8/8] vhost: vDPA BLK devices configure device when all queue callfds are set

2022-08-22 Thread Andy Pei
In the virtio blk vDPA live migration use case, before the live migration process, QEMU will set call fd to vDPA back-end. QEMU and vDPA back-end stand by until live migration starts. During live migration process, QEMU sets kick fd and a new call fd. However, after the kick fd is set to the vDPA b

[PATCH 7/8] vhost: configure device when any queue is ready for BLK device

2022-08-22 Thread Andy Pei
When boot from virtio blk device, seabois in QEMU only enables one queue. To work in this scenario, vDPA BLK device back-end conf_dev when any queue is ready. Signed-off-by: Andy Pei --- lib/vhost/vhost_user.c | 56 +++--- 1 file changed, 44 insertions

[PATCH 6/8] vdpa/ifc: set vring state callback update data path

2022-08-22 Thread Andy Pei
To support multi queue, in the case that first queue is ready and device is configured, when more queues need to be configured, we just close and restart data path. This also fix the situation that using set_vring_state callback to disable one queue will cause all vfio interrupts being disabled. S

[PATCH 5/8] vdpa/ifc: only configure enabled queue

2022-08-22 Thread Andy Pei
when configure the hardware queue, we only configure queues which have been enabled by vhost. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.c | 5 - drivers/vdpa/ifc/ifcvf_vdpa.c | 4 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/ifc/base/ifcvf.c b

[PATCH 4/8] vdpa/ifc: write queue count to MQ register

2022-08-22 Thread Andy Pei
Write queue count to IFCVF_MQ_OFFSET register to enable multi queue feature. Signed-off-by: Andy Pei Signed-off-by: Huang Wei --- drivers/vdpa/ifc/base/ifcvf.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.c index

[PATCH 3/8] vdpa/ifc: set max queues according to HW spec

2022-08-22 Thread Andy Pei
Set max_queues according to virtio HW spec. For virtio BLK device, set max_queues to the value of "num_queues". "num_queues" is element of struct virtio_blk_config. Signed-off-by: Andy Pei Signed-off-by: Huang Wei --- drivers/vdpa/ifc/base/ifcvf.h | 2 +- drivers/vdpa/ifc/ifcvf_vdpa.c | 18 +++

[PATCH 2/8] vdpa/ifc: add multi queue suppoort

2022-08-22 Thread Andy Pei
Enable VHOST_USER_PROTOCOL_F_MQ feature. ExposeIFCVF_MQ_OFFSET register to enable multi queue. Signed-off-by: Andy Pei Signed-off-by: Huang Wei --- drivers/vdpa/ifc/base/ifcvf.c | 5 + drivers/vdpa/ifc/base/ifcvf.h | 2 ++ drivers/vdpa/ifc/ifcvf_vdpa.c | 1 + 3 files changed, 8 insertions(+

[PATCH 1/8] vdpa/ifc: add new device ID

2022-08-22 Thread Andy Pei
From: Huang Wei Add new device id to support IFCVF_NET_TRANSITIONAL_DEVICE_ID (0x1000). Signed-off-by: Huang Wei Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.h | 4 +++- drivers/vdpa/ifc/ifcvf_vdpa.c | 9 - 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/dri

[PATCH 0/8] add multi queue support to vDPA ifc driver

2022-08-22 Thread Andy Pei
Add multi queue support to vDPA ifc driver. Multi queue support for virtio-net device and virtio-blk device. Andy Pei (7): vdpa/ifc: add multi queue suppoort vdpa/ifc: set max queues according to HW spec vdpa/ifc: write queue count to MQ register vdpa/ifc: only configure enabled queue vd

RE: [PATCH v2 1/3] ethdev: introduce pool sort capability

2022-08-22 Thread Ding, Xuan
Hi Hanumanth, > -Original Message- > From: Hanumanth Pothula > Sent: Saturday, August 13, 2022 1:25 AM > To: Thomas Monjalon ; Ferruh Yigit > ; Andrew Rybchenko > > Cc: dev@dpdk.org; Ding, Xuan ; Wu, WenxuanX > ; Li, Xiaoyun ; > step...@networkplumber.org; Wang, YuanX ; > m...@ashroe.eu;

RE: [PATCH v2] net/ice: support disabling ACL engine in DCF via devargs

2022-08-22 Thread Zhang, Qi Z
> -Original Message- > From: Zeng, ZhichaoX > Sent: Wednesday, August 17, 2022 4:21 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zeng, ZhichaoX > ; Zhang, Qi Z > Subject: [PATCH v2] net/ice: support disabling ACL engine in DCF via devargs > > From: Zhichao Zeng > > Support disabling D

[PATCH v4] examples: add eventdev_producer_consumer example

2022-08-22 Thread Timothy McDaniel
The eventdev-producer-consumer application is a single-stage producer-worker-consumer pipeline sample to mimic real-world applications. It is useful in measuring performance impact when any eventdev configuration is changed. Unlike test-eventdev, it allows configuring a load balanced queue between

[PATCH v3] examples: add eventdev_producer_consumer example

2022-08-22 Thread Timothy McDaniel
The eventdev-producer-consumer application is a single-stage producer-worker-consumer pipeline sample to mimic real-world applications. It is useful in measuring performance impact when any eventdev configuration is changed. Unlike test-eventdev, it allows configuring a load balanced queue between

[PATCH v2] examples/eventdev_producer_consumer: fix 32-bit checkpatch issues

2022-08-22 Thread Timothy McDaniel
Fixed style and format issues, primarily those involving data types whose size varies depending on whether we are building for 32 or 64 bit platforms. Signed-off-by: Timothy McDaniel --- examples/eventdev_producer_consumer/main.c | 18 +- 1 file changed, 9 insertions(+), 9 deleti

RE: [Patch v4 17/17] net/mana: add function to report queue stats

2022-08-22 Thread Long Li
> Subject: Re: [Patch v4 17/17] net/mana: add function to report queue stats > > On 7/9/2022 12:49 AM, lon...@linuxonhyperv.com wrote: > > CAUTION: This message has originated from an External Source. Please use > proper judgment and caution when opening attachments, clicking links, or > respondin

RE: [Patch v4 11/17] net/mana: implement the hardware layer operations

2022-08-22 Thread Long Li
> Subject: Re: [Patch v4 11/17] net/mana: implement the hardware layer > operations > > On 7/9/2022 12:49 AM, lon...@linuxonhyperv.com wrote: > > > > > From: Long Li > > > > The hardware layer of MANA understands the device queue and doorbell > > formats. Those functions are implemented for use

RE: [Patch v4 01/17] net/mana: add basic driver, build environment and doc

2022-08-22 Thread Long Li
> Subject: Re: [Patch v4 01/17] net/mana: add basic driver, build environment > and doc > > On 8/22/2022 4:03 PM, Ferruh Yigit wrote: > >> + struct rte_pci_device *pci_dev, > >> + struct rte_ether_addr *mac_addr) { > >> +   struct ibv_dev

RE: [Patch v4 00/17] Introduce Microsoft Azure Network Adatper (MANA) PMD

2022-08-22 Thread Long Li
> Subject: Re: [Patch v4 00/17] Introduce Microsoft Azure Network Adatper > (MANA) PMD > > On 7/9/2022 12:49 AM, lon...@linuxonhyperv.com wrote: > > > > > From: Long Li > > > > MANA is a network interface card to be used in the Azure cloud > environment. > > MANA provides safe access to user mem

Re: [PATCH] mbuf: remove deprecated offload flags

2022-08-22 Thread David Marchand
On Fri, Aug 5, 2022 at 10:03 AM Andrew Rybchenko wrote: > > Remove deprecated ``PKT_*`` flags. Use corresponding flags with > ``RTE_MBUF_F_`` prefix instead. > > Signed-off-by: Andrew Rybchenko The change lgtm. We may reference the cocci script devtools/cocci/prefix_mbuf_offload_flags.cocci in t

Re: [Patch v4 15/17] net/mana: add function to send packets

2022-08-22 Thread Ferruh Yigit
On 7/9/2022 12:49 AM, lon...@linuxonhyperv.com wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. From: Long Li With all the TX queues created, MANA can send packe

Re: [Patch v4 17/17] net/mana: add function to report queue stats

2022-08-22 Thread Ferruh Yigit
On 7/9/2022 12:49 AM, lon...@linuxonhyperv.com wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. From: Long Li Report packet statistics. Signed-off-by: Long Li

Re: [Patch v4 11/17] net/mana: implement the hardware layer operations

2022-08-22 Thread Ferruh Yigit
On 7/9/2022 12:49 AM, lon...@linuxonhyperv.com wrote: From: Long Li The hardware layer of MANA understands the device queue and doorbell formats. Those functions are implemented for use by packet RX/TX code. Signed-off-by: Long Li --- Change log: v2: Remove unused header files. Rename a cam

Re: [Patch v4 01/17] net/mana: add basic driver, build environment and doc

2022-08-22 Thread Ferruh Yigit
On 8/22/2022 4:03 PM, Ferruh Yigit wrote: + struct rte_pci_device *pci_dev, + struct rte_ether_addr *mac_addr) +{ +   struct ibv_device **ibv_list; +   int ibv_idx; +   struct ibv_context *ctx; +   struct ibv_device_attr_ex d

Re: [Patch v4 01/17] net/mana: add basic driver, build environment and doc

2022-08-22 Thread Ferruh Yigit
On 7/9/2022 12:49 AM, lon...@linuxonhyperv.com wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. From: Long Li MANA is a PCI device. It uses IB verbs to access ha

Re: [Patch v4 00/17] Introduce Microsoft Azure Network Adatper (MANA) PMD

2022-08-22 Thread Ferruh Yigit
On 7/9/2022 12:49 AM, lon...@linuxonhyperv.com wrote: From: Long Li MANA is a network interface card to be used in the Azure cloud environment. MANA provides safe access to user memory through memory registration. It has IOMMU built into the hardware. MANA uses IB verbs and RDMA layer to con

[PATCH v3 5/5] examples/ipsec-secgw: update ether type using tunnel info

2022-08-22 Thread Nithin Dabilpuram
Update ether type for outbound SA processing based on tunnel header information in both NEON functions for poll mode and event mode worker functions. Signed-off-by: Nithin Dabilpuram Reviewed-by: Ruifeng Wang Acked-by: Akhil Goyal --- examples/ipsec-secgw/ipsec_neon.h | 41 ++

[PATCH v3 4/5] app/test: update L2 header based on tunnel IP version

2022-08-22 Thread Nithin Dabilpuram
Update L2 header based on tunnel IP version in the application as driver/HW is not expected to update L2 ether type post Outbound Inline protocol offload processing. Signed-off-by: Nithin Dabilpuram Acked-by: Akhil Goyal --- app/test/test_security_inline_proto.c | 34 +++

[PATCH v3 3/5] net/cnxk: remove L2 header update for outbound inline pkts

2022-08-22 Thread Nithin Dabilpuram
Remove L2 header update for outbound inline packets as application is already taking care of the same. Signed-off-by: Nithin Dabilpuram --- drivers/net/cnxk/cn10k_tx.h | 17 - 1 file changed, 17 deletions(-) diff --git a/drivers/net/cnxk/cn10k_tx.h b/drivers/net/cnxk/cn10k_tx.h

[PATCH v3 2/5] security: clarify L2 header requirement for outbound inline

2022-08-22 Thread Nithin Dabilpuram
Clarify that for Outbound Inline IPsec processing, L2 header needs to be up to date with ether type which will be applicable post IPsec processing as the IPsec offload only touches L3 and above. Signed-off-by: Nithin Dabilpuram --- doc/guides/prog_guide/rte_security.rst | 4 +++- 1 file changed,

[PATCH v3 1/5] mbuf: clarify meta data needed for Outbound Inline

2022-08-22 Thread Nithin Dabilpuram
Clarify mbuf meta data needed for Outbound Inline processing. Application needs to provide mbuf.l3_len and L3 type in mbuf.ol_flags so that like tunnel mode using mbuf.l2_len, transport mode can make use of l3_len and l3_type to determine perform proper transport mode IPsec processing. Signed-off-

Re: [PATCH 0/3] eal: small rte_common.h fixes and cleanup

2022-08-22 Thread Bruce Richardson
On Sun, Aug 21, 2022 at 11:50:06PM +0300, Dmitry Kozlyuk wrote: > Dmitry Kozlyuk (3): > eal: fix pointer arithmetic with an expression argument > eal: uninline rte_str_to_size > eal: deduplicate roundup code > > app/test/test_common.c | 11 > lib/eal/common/eal_comm

Re: [PATCH 2/3] eal: uninline rte_str_to_size

2022-08-22 Thread Bruce Richardson
On Mon, Aug 22, 2022 at 09:24:47AM +0200, Morten Brørup wrote: > > From: Dmitry Kozlyuk [mailto:dmitry.kozl...@gmail.com] > > Sent: Sunday, 21 August 2022 22.50 > > To: dev@dpdk.org > > Cc: Dmitry Kozlyuk; Ray Kinsella > > Subject: [PATCH 2/3] eal: uninline rte_str_to_size > > > > There is no reas

Re: [PATCH v4 2/2] net/cnxk: support ops to update precolor VLAN table

2022-08-22 Thread Jerin Jacob
On Tue, Jun 21, 2022 at 1:05 PM wrote: > > From: Sunil Kumar Kori > > Implement API to update VLAN table for pre-coloring for > incoming packet per nixlf for CN10K platform. > > Signed-off-by: Sunil Kumar Kori Squashed 1/2 and 2/2 and Updated the git commit as follows and applied to dpdk-next-

[PATCH v2] examples/fips_validation: add parsing for AES CTR

2022-08-22 Thread Brian Dooley
Added functionality to parse algorithm for AES CTR test Signed-off-by: Brian Dooley --- v2: fix clang warning for int-in-bool-context --- examples/fips_validation/fips_validation.c | 2 ++ examples/fips_validation/fips_validation.h | 2 ++ examples/fips_validation/fips_validation_aes.c |

Re: [PATCH v4] examples/vm_power_manager: use safe version of list iterator

2022-08-22 Thread Hunt, David
On 22/08/2022 11:58, Reshma Pattan wrote: From: Hamza Khan Currently, when vm_power_manager exits, we are using a LIST_FOREACH macro to iterate over VM info structures while freeing them. This leads to use-after-free error. To address this, replace all usages of LIST_* with TAILQ_* macros, an

Re: Reason to alway to build both static and shared libs

2022-08-22 Thread Bruce Richardson
On Wed, Aug 03, 2022 at 10:13:24PM -0700, Jianshen Liu wrote: >Hi all, Could I know the reason for always building both static and >shared libs of DPDK? I can find the [1]patch to enable this behavior, >but it seems that it didn't mention the reason behind it. Also, if I >propose a

[PATCH v4] examples/vm_power_manager: use safe version of list iterator

2022-08-22 Thread Reshma Pattan
From: Hamza Khan Currently, when vm_power_manager exits, we are using a LIST_FOREACH macro to iterate over VM info structures while freeing them. This leads to use-after-free error. To address this, replace all usages of LIST_* with TAILQ_* macros, and use the RTE_TAILQ_FOREACH_SAFE macro to iter

[Bug 1070] [dpdk-20.11.6-rc1] unit_tests_eal/link_bonding_rssconf: link_bonding_rssconf_autotest test failed

2022-08-22 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1070 Bug ID: 1070 Summary: [dpdk-20.11.6-rc1] unit_tests_eal/link_bonding_rssconf: link_bonding_rssconf_autotest test failed Product: DPDK Version: 20.11 Hardware: A

[PATCH v3 1/3] net/octeontx_ep: rename as octeon_ep

2022-08-22 Thread Sathesh Edara
This patch renames octeon end point driver from octeontx_ep to octeon_ep to enable single unified driver to support current OcteonTx and future Octeon PCI endpoint NICs to reflect common driver for all Octeon based PCI endpoint NICs. Signed-off-by: Sathesh Edara --- MAINTAINERS

[PATCH v3 3/3] net/octeon_ep: support link status

2022-08-22 Thread Sathesh Edara
Added functionality to update link speed, duplex mode and link state. Signed-off-by: Sathesh Edara --- doc/guides/nics/features/octeon_ep.ini | 1 + drivers/net/octeon_ep/otx_ep_ethdev.c | 17 + 2 files changed, 18 insertions(+) diff --git a/doc/guides/nics/features/octeon_ep.

[PATCH v3 2/3] net/octeon_ep: support basic stats

2022-08-22 Thread Sathesh Edara
Added functionality to fetch and reset ethdev stats. Signed-off-by: Sathesh Edara --- doc/guides/nics/features/octeon_ep.ini | 1 + drivers/net/octeon_ep/otx_ep_ethdev.c | 52 ++ 2 files changed, 53 insertions(+) diff --git a/doc/guides/nics/features/octeon_ep.ini b/d

[PATCH v3 0/3] net/octeon_ep: rename driver and add features

2022-08-22 Thread Sathesh Edara
This patch set renames the net/octeontx_ep driver to net/octeon_ep and 2nd and 3rd patches add support for basic stats and link status. Changes in v3: - Updated commit messaage. - Updated deprecation.rst. Changes in v2: Added new features in the renamed driver. Sathesh Edara (3): net/octeontx

RE: [PATCH 0/2] IPsec on Arm

2022-08-22 Thread Ruifeng Wang
> -Original Message- > From: Zhang, Roy Fan > Sent: Monday, August 22, 2022 3:54 PM > To: Ruifeng Wang ; De Lara Guarch, Pablo > ; Wang, Yipeng1 ; > Gobriel, Sameh > ; Richardson, Bruce ; > Medvedkin, > Vladimir ; gak...@marvell.com > Cc: dev@dpdk.org; Honnappa Nagarahalli ; nd > > Sub

[PATCH] linux/igb_uio: make module parameters visible in sysfs

2022-08-22 Thread Shinae Woo
- explicitly set default value for intr_mode - give read permission on wc_activate - applying patch gives below visibility ``` $ more /sys/module/igb_uio/parameters/* | cat :: /sys/module/igb_uio/parameters/intr_mode :: msix :: /sys/module/igb_uio/parameters/wc_

[PATCH] sched:higher rates of pipe and subport are not taken care in application.

2022-08-22 Thread Megha Ajmera
--- examples/qos_sched/cfg_file.c | 66 +-- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/examples/qos_sched/cfg_file.c b/examples/qos_sched/cfg_file.c index 450482f07d..fe0b42b023 100644 --- a/examples/qos_sched/cfg_file.c +++ b/examples/qos_sched

[PATCH] sched:In rte_sched_subport_config() API, subport_profile_id is not set correctly.

2022-08-22 Thread Megha Ajmera
--- lib/sched/rte_sched.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index 599c7e9536..09f855a04b 100644 --- a/lib/sched/rte_sched.c +++ b/lib/sched/rte_sched.c @@ -1263,8 +1263,6 @@ rte_sched_subport_config(struct rte_sched_port *port,

[PATCH] sched:subport field is unused in hqos profile.

2022-08-22 Thread Megha Ajmera
--- examples/qos_sched/profile.cfg | 2 -- 1 file changed, 2 deletions(-) diff --git a/examples/qos_sched/profile.cfg b/examples/qos_sched/profile.cfg index d4b21c0170..8da5777538 100644 --- a/examples/qos_sched/profile.cfg +++ b/examples/qos_sched/profile.cfg @@ -26,8 +26,6 @@ number of subports

Re: [dpdk-kmods v2] windows/netuio: fix BAR parsing

2022-08-22 Thread Liu, Qiao
在 2022/8/12 6:17, Pallavi Kadam 写道: Current code was always checking the 'prev_bar & PCI_TYPE_64BIT' though only the first BAR slot of a 64-bit BAR contains flags. Also for certain PCIe devices, BAR values were not continuous. This patch fixes this incorrectness and maps the BAR addresses corre

RE: [PATCH 0/2] IPsec on Arm

2022-08-22 Thread Zhang, Roy Fan
Hi Ruifeng, We have no technical issues with these patches based on their current functionality. However, it is worth pointing out that we are planning some changes to the Intel® Multi-Buffer Crypto for IPSec library which will require API changes in the future. These changes are, but not limit

[PATCH v1] vhost: fix build

2022-08-22 Thread Min Zhou
This patch fixes the following build failure seen on CentOS 8 with gcc 12.1 because of uninitialized struct variable: [..] ../lib/vhost/virtio_net.c:1159:18: warning: 'buf_vec[0].buf_addr' may be used uninitialized [-Wmaybe-uninitialized] 1159 | buf_addr = buf_vec[vec_idx].buf_addr;

RE: [PATCH 3/3] eal: deduplicate roundup code

2022-08-22 Thread Morten Brørup
> From: Dmitry Kozlyuk [mailto:dmitry.kozl...@gmail.com] > Sent: Sunday, 21 August 2022 22.50 > > RTE_CACHE_LINE_ROUNDUP() implementation repeated RTE_ALIGN_MUL_CEIL(). > In other places RTE_CACHE_LINE_SIZE is assumed to be a power-of-2, > so define RTE_CACHE_LINE_ROUNDUP() using RTE_ALIGN_CEIL().

RE: [PATCH 2/3] eal: uninline rte_str_to_size

2022-08-22 Thread Morten Brørup
> From: Dmitry Kozlyuk [mailto:dmitry.kozl...@gmail.com] > Sent: Sunday, 21 August 2022 22.50 > To: dev@dpdk.org > Cc: Dmitry Kozlyuk; Ray Kinsella > Subject: [PATCH 2/3] eal: uninline rte_str_to_size > > There is no reason for rte_str_to_size() to be inline. > Move the implementation out of . > E

RE: [PATCH 1/3] eal: fix pointer arithmetic with an expression argument

2022-08-22 Thread Morten Brørup
> From: Dmitry Kozlyuk [mailto:dmitry.kozl...@gmail.com] > Sent: Sunday, 21 August 2022 22.50 > > RTE_PTR_SUB(ptr, x) and RTE_PTR_ALIGN_FLOOR() worked incorrectly > if "ptr" was an expression: > > uint32_t arr[3]; > > RTE_PTR_SUB(arr + 1, sizeof(arr[0])); > // expected: (uint32_t *)(