Re: [PATCH v7 0/7] Introduce support for LoongArch architecture

2022-10-03 Thread David Marchand
On Fri, Sep 30, 2022 at 10:02 AM Min Zhou wrote: > > Dear team, > > The following patch set is intended to support DPDK running on LoongArch > architecture. > > LoongArch is the general processor architecture of Loongson Corporation > and is a new RISC ISA, which is a bit like MIPS or RISC-V. > >

Re: [PATCH 3/3] ethdev: add structure for indirect AGE update

2022-10-03 Thread Andrew Rybchenko
On 10/3/22 18:13, Ori Kam wrote: Hi Andrew, -Original Message- From: Andrew Rybchenko Sent: Monday, 3 October 2022 16:18 On 10/3/22 11:30, Ori Kam wrote: Hi Andrew, -Original Message- From: Andrew Rybchenko Sent: Monday, 3 October 2022 11:04 On 9/21/22 17:54, Michael Baum

Re: [PATCH] drivers: suggestion on removing empty version.map files

2022-10-03 Thread Omer Yamac
On 03.10.2022 17:01, Bruce Richardson wrote: On Mon, Oct 03, 2022 at 04:59:18PM +0300, Omer Yamac wrote: On 03.10.2022 12:19, Bruce Richardson wrote: > On Mon, Oct 03, 2022 at 09:52:03AM +0300, Abdullah Ömer Yamaç wrote: > > In this patch, we remove all version.map files which include > > o

Re: [PATCH] net/bnxt: fix build with GCC 13

2022-10-03 Thread Ajit Khaparde
On Mon, Oct 3, 2022 at 9:58 AM David Marchand wrote: > > GCC 13 complains with: > > ../../../dpdk/drivers/net/bnxt/tf_ulp/ulp_flow_db.c:962:1: > error: conflicting types for ‘ulp_flow_db_flush_flows’ due to > enum/integer mismatch; have ‘int32_t(struct bnxt_ulp_context *, > enum bnxt_u

Re: [dpdk-dev] [PATCH 2/2] net/bnxt: fix freeing of representor info memory

2022-10-03 Thread Ajit Khaparde
On Tue, Sep 27, 2022 at 9:00 AM Kalesh A P wrote: > > From: Kalesh AP > > Driver allocates "bp->rep_info" inside bnxt_init_rep_info() which is > invoked from bnxt_rep_port_probe(). But the memory is freed inside > bnxt_uninit_resources(), which is wrong. As a result, after error > recovery bp->re

Re: [dpdk-dev] [PATCH 1/2] net/bnxt: remove unnecessary check

2022-10-03 Thread Ajit Khaparde
On Tue, Sep 27, 2022 at 9:00 AM Kalesh A P wrote: > > From: Kalesh AP > > We are not invoking rte_eth_switch_domain_free currently owing to > an unnecessary check. This patch fixes that. > > Fixes: e2895305a5b5 ("net/bnxt: fix resource cleanup") > Cc: sta...@dpdk.org > > Signed-off-by: Kalesh AP

Re: [PATCH] net/bnxt: return -EBUSY if port is active during MTU change

2022-10-03 Thread Ajit Khaparde
On Thu, Sep 15, 2022 at 4:29 AM Benjamin Le Berre wrote: > > When the BNXT PMD was made to disallow MTU changes on active ports, the > error code chosen for the case in bnxt_set_mtu_op() was -EPERM. > > The doc comment for rte_eth_dev_set_mtu() in lib/ethdev/rte_ethdev.h > lists -EBUSY as the valu

Re: [PATCH v3] net/bnxt: fix null pointer dereference in bnxt_hwrm_port_led_cfg()

2022-10-03 Thread Ajit Khaparde
On Mon, Aug 1, 2022 at 9:15 PM Mao,Yingming wrote: > > Thans for your review. > Mao Yingming > > -邮件原件- > 发件人: Somnath Kotur > 发送时间: 2022年8月2日 12:09 > 收件人: Mao,Yingming > 抄送: dev@dpdk.org; Ajit Khaparde ; Kalesh AP > ; Thomas Monjalon > 主题: Re: [PATCH v3

RE: [PATCH v7 2/4] ethdev: introduce protocol hdr based buffer split

2022-10-03 Thread Wang, YuanX
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Monday, October 3, 2022 3:47 PM > To: Wang, YuanX ; dev@dpdk.org; Thomas > Monjalon ; Ferruh Yigit > Cc: ferruh.yi...@xilinx.com; m...@ashroe.eu; Li, Xiaoyun > ; Singh, Aman Deep ; > Zhang, Yuying ; Zhang, Qi Z > ; Yang, Qi

RE: [PATCH v7 1/4] ethdev: introduce protocol header API

2022-10-03 Thread Wang, YuanX
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Monday, October 3, 2022 3:04 PM > To: Wang, YuanX ; dev@dpdk.org; Thomas > Monjalon ; Ferruh Yigit ; > Ray Kinsella > Cc: ferruh.yi...@xilinx.com; Li, Xiaoyun ; Singh, Aman > Deep ; Zhang, Yuying > ; Zhang, Qi Z ; Yang, > Q

Re: [PATCH] ethdev: forbid the use of direction attr in transfer flows

2022-10-03 Thread Ferruh Yigit
On 9/30/2022 11:42 AM, Ori Kam wrote: Hi Ivan, -Original Message- From: Ivan Malov Sent: Friday, 30 September 2022 12:43 As part of DPDK 21.11 release, it was announced that the use of attributes 'ingress' and 'egress' in 'transfer' rules was deprecated. The transition period is ove

Re: [PATCH 0/4] ethdev: remove not supported flow actions

2022-10-03 Thread Ferruh Yigit
On 9/29/2022 1:04 PM, Ori Kam wrote: -Original Message- From: Andrew Rybchenko Sent: Thursday, 29 September 2022 12:23 Process deprecation notice to remove RTE flow API actions which are not actually supported by any PMD. Andrew Rybchenko (4): ethdev: remove deprecated flow actio

Re: [PATCH 1/2] net/dpaa2: use new IEEE1588 flags

2022-10-03 Thread Ferruh Yigit
On 9/28/2022 8:14 AM, Gagandeep Singh wrote: Flags for IEEE1588 with ``PKT_*`` prefix has been changed to ``RTE_MBUF_F_*``. So in this patch updating the old flags. Signed-off-by: Gagandeep Singh For series, Reviewed-by: Ferruh Yigit Fixes: b9b509246da2 ("mbuf: remove deprecated offload fla

Re: [PATCH] net/softnic: fix file close

2022-10-03 Thread Ferruh Yigit
On 9/27/2022 5:42 AM, Harshad Narayane wrote: Coverity issue: 380976 Fixes: e3be2495 ("net/softnic: add pipeline code generation command") Fix file close at pipeline code generation. Signed-off-by: Harshad Narayane Signed-off-by: Kamalakannan R Acked-by: Cristian Dumitrescu Applied to dpdk

Re: [PATCH] net/softnic: fix memory free

2022-10-03 Thread Ferruh Yigit
On 9/27/2022 5:42 AM, Harshad Narayane wrote: Coverity issue: 380975 Coverity issue: 380977 Fixes: 02270033 ("net/softnic: add pipeline library build command") Fix memory resource free for buffer allocation failure at pipeline library build. Signed-off-by: Harshad Narayane Signed-off-by: Kamal

Re: [PATCH v4 1/3] ethdev: introduce ethdev desc dump API

2022-10-03 Thread Ferruh Yigit
On 9/23/2022 8:43 AM, Dongdong Liu wrote: From: "Min Hu (Connor)" Added the ethdev Rx/Tx desc dump API which provides functions for query descriptor from device. HW descriptor info differs in different NICs. The information demonstrates I/O process which is important for debug. As the informa

Re: [PATCH v7 1/4] eal: add lcore poll busyness telemetry

2022-10-03 Thread Mattias Rönnblom
On 2022-10-01 16:17, Konstantin Ananyev wrote: Hi Kevin, Currently, there is no way to measure lcore poll busyness in a passive way, without any modifications to the application. This patch adds a new EAL API that will be able to passively track core polling busyness. The poll busyness is

[PATCH] net/softnic: remove maintainer

2022-10-03 Thread Jasvinder Singh
I am removing myself as the maintainer. Signed-off-by: Jasvinder Singh --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index a55b379d73..c0337bc7af 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1009,7 +1009,6 @@ F: doc/guides/nics/fail_safe.rst F: d

[PATCH] sched: remove maintainer

2022-10-03 Thread Jasvinder Singh
I am removing myself as the maintainer of the sched library. Signed-off-by: Jasvinder Singh --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index c0337bc7af..b43fabe6a7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1471,7 +1471,6 @@ F: doc/guides/sam

[PATCH v11 7/7] bbdev: remove unnecessary if-check

2022-10-03 Thread Nicolas Chautru
Code clean up due to if-check not required Signed-off-by: Nicolas Chautru Acked-by: Maxime Coquelin --- lib/bbdev/rte_bbdev_op.h | 24 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h index c322d15dd5..e2

[PATCH v11 6/7] bbdev: add queue related warning and status information

2022-10-03 Thread Nicolas Chautru
This allows to expose more information with regards to any queue related failure and warning which cannot be supported in existing API. Signed-off-by: Nicolas Chautru Acked-by: Maxime Coquelin --- app/test-bbdev/test_bbdev_perf.c | 2 ++ doc/guides/rel_notes/release_22_11.rst | 3 ++ li

[PATCH v11 5/7] bbdev: add new operation for FFT processing

2022-10-03 Thread Nicolas Chautru
Extension of bbdev operation to support FFT based operations. Signed-off-by: Nicolas Chautru Acked-by: Hemant Agrawal Acked-by: Maxime Coquelin --- doc/guides/prog_guide/bbdev.rst| 103 + doc/guides/rel_notes/deprecation.rst | 4 - doc/guides/rel_notes/release_22_11

[PATCH v11 4/7] drivers/baseband: update PMDs to expose queue per operation

2022-10-03 Thread Nicolas Chautru
Add support in existing bbdev PMDs for the explicit number of queues and priority for each operation type configured on the device. Signed-off-by: Nicolas Chautru Acked-by: Maxime Coquelin Acked-by: Hemant Agrawal --- drivers/baseband/acc100/rte_acc100_pmd.c | 29 +++ .../

[PATCH v11 3/7] bbdev: add device info on queue topology

2022-10-03 Thread Nicolas Chautru
Adding more options in the API to expose the number of queues exposed and related priority. Signed-off-by: Nicolas Chautru Acked-by: Maxime Coquelin --- doc/guides/rel_notes/deprecation.rst | 3 --- doc/guides/rel_notes/release_22_11.rst | 2 +- lib/bbdev/rte_bbdev.h | 4

[PATCH v11 2/7] bbdev: add device status info

2022-10-03 Thread Nicolas Chautru
Added device status information, so that the PMD can expose information related to the underlying accelerator device status. Minor order change in structure to fit into padding hole. Signed-off-by: Nicolas Chautru Acked-by: Mingshan Zhang Acked-by: Hemant Agrawal --- doc/guides/rel_notes/depre

[PATCH v11 1/7] bbdev: allow operation type enum for growth

2022-10-03 Thread Nicolas Chautru
Updating the enum for rte_bbdev_op_type to allow to keep ABI compatible for enum insertion while adding padded maximum value for array need. Removing RTE_BBDEV_OP_TYPE_COUNT and instead exposing RTE_BBDEV_OP_TYPE_SIZE_MAX. Signed-off-by: Nicolas Chautru Acked-by: Maxime Coquelin --- app/test-bb

[PATCH v11 0/7] bbdev changes for 22.11

2022-10-03 Thread Nicolas Chautru
Hi Akhil, Thomas, v11: updated based on Thomas review notably on comments through the serie and ordering. Thanks. I have also updated rel_notes and deprecation through the serie this time. v10: replacing the _PADDED_MAX enum to _SIZE_MAX macro based on suggestion from Ferruh/Maxime/Akhil. Than

[Bug 1089] mlx5 Windows crash creating flows in multiple threads

2022-10-03 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1089 Bug ID: 1089 Summary: mlx5 Windows crash creating flows in multiple threads Product: DPDK Version: 21.11 Hardware: All OS: Windows Status: UNCONFIRMED Severity: c

Re: [PATCH v9 2/5] ethdev: support proactive error handling mode

2022-10-03 Thread Ferruh Yigit
On 9/22/2022 8:41 AM, Chengwen Feng wrote: From: Kalesh AP Some PMDs (e.g. hns3) could detect hardware or firmware errors, and try to recover from the errors. In this process, the PMD sets the data path pointers to dummy functions (which will prevent the crash), and also make sure the control p

Re: [PATCH v9 1/5] ethdev: support get port error handling mode

2022-10-03 Thread Ferruh Yigit
On 9/22/2022 8:41 AM, Chengwen Feng wrote: This patch support gets port's error handling mode by rte_eth_dev_info_get() API. Currently, the defined modes include: 1) NONE: it means no error handling modes are supported by this port. 2) PASSIVE: passive error handling, after the PMD detect that a

Re: [PATCH v1] dma/idxd: add completion status for page fault

2022-10-03 Thread Thomas Monjalon
23/08/2022 16:47, Sean Morrissey: > Add a status for page faults to be used when getting the > completion status of an operation. > > Signed-off-by: Sean Morrissey Applied, thanks.

Re: [PATCH v3] dma/cnxk: add support for CN10K DMA engine

2022-10-03 Thread Thomas Monjalon
05/08/2022 21:30, Radha Mohan Chintakuntla: > Added support for CN10K SoC DMA engine to dmadev. > > Signed-off-by: Radha Mohan Chintakuntla > Reviewed-by: Jerin Jacob Kollanukkaran Applied, thanks.

Re: [PATCH v10 6/7] bbdev: add queue related warning and status information

2022-10-03 Thread Thomas Monjalon
03/10/2022 18:39, Chautru, Nicolas: > Hi Thomas, > > I will update all your comments below today, thanks. Please do a self review of other patches (I reviewed only this one), I suspect there are a lot of other details to improve in other places. > The one where we need your confirmation is spec

Re: [PATCH v7 1/7] eal/loongarch: support LoongArch architecture

2022-10-03 Thread David Marchand
On Fri, Sep 30, 2022 at 10:02 AM Min Zhou wrote: > > Add all necessary elements for DPDK to compile and run EAL on > LoongArch64 Soc. > > This includes: > > - EAL library implementation for LoongArch ISA. > - meson build structure for 'loongarch' architecture. > RTE_ARCH_LOONGARCH define is adde

Re: [PATCH v2] examples/kni: remove deprecated kni example

2022-10-03 Thread Thomas Monjalon
03/10/2022 18:47, Stephen Hemminger: > On Mon, 03 Oct 2022 18:11:08 +0200 > Thomas Monjalon wrote: > > > 20/09/2022 17:51, Bruce Richardson: > > > As part of the agreed process for deprecating KNI in DPDK, the example > > > app is scheduled for removal as part of the 22.11 release. > > > > > > S

[PATCH] net/bnxt: fix build with GCC 13

2022-10-03 Thread David Marchand
GCC 13 complains with: ../../../dpdk/drivers/net/bnxt/tf_ulp/ulp_flow_db.c:962:1: error: conflicting types for ‘ulp_flow_db_flush_flows’ due to enum/integer mismatch; have ‘int32_t(struct bnxt_ulp_context *, enum bnxt_ulp_fdb_type)’ {aka ‘int(struct bnxt_ulp_context *, enum bnxt_ul

Re: [PATCH v2] examples/kni: remove deprecated kni example

2022-10-03 Thread Stephen Hemminger
On Mon, 03 Oct 2022 18:11:08 +0200 Thomas Monjalon wrote: > 20/09/2022 17:51, Bruce Richardson: > > As part of the agreed process for deprecating KNI in DPDK, the example > > app is scheduled for removal as part of the 22.11 release. > > > > Signed-off-by: Bruce Richardson > > --- > > V2: Corre

RE: [PATCH v10 6/7] bbdev: add queue related warning and status information

2022-10-03 Thread Chautru, Nicolas
Hi Thomas, I will update all your comments below today, thanks. The one where we need your confirmation is specifically this comment from your, I believe we discussed but good to make sure we are all aligned: > But the big question is why do we need this "MAX" value? > The guideline is to avo

RE: [dpdk-dev v3 1/1] lib/cryptodev: multi-process IPC request handler

2022-10-03 Thread Power, Ciara
Hi Kai, Some small comments below. > -Original Message- > From: Kai Ji > Sent: Sunday 2 October 2022 23:45 > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai > Subject: [dpdk-dev v3 1/1] lib/cryptodev: multi-process IPC request handler > > This patch add a function to support queue-p

[PATCH v5] ethdev: add send to kernel action

2022-10-03 Thread Michael Savisko
In some cases application may receive a packet that should have been received by the kernel. In this case application uses KNI or other means to transfer the packet to the kernel. With bifurcated driver we can have a rule to route packets matching a pattern (example: IPv4 packets) to the DPDK appl

Re: [PATCH v7 0/7] Introduce support for LoongArch architecture

2022-10-03 Thread David Marchand
Hello Min, On Sat, Oct 1, 2022 at 4:26 PM zhoumin wrote: > I'm Sorry, I misunderstood the 'instructions' you said. The process of > making the toolchain is a little complicated. So I made a script used to > generate the toolchain from source codes. The content of the script is > as follows: > I

Re: [PATCH v2] examples/dma: support DMA dequeue when no packet received

2022-10-03 Thread Thomas Monjalon
25/07/2022 14:48, Bruce Richardson: > On Mon, Jul 25, 2022 at 08:22:00PM +0800, Chengwen Feng wrote: > > Currently the example using DMA in asynchronous mode, which are: > > nb_rx = rte_eth_rx_burst(); > > if (nb_rx == 0) > > continue; > > ... > > dma_enqueue(); // enque

Re: [PATCH v2] examples/kni: remove deprecated kni example

2022-10-03 Thread Thomas Monjalon
20/09/2022 17:51, Bruce Richardson: > As part of the agreed process for deprecating KNI in DPDK, the example > app is scheduled for removal as part of the 22.11 release. > > Signed-off-by: Bruce Richardson > --- > V2: Correct old release note links to KNI guide by referencing older doc Acked-by:

[PATCH v1] crypto/qat: reallocate on openssl version check

2022-10-03 Thread Brian Dooley
This patch reallocates the openssl version check from qat_session_configure() to a proper qat_security_session_create() routine Fixes: 3227bc7138f5 ("crypto/qat: use intel-ipsec-mb for partial hash and AES") Cc: sta...@dpdk.org Signed-off-by: Brian Dooley --- drivers/crypto/qat/qat_sym_session.

RE: [PATCH 3/3] ethdev: add structure for indirect AGE update

2022-10-03 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Monday, 3 October 2022 16:18 > > On 10/3/22 11:30, Ori Kam wrote: > > Hi Andrew, > > > >> -Original Message- > >> From: Andrew Rybchenko > >> Sent: Monday, 3 October 2022 11:04 > >> > >> On 9/21/22 17:54, Michael B

Re: [PATCH v2] net/pcap: fix timeout of stopping device

2022-10-03 Thread Ferruh Yigit
On 9/21/2022 8:14 AM, Zhou, YidingX wrote: -Original Message- From: Stephen Hemminger Sent: Tuesday, September 6, 2022 10:58 PM To: Zhou, YidingX Cc: dev@dpdk.org; Zhang, Qi Z ; Burakov, Anatoly ; He, Xingguang ; sta...@dpdk.org Subject: Re: [PATCH v2] net/pcap: fix timeout of stoppi

Re: [PATCH v2 1/1] ethdev: add protocol param to color table update

2022-10-03 Thread Ferruh Yigit
On 8/23/2022 2:34 PM, Dumitrescu, Cristian wrote: -Original Message- From: sk...@marvell.com Sent: Tuesday, August 23, 2022 11:23 AM To: Dumitrescu, Cristian ; Singh, Aman Deep ; Zhang, Yuying ; Nithin Dabilpuram ; Kiran Kumar K ; Sunil Kumar Kori ; Satha Rao ; Singh, Jasvinder ; Thom

Re: [PATCH v7] eal: add bus cleanup to eal cleanup

2022-10-03 Thread Kevin Laatz
Hi David, On 03/10/2022 13:35, David Marchand wrote: Hello Bruce, Kevin, On Mon, Jun 13, 2022 at 5:59 PM Bruce Richardson wrote: For info, Li has sent a patch for the bus cleanup which is not updating the bus code: https://patches.dpdk.org/project/dpdk/patch/20220606114650.209612-3-l...@nvidi

Re: [PATCH 1/6] service: reduce statistics overhead for parallel services

2022-10-03 Thread Mattias Rönnblom
On 2022-10-03 15:33, Van Haaren, Harry wrote: >> -Original Message- >> From: Mattias Rönnblom >> Sent: Tuesday, September 6, 2022 5:14 PM >> To: Van; Haaren; Van Haaren, Harry >> Cc: dev@dpdk.org; Honnappa Nagarahalli ; >> Morten Brørup ; nd ; >> mattias.ronnblom >> Subject: [PATCH 1/6]

Re: [PATCH v2 00/14] add support for idpf PMD in DPDK

2022-10-03 Thread Andrew Rybchenko
On 10/3/22 16:31, Andrew Rybchenko wrote: On 9/5/22 13:58, Junfeng Guo wrote: This patchset introduced the idpf (Infrastructure Data Path Function) PMD [*EXPERIMENTAL*] in DPDK for Intel Device ID of 0x1452. v2: fixed some coding style issues and did some refactors. The patch series should:

Re: [PATCH 3/6] service: reduce average case service core overhead

2022-10-03 Thread Mattias Rönnblom
On 2022-10-03 15:33, Van Haaren, Harry wrote: >> -Original Message- >> From: Mattias Rönnblom >> Sent: Tuesday, September 6, 2022 5:14 PM >> To: Van; Haaren; Van Haaren, Harry >> Cc: dev@dpdk.org; Honnappa Nagarahalli ; >> Morten Brørup ; nd ; >> mattias.ronnblom >> Subject: [PATCH 3/6]

Re: [PATCH v2 14/14] net/idpf: add support for timestamp offload

2022-10-03 Thread Andrew Rybchenko
On 9/5/22 13:58, Junfeng Guo wrote: Add support for timestamp offload. Signed-off-by: Wenjing Qiao Signed-off-by: Junfeng Guo [snip] +/* Helper function to convert a 32b nanoseconds timestamp to 64b. */ +static inline uint64_t +idpf_tstamp_convert_32b_64b(struct iecm_hw *hw, struct idpf_ad

Re: [PATCH v2 13/14] net/idpf: add AVX512 data path for single queue model

2022-10-03 Thread Andrew Rybchenko
On 9/5/22 13:58, Junfeng Guo wrote: Add support of AVX512 vector data path for single queue model. Signed-off-by: Wenjun Wu Signed-off-by: Junfeng Guo [snip] +static __rte_always_inline void +idpf_singleq_rearm(struct idpf_rx_queue *rxq) +{ [snip] + const __m512i iova_offsets =

Re: [PATCH v2 10/14] net/idpf: add support for mtu configuration

2022-10-03 Thread Andrew Rybchenko
On 9/5/22 13:58, Junfeng Guo wrote: Add dev ops mtu_set. It would be useful to mention in the description that changing MTU is not supported when device is started.

Re: [PATCH v2 09/14] net/idpf: add support for RSS

2022-10-03 Thread Andrew Rybchenko
On 9/5/22 13:58, Junfeng Guo wrote: Add RSS support. Signed-off-by: Beilei Xing Signed-off-by: Junfeng Guo --- drivers/net/idpf/idpf_ethdev.c | 118 - drivers/net/idpf/idpf_ethdev.h | 17 + drivers/net/idpf/idpf_vchnl.c | 96 ++

Re: [PATCH v2 08/14] net/idpf: add support for basic Rx/Tx datapath

2022-10-03 Thread Andrew Rybchenko
On 9/5/22 13:58, Junfeng Guo wrote: Add basic RX & TX support in split queue mode and single queue mode. RX -> Rx, TX -> Tx Split queue mode is selected by default. What is split queue mode? Where is it defined/described? The patch is very big again. Please, start from really basic Rx and

Re: [PATCH] drivers: suggestion on removing empty version.map files

2022-10-03 Thread Bruce Richardson
On Mon, Oct 03, 2022 at 04:59:18PM +0300, Omer Yamac wrote: > > > On 03.10.2022 12:19, Bruce Richardson wrote: > > On Mon, Oct 03, 2022 at 09:52:03AM +0300, Abdullah Ömer Yamaç wrote: > > > In this patch, we remove all version.map files which include > > > only the below part: > > > `DPDK_23 { >

Re: [PATCH] drivers: suggestion on removing empty version.map files

2022-10-03 Thread Omer Yamac
On 03.10.2022 12:19, Bruce Richardson wrote: On Mon, Oct 03, 2022 at 09:52:03AM +0300, Abdullah Ömer Yamaç wrote: In this patch, we remove all version.map files which include only the below part: `DPDK_23 { local: *; };` Then we modify the meson.build to be able to compile without v

Re: [PATCH v2 06/14] net/idpf: add support for packet type get

2022-10-03 Thread Andrew Rybchenko
On 9/5/22 13:58, Junfeng Guo wrote: Add dev ops dev_supported_ptypes_get. Signed-off-by: Beilei Xing Signed-off-by: Wenjun Wu Signed-off-by: Junfeng Guo [snip] diff --git a/drivers/net/idpf/idpf_rxtx.c b/drivers/net/idpf/idpf_rxtx.c index fe044a80c9..1c5c4688cc 100644 --- a/drivers/net/id

[PATCH v6 6/6] security: hide session structure

2022-10-03 Thread Akhil Goyal
Structure rte_security_session is moved to internal headers which are not visible to applications. The only field which should be used by app is opaque_data. This field can now be accessed via set/get APIs added in this patch. Subsequent changes in app and lib are made to compile the code. Signed-

[PATCH v6 5/6] drivers/crypto: support security session get size op

2022-10-03 Thread Akhil Goyal
Added the support for rte_security_op.session_get_size() in all the PMDs which support rte_security sessions and the op was not supported. Signed-off-by: Akhil Goyal Acked-by: Kai Ji Tested-by: Gagandeep Singh Tested-by: David Coyle Tested-by: Kevin O'Sullivan --- drivers/crypto/caam_jr/caam

[PATCH v6 4/6] security: remove priv mempool usage

2022-10-03 Thread Akhil Goyal
As per current design, rte_security_session_create() unnecessarily use 2 mempool objects for a single session. To address this, the API will now take only 1 mempool object instead of 2. With this change, the library layer will get the object from mempool and session priv data is stored contiguousl

[PATCH v6 3/6] cryptodev: hide sym session structure

2022-10-03 Thread Akhil Goyal
Structure rte_cryptodev_sym_session is moved to internal headers which are not visible to applications. The only field which should be used by app is opaque_data. This field can now be accessed via set/get APIs added in this patch. Subsequent changes in app and lib are made to compile the code. Si

[PATCH v6 2/6] crypto/scheduler: use unified session

2022-10-03 Thread Akhil Goyal
From: Fan Zhang This patch updates the scheduler PMD to use unified session data structure. Previously thanks to the private session array in cryptodev sym session there are no necessary change needed for scheduler PMD other than the way ops are enqueued/dequeued. The patch inherits the same desi

Re: [PATCH v2 05/14] net/idpf: add support for device information get

2022-10-03 Thread Andrew Rybchenko
On 9/5/22 13:58, Junfeng Guo wrote: Add dev ops dev_infos_get. The hook may be called on very earlier stages of the driver life. So, I'd recommend to move the patch even before configure/clsoe. User may request the dev_info in just probed state. Signed-off-by: Beilei Xing Signed-off-by: Jun

[PATCH v6 0/6] crypto/security session framework rework

2022-10-03 Thread Akhil Goyal
This patchset reworks the symmetric crypto and security session data structure to use a single virtual/physical contiguous buffer for symmetric crypto/security session and driver private data. In addition the session data structure is now private. The session is represented as an opaque pointer in

Re: [PATCH v2 04/14] net/idpf: add support for queue operations

2022-10-03 Thread Andrew Rybchenko
On 9/5/22 13:58, Junfeng Guo wrote: Add support for queue operations: - rx_queue_start - rx_queue_stop - tx_queue_start - tx_queue_stop - rx_queue_setup - rx_queue_release - tx_queue_setup - tx_queue_release The patch is huge. Plea

RE: [PATCH 4/6] service: tweak cycle statistics semantics

2022-10-03 Thread Van Haaren, Harry
> -Original Message- > From: Morten Brørup > Sent: Wednesday, September 7, 2022 9:41 AM > To: mattias.ronnblom ; Van Haaren, Harry > > Cc: dev@dpdk.org; Honnappa Nagarahalli ; nd > > Subject: RE: [PATCH 4/6] service: tweak cycle statistics semantics > > > From: Mattias Rönnblom [mailt

Re: [PATCH v2 03/14] net/idpf: add support for device initialization

2022-10-03 Thread Andrew Rybchenko
On 9/5/22 13:58, Junfeng Guo wrote: Support device init and the following dev ops: - dev_configure - dev_start - dev_stop - dev_close A bit strange set from my point of view since you can't start without setup queues. Each patch should be testable. It should be n

RE: [PATCH 1/6] service: reduce statistics overhead for parallel services

2022-10-03 Thread Van Haaren, Harry
> -Original Message- > From: Mattias Rönnblom > Sent: Tuesday, September 6, 2022 5:14 PM > To: Van; Haaren; Van Haaren, Harry > Cc: dev@dpdk.org; Honnappa Nagarahalli ; > Morten Brørup ; nd ; > mattias.ronnblom > Subject: [PATCH 1/6] service: reduce statistics overhead for parallel servi

RE: [PATCH 3/6] service: reduce average case service core overhead

2022-10-03 Thread Van Haaren, Harry
> -Original Message- > From: Mattias Rönnblom > Sent: Tuesday, September 6, 2022 5:14 PM > To: Van; Haaren; Van Haaren, Harry > Cc: dev@dpdk.org; Honnappa Nagarahalli ; > Morten Brørup ; nd ; > mattias.ronnblom > Subject: [PATCH 3/6] service: reduce average case service core overhead >

Re: [PATCH v2 00/14] add support for idpf PMD in DPDK

2022-10-03 Thread Andrew Rybchenko
On 9/5/22 13:58, Junfeng Guo wrote: This patchset introduced the idpf (Infrastructure Data Path Function) PMD [*EXPERIMENTAL*] in DPDK for Intel Device ID of 0x1452. v2: fixed some coding style issues and did some refactors. The patch series should: - add entry in MAINTAINERS - add driver do

Re: [PATCH v2 02/14] net/idpf/base: add logs and OS specific implementation

2022-10-03 Thread Andrew Rybchenko
On 9/5/22 13:58, Junfeng Guo wrote: Add PMD logs. Add some MACRO definations and small functions which are specific for DPDK. Signed-off-by: Beilei Xing Signed-off-by: Junfeng Guo The patch adds dead code as well. Added headers are used nowhere. One more question is what's the point to have

Re: [PATCH v2 01/14] net/idpf/base: introduce base code

2022-10-03 Thread Andrew Rybchenko
On 9/5/22 13:58, Junfeng Guo wrote: Introduce base code for IDPF (Infrastructure Data Path Function) PMD. Signed-off-by: Beilei Xing Signed-off-by: Junfeng Guo I'm OK to import base driver in one patch, but it should not be the first patch with dead code which is not actually built just afte

Re: [PATCH 3/3] ethdev: add structure for indirect AGE update

2022-10-03 Thread Andrew Rybchenko
On 10/3/22 11:30, Ori Kam wrote: Hi Andrew, -Original Message- From: Andrew Rybchenko Sent: Monday, 3 October 2022 11:04 On 9/21/22 17:54, Michael Baum wrote: Add a new structure for indirect AGE update. This new structure enables: 1. Update timeout value. 2. Stop AGE checking. 3. S

Re: [PATCH v2] replace Mellanox with NVIDIA

2022-10-03 Thread Thomas Monjalon
03/10/2022 15:06, Gal Cohen (ProdM): > Ack. > > Thanks Thomas. > > -Gal > > From: Thomas Monjalon > NVIDIA acquired Mellanox Technologies in 2020. > The DPDK documentation and code might still include instances of or > references to Mellanox trademarks (like BlueField and ConnectX) that are

RE: [PATCH v2] replace Mellanox with NVIDIA

2022-10-03 Thread Gal Cohen (ProdM)
Ack. Thanks Thomas. -Gal -Original Message- From: Thomas Monjalon Sent: Monday, 3 October 2022 15:40 To: dev@dpdk.org Cc: Matan Raz ; Gal Cohen (ProdM) ; Asaf Penso ; Raslan Darawsheh ; Matan Azrad ; Elena Agostini ; Slava Ovsiienko ; Ori Kam ; Bruce Richardson Subject: [PATCH v2

RE: [PATCH 1/6] service: reduce statistics overhead for parallel services

2022-10-03 Thread Van Haaren, Harry
> -Original Message- > From: Mattias Rönnblom > Sent: Monday, October 3, 2022 12:37 PM > To: David Marchand ; Van Haaren, Harry > > Cc: dev@dpdk.org; Honnappa Nagarahalli ; > Morten Brørup ; nd > Subject: Re: [PATCH 1/6] service: reduce statistics overhead for parallel > services > >

Re: [PATCH v7 0/7] Introduce support for LoongArch architecture

2022-10-03 Thread zhoumin
Hi, Ali, Thanks for your kind reply. On Mon, Oct 3, 2022 at 16:14, Ali Alnubani wrote: -Original Message- From: David Marchand Sent: Friday, September 30, 2022 5:21 PM To: zhoumin Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; bruce.richard...@intel.com; anatoly.bura...@intel.com; qimi

[PATCH v2] replace Mellanox with NVIDIA

2022-10-03 Thread Thomas Monjalon
NVIDIA acquired Mellanox Technologies in 2020. The DPDK documentation and code might still include instances of or references to Mellanox trademarks (like BlueField and ConnectX) that are now NVIDIA trademarks. The PCI IDs and copyrights are unchanged. Signed-off-by: Thomas Monjalon --- v2: - co

Re: [PATCH v5 1/2] member: implement NitroSketch mode

2022-10-03 Thread Thomas Monjalon
16/09/2022 05:03, Leyi Rong: > lib/member/meson.build| 49 ++- > lib/member/rte_member.c | 75 > lib/member/rte_member.h | 154 ++- > lib/member/rte_member_heap.h | 424 ++ > lib/member/rte_member_sketch.c| 594

Re: [PATCH v7] eal: add bus cleanup to eal cleanup

2022-10-03 Thread David Marchand
Hello Bruce, Kevin, On Mon, Jun 13, 2022 at 5:59 PM Bruce Richardson wrote: > > > For info, Li has sent a patch for the bus cleanup > > > which is not updating the bus code: > > > https://patches.dpdk.org/project/dpdk/patch/20220606114650.209612-3-l...@nvidia.com/ > > > It may be a temporary solu

Re: [PATCH 1/6] service: reduce statistics overhead for parallel services

2022-10-03 Thread Mattias Rönnblom
On 2022-10-03 11:53, David Marchand wrote: > On Mon, Oct 3, 2022 at 10:40 AM Mattias Rönnblom > wrote: >> >> On 2022-10-03 10:06, David Marchand wrote: >>> On Tue, Sep 6, 2022 at 6:17 PM Mattias Rönnblom >>> wrote: Move the statistics from the service data structure to the per-lcore >>>

Re: [PATCH v4] ethdev: add send to kernel action

2022-10-03 Thread Andrew Rybchenko
On 10/3/22 14:06, Ori Kam wrote: Hi Andrew, -Original Message- From: Andrew Rybchenko Sent: Monday, 3 October 2022 13:47 On 10/3/22 12:57, Ori Kam wrote: Hi Andrew, -Original Message- From: Andrew Rybchenko Sent: Monday, 3 October 2022 12:44 On 10/3/22 11:23, Ori Kam wrot

RE: [PATCH v4] ethdev: add send to kernel action

2022-10-03 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Monday, 3 October 2022 13:47 > > On 10/3/22 12:57, Ori Kam wrote: > > Hi Andrew, > > > >> -Original Message- > >> From: Andrew Rybchenko > >> Sent: Monday, 3 October 2022 12:44 > >> > >> On 10/3/22 11:23, Ori Kam w

Re: [PATCH v4] ethdev: add send to kernel action

2022-10-03 Thread Andrew Rybchenko
On 10/3/22 12:57, Ori Kam wrote: Hi Andrew, -Original Message- From: Andrew Rybchenko Sent: Monday, 3 October 2022 12:44 On 10/3/22 11:23, Ori Kam wrote: Hi Andrew -Original Message- From: Andrew Rybchenko Sent: Monday, 3 October 2022 10:54 On 9/29/22 17:54, Michael Savisk

Re: [PATH 2/2] vhost: fix slot index calculation in async vhost

2022-10-03 Thread Maxime Coquelin
On 8/22/22 06:31, Cheng Jiang wrote: When the packet receiving failure and the DMA ring full occur simultaneously in the asynchronous vhost, the slot_idx needs to be reduced by 1. For packed virtqueue, the slot index should be s/reduced/decreased/ ring_size - 1, if the slot_idx is currentl

Re: [PATH 1/2] vhost: fix descs count in async vhost packed ring

2022-10-03 Thread Maxime Coquelin
On 8/22/22 06:31, Cheng Jiang wrote: When vhost receive packets from the front-end using packed virtqueue, it receives* might use multiple descriptors for one packet, so we need calculate and so we need to* record the descriptor number for each packet to update available descriptor cou

Re: [PATCH v2] rwlock: prevent readers from starving writers

2022-10-03 Thread David Marchand
On Tue, Jul 19, 2022 at 10:28 PM Stephen Hemminger wrote: > > Modify reader/writer lock to avoid starvation of writer. The previous > implementation would cause a writer to get starved if readers kept > acquiring the lock. The new version uses an additional bit to indicate > that a writer is wai

Opensource ethdev tests

2022-10-03 Thread Andrew Rybchenko
Hi Thomas and community, May I ask to add https://ts-factory.io/ to the DPDK ecosystem. I'm not 100% that it is suitable for the ecosystem since it is not consuming DPDK, but rather testing DPDK ethdev. Anyway it could be useful for ethdev PMD developers and maintainers. I'll not repeat what i

RE: [PATCH v4] ethdev: add send to kernel action

2022-10-03 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Monday, 3 October 2022 12:44 > > On 10/3/22 11:23, Ori Kam wrote: > > Hi Andrew > > > >> -Original Message- > >> From: Andrew Rybchenko > >> Sent: Monday, 3 October 2022 10:54 > >> On 9/29/22 17:54, Michael Savisko

Re: [PATCH 1/6] service: reduce statistics overhead for parallel services

2022-10-03 Thread David Marchand
On Mon, Oct 3, 2022 at 10:40 AM Mattias Rönnblom wrote: > > On 2022-10-03 10:06, David Marchand wrote: > > On Tue, Sep 6, 2022 at 6:17 PM Mattias Rönnblom > > wrote: > >> > >> Move the statistics from the service data structure to the per-lcore > >> struct. This eliminates contention for the coun

Re: [PATCH v4] ethdev: add send to kernel action

2022-10-03 Thread Andrew Rybchenko
On 10/3/22 11:23, Ori Kam wrote: Hi Andrew -Original Message- From: Andrew Rybchenko Sent: Monday, 3 October 2022 10:54 On 9/29/22 17:54, Michael Savisko wrote: In some cases application may receive a packet that should have been received by the kernel. In this case application uses K

Re: [PATCH] drivers: suggestion on removing empty version.map files

2022-10-03 Thread Bruce Richardson
On Mon, Oct 03, 2022 at 09:52:03AM +0300, Abdullah Ömer Yamaç wrote: > In this patch, we remove all version.map files which include > only the below part: > `DPDK_23 { > local: *; > };` > > Then we modify the meson.build to be able to compile without version.map > > Signed-off-by: Abdullah

Re: [PATCH v2 1/3] ethdev: add API for direct rearm mode

2022-10-03 Thread Konstantin Ananyev
27/09/2022 03:47, Feifei Wang пишет: Add API for enabling direct rearm mode and for mapping RX and TX queues. Currently, the API supports 1:1(txq : rxq) mapping. Furthermore, to avoid Rx load Tx data directly, add API called 'rte_eth_txq_data_get' to get Tx sw_ring and its information. Suggeste

Re: [PATCH 1/6] service: reduce statistics overhead for parallel services

2022-10-03 Thread Mattias Rönnblom
On 2022-10-03 10:06, David Marchand wrote: > On Tue, Sep 6, 2022 at 6:17 PM Mattias Rönnblom > wrote: >> >> Move the statistics from the service data structure to the per-lcore >> struct. This eliminates contention for the counter cache lines, which >> decreases the producer-side statistics overhe

RE: [PATCH 3/3] ethdev: add structure for indirect AGE update

2022-10-03 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Monday, 3 October 2022 11:04 > > On 9/21/22 17:54, Michael Baum wrote: > > Add a new structure for indirect AGE update. > > > > This new structure enables: > > 1. Update timeout value. > > 2. Stop AGE checking. > > 3. Start

Re: [PATCH v10 6/7] bbdev: add queue related warning and status information

2022-10-03 Thread Thomas Monjalon
Looking at this patch because I have been alerted about the ABI compat handling. I see some details that should have been caught in earlier reviews. 30/09/2022 20:46, Nicolas Chautru: > +/* > + * Maximum size to be used to manage the enum rte_bbdev_enqueue_status > including padding for future

RE: [PATCH v4] ethdev: add send to kernel action

2022-10-03 Thread Ori Kam
Hi Andrew > -Original Message- > From: Andrew Rybchenko > Sent: Monday, 3 October 2022 10:54 > On 9/29/22 17:54, Michael Savisko wrote: > > In some cases application may receive a packet that should have been > > received by the kernel. In this case application uses KNI or other means > >

RE: [PATCH v7 0/7] Introduce support for LoongArch architecture

2022-10-03 Thread Ali Alnubani
> -Original Message- > From: David Marchand > Sent: Friday, September 30, 2022 5:21 PM > To: zhoumin > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > bruce.richard...@intel.com; anatoly.bura...@intel.com; > qiming.y...@intel.com; yuying.zh...@intel.com; jgraj...@cisco.com; > konstantin.v.

  1   2   >