RE: rte_service unit test failing randomly

2022-10-05 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Wednesday, 5 October 2022 23.34 > > On 2022-10-05 22:52, Thomas Monjalon wrote: > > 05/10/2022 22:33, Mattias Rönnblom: > >> On 2022-10-05 21:14, David Marchand wrote: > >>> Hello, > >>> > >>> The service_autotest unit test ha

Re: [PATCH v4 0/6] add thread lifetime and attributes API

2022-10-05 Thread David Marchand
On Wed, Oct 5, 2022 at 6:34 PM Tyler Retzlaff wrote: > > On Wed, Oct 05, 2022 at 09:11:26AM -0700, Tyler Retzlaff wrote: > > hi David, > > > > > > > > > > Newly added code can go to eal_common_thread.c rather than introduce a > > > new common/rte_thread.c file (or is there a rationale for this?).

RE: [PATCH v2] examples: compilation fix for GCC-12

2022-10-05 Thread Amit Prakash Shukla
checkpatch complains about coding style error. It looks like a false positive ? Please suggest. Thanks, Amit Shukla > -Original Message- > From: Amit Prakash Shukla > Sent: Friday, September 2, 2022 1:14 PM > To: Ruifeng Wang > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; > sta...@dp

[PATCH v4 6/6] net/af_xdp: make compatible with libbpf v0.8.0

2022-10-05 Thread Andrew Rybchenko
From: Ciara Loftus libbpf v0.8.0 deprecates the bpf_get_link_xdp_id() and bpf_set_link_xdp_fd() functions. Use meson to detect if bpf_xdp_attach() is available and if so, use the recommended replacement functions bpf_xdp_query_id(), bpf_xdp_attach() and bpf_xdp_detach(). Signed-off-by: Ciara Lof

[PATCH v4 5/6] net/af_xdp: log errors on XDP program removal failures

2022-10-05 Thread Andrew Rybchenko
Make it visible in logs if something goes wrong on XDP program removal failure. Signed-off-by: Andrew Rybchenko --- drivers/net/af_xdp/rte_eth_af_xdp.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af

[PATCH v4 4/6] net/af_xdp: avoid version-based check for program load mech

2022-10-05 Thread Andrew Rybchenko
Version-based checks are bad. It is better to check for required functions. Check for bpf_object__next_program() in this case since it appears last in libbpf among functions used to load program without bpf_prog_load() which is deprecated in libbpf v0.7.0. Signed-off-by: Andrew Rybchenko --- dri

[PATCH v4 3/6] net/af_xdp: avoid version-based check for shared UMEM

2022-10-05 Thread Andrew Rybchenko
Check for xsk_socket__create_shared() function instead. Signed-off-by: Andrew Rybchenko --- drivers/net/af_xdp/meson.build | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/net/af_xdp/meson.build b/drivers/net/af_xdp/meson.build index fa011c357d..

[PATCH v4 2/6] net/af_xdp: make it clear which libxdp version is required

2022-10-05 Thread Andrew Rybchenko
Include checked libxdp version in driver build skip reason. Signed-off-by: Andrew Rybchenko --- drivers/net/af_xdp/meson.build | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/af_xdp/meson.build b/drivers/net/af_xdp/meson.build index 882d0b9518..fa011c357d 1

[PATCH v4 1/6] net/af_xdp: move XDP library presence flag to right branch

2022-10-05 Thread Andrew Rybchenko
RTE_NET_AF_XDP_LIBXDP is a conditional to include xdp/xsk.h and should be set as soon as we know that the header is present. RTE_NET_AF_XDP_SHARED_UMEM is one of conditions to use xsk_socket__create_shared(). Both do not depend on libbpf and bpf/bpf.h presence. Since else branch below returns erro

[PATCH v4 0/6] net/af_xdp: make compatible with libbpf v0.8.0

2022-10-05 Thread Andrew Rybchenko
Update net/af_xdp build to support libbfp v0.8.0. Avoid library version based checks, check for function presense instead. v4: - just rebase - do not mention libbpf v0.8.0 as a strict limitation v3: - avoid version-based checks Andrew Rybchenko (5): net/af_xdp: move XDP library pre

RE: [EXT] DPDK build for Arm with GCC 12

2022-10-05 Thread Rahul Bhansali
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, October 4, 2022 6:17 PM > To: Rahul Bhansali ; Akhil Goyal > > Cc: dev@dpdk.org; ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com > Subject: [EXT] DPDK build for Arm with GCC 12 > > External Email > > --

Re: [PATCH v2] vhost: fix build

2022-10-05 Thread zhoumin
Hi, Maxime, Thanks a lot for your kind reply. This patch is very useful and relieves the concerns in my heart. On Wed, Oct 5, 2022 at 22:51, Maxime Coquelin wrote: Hi Min, On 9/26/22 05:25, zhoumin wrote: Hi Chenbo, On Mon, 26 Sep 2022, 10:57, Xia, Chenbo wrote: Hi Min, -Original

Re: [PATCH v2] vhost: fix build

2022-10-05 Thread zhoumin
Hi, Maxime, Thanks a lot for your kind reply. This patch is very useful and relieves the concerns in my heart. On Wed, Oct 5, 2022 at 22:51, Maxime Coquelin wrote: Hi Min, On 9/26/22 05:25, zhoumin wrote: Hi Chenbo, On Mon, 26 Sep 2022, 10:57, Xia, Chenbo wrote: Hi Min, -Original

RE: [EXT] [dpdk-dev v3 1/1] lib/cryptodev: multi-process IPC request handler

2022-10-05 Thread Ji, Kai
Please see my comments inline > -Original Message- > From: Akhil Goyal > Sent: Tuesday, October 4, 2022 7:13 PM > To: Ji, Kai ; dev@dpdk.org > Subject: RE: [EXT] [dpdk-dev v3 1/1] lib/cryptodev: multi-process IPC request > handler > > > This patch add a function to support queue-pair con

Re: [PATCH] eal: fix return type of bsf safe functions

2022-10-05 Thread Thomas Monjalon
06/10/2022 00:20, Tyler Retzlaff: > On Wed, Oct 05, 2022 at 09:41:26PM +0200, David Marchand wrote: > > On Wed, Oct 5, 2022 at 5:41 PM Thomas Monjalon wrote: > > > > > > In a recent commit, changing return type from int to uint32_t, > > > I did a last minute change to functions rte_bsf32_safe and

[Patch v10 18/18] net/mana: support Rx interrupts

2022-10-05 Thread longli
From: Long Li mana can receive Rx interrupts from kernel through RDMA verbs interface. Implement Rx interrupts in the driver. Signed-off-by: Long Li --- Change log: v5: New patch added to the series v8: Fix coding style on function definitions. doc/guides/nics/features/mana.ini | 1 + drive

[Patch v10 17/18] net/mana: report queue stats

2022-10-05 Thread longli
From: Long Li Report packet statistics. Signed-off-by: Long Li --- Change log: v5: Fixed calculation of stats packets/bytes/errors by adding them over the queue stats. v8: Fixed coding style on function definitions. doc/guides/nics/features/mana.ini | 1 + drivers/net/mana/mana.c

[Patch v10 16/18] net/mana: start/stop device

2022-10-05 Thread longli
From: Long Li Add support for starting/stopping the device. Signed-off-by: Long Li --- Change log: v2: Use spinlock for memory registration cache. Add prefix mana_ to all function names. v6: Roll back device state on error in mana_dev_start() drivers/net/mana/mana.c | 77 +

[Patch v10 15/18] net/mana: send packets

2022-10-05 Thread longli
From: Long Li With all the TX queues created, MANA can send packets over those queues. Signed-off-by: Long Li --- Change log: v2: rename all camel cases. v7: return the correct number of packets sent v8: fix coding style to function definitions. change enum names to use capital letters. v10: re

[Patch v10 13/18] net/mana: start/stop Rx queues

2022-10-05 Thread longli
From: Long Li MANA allocates device queues through the IB layer when starting Rx queues. When device is stopped all the queues are unmapped and freed. Signed-off-by: Long Li --- Change log: v2: Add prefix mana_ to all function names. Remove unused header files. v4: Move defition "uint32_t i" fr

[Patch v10 14/18] net/mana: receive packets

2022-10-05 Thread longli
From: Long Li With all the RX queues created, MANA can use those queues to receive packets. Signed-off-by: Long Li --- Change log: v2: Add mana_ to all function names. Rename a camel case. v8: Fix coding style to function definitions. v10: Rearrange the order in doc/guides/nics/features/mana.in

[Patch v10 11/18] net/mana: implement the hardware layer operations

2022-10-05 Thread longli
From: Long Li The hardware layer of MANA understands the device queue and doorbell formats. Those functions are implemented for use by packet RX/TX code. Signed-off-by: Long Li --- Change log: v2: Remove unused header files. Rename a camel case. v5: Use RTE_BIT32() instead of defining a new BIT

[Patch v10 12/18] net/mana: start/stop Tx queues

2022-10-05 Thread longli
From: Long Li MANA allocate device queues through the IB layer when starting Tx queues. When device is stopped all the queues are unmapped and freed. Signed-off-by: Long Li --- Change log: v2: Add prefix mana_ to all function names. Remove unused header files. v8: fix coding style to function d

[Patch v10 10/18] net/mana: implement memory registration

2022-10-05 Thread longli
From: Long Li MANA hardware has iommu built-in, that provides hardware safe access to user memory through memory registration. Since memory registration is an expensive operation, this patch implements a two level memory registration cache mechanisum for each queue and for each port. Signed-off-

[Patch v10 09/18] net/mana: configure Tx queues

2022-10-05 Thread longli
From: Long Li Tx hardware queue is allocated when starting the queue, this is for pre configuration. Signed-off-by: Long Li --- change log: v8: fix coding style to function definitions v9: move data definitions from earlier patch. drivers/net/mana/mana.c | 67 +

[Patch v10 08/18] net/mana: configure Rx queues

2022-10-05 Thread longli
From: Long Li Rx hardware queue is allocated when starting the queue. This function is for queue configuration pre starting. Signed-off-by: Long Li --- Change log: v8: fix coding style to function definitions v9: move data defintions from earlier patch. drivers/net/mana/mana.c | 71 ++

[Patch v10 07/18] net/mana: configure RSS

2022-10-05 Thread longli
From: Long Li Currently this PMD supports RSS configuration when the device is stopped. Configuring RSS in running state will be supported in the future. Signed-off-by: Long Li --- change log: v8: fix coding sytle to function definitions v10: remove accidentally introduced change from v9 doc/

[Patch v10 06/18] net/mana: report device info

2022-10-05 Thread longli
From: Long Li Add the function to get device info. Signed-off-by: Long Li --- Change log: v8: use new macro definition start with "MANA_" fix coding style to function definitions v9: move data definitions from earlier patch. v10: rebase to latest master branch doc/guides/nics/features/mana.in

[Patch v10 05/18] net/mana: support device removal interrupts

2022-10-05 Thread longli
From: Long Li MANA supports PCI hot plug events. Add this interrupt to DPDK core so its parent PMD can detect device removal during Azure servicing or live migration. Signed-off-by: Long Li --- Change log: v8: fix coding style of function definitions. v9: remove unused data fields. doc/guides

[Patch v10 04/18] net/mana: support link update

2022-10-05 Thread longli
From: Long Li The carrier state is managed by the Azure host. MANA runs as a VF and always reports "up". Signed-off-by: Long Li --- doc/guides/nics/features/mana.ini | 1 + drivers/net/mana/mana.c | 18 ++ 2 files changed, 19 insertions(+) diff --git a/doc/guides/ni

[Patch v10 02/18] net/mana: device configuration and stop

2022-10-05 Thread longli
From: Long Li MANA defines its memory allocation functions to override IB layer default functions to allocate device queues. This patch adds the code for device configuration and stop. Signed-off-by: Long Li --- v2: Removed validation for offload settings in mana_dev_configure(). v8: Fix coding

[Patch v10 03/18] net/mana: report supported ptypes

2022-10-05 Thread longli
From: Long Li Report supported protocol types. Signed-off-by: Long Li --- Change log. v7: change link_speed to RTE_ETH_SPEED_NUM_100G drivers/net/mana/mana.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c index f5084b4a

[Patch v10 01/18] net/mana: add basic driver with build environment and doc

2022-10-05 Thread longli
From: Long Li MANA is a PCI device. It uses IB verbs to access hardware through the kernel RDMA layer. This patch introduces build environment and basic device probe functions. Signed-off-by: Long Li --- Change log: v2: Fix typos. Make the driver build only on x86-64 and Linux. Remove unused he

[Patch v10 00/18] Introduce Microsoft Azure Network Adatper (MANA) PMD

2022-10-05 Thread longli
From: Long Li MANA is a network interface card to be used in the Azure cloud environment. MANA provides safe access to user memory through memory registration. It has IOMMU built into the hardware. MANA uses IB verbs and RDMA layer to configure hardware resources. It requires the corresponding R

Re: [PATCH] eal: fix return type of bsf safe functions

2022-10-05 Thread Tyler Retzlaff
On Wed, Oct 05, 2022 at 09:41:26PM +0200, David Marchand wrote: > On Wed, Oct 5, 2022 at 5:41 PM Thomas Monjalon wrote: > > > > In a recent commit, changing return type from int to uint32_t, > > I did a last minute change to functions rte_bsf32_safe and rte_bsf64_safe, > > because thought they wer

Re: rte_service unit test failing randomly

2022-10-05 Thread Mattias Rönnblom
On 2022-10-05 22:52, Thomas Monjalon wrote: > 05/10/2022 22:33, Mattias Rönnblom: >> On 2022-10-05 21:14, David Marchand wrote: >>> Hello, >>> >>> The service_autotest unit test has been failing randomly. >>> This is not something new. >>> We have been fixing this unit test and the service code, he

Re: [PATCH] license/README: fix pathnames and add MIT

2022-10-05 Thread Ferruh Yigit
On 10/5/2022 5:32 PM, Stephen Hemminger wrote: The pathnames in the license directory README are incorrect. The current repository puts license text in license/ not licenses/. Also, MIT license is used already in a couple of places so add the necessary entry in the README. Signed-off-by: Stephe

RE: [PATCH v7 13/14] baseband/acc: add PF configure companion function

2022-10-05 Thread Vargas, Hernan
Coding style warning is a false alarm. Acked-by: Hernan Vargas -Original Message- From: Chautru, Nicolas Sent: Thursday, September 29, 2022 4:11 PM To: dev@dpdk.org; tho...@monjalon.net Cc: maxime.coque...@redhat.com; t...@redhat.com; m...@ashroe.eu; Richardson, Bruce ; hemant.agra...

Re: rte_service unit test failing randomly

2022-10-05 Thread Thomas Monjalon
05/10/2022 22:33, Mattias Rönnblom: > On 2022-10-05 21:14, David Marchand wrote: > > Hello, > > > > The service_autotest unit test has been failing randomly. > > This is not something new. > > We have been fixing this unit test and the service code, here and there. > > For some time we were "fine"

[PATCH v3] vhost: fix build issues with GCC 12

2022-10-05 Thread Maxime Coquelin
This patch fixes a compilation issue met with GCC 12 on LoongArch64: In function ‘mbuf_to_desc’, inlined from ‘vhost_enqueue_async_packed’ at ../../../dpdk/lib/vhost/virtio_net.c:1822:6, inlined from ‘virtio_dev_rx_async_packed’ at ../../../dpdk/lib/vhost/virtio_net.c:1836:6, inlined

Re: rte_service unit test failing randomly

2022-10-05 Thread Mattias Rönnblom
On 2022-10-05 21:14, David Marchand wrote: > Hello, > > The service_autotest unit test has been failing randomly. > This is not something new. > We have been fixing this unit test and the service code, here and there. > For some time we were "fine": the failures were rare. > > But recenly (for th

Re: [PATCH 1/2] kni: flag deprecated status at build time

2022-10-05 Thread David Marchand
On Wed, Oct 5, 2022 at 4:35 PM Bruce Richardson wrote: > > To ensure all users are aware of KNI's deprecated status at build time > we can take the following actions: > > 1. disable the library by default. It can be re-enabled by setting >disabled_libs to the empty string (or other string not

Re: [PATCH] eal: fix return type of bsf safe functions

2022-10-05 Thread David Marchand
On Wed, Oct 5, 2022 at 5:41 PM Thomas Monjalon wrote: > > In a recent commit, changing return type from int to uint32_t, > I did a last minute change to functions rte_bsf32_safe and rte_bsf64_safe, > because thought they were forgotten. > Actually these functions are returning 0 or 1, so it should

Re: [PATCH] remove prefix to some local macros in apps and examples

2022-10-05 Thread David Marchand
On Tue, Oct 4, 2022 at 2:58 PM Ferruh Yigit wrote: > > On 10/4/2022 9:01 AM, David Marchand wrote: > > RTE_TEST_[RT]X_DESC_DEFAULT and RTE_TEST_[RT]X_DESC_MAX macros have been > > copied in a lot of app/ and examples/ code. > > Those macros are local to each program. > > > > They are not related t

Re: [PATCH] raw/skeleton: remove useless check

2022-10-05 Thread David Marchand
On Tue, Oct 4, 2022 at 10:00 AM David Marchand wrote: > > As reported by Coverity, this check is pointless since dev is already > dereferenced earlier. Besides, dev is passed by the rawdev layer and > can't be NULL. > > Note: the issue was probably present before the incriminated commit. > It is u

Re: [PATCH] net/qede/base: fix 32-bit build with GCC 12

2022-10-05 Thread David Marchand
On Tue, Oct 4, 2022 at 1:18 PM Thomas Monjalon wrote: > > A pointer is passed to a macro and it seems mistakenly referenced. > This issue is seen only when compiling with GCC 12 for 32-bit: > > drivers/net/qede/base/ecore_init_fw_funcs.c:1418:25: > error: array subscript 1 is outside array

RE: [PATCH v2] sched: Fix subport profile id not set correctly.

2022-10-05 Thread Dumitrescu, Cristian
> -Original Message- > From: Ajmera, Megha > Sent: Wednesday, October 5, 2022 6:23 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: sta...@dpdk.org > Subject: [PATCH v2] sched: Fix subport profile id not set correctly. > > In rte_sched_subport_config() API, subpo

rte_service unit test failing randomly

2022-10-05 Thread David Marchand
Hello, The service_autotest unit test has been failing randomly. This is not something new. We have been fixing this unit test and the service code, here and there. For some time we were "fine": the failures were rare. But recenly (for the last two weeks at least), it started failing more frequen

[PATCH v3] sched: subport field is unused in hqos profile

2022-10-05 Thread Megha Ajmera
Removed unused subport field from profile.cfg Correctly using subport profile id in subport config load. Fixes: 802d214dc880 ("examples/qos_sched: update subport rate dynamically") Cc: cristian.dumitre...@intel.com Signed-off-by: Megha Ajmera --- examples/qos_sched/cfg_file.c | 2 +- examples/

[PATCH v2] sched: subport field is unused in hqos profile

2022-10-05 Thread Megha Ajmera
Removed ununsed subport field from profile.cfg Correctly using subport profile id in subport config load. Fixes: 802d214dc880 ("examples/qos_sched: update subport rate dynamically") Cc: cristian.dumitre...@intel.com Signed-off-by: Megha Ajmera --- examples/qos_sched/cfg_file.c | 2 +- examples

Re: [Bug 1030] rte_malloc() and rte_free() get stuck when used with signal handler

2022-10-05 Thread Stephen Hemminger
On Mon, 13 Jun 2022 14:48:45 +0500 Sarosh Arif wrote: > Thank you for help, I'll do it this way. > > On Sat, Jun 11, 2022 at 9:25 PM Mattias Rönnblom > wrote: > > > > On 2022-06-10 08:04, Sarosh Arif wrote: > > > On Thu, Jun 9, 2022 at 8:26 PM Stephen Hemminger > > > wrote: > > >> > > >>

[PATCH v2] sched: Fix subport profile id not set correctly.

2022-10-05 Thread Megha Ajmera
In rte_sched_subport_config() API, subport_profile_id is not set correctly. Fixes: ac6fcb841b0f ("sched: update subport rate dynamically") Cc: cristian.dumitre...@intel.com Signed-off-by: Megha Ajmera --- lib/sched/rte_sched.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/sched/rte_s

[PATCH v5 5/6] test/threads: add tests for thread attributes API

2022-10-05 Thread Tyler Retzlaff
Test basic functionality and demonstrate use of following thread attributes api. Additionally, test attributes are processed when supplied to rte_thread_create(). * rte_thread_attr_init * rte_thread_attr_set_affinity * rte_thread_attr_get_affinity * rte_thread_attr_set_priority Si

[PATCH v5 6/6] test/threads: remove unit test use of pthread

2022-10-05 Thread Tyler Retzlaff
Now that rte_thread provides thread lifetime functions stop using pthread in unit tests. Signed-off-by: Tyler Retzlaff --- app/test/test_threads.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/app/test/test_threads.c b/app/test/test_threads.c index 3c22cec..e0f18e4 1

[PATCH v5 4/6] test/threads: add tests for thread lifetime API

2022-10-05 Thread Tyler Retzlaff
Test basic functionality and demonstrate use of following thread lifetime api. * rte_thread_create * rte_thread_detach * rte_thread_join Signed-off-by: Narcisa Vasile Signed-off-by: Tyler Retzlaff --- app/test/test_threads.c | 54 +++-- 1

[PATCH v5 2/6] eal: add thread lifetime management

2022-10-05 Thread Tyler Retzlaff
The *rte_thread_create()* function can optionally receive an rte_thread_attr_t object that will cause the thread to be created with the affinity and priority described by the attributes object. If no rte_thread_attr_t is passed (parameter is NULL), the default affinity and priority are used. On Wi

[PATCH v5 1/6] eal: add thread attributes

2022-10-05 Thread Tyler Retzlaff
Implement thread attributes for: * thread affinity * thread priority Implement functions for managing thread attributes. Priority is represented through an enum that allows for two levels: * RTE_THREAD_PRIORITY_NORMAL * RTE_THREAD_PRIORITY_REALTIME_CRITICAL Affinity is desc

[PATCH v5 3/6] eal: add basic rte thread ID equal API

2022-10-05 Thread Tyler Retzlaff
Add rte_thread_equal() that tests if two rte_thread_id are equal. Signed-off-by: Narcisa Vasile Signed-off-by: Tyler Retzlaff Acked-by: Chengwen Feng --- lib/eal/unix/rte_thread.c| 6 ++ lib/eal/version.map | 1 + lib/eal/windows/rte_thread.c | 6 ++ 3 files changed, 13 in

[PATCH v5 0/6] add thread lifetime and attributes API

2022-10-05 Thread Tyler Retzlaff
add rte thread lifetime and attributes api. with these api additions there is now sufficient platform abstracted thread api to remove the use of pthread in the unit tests. v5: * include errno.h in rte_thread.c since errno.h is no longer included in rte_common.h * move rte_thread_attr symbo

Re: [PATCH] examples/l2fwd-cat: fix build

2022-10-05 Thread David Marchand
On Wed, Oct 5, 2022 at 5:24 PM Kevin Traynor wrote: > > and need to be included for the build > since they were removed from . > > ../examples/l2fwd-cat/cat.c: In function ‘parse_set’: > ../examples/l2fwd-cat/cat.c:66:16: > warning: implicit declaration of function ‘isblank’ > [-Wimplicit-functi

Re: [PATCH v10 00/13] preparation for the rte_flow offload of nfp PMD

2022-10-05 Thread Ferruh Yigit
On 10/5/2022 12:34 PM, Ferruh Yigit wrote: On 9/26/2022 7:59 AM, Chaoyong He wrote: This is the first patch series to add the support of rte_flow offload for nfp PMD, includes: Add the support of flower firmware application Add the support of representor port Add the flower service infrastructur

Re: [PATCH 0/2] net/nfp: use a single struct eth_dev_ops

2022-10-05 Thread Ferruh Yigit
On 9/22/2022 2:03 PM, Niklas Söderlund wrote: Hi all, This small series aims to reduce code duplication by using a single shared struct eth_dev_ops for NFDk and NFD3. Patch 1/2 is a small bug fix that suck in when adding support for NFP3800 where the error code is not correctly propagated. Pat

Re: [PATCH v4 0/6] add thread lifetime and attributes API

2022-10-05 Thread Tyler Retzlaff
On Wed, Oct 05, 2022 at 09:11:26AM -0700, Tyler Retzlaff wrote: > hi David, > > > > > > Newly added code can go to eal_common_thread.c rather than introduce a > > new common/rte_thread.c file (or is there a rationale for this?). > > i will make this change in the next revision. if anyone does o

Re: [PATCH v2] vhost: fix compilation issue in async path

2022-10-05 Thread David Marchand
On Wed, Oct 5, 2022 at 5:36 PM Maxime Coquelin wrote: > On 10/5/22 17:11, Maxime Coquelin wrote: > > This patch fixes a compilation issue met with GCC 12 on > > LoongArch64: > > > > In function ‘mbuf_to_desc’, > > inlined from ‘vhost_enqueue_async_packed’ at > > ../../../dpdk/lib/vhost/virti

[PATCH] license/README: fix pathnames and add MIT

2022-10-05 Thread Stephen Hemminger
The pathnames in the license directory README are incorrect. The current repository puts license text in license/ not licenses/. Also, MIT license is used already in a couple of places so add the necessary entry in the README. Signed-off-by: Stephen Hemminger --- license/README | 12 ---

[PATCH v8 3/3] test/power: add unit tests for uncore API

2022-10-05 Thread Tadhg Kearney
Add basic unit tests covering all nine uncore API's. Signed-off-by: Tadhg Kearney Reviewed-by: David Hunt Acked-by: David Hunt --- app/test/meson.build | 2 + app/test/test_power_intel_uncore.c | 301 + 2 files changed, 303 insertions(+) create mode

[PATCH v8 2/3] l3fwd-power: add option to call uncore API

2022-10-05 Thread Tadhg Kearney
Add option for setting uncore frequency min/max/index, through uncore API. This will be set for each package and die on the SKU. On exit, uncore min and max frequency will be reverted back to previous frequencies. Signed-off-by: Tadhg Kearney Reviewed-by: David Hunt Acked-by: David Hunt --- ..

[PATCH v8 1/3] power: add Intel uncore frequency control API to power library

2022-10-05 Thread Tadhg Kearney
Add API to allow uncore frequency adjustment. Uncore is a term used by Intel to describe function of a microprocessor that are closely connected to the core to achieve high performance. This is done through manipulating related uncore frequency control sysfs entries to adjust the minimum and maximu

[PATCH v8 0/3] add Intel uncore api to be called through l3fwd-power

2022-10-05 Thread Tadhg Kearney
This is targeting 22.11 and aims to add an API to DPDK power library to allow uncore frequency adjustment. This will be called through the l3fwd-power app and gives the ability to set the minimum and maximum uncore frequency to both min, max or specific frequency index. Signed-off-by: tadhgkearney

Re: [PATCH v4 0/6] add thread lifetime and attributes API

2022-10-05 Thread Tyler Retzlaff
hi David, On Wed, Sep 21, 2022 at 10:15:36AM +0200, David Marchand wrote: > On Mon, Jun 27, 2022 at 6:56 PM Tyler Retzlaff > wrote: > > > > add rte thread lifetime and attributes api. with these api additions > > there is now sufficient platform abstracted thread api to remove the > > use of pthr

Re: [PATCH] net/nfp: fix memory leak for receive function

2022-10-05 Thread Ferruh Yigit
On 9/22/2022 2:09 PM, Niklas Söderlund wrote: From: Long Wu nfp_net_recv_pkts() should not return a value that less than 0 and the inappropriate return value in receive loop also causes the memory leak. Modify code to avoid return a value less than 0. Furthermore, When nfp_net_recv_pkts() break

[PATCH] eal: fix return type of bsf safe functions

2022-10-05 Thread Thomas Monjalon
In a recent commit, changing return type from int to uint32_t, I did a last minute change to functions rte_bsf32_safe and rte_bsf64_safe, because thought they were forgotten. Actually these functions are returning 0 or 1, so it should be int. The return type is reverted to the original type for the

Re: [PATCH v2] vhost: fix compilation issue in async path

2022-10-05 Thread Maxime Coquelin
On 10/5/22 17:11, Maxime Coquelin wrote: This patch fixes a compilation issue met with GCC 12 on LoongArch64: In function ‘mbuf_to_desc’, inlined from ‘vhost_enqueue_async_packed’ at ../../../dpdk/lib/vhost/virtio_net.c:1822:6, inlined from ‘virtio_dev_rx_async_packed’ at ../../..

[PATCH v8 4/4] net/ice: support buffer split in Rx path

2022-10-05 Thread Yuan Wang
This patch adds support for protocol based buffer split in normal Rx data paths. When the Rx queue is configured with specific protocol type, packets received will be directly split into protocol header and payload parts limitation of pmd. And the two parts will be put into different mempools. Cur

[PATCH v8 3/4] app/testpmd: add rxhdrs commands and parameters

2022-10-05 Thread Yuan Wang
Add command line parameter: --rxhdrs=eth[,ipv4,udp] Set the protocol_hdr of segments to scatter packets on receiving if split feature is engaged. And the queues with BUFFER_SPLIT flag. Add interactive mode command: testpmd>set rxhdrs eth,ipv4,udp (protocol sequence should be valid) The protocol

[PATCH v8 2/4] ethdev: introduce protocol hdr based buffer split

2022-10-05 Thread Yuan Wang
Currently, Rx buffer split supports length based split. With Rx queue offload RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT enabled and Rx packet segment configured, PMD will be able to split the received packets into multiple segments. However, length based buffer split is not suitable for NICs that do split b

[PATCH v8 1/4] ethdev: introduce protocol header API

2022-10-05 Thread Yuan Wang
Add a new ethdev API to retrieve supported protocol headers of a PMD, which helps to configure protocol header based buffer split. Signed-off-by: Yuan Wang Signed-off-by: Xuan Ding Signed-off-by: Wenxuan Wu Reviewed-by: Andrew Rybchenko --- doc/guides/rel_notes/release_22_11.rst | 5 li

[PATCH v8 0/4] support protocol based buffer split

2022-10-05 Thread Yuan Wang
Protocol type based buffer split consists of splitting a received packet into several separate segments based on the packet content. It is useful in some scenarios, such as GPU acceleration. The splitting will help to enable true zero copy and hence improve the performance significantly. This patc

Re: [PATCH] examples/l2fwd-cat: fix build

2022-10-05 Thread David Marchand
On Wed, Oct 5, 2022 at 5:24 PM Kevin Traynor wrote: > > and need to be included for the build > since they were removed from . > > ../examples/l2fwd-cat/cat.c: In function ‘parse_set’: > ../examples/l2fwd-cat/cat.c:66:16: > warning: implicit declaration of function ‘isblank’ > [-Wimplicit-functi

[PATCH] examples/l2fwd-cat: fix build

2022-10-05 Thread Kevin Traynor
and need to be included for the build since they were removed from . ../examples/l2fwd-cat/cat.c: In function ‘parse_set’: ../examples/l2fwd-cat/cat.c:66:16: warning: implicit declaration of function ‘isblank’ [-Wimplicit-function-declaration] 66 | while (isblank(*str)) |

Re: [PATCH 2/3] eal: change rte_fls and rte_bsf to return uint32_t

2022-10-05 Thread Thomas Monjalon
05/10/2022 17:15, Tyler Retzlaff: > On Wed, Oct 05, 2022 at 11:02:45AM +0200, Thomas Monjalon wrote: > > 08/08/2022 23:21, Tyler Retzlaff: > > > From: Tyler Retzlaff > > > > > > > You forgot the _safe versions: > > > > > --- a/lib/eal/include/rte_common.h > > +++ b/lib/eal/include/rte_common.h

Re: [PATCH 2/3] eal: change rte_fls and rte_bsf to return uint32_t

2022-10-05 Thread Tyler Retzlaff
On Wed, Oct 05, 2022 at 11:02:45AM +0200, Thomas Monjalon wrote: > 08/08/2022 23:21, Tyler Retzlaff: > > From: Tyler Retzlaff > > > > You forgot the _safe versions: > > --- a/lib/eal/include/rte_common.h > +++ b/lib/eal/include/rte_common.h > @@ -660,7 +660,7 @@ rte_bsf32(uint32_t v) > * @re

[PATCH v2] vhost: fix compilation issue in async path

2022-10-05 Thread Maxime Coquelin
This patch fixes a compilation issue met with GCC 12 on LoongArch64: In function ‘mbuf_to_desc’, inlined from ‘vhost_enqueue_async_packed’ at ../../../dpdk/lib/vhost/virtio_net.c:1822:6, inlined from ‘virtio_dev_rx_async_packed’ at ../../../dpdk/lib/vhost/virtio_net.c:1836:6, inlined

Re: [PATCH] vhost: fix compilation issue in async path

2022-10-05 Thread Maxime Coquelin
On 10/5/22 16:56, David Marchand wrote: On Wed, Oct 5, 2022 at 4:49 PM Maxime Coquelin wrote: This patch fixes a compilation issue met with GCC on GCC 12 (it is worth detailing, since I and Thomas hit the same issue on some other cross compiling toolchains using GCC 12). Loongarch64:

Re: [PATCH v3 1/2] vhost: check for nr_vec == 0 in desc_to_mbuf, mbuf_to_desc

2022-10-05 Thread Maxime Coquelin
On 8/2/22 02:49, Claudio Fontana wrote: in virtio_dev_split we cannot currently call desc_to_mbuf with nr_vec == 0, or we end up trying to rte_memcpy from a source address buf_vec[0] that is an uninitialized stack variable. Improve this in general by having desc_to_mbuf and mbuf_to_desc retur

Re: [PATCH] vhost: fix compilation issue in async path

2022-10-05 Thread David Marchand
On Wed, Oct 5, 2022 at 4:49 PM Maxime Coquelin wrote: > > This patch fixes a compilation issue met with GCC on GCC 12 (it is worth detailing, since I and Thomas hit the same issue on some other cross compiling toolchains using GCC 12). > Loongarch64: LoongArch64 > > In function ‘mbuf_to_desc’,

Re: [PATCH v2] vhost: fix build

2022-10-05 Thread Maxime Coquelin
Hi Min, On 9/26/22 05:25, zhoumin wrote: Hi Chenbo, On Mon, 26 Sep 2022, 10:57, Xia, Chenbo wrote: Hi Min, -Original Message- From: Min Zhou Sent: Monday, August 29, 2022 4:29 PM To: david.march...@redhat.com; maxime.coque...@redhat.com; Xia, Chenbo ; zhou...@loongson.cn Cc: dev@dp

[PATCH] vhost: fix compilation issue in async path

2022-10-05 Thread Maxime Coquelin
This patch fixes a compilation issue met with GCC on Loongarch64: In function ‘mbuf_to_desc’, inlined from ‘vhost_enqueue_async_packed’ at ../../../dpdk/lib/vhost/virtio_net.c:1822:6, inlined from ‘virtio_dev_rx_async_packed’ at ../../../dpdk/lib/vhost/virtio_net.c:1836:6, inlined fr

RE: [PATCH 1/2] kni: flag deprecated status at build time

2022-10-05 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Wednesday, 5 October 2022 16.35 > > To ensure all users are aware of KNI's deprecated status at build time > we can take the following actions: > > 1. disable the library by default. It can be re-enabled by setting >disabled

[PATCH 2/2] kni: add deprecation warning at runtime

2022-10-05 Thread Bruce Richardson
When KNI is being used at runtime, output a warning message about its deprecated status. This is part of the deprecation process for KNI agreed by the DPDK technical board.[1] [1] http://mails.dpdk.org/archives/dev/2022-June/243596.html Signed-off-by: Bruce Richardson --- doc/guides/rel_notes/d

[PATCH 1/2] kni: flag deprecated status at build time

2022-10-05 Thread Bruce Richardson
To ensure all users are aware of KNI's deprecated status at build time we can take the following actions: 1. disable the library by default. It can be re-enabled by setting disabled_libs to the empty string (or other string not including 'kni') 2. add support for a list of deprecated libs t

Re: [PATCH 05/15] net/dpaa2: check free enqueue descriptors before Tx

2022-10-05 Thread Ferruh Yigit
On 9/28/2022 6:25 AM, Gagandeep Singh wrote: From: brick Check if there exists free enqueue descriptors before enqueuing Tx packet. Also try to free enqueue descriptors in case they are not free. Fixes: ed1cdbed6a15 ("net/dpaa2: support multiple Tx queues enqueue for ordered") Cc: sta...@dpdk

Re: [PATCH 00/15] DPAA and DPAA2 driver changes

2022-10-05 Thread Ferruh Yigit
On 9/28/2022 6:25 AM, Gagandeep Singh wrote: This series have list of patch for bug fixes and some enhancements to DPAA1 and DPAA2 net drivers. Apeksha Gupta (2): net/enetfec: fix restart issue net/enetfec: fix buffer leak issue Gagandeep Singh (7): net/dpaa: support ESP packet type in

Re: [PATCH 11/15] bus/dpaa: pass interface name as a string instead of pointer

2022-10-05 Thread Ferruh Yigit
On 9/28/2022 6:25 AM, Gagandeep Singh wrote: From: Rohit Raj Due to change in latest kernel, passing the interface name to kernel through IOCTL as string instead of character pointer. This kernel component is the one that is delivered part of SDK I assume, instead of an upstreamed one. Wh

Re: [PATCH 15/15] net/dpaa: fix buffer free in slow path

2022-10-05 Thread Ferruh Yigit
On 9/28/2022 6:25 AM, Gagandeep Singh wrote: Adding a check in slow path to free those buffers which are not external. Can you please explain what was the error before fix, what was happening when you try to free all mbufs? Also it seems previous logic was different, with 'prev_seg' etc, ca

Re: [PATCH 07/15] net/dpaa2: use internal mempool for SG table

2022-10-05 Thread Ferruh Yigit
On 9/28/2022 6:25 AM, Gagandeep Singh wrote: Creating and using driver's mempool for allocating the SG table memory required for FD creation instead of relying on user mempool. As far as I can see this is in the Tx path, can you please explain why driver need an internal pktmbuf pool? And s

Re: [PATCH 06/15] net/dpaa: support ESP packet type in packet parsing

2022-10-05 Thread Ferruh Yigit
On 9/28/2022 6:25 AM, Gagandeep Singh wrote: Add support of ESP packet type in packet receive path. Signed-off-by: Gagandeep Singh --- drivers/net/dpaa/dpaa_rxtx.c | 10 ++ drivers/net/dpaa/dpaa_rxtx.h | 6 ++ 2 files changed, 16 insertions(+) diff --git a/drivers/net/dpaa/dpa

Re: [PATCH v7 0/4] Add lcore poll busyness telemetry

2022-10-05 Thread Kevin Laatz
On 14/09/2022 10:29, Kevin Laatz wrote: Currently, there is no way to measure lcore polling busyness in a passive way, without any modifications to the application. This patchset adds a new EAL API that will be able to passively track core polling busyness. As part of the set, new telemetry endpo

Re: [PATCH v2 0/6] Service cores performance and statistics improvements

2022-10-05 Thread David Marchand
On Wed, Oct 5, 2022 at 11:20 AM Mattias Rönnblom wrote: > > This series contains performance improvements and new statistics- > related functionality for the EAL service cores framework. > > A new per-lcore TSC cycle counter is introduced, which reflect the > total amount of cycles spent by that l

Re: [PATCH v3 2/2] service: fix potential stats race-condition on MT services

2022-10-05 Thread David Marchand
On Mon, Jul 11, 2022 at 3:18 PM Harry van Haaren wrote: > > This commit fixes a potential racey-add that could occur if > multiple service-lcores were executing the same MT-safe service > at the same time, with service statistics collection enabled. > > Because multiple threads can run and execute

  1   2   >