[Bug 1095] librte_bbdev build failure with clang 3.4.2

2022-10-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1095 Bug ID: 1095 Summary: librte_bbdev build failure with clang 3.4.2 Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[PATCH] net/nfp: set the appropriate initialized value of flbufsz

2022-10-09 Thread Chaoyong He
From: Peng Zhang When the testpmd app start-up with parameter max-pkt-len, it will set MTU. But the initialized value of flubfsz is inappropriate, if the value of flbufsz is smaller than the valude of max-pkt-len, the testpmd app will start fail. Fixes: 5c305e218f15 ("net/nfp: fix initialization

[PATCH v4] eal: non-temporal memcpy

2022-10-09 Thread Morten Brørup
This patch provides a function for memory copy using non-temporal store, load or both, controlled by flags passed to the function. Applications sometimes copy data to another memory location, which is only used much later. In this case, it is inefficient to pollute the data cache with the copied d

RE: [PATCH v3 1/4] ethdev: add trace points

2022-10-09 Thread Ankur Dwivedi
Hi All, >-Original Message- >From: Ankur Dwivedi >Sent: Friday, October 7, 2022 9:54 PM >To: dev@dpdk.org; Morten Brørup >Cc: tho...@monjalon.net; m...@ashroe.eu; or...@nvidia.com; >ferruh.yi...@xilinx.com; ch...@att.com; humi...@huawei.com; >linvi...@tuxdriver.com; ciara.lof...@intel.com

[PATCH] net/nfp: add the feature of RSS based on VXLAN inner layer

2022-10-09 Thread Chaoyong He
Add the logics to support the feature of RSS packets based on the inner layer of VXLAN tunnel. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund Depends-on: series-24819 ("preparation for the rte_flow offload of nfp PMD") --- drivers/net/nfp/flower/nfp_flower.c | 2 +- dr

[PATCH v2 24/24] net/nfp: add the offload support of set IPv6 DSCP action

2022-10-09 Thread Chaoyong He
Add the corresponding logics to support the offload of set IPv6 DSCP action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 2 +- drivers/net/nfp/nfp_flow.c | 39 ++

[PATCH v2 23/24] net/nfp: add the offload support of set IPv4 DSCP action

2022-10-09 Thread Chaoyong He
Add the corresponding logics to support the offload of set IPv4 DSCP action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/nfp/nfp_flow.c | 39 +++

[PATCH v2 22/24] net/nfp: add the offload support of set TTL action

2022-10-09 Thread Chaoyong He
Add the corresponding data structure and logics, to support the offload of set TTL action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/nfp/flower/nfp_flower_cmsg.h | 44

[PATCH v2 21/24] net/nfp: add the offload support of set TP DST port action

2022-10-09 Thread Chaoyong He
Add the corresponding logics to support the offload of set TP dest port action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/nfp/nfp_flow.c | 15 +++

[PATCH v2 20/24] net/nfp: add the offload support of set TP SRC port action

2022-10-09 Thread Chaoyong He
Add the corresponding data structure and logics, to support the offload of set TP source port action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + drivers/net/nfp/flower/nfp_flower_cmsg.h | 21 +++ drivers/net/nfp/nfp_

[PATCH v2 19/24] net/nfp: add the offload support of set DST IPv6 action

2022-10-09 Thread Chaoyong He
Add the corresponding logics to support the offload of set dest IPv6 address action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 2 +- drivers/net/nfp/nfp_flow.c | 9 + 3

[PATCH v2 18/24] net/nfp: add the offload support of set SRC IPv6 action

2022-10-09 Thread Chaoyong He
Add the corresponding data structure and logics, to support the offload of set source IPv6 address action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + drivers/net/nfp/flower/nfp_flower_cmsg.h | 33 ++

[PATCH v2 17/24] net/nfp: add the offload support of set DST IPv4 action

2022-10-09 Thread Chaoyong He
Add the corresponding logics to support the offload of set dest IPv4 address action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/nfp/nfp_flow.c | 16 +++

[PATCH v2 16/24] net/nfp: add the offload support of set SRC IPv4 action

2022-10-09 Thread Chaoyong He
Add the corresponding data structure and logics, to support the offload of set source IPv4 address action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + drivers/net/nfp/flower/nfp_flower_cmsg.h | 25 ++ drivers/net/

[PATCH v2 15/24] net/nfp: add the offload support of push VLAN action

2022-10-09 Thread Chaoyong He
Add the corresponding data structure and logics, to support the offload of push_vlan action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 3 ++ doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/nfp/flower/nfp_flower_cmsg.h |

[PATCH v2 14/24] net/nfp: add the offload support of pop VLAN action

2022-10-09 Thread Chaoyong He
Add the corresponding data structure and logics, to support the offload of pop_vlan action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + drivers/net/nfp/flower/nfp_flower_cmsg.h | 5 + drivers/net/nfp/nfp_flow.c

[PATCH v2 13/24] net/nfp: add the offload support of set DST MAC action

2022-10-09 Thread Chaoyong He
Add the corresponding logics to support the offload of set dest MAC action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/nfp/nfp_flow.c | 15 +++ 3 f

[PATCH v2 12/24] net/nfp: add the offload support of set SRC MAC action

2022-10-09 Thread Chaoyong He
Add the corresponding data structure and logics, to support the offload of set source MAC action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + drivers/net/nfp/flower/nfp_flower_cmsg.h | 27 ++ drivers/net/nfp/nfp_f

[PATCH v2 11/24] net/nfp: add the offload support of SCTP item

2022-10-09 Thread Chaoyong He
Add the corresponding logics to support the offload of SCTP item. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/nfp/nfp_flow.c | 63 ++

[PATCH v2 10/24] net/nfp: add the offload support of UDP item

2022-10-09 Thread Chaoyong He
Add the corresponding logics to support the offload of UDP item. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/nfp/nfp_flow.c | 63 +++

[PATCH v2 09/24] net/nfp: add the offload support of TCP item

2022-10-09 Thread Chaoyong He
Add the corresponding data structure and logics, to support the offload of TCP item. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/nfp/nfp_flow.c | 91 +++

[PATCH v2 08/24] net/nfp: add the offload support of IPv6 item

2022-10-09 Thread Chaoyong He
Add the corresponding data structure and logics, to support the offload of IPv6 item. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 2 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/nfp/flower/nfp_flower_cmsg.h | 33

[PATCH v2 07/24] net/nfp: add the offload support of IPv4 item

2022-10-09 Thread Chaoyong He
Add the corresponding data structure and logics, to support the offload of IPv4 item. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/nfp/flower/nfp_flower_cmsg.h | 38

[PATCH v2 06/24] net/nfp: add the offload support of VLAN item

2022-10-09 Thread Chaoyong He
Add the corresponding data structure and logics, to support the offload of VLAN item. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/nfp/nfp_flow.c | 46 ++

[PATCH v2 05/24] net/nfp: add the offload support of basic actions

2022-10-09 Thread Chaoyong He
Add the offload support of very basic actions: mark, rss, count, drop and output. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 6 ++ doc/guides/rel_notes/release_22_11.rst | 6 ++ drivers/net/nfp/flower/nfp_flower_cmsg.h | 11 +++

[PATCH v2 04/24] net/nfp: add the offload support of basic items

2022-10-09 Thread Chaoyong He
Add the offload support of very basic items: ethernet and port id. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 4 + doc/guides/rel_notes/release_22_11.rst | 4 + drivers/net/nfp/flower/nfp_flower_cmsg.h | 20 +++ drivers/net/nfp

[PATCH v2 03/24] net/nfp: add the flow APIs of nfp PMD

2022-10-09 Thread Chaoyong He
Add the flow validate/create/query/destroy/flush API of nfp PMD. The flow create API construct a control cmsg and send it to firmware, then add this flow to the hash table. The flow query API get flow stats from the flow_priv structure. Note there exist an rte_spin_lock to prevent the update and

[PATCH v2 02/24] net/nfp: add the structures and functions for flow offload

2022-10-09 Thread Chaoyong He
Add the structures and functions to process mask table, flow table, and flow stats id, which are used in the rte_flow offload logics. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/flower/nfp_flower.c | 11 +- drivers/net/nfp/meson.build | 3 + drivers/n

[PATCH v2 01/24] net/nfp: add the stats process logic in ctrl VNIC service

2022-10-09 Thread Chaoyong He
Add the flow stats process logic in the ctrl VNIC service. The flower firmware pass the flow stats to nfp driver through control message, we store them in the flow_priv structure. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/flower/nfp_flower.h | 2 + drive

[PATCH v2 00/24] add the basic rte_flow offload support of nfp PMD

2022-10-09 Thread Chaoyong He
This is the second patch series to add the support of rte_flow offload for nfp PMD, includes: Implement the rte_flow related API Implement the offload framework of nfp card Add the offload support of common rte_flow pattern items Add the offload support of common rte_flow actions * Changes since v

RE: [PATCH v2] build: increase minimum meson version to 0.53.2

2022-10-09 Thread Tu, Lijuan
> -Original Message- > From: David Marchand > Sent: Saturday, October 8, 2022 3:13 AM > To: Richardson, Bruce ; Thomas Monjalon > > Cc: dev@dpdk.org; c...@dpdk.org; Lincoln Lavoie ; Tu, > Lijuan ; Chen, Zhaoyan ; > Mcnamara, John > Subject: Re: [PATCH v2] build: increase minimum meson

RE: [PATCH v3] net/vhost: support asynchronous data path

2022-10-09 Thread Hu, Jiayu
Hi Chenbo and Maxime, > -Original Message- > From: Wang, YuanX > Sent: Wednesday, August 24, 2022 12:36 AM > To: maxime.coque...@redhat.com; Xia, Chenbo ; > dev@dpdk.org > Cc: Hu, Jiayu ; He, Xingguang > ; Jiang, Cheng1 ; Wang, > YuanX ; Ma, WenwuX > Subject: [PATCH v3] net/vhost: suppor

RE: [PATCH v9 0/4] support protocol based buffer split

2022-10-09 Thread Ding, Xuan
> -Original Message- > From: Andrew Rybchenko > Sent: Sunday, October 9, 2022 10:59 PM > To: Wang, YuanX ; dev@dpdk.org > Cc: tho...@monjalon.net; ferruh.yi...@xilinx.com; m...@ashroe.eu; Li, > Xiaoyun ; Singh, Aman Deep > ; Zhang, Yuying ; > Zhang, Qi Z ; Yang, Qiming ; > jerinjac...@gmai

RE: [PATCH v5 0/2] introduce NitroSketch Mode into membership library

2022-10-09 Thread Rong, Leyi
> -Original Message- > From: Thomas Monjalon > Sent: Monday, October 10, 2022 7:13 AM > To: Rong, Leyi > Cc: ferruh.yi...@xilinx.com; Richardson, Bruce ; > david.march...@redhat.com; suanmi...@nvidia.com; Wang, Yipeng1 > ; zaoxing...@gmail.com; Gobriel, Sameh > ; dev@dpdk.org; dev@dpdk.

RE: [PATCH v3] net/iavf: fix error of virtchnl command

2022-10-09 Thread Zhou, YidingX
> > This commit starts a thread to handle all events to fix this issue. > > > > Fixes: 48de41ca11f0 ("net/avf: enable link status update") > > CC: sta...@dpdk.org > > > > Signed-off-by: Yiding Zhou > > --- > > + > > static uint32_t > > iavf_convert_link_speed(enum virtchnl_link_speed virt_link

RE: [PATCH 0/2] net/ixgbe: fixes related to promiscuous mode in VFs

2022-10-09 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Wenjun1 > Sent: Monday, October 10, 2022 9:37 AM > To: Matz, Olivier ; dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Zhao1, Wei ; > sta...@dpdk.org > Subject: RE: [PATCH 0/2] net/ixgbe: fixes related to promiscuous mode in VFs > > > > > -Origin

RE: [PATCH 0/2] net/ixgbe: fixes related to promiscuous mode in VFs

2022-10-09 Thread Wu, Wenjun1
> -Original Message- > From: Olivier Matz > Sent: Thursday, September 29, 2022 8:09 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Wu, Wenjun1 > ; Zhang, Qi Z ; Zhao1, Wei > ; sta...@dpdk.org > Subject: [PATCH 0/2] net/ixgbe: fixes related to promiscuous mode in VFs > > These 2 patches have

RE: [PATCH] net/ixgbevf: fix promiscuous and allmulti

2022-10-09 Thread Wu, Wenjun1
Hi Olivier, > -Original Message- > From: Olivier Matz > Sent: Thursday, September 29, 2022 8:22 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Wu, Wenjun1 > ; Zhao1, Wei > Subject: [PATCH] net/ixgbevf: fix promiscuous and allmulti > > The configuration of allmulti and promiscuous modes conf

Re: [PATCH v2] power: add unpriv. read of turbo % for pstate

2022-10-09 Thread Thomas Monjalon
25/08/2022 20:22, Markus Theil: > If DPDK applications should be used with a minimal set of privileges, > using the msr kernel module on linux should not be necessary. > > Since at least kernel 4.4 the rdmsr call to obtain the last non-turbo > boost frequency can be left out, if the sysfs interfac

Re: [PATCH v3] pcapng: fix write more packets than IOV_MAX limit

2022-10-09 Thread Thomas Monjalon
01/08/2022 17:33, Stephen Hemminger: > On Mon, 1 Aug 2022 10:40:56 +0200 > Mário Kuka wrote: > > > The rte_pcapng_write_packets() function fails when we try to write more > > packets than the IOV_MAX limit. writev() system call is limited by the > > IOV_MAX limit. The iovcnt argument is valid if

Re: [PATCH] apps/dumpcap: fix interface parameter option

2022-10-09 Thread Thomas Monjalon
22/08/2022 01:56, Ben Magistro: > The dumpcap application supports an interface parameter via the > `-i` [1] option however the current documentation utilizes a `-I` flag. > > [1] https://git.dpdk.org/dpdk/tree/app/dumpcap/main.c#n314 > > Fixes: cbb44143be74 ("app/dumpcap: add new packet capture

Re: [PATCH] dumpcap: fix list interfaces

2022-10-09 Thread Thomas Monjalon
> Acked-by: Reshma Pattan Applied, thanks.

Re: [PATCH v2] eal: fix data race in multi-process support

2022-10-09 Thread Thomas Monjalon
06/09/2022 18:45, Stephen Hemminger: > If DPDK is built with thread sanitizer it reports a race > in setting of multiprocess file descriptor. The fix is to > use atomic operations when updating mp_fd. > > Build: > $ meson -Db_sanitize=address build > $ ninja -C build > > Simple example: > $ .buil

Re: [PATCH v5 0/2] introduce NitroSketch Mode into membership library

2022-10-09 Thread Thomas Monjalon
16/09/2022 05:03, Leyi Rong: > This patchset introduce a brand new NitroSketch Mode into membership > library. This algorithm provides high-fidelity approximate measurements > and appears as a promissing alternative to triditional approches such as > packet sampling. [...] > Leyi Rong (2): > memb

[PATCH] doc: add Rx buffer split capability for mlx5

2022-10-09 Thread Thomas Monjalon
When adding buffer split feature to mlx in DPDK 20.11, it has been forgotten to fill the feature matrix. Fixes: 6c8f7f1c1877 ("net/mlx5: report Rx buffer split capabilities") Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon --- doc/guides/nics/features/mlx5.ini | 1 + 1 file changed, 1 insert

[PATCH] examples/l2fwd-crypto: fix typo in error message

2022-10-09 Thread Ali Alnubani
Fixes spelling in one of the app's exit messages. Fixes: 387259bd6c67 ("examples/l2fwd-crypto: add sample application") Cc: declan.dohe...@intel.com Cc: sta...@dpdk.org Signed-off-by: Ali Alnubani --- examples/l2fwd-crypto/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 1/2] net/bonding: fix xmit l34 hash calculate for tcp

2022-10-09 Thread Thomas Monjalon
> > In the following two cases, tcp_hdr + sizeof(*tcp_hdr) == pkt_end, > > and the TCP port is not taken into account in calculating the HASH > > value of TCP packets. TCP connections with the same source and > > destination IP addresses will be hashed to the same slave port, > > which may cause lo

Re: [PATCH] doc: clarify deprecation status for flow actions PF and VF

2022-10-09 Thread Thomas Monjalon
05/10/2022 13:32, Ivan Malov: > These actions have been deprecated since DPDK 21.11 as > ambiguous and hard-to-use, but their removal might not > be popular because net drivers i40e, ixgbe and txgbe > employ these actions in complicated "PF/VF + QUEUE" > tunnel rule support. Maintainers of these dr

Re: [PATCH] gro: fix gro with ethernet tail padding bytes

2022-10-09 Thread Thomas Monjalon
15/08/2022 03:27, Hu, Jiayu: > From: Jun Qiu > > > > I don't think the stack(software) cares if the length of a packet is less > > than 60, > > especially when receiving it. > > In the linux kernel, if the packet length does not match the IP > > total-length, > > the packet is flushed to the st

Re: [PATCH] net/softnic: remove maintainer

2022-10-09 Thread Thomas Monjalon
03/10/2022 21:59, Jasvinder Singh: > I am removing myself as the maintainer. > > Signed-off-by: Jasvinder Singh Applied and squashed with sched.

Re: [PATCH] sched: remove maintainer

2022-10-09 Thread Thomas Monjalon
03/10/2022 21:59, Jasvinder Singh: > I am removing myself as the maintainer of the sched library. > > Signed-off-by: Jasvinder Singh Applied and squashed with softnic.

Re: [PATCH] doc: remove DPAA2 cmdif raw driver deprecation notice

2022-10-09 Thread Thomas Monjalon
03/10/2022 07:00, Gagandeep Singh: > In commit [1], It was announced to remove the DPAA2 cmdif > raw driver as there was no active user known at that time. > But now, one of the DPAA2 user has objected this driver > removal so in this patch, removing the deprecation notice > for the driver. > > [1

Re: [PATCH] doc: remove deprecation for inline IPsec events

2022-10-09 Thread Thomas Monjalon
02/10/2022 21:03, Akhil Goyal: > The IPsec SA expiry events were added as per below patch, > but the deprecation notice was not removed. This patch removed it. > > Fixes: d1ce79d14ba1 ("ethdev: add IPsec SA expiry event subtypes") > > Signed-off-by: Akhil Goyal Applied, thanks.

Re: [EXT] [dpdk-dev v5] lib/cryptodev: multi-process IPC request handler

2022-10-09 Thread Zhang, Fan
Hi Akhil, On 06/10/2022 19:49, Akhil Goyal wrote: As some cryptode PMDs have multiprocess support, the secondary process needs queue-pair to be configured by the primary process before to use. This patch adds an IPC register function to help the primary process to register IPC action that allow

[PATCH v2] linux/igb_uio: fix build with kernel 5.18+

2022-10-09 Thread Georg Müller
pci_set_dma_mask() and pci_set_consistent_dma_mask() were removed with kernel 5.18. They both were just wrappers for dma_set_mask() and dma_set_coherent_mask(). Instead, use dma_set_mask_and_coherent(), which is a combination of dma_set_mask() and dma_set_coherent_mask(). dma_set_mask_and_coheren

RE: [RFC v2] non-temporal memcpy

2022-10-09 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Tuesday, 9 August 2022 13.53 > > On 2022-08-09 11:24, Morten Brørup wrote: > >> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > >> Sent: Sunday, 7 August 2022 22.41 > >> > >> On 2022-07-29 18:05, Stephen Hemminger wrote: > >>>

[PATCH v3] eal: non-temporal memcpy

2022-10-09 Thread Morten Brørup
This patch provides a function for memory copy using non-temporal store, load or both, controlled by flags passed to the function. Applications sometimes copy data to another memory location, which is only used much later. In this case, it is inefficient to pollute the data cache with the copied d

RE: [PATCH v6 3/4] mempool: fix cache flushing algorithm

2022-10-09 Thread Morten Brørup
> From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru] > Sent: Sunday, 9 October 2022 16.52 > > On 10/9/22 17:31, Morten Brørup wrote: > >> From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru] > >> Sent: Sunday, 9 October 2022 15.38 > >> > >> From: Morten Brørup > >> [...] > >

Re: [PATCH v9 0/4] support protocol based buffer split

2022-10-09 Thread Andrew Rybchenko
On 10/9/22 23:25, Yuan Wang wrote: Protocol type based buffer split consists of splitting a received packet into several separate segments based on the packet content. It is useful in some scenarios, such as GPU acceleration. The splitting will help to enable true zero copy and hence improve the

Re: [PATCH v6 3/4] mempool: fix cache flushing algorithm

2022-10-09 Thread Andrew Rybchenko
On 10/9/22 17:31, Morten Brørup wrote: From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru] Sent: Sunday, 9 October 2022 15.38 From: Morten Brørup Fix the rte_mempool_do_generic_put() caching flushing algorithm to keep hot objects in cache instead of cold ones. The algorithm was: 1

RE: [PATCH v6 4/4] mempool: flush cache completely on overflow

2022-10-09 Thread Morten Brørup
> From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru] > Sent: Sunday, 9 October 2022 15.38 > To: Olivier Matz > Cc: dev@dpdk.org; Morten Brørup; Bruce Richardson > Subject: [PATCH v6 4/4] mempool: flush cache completely on overflow > > The cache was still full after flushing. In the oppo

Re: [PATCH] regex/mlx5: add check for nb max matches

2022-10-09 Thread Thomas Monjalon
01/09/2022 10:28, Gerry Gribbon: > Added check so user gets error if they try to configure the > nb_max_matches value when using rte_regexdev_configure(). > > Signed-off-by: Gerry Gribbon > Acked-by: Ori Kam Applied, thanks. Note the more explicit title on merge: regex/mlx5: forbid changing ma

RE: [PATCH v6 3/4] mempool: fix cache flushing algorithm

2022-10-09 Thread Morten Brørup
> From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru] > Sent: Sunday, 9 October 2022 15.38 > > From: Morten Brørup > > Fix the rte_mempool_do_generic_put() caching flushing algorithm to > keep hot objects in cache instead of cold ones. > > The algorithm was: > 1. Add the objects to t

Re: [PATCH] regex/mlx5: add support for combined rof file

2022-10-09 Thread Thomas Monjalon
01/09/2022 10:24, Gerry Gribbon: > Added support to allow parsing of a combined rof file to > locate compatible binary rof data for the Bluefield hardware > being run on. > > Signed-off-by: Gerry Gribbon > Acked-by: Ori Kam Applied, thanks.

Re: [PATCH] net/mana: fix dependencies

2022-10-09 Thread Thomas Monjalon
09/10/2022 15:53, Thomas Monjalon: > The reason for not building is updated > to be consistent with other drivers. > > The libibverbs was not detected through pkg-config. > The method dependency() needs to be used first. > > The support in rdma-core and Linux is not released yet, > so the documen

Re: [PATCH] net/mana: fix dependencies

2022-10-09 Thread Jason Gunthorpe
I'm hopeful for 6.2, but it needs a respin I haven't seen yet. Get Outlook for Android From: Thomas Monjalon Sent: Sunday, October 9, 2022 11:03:56 AM To: NBU-Contact-longli (EXTERNAL) ; Jason Gunthorpe Cc: dev@dpdk.org ; ferruh.yi...@amd

Re: [PATCH] net/mana: fix dependencies

2022-10-09 Thread Thomas Monjalon
Long, For the reasons below, we should not have merged the MANA PMD in DPDK 22.11. We must not assume dependencies until they are upstream. This is a red flag on the PMD, a revert is possible. Jason, Please could you tell us what is the expected date of release of the MANA support in Linux and r

[PATCH] net/mana: fix dependencies

2022-10-09 Thread Thomas Monjalon
The reason for not building is updated to be consistent with other drivers. The libibverbs was not detected through pkg-config. The method dependency() needs to be used first. The support in rdma-core and Linux is not released yet, so the documentation is updated. Signed-off-by: Thomas Monjalon

[PATCH v6 4/4] mempool: flush cache completely on overflow

2022-10-09 Thread Andrew Rybchenko
The cache was still full after flushing. In the opposite direction, i.e. when getting objects from the cache, the cache is refilled to full level when it crosses the low watermark (which happens to be zero). Similarly, the cache should be flushed to empty level when it crosses the high watermark (w

[PATCH v6 3/4] mempool: fix cache flushing algorithm

2022-10-09 Thread Andrew Rybchenko
From: Morten Brørup Fix the rte_mempool_do_generic_put() caching flushing algorithm to keep hot objects in cache instead of cold ones. The algorithm was: 1. Add the objects to the cache. 2. Anything greater than the cache size (if it crosses the cache flush threshold) is flushed to the bac

[PATCH v6 2/4] mempool: avoid usage of term ring on put

2022-10-09 Thread Andrew Rybchenko
Term ring is misleading since it is the default, but still just one of possible drivers to store objects. Signed-off-by: Andrew Rybchenko Reviewed-by: Morten Brørup --- lib/mempool/rte_mempool.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/mempool/rte_mempool.

[PATCH v6 0/4] mempool: fix mempool cache flushing algorithm

2022-10-09 Thread Andrew Rybchenko
v6 changes (Andrew Rybchenko): - Fix spelling v5 changes (Andrew Rybchenko): - Factor out cosmetic fixes into separate patches to make all patches smaller and easier to review - Remove extra check as per review notes - Factor out entire cache flushing into a separate patch. It is nice from l

[PATCH v6 1/4] mempool: check driver enqueue result in one place

2022-10-09 Thread Andrew Rybchenko
Enqueue operation must not fail. Move corresponding debug check from one particular case to dequeue operation helper in order to do it for all invocations. Log critical message with useful information instead of rte_panic(). Make rte_mempool_do_generic_put() implementation more readable and fix i

Re: [PATCH v5 0/4] mempool: fix mempool cache flushing algorithm

2022-10-09 Thread Andrew Rybchenko
Sorry, forgot --in-reply-to. I'll send v6 with spelling fixes and --in-reply-to to have thread for so interesting topic complete.

[PATCH v5 4/4] mempool: flush cache completely on overflow

2022-10-09 Thread Andrew Rybchenko
The cache was still full after flushing. In the opposite direction, i.e. when getting objects from the cache, the cache is refilled to full level when it crosses the low watermark (which happens to be zero). Similarly, the cache should be flushed to empty level when it crosses the high watermark (w

[PATCH v5 3/4] mempool: fix cache flushing algorithm

2022-10-09 Thread Andrew Rybchenko
From: Morten Brørup Fix the rte_mempool_do_generic_put() caching flushing algorithm to keep hot objects in cache instead of cold ones. The algorithm was: 1. Add the objects to the cache. 2. Anything greater than the cache size (if it crosses the cache flush threshold) is flushed to the bac

[PATCH v5 1/4] mempool: check driver enqueue result in one place

2022-10-09 Thread Andrew Rybchenko
Enqueue operation must not fail. Move corresponding debug check from one particular case to dequeue operation helper in order to do it for all invocations. Log critical message with useful information instead of rte_panic(). Make rte_mempool_do_generic_put() implementation more readable and fix i

[PATCH v5 2/4] mempool: avoid usage of term ring on put

2022-10-09 Thread Andrew Rybchenko
Term ring is misleading since it is the default, but still just one of possible drivers to store objects. Signed-off-by: Andrew Rybchenko Reviewed-by: Morten Brørup --- lib/mempool/rte_mempool.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/mempool/rte_mempool.

[PATCH v5 0/4] mempool: fix mempool cache flushing algorithm

2022-10-09 Thread Andrew Rybchenko
v5 changes (Andrew Rybchenko): - Factor out cosmetic fixes into separate patches to make all patches smaller and easier to review - Remove extra check as per review notes - Factor out entire cache flushing into a separate patch. It is nice from logical changes separation point of view, easie

Re: [PATCH v4] mempool: fix mempool cache flushing algorithm

2022-10-09 Thread Andrew Rybchenko
diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h index 1e7a3c1527..e7e09e48fc 100644 --- a/lib/mempool/rte_mempool.h +++ b/lib/mempool/rte_mempool.h @@ -1344,31 +1344,41 @@ rte_mempool_do_generic_put(struct rte_mempool *mp, void * const *obj_table, if (unlikely(cache ==

Re: [PATCH] regexdev: add match mode command line parameter

2022-10-09 Thread Thomas Monjalon
01/09/2022 10:22, Gerry Gribbon: > Allows application to specify match mode to be used. > > Signed-off-by: Gerry Gribbon > Acked-by: Ori Kam > --- > app/test-regex/main.c| 38 ++-- > doc/guides/tools/testregex.rst | 3 ++ > drivers/regex/mlx5/m

Re: [PATCH 2/2] mempool: avoid usage of term ring on put

2022-10-09 Thread Andrew Rybchenko
On 10/9/22 16:08, Morten Brørup wrote: From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru] Sent: Sunday, 9 October 2022 13.12 Term ring is misleading since it is the default, but still just one of possible drivers to store objects. Signed-off-by: Andrew Rybchenko --- Reviewed-by: M

RE: [PATCH 2/2] mempool: avoid usage of term ring on put

2022-10-09 Thread Morten Brørup
> From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru] > Sent: Sunday, 9 October 2022 13.12 > > Term ring is misleading since it is the default, but still just > one of possible drivers to store objects. > > Signed-off-by: Andrew Rybchenko > --- Reviewed-by: Morten Brørup PS: The ter

RE: [PATCH 1/2] mempool: check driver enqueue result in one place

2022-10-09 Thread Morten Brørup
> From: Andrew Rybchenko [mailto:andrew.rybche...@oktetlabs.ru] > Sent: Sunday, 9 October 2022 13.12 > > Enqueue operation must not fail. Move corresponding debug check > from one particular case to dequeue operation helper in order > to do it for all invocations. > > Log critical message with us

Re: [PATCH] regexdev: display response flags value

2022-10-09 Thread Thomas Monjalon
01/09/2022 10:29, Gerry Gribbon: > Allows application user to see response flags > > Signed-off-by: Gerry Gribbon > Acked-by: Ori Kam Applied, thanks.

Re: [PATCH v2] regexdev: add maximum number of mbuf segments field

2022-10-09 Thread Thomas Monjalon
07/10/2022 10:04, Gerry Gribbon: > Allows application to query maximum number of mbuf segments that can > be chained together. > > Signed-off-by: Gerry Gribbon > Acked-by: Ori Kam Applied, thanks.

[PATCH v9 4/4] net/ice: support buffer split in Rx path

2022-10-09 Thread Yuan Wang
Add support for protocol based buffer split in normal Rx data paths. When the Rx queue is configured with specific protocol type, packets received will be directly split into protocol header and payload parts. And the two parts will be put into different mempools. Currently, protocol based buffer

[PATCH v9 3/4] app/testpmd: add rxhdrs commands and parameters

2022-10-09 Thread Yuan Wang
Add command line parameter: --rxhdrs=eth[,ipv4] Set the protocol_hdr of segments to scatter packets on receiving if split feature is engaged. And the queues with BUFFER_SPLIT flag. Add interactive mode command: testpmd>set rxhdrs eth,ipv4,ipv4-udp (protocol sequence should be valid) The protocol

[PATCH v9 2/4] ethdev: introduce protocol hdr based buffer split

2022-10-09 Thread Yuan Wang
Currently, Rx buffer split supports length based split. With Rx queue offload RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT enabled and Rx packet segment configured, PMD will be able to split the received packets into multiple segments. However, length based buffer split is not suitable for NICs that do split b

[PATCH v9 1/4] ethdev: introduce protocol header API

2022-10-09 Thread Yuan Wang
Add a new ethdev API to retrieve supported protocol headers of a PMD, which helps to configure protocol header based buffer split. Signed-off-by: Yuan Wang Signed-off-by: Xuan Ding Signed-off-by: Wenxuan Wu Reviewed-by: Andrew Rybchenko --- doc/guides/nics/features.rst | 2 +- doc/

[PATCH v9 0/4] support protocol based buffer split

2022-10-09 Thread Yuan Wang
Protocol type based buffer split consists of splitting a received packet into several separate segments based on the packet content. It is useful in some scenarios, such as GPU acceleration. The splitting will help to enable true zero copy and hence improve the performance significantly. This patc

[PATCH 2/2] mempool: avoid usage of term ring on put

2022-10-09 Thread Andrew Rybchenko
Term ring is misleading since it is the default, but still just one of possible drivers to store objects. Signed-off-by: Andrew Rybchenko --- lib/mempool/rte_mempool.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.

[PATCH 1/2] mempool: check driver enqueue result in one place

2022-10-09 Thread Andrew Rybchenko
Enqueue operation must not fail. Move corresponding debug check from one particular case to dequeue operation helper in order to do it for all invocations. Log critical message with useful information instead of rte_panic(). Make rte_mempool_do_generic_put() implementation more readable and fix i

Re: [PATCH v11 4/5] net/hns3: support proactive error handling mode

2022-10-09 Thread Dongdong Liu
On 2022/10/9 17:10, Chengwen Feng wrote: This patch supports proactive error handling mode. Signed-off-by: Chengwen Feng Acked-by: Dongdong Liu --- drivers/net/hns3/hns3_common.c | 2 ++ drivers/net/hns3/hns3_intr.c | 24 2 files changed, 26 insertions(+) di

Re: [PATCH v5 0/7] mbuf dynamic field expansion

2022-10-09 Thread Thomas Monjalon
07/10/2022 23:02, Shijith Thotton: > This is a continuation of the discussions[1] to add mbuf physical address > field to dynamic field. > Previous version was to add PA field to dynamic field area based on the EAL > IOVA mode option. It was > deemed unsafe as some components could still use the

[PATCH v11 5/5] net/bnxt: support proactive error handling mode

2022-10-09 Thread Chengwen Feng
From: Kalesh AP This patch supports proactive error handling mode. Signed-off-by: Kalesh AP Signed-off-by: Somnath Kotur Reviewed-by: Ajit Khaparde Reviewed-by: Chengwen Feng --- drivers/net/bnxt/bnxt_cpr.c| 4 drivers/net/bnxt/bnxt_ethdev.c | 13 - 2 files changed, 16

[PATCH v11 3/5] app/testpmd: support error handling mode event

2022-10-09 Thread Chengwen Feng
From: Kalesh AP This patch supports error handling mode event process. Signed-off-by: Kalesh AP Signed-off-by: Somnath Kotur Signed-off-by: Chengwen Feng Reviewed-by: Ajit Khaparde --- app/test-pmd/parameters.c | 10 -- app/test-pmd/testpmd.c| 8 +++- 2 files changed, 15 in

[PATCH v11 4/5] net/hns3: support proactive error handling mode

2022-10-09 Thread Chengwen Feng
This patch supports proactive error handling mode. Signed-off-by: Chengwen Feng --- drivers/net/hns3/hns3_common.c | 2 ++ drivers/net/hns3/hns3_intr.c | 24 2 files changed, 26 insertions(+) diff --git a/drivers/net/hns3/hns3_common.c b/drivers/net/hns3/hns3_common.

[PATCH v11 2/5] ethdev: support proactive error handling mode

2022-10-09 Thread Chengwen Feng
From: Kalesh AP Some PMDs (e.g. hns3) could detect hardware or firmware errors, and try to recover from the errors. In this process, the PMD sets the data path pointers to dummy functions (which will prevent the crash), and also make sure the control path operations failed with retcode -EBUSY. T

[PATCH v11 1/5] ethdev: support get port error handling mode

2022-10-09 Thread Chengwen Feng
This patch support gets port's error handling mode by rte_eth_dev_info_get() API. Currently, the defined modes include: 1) NONE: it means no error handling modes are supported by this port. 2) PASSIVE: passive error handling, after the PMD detect that a reset is required, the PMD reports RTE_ETH_E

  1   2   >