RE: [PATCH] net/ice: fix scalar Rx and Tx path segment

2022-11-03 Thread Xu, Ke1
> -Original Message- > From: Mingjin Ye > Sent: Friday, November 4, 2022 1:21 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhou, YidingX ; Ye, MingjinX > ; Yang, Qiming ; Zhang, Qi > Z ; Wu, Jingjing ; Lu, > Wenzhuo ; Ferruh Yigit ; Li, > Xiaoyun > Subject: [PATCH] net/ice: fix scalar R

[PATCH v3] doc: fix minor issues in the event timer adapter guide

2022-11-03 Thread Mattias Rönnblom
In the example: * Properly initialize the socket id field. * Remove comments redundant and/or not consistent with the code. 180 seconds is not 2 minutes. * Remove redundant pointer initialization. In both the example and text, the flags field of the conf struct was erroneously referred to as tim

[PATCH v3] net/iavf: revert fix VLAN insertion

2022-11-03 Thread Yiding Zhou
The vector Tx path does not support VLAN insertion via the L2TAG2 field, but the scalar path supports. The previous commit was to force to select scalar path as soon as kernel driver requests to use L2TAG2. That logic is incorrect. Because other case like VLAN offloading not required but scalar pa

RE: [PATCH 0/2] app/testseventdev: crypto producer fixes

2022-11-03 Thread Anoob Joseph
> > This patch series address issues with crypto producer - correct setup sequence > and multi stage handling with time stamp attached. > > Volodymyr Fialko (2): > app/testeventdev: setup crypto adapter before sessions > app/testeventdev: resolve issues with crypto producer > Series Acked-b

RE: [PATCH v5] vdpa/ifc/base: wait for queue disable before saving q-state

2022-11-03 Thread Xia, Chenbo
> -Original Message- > From: Maheshwari, Abhishek > Sent: Thursday, November 3, 2022 5:35 PM > To: maxime.coque...@redhat.com; Wang, Xiao W > Cc: dev@dpdk.org; sta...@dpdk.org; Xia, Chenbo ; > Mandal, Purna Chandra ; Maheshwari, > Abhishek > Subject: [PATCH v5] vdpa/ifc/base: wait for qu

RE: [PATCH] doc: correct product name for idpf

2022-11-03 Thread Zhang, Qi Z
> -Original Message- > From: beilei.x...@intel.com > Sent: Tuesday, November 1, 2022 2:13 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Xing, Beilei > Subject: [PATCH] doc: correct product name for idpf > > From: Beilei Xing > > This patch corrects the product name for idpf PMD. > > F

DPDK Release Status Meeting 2022-11-03

2022-11-03 Thread Mcnamara, John
Release status meeting minutes 2022-11-03 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * ARM [No] * Canonical [No] * Debian/Microsoft * Intel * Marvell * Nvidia * Red Hat * Xilinx/AMD Release Dates - T

[PATCH v1 0/1] baseband/acc: coverity fix RC2

2022-11-03 Thread Hernan Vargas
Fix for coverity issues 381631, 381646 raised on RC2 for the ACC100 PMD. Hernan Vargas (1): baseband/acc: fix check after deref and dead code drivers/baseband/acc/rte_acc100_pmd.c | 4 1 file changed, 4 deletions(-) -- 2.37.1

[PATCH v1 1/1] baseband/acc: fix check after deref and dead code

2022-11-03 Thread Hernan Vargas
Fix potential issue of dereferencing a pointer before null check. Remove null check for value that could never be null. Coverity issue: 381646, 381631 Fixes: 989dec301a9 ("baseband/acc100: add ring companion address") Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 4 --

Re: [PATCH v8 1/1] baseband/acc100: add detection for deRM corner cases

2022-11-03 Thread Maxime Coquelin
On 11/4/22 04:08, Hernan Vargas wrote: Add function to detect if de-ratematch pre-processing is recommended for SW corner cases. Some specific 5GUL FEC corner cases may cause unintended back pressure and in some cases a potential stability issue on the ACC100. The PMD can detect such code bloc

RE: [PATCH v7 1/1] baseband/acc100: add detection for deRM corner cases

2022-11-03 Thread Chautru, Nicolas
Given how close we are to 22.11, let's not argue over this. Hernan sending a new patch based on Maxime recommendation. > -Original Message- > From: Chautru, Nicolas > Sent: Thursday, November 3, 2022 9:21 AM > To: Maxime Coquelin ; Vargas, Hernan > ; dev@dpdk.org; gak...@marvell.com; > t

[PATCH v8 1/1] baseband/acc100: add detection for deRM corner cases

2022-11-03 Thread Hernan Vargas
Add function to detect if de-ratematch pre-processing is recommended for SW corner cases. Some specific 5GUL FEC corner cases may cause unintended back pressure and in some cases a potential stability issue on the ACC100. The PMD can detect such code block configuration and issue an info message to

[PATCH v8 0/1] baseband/acc100: changes for 22.11

2022-11-03 Thread Hernan Vargas
v8: Remove unused parameter per community recommendation. v7: Not including dependency on SDK introduced in previous v3 for now due to lack of consensus yet. Still detecting the known corner case and flagging it. v6: Fix commit message typo. v5: Fix compilation error and squash documentation cha

[PATCH v2] test/hash: fix coverity warning

2022-11-03 Thread Vladimir Medvedkin
Check return value after bulk lookup Coverity issue: 357746 Fixes: 14b8ab576235 ("hash: add bulk lookup with signatures array") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- app/test/test_hash_perf.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/app/t

Re: [PATCH 2/2] test/hash: fix coverity warning

2022-11-03 Thread Medvedkin, Vladimir
Hi Stephen, On 03/11/2022 18:33, Stephen Hemminger wrote: On Thu, 3 Nov 2022 18:13:38 + Vladimir Medvedkin wrote: + if (ret != 0) { + printf("rte_hash_lookup_with_hash_bulk" +

Re: [PATCH 2/2] test/hash: fix coverity warning

2022-11-03 Thread Stephen Hemminger
On Thu, 3 Nov 2022 18:13:38 + Vladimir Medvedkin wrote: > + if (ret != 0) { > + printf("rte_hash_lookup_with_hash_bulk" > + " failed with %d\n", ret); > +

[PATCH 2/2] test/hash: fix coverity warning

2022-11-03 Thread Vladimir Medvedkin
Check return value after bulk lookup Coverity issue: 357746 Fixes: 14b8ab576235 ("hash: add bulk lookup with signatures array") Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- app/test/test_hash_perf.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/ap

[PATCH 1/2] test/hash: fix coverity warning

2022-11-03 Thread Vladimir Medvedkin
Remove unnecessary variable assignment Coverity issue: 336800 Fixes: 3f9aab961ed3 ("test/hash: check lock-free extendable bucket") Cc: dharmik.thak...@arm.com Cc: sta...@dpdk.org Signed-off-by: Vladimir Medvedkin --- app/test/test_hash_readwrite_lf_perf.c | 1 - 1 file changed, 1 deletion(-) d

[PATCH 2/2] app/testeventdev: resolve issues with crypto producer

2022-11-03 Thread Volodymyr Fialko
Resolve issues with crypto producer in configuration with multiple stages. 1) With symmetric crypto producer and enabled `--fwd_latency` we will treat rte_mbuf as perf_elt which will lead to rte_mbuf header corruption. Use rte_mbuf data to store time stamp information. 2) For asymmetric crypto pr

[PATCH 1/2] app/testeventdev: setup crypto adapter before sessions

2022-11-03 Thread Volodymyr Fialko
Setup crypto adapter and add queue pairs before assigning them in session metadata. Session metadata may use queue pair configuration parameters, so queue pair should be added before meta assignment. Signed-off-by: Volodymyr Fialko --- app/test-eventdev/test_perf_common.c | 16 ++--

[PATCH 0/2] app/testseventdev: crypto producer fixes

2022-11-03 Thread Volodymyr Fialko
This patch series address issues with crypto producer - correct setup sequence and multi stage handling with time stamp attached. Volodymyr Fialko (2): app/testeventdev: setup crypto adapter before sessions app/testeventdev: resolve issues with crypto producer app/test-eventdev/test_perf_atq

Re: [PATCH] event/dlb2: fix meson build

2022-11-03 Thread Ferruh Yigit
On 11/3/2022 3:35 PM, Thomas Monjalon wrote: 03/11/2022 16:22, Ferruh Yigit: "meson setup" fails when '-Werror' compiler flag is enabled [1]. This is not a build error in the driver but a build error in meson during "meson setup" stage. This issue exists for a while but meson takes it as a warn

RE: [PATCH v7 1/1] baseband/acc100: add detection for deRM corner cases

2022-11-03 Thread Chautru, Nicolas
Hi Maxime, Akhil, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, November 3, 2022 8:08 AM > To: Chautru, Nicolas ; Vargas, Hernan > ; dev@dpdk.org; gak...@marvell.com; > t...@redhat.com > Cc: Zhang, Qi Z > Subject: Re: [PATCH v7 1/1] baseband/acc100: add detection for d

[PATCH] event/cnxk: fix missing mempool cookie marking

2022-11-03 Thread pbhagavatula
From: Pavan Nikhilesh Mark chunks mempool objects as "put" as they are freed to NPA automatically when they are parsed by TIM HW. Fixes: 300b796262a1 ("event/cnxk: add timer arm routine") Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cnxk_tim_worker.h | 1 + 1 file changed, 1 insertio

[PATCH 2/2] devtools: stop depending on libabigail xml format

2022-11-03 Thread David Marchand
A ABI reference depends on: - DPDK build options, - toolchain compiler and versions, - libabigail version. The reason for the latter point is that, when the ABI reference was generated, ABI xml files were dumped in a format depending on the libabigail version. Those xml files were then later used

[PATCH 1/2] devtools: unify configuration for ABI check

2022-11-03 Thread David Marchand
We have been skipping removed libraries in the ABI check by updating the check-abi.sh script itself. See, for example, commit 33584c19ddc2 ("raw/dpaa2_qdma: remove driver"). Having two places for exception is a bit confusing, and those exceptions are best placed in a single configuration file out

[PATCH 0/2] ABI check updates

2022-11-03 Thread David Marchand
This series moves ABI exceptions in a single configuration file and simplifies the ABI check so that no artefact depending on libabigail version is stored in the CI. -- David Marchand David Marchand (2): devtools: unify configuration for ABI check devtools: stop depending on libabigail xml f

Re: [PATCH] event/dlb2: fix meson build

2022-11-03 Thread Thomas Monjalon
03/11/2022 16:22, Ferruh Yigit: > "meson setup" fails when '-Werror' compiler flag is enabled [1]. > This is not a build error in the driver but a build error in meson > during "meson setup" stage. > > This issue exists for a while but meson takes it as a warning and > ignores it unless '-Werror'

[PATCH v1] net/mlx5: fix incorrect match mask for meter flow

2022-11-03 Thread Shun Hao
There's an issue introduced by the change of splitting item matcher and value translation, that the matcher mask value for color is not set correctly in meter policy flow creation. This patch fixes this by providing the correct color mask. Fixes: cd4ab74206 ("net/mlx5: split flow item matcher and

RE: [PATCH] app/testeventdev: fix limit names in error message

2022-11-03 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Volodymyr Fialko > Sent: Monday, October 31, 2022 4:09 PM > To: dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran ; Akhil Goyal > ; Anoob Joseph ; Pavan > Nikhilesh Bhagavatula ; Volodymyr Fialko > > Subject: [PATCH] app/testeventdev: fix limit names in error me

[PATCH] event/dlb2: fix meson build

2022-11-03 Thread Ferruh Yigit
"meson setup" fails when '-Werror' compiler flag is enabled [1]. This is not a build error in the driver but a build error in meson during "meson setup" stage. This issue exists for a while but meson takes it as a warning and ignores it unless '-Werror' compiler flag is provided. Although it doesn

Re: [EXT] Re: [PATCH v11 1/1] app/testpmd: support multiple mbuf pools per Rx queue

2022-11-03 Thread Singh, Aman Deep
On 11/3/2022 6:06 PM, Hanumanth Reddy Pothula wrote: -Original Message- From: Singh, Aman Deep Sent: Thursday, November 3, 2022 5:46 PM To: Hanumanth Reddy Pothula ; Yuying Zhang Cc: dev@dpdk.org; andrew.rybche...@oktetlabs.ru; tho...@monjalon.net; Jerin Jacob Kollanukkaran ; Nithi

[PATCH v7 8/9] dts: add dts workflow module

2022-11-03 Thread Juraj Linkeš
The module implements methods needed to run DTS. It handles the creation of objects and eventually the whole DTS workflow, such as running node setups, test gathering, setup and execution and various cleanups. Signed-off-by: Owen Hilyard Signed-off-by: Juraj Linkeš --- dts/framework/dts.py |

[PATCH v7 9/9] dts: add dts executable script

2022-11-03 Thread Juraj Linkeš
The script is an interface to run DTS. Signed-off-by: Owen Hilyard Signed-off-by: Juraj Linkeš --- dts/main.py | 23 +++ 1 file changed, 23 insertions(+) create mode 100755 dts/main.py diff --git a/dts/main.py b/dts/main.py new file mode 100755 index 00..43311fa847

[PATCH v7 7/9] dts: add node base class

2022-11-03 Thread Juraj Linkeš
The base class implements basic node management methods - connect and execute commands. Signed-off-by: Owen Hilyard Signed-off-by: Juraj Linkeš --- dts/framework/testbed_model/__init__.py | 7 +++ dts/framework/testbed_model/node.py | 62 + 2 files changed, 69 inser

[PATCH v7 6/9] dts: add ssh session module

2022-11-03 Thread Juraj Linkeš
The module uses the pexpect python library and implements connection to a node and two ways to interact with the node: 1. Send a string with specified prompt which will be matched after the string has been sent to the node. 2. Send a command to be executed. No prompt is specified here. Signed-o

[PATCH v7 5/9] dts: add remote session abstraction

2022-11-03 Thread Juraj Linkeš
The abstraction allows for easy switching of implementations of remote connections (ssh, telnet, etc.). It implements some common features, such as logging of commands and their outputs and history bookkeeping and defines methods that must be implemented by derived classes. Signed-off-by: Owen Hil

[PATCH v7 4/9] dts: add basic logging facility

2022-11-03 Thread Juraj Linkeš
The logging module provides loggers distinguished by two attributes, a custom format and a verbosity switch. The loggers log to both console and more verbosely to files. Signed-off-by: Owen Hilyard Signed-off-by: Juraj Linkeš --- .gitignore| 3 + dts/framework/logger.py | 11

[PATCH v7 3/9] dts: add config parser module

2022-11-03 Thread Juraj Linkeš
From: Owen Hilyard The configuration is split into two parts, one defining the parameters of the test run and the other defining the topology to be used. The format of the configuration is YAML. It is validated according to a json schema which also server as detailed documentation of the various

[PATCH v7 2/9] dts: add developer tools

2022-11-03 Thread Juraj Linkeš
The devtools that check Python code are Black and Isort to format the code and Pylama to do static analysis. Signed-off-by: Owen Hilyard Signed-off-by: Juraj Linkeš --- devtools/dts-check-format.sh | 87 doc/guides/tools/dts.rst | 67

[PATCH v7 1/9] dts: add project tools config

2022-11-03 Thread Juraj Linkeš
Add configuration for Python tools used in DTS: Poetry, dependency and package manager Black, formatter Pylama, static analysis Isort, import sorting Signed-off-by: Owen Hilyard Signed-off-by: Juraj Linkeš --- MAINTAINERS| 5 + doc/guides/tools/dts.rst | 56 ++ doc/guid

[PATCH v7 0/9] dts: ssh connection to a node

2022-11-03 Thread Juraj Linkeš
All the necessary code needed to connect to a node in a topology with a bit more, such as basic logging and some extra useful methods. To run the code, modify the config file, conf.yaml and execute ./main.py from the root dts folder. Here's an example config: executions: - system_under_test: "SU

Re: [PATCH v7 1/1] baseband/acc100: add detection for deRM corner cases

2022-11-03 Thread Maxime Coquelin
Hi Nicolas, On 11/3/22 15:59, Chautru, Nicolas wrote: Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Thursday, November 3, 2022 7:10 AM To: Vargas, Hernan ; dev@dpdk.org; gak...@marvell.com; t...@redhat.com Cc: Chautru, Nicolas ; Zhang, Qi Z Subject: Re: [PATCH v7 1/1] bas

RE: [PATCH v7 1/1] baseband/acc100: add detection for deRM corner cases

2022-11-03 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, November 3, 2022 7:10 AM > To: Vargas, Hernan ; dev@dpdk.org; > gak...@marvell.com; t...@redhat.com > Cc: Chautru, Nicolas ; Zhang, Qi Z > > Subject: Re: [PATCH v7 1/1] baseband/acc100: add detection for deRM corn

Re: Flow Bifurcation of splitting the traffic between kernel space and user space (DPDK)

2022-11-03 Thread Ramakrishnan G
Dear Stephan, Thanks for the quick response. Yes. we realised that the article is more than 5 years old. We thought that this code is part of kernel code. Our idea is to use the single NIC port and assign single IP Address like 16.10.56.78. If we access 16.10.56.78:9090, the traffic should be for

Re: Flow Bifurcation of splitting the traffic between kernel space and user space (DPDK)

2022-11-03 Thread Ramakrishnan G
Dear Aaron, DPDK Dev team, pls help in solving this issue. We would like to have the same IP Address for linux and DPDK user space and have the flow type defined for routing the respective port traffic Thanks, Ram On Sat, Oct 29, 2022 at 2:39 AM Ramakrishnan G wrote: > Dear Aaron and DPDK Dev

Re: [PATCH v2] net/iavf: revert fix VLAN insertion

2022-11-03 Thread Kevin Traynor
On 03/11/2022 14:06, Yang, Qiming wrote: Hi, Kevin -Original Message- From: Kevin Traynor Sent: Thursday, November 3, 2022 6:52 PM To: Zhou, YidingX Cc: Yang, Qiming ; Zhang, Qi Z Subject: Re: [PATCH v2] net/iavf: revert fix VLAN insertion On 03/11/2022 10:38, Zhou, YidingX wrote:

RE: [PATCH] net/mlx5/hws: fix possible negative return on sq create

2022-11-03 Thread Alex Vesker
Also forgot to add to commit message: Coverity issue: 381674 > -Original Message- > From: Alex Vesker > Sent: Thursday, November 3, 2022 2:52 PM > To: Alex Vesker ; Slava Ovsiienko > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Suanming Mou ; > Matan Azrad > Cc: dev@dpdk.org; Ori Kam >

Re: [PATCH v7 1/1] baseband/acc100: add detection for deRM corner cases

2022-11-03 Thread Maxime Coquelin
On 11/1/22 05:13, Hernan Vargas wrote: Add function to detect if de-ratematch pre-processing is recommended for SW corner cases. Some specific 5GUL FEC corner cases may cause unintended back pressure and in some cases a potential stability issue on the ACC100. The PMD can detect such code bloc

[PATCH v2] cleanup compat header inclusions

2022-11-03 Thread David Marchand
With symbols going though experimental/stable stages, we accumulated a lot of discrepancies about inclusion of the rte_compat.h header. Some headers are including it where unneeded, while others rely on implicit inclusion. Fix unneeded inclusions: $ git grep -l include..rte_compat.h | xargs gre

[PATCH 2/2] net/ionic: fix up minor coverity issue in packet transmit

2022-11-03 Thread Andrew Boyer
If tx_pkts is NULL, nb_pkts must be 0. Coverity doesn't know this so it thinks this is a forward-NULL violation. Make things more clear by checking for nb_pkts instead. Coverity issue: 381614 Coverity issue: 381619 Fixes: e86a6fcc7cf3 ("net/ionic: add optimized non-scattered Rx/Tx") Signed-off-by

[PATCH 1/2] net/ionic: fix up minor coverity issue in queue allocation

2022-11-03 Thread Andrew Boyer
(uint16_t * uint16_t) promoted to uint64_t has a sign extension problem reported by Coverity. Cast one arg to uint64_t first to eliminate the sign extension. Coverity issue: 381617 Coverity issue: 381618 Fixes: 7b20fc2f3c06 ("net/ionic: overhaul Rx for performance") Signed-off-by: Andrew Boyer -

[PATCH 0/2] net/ionic: fix up minor coverity issues

2022-11-03 Thread Andrew Boyer
These patches will make no functional difference, but should eliminate four coverity issues. Alternatively, we could just mark them as False Positive or Ignored in coverity. Signed-off-by: Andrew Boyer Andrew Boyer (2): net/ionic: fix up minor coverity issue in queue allocation net/ionic: f

[PATCH v1] dts: add Dockerfile

2022-11-03 Thread Juraj Linkeš
The Dockerfile defines development and CI runner images. Signed-off-by: Juraj Linkeš --- dts/.devcontainer/devcontainer.json | 30 dts/Dockerfile | 38 dts/README.md | 55 + 3 files chang

[PATCH v1 2/2] doc: increase python max line to 88

2022-11-03 Thread Juraj Linkeš
88 is a good compromise between shorter files, readability and other considerations. More in [0]. [0] https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#line-length Signed-off-by: Owen Hilyard Signed-off-by: Juraj Linkeš --- .editorconfig

[PATCH v1 0/2] python gitignore and line length

2022-11-03 Thread Juraj Linkeš
These two config options/preferences are relevant to DTS, but not only to DTS and need to be discussed separately, as they affect all Python code in DPDK. Juraj Linkeš (2): git: ignore standard python files doc: increase python max line to 88 .editorconfig| 2 +-

[PATCH v1 1/2] git: ignore standard python files

2022-11-03 Thread Juraj Linkeš
These are python byte-compiled/optimized/dll files and IDE files. Signed-off-by: Juraj Linkeš --- .gitignore | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index 212c7aa28e..fbec0ce441 100644 --- a/.gitignore +++ b/.gitignore @@ -33,8 +33,10 @@

Re: [PATCH v2 0/4] crypto/ccp cleanup

2022-11-03 Thread David Marchand
Hello, On Wed, Nov 2, 2022 at 2:54 PM Uttarwar, Sunil Prakashrao wrote: > > [AMD Official Use Only - General] > > Hi David, > > Please find below response. Not sure why dev@ was dropped. Adding it back. > > -Original Message- > From: David Marchand > Sent: Wednesday, November 2, 2022

RE: [EXT] [PATCH v7 1/1] baseband/acc100: add detection for deRM corner cases

2022-11-03 Thread Akhil Goyal
> Add function to detect if de-ratematch pre-processing is recommended for > SW corner cases. > Some specific 5GUL FEC corner cases may cause unintended back pressure > and in some cases a potential stability issue on the ACC100. > The PMD can detect such code block configuration and issue an info

RE: [PATCH v4] app/test-security-perf: add security perf app

2022-11-03 Thread Akhil Goyal
> Subject: [PATCH v4] app/test-security-perf: add security perf app > > Add performance application to test security session create & destroy > rates supported by the security enabled cryptodev PMD. The > application would create specified number of sessions and captures the > time taken for the s

[PATCH] net/mlx5/hws: fix possible negative return on sq create

2022-11-03 Thread Alex Vesker
The sysconf call can return a negative value (-1) on failure this will lead to posix_memalign to fail. This is not a realistic case which was found by the static checkers. Fixes: 3eb7488 ("net/mlx5/hws: add send layer") Signed-off-by: Alex Vesker Reviewed-by: Erez Shitrit --- drivers/net/mlx5/h

[PATCH] net/mlx5/hws: fix possible action setter segmenation fault

2022-11-03 Thread Alex Vesker
When the maximum action combination in RX is used we can get a segfault due to an incorrecrt max array size define. This bug can happen on RX/TX or FDB in the most complex cases. Current max was set to 7, but actual max is: Max TX: 8, Max RX: 10, Max FDB: 9 Fixes: f8c8a6d ("net/mlx5/hws: add actio

[PATCH] net/mlx5/hws: check action creation for HWS support

2022-11-03 Thread Alex Vesker
Fix segmentation fault when user will request to allocate a HWS action while current device doesn't support HWS. Fixes: f8c8a6d ("net/mlx5/hws: add action object") Signed-off-by: Alex Vesker Reviewed-by: Erez Shitrit --- drivers/net/mlx5/hws/mlx5dr_action.c | 7 +++ 1 file changed, 7 insert

[PATCH] net/mlx5/hws: allow HWS support on non esw-manager devices

2022-11-03 Thread Alex Vesker
On context initialization the reparse capability support for NIC and FDB tables was required for allowing HWS. This caused a problem for devices that only want to run NIC steering. Modified the check to require FDB reparse only for esw-manager. Fixes: b0290e5 ("net/mlx5/hws: add context object") S

[PATCH v4] app/test-security-perf: add security perf app

2022-11-03 Thread Anoob Joseph
Add performance application to test security session create & destroy rates supported by the security enabled cryptodev PMD. The application would create specified number of sessions and captures the time taken for the same before proceeding to destroy of the same. When operating on multi-core, the

Re: [PATCH v2] net/iavf: revert fix VLAN insertion

2022-11-03 Thread Kevin Traynor
re-adding dev mailing list On 03/11/2022 10:51, Kevin Traynor wrote: On 03/11/2022 10:38, Zhou, YidingX wrote: Hi, Kevin According to suggestion, we did many deep investigation and various attempts, unfortunately that the performance drop(about 40%) caused by the previous commit: 0d58caa7d6d1

RE: [EXT] Re: [PATCH v11 1/1] app/testpmd: support multiple mbuf pools per Rx queue

2022-11-03 Thread Hanumanth Reddy Pothula
> -Original Message- > From: Singh, Aman Deep > Sent: Thursday, November 3, 2022 5:46 PM > To: Hanumanth Reddy Pothula ; Yuying Zhang > > Cc: dev@dpdk.org; andrew.rybche...@oktetlabs.ru; tho...@monjalon.net; > Jerin Jacob Kollanukkaran ; Nithin Kumar Dabilpuram > > Subject: [EXT] Re: [

Re: [PATCH v11 1/1] app/testpmd: support multiple mbuf pools per Rx queue

2022-11-03 Thread Singh, Aman Deep
On 10/25/2022 7:10 AM, Hanumanth Pothula wrote: Some of the HW has support for choosing memory pools based on the packet's size. The pool sort capability allows PMD/NIC to choose a memory pool based on the packet's length. On multiple mempool support enabled, populate mempool array accordingl

RE: [dpdk-dev v1] crypto/ipsec_mb: handle mp request register error

2022-11-03 Thread Akhil Goyal
> Hi Kai, > > > Subject: [dpdk-dev v1] crypto/ipsec_mb: handle mp request register error > > > > This patch fix the EXIST error handling when calling > > rte_mp_action_register(). > > > > Signed-off-by: Kai Ji > > --- > > drivers/crypto/ipsec_mb/ipsec_mb_private.c | 11 +-- > > 1 file c

RE: [PATCH 0/2] net/mlx5: fix some sample/mirror issues

2022-11-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Jiawei(Jonny) Wang > Sent: Wednesday, November 2, 2022 3:44 PM > To: Slava Ovsiienko ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH 0/2] net/mlx5: fix some sample/mirror issues > > Some fixes for sample/mirror issues. > > Jiawe

RE: [PATCH v1] net/mlx5: fix action flag data type

2022-11-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Shun Hao > Sent: Tuesday, November 1, 2022 12:07 PM > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam ; Bing Zhao > > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH v1] net/mlx5: fix action flag data type > > MLX5_FLOW_ACTION flag

RE: [PATCH 0/5] net/mlx5: some counter fixes

2022-11-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Michael Baum > Sent: Monday, October 31, 2022 6:08 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko > Subject: [PATCH 0/5] net/mlx5: some counter fixes > > Some fixes for HW/SW steering counters. > > Michael Baum (5): > n

RE: [PATCH] net/mlx5: enable flow aging action

2022-11-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Monday, October 31, 2022 10:21 AM > To: Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH] net/mlx5: enable flow aging action > > As the queue-based aging API has been integrated[1], the flow agi

RE: [PATCH] net/mlx5/hws: remove deprecated rte_atomic

2022-11-03 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alex Vesker > Sent: Sunday, October 30, 2022 6:12 PM > To: Alex Vesker ; Slava Ovsiienko > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Suanming Mou ; > Matan Azrad > Cc: dev@dpdk.org; Ori Kam > Subject: [PATCH] net/mlx5/hws: remove deprecated rte_atomic

RE: [EXT] [PATCH v1 1/1] baseband/acc: fix to possible negative shift

2022-11-03 Thread Akhil Goyal
> Potential occurrence of negative shift when using invalid > configuration on ACC200. Enforcing that depth > 0. > > Coverity issue: 381636 > Fixes: 40e3adbdd3 ("baseband/acc200: add queue configuration") > > Signed-off-by: Nicolas Chautru Applied to dpdk-next-crypto Thanks.

RE: [EXT] [PATCH v1] examples/fips_validation: fix IV generation for gmac

2022-11-03 Thread Akhil Goyal
> Replace rand() call in fips validation example with rte_rand(). > > Coverity issue: 381668 > Fixes: e27268bd2103 ("examples/fips_validation: add parsing for AES-GMAC") > > Signed-off-by: Brian Dooley Applied to dpdk-next-crypto Thanks.

RE: [PATCH v2] crypto/qat: fix reallocate OpenSSL version check

2022-11-03 Thread Akhil Goyal
> Acked-by: Kai Ji > > > Subject: [PATCH v2] crypto/qat: fix reallocate OpenSSL version check > > > > Move the ossl_legacy_provider_unload() into the right place for secure > protocol > > for QAT. Remove unnecessary unload from session destroy. > > > > Fixes: 52d59b92b06d ("crypto/qat: enable Ope

[PATCH] common/mlx5: fix shared mempool subscription

2022-11-03 Thread Gregory Etelson
MLX5 PMD counted each mempool subscribe invocation. The PMD expected that the mempool subscription will be deleted after the mempool counter dropped to 0. However, current PMD design unsubscribes mempool callbacks only once. As the result, the PMD destroyed mlx5_common_device but kept shared RX sub

Re: [dpdk-dev] [PATCH v6 06/10] eal: register non-EAL threads as lcores

2022-11-03 Thread Thomas Monjalon
03/11/2022 10:02, Morten Brørup: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Marchand > > Sent: Monday, 6 July 2020 22.53 > > > > DPDK allows calling some part of its API from a non-EAL thread but this > > has some limitations. > > OVS (and other applications) has its own thread

[PATCH] net/mlx5: forbid direction attributes in transfer flow rules

2022-11-03 Thread Dariusz Sosnowski
Since [1] flow API forbids usage of direction attributes in transfer flow rules. This patch adapts mlx5 PMD to this requirement. >From this patch, flow rule validation in mxl5 PMD will reject transfer flow rules with any of the direction attributes set (i.e. 'ingress' or 'egress'). As a result flo

[PATCH v5] vdpa/ifc/base: wait for queue disable before saving q-state

2022-11-03 Thread Abhishek Maheshwari
Some ifc hardware require synchronization between disabling a queue and saving queue-state from LM registers. When queue is disabled from vDPA driver, ifc device stops executing new virtio-cmds and then updates LM registers with used/avail index. Before saving the queue-state, vDPA driver should wa

[PATCH] net/ice: fix scalar Rx and Tx path segment

2022-11-03 Thread Mingjin Ye
CRC is stripped by the hardware in the scattered Rx path. If the last buffer packet length is '0', the scalar Tx path would send empty buffer that causes the Tx queue to overflow. This patch adds a judgment for the last buffer length to fix this issue, so that it would free the mbuf associated to

RE: [dpdk-dev v1] crypto/ipsec_mb: handle mp request register error

2022-11-03 Thread Dooley, Brian
Hi Kai, > -Original Message- > From: Kai Ji > Sent: Wednesday, November 2, 2022 11:25 PM > To: dev@dpdk.org > Cc: gak...@marvell.com; Ji, Kai ; De Lara Guarch, Pablo > ; Burakov, Anatoly > > Subject: [dpdk-dev v1] crypto/ipsec_mb: handle mp request register error > > This patch fix the

[PATCH] net/i40e: fix PCTYPE configuration for X722

2022-11-03 Thread Mingjin Ye
To make X722's PCTYPE is compatible with X710, the PCTYPE in the FD programming descriptor is translated into different types by using GLQF_FD_PCTYPE table. But the types of 'UNICAST_IPV4_UDP' and 'MULTICAST_IPV4_UDP' are only supported for X722, so that the corresponding registers can not be confi

RE: [dpdk-dev] [PATCH v6 06/10] eal: register non-EAL threads as lcores

2022-11-03 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Marchand > Sent: Monday, 6 July 2020 22.53 > > DPDK allows calling some part of its API from a non-EAL thread but this > has some limitations. > OVS (and other applications) has its own thread management but still > want to avoid such li

RE: [PATCH v2 2/3] mempool: include non-DPDK threads in statistics

2022-11-03 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Wednesday, 2 November 2022 18.53 > > On 2022-11-02 10:09, Morten Brørup wrote: > >> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > >> Sent: Wednesday, 2 November 2022 08.53 > >> > >> On 2022-10-31 12:26, Morten Brørup wrote:

RE: [EXT] [PATCH v1 0/6] baseband/acc: fixes on top of RC2

2022-11-03 Thread Akhil Goyal
> A few fixes still required for the baseband acc PMDs > for ACC100 and ACC200 on top of RC2. Most of them > introduced recently including one covery warning. > All changes pushed in same serie for ease of review/apply. > > Hernan Vargas (3): > baseband/acc: fix PMON register values > baseband

RE: [EXT] [PATCH] crypto/scheduler: fix session retrieval for ops

2022-11-03 Thread Akhil Goyal
> In cases where some ops failed to enqueue, the op session was never being > reset. This resulted in a segmentation fault when processing ops the > next time. To fix this, only set the op session after the failure > condition is checked. > > Also, the incorrect ops index was being used for sessio

RE: [dpdk-dev v1] crypto/ipsec_mb: fix of qp NULL check

2022-11-03 Thread Akhil Goyal
> > Subject: [dpdk-dev v1] crypto/ipsec_mb: fix of qp NULL check > > > > This patch fix the NULL pointer check when dereference qp and ring lookup. > > > > Coverity issue: 381625 > > Fixes: c75542ae4200 ("crypto/ipsec_mb: introduce IPsec_mb framework") > > Cc: roy.fan.zh...@intel.com > > > > Signed

RE: [EXT] Re: [PATCH 1/1] test/bbdev: use helper function to set IOVA addr

2022-11-03 Thread Akhil Goyal
> > On Thu, Nov 3, 2022 at 12:54 PM Srikanth Yalavarthi > wrote: > > > > > On Tue, Nov 1, 2022 at 3:23 PM Srikanth Yalavarthi > > > wrote: > > > > > > > > Use helper function rte_mbuf_iova_set to set IOVA address to fix > > > > compilation failures. > > > > > > > > Below error was observed: > >

Re: [EXT] Re: [PATCH 1/1] test/bbdev: use helper function to set IOVA addr

2022-11-03 Thread Jerin Jacob
On Thu, Nov 3, 2022 at 12:54 PM Srikanth Yalavarthi wrote: > > > On Tue, Nov 1, 2022 at 3:23 PM Srikanth Yalavarthi > > wrote: > > > > > > Use helper function rte_mbuf_iova_set to set IOVA address to fix > > > compilation failures. > > > > > > Below error was observed: > > > > > > dpdk/app/test-b

RE: [EXT] Re: [PATCH 1/1] test/bbdev: use helper function to set IOVA addr

2022-11-03 Thread Srikanth Yalavarthi
> On Tue, Nov 1, 2022 at 3:23 PM Srikanth Yalavarthi > wrote: > > > > Use helper function rte_mbuf_iova_set to set IOVA address to fix > > compilation failures. > > > > Below error was observed: > > > > dpdk/app/test-bbdev/test_bbdev_perf.c: In function ‘init_op_data_objs’: > > dpdk/app/test-bbdev

Re: [PATCH v4 1/2] app/testpmd: fix vlan offload of rxq

2022-11-03 Thread lihuisong (C)
在 2022/11/3 9:28, Ye, MingjinX 写道: -Original Message- From: lihuisong (C) Sent: 2022年10月28日 10:09 To: Ye, MingjinX ; dev@dpdk.org Cc: sta...@dpdk.org; Zhou, YidingX ; Singh, Aman Deep ; Zhang, Yuying Subject: Re: [PATCH v4 1/2] app/testpmd: fix vlan offload of rxq 在 2022/10/27 19: