Re: [PATCH v12 1/1] app/testpmd: support multiple mbuf pools per Rx queue

On 11/7/2022 11:01 AM, Hanumanth Pothula wrote: Some of the HW has support for choosing memory pools based on the packet's size. The pool sort capability allows PMD/NIC to choose a memory pool based on the packet's length. On multiple mempool support enabled, populate mempool array accordingl

[PATCH v5] ethdev: add special flags when creating async transfer table

The transfer domain rule is able to match traffic wire/vport origin which are corresponding to two kinds of underlayer resources. Wire means traffic arrives from the uplink port while vport means traffic initiated from VF/SF. In customer deployments, they usually match only one kind of traffic in

[PATCH v5] ethdev: add special flags when creating async transfer table

The transfer domain rule is able to match traffic wire/vport origin which are corresponding to two kinds of underlayer resources. Wire means traffic arrives from the uplink port while vport means traffic initiated from VF/SF. In customer deployments, they usually match only one kind of traffic in

Re: FW: [PATCH v4 3/3] mempool: use cache for frequently updated stats

On 2022-11-09 06:03, Morten Brørup wrote: >> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] >> Sent: Tuesday, 8 November 2022 18.38 >>> >>> On Tue, Nov 08, 2022 at 04:51:11PM +0100, Thomas Monjalon wrote: 08/11/2022 15:30, Morten Brørup: >> From: Thomas Monjalon [mailto:th

RE: [PATCH] net/mlx5: fix the first segment inline length

Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Tuesday, November 8, 2022 3:45 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad ; > Michael Baum > Subject: [PATCH] net/mlx5: fix the first segment inline length > > Packets can be

RE: [PATCH] net/mlx5: remove unneeded GENEVE option length assert

Hi, > -Original Message- > From: Suanming Mou > Sent: Wednesday, November 9, 2022 3:40 AM > To: Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH] net/mlx5: remove unneeded GENEVE option length assert > > In order to share flow items translate code,

Re: [PATCH v5] ethdev: add special flags when creating async transfer table

09/11/2022 09:13, Rongwei Liu: > v2: Move the new field to template table attribute. > v4: Mark it as optional and clear the concept. > v5: Change specialize type to uint32_t. There are more changes to do (replace enum with defines and update the commit message).

Re: [PATCH v4] ethdev: add special flags when creating async transfer table

On 11/8/22 18:25, Thomas Monjalon wrote: 08/11/2022 15:38, Andrew Rybchenko: On 11/8/22 16:29, Thomas Monjalon wrote: 08/11/2022 12:47, Andrew Rybchenko: On 11/8/22 14:39, Andrew Rybchenko wrote: On 11/4/22 13:44, Rongwei Liu wrote: diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h

RE: [PATCH 1/2] test/hash: fix coverity warning

> -Original Message- > From: Vladimir Medvedkin > Sent: Friday, November 4, 2022 2:13 AM > To: dev@dpdk.org > Cc: Dharmik Thakkar ; sta...@dpdk.org; Yipeng Wang > ; Sameh Gobriel ; Bruce > Richardson > > Subject: [PATCH 1/2] test/hash: fix coverity warning > > Remove unnecessary variabl

Re: [PATCH v4] ethdev: add special flags when creating async transfer table

09/11/2022 09:53, Andrew Rybchenko: > On 11/8/22 18:25, Thomas Monjalon wrote: > > 08/11/2022 15:38, Andrew Rybchenko: > >> On 11/8/22 16:29, Thomas Monjalon wrote: > >>> 08/11/2022 12:47, Andrew Rybchenko: > On 11/8/22 14:39, Andrew Rybchenko wrote: > > On 11/4/22 13:44, Rongwei Liu wrote

Re: [PATCH v4] ethdev: add special flags when creating async transfer table

On 11/9/22 12:03, Thomas Monjalon wrote: 09/11/2022 09:53, Andrew Rybchenko: On 11/8/22 18:25, Thomas Monjalon wrote: 08/11/2022 15:38, Andrew Rybchenko: On 11/8/22 16:29, Thomas Monjalon wrote: 08/11/2022 12:47, Andrew Rybchenko: On 11/8/22 14:39, Andrew Rybchenko wrote: On 11/4/22 13:44,

[PATCH] examples/ipsec-secgw: fix uninitialized variable access

Fix uninitialized variable access of outbound offloads flags. Coverity issue: 381669 Fixes: 6938fc92c404 ("examples/ipsec-secgw: add lookaside event mode") Signed-off-by: Volodymyr Fialko --- examples/ipsec-secgw/ipsec-secgw.c | 19 +++ examples/ipsec-secgw/ipsec.h| 7

RE: [PATCH] net/mlx5: fix assert when creating meter policy

Hi, > -Original Message- > From: Shun Hao > Sent: Wednesday, November 9, 2022 9:53 AM > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam ; Jiawei(Jonny) Wang > > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix assert when creating meter policy > > Wh

[PATCH 0/2] net/mlx5/hws: fix matcher clean up for FDB tables

Before these patches, if an application was configured to run with HW Steering and E-Switch enabled, on EAL cleanup the assertion in mlx5_dev_hw_global_release() was triggered - PD release was unsuccessful. Root cause of this issue was linked to an inability to destroy RTC objects used internally

[PATCH 1/2] net/mlx5/hws: fix order of destroying default tables

From: Erez Shitrit This patch fixes the order dereferencing default FDB miss table and destroying the flow table object. Flow table should be destroyed before the dereference. Fixes: 394cc7ba4033 ("net/mlx5/hws: add table object") Cc: va...@nvidia.com Signed-off-by: Erez Shitrit Signed-off-by:

[PATCH 2/2] net/mlx5/hws: fix disconnecting matcher

From: Erez Shitrit This patch fixes the matcher disconnection handling, by removing the RTC references from flow table if the currently removed matcher was the last one for the given table. As a result RTC in this matcher can be correctly freed, since there are no dangling references to the RTC.

RE: [PATCH v2] net/mlx5/hws: fix timestamp format on Tx queue creation

Hi, > -Original Message- > From: Slava Ovsiienko > Sent: Wednesday, November 9, 2022 9:58 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Alex Vesker > Subject: [PATCH v2] net/mlx5/hws: fix timestamp format on Tx queue > creation > > The NIC since 6DX supports multiple ti

RE: [PATCH v2] testpmd: make f_quit flag volatile

> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, November 9, 2022 2:08 AM > To: dev@dpdk.org > Cc: Phil Yang ; Stephen Hemminger > > Subject: [PATCH v2] testpmd: make f_quit flag volatile > > Since f_quit is set in a signal handler it needs to be marked volatile. > Ot

RE: FW: [PATCH v4 3/3] mempool: use cache for frequently updated stats

> On 2022-11-09 06:03, Morten Brørup wrote: > >> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > >> Sent: Tuesday, 8 November 2022 18.38 > >>> > >>> On Tue, Nov 08, 2022 at 04:51:11PM +0100, Thomas Monjalon wrote: > 08/11/2022 15:30, Morten Brørup: > >> From: Thomas Monj

RE: [PATCH 0/2] net/mlx5/hws: fix matcher clean up for FDB tables

From: Dariusz Sosnowski > Before these patches, if an application was configured to run with HW > Steering and E-Switch enabled, on EAL cleanup the assertion in > mlx5_dev_hw_global_release() was triggered - PD release was unsuccessful. > > Root cause of this issue was linked to an inability

Re: [PATCH v2] testpmd: make f_quit flag volatile

On 11/9/22 13:11, Ruifeng Wang wrote: -Original Message- From: Stephen Hemminger Sent: Wednesday, November 9, 2022 2:08 AM To: dev@dpdk.org Cc: Phil Yang ; Stephen Hemminger Subject: [PATCH v2] testpmd: make f_quit flag volatile Since f_quit is set in a signal handler it needs to be m

Re: [PATCH V2] net/bonding: fix bond3 and bond4 process mbuf fast free

On 11/9/22 06:24, Stephen Hemminger wrote: On Wed, 9 Nov 2022 10:22:37 +0800 Huisong Li wrote: The RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE offload can't be used in bonding mode Broadcast and mode 8023AD. Currently, bonding driver forcibly removes from the dev->data->dev_conf.txmode.offloads and proc

Re: [PATCH v12 1/1] app/testpmd: support multiple mbuf pools per Rx queue

On 11/9/22 11:04, Singh, Aman Deep wrote: On 11/7/2022 11:01 AM, Hanumanth Pothula wrote: Some of the HW has support for choosing memory pools based on the packet's size. The pool sort capability allows PMD/NIC to choose a memory pool based on the packet's length. On multiple mempool support en

[Bug 1123] [dpdk-22.11][ASan Test] the stack-buffer-overflow was found when quit testpmd in Redhat9

https://bugs.dpdk.org/show_bug.cgi?id=1123 Bug ID: 1123 Summary: [dpdk-22.11][ASan Test] the stack-buffer-overflow was found when quit testpmd in Redhat9 Product: DPDK Version: 22.11 Hardware: x86 OS: Linux

Re: [PATCH] app/testpmd: fix flow list for async flows

On 11/7/22 16:16, Alexander Kozyrev wrote: Flows created with the new asynchronous Flow API lack attributes (direction, priority, group number). These attributes are part of a template table for flows created via rte_flow_async_create(). When testpmd tries to list all the flows it accesses flow

Re: [PATCH v4] vdpa/ifc: fix update_datapath error handling

Hi Maxime, Thanks for your review. On Tue, Nov 08, 2022 at 02:49:39PM +0100, Maxime Coquelin wrote: > Hi Taekyung, > > On 11/8/22 09:56, Taekyung Kim wrote: > > Stop and return the error code when update_datapath fails. > > update_datapath prepares resources for the vdpa device. > > The driver s

Re: [PATCH v4] vdpa/ifc: fix update_datapath error handling

Hi Andy, Thanks for your review. On Wed, Nov 09, 2022 at 02:39:09AM +, Pei, Andy wrote: > > > > -Original Message- > > From: Taekyung Kim > > Sent: Tuesday, November 8, 2022 4:56 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; Pei, Andy ; > > kim.tae.ky...@navercorp.com; maxime.coque

Re: [PATCH v4] ethdev: add special flags when creating async transfer table

09/11/2022 10:36, Andrew Rybchenko: > On 11/9/22 12:03, Thomas Monjalon wrote: > > 09/11/2022 09:53, Andrew Rybchenko: > >> On 11/8/22 18:25, Thomas Monjalon wrote: > >>> 08/11/2022 15:38, Andrew Rybchenko: > On 11/8/22 16:29, Thomas Monjalon wrote: > > 08/11/2022 12:47, Andrew Rybchenko:

RE: FW: [PATCH v4 3/3] mempool: use cache for frequently updated stats

> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Wednesday, 9 November 2022 11.20 > > > On 2022-11-09 06:03, Morten Brørup wrote: > > >> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > > >> Sent: Tuesday, 8 November 2022 18.38 > > >>> > > >>> On Tue, Nov

[PATCH] net/mlx5: fix indexed pool local cache crash

Local cache for an indexed pool is not initialized in the situation when all the indices are allocated on one CPU core and freed on another one. That leads to a crash once we try to check its reference counter. Check that the local cache is initialized before accessing this counter. Fixes: d15c094

RE: [PATCH] net/mlx5: fix indexed pool local cache crash

> -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, November 9, 2022 14:58 > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad ; Michael Baum > > Subject: [PATCH] net/mlx5: fix indexed pool local cache crash > > Local cache for an in

[PATCH] bus/auxiliary: prevent device from being probed again

The device on auxiliary bus doesn't support being probed again without being removed firstly. The PMD will detect and return error for this unsupported operation. Some of the resources would be cleared wrongly. When quiting, there will be unexpected error like crash. To prevent this, the device dr

[PATCH v2] bus/auxiliary: prevent device from being probed again

The device on auxiliary bus doesn't support being probed again without being removed firstly. The PMD will detect and return error for this unsupported operation. Some of the resources would be cleared wrongly. When quitting, there will be unexpected error like crash. To prevent this, the device d

[dpdk-dev] [PATCH] lib: fix doxygen syntax issues

From: Jerin Jacob Fix following syntax error reported by doxygen 1.9.5 version. lib/eal/include/rte_uuid.h:89: error: RTE_UUID_STRLEN has @param documentation sections but no arguments (warning treated as error, aborting now) lib/power/rte_power.h:169: error: rte_power_freq_up has @param docume

Re: [dpdk-dev] [PATCH] lib: fix doxygen syntax issues

09/11/2022 15:54, jer...@marvell.com: > From: Jerin Jacob > > Fix following syntax error reported by doxygen 1.9.5 version. > > lib/eal/include/rte_uuid.h:89: error: RTE_UUID_STRLEN > has @param documentation sections but no arguments > (warning treated as error, aborting now) > > lib/power/rte

Re: [dpdk-dev] [PATCH] lib: fix doxygen syntax issues

On Wed, Nov 9, 2022 at 8:34 PM Thomas Monjalon wrote: > > 09/11/2022 15:54, jer...@marvell.com: > > From: Jerin Jacob > > > > Fix following syntax error reported by doxygen 1.9.5 version. > > > > lib/eal/include/rte_uuid.h:89: error: RTE_UUID_STRLEN > > has @param documentation sections but no ar

[PATCH] app/test: add SHA3 test cases

Add test cases for SHA3 hash family for Digest and Digest-Verify. Signed-off-by: Volodymyr Fialko Expected vectors were generated with OpenSSL. Adding to CC original authors of PMDs that currently have support for SHA3 to check if there's any issues. --- app/test/test_cryptodev_hash_test_vect

RE: [PATCH 0/2] net/mlx5/hws: fix matcher clean up for FDB tables

Hi, > -Original Message- > From: Dariusz Sosnowski > Sent: Wednesday, November 9, 2022 11:54 AM > To: Matan Azrad ; Slava Ovsiienko > ; Alex Vesker ; Erez Shitrit > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH 0/2] net/mlx5/hws: fix matcher clean up for FDB tables > > Before

RE: [PATCH] net/mlx5: fix indexed pool local cache crash

Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, November 9, 2022 2:58 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad ; > Michael Baum > Subject: [PATCH] net/mlx5: fix indexed pool local cache crash > > Local cache fo

Re: [PATCH v8 0/9] dts: ssh connection to a node

04/11/2022 12:05, Juraj Linkeš: > All the necessary code needed to connect to a node in a topology with > a bit more, such as basic logging and some extra useful methods. Applied, thanks. That's the first step towards integration of DTS in DPDK repository. Nice to see this becoming a reality. [.

RE: [PATCH v8 0/9] dts: ssh connection to a node

> > 04/11/2022 12:05, Juraj Linkeš: > > All the necessary code needed to connect to a node in a topology with > > a bit more, such as basic logging and some extra useful methods. > > Applied, thanks. > > That's the first step towards integration of DTS in DPDK repository. > Nice to see this be

[PATCH 1/3] net/mlx5: fix log level on failed transfer proxy stop

This patches increases log level for error reporting when stopping the transfer proxy port failed. Stopping can fail with EBUSY when related representor ports are still running. Fixes: 483181f7b6dd ("net/mlx5: support device control of representor matching") Signed-off-by: Dariusz Sosnowski ---

[PATCH 0/3] ethdev: document special cases of port start and stop

This patch series attempts to address the special failure cases of rte_eth_dev_stop() and rte_eth_dev_start(). In case of starting a port, If the port depends on another one being started, PMDs might return (-EAGAIN) to notify about such situation. In case of stopping a port, If the port cannot b

[PATCH 2/3] doc: document E-Switch limitations with HWS in mlx5 PMD

This patch adds the following limitations to the mlx5 PMD guide: - With HW Steering and E-Switch enabled, transfer proxy port must be started before any port representor. - With HW Steering and E-Switch enabled, all representors must be stopped before transfer proxy port is stopped. Signed-of

[PATCH 3/3] ethdev: document special cases of port start and stop

This patch clarifies the handling of following cases in the ethdev API docs: - If rte_eth_dev_start() returns (-EAGAIN) for some port, it cannot be started until other port is started. - If rte_eth_dev_stop() returns (-EBUSY) for some port, it cannot be stopped until other port is stopped. Wh

Re: [PATCH v2] kni: fix possible alloc_q starvation when mbufs are exhausted

On Wed, 9 Nov 2022 14:04:34 +0800 Yangchao Zhou wrote: > In some scenarios, mbufs returned by rte_kni_rx_burst are not freed > immediately. So kni_allocate_mbufs may be failed, but we don't know. > > Even worse, when alloc_q is completely exhausted, kni_net_tx in > rte_kni.ko will drop all tx p

[PATCH] net/mlx5: fix port initialization with small LRO

If application provided maximal LRO size was less than expected PMD minimum, the PMD either crashed with assert, if asserts were enabled, or proceeded with port initialization to set port private maximal LRO size below supported minimum. The patch terminates port start if LRO size does not match P

[PATCH] app/testpmd: fix interactive mode with no ports

Testpmd terminated unconditionally if it failed to start all ports. The patch allows testpmd to get into the command line, if the interactive mode was requested. Fixes: 6937d2103e22 ("app/testpmd: add option to not start device") Signed-off-by: Gregory Etelson --- app/test-pmd/testpmd.c | 8 +++

Re: [PATCH v8 0/9] dts: ssh connection to a node

On Wed, Nov 9, 2022 at 11:23 AM Honnappa Nagarahalli < honnappa.nagaraha...@arm.com> wrote: > > > > > > 04/11/2022 12:05, Juraj Linkeš: > > > All the necessary code needed to connect to a node in a topology with > > > a bit more, such as basic logging and some extra useful methods. > > > > Applie

[PATCH v2] app/testpmd: fix interactive mode with no ports

Testpmd terminated unconditionally if it failed to start all ports. The patch allows testpmd to get into the command line, if the interactive mode was requested. Fixes: 6937d2103e22 ("app/testpmd: add option to not start device") Cc: step...@networkplumber.org Cc: sta...@dpdk.org Signed-off-by:

[PATCH] devtools: set DTS directory to format check

The script was running on the current directory. If not in the DTS directory, it would re-format every Python files. A new positional argument is added to specify the directory to check. In most cases, the (new) default value should be enough. While updating argument handling, the usage is printe

[PATCH v5] testpmd: cleanup cleanly from signal

Do a clean shutdown of testpmd when a signal is received; instead of having testpmd kill itself. This fixes problem where a signal could be received in the middle of a PMD and then the signal handler would call PMD's close routine which could cause a deadlock. Added benefit is it gets rid of Windo

Re: [PATCH] devtools: set DTS directory to format check

On Wed, Nov 9, 2022 at 12:09 PM Thomas Monjalon wrote: > The script was running on the current directory. > If not in the DTS directory, it would re-format every Python files. > > A new positional argument is added to specify the directory to check. > In most cases, the (new) default value should

RE: [RFC] mempool: zero-copy cache put bulk

> > > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > > Sent: Sunday, 6 November 2022 00.11 > > > > + Akshitha, she is working on similar patch > > > > Few comments inline > > > > > From: Morten Brørup > > > Sent: Saturday, November 5, 2022 8:40 AM > > > > > > Zero-copy acces

[PATCH v5 1/3] mempool: split stats from debug

Split stats from debug, to make mempool statistics available without the performance cost of continuously validating the debug cookies in the mempool elements. mempool_perf_autotest shows the following improvements in rate_persec. The cost of enabling mempool debug without this patch: -28.1 % and

[PATCH v5 2/3] mempool: add stats for unregistered non-EAL threads

This patch adds statistics for unregistered non-EAL threads, which was previously not included in the statistics. Add one more entry to the stats array, and use the last index for unregistered non-EAL threads. The unregistered non-EAL thread statistics are incremented atomically. In theory, the

[PATCH v5 3/3] mempool: use cache for frequently updated stats

When built with stats enabled (RTE_LIBRTE_MEMPOOL_STATS defined), the performance of mempools with caches is improved as follows. When accessing objects in the mempool, either the put_bulk and put_objs or the get_success_bulk and get_success_objs statistics counters are likely to be incremented.

[PATCH] doc: support IPsec Multi-buffer lib v1.3

Updated AESNI MB and AESNI GCM, KASUMI, ZUC and SNOW3G PMD documentation guides with information about the latest Intel IPSec Multi-buffer library supported. Signed-off-by: Pablo de Lara --- doc/guides/cryptodevs/aesni_gcm.rst | 8 doc/guides/cryptodevs/aesni_mb.rst | 18 -

[PATCH v2] doc: support IPsec Multi-buffer lib v1.3

Updated AESNI MB and AESNI GCM, KASUMI, ZUC and SNOW3G PMD documentation guides with information about the latest Intel IPSec Multi-buffer library supported. Signed-off-by: Pablo de Lara --- - v2: Removed repeated word 'the' --- doc/guides/cryptodevs/aesni_gcm.rst | 8 doc/guides/cry

[PATCH v2 0/3] ethdev: document special cases of port start and stop

This patch series attempts to address the special failure cases of rte_eth_dev_stop() and rte_eth_dev_start(). In case of starting a port, If the port depends on another one being started, PMDs might return (-EAGAIN) to notify about such situation. In case of stopping a port, If the port cannot b

[PATCH v2 1/3] net/mlx5: fix log level on failed transfer proxy stop

This patches increases log level for error reporting when stopping the transfer proxy port failed. Stopping can fail with EBUSY when related representor ports are still running. Fixes: 483181f7b6dd ("net/mlx5: support device control of representor matching") Signed-off-by: Dariusz Sosnowski ---

[PATCH v2 3/3] ethdev: document special cases of port start and stop

This patch clarifies the handling of following cases in the ethdev API docs: - If rte_eth_dev_start() returns (-EAGAIN) for some port, it cannot be started until other port is started. - If rte_eth_dev_stop() returns (-EBUSY) for some port, it cannot be stopped until other port is stopped. Wh

[PATCH v2 2/3] doc: document E-Switch limitations with HWS in mlx5 PMD

This patch adds the following limitations to the mlx5 PMD guide: - With HW Steering and E-Switch enabled, transfer proxy port must be started before any port representor. - With HW Steering and E-Switch enabled, all representors must be stopped before transfer proxy port is stopped. Signed-of

[PATCH 00/14] whitespace around keywords

The DPDK standard now enforced through checkpatch is to use a space after keywords. Much of the older code that was grandfathered in doesn't follow that, so fix it. No urgency to this patchset, and it might just be viewed as churn. But I prefer to read code that looks all the same. “A foolish con

[PATCH 01/14] eal: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- lib/eal/linux/eal_hugepage_info.c | 6 +++--- lib/eal/linux/eal_interrupts.c| 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/eal/linux/eal_hugepage_info.c b/lib/eal/linux/eal_hugepage_info.c index a1b6c

[PATCH 02/14] cmdline: fix whitespace

Add space after keywords. Remove unnecessary spaces in if expressions. Signed-off-by: Stephen Hemminger --- lib/cmdline/cmdline_parse_string.c | 10 +- lib/cmdline/cmdline_rdline.c | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/cmdline/cmdline_parse

[PATCH 04/14] ip_frag: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ip_frag/rte_ipv4_reassembly.c b/lib/ip_frag/rte_ipv4_reassembly.c index 4a89a5f5365a..88ee0aa63f62 100644 --- a/lib/ip_frag/rt

[PATCH 03/14] timer: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- lib/timer/rte_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/timer/rte_timer.c b/lib/timer/rte_timer.c index 85d67573eb9e..9eb73f1fed13 100644 --- a/lib/timer/rte_timer.c +++ b/lib/timer/rte_timer.c @

[PATCH 05/14] testpmd: fix whitspace

Add space after keywords. Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c| 30 +++--- app/test-pmd/parameters.c | 8 app/test-pmd/testpmd.c| 2 +- 3 files changed, 20 insertions(+), 20 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/

[PATCH 06/14] test: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- app/test/test_cmdline_cirbuf.c | 4 ++-- app/test/test_debug.c | 4 ++-- app/test/test_hash.c | 8 app/test/test_lpm6_perf.c | 2 +- app/test/test_malloc.c | 14 +++--- app/test/te

[PATCH 07/14] examples/qos_sched: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- examples/qos_sched/app_thread.c | 6 +++--- examples/qos_sched/args.c | 2 +- examples/qos_sched/init.c | 2 +- examples/qos_sched/main.c | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/exam

[PATCH 08/14] examples/vhost: fix whitespace

Add space after keywords Signed-off-by: Stephen Hemminger --- examples/vhost/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index 42e53a0f9a4f..cabc8682346c 100644 --- a/examples/vhost/main.c +++ b/examples/vhost/mai

[PATCH 09/14] l3fwd: fix whitespace

Add space after keywoords Signed-off-by: Stephen Hemminger --- examples/l3fwd-power/main.c | 6 +++--- examples/l3fwd/main.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index fd3ade330f82..b2270e1056c8

[PATCH 10/14] examples: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- examples/cmdline/parse_obj_list.c | 2 +- examples/ip_reassembly/main.c | 2 +- examples/multi_process/symmetric_mp/main.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/cmdl

[PATCH 11/14] bus/pci: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- drivers/bus/pci/bsd/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/pci/bsd/pci.c b/drivers/bus/pci/bsd/pci.c index 7459d15c7e31..056e2eda2d5f 100644 --- a/drivers/bus/pci/bsd/pci.c +++ b/drivers

[PATCH 12/14] net/e1000: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- drivers/net/e1000/em_ethdev.c | 4 ++-- drivers/net/e1000/igb_ethdev.c | 8 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c index 8ee9be12ad19..14

[PATCH 13/14] net/i40e: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- drivers/net/i40e/i40e_pf.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c index 15d9ff868f3a..7050e0057d8e 100644 --- a/drivers/net/i40e/i40e_pf.c +

[PATCH 14/14] net/bnx2x: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h index 89414ac88a93..9cb927e25449 100644 --- a/drivers/net/bnx2x/bnx2x.h +++ b/drivers

RE: [PATCH 07/14] examples/qos_sched: fix whitespace

> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, November 9, 2022 7:15 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Dumitrescu, > Cristian > Subject: [PATCH 07/14] examples/qos_sched: fix whitespace > > Add space after keywords. > > Signed-off-by: Stephen Hemminge

[PATCH v2 01/14] eal: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- lib/eal/linux/eal_hugepage_info.c | 6 +++--- lib/eal/linux/eal_interrupts.c| 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/eal/linux/eal_hugepage_info.c b/lib/eal/linux/eal_hugepage_info.c index a1b6c

[PATCH v2 00/14] whitespace after keywords

The DPDK standard now enforced through checkpatch is to use a space after keywords. Much of the older code that was grandfathered in doesn't follow that, so fix it. No urgency to this patchset, and it might just be viewed as churn. But I prefer to read code that looks all the same. “A foolish con

[PATCH v2 02/14] cmdline: fix whitespace

Add space after keywords. Remove unnecessary spaces in if expressions. Signed-off-by: Stephen Hemminger --- lib/cmdline/cmdline_parse_string.c | 16 +++- lib/cmdline/cmdline_rdline.c | 12 ++-- 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/lib/cmdline

[PATCH v2 03/14] timer: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- lib/timer/rte_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/timer/rte_timer.c b/lib/timer/rte_timer.c index 85d67573eb9e..9eb73f1fed13 100644 --- a/lib/timer/rte_timer.c +++ b/lib/timer/rte_timer.c @

[PATCH v2 04/14] ip_frag: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ip_frag/rte_ipv4_reassembly.c b/lib/ip_frag/rte_ipv4_reassembly.c index 4a89a5f5365a..88ee0aa63f62 100644 --- a/lib/ip_frag/rt

[PATCH v2 05/14] testpmd: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c| 31 --- app/test-pmd/parameters.c | 10 ++ app/test-pmd/testpmd.c| 2 +- 3 files changed, 23 insertions(+), 20 deletions(-) diff --git a/app/test-pmd/cmdline.c b/a

[PATCH v2 06/14] test: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- app/test/test_cmdline_cirbuf.c | 4 ++-- app/test/test_debug.c | 4 ++-- app/test/test_hash.c | 6 +++--- app/test/test_lpm6_perf.c | 2 +- app/test/test_malloc.c | 14 +++--- app/test/test

[PATCH v2 07/14] examples/qos_sched: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- examples/qos_sched/app_thread.c | 6 +++--- examples/qos_sched/args.c | 2 +- examples/qos_sched/init.c | 2 +- examples/qos_sched/main.c | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/exam

[PATCH v2 08/14] examples/vhost: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- examples/vhost/main.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index 42e53a0f9a4f..9fee966916e9 100644 --- a/examples/vhost/main.c +++ b/examples/vhost/m

[PATCH v2 10/14] examples: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- examples/cmdline/parse_obj_list.c | 2 +- examples/ip_reassembly/main.c | 2 +- examples/multi_process/symmetric_mp/main.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/cmdl

[PATCH v2 09/14] l3fwd: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- examples/l3fwd-power/main.c | 7 --- examples/l3fwd/main.c | 7 --- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index fd3ade330f82..7bd5d8cb22

[PATCH v2 11/14] bus/pci: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- drivers/bus/pci/bsd/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/pci/bsd/pci.c b/drivers/bus/pci/bsd/pci.c index 7459d15c7e31..056e2eda2d5f 100644 --- a/drivers/bus/pci/bsd/pci.c +++ b/drivers

[PATCH v2 13/14] net/i40e: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- drivers/net/i40e/i40e_pf.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c index 15d9ff868f3a..7050e0057d8e 100644 --- a/drivers/net/i40e/i40e_pf.c +

[PATCH v2 12/14] net/e1000: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- drivers/net/e1000/em_ethdev.c | 4 ++-- drivers/net/e1000/igb_ethdev.c | 8 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c index 8ee9be12ad19..14

[PATCH v2 14/14] net/bnx2x: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h index 89414ac88a93..9cb927e25449 100644 --- a/drivers/net/bnx2x/bnx2x.h +++ b/drivers

RE: [RFC] mempool: zero-copy cache put bulk

+To: Bruce also showed interest in this topic, and might have more insights. > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Wednesday, 9 November 2022 18.58 > > > > > > > > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > > > Sent: Sunday, 6 Novembe

Re: [PATCH v4] testpmd: cleanup cleanly from signal

On 2022-11-09 05:10, Stephen Hemminger wrote: Do a clean shutdown of testpmd when a signal is received; instead of having testpmd kill itself. This fixes problem where a signal could be received in the middle of a PMD and then the signal handler would call PMD's close routine which could cause a

Re: Question about naive XOR hash in DPDK

On 2022-11-07 19:57, Bili Dong wrote: Dear DPDK devs, We are using DPDK as the backend target of a P4 pipeline (https://github.com/p4lang/p4-dpdk-target ). A recent issue we are trying to solve is to support a naive XOR hash (something like this

[PATCH] net/mlx5: fix port's event cleaning order

The shared IB device (sh) has per port data with filed for interrupt handler port_id. It used by shared interrupt handler to find the corresponding rte_eth device by IB port index. If value is equal or greater RTE_MAX_ETHPORTS it means there is no subhandler installed for specified IB port index.

[PATCH v2] net/mlx5: fix port's event cleaning order

The shared IB device (sh) has per port data with filed for interrupt handler port_id. It used by shared interrupt handler to find the corresponding rte_eth device by IB port index. If value is equal or greater RTE_MAX_ETHPORTS it means there is no subhandler installed for specified IB port index.

RE: [RFC] mempool: zero-copy cache put bulk

> > +To: Bruce also showed interest in this topic, and might have more insights. > > > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > > Sent: Wednesday, 9 November 2022 18.58 > > > > > > > > > > > > > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > > > >

  1   2   >