[PATCH] net/iavf: enable tx outer checksum offload on avx512

2022-12-21 Thread Zhichao Zeng
This patch is to enable outer checksum offload on avx512 Tx path for tunnel packet by adding Tx path with context descriptor and adjusting path select logic. Signed-off-by: Yiding Zhou Signed-off-by: Zhichao Zeng --- drivers/net/iavf/iavf_rxtx.c| 21 +- drivers/net/iavf/iavf_rxtx.h

RE: [PATCH] net/iavf:fix slow memory allocation

2022-12-21 Thread You, KaisenX
> -Original Message- > From: Ferruh Yigit > Sent: 2022年12月21日 21:49 > To: You, KaisenX ; dev@dpdk.org; Burakov, > Anatoly ; David Marchand > > Cc: sta...@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; Wu, Jingjing ; Xing, > Beilei ; Zhang, Qi Z ; Luca > Boccassi ; Mcnamara, John > ; Kevin T

RE: [PATCH] net/iavf:fix slow memory allocation

2022-12-21 Thread You, KaisenX
> -Original Message- > From: David Marchand > Sent: 2022年12月21日 18:50 > To: You, KaisenX > Cc: Ferruh Yigit ; dev@dpdk.org; Burakov, Anatoly > ; sta...@dpdk.org; Yang, Qiming > ; Zhou, YidingX ; Wu, > Jingjing ; Xing, Beilei ; Zhang, > Qi Z ; Luca Boccassi ; Mcnamara, > John ; Kevin Tra

[PATCH v4 6/6] ethdev: add trace points for tm

2022-12-21 Thread Ankur Dwivedi
Adds trace points for rte_tm specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace_points.c | 90 ++ lib/ethdev/rte_ethdev_trace.h| 126 + lib/ethdev/rte_ethdev_trace_fp.h | 155 +++ lib

[PATCH v4 5/6] ethdev: add trace points for mtr

2022-12-21 Thread Ankur Dwivedi
Adds trace points for rte_mtr specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace_points.c | 63 +++ lib/ethdev/rte_ethdev_trace.h| 103 +++ lib/ethdev/rte_ethdev_trace_fp.h | 89 ++

[PATCH v4 4/6] ethdev: add trace points for flow

2022-12-21 Thread Ankur Dwivedi
Adds trace points for rte_flow specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace_points.c | 117 ++ lib/ethdev/rte_ethdev_trace.h| 367 +++ lib/ethdev/rte_ethdev_trace_fp.h | 109 + lib/ethdev/rte_flow.c

[PATCH v4 3/6] ethdev: add trace points for remaining functions

2022-12-21 Thread Ankur Dwivedi
Adds trace points for remaining ethdev functions. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace_points.c | 252 +++ lib/ethdev/rte_ethdev.c | 456 ++- lib/ethdev/rte_ethdev_cman.c | 30 +- lib/ethdev/rte_ethdev_trace.h| 523 +++

[PATCH v4 2/6] ethdev: add trace points for ethdev

2022-12-21 Thread Ankur Dwivedi
Adds trace points for ethdev functions. Moved the rte_ethdev_trace_rx_burst and rte_ethdev_trace_tx_burst to a new file rte_ethdev_trace_fp_burst.h. This is needed to resolve cyclic dependency between rte_ethdev.h and rte_ethdev_trace_fp.h. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_priv

[PATCH v4 1/6] eal: trace: add trace point emit for array

2022-12-21 Thread Ankur Dwivedi
Adds a trace point emit function for array. The maximum array bytes which can be captured is set to 32. Also adds test case for emit array tracepoint function. Signed-off-by: Ankur Dwivedi --- app/test/test_trace.c | 3 +++ lib/eal/common/eal_common_trace_points.c | 2 +

[PATCH v4 0/6] add trace points in ethdev library

2022-12-21 Thread Ankur Dwivedi
This series adds trace points for functions in the ethdev library. The trace points are added in ethdev, flow, mtr and tm files. v4: - Adds tracepoint function to emit char array. Also adds the test case. - Resolved review comments on "ethdev: add trace point" patch. This patch is divided

Re: [PATCH 1/3] lib: dpdk spec to skip red for ingress policer

2022-12-21 Thread Jerin Jacob
On Thu, Dec 22, 2022 at 8:32 AM Stephen Hemminger wrote: > > On Thu, 22 Dec 2022 07:09:02 +0530 > Rakesh Kudurumalla wrote: > > > Dropping of packets based on RED can be skipped > > with meter action, when RED is configured using > > rte_eth_cman_config_set() > > > > Signed-off-by: Rakesh Kudurum

Re: [PATCH 1/3] lib: dpdk spec to skip red for ingress policer

2022-12-21 Thread Stephen Hemminger
On Thu, 22 Dec 2022 07:09:02 +0530 Rakesh Kudurumalla wrote: > Dropping of packets based on RED can be skipped > with meter action, when RED is configured using > rte_eth_cman_config_set() > > Signed-off-by: Rakesh Kudurumalla Should this be more general and apply to all congestion management

[PATCH 3/3] net/cnxk: skip red drop for ingress policer

2022-12-21 Thread Rakesh Kudurumalla
Dropping of packets is based on action configured to meter.If both skip_red and drop actions are configured then tail dropping in invoked else if only drop action is configured then RED drop is invoked.This action is supported only when RED is configured using rte_eth_cman_config_set() Signed-off-

[PATCH 2/3] app/testpmd: add skip red for testpmd

2022-12-21 Thread Rakesh Kudurumalla
added support for testpmd application to accept skip_red action while configuring policy action Signed-off-by: Rakesh Kudurumalla --- app/test-pmd/cmdline_flow.c | 9 + 1 file changed, 9 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 88108498e

[PATCH 1/3] lib: dpdk spec to skip red for ingress policer

2022-12-21 Thread Rakesh Kudurumalla
Dropping of packets based on RED can be skipped with meter action, when RED is configured using rte_eth_cman_config_set() Signed-off-by: Rakesh Kudurumalla --- lib/ethdev/rte_flow.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h inde

[RFC PATCH] bus/platform: add platform bus

2022-12-21 Thread Tomasz Duszynski
Platform bus is a software bus under Linux that manages devices which generally do not have built-in discovery mechanisms. Linux normally learns about platform devices directly from device-tree during boot-up phase. Up to this point, whenever some userspace app needed control over platform device

Re: DPDK:fast-tests suite linux/vm

2022-12-21 Thread Tyler Retzlaff
On Wed, Dec 21, 2022 at 11:49:41AM -0800, Stephen Hemminger wrote: > On Wed, 21 Dec 2022 11:33:36 -0800 > Tyler Retzlaff wrote: > > > On Wed, Dec 21, 2022 at 11:03:33AM -0800, Stephen Hemminger wrote: > > > On Wed, 21 Dec 2022 10:13:49 -0800 > > > Tyler Retzlaff wrote: > > > > > > > hi folks,

Re: DPDK:fast-tests suite linux/vm

2022-12-21 Thread Lincoln Lavoie
16GB should be enough to run the unit tests. You'll likely have better luck with the system setup to provide pages. Our lab runners provide 2560x 2MB pages (5 GB), out of their 16G of RAM. We only run 1 unit test at a time on each runner, because of noise neighbor issues between the containers.

Re: DPDK:fast-tests suite linux/vm

2022-12-21 Thread Stephen Hemminger
On Wed, 21 Dec 2022 11:33:36 -0800 Tyler Retzlaff wrote: > On Wed, Dec 21, 2022 at 11:03:33AM -0800, Stephen Hemminger wrote: > > On Wed, 21 Dec 2022 10:13:49 -0800 > > Tyler Retzlaff wrote: > > > > > hi folks, > > > > > > are there any additional requirements that may not be documented for

Re: DPDK:fast-tests suite linux/vm

2022-12-21 Thread Tyler Retzlaff
On Wed, Dec 21, 2022 at 11:03:33AM -0800, Stephen Hemminger wrote: > On Wed, 21 Dec 2022 10:13:49 -0800 > Tyler Retzlaff wrote: > > > hi folks, > > > > are there any additional requirements that may not be documented for > > running the DPDK:fast-tests suite in a vm on linux? > > > > if i run t

Re: DPDK:fast-tests suite linux/vm

2022-12-21 Thread Stephen Hemminger
On Wed, 21 Dec 2022 10:13:49 -0800 Tyler Retzlaff wrote: > hi folks, > > are there any additional requirements that may not be documented for > running the DPDK:fast-tests suite in a vm on linux? > > if i run the suite as follows i end up getting intermittent failures. > are there known issues

Re: [RFC] eal: per-thread constructors/destructors

2022-12-21 Thread Mattias Rönnblom
On 2022-12-21 17:12, David Marchand wrote: > On Sun, Dec 18, 2022 at 11:01 AM Morten Brørup > wrote: >> >> This RFC introduces per-thread constructors/destructors: >> * Per-thread constructors are functions called as the first thing from newly >> created threads. This can be used to initialize v

DPDK:fast-tests suite linux/vm

2022-12-21 Thread Tyler Retzlaff
hi folks, are there any additional requirements that may not be documented for running the DPDK:fast-tests suite in a vm on linux? if i run the suite as follows i end up getting intermittent failures. are there known issues running in a vm? meson test -C u --test-args='--no-huge' --suite fast-

Re: [RFC] eal: per-thread constructors/destructors

2022-12-21 Thread Tyler Retzlaff
On Wed, Dec 21, 2022 at 05:12:54PM +0100, David Marchand wrote: > On Sun, Dec 18, 2022 at 11:01 AM Morten Brørup > wrote: > > > > This RFC introduces per-thread constructors/destructors: > > * Per-thread constructors are functions called as the first thing from > > newly created threads. This ca

Re: C++20 report error at file rte_spinlock.h

2022-12-21 Thread Stephen Hemminger
On Tue, 20 Dec 2022 02:11:42 + "Zhou, Xiangyun" wrote: > Thanks very much for Konstantin and Tyler's analyzing. > > I agree that removal of 'volatile' is enough. A spinlock has already used to > protect these variables. > > -Original Message- > From: Konstantin Ananyev > Sent: T

Re: [PATCH v1 2/2] net/axgbe: move offloads to Rx/Tx queue setup

2022-12-21 Thread Ferruh Yigit
On 12/21/2022 2:52 AM, Jesna K E wrote: > For Multiprocess dpdk applications retrieving the offload parameter > for receive packet directly from struct eth_dev > giving segmentation fault since rxmode.offloads from eth_dev was > null duirng recv_pkts. So retrieved offload from rx/tx_queue_setup() >

Re: [RFC] eal: per-thread constructors/destructors

2022-12-21 Thread David Marchand
On Sun, Dec 18, 2022 at 11:01 AM Morten Brørup wrote: > > This RFC introduces per-thread constructors/destructors: > * Per-thread constructors are functions called as the first thing from newly > created threads. This can be used to initialize variables in thread-local > storage, variables depe

Re: [PATCH] ci: drop Travis configuration

2022-12-21 Thread David Marchand
On Wed, Dec 14, 2022 at 8:11 PM Aaron Conole wrote: > > David Marchand writes: > > > We stopped using Travis in the main branch and in the public CI in favor > > of GHA more than a year ago. > > The UNH community lab now covers testing native compilation and unit > > tests for ARM platforms. > >

Re: [PATCH v1 1/2] net/axgbe: add multi-process support

2022-12-21 Thread Ferruh Yigit
On 12/21/2022 2:52 AM, Jesna K E wrote: > Added multi-process support for axgbe PMD > To achieve multi-process support separate out TX and RX function > inside the axgbe driver and call that from a secondary process > when it is attaching to an already-configured NIC > > Signed-off-by: Jesna K E

Re: [PATCH] test/crypto: add further ZUC testcases

2022-12-21 Thread Zhang, Fan
Hi Ciara, On 12/21/2022 2:04 PM, Ciara Power wrote: Previously no ZUC decryption only or hash verify testcases existed, only encryption and authentication. This commit adds testcases for ZUC 128 and 256 decryption, and hash verify. + if (direction == RTE_CRYPTO_CIPHER_OP_ENCRYPT) { +

Re: [PATCH v2 0/2] Enable the lcores test on Windows instead of skipping it.

2022-12-21 Thread David Marchand
On Fri, Dec 16, 2022 at 6:16 PM Tyler Retzlaff wrote: > > Two bugs are fixed to allow this test to build, run & pass. > * Mark memory configuration complete during rte_eal_init() > * Use rte thread api to get a proper implementation of thread join. > > v2: > * update commit message to clarif

Re: [PATCH v2 2/2] devtools: configure source repo to use as ABI reference

2022-12-21 Thread David Marchand
On Fri, Dec 9, 2022 at 10:02 AM David Marchand wrote: > > From: Ferruh Yigit > > By default 'test-meson-builds.sh' script clones the repository which the > script is in, and selects a configured branch ('DPDK_ABI_REF_VERSION') > as a reference for ABI check. > > This patch enables selecting diffe

Re: [PATCH] malloc: enhance NUMA affinity heuristic

2022-12-21 Thread David Marchand
Hello Min, On Wed, Dec 21, 2022 at 11:49 AM David Marchand wrote: > > Trying to allocate memory on the first detected numa node has less > chance to find some memory actually available rather than on the main > lcore numa node (especially when the DPDK application is started only > on one numa no

RE: [RFC v3 2/2] ethdev: add API to set process to active or standby

2022-12-21 Thread Rongwei Liu
HI Jerin: BR Rongwei > -Original Message- > From: Jerin Jacob > Sent: Wednesday, December 21, 2022 21:12 > To: Rongwei Liu > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Ferruh Yigit > ; Andrew Rybchenko > ; dev@dpdk.org; Raslan Darawsheh >

[PATCH v2] test/crypto: add further ZUC testcases

2022-12-21 Thread Ciara Power
Previously no ZUC decryption only or hash verify testcases existed, only encryption and authentication. This commit adds testcases for ZUC 128 and 256 decryption, and hash verify. Signed-off-by: Ciara Power --- v2: fixed variable initialisation. --- app/test/test_cryptodev.c | 446 +

[PATCH] crypto/qat: fix stream cipher direction

2022-12-21 Thread Ciara Power
Stream ciphers use ENCRYPT mode in HW for both encryption and decryption operations. This patch adds in an overwrite to always set ENCRYPT mode for these algorithms. Fixes: d9b7d5bbc845 ("crypto/qat: add ZUC EEA3/EIA3 capability") Cc: arkadiuszx.kusz...@intel.com Cc: sta...@dpdk.org Signed-off-by

[PATCH] test/crypto: add further ZUC testcases

2022-12-21 Thread Ciara Power
Previously no ZUC decryption only or hash verify testcases existed, only encryption and authentication. This commit adds testcases for ZUC 128 and 256 decryption, and hash verify. Signed-off-by: Ciara Power --- app/test/test_cryptodev.c | 444 +++--- 1 file change

Re: [PATCH] malloc: enhance NUMA affinity heuristic

2022-12-21 Thread Ferruh Yigit
On 12/21/2022 11:16 AM, Bruce Richardson wrote: > On Wed, Dec 21, 2022 at 11:48:57AM +0100, David Marchand wrote: >> Trying to allocate memory on the first detected numa node has less >> chance to find some memory actually available rather than on the main >> lcore numa node (especially when the DP

Re: [PATCH] net/iavf:fix slow memory allocation

2022-12-21 Thread Ferruh Yigit
On 12/20/2022 6:52 AM, You, KaisenX wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: 2022年12月13日 21:28 >> To: You, KaisenX ; dev@dpdk.org; Burakov, >> Anatoly ; David Marchand >> >> Cc: sta...@dpdk.org; Yang, Qiming ; Zhou, YidingX >> ; Wu, Jingjing ; Xing, >> Beilei ; Zh

[PATCH 4/4] crypto/cnxk: add error interrupt event query handler

2022-12-21 Thread Srujana Challa
Adds RTE_CRYPTODEV_EVENT_ERROR query handler for cn9k/cn10k PMD. The query handler finds the next queue pair ID with pending error interrupt event if any, starting from the given queue pair index, for the device. Signed-off-by: Srujana Challa --- drivers/common/cnxk/roc_cpt.c | 4 ++

[PATCH 3/4] cryptodev: introduce query API for error interrupt event

2022-12-21 Thread Srujana Challa
An event RTE_CRYPTODEV_EVENT_ERROR gets fired when crypto PMD receives an error interrupt. This patch adds query function for the application, to get more info about the event. Signed-off-by: Srujana Challa --- lib/cryptodev/cryptodev_pmd.h | 9 + lib/cryptodev/rte_cryptodev.c | 19

[PATCH 2/4] crypto/cnxk: add callback to report CPT HW error

2022-12-21 Thread Srujana Challa
Adds and register callback to report CPT MISC error interrupts to the application using rte_cryptodev_pmd_callback_process. Signed-off-by: Srujana Challa --- drivers/crypto/cnxk/cnxk_cryptodev.c | 12 drivers/crypto/cnxk/cnxk_cryptodev.h | 1 + drivers/crypto/cnxk/cnxk_cryp

[PATCH 1/4] common/cnxk: add CPT HW error callback register functions

2022-12-21 Thread Srujana Challa
Adds functions to register callback API to report CPT_MISC_INT to the driver. Signed-off-by: Srujana Challa --- drivers/common/cnxk/roc_cpt.c | 31 +++ drivers/common/cnxk/roc_cpt.h | 8 +++- drivers/common/cnxk/version.map | 2 ++ 3 files changed, 40 insert

Re: [RFC v3 2/2] ethdev: add API to set process to active or standby

2022-12-21 Thread Jerin Jacob
On Wed, Dec 21, 2022 at 6:20 PM Rongwei Liu wrote: > > HI Jerin: > > BR > Rongwei > > > -Original Message- > > From: Jerin Jacob > > Sent: Wednesday, December 21, 2022 20:45 > > To: Rongwei Liu > > Cc: Matan Azrad ; Slava Ovsiienko > > ; Ori Kam ; NBU-Contact- > > Thomas Monjalon (EXTERN

RE: [RFC v3 2/2] ethdev: add API to set process to active or standby

2022-12-21 Thread Rongwei Liu
HI Jerin: BR Rongwei > -Original Message- > From: Jerin Jacob > Sent: Wednesday, December 21, 2022 20:45 > To: Rongwei Liu > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Ferruh Yigit > ; Andrew Rybchenko > ; dev@dpdk.org; Raslan Darawsheh >

Re: [RFC v3 2/2] ethdev: add API to set process to active or standby

2022-12-21 Thread Jerin Jacob
On Wed, Dec 21, 2022 at 5:35 PM Rongwei Liu wrote: > > Hi Jerin: > > BR > Rongwei > > > -Original Message- > > From: Jerin Jacob > > Sent: Wednesday, December 21, 2022 19:00 > > To: Rongwei Liu > > Cc: Matan Azrad ; Slava Ovsiienko > > ; Ori Kam ; NBU-Contact- > > Thomas Monjalon (EXTERN

RE: [RFC v3 2/2] ethdev: add API to set process to active or standby

2022-12-21 Thread Rongwei Liu
Hi Jerin: BR Rongwei > -Original Message- > From: Jerin Jacob > Sent: Wednesday, December 21, 2022 19:00 > To: Rongwei Liu > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Ferruh Yigit > ; Andrew Rybchenko > ; dev@dpdk.org; Raslan Darawsheh >

Re: [PATCH] malloc: enhance NUMA affinity heuristic

2022-12-21 Thread Bruce Richardson
On Wed, Dec 21, 2022 at 11:48:57AM +0100, David Marchand wrote: > Trying to allocate memory on the first detected numa node has less > chance to find some memory actually available rather than on the main > lcore numa node (especially when the DPDK application is started only > on one numa node). >

[PATCH] test: add cryptodev crosscheck suite

2022-12-21 Thread Volodymyr Fialko
Add new test suite that allow to crosscheck cryptodevs based on their capabilities. Test suite will scan supported capabilities, determine common and generate appropriate input, then suite will check if output from all crpytodevs are the same. Signed-off-by: Volodymyr Fialko --- app/test/meson.b

Re: [RFC v3 2/2] ethdev: add API to set process to active or standby

2022-12-21 Thread Jerin Jacob
On Wed, Dec 21, 2022 at 3:02 PM Rongwei Liu wrote: > > HI Jerin: > Hi Rongwei > BR > Rongwei > > > -Original Message- > > From: Jerin Jacob > > Sent: Wednesday, December 21, 2022 17:13 > > To: Rongwei Liu > > Cc: Matan Azrad ; Slava Ovsiienko > > ; Ori Kam ; NBU-Contact- > > Thomas Mon

[PATCH 3/4] cryptodev: introduce query API for error interrupt event

2022-12-21 Thread Srujana Challa
An event RTE_CRYPTODEV_EVENT_ERROR gets fired when crypto PMD receives an error interrupt. This patch adds query function for the application, to get more info about the event. Signed-off-by: Srujana Challa --- lib/cryptodev/cryptodev_pmd.h | 9 + lib/cryptodev/rte_cryptodev.c | 19

[PATCH 2/4] crypto/cnxk: add callback to report CPT HW error

2022-12-21 Thread Srujana Challa
Adds and register callback to report CPT MISC error interrupts to the application using rte_cryptodev_pmd_callback_process. Signed-off-by: Srujana Challa --- drivers/crypto/cnxk/cnxk_cryptodev.c | 12 drivers/crypto/cnxk/cnxk_cryptodev.h | 1 + drivers/crypto/cnxk/cnxk_cryp

Re: [PATCH] net/iavf:fix slow memory allocation

2022-12-21 Thread David Marchand
On Wed, Dec 21, 2022 at 10:12 AM You, KaisenX wrote: > > -Original Message- > > From: David Marchand > > Sent: 2022年12月20日 18:33 > > To: You, KaisenX > > Cc: Ferruh Yigit ; dev@dpdk.org; Burakov, Anatoly > > ; sta...@dpdk.org; Yang, Qiming > > ; Zhou, YidingX ; Wu, > > Jingjing ; Xing, B

[PATCH 1/4] common/cnxk: add CPT HW error callback register functions

2022-12-21 Thread Srujana Challa
Adds functions to register callback API to report CPT_MISC_INT to the driver. Signed-off-by: Srujana Challa --- drivers/common/cnxk/roc_cpt.c | 32 drivers/common/cnxk/roc_cpt.h | 8 +++- drivers/common/cnxk/version.map | 2 ++ 3 files changed, 41 inser

[PATCH 4/4] crypto/cnxk: add error interrupt event query handler

2022-12-21 Thread Srujana Challa
Adds RTE_CRYPTODEV_EVENT_ERROR query handler for cn9k/cn10k PMD. The query handler finds the next queue pair ID with pending error interrupt event if any, starting from the given queue pair index, for the device. Signed-off-by: Srujana Challa --- drivers/common/cnxk/roc_cpt.c | 4 ++

[PATCH] malloc: enhance NUMA affinity heuristic

2022-12-21 Thread David Marchand
Trying to allocate memory on the first detected numa node has less chance to find some memory actually available rather than on the main lcore numa node (especially when the DPDK application is started only on one numa node). Signed-off-by: David Marchand --- lib/eal/common/malloc_heap.c | 2 +-

RE: [PATCH v2] net/mlx5: add debug support for dumping all rte ports

2022-12-21 Thread Slava Ovsiienko
> -Original Message- > From: Alex Vesker > Sent: Wednesday, December 21, 2022 12:10 PM > To: dev@dpdk.org > Cc: Slava Ovsiienko ; Matan Azrad > ; Raslan Darawsheh > Subject: [PATCH v2] net/mlx5: add debug support for dumping all rte ports > > Add a special value max_uint16 to request dum

[RFC 5/5] drivers: enhance the Tx queue affinity

2022-12-21 Thread Jiawei Wang
Previous patch support the tx affinity configuration in the Tx queue API, it supports to set the affinity value on each Queue. This patch updates TIS creation with tx_affinity value of Tx queue , TIS index 1 goes to port 1, TIS index 2 goes to port 2, and TIS index 0 is reserved for default HWS ha

[RFC 4/5] net/mlx5: add port affinity item support

2022-12-21 Thread Jiawei Wang
This patch adds the new port affinity item supports in PMD: RTE_FLOW_ITEM_TYPE_PORT_AFFINITY. This patch adds the validation function for the new item, it works for NIC-RX rules on ROOT-table only. Signed-off-by: Jiawei Wang --- doc/guides/nics/features/mlx5.ini | 1 + doc/guides/nics/mlx5.rst

[RFC 3/5] drivers: add lag Rx port affinity in PRM

2022-12-21 Thread Jiawei Wang
This patch adds function to query hca capability via Devx for lag_rx_port_affinity. Signed-off-by: Jiawei Wang --- drivers/common/mlx5/mlx5_devx_cmds.c | 3 +++ drivers/common/mlx5/mlx5_devx_cmds.h | 1 + drivers/common/mlx5/mlx5_prm.h | 7 +-- drivers/net/mlx5/linux/mlx5_os.c | 4

[RFC 2/5] ethdev: introduce the affinity field in Tx queue API

2022-12-21 Thread Jiawei Wang
For the multiple hardware ports connect to a single DPDK port (mhpsdp), the previous patch introduces the new rte flow item to match the port affinity of the received packets. This patch adds the tx_affinity setting in Tx queue API, the affinity value reflects packets be sent to which hardware por

[RFC 1/5] ethdev: add port affinity match item

2022-12-21 Thread Jiawei Wang
For the multiple hardware ports connect to a single DPDK port (mhpsdp), currently there is no information to indicate the packet belongs to which hardware port. This patch introduces a new port affinity item in rte flow API, and the port affinity value reflects the physical port affinity of the re

[RFC 0/5] add new port affinity item and affinity in Tx queue API

2022-12-21 Thread Jiawei Wang
For the multiple hardware ports connect to a single DPDK port (mhpsdp), currently there is no information to indicate the packet belongs to which hardware port. This patch introduces a new port affinity item in rte flow API, and the port affinity value reflects the physical port affinity of the re

[PATCH v2] eal: cleanup alarm and multiprocess hotplug before memory detach

2022-12-21 Thread Fengnan Chang
Alarm and multiprocess hotplug still need access hugepage memory, if alarm event processed after memory detach, it may cause SEGV. So cleanup alarm and multiprocess hotplug before memory detach. Fixes: 90b13ab8d4f7 ("alarm: remove direct access to interrupt handle") Fixes: a0cc7be20dd1 ("mem: clea

[PATCH] net/vmxnet3: added checks for TCP for RSS Configuration

2022-12-21 Thread Raghav Roy
Added checks for TCP in vmxnet3_rss_configure() This check ensures the the hashType for RSS, when enabled just for UDP, is not NONE. Signed-off-by: Raghav Roy --- drivers/net/vmxnet3/vmxnet3_ethdev.h | 3 +++ drivers/net/vmxnet3/vmxnet3_rxtx.c | 9 - 2 files changed, 11 insertions(+),

RE: [PATCH v2] IGC: Remove I225_I_PHY_ID checking

2022-12-21 Thread Mah, Yock Gen
-Original Message- From: Kevin Traynor Sent: Tuesday, 20 December, 2022 11:48 PM To: Mah, Yock Gen ; IOTG DPDK Ref App ; Zhang, Qi Z ; Taripin, Samuel Cc: dev@dpdk.org Subject: Re: [PATCH v2] IGC: Remove I225_I_PHY_ID checking On 19/10/2022 09:34, Kevin Traynor wrote: > On 18/10/202

RE: C++20 report error at file rte_spinlock.h

2022-12-21 Thread Zhou, Xiangyun
Thanks very much for Konstantin and Tyler's analyzing. I agree that removal of 'volatile' is enough. A spinlock has already used to protect these variables. -Original Message- From: Konstantin Ananyev Sent: Tuesday, December 20, 2022 12:51 AM To: Tyler Retzlaff ; Zhou, Xiangyun Cc:

[PATCH V1 11/11] net/mlx5/hws: add debug details for cross gvmi

2022-12-21 Thread Erez Shitrit
For context, table and matcher. Signed-off-by: Erez Shitrit Signed-off-by: Hamdan Igbaria Reviewed-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_debug.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_debug.c b/driver

[PATCH V1 10/11] net/mlx5/hws: support actions while shared resources is used

2022-12-21 Thread Erez Shitrit
TIR/FT actions are different in the context of shared ibv resource, it created on the local ibv_context and aliased to the shared ibv_context. Other actions should be created on the shared ibv resource, new flag was added to indicates where this object came from. Signed-off-by: Erez Shitrit Rev

[PATCH V1 09/11] net/mlx5/hws: support shared ibv-context with local one

2022-12-21 Thread Erez Shitrit
The idea is to have a shared ibv_context that all the resources allocated on it (FT + TIR are exceptions) When ever a resource created locally an alias object to that resource allocated and it used in the other context. The connections between the resources are done according to each type of the

[PATCH V1 08/11] net/mlx5/hws: add vhca identifier ID to the caps

2022-12-21 Thread Erez Shitrit
And read it in the query_cap function Signed-off-by: Erez Shitrit Reviewed-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_cmd.c | 3 +++ drivers/net/mlx5/hws/mlx5dr_cmd.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.c b/drivers/net/mlx5/hws/mlx5dr_cm

Re: [PATCH] net/gve: add support for basic stats

2022-12-21 Thread Joshua Washington
Hello, As it turns out, this error actually propagates to the "total" stats as well, which I assume is just calculated by adding TX-packets and TX-dropped. Here are the full stats from the example that Rushil mentioned: -- Forward statistics for port 0 -

[PATCH v2 2/2] app/test-flow-perf: fix division or module by zero

2022-12-21 Thread Mohammad Iqbal Ahmad
Fix division or module by zero reported by coverity scan. Coverity issue: 373870 Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation") Signed-off-by: Mohammad Iqbal Ahmad --- app/test-flow-perf/main.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/

[PATCH v2 1/2] mailmap: add contributor to list

2022-12-21 Thread Mohammad Iqbal Ahmad
Add contributor to mailmap. Signed-off-by: Mohammad Iqbal Ahmad --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 75884b6fe2..464164765f 100644 --- a/.mailmap +++ b/.mailmap @@ -911,6 +911,7 @@ Mitch Williams Mit Matelske Mohamad Noor Alim Hussin Mo

[PATCH V1 07/11] net/mlx5/hws: added command to create alias objects

2022-12-21 Thread Erez Shitrit
From: Yevgeny Kliteynik Added support for a command that can create alias objects - objects that are accessed across VHCA. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Alex Vesker --- drivers/common/mlx5/mlx5_prm.h| 23 ++-- drivers/net/mlx5/hws/mlx5dr_cmd.c | 44 +++

[PATCH V1 05/11] net/mlx5/hws: read cross-vhca capabilities

2022-12-21 Thread Erez Shitrit
From: Yevgeny Kliteynik And keep them for future processing. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_cmd.c | 24 drivers/net/mlx5/hws/mlx5dr_cmd.h | 1 + 2 files changed, 25 insertions(+) diff --git a/drivers/net/ml

[PATCH V1 06/11] net/mlx5/hws: added allow-other-vhca-access command

2022-12-21 Thread Erez Shitrit
From: Yevgeny Kliteynik Added FW command to allow creation of alias objects. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Alex Vesker --- drivers/common/mlx5/mlx5_prm.h| 23 +++ drivers/net/mlx5/hws/mlx5dr_cmd.c | 28 drivers/net/mlx5/hws

[PATCH V1 04/11] net/mlx5/hws: add PRM definitions for cross-vhca capabilities

2022-12-21 Thread Erez Shitrit
From: Yevgeny Kliteynik Each new cap was defined. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Alex Vesker --- drivers/common/mlx5/mlx5_prm.h | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm

[PATCH V1 03/11] net/mlx5/hws: remove wrong PRM capability macros

2022-12-21 Thread Erez Shitrit
From: Yevgeny Kliteynik Removing macros for wrong capability checks. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Alex Vesker --- drivers/common/mlx5/mlx5_prm.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h index 19c

[PATCH V1 02/11] net/mlx5/hws: add capabilities fields for vhca access

2022-12-21 Thread Erez Shitrit
The new fields define the ability to access from one vhca to other one. Signed-off-by: Erez Shitrit Reviewed-by: Alex Vesker --- drivers/common/mlx5/mlx5_prm.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_p

[PATCH V1 01/11] mailmap: add new contributors to the list

2022-12-21 Thread Erez Shitrit
Added Yevgeny Kliteynik to the list Signed-off-by: Erez Shitrit --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 75884b6fe2..c6f34d18a6 100644 --- a/.mailmap +++ b/.mailmap @@ -1495,6 +1495,7 @@ Yash Sharma Yasufumi Ogawa Yelena Krivosheev Yerde

[PATCH V1 00/11] Support resource sharing among ibv_devices

2022-12-21 Thread Erez Shitrit
Add the option to use resources (Tables, Matchers, Actions, etc.) from one gvmi (AKA ibv_cntext) to other gvmi's. When specific gvmi allows other to use its resources, steering objects Will created and used on that gvmi. It is done by aliases objects that map between local resources to shared/rem

[PATCH v2] net/mlx5: add debug support for dumping all rte ports

2022-12-21 Thread Alex Vesker
Add a special value max_uint16 to request dump of all rte ethernet ports. This is useful for collecting the full info from all the ports in a single dump. Signed-off-by: Alex Vesker Reviewed-by: Ori Kam --- drivers/net/mlx5/linux/mlx5_socket.c | 39 ++-- 1 file changed,

RE: [RFC v3 2/2] ethdev: add API to set process to active or standby

2022-12-21 Thread Rongwei Liu
HI Jerin: BR Rongwei > -Original Message- > From: Jerin Jacob > Sent: Wednesday, December 21, 2022 17:13 > To: Rongwei Liu > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Ferruh Yigit > ; Andrew Rybchenko > ; dev@dpdk.org; Raslan Darawsheh >

Re: [PATCH] net/af_xdp: make compatible with libbpf v0.8.0

2022-12-21 Thread Kevin Traynor
On 21/12/2022 06:09, Andrew Rybchenko wrote: Hi Kevin, On 12/20/22 17:05, Kevin Traynor wrote: On 24/06/2022 11:23, Ciara Loftus wrote: libbpf v0.8.0 deprecates the bpf_get_link_xdp_id and bpf_set_link_xdp_fd functions. Use meson to detect if libbpf >= v0.7.0 is linked and if so, use the recom

Re: questions about crypto_scheduler

2022-12-21 Thread Zhang, Fan
Hi Zhangfei, The crypto scheduler PMD's session contains "sub-sessions" for all works, 1 sub-session per driver ID, to minimize the memory footprint. When configuring session, it configures the sub-sessions one by one. Since your UADK devices sharing the same driver ID, the crypto scheduler w

[PATCH 4/4] event/cnxk: restructure for cn10k datapath

2022-12-21 Thread Rahul Bhansali
Restructure for separate cn10k datapath functionality to reduce recompilation time in case of any changes in control path. New *_dp.h files are created to have macros, functions as required for datapath with minimal dependency on roc changes. Separates Tx and Rx datapath files to save recompilati

[PATCH 3/4] crypto/cnxk: include only files that are used

2022-12-21 Thread Rahul Bhansali
From: Anoob Joseph Inclusion of roc_api.h in all files would mean any change in RoC API would result in recompilation of all cnxk drivers. Address this issue in crypto_cnxk drivers by including only the headers that are required. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/cnxk_securit

[PATCH 2/4] net/cnxk: restructure for cn10k datapath

2022-12-21 Thread Rahul Bhansali
Restructure for separate cn10k datapath functionality to reduce recompilation time in case of any changes in control path. New cnxk_ethdev_dp.h and cn10k_rxtx.h files are created to have macros, functions as required for datapath with minimal dependency on roc changes. Signed-off-by: Rahul Bhansa

[PATCH 1/4] common/cnxk: restructure for cn10k datapath

2022-12-21 Thread Rahul Bhansali
Restructure for separate datapath functionality to reduce recompilation time. New *_dp.h are created to have macros, functions as required for datapath. Signed-off-by: Rahul Bhansali --- Depends-on: series-25906 ("[01/11] common/cnxk: free pending sqe buffers") Depends-on: series-26179 ("net/cnx

Re: [RFC v3 2/2] ethdev: add API to set process to active or standby

2022-12-21 Thread Jerin Jacob
On Wed, Dec 21, 2022 at 2:31 PM Rongwei Liu wrote: > > Users may want to change the DPDK process to different versions Different version of DPDK? If there is any ABI change how to support this? > such as hot upgrade. > There is a strong requirement to simplify the logic and shorten the > traffic

RE: [PATCH] net/iavf:fix slow memory allocation

2022-12-21 Thread You, KaisenX
> -Original Message- > From: David Marchand > Sent: 2022年12月20日 18:33 > To: You, KaisenX > Cc: Ferruh Yigit ; dev@dpdk.org; Burakov, Anatoly > ; sta...@dpdk.org; Yang, Qiming > ; Zhou, YidingX ; Wu, > Jingjing ; Xing, Beilei ; Zhang, > Qi Z ; Luca Boccassi ; Mcnamara, > John ; Kevin Tra

[RFC v3 2/2] ethdev: add API to set process to active or standby

2022-12-21 Thread Rongwei Liu
Users may want to change the DPDK process to different versions such as hot upgrade. There is a strong requirement to simplify the logic and shorten the traffic downtime as much as possible. This update introduces new rte_eth process role definitions: active or standby. The active role means rule

[RFC v3 1/2] ethdev: add group description

2022-12-21 Thread Rongwei Liu
Add more sentences to describe group concepts and define group 0 as root group for traffic to search a hit rule. Signed-off-by: Rongwei Liu --- lib/ethdev/rte_flow.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index b60987db4

[RFC v3 0/2] add API to set process to active or standby

2022-12-21 Thread Rongwei Liu
Set the rte_eth process to the active or standby role that affects the flow rules offloading which is userful when switching DPDK to a different version. v3: Use active/standby words to distinguish. Add new device capability bit. v2: Add more sentences to describe group concepts and define gro

[RFC 9/9] net/mlx5/hws: add modify IPv6 protocol implementation

2022-12-21 Thread Rongwei Liu
Add HWS modify IPv6 protocol implementation. Signed-off-by: Rongwei Liu --- drivers/common/mlx5/mlx5_prm.h | 1 + drivers/net/mlx5/mlx5_flow_dv.c | 10 ++ 2 files changed, 11 insertions(+) diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h index 1545b929b6..c

[RFC 8/9] app/testpmd: add modify IPv6 protocol command line

2022-12-21 Thread Rongwei Liu
Add new modify field destination type string: "ipv6_proto". Signed-off-by: Rongwei Liu --- app/test-pmd/cmdline_flow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 24fdb260e9..374c89d434 100644 --- a/app/tes

[RFC 7/9] ethdev: add modify IPv6 protocol field

2022-12-21 Thread Rongwei Liu
Add IPv6 protocol modify field definition. Signed-off-by: Rongwei Liu --- lib/ethdev/rte_flow.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index f8f1d6f9dd..b1240b0cb0 100644 --- a/lib/ethdev/rte_flow.h +++ b/lib/ethdev/rte_flow.h @@ -3567,6

[RFC 6/9] app/testpmd: add IPv6 routing extension header in raw encap

2022-12-21 Thread Rongwei Liu
Add IPv6 routing extension header support in raw_encap command. 1. No TLV support now. 2. Assume header length equals to the current segment_left. Signed-off-by: Rongwei Liu --- app/test-pmd/cmdline_flow.c | 17 + 1 file changed, 17 insertions(+) diff --git a/app/test-pmd/cmdlin

[RFC 5/9] net/mlx5/hws: add IPv6 routing extension matching support

2022-12-21 Thread Rongwei Liu
Add mlx5 HWS logic to match IPv6 routing extension header. Once detecting IPv6 matching extension items in pattern template create callback, PMD allocates a flex parser to sample the first dword of srv6 header. Only support next_hdr/segments_left/type for now. Signed-off-by: Rongwei Liu --- do

  1   2   >