RE: [PATCH] net/ixgbe: fix ixgbe firmware version get

2023-01-04 Thread He, ShiyangX
>-Original Message- >From: Morten Brørup >Sent: Thursday, January 5, 2023 2:57 PM >To: He, ShiyangX ; dev@dpdk.org >Cc: Zhou, YidingX ; sta...@dpdk.org; Yang, Qiming >; Wu, Wenjun1 ; Remy >Horton >Subject: RE: [PATCH] net/ixgbe: fix ixgbe firmware version get > >> From: He, ShiyangX [m

RE: [PATCH v2 1/2] eal: provide leading and trailing zero bit count abstraction

2023-01-04 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Thursday, 24 November 2022 00.43 > > Provide an abstraction for leading and trailing zero bit counting > functions to hide compiler specific intrinsics and builtins. > > Signed-off-by: Tyler Retzlaff > --- > lib/eal/include/me

RE: [PATCH] net/ixgbe: fix ixgbe firmware version get

2023-01-04 Thread Morten Brørup
> From: He, ShiyangX [mailto:shiyangx...@intel.com] > Sent: Thursday, 5 January 2023 03.52 > > >From: Morten Brørup > >Sent: Wednesday, January 4, 2023 6:19 PM > > > >> From: Shiyang He [mailto:shiyangx...@intel.com] > >> Sent: Wednesday, 4 January 2023 10.52 > >> > >> The firmware version obtain

RE: [PATCH] build: avoid deprecated function for Meson properties

2023-01-04 Thread Ruifeng Wang
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, January 4, 2023 7:37 PM > To: Ruifeng Wang ; Bruce Richardson > ; > Stanislaw Kardach > Cc: dev@dpdk.org; David Marchand > Subject: [PATCH] build: avoid deprecated function for Meson properties > > The function get_cross_p

RE: [PATCH] net/ixgbe: fix ixgbe firmware version get

2023-01-04 Thread He, ShiyangX
>-Original Message- >From: Morten Brørup >Sent: Wednesday, January 4, 2023 6:19 PM >To: He, ShiyangX ; dev@dpdk.org >Cc: Zhou, YidingX ; sta...@dpdk.org; Yang, Qiming >; Wu, Wenjun1 ; Remy >Horton >Subject: RE: [PATCH] net/ixgbe: fix ixgbe firmware version get > >> From: Shiyang He [ma

Re: [PATCH v2 0/2] eal: provide leading and trailing zero bit count

2023-01-04 Thread Tyler Retzlaff
hi just adding a few extra folks to the to line to try and get some reviewer attention since this patch has been sitting here for a while. the change is fairly straight forward, would just like to get it cleared. feedback is appreciated! thanks On Wed, Nov 23, 2022 at 03:43:15PM -0800, Tyler Re

Re: [PATCH v2 1/1] eal/linux: reject --huge-dir not parent of mountpt

2023-01-04 Thread Ashish Sadanandan
On Wed, Jan 4, 2023 at 9:22 AM John Levon wrote: > On Tue, Jan 03, 2023 at 05:00:30PM -0700, Ashish Sadanandan wrote: > > > The code added for allowing --huge-dir to specify hugetlbfs > > sub-directories has a bug where it incorrectly matches mounts that > > contain a prefix of the specified --hu

Re: [PATCH v2 1/1] eal/linux: reject --huge-dir not parent of mountpt

2023-01-04 Thread Ashish Sadanandan
On Wed, Jan 4, 2023 at 4:24 AM Dmitry Kozlyuk wrote: > 2023-01-03 17:00 (UTC-0700), Ashish Sadanandan: > > The code added for allowing --huge-dir to specify hugetlbfs > > sub-directories has a bug where it incorrectly matches mounts that > > contain a prefix of the specified --huge-dir. > > > > A

[PATCH v3 1/1] eal/linux: reject --huge-dir not parent of mountpt

2023-01-04 Thread Ashish Sadanandan
The code added for allowing --huge-dir to specify hugetlbfs sub-directories has a bug where it incorrectly matches mounts that contain a prefix of the specified --huge-dir. Consider --huge-dir=/dev/hugepages1G is passed to rte_eal_init. Given the following hugetlbfs mounts $ mount | grep hugetlbf

RE: [PATCH v1 6/6] baseband/acc: acc100 fix queue mapping to 64 bits

2023-01-04 Thread Chautru, Nicolas
> From: Vargas, Hernan > > Fix potential overflow for Q mapping extension to 64 bits. > > Fixes: 32e8b7ea35d ("baseband/acc100: refactor to segregate common > code") > > Signed-off-by: Hernan Vargas > --- (...) For the series, thanks Reviewed-by: Nicolas Chautru

RE: [PATCH v1 0/3] bbdev: remove offload cost

2023-01-04 Thread Chautru, Nicolas
Hi Maxime, I don’t see them on the baseband tree dpdk-next-baseband I did a clean clone, these are the last 3 commits dc0a5a0d2a (HEAD -> for-main, origin/for-main) test/bbdev: explicit check for allocation failure 0e927787a3 test/bbdev: fix build issue with optional build flag 51d49ccd2

Re: [PATCH v2 1/1] eal/linux: reject --huge-dir not parent of mountpt

2023-01-04 Thread John Levon
On Tue, Jan 03, 2023 at 05:00:30PM -0700, Ashish Sadanandan wrote: > The code added for allowing --huge-dir to specify hugetlbfs > sub-directories has a bug where it incorrectly matches mounts that > contain a prefix of the specified --huge-dir. Sorry for the trouble & thanks for the fix. > +

Re: [PATCH 2/6] app/dumpcap: fix storing port identifier

2023-01-04 Thread Stephen Hemminger
On Mon, 2 Jan 2023 16:24:37 + Ben Magistro wrote: > When dumpcap adds an interface, the port was not being preserved. This > results in the structure being initialized and the port field being set > to 0 regardless of what port was actually selected. This unset field is > then used in both t

Re: [PATCH 4/6] app/dumpcap: fix capturing on multiple interfaces

2023-01-04 Thread Stephen Hemminger
On Mon, 2 Jan 2023 16:24:39 + Ben Magistro wrote: > When selecting interfaces to capture traffic on, only the last interface > specified was being preserved for selection. This turns the interface > argument into an array allowing multiple interfaces to be selected. > > This also adds check

Re: [PATCH 5/6] app/dumpcap: improve per interface arg parsing

2023-01-04 Thread Stephen Hemminger
On Mon, 2 Jan 2023 16:24:40 + Ben Magistro wrote: > + > +/* struct representing args for each interface */ > +struct interface_opts { > + const char *intf_arg; > + const char *filter_str; > + bool promiscuous_mode; > + uint32_t snaplen; > +}; > +/* default parameters for inte

[PATCH v1 5/6] baseband/acc: acc100 ignore missing mempools

2023-01-04 Thread Hernan Vargas
Mempool not strictly required to be present in op for processing. Previous criteria too strict. No functional impact. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers

[PATCH v1 6/6] baseband/acc: acc100 fix queue mapping to 64 bits

2023-01-04 Thread Hernan Vargas
Fix potential overflow for Q mapping extension to 64 bits. Fixes: 32e8b7ea35d ("baseband/acc100: refactor to segregate common code") Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/baseband/acc/rt

[PATCH v1 4/6] baseband/acc: acc100 fix iteration counter in TB

2023-01-04 Thread Hernan Vargas
Use ldpc or turbo iteration counter based on the operation type. Fixes: 5ad5060f8f7 ("baseband/acc100: add LDPC processing functions") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff -

[PATCH v1 3/6] baseband/acc: acc100 free harq layout pointer

2023-01-04 Thread Hernan Vargas
Explicitly call rte_free for harq_layout pointer in dev_close function to prevent memory leak. Fixes: ba2262fe16c ("baseband/acc100: fix close cleanup") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH v1 0/6] baseband/acc: changes for 23.03

2023-01-04 Thread Hernan Vargas
Upstreaming ACC100 changes for 23.03. Hernan Vargas (6): baseband/acc: acc100 use define constant baseband/acc: acc100 use desc helper functions baseband/acc: acc100 free harq layout pointer baseband/acc: acc100 fix iteration counter in TB baseband/acc: acc100 ignore missing mempools b

[PATCH v1 2/6] baseband/acc: acc100 use desc helper functions

2023-01-04 Thread Hernan Vargas
Use the designated descriptor helper functions for descriptor address calculations. No functional impact. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 38 +-- 1 file changed, 13 insertions(+), 25 deletions(-) diff --git a/drivers/baseband/acc/

[PATCH v1 1/6] baseband/acc: acc100 use define constant

2023-01-04 Thread Hernan Vargas
Use define constant ACC_HARQ_ALIGN_64B instead of hardcoded number. No functional impact. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/r

RE: [PATCH v4 1/4] eal: add generic support for reading PMU events

2023-01-04 Thread Tomasz Duszynski
> -Original Message- > From: Mattias Rönnblom > Sent: Thursday, December 15, 2022 9:46 AM > To: Tomasz Duszynski ; dev@dpdk.org > Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; > m...@smartsharesystems.com; > zhou...@loongson.cn > Subject: [EXT] Re: [PATCH v4 1/4] eal: add generic s

RE: [EXT] [PATCH v2] test/crypto: add further ZUC testcases

2023-01-04 Thread Tejasree Kondoj
Acked-by: Tejasree Kondoj > -Original Message- > From: Ciara Power > Sent: Wednesday, December 21, 2022 7:56 PM > To: Akhil Goyal ; Fan Zhang > > Cc: dev@dpdk.org; kai...@intel.com; Ciara Power > Subject: [EXT] [PATCH v2] test/crypto: add further ZUC testcases > > External Email > >

Re: [PATCH v2] net/axgbe: add multi-process support

2023-01-04 Thread Ferruh Yigit
On 1/4/2023 11:45 AM, Jesna K E wrote: > Added multi-process support for axgbe PMD > To achieve multi-process support separate out TX and RX function > inside the axgbe driver and call that from a secondary process > when it is attaching to an already-configured NIC > > Signed-off-by: Jesna K E

[PATCH 3/3] crypto/cnxk: add support for SHAKE hash

2023-01-04 Thread Volodymyr Fialko
Add support for SHAKE hash and hmac operations Signed-off-by: Volodymyr Fialko --- doc/guides/cryptodevs/cnxk.rst| 2 + doc/guides/cryptodevs/features/cn10k.ini | 2 + doc/guides/cryptodevs/features/cn9k.ini | 2 + drivers/common/cnxk/roc_se.h | 4

[PATCH 2/3] app/test: add SHAKE test cases

2023-01-04 Thread Volodymyr Fialko
Add test cases for SHAKE hash algorithm for Digest and Digest-Verify. Signed-off-by: Volodymyr Fialko --- app/test/test_cryptodev_hash_test_vectors.h | 66 + 1 file changed, 66 insertions(+) diff --git a/app/test/test_cryptodev_hash_test_vectors.h b/app/test/test_cryptodev_

[PATCH 1/3] cryptodev: add SHAKE algorithm

2023-01-04 Thread Volodymyr Fialko
Add SHAKE to enum of auth algorithms. Signed-off-by: Volodymyr Fialko --- doc/guides/cryptodevs/features/default.ini | 2 ++ lib/cryptodev/rte_crypto_sym.h | 7 ++- lib/cryptodev/rte_cryptodev.c | 5 - 3 files changed, 12 insertions(+), 2 deletions(-) diff --git

[PATCH 0/3] Add support for SHAKE

2023-01-04 Thread Volodymyr Fialko
This series defines new enums for SHAKE128 and SHAKE256 authentication algorithms and implements support for CNXK crypto PMD. Depends-on: 26375 ("cryptodev: add algo enums to string conversion APIs") Volodymyr Fialko (3): cryptodev: add SHAKE algorithm app/test: add SHAKE test cases crypto/

Re: [PATCH v3] kni: fix possible alloc_q starvation when mbufs are exhausted

2023-01-04 Thread Ferruh Yigit
On 1/4/2023 11:57 AM, Matt wrote: > Hi Ferruh, > > In my case, the traffic is not large, so I can't see the impact. > I also tested under high load(>2Mpps with 2 DPDK cores and 2 kernel threads) > and found no significant difference in performance either. > I think the reason should be that it wil

Re: [PATCH v1 0/3] bbdev: remove offload cost

2023-01-04 Thread Maxime Coquelin
Hi Nicolas, On 1/3/23 23:07, Chautru, Nicolas wrote: Hi Maxime, Happy new year. Happy new year. What does the state " Awaiting Upstream" mean in patchwork for that serie? Can this be applied? It means it is the the bbdev tree, and is awaiting being pulled into the main tree. So it is ap

RE: [PATCH 3/3] app/crypto-perf: fix IPsec direction

2023-01-04 Thread Akhil Goyal
> Subject: [PATCH 3/3] app/crypto-perf: fix IPsec direction > > The default value of options->auth_op & options->cipher_op are such that > an unconditional check for the same would always return true. Hence, the > direction is always determined to be outbound/egress. > > The field options->aead_a

Re: [PATCH] build: avoid deprecated function for Meson properties

2023-01-04 Thread Stanisław Kardach
On Wed, Jan 4, 2023 at 12:36 PM Thomas Monjalon wrote: > > The function get_cross_property() has been deprecated in Meson 0.58, > and is replaced by the function get_external_property() introduced > in Meson 0.54. > > This replacement requires to raise the minimal accepted Meson version > from 0.5

[PATCH] net/mlx5: support ESP item in Verbs interface

2023-01-04 Thread Maayan Kashani
ESP item is not currently supported in Verbs interface. Validate/translate ESP item in Verbs interface. Signed-off-by: Maayan Kashani Acked-by: Matan Azrad --- doc/guides/nics/mlx5.rst| 3 ++ drivers/common/mlx5/linux/meson.build | 2 + drivers/net/mlx5/mlx5_flow_verbs.c

Re: [PATCH v3] kni: fix possible alloc_q starvation when mbufs are exhausted

2023-01-04 Thread Matt
Hi Ferruh, In my case, the traffic is not large, so I can't see the impact. I also tested under high load(>2Mpps with 2 DPDK cores and 2 kernel threads) and found no significant difference in performance either. I think the reason should be that it will not run to 'kni_fifo_count(kni->alloc_q) ==

RE: [EXT] Re: [PATCH] crypto/qat: fix build

2023-01-04 Thread Akhil Goyal
> On Fri, Dec 30, 2022 at 10:07:28PM +0100, Thomas Monjalon wrote: > > When trying to compile on a fresh system, I hit this error: > > > > intel-ipsec-mb.h:333: error: "AES_BLOCK_SIZE" redefined > > 333 | #define AES_BLOCK_SIZE IMB_AES_BLOCK_SIZE > > In file included from drivers/crypto/

RE: [EXT] [PATCH] crypto/qat: fix stream cipher direction

2023-01-04 Thread Akhil Goyal
> Stream ciphers use ENCRYPT mode in HW for both encryption and > decryption operations. This patch adds in an overwrite to always set > ENCRYPT mode for these algorithms. > > Fixes: d9b7d5bbc845 ("crypto/qat: add ZUC EEA3/EIA3 capability") > Cc: arkadiuszx.kusz...@intel.com > Cc: sta...@dpdk.org

[PATCH v2] net/axgbe: add multi-process support

2023-01-04 Thread Jesna K E
Added multi-process support for axgbe PMD To achieve multi-process support separate out TX and RX function inside the axgbe driver and call that from a secondary process when it is attaching to an already-configured NIC Signed-off-by: Jesna K E --- .mailmap | 1 +

RE: mailmap causing checkpatch warnings

2023-01-04 Thread Konstantin Ananyev
> > 24/12/2022 12:05, Morten Brørup: > > Bruce, David, > > > > I just submitted a patch with an Acked-by from Konstantin, using his > > current (Huawei) email address, and it triggered the following > checkpatch warning: > > Konstantin Ananyev mail differs from primary mail, please fix the comm

RE: [PATCH v2] net/mlx5: add debug support for dumping all rte ports

2023-01-04 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alex Vesker > Sent: Wednesday, December 21, 2022 12:10 PM > To: dev@dpdk.org > Cc: Slava Ovsiienko ; Matan Azrad > ; Raslan Darawsheh > Subject: [PATCH v2] net/mlx5: add debug support for dumping all rte ports > > Add a special value max_uint16 to reques

RE: [PATCH v2] net/mlx5: add stub functions to null drv ops

2023-01-04 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Asaf Penso > Sent: Wednesday, December 28, 2022 8:37 PM > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > Slava Ovsiienko ; Matan Azrad > ; Raslan Darawsheh > Subject: [PATCH v2] net/mlx5: add stub functions to null drv ops > > There ar

RE: [EXT] [dpdk-dev] [PATCH v1 1/1] compress/octeontx: async burst mode feature support

2023-01-04 Thread Akhil Goyal
> Async burst mode feature support is added, improves the single thread > compression/decompression throughput. > > Signed-off-by: Mahipal Challa Applied to dpdk-next-crypto Thanks.

[PATCH] build: avoid deprecated function for Meson properties

2023-01-04 Thread Thomas Monjalon
The function get_cross_property() has been deprecated in Meson 0.58, and is replaced by the function get_external_property() introduced in Meson 0.54. This replacement requires to raise the minimal accepted Meson version from 0.53.2 to 0.54.0. Signed-off-by: Thomas Monjalon --- config/arm/meson

RE: [PATCH] test/crypto: add scatter-gather test cases

2023-01-04 Thread Akhil Goyal
> Subject: [PATCH] test/crypto: add scatter-gather test cases > > Add test cases to verify scatter-gather (SGL) buffers, with multiple > segments. > > Signed-off-by: Volodymyr Fialko > Signed-off-by: Archana Muniganti Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

Re: [PATCH v2 1/1] eal/linux: reject --huge-dir not parent of mountpt

2023-01-04 Thread Dmitry Kozlyuk
2023-01-03 17:00 (UTC-0700), Ashish Sadanandan: > The code added for allowing --huge-dir to specify hugetlbfs > sub-directories has a bug where it incorrectly matches mounts that > contain a prefix of the specified --huge-dir. > > Consider --huge-dir=/dev/hugepages1G is passed to rte_eal_init. Giv

RE: [EXT] Re: [PATCH] crypto/qat: add SHA3 plain hash support

2023-01-04 Thread Akhil Goyal
> On 12/14/2022 4:26 PM, Ciara Power wrote: > > > Add support for plain SHA3-224, SHA3-256, > > SHA3-384, and SHA3-512 hash support in QAT GEN3. > > Add support for SHA3-256 in GEN2. > > > > Signed-off-by: Ciara Power > > > > --- > > Tested using testcases from patch not yet merged. > > https://p

RE: [PATCH] app/test: add SHA3 test cases

2023-01-04 Thread Akhil Goyal
> > Subject: [PATCH] app/test: add SHA3 test cases > > > > Add test cases for SHA3 hash family for Digest and Digest-Verify. > > > > Signed-off-by: Volodymyr Fialko > > > > Expected vectors were generated with OpenSSL. Adding to CC original > > authors of PMDs that currently have support for SHA3

Re: [PATCH] cryptodev: increase default max nb queue pairs

2023-01-04 Thread Zhang, Fan
On 1/4/2023 7:30 AM, Anoob Joseph wrote: Increase default maximum number of queue pairs to 64. For sw crypto PMDs, the number of queue pairs can be increased as required. The default value (which is set to 8), prevents usage of sw cryptodev PMDs with larger number of cores. Application would be

RE: [PATCH v5 2/4] eal: allow applications to report their cpu usage

2023-01-04 Thread Konstantin Ananyev
> > Konstantin Ananyev, Dec 22, 2022 at 13:41: > > > +static rte_lcore_usage_cb lcore_usage_cb; > > > + > > > +void > > > +rte_lcore_register_usage_cb(rte_lcore_usage_cb cb) > > > +{ > > > + lcore_usage_cb = cb; > > > +} > > > + > > > > LGTM in general. > > One question: I assume this function i

RE: [PATCH v5 2/4] eal: allow applications to report their cpu usage

2023-01-04 Thread Morten Brørup
> From: Robin Jarry [mailto:rja...@redhat.com] > Sent: Wednesday, 4 January 2023 11.14 > > Morten Brørup, Dec 16, 2022 at 11:47: > > > + usage_str[0] = '\0'; > > > + usage_cb = lcore_usage_cb; > > > + if (usage_cb != NULL && usage_cb(lcore_id, &usage) == 0) { > > > > Move memset() inside here, and

RE: [PATCH] net/ixgbe: fix ixgbe firmware version get

2023-01-04 Thread Morten Brørup
> From: Shiyang He [mailto:shiyangx...@intel.com] > Sent: Wednesday, 4 January 2023 10.52 > > The firmware version obtained by dpdk-ethtool is inconsistent with that > obtained by linux-ethtool. > > This commit fixes the issue. > > Fixes: 8b0b56574269 ("net/ixgbe: add firmware version get") > Cc

Re: [PATCH v5 2/4] eal: allow applications to report their cpu usage

2023-01-04 Thread Robin Jarry
Robin Jarry, Dec 16, 2022 at 11:21: > Allow applications to register a callback that will be invoked in > rte_lcore_dump() and when requesting lcore info in the telemetry API. > > The callback is expected to return the number of TSC cycles that have > passed since application start and the number o

Re: [PATCH v5 2/4] eal: allow applications to report their cpu usage

2023-01-04 Thread Robin Jarry
Morten Brørup, Dec 16, 2022 at 11:47: > > + usage_str[0] = '\0'; > > + usage_cb = lcore_usage_cb; > > + if (usage_cb != NULL && usage_cb(lcore_id, &usage) == 0) { > > Move memset() inside here, and add comment: > > + /* The application's callback may not set all the fields in the structure,

RE: [PATCH 00/17] fixes and improvements to cnxk crytpo PMD

2023-01-04 Thread Akhil Goyal
> Subject: [PATCH 00/17] fixes and improvements to cnxk crytpo PMD > > This series adds improvements and support for SHA3, > IPsec scatter gather mode in cnxk crypto PMD. > > Aakash Sasidharan (1): > common/cnxk: generate opad and ipad in driver > > Anoob Joseph (3): > common/cnxk: perform L

RE: [PATCH v3 1/3] ethdev: enable direct rearm with separate API

2023-01-04 Thread Morten Brørup
> From: Feifei Wang [mailto:feifei.wa...@arm.com] > Sent: Wednesday, 4 January 2023 09.51 > > Hi, Morten > > > 发件人: Morten Brørup > > 发送时间: Wednesday, January 4, 2023 4:22 PM > > > > > From: Feifei Wang [mailto:feifei.wa...@arm.com] > > > Sent: Wednesday, 4 January 2023 08.31 > > > > > > Add 'tx

Re: [PATCH v5 2/4] eal: allow applications to report their cpu usage

2023-01-04 Thread Robin Jarry
Konstantin Ananyev, Dec 22, 2022 at 13:41: > > +static rte_lcore_usage_cb lcore_usage_cb; > > + > > +void > > +rte_lcore_register_usage_cb(rte_lcore_usage_cb cb) > > +{ > > + lcore_usage_cb = cb; > > +} > > + > > LGTM in general. > One question: I assume this function is supposed to be called jus

[PATCH] net/ixgbe: fix ixgbe firmware version get

2023-01-04 Thread Shiyang He
The firmware version obtained by dpdk-ethtool is inconsistent with that obtained by linux-ethtool. This commit fixes the issue. Fixes: 8b0b56574269 ("net/ixgbe: add firmware version get") Cc: sta...@dpdk.org Signed-off-by: Shiyang He --- drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- 1 file changed,

RE: [PATCH 1/2] ethdev: add query_update sync and async function calls

2023-01-04 Thread Ori Kam
Hi Gregory, Some comments below, Also you are missing the release rst file update. > -Original Message- > From: Gregory Etelson > Sent: Wednesday, 21 December 2022 9:36 > > Current API allows either query or update indirect flow action. > If port hardware allows both update and query in

回复: [PATCH v3 1/3] ethdev: enable direct rearm with separate API

2023-01-04 Thread Feifei Wang
Hi, Morten > -邮件原件- > 发件人: Morten Brørup > 发送时间: Wednesday, January 4, 2023 4:22 PM > 收件人: Feifei Wang ; tho...@monjalon.net; > Ferruh Yigit ; Andrew Rybchenko > > 抄送: dev@dpdk.org; konstantin.v.anan...@yandex.ru; nd ; > Honnappa Nagarahalli ; Ruifeng Wang > > 主题: RE: [PATCH v3 1/3] eth

RE: [PATCH v3 1/3] ethdev: enable direct rearm with separate API

2023-01-04 Thread Morten Brørup
> From: Feifei Wang [mailto:feifei.wa...@arm.com] > Sent: Wednesday, 4 January 2023 08.31 > > Add 'tx_fill_sw_ring' and 'rx_flush_descriptor' API into direct rearm > mode for separate Rx and Tx Operation. And this can support different > multiple sources in direct rearm mode. For examples, Rx driv