Re: [PATCH] net/i40e: rework maximum frame size configuration

On Mon, Jan 16, 2023 at 1:15 PM Su, Simei wrote: > > Hi David, > > > -Original Message- > > From: David Marchand > > Sent: Monday, January 16, 2023 7:19 PM > > To: Su, Simei > > Cc: Xing, Beilei ; Zhang, Yuying > > ; dev@dpdk.org; Zhang, Qi Z > > ; Yang, Qiming ; > > sta...@dpdk.org; Zha

RE: [PATCH] examples/ptpclient: add signal handler for cleanup

Ping. > -Original Message- > From: Rahul Bhansali > Sent: Wednesday, November 2, 2022 10:21 PM > To: dev@dpdk.org; Kirill Rybalchenko > Subject: RE: [PATCH] examples/ptpclient: add signal handler for cleanup > > Ping. > > > -Original Message- > > From: Rahul Bhansali > > Sent:

[PATCH v3 10/10] bus/vdev: check result of rte_vdev_device_name

From: Sinan Kaya In rte_eth_vdev_allocate result of call to rte_vdev_device_name is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/ethdev/ethdev_vdev.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ethdev/ethdev_vdev.h b/lib/ethdev/ethdev_vdev.h index 364f140f

[PATCH v3 08/10] malloc: check result of malloc_elem_free

From: Sinan Kaya In malloc_heap_free result of call to malloc_elem_free is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/malloc_heap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/eal/common/malloc_heap.c b/lib/eal/common/malloc_heap.c index 8827

[PATCH v3 09/10] malloc: check result of elem_start_pt

From: Sinan Kaya In malloc_elem_alloc result of call to elem_start_pt is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/malloc_elem.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/eal/common/malloc_elem.c b/lib/eal/common/malloc_elem.c index 8f4981

[PATCH v3 07/10] malloc: check result of rte_mem_virt2memseg

From: Sinan Kaya In malloc_elem_find_max_iova_contig result of call to rte_mem_virt2memseg is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/malloc_elem.c | 11 --- lib/eal/common/malloc_heap.c | 2 +- 2 files changed, 9 insertions(+), 4 deletions(-)

[PATCH v3 06/10] malloc: check result of rte_fbarray_get

From: Sinan Kaya In eal_memalloc_is_contig result of call to rte_fbarray_get is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/eal_common_memalloc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/eal/common/eal_common_memalloc.c b/

[PATCH v3 05/10] malloc: check result of rte_mem_virt2memseg_list

From: Sinan Kaya In alloc_pages_on_heap result of call to rte_mem_virt2memseg_list is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/malloc_heap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/eal/common/malloc_heap.c b/lib/eal/common/malloc_heap.c

[PATCH v3 04/10] malloc: malloc_elem_join_adjacent_free can return null

From: Sinan Kaya In malloc_heap_add_memory result of call to malloc_elem_join_adjacent_free is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/malloc_heap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/eal/common/malloc_heap.c b/lib/eal/common/mallo

[PATCH v3 03/10] memzone: check result of malloc_elem_from_data

From: Sinan Kaya In memzone_reserve_aligned_thread_unsafe result of call to malloc_elem_from_data is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/eal_common_memzone.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/eal/common/eal_common_memzone.c

[PATCH v3 01/10] ethdev: check return result of rte_eth_dev_info_get

From: Sinan Kaya rte_class_eth: eth_mac_cmp: The status of this call to rte_eth_dev_info_get is not checked, potentially leaving dev_info uninitialized. Signed-off-by: Sinan Kaya --- lib/ethdev/rte_class_eth.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/ethdev/rt

[PATCH v3 00/10] codeql fixes for various subsystems

From: Sinan Kaya Following up the codeql reported problems first submitted by Stephen Hemminger here: https://lore.kernel.org/all/20220527161210.77212d0b@hermes.local/t/ Posting a series of fixes about potential null pointer accesses. Changes from v3: - Dropped net/tap: check if name is null -

[PATCH v3 02/10] memzone: check result of rte_fbarray_get

From: Sinan Kaya In memzone_lookup_thread_unsafe result of call to rte_fbarray_get is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/eal_common_memzone.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/eal/common/eal_common_memzone.

Re: [PATCH v2 5/5] ethdev: telemetry xstats support hide zero

Hi Bruce, On 2023/1/11 22:08, Bruce Richardson wrote: > On Wed, Jan 11, 2023 at 12:06:30PM +, Chengwen Feng wrote: >> The number of xstats may be large, after the hide zero option is added, >> only non-zero values can be displayed. >> >> Signed-off-by: Chengwen Feng >> --- >> lib/ethdev/rte_

[PATCH v4 0/5] support dmadev/ethdev stats reset

This patchset contains dmadev/ethdev stats reset, and also support hide zero for ethdev xstats and two telemetry related bugs. Chengwen Feng (5): dmadev: support stats reset telemetry command telemetry: fix repeat display when callback don't init dict ethdev: add newline to telemetry log str

[PATCH v4 5/5] ethdev: telemetry xstats support hide zero

The number of xstats may be large, after the hide zero option is added, only non-zero values can be displayed. Signed-off-by: Chengwen Feng --- lib/ethdev/rte_ethdev.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethde

[PATCH v4 4/5] ethdev: support xstats reset telemetry command

The xstats reset is useful for debugging, so add it to the ethdev telemetry command lists. Signed-off-by: Chengwen Feng --- lib/ethdev/rte_ethdev.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index 9eeae61024.

[PATCH v4 1/5] dmadev: support stats reset telemetry command

The stats reset is useful for debugging, so add it to the dmadev telemetry command lists. Signed-off-by: Chengwen Feng Reviewed-by: Bruce Richardson --- lib/dmadev/rte_dmadev.c | 43 + 1 file changed, 43 insertions(+) diff --git a/lib/dmadev/rte_dmadev.c

[PATCH v4 2/5] telemetry: fix repeat display when callback don't init dict

When a telemetry callback doesn't initialize the telemetry data structure and returns a non-negative number, the telemetry will repeat to display the last result. This patch zero the data structure to avoid the problem. Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality") Cc: sta...@dpdk

[PATCH v4 3/5] ethdev: add newline to telemetry log string

The telemetry related code may invoke RTE_ETHDEV_LOG to display information, the newline character is not added automatically to the RTE_ETHDEV_LOG, therefore, the newline character must be explicitly added to the log string. Fixes: 5514319e7b43 ("telemetry: fix passing full params string to comma

[PATCH v3 3/5] ethdev: add newline to telemetry log string

The telemetry related code may invoke RTE_ETHDEV_LOG to display information, the newline character is not added automatically to the RTE_ETHDEV_LOG, therefore, the newline character must be explicitly added to the log string. Fixes: 5514319e7b43 ("telemetry: fix passing full params string to comma

[PATCH v3 5/5] ethdev: telemetry xstats support hide zero

The number of xstats may be large, after the hide zero option is added, only non-zero values can be displayed. Signed-off-by: Chengwen Feng --- lib/ethdev/rte_ethdev.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethde

[PATCH v3 2/5] telemetry: fix repeat display when callback don't init dict

When a telemetry callback doesn't initialize the telemetry data structure and returns a non-negative number, the telemetry will repeat to display the last result. This patch zero the data structure to avoid the problem. Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality") Cc: sta...@dpdk

[PATCH v3 4/5] ethdev: support xstats reset telemetry command

The xstats reset is useful for debugging, so add it to the ethdev telemetry command lists. Signed-off-by: Chengwen Feng --- lib/ethdev/rte_ethdev.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index 9eeae61024.

[PATCH v3 1/5] dmadev: support stats reset telemetry command

The stats reset is useful for debugging, so add it to the dmadev telemetry command lists. Signed-off-by: Chengwen Feng Reviewed-by: Bruce Richardson --- lib/dmadev/rte_dmadev.c | 43 + 1 file changed, 43 insertions(+) diff --git a/lib/dmadev/rte_dmadev.c

[PATCH v3 0/5] support dmadev/ethdev stats reset

This patchset contains dmadev/ethdev stats reset, and also support hide zero for ethdev xstats and two telemetry related bugs. Chengwen Feng (5): dmadev: support stats reset telemetry command telemetry: fix repeat display when callback don't init dict ethdev: add newline to telemetry log str

[PATCH 2/2] net/mana: enable driver by default

From: Long Li The dependencies of mana have been released in rdma-core v44 and Linux kernel 6.2. Signed-off-by: Long Li --- MAINTAINERS | 2 +- drivers/net/meson.build | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 9a0f416d2e..7

[PATCH 1/2] net/mana: add version information for dependencies

From: Long Li The required dependencies for mana from rdma-core and Linux kernel have been released. Add those information to the doc. Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment") Signed-off-by: Long Li --- doc/guides/nics/mana.rst | 8 +++- 1 file changed, 3 i

Re: net/bnxt: wrong link status when lsc_intr is used

On Thu, Jan 19, 2023 at 5:37 AM Edwin Brossette wrote: > > Hello, > snip > I was wondering if patching the code to move this line which sets lsc > interrupt on somewhere else might be reasonable, or if this could cause > further trouble. Maybe having a parameter to trigger it ON/OFF m

[PATCH v6 4/4] eal: add PMU support to tracing library

In order to profile app one needs to store significant amount of samples somewhere for an analysis latern on. Since trace library supports storing data in a CTF format lets take adventage of that and add a dedicated PMU tracepoint. Signed-off-by: Tomasz Duszynski --- app/test/test_trace_perf.c

[PATCH v6 3/4] pmu: support reading Intel x86_64 PMU events in runtime

Add support for reading Intel x86_64 PMU events in runtime. Signed-off-by: Tomasz Duszynski --- app/test/test_pmu.c | 2 ++ lib/pmu/meson.build | 1 + lib/pmu/rte_pmu.h| 2 ++ lib/pmu/rte_pmu_pmc_x86_64.h | 24 4 files changed, 29 inserti

[PATCH v6 2/4] pmu: support reading ARM PMU events in runtime

Add support for reading ARM PMU events in runtime. Signed-off-by: Tomasz Duszynski --- app/test/test_pmu.c | 4 ++ lib/pmu/meson.build | 7 +++ lib/pmu/pmu_arm64.c | 94 + lib/pmu/rte_pmu.h | 4 ++ lib/pmu/rte_pmu_pmc_arm64

[PATCH v6 1/4] lib: add generic support for reading PMU events

Add support for programming PMU counters and reading their values in runtime bypassing kernel completely. This is especially useful in cases where CPU cores are isolated (nohz_full) i.e run dedicated tasks. In such cases one cannot use standard perf utility without sacrificing latency and performa

[PATCH v6 0/4] add support for self monitoring

This series adds self monitoring support i.e allows to configure and read performance measurement unit (PMU) counters in runtime without using perf utility. This has certain adventages when application runs on isolated cores with nohz_full kernel parameter. Events can be read directly using rte_pm

Re: [PATCH v4 1/9] eal: annotate spinlock, rwlock and seqlock

On Thu, Jan 19, 2023 at 10:16:35PM +0100, David Marchand wrote: > On Thu, Jan 19, 2023 at 9:39 PM Tyler Retzlaff > wrote: > > > > On Thu, Jan 19, 2023 at 11:42:02AM -0800, Stephen Hemminger wrote: > > > On Thu, 19 Jan 2023 19:46:12 +0100 > > > David Marchand wrote: > > > > > > > +#ifndef __DOXYGE

[PATCH] doc: add capability to access physical addresses

DAC_READ_SEARCH or DAC_OVERRIDE capability is required to access /proc/self/pagemap, but the Linux guide mentioned neither one. Recommend DAC_READ_SEARCH as less impactful. Fixes: 979bb5d493fb ("doc: add more instructions for running as non-root") Cc: sta...@dpdk.org Signed-off-by: Dmitry Kozlyuk

Re: [PATCH v4 1/9] eal: annotate spinlock, rwlock and seqlock

On Thu, Jan 19, 2023 at 9:39 PM Tyler Retzlaff wrote: > > On Thu, Jan 19, 2023 at 11:42:02AM -0800, Stephen Hemminger wrote: > > On Thu, 19 Jan 2023 19:46:12 +0100 > > David Marchand wrote: > > > > > +#ifndef __DOXYGEN__ > > > + __rte_exclusive_lock_function(&seqlock->lock) > > > +#endif > > >

Re: [PATCH v4 1/9] eal: annotate spinlock, rwlock and seqlock

On Thu, Jan 19, 2023 at 8:42 PM Stephen Hemminger wrote: > > On Thu, 19 Jan 2023 19:46:12 +0100 > David Marchand wrote: > > > +#ifndef __DOXYGEN__ > > + __rte_exclusive_lock_function(&seqlock->lock) > > +#endif > > { > > Would be cleaner any required ifdefs was in rte_lock_annotations > rath

Re: [PATCH v4 1/9] eal: annotate spinlock, rwlock and seqlock

On Thu, Jan 19, 2023 at 11:42:02AM -0800, Stephen Hemminger wrote: > On Thu, 19 Jan 2023 19:46:12 +0100 > David Marchand wrote: > > > +#ifndef __DOXYGEN__ > > + __rte_exclusive_lock_function(&seqlock->lock) > > +#endif > > { > > Would be cleaner any required ifdefs was in rte_lock_annotations

Re: [PATCH v4 1/9] eal: annotate spinlock, rwlock and seqlock

On Thu, 19 Jan 2023 19:46:12 +0100 David Marchand wrote: > clang offers some thread safety checks, statically verifying that locks > are taken and released in the code. > To use those checks, the full code leading to taking or releasing locks > must be annotated with some attributes. > > Wrap th

Re: [PATCH v6 5/5] telemetry: add /eal/lcore/usage endpoint

On 19/01/2023 15:06, Robin Jarry wrote: Allow fetching CPU cycles usage for all lcores with a single request. This endpoint is intended for repeated and frequent invocations by external monitoring systems and therefore returns condensed data. It consists of a single dictionary with three keys: "

Re: [PATCH v6 4/5] testpmd: report lcore usage

On 19/01/2023 15:06, Robin Jarry wrote: Reuse the --record-core-cycles option to account for busy cycles. One turn of packet_fwd_t is considered "busy" if there was at least one received or transmitted packet. Add a new busy_cycles field in struct fwd_stream. Update get_end_cycles to accept an a

Re: [PATCH v6 3/5] testpmd: add dump_lcores command

On 19/01/2023 15:06, Robin Jarry wrote: Add a simple command that calls rte_lcore_dump(). Signed-off-by: Robin Jarry Acked-by: Morten Brørup Acked-by: Konstantin Ananyev --- Notes: v5 -> v6: No change app/test-pmd/cmdline.c | 3 +++ 1 file changed, 3 insertions(+) Reviewed-by: Kev

Re: [PATCH v6 2/5] eal: allow applications to report their cpu usage

On 19/01/2023 15:06, Robin Jarry wrote: Allow applications to register a callback that will be invoked in rte_lcore_dump() and when requesting lcore info in the telemetry API. The callback is expected to return the number of TSC cycles that have passed since application start and the number of t

Re: [PATCH v6 1/5] eal: add lcore info in telemetry

On 19/01/2023 15:06, Robin Jarry wrote: Report the same information than rte_lcore_dump() in the telemetry API into /eal/lcore/list and /eal/lcore/info,ID. Example: --> /eal/lcore/info,3 { "/eal/lcore/info": { "lcore_id": 3, "socket": 0, "role": "RTE", "cp

RE: [PATCH v4 0/9] vhost lock annotations

> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Thursday, 19 January 2023 19.46 > > vhost internals involves multiple locks to protect data access by > multiple threads. > > This series uses clang thread safety checks [1] to catch issues during > compilation: EAL spinlock, seqlo

[PATCH v4 9/9] vhost: enable lock check

Now that all locks in this library are annotated, we can enable the check. Signed-off-by: David Marchand --- lib/vhost/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/vhost/meson.build b/lib/vhost/meson.build index bc7272053b..197a51d936 100644 --- a/lib/vhost/meson.build +

[PATCH v4 8/9] vhost: annotate vDPA device list accesses

Access to vdpa_device_list must be protected with vdpa_device_list_lock spinlock. Signed-off-by: David Marchand --- Changes since RFC v3: - rebased, --- lib/vhost/vdpa.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/lib/vhost/vdpa.c b/lib/vhost/vdpa.c

[PATCH v4 7/9] vhost: annotate IOTLB lock

The starting point for this is __vhost_iova_to_vva() which requires the lock to be taken. Annotate all the code leading to a call to it. vdpa and vhost_crypto code are annotated but they end up not taking a IOTLB lock and have been marked with a FIXME at the top level. Signed-off-by: David Marcha

[PATCH v4 6/9] vhost: always take IOTLB lock

clang does not support conditionally held locks when statically analysing taken locks with thread safety checks. Always take iotlb locks regardless of VIRTIO_F_IOMMU_PLATFORM feature. Signed-off-by: David Marchand --- lib/vhost/vhost.c | 8 +++- lib/vhost/virtio_net.c | 24

[PATCH v4 5/9] vhost: annotate async accesses

vq->async is initialised and must be accessed under vq->access_lock. Signed-off-by: David Marchand --- Changes since RFC v3: - rebased, - fixed annotations vq->access_lock -> &vq->access_lock, - reworked free_vq, --- lib/vhost/vhost.c | 4 lib/vhost/vhost.h | 2 +- lib/vhost/vh

[PATCH v4 4/9] vhost: annotate virtqueue access lock

vhost_user_lock/unlock_all_queue_pairs must be waived since clang annotations can't express taking a runtime number of locks. vhost_queue_stats_update() requirement can be expressed with a required tag. Signed-off-by: David Marchand --- Changes since RFC v3: - removed annotations needed for vhos

[PATCH v4 3/9] vhost: terminate when access lock is not taken

Be a bit more strict when a programmatic error is detected wrt to the access_lock not being taken. Mark the new helper with __rte_assert_exclusive_lock so that clang understands where locks are expected to be taken. Signed-off-by: David Marchand --- lib/vhost/vhost.c | 18 +++---

[PATCH v4 2/9] vhost: simplify need reply handling

Dedicate send_vhost_slave_message() helper to the case when no reply is needed. Add a send_vhost_slave_message_process_reply() helper for the opposite. This new helper merges both send_vhost_slave_message() and the code previously in process_slave_message_reply(). The slave_req_lock lock is then o

[PATCH v4 1/9] eal: annotate spinlock, rwlock and seqlock

clang offers some thread safety checks, statically verifying that locks are taken and released in the code. To use those checks, the full code leading to taking or releasing locks must be annotated with some attributes. Wrap those attributes into our own set of macros. rwlock, seqlock and the "no

[PATCH v4 0/9] vhost lock annotations

vhost internals involves multiple locks to protect data access by multiple threads. This series uses clang thread safety checks [1] to catch issues during compilation: EAL spinlock, seqlock and rwlock are annotated and vhost code is instrumented so that clang can statically check correctness. Tho

Re: [PATCH] examples/cmdline: fix build error with gcc 12

On Thu, Jan 19, 2023 at 08:44:41AM -0800, Stephen Hemminger wrote: > On Thu, 19 Jan 2023 08:59:10 + > Bruce Richardson wrote: > > > > > struct object { > > > > SLIST_ENTRY(object) next; > > > > > > I confirm it solves the build warning, but what about to get rid of > > > `OBJ_NAME

Re: [PATCH] net/mana: disable driver by default

19/01/2023 17:32, Long Li: > > Subject: Re: [PATCH] net/mana: disable driver by default > > > > 19/01/2023 15:49, Ferruh Yigit: > > > On 10/13/2022 12:47 PM, Ferruh Yigit wrote: > > > > Driver is disabled by default because its dependencies are not > > > > upstreamed yet, code is available for dev

[PATCH v4] app/testpmd: fix interactive mode with no ports

Testpmd terminated unconditionally if it failed to start all ports. The patch allows testpmd to get into the command line, if the interactive mode was requested. Fixes: 6937d2103e22 ("app/testpmd: add option to not start device") Cc: step...@networkplumber.org Cc: sta...@dpdk.org Signed-off-by:

Re: [PATCH v3] app/testpmd: fix interactive mode with no ports

On Thu, 19 Jan 2023 19:23:12 +0200 Gregory Etelson wrote: > + if (!no_device_start && start_port(RTE_PORT_ALL) != 0) { > + fprintf(stderr, "Start ports failed\n"); > + if (!interactive) { > + rte_eal_cleanup(); > + rte_exit(EXIT_

[PATCH v3] app/testpmd: fix interactive mode with no ports

Testpmd terminated unconditionally if it failed to start all ports. The patch allows testpmd to get into the command line, if the interactive mode was requested. Fixes: 6937d2103e22 ("app/testpmd: add option to not start device") Cc: step...@networkplumber.org Cc: sta...@dpdk.org Signed-off-by:

[PATCH v3] app/testpmd: fix interactive mode with no ports

Testpmd terminated unconditionally if it failed to start all ports. The patch allows testpmd to get into the command line, if the interactive mode was requested. Fixes: 6937d2103e22 ("app/testpmd: add option to not start device") Cc: step...@networkplumber.org Cc: sta...@dpdk.org Signed-off-by:

Re: [EXT] Re: [PATCH v2 2/3] graph: pcap capture for graph nodes

On Thu, 19 Jan 2023 14:37:49 + Amit Prakash Shukla wrote: > > > > One other option is to add a new custom block type or options in pcapng. > > Keep comment as a string, since that is what wireshark etc no how to handle. > > Also, packet id data might be useful for graph. > > I gave a try

[PATCH v6 2/2] ethdev: add quota flow action and item

Quota action limits traffic according to pre-defined configuration. Quota reflects overall traffic usage regardless bandwidth. Quota flow action initialized with signed tokens number value. Quota flow action updates tokens number according to these rules: 1. if quota was configured to count packet

[PATCH v6 1/2] ethdev: add query_update sync and async function calls

Current API allows either query or update indirect flow action. If indirect action must be conditionally updated according to it's present state application must first issue action query then analyze returned data and if needed issue update request. When the update will be processed, action state c

RE: [PATCH v6 5/5] telemetry: add /eal/lcore/usage endpoint

> From: Robin Jarry [mailto:rja...@redhat.com] > Sent: Thursday, 19 January 2023 17.35 > > Morten Brørup, Jan 19, 2023 at 17:21: > > In the future, the rte_lcore_usage structure may contain more fields, > > and some may not be related to the TSC. So consider removing "cycles" > > from the descript

Re: [PATCH] examples/cmdline: fix build error with gcc 12

On Thu, 19 Jan 2023 08:59:10 + Bruce Richardson wrote: > > > struct object { > > > SLIST_ENTRY(object) next; > > > > I confirm it solves the build warning, but what about to get rid of > > `OBJ_NAME_LEN_MAX` completely if the intentions is to make size same as > > cmdline library array:

Re: [PATCH v6 5/5] telemetry: add /eal/lcore/usage endpoint

Morten Brørup, Jan 19, 2023 at 17:21: > In the future, the rte_lcore_usage structure may contain more fields, > and some may not be related to the TSC. So consider removing "cycles" > from the description of the telemetry path. > > Don't waste time changing it unless you are providing a new patch >

RE: [PATCH] net/mana: disable driver by default

> Subject: Re: [PATCH] net/mana: disable driver by default > > 19/01/2023 15:49, Ferruh Yigit: > > On 10/13/2022 12:47 PM, Ferruh Yigit wrote: > > > Driver is disabled by default because its dependencies are not > > > upstreamed yet, code is available for development and investigation. > > > > > >

RE: [PATCH v6 5/5] telemetry: add /eal/lcore/usage endpoint

> From: Robin Jarry [mailto:rja...@redhat.com] > Sent: Thursday, 19 January 2023 16.07 > > Allow fetching CPU cycles usage for all lcores with a single request. > This endpoint is intended for repeated and frequent invocations by > external monitoring systems and therefore returns condensed data.

Re: [PATCH v3 00/10] dts: add hello world testcase

Everything looks good to me with the exception of some issues I ran into with terminal codes. Setting TERM=dumb before running fixed it, but we might want to set that inside of DTS since I can't think of a reason why we would need colors or any of the other "fancy" features of the vt220, and settin

Re: [PATCH] net/mana: disable driver by default

19/01/2023 15:49, Ferruh Yigit: > On 10/13/2022 12:47 PM, Ferruh Yigit wrote: > > Driver is disabled by default because its dependencies are not > > upstreamed yet, code is available for development and investigation. > > > > When all dependencies are upstreamed, driver can be enabled back. > > >

Re: [PATCH v8] testpmd: cleanup cleanly from signal

On 11/12/2022 5:28 PM, Stephen Hemminger wrote: > Do a clean shutdown of testpmd when a signal is received; > instead of having testpmd kill itself. > This fixes the problem where a signal could be received > in the middle of a PMD and then the signal handler would call > PMD's close routine leadin

RE: [PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration

> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, January 18, 2023 12:10 PM > To: Koikkara Reeny, Shibin ; > dev@dpdk.org; Burakov, Anatoly ; Richardson, > Bruce > Cc: Loftus, Ciara > Subject: RE: [PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration > > > > > -Original Me

Re: [PATCH v2] app/testpmd: fix interactive mode with no ports

On 11/16/2022 4:23 AM, Singh, Aman Deep wrote: > Hi Gregory, > > Thanks for the patch. > > On 11/9/2022 10:39 PM, Gregory Etelson wrote: >> Testpmd terminated unconditionally if it failed to start all ports. >> >> The patch allows testpmd to get into the command line, >> if the interactive mode w

[PATCH v6 4/5] testpmd: report lcore usage

Reuse the --record-core-cycles option to account for busy cycles. One turn of packet_fwd_t is considered "busy" if there was at least one received or transmitted packet. Add a new busy_cycles field in struct fwd_stream. Update get_end_cycles to accept an additional argument for the number of proce

[PATCH v6 3/5] testpmd: add dump_lcores command

Add a simple command that calls rte_lcore_dump(). Signed-off-by: Robin Jarry Acked-by: Morten Brørup Acked-by: Konstantin Ananyev --- Notes: v5 -> v6: No change app/test-pmd/cmdline.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c i

[PATCH v6 5/5] telemetry: add /eal/lcore/usage endpoint

Allow fetching CPU cycles usage for all lcores with a single request. This endpoint is intended for repeated and frequent invocations by external monitoring systems and therefore returns condensed data. It consists of a single dictionary with three keys: "lcore_ids", "total_cycles" and "busy_cycle

[PATCH v6 2/5] eal: allow applications to report their cpu usage

Allow applications to register a callback that will be invoked in rte_lcore_dump() and when requesting lcore info in the telemetry API. The callback is expected to return the number of TSC cycles that have passed since application start and the number of these cycles that were spent doing busy wor

[PATCH v6 1/5] eal: add lcore info in telemetry

Report the same information than rte_lcore_dump() in the telemetry API into /eal/lcore/list and /eal/lcore/info,ID. Example: --> /eal/lcore/info,3 { "/eal/lcore/info": { "lcore_id": 3, "socket": 0, "role": "RTE", "cpuset": [ 3 ] } } Signed-off-

[PATCH v6 0/5] lcore telemetry improvements

This is a follow up on previous work by Kevin Laatz: http://patches.dpdk.org/project/dpdk/list/?series=24658&state=* This series is aimed at allowing DPDK applications to expose their CPU usage stats in the DPDK telemetry under /eal/lcore/info. This is a much more basic and naive approach which l

Re: [PATCH] vdpa/ifc: improve device stop logic for block device

On 12/13/22 08:37, Andy Pei wrote: For block device, we make sure no IO is inflight before we stop device. We terminate the notify relay process and wait for all inflight IOs to be completed. So in this period, we wait for hardware to update used index, there is no need to relay new kick. Sig

Re: [PATCH] vdpa/ifc: fix reconnetion issue in SW assisted live migration

On 12/12/22 08:12, Andy Pei wrote: In the case using argument "sw-live-migration=1" to enable SW assisted live migration, we take QEMU as front end for example, after source VM migrates to destination VM, we keep vdpa process for source VM there, we kill the QEMU process for source VM, and res

Re: [PATCH v7] net/tap: Allow jumbo frames

On 8/8/2022 4:03 PM, Stephen Hemminger wrote: > On Mon, 8 Aug 2022 16:49:44 +0200 > Francesco Mancino wrote: > >> eth_dev_validate_mtu, introduced in 990912e676e, validates configured >> MTU plus overhead against max_rx_pktlen. >> Since TAP is a virtual device, it should support as big MTU as pos

Re: [PATCH] net/mana: disable driver by default

On 10/13/2022 12:47 PM, Ferruh Yigit wrote: > Driver is disabled by default because its dependencies are not > upstreamed yet, code is available for development and investigation. > > When all dependencies are upstreamed, driver can be enabled back. > > Fixes: 517ed6e2d590 ("net/mana: add basic d

Re: [PATCH V5] ethdev: fix one address occupies two indexes in MAC addrs

Hi, You missed some questions and comments below. 19/01/2023 10:57, lihuisong (C): > 在 2023/1/18 16:26, Thomas Monjalon 写道: > > 20/10/2022 11:31, Huisong Li: > >> The dev->data->mac_addrs[0] will be changed to a new MAC address when > >> applications modify the default MAC address by .mac_addr_se

RE: [EXT] Re: [PATCH v2 2/3] graph: pcap capture for graph nodes

Hi Stephen, Thanks for the reply. Please find my reply in-line. > -Original Message- > From: Stephen Hemminger > Sent: Thursday, January 12, 2023 10:00 PM > To: Amit Prakash Shukla > Cc: Jerin Jacob Kollanukkaran ; Kiran Kumar > Kokkilagadda ; Nithin Kumar Dabilpuram > ; dev@dpdk.org >

Re: [PATCH V4 0/5] app/testpmd: support mulitple process attach and detach port

19/01/2023 11:31, lihuisong (C): > 在 2023/1/18 22:12, Thomas Monjalon 写道: > > 11/01/2023 11:46, Ferruh Yigit: > >> On 1/11/2023 10:27 AM, Ferruh Yigit wrote: > >>> On 1/11/2023 12:53 AM, lihuisong (C) wrote: > 在 2023/1/11 0:51, Ferruh Yigit 写道: > > Hi Huisong, > > > > I haven't che

RE: [EXT] Re: [PATCH v3 2/3] graph: pcap capture for graph nodes

Thanks Jerin for the code review and feedback. I will make the suggested changes in next version of the patch. > -Original Message- > From: Jerin Jacob > Sent: Thursday, January 12, 2023 5:48 PM > To: Amit Prakash Shukla > Cc: Jerin Jacob Kollanukkaran ; Kiran Kumar > Kokkilagadda ; Nit

Re: [PATCH RESEND v2 01/11] ethdev: check return result of rte_eth_dev_info_get

On 11/22/2022 3:30 PM, ok...@kernel.org wrote: > From: Sinan Kaya > > rte_class_eth: eth_mac_cmp: The status of this call to rte_eth_dev_info_get > is not checked, potentially leaving dev_info uninitialized. > > Signed-off-by: Sinan Kaya > --- > lib/ethdev/rte_class_eth.c | 4 +++- > 1 file ch

ICE DDP Load assistance

Hello, We are still trying to track this down but want to reach out to the community and see if there is something obvious we are missing. This happens to be a CentOS 7 based host with DPDK 22.11.1 in use. We have obtained the latest compatible Intel drivers and DDP from https://sourceforge.net/

Re: [PATCH v4] vdpa/ifc: Match default subsystem IDs for modern virtio-blk devices

Hi Abhishek, On 12/15/22 04:48, Abhishek Maheshwari wrote: Amending the match table for vdpa/ifcvf driver to work with virtio-blk devices that have default subsystem IDs. Cc: sta...@dpdk.org Is that really a fix? If so, you need to add the Fixes tag so that LTS maintainers know on which LTS i

RE: [EXT] [PATCH] graph: fix node shrink

> -Original Message- > From: David Marchand > Sent: 19 January 2023 04:03 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Jerin Jacob Kollanukkaran ; Kiran > Kumar Kokkilagadda ; Nithin Kumar Dabilpuram > ; Pavan Nikhilesh Bhagavatula > > Subject: [EXT] [PATCH] graph: fix node shrink > >

[PATCH v5 2/2] ethdev: add quota flow action and item

Quota action limits traffic according to pre-defined configuration. Quota reflects overall traffic usage regardless bandwidth. Quota flow action initialized with signed tokens number value. Quota flow action updates tokens number according to these rules: 1. if quota was configured to count packet

[PATCH v5 1/2] ethdev: add query_update sync and async function calls

Current API allows either query or update indirect flow action. If indirect action must be conditionally updated according to it's present state application must first issue action query then analyze returned data and if needed issue update request. When the update will be processed, action state c

RE: [PATCH 1/4] net/mlx5/hws: definitions for Hash Split/Linear Lookup tbls

Hello, ci/iol-testing tried to apply this patchset on the main branch, even though it's intended for dpdk-next-net-mlx: https://patches.dpdk.org/project/dpdk/patch/20230112134913.2632849-1-klit...@nvidia.com/ The helper script in dpdk-ci repo reports dpdk-next-net-mlx: $ ./tools/pw_maintainers_c

Re: [PATCH] net/nfp: update descriptors logic

On 11/22/2022 1:09 PM, Niklas Söderlund wrote: > From: Jin Liu > > The minimum value of TX/RX descriptors for NFP3800 card is not same > with NFP4000 card, the minimum value of NFP4000 card is 256 while > NFP3800 card is 512, add the minimum descriptor macro for NFP3800 > card. > > Modify the lo

[PATCH 2/2] net/vhost: support private dump

This patch implements eth_dev_priv_dump callback which could use for debugging. Signed-off-by: Chengwen Feng --- drivers/net/vhost/rte_eth_vhost.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c ind

[PATCH 1/2] net/virtio: support private dump

This patch implements eth_dev_priv_dump callback which could use for debugging. Signed-off-by: Chengwen Feng --- drivers/net/virtio/virtio_ethdev.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c in

[PATCH 0/2] add private dump for vhost and virtio

This patch addes private dump for vhost and virtio PMDs. Chengwen Feng (2): net/virtio: support private dump net/vhost: support private dump drivers/net/vhost/rte_eth_vhost.c | 21 + drivers/net/virtio/virtio_ethdev.c | 19 +++ 2 files changed, 40 inserti

  1   2   >