RE: [PATCH v5] mempool cache: add zero-copy get and put functions

2023-01-22 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.v.anan...@yandex.ru] > Sent: Sunday, 22 January 2023 21.35 > > Hi Morten, > > Few nits, see below. > Also I still think we do need a test case for _zc_get_ before > accepting it in the mainline. Poking at my bad conscience... :-) It's on my todo-lis

Re: [RFC] ethdev: add template table insertion and matching types

2023-01-22 Thread Thomas Monjalon
21/01/2023 00:06, Alexander Kozyrev: > > 14/12/2022 03:21, Alexander Kozyrev: > > > Bring more flexibility and control over both flow rule insertion > > > and packet matching mechanisms. Introduce 2 new flow table types: > > > > > > 1. Allow a user to specify the insertion type used in template tab

Re: [PATCH v3 10/10] bus/vdev: check result of rte_vdev_device_name

2023-01-22 Thread Thomas Monjalon
20/01/2023 17:47, Stephen Hemminger: > On Thu, 19 Jan 2023 23:41:40 -0500 > ok...@kernel.org wrote: > > > diff --git a/lib/ethdev/ethdev_vdev.h b/lib/ethdev/ethdev_vdev.h > > index 364f140f91..6d94a65d97 100644 > > --- a/lib/ethdev/ethdev_vdev.h > > +++ b/lib/ethdev/ethdev_vdev.h > > @@ -34,6 +34,

Re: [PATCH v5] mempool cache: add zero-copy get and put functions

2023-01-22 Thread Konstantin Ananyev
Hi Morten, Few nits, see below. Also I still think we do need a test case for _zc_get_ before accepting it in the mainline. With that in place: Acked-by: Konstantin Ananyev Zero-copy access to mempool caches is beneficial for PMD performance, and must be provided by the mempool library to fix

Re: [PATCH v2 2/2] ring: add ring info telemetry cmd

2023-01-22 Thread Konstantin Ananyev
This patch supports dump of the info of ring by its name. An example using this command is shown below: --> /ring/info,MP_mb_pool_0 { "/ring/info": { "name": "MP_mb_pool_0", "socket": 0, "flags": 0, "producer_type": "MP", "consumer_type": "MC", "size": 262144,

Re: [PATCH v2 1/2] ring: add ring list telemetry cmd

2023-01-22 Thread Konstantin Ananyev
Hi Jie, This patch supports the list of rings with telemetry cmd. An example using this command is shown below: --> /ring/list { "/ring/list": [ "HT_:7d:00.2", "MP_mb_pool_0" ] } Signed-off-by: Jie Hai --- lib/ring/meson.build | 1 + lib/ring/rte_ring.c | 40 +

Re: [PATCH v3 7/7] ip_frag: fix whitespace

2023-01-22 Thread Konstantin Ananyev
17/01/2023 00:14, Stephen Hemminger пишет: The style standard is to use blank after keywords. I.e "if (" not "if(" Signed-off-by: Stephen Hemminger --- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ip_frag/rte_ipv4_reassembly.c b/l

Re: [PATCH v4 0/3] Split logging functionality out of EAL

2023-01-22 Thread David Marchand
Hi Bruce, On Fri, Jan 20, 2023 at 7:22 PM Bruce Richardson wrote: > > There is a general desire to reduce the size and scope of EAL. To this > end, this patchset makes a (very) small step in that direction by taking > the logging functionality out of EAL and putting it into its own library > that

Re: [PATCH v6 0/5] add rte_thread_set_name API for rte_thread_t

2023-01-22 Thread David Marchand
On Wed, Jan 18, 2023 at 8:54 PM Tyler Retzlaff wrote: > > Replace the rte_thread_setname API which operates on pthread_t with > rte_thread_set_name that operates on rte_thread_t. > > We should try to align tracing output from the EAL for all platforms > but in this case we are retaining an excepti

Re: [PATCH v2 0/8] start cleanup of rte_flow_item_*

2023-01-22 Thread David Marchand
Hi Ferruh, Thomas, On Fri, Jan 20, 2023 at 6:19 PM Ferruh Yigit wrote: > > There was a plan to have structures from lib/net/ at the beginning > of corresponding flow item structures. > Unfortunately this plan has not been followed up so far. > This series is a step to make the most used items, >