[PATCH v2 3/3] net/cnxk: skip red drop for ingress policer

2023-01-24 Thread Rakesh Kudurumalla
Dropping of packets is based on action configured to meter.If both skip_red and drop actions are configured then tail dropping in invoked else if only drop action is configured then RED drop is invoked.This action is supported only when RED is configured using rte_eth_cman_config_set() Signed-off-

[PATCH v2 1/3] lib: skip congestion management configuration

2023-01-24 Thread Rakesh Kudurumalla
Skip the congestion management configuration applied using rte_eth_cman_config_set() API on the given ethdev Rx queue. Signed-off-by: Rakesh Kudurumalla --- V2: Rename action name to skip congestion management lib/ethdev/rte_flow.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib

[PATCH v2 2/3] app/testpmd: add skip cman support for testpmd

2023-01-24 Thread Rakesh Kudurumalla
added support for testpmd application to accept skip_cman action while configuring policy action Signed-off-by: Rakesh Kudurumalla --- app/test-pmd/cmdline_flow.c | 9 + 1 file changed, 9 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 88108498

RE: [PATCH] compressdev: fix end of comp PMD list macro conflict

2023-01-24 Thread Michael Baum
Hi All, any comments? From: Michael Baum > The "rte_compressdev_info_get()" function retrieves the contextual information > of a device. > The output structure "dev_info" contains a list of devices supported > capabilities > for each supported algorithm. > > In this function description, it s

RE: [EXT] Re: [PATCH v2 2/4] net/cnxk: restructure for cn10k datapath

2023-01-24 Thread Rahul Bhansali
> -Original Message- > From: Jerin Jacob > Sent: Wednesday, January 25, 2023 10:29 AM > To: Rahul Bhansali > Cc: dev@dpdk.org; Nithin Kumar Dabilpuram ; > Kiran Kumar Kokkilagadda ; Sunil Kumar Kori > ; Satha Koteswara Rao Kottidi > ; Jerin Jacob Kollanukkaran > Subject: [EXT] Re: [PAT

Re: [PATCH] eventdev/timer: fix overflow issue

2023-01-24 Thread Jerin Jacob
On Wed, Jan 25, 2023 at 8:17 AM Stephen Hemminger wrote: > > On Tue, 24 Jan 2023 10:09:45 -0600 > Erik Gabriel Carrillo wrote: > > > The software timer adapter converts event timer timeout ticks to a > > number of CPU cycles at which an rte_timer should expire. The > > computation uses integer op

Re: [PATCH v2 2/4] net/cnxk: restructure for cn10k datapath

2023-01-24 Thread Jerin Jacob
On Wed, Jan 18, 2023 at 3:57 PM Rahul Bhansali wrote: > > Restructure for separate cn10k datapath functionality to reduce > recompilation time in case of any changes in control path. > > New cnxk_ethdev_dp.h and cn10k_rxtx.h files are created to have > macros, functions as required for datapath wi

Re: [PATCH v2 1/3] eventdev/eth_rx: add params set/get APIs

2023-01-24 Thread Jerin Jacob
On Tue, Jan 24, 2023 at 6:37 PM Naga Harish K, S V wrote: > > Hi Jerin, > > > -Original Message- > > From: Jerin Jacob > > Sent: Tuesday, January 24, 2023 10:00 AM > > To: Naga Harish K, S V > > Cc: jer...@marvell.com; Carrillo, Erik G ; > > Gujjar, > > Abhinandan S ; dev@dpdk.org; Jaya

Re: [EXT] [PATCH] app/testeventdev: add crypto producer burst mode

2023-01-24 Thread Jerin Jacob
On Tue, Jan 17, 2023 at 9:00 PM Shijith Thotton wrote: > > >Add ability to set enqueue burst size for crypto producer. > > > >Existing parameter `--prod_enq_burst_sz` can be used in combination with > >`--prod_type_cryptodev` to enable burst enqueue for crypto producer. > > > >Example: > >./dp

Re: [PATCH] eventdev/timer: fix overflow issue

2023-01-24 Thread Stephen Hemminger
On Tue, 24 Jan 2023 10:09:45 -0600 Erik Gabriel Carrillo wrote: > The software timer adapter converts event timer timeout ticks to a > number of CPU cycles at which an rte_timer should expire. The > computation uses integer operations that can result in overflow. > > Use floating point operation

Reminder - DPDK DTS Working Group Tomorrow 1/25/23 @ 6am PT/9am ET/1500h CET

2023-01-24 Thread Nathan Southern
Good evening, Tomorrow DPDK will hold its DTS Working Group at 6am PT/9am ET/1500h CET. Zoom information to follow. We look forward to seeing you there. Thanks, Nathan Nathan C. Southern, Project Coordinator Data Plane Development Kit The Linux Foundation 248.835.4812 (mobile) nsouth...@li

[PATCH v2] eventdev/timer: fix overflow issue

2023-01-24 Thread Erik Gabriel Carrillo
The software timer adapter converts event timer timeout ticks to a number of CPU cycles at which an rte_timer should expire. The computation uses integer operations that can result in overflow. Use floating point operations instead to perform the computation, and convert the final result back to a

Re: [PATCH v9 4/4] eal: deprecation notice for rte thread setname API

2023-01-24 Thread Tyler Retzlaff
On Tue, Jan 24, 2023 at 07:05:18PM +0100, Thomas Monjalon wrote: > 24/01/2023 19:02, Tyler Retzlaff: > > +* eal: The function ``rte_thread_setname`` is planned to be deprecated > > + starting with the 23.03 release subject to the replacement API > > + rte_thread_set_name being marked as stable an

Re: [PATCH v5 1/2] ethdev: fix ethdev configuration state on reset

2023-01-24 Thread Ferruh Yigit
On 1/18/2023 10:29 AM, Thomas Monjalon wrote: > 21/12/2022 03:07, Hanumanth Pothula: >> Presently, on device reset, ethdev configuration state, >> dev_configured, is not reset. >> >> On device reset, reset ethdev configuration state to make >> sure device reconfiguration happens cleanly. >> >> Sign

[PATCH v10 1/4] eal: add thread set name API operating on rte thread

2023-01-24 Thread Tyler Retzlaff
Add a rte_thread_set_name that sets the name of an rte_thread_t thread. This is a replacement for the rte_thread_setname(pthread_t, ...) which exposes platform-specific details. Introduces Windows implementation for rte_thread_set_name not previously available on Windows. Adapt drivers/mlx5 to us

[PATCH v10 2/4] eal: remove thread getname API

2023-01-24 Thread Tyler Retzlaff
Remove the rte_thread_getname API. The API is __rte_experimental and requires no deprecation notice. Fold the platform specific variants into the one place it is used as a special case to retain the functionality for linux only. Adjust the function as follows. * reduce scope where thread_get_nam

[PATCH v10 4/4] eal: deprecation notice for rte thread setname API

2023-01-24 Thread Tyler Retzlaff
Notify deprecation of rte_thread_setname API, it will be removed as it exposes platform-specific thread details. The functionality it provided is now available via the new rte_lcore_set_name API. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: David Marchand --- doc/guides/rel_

[PATCH v10 3/4] eal: set thread name on Windows worker threads

2023-01-24 Thread Tyler Retzlaff
Bring Windows EAL worker thread initialization in line with linux & freebsd by setting the worker thread name using the new platform agnostic rte_thread_set_name API. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- lib/eal/windows/eal.c | 7 +++ 1 file changed, 7 insertions(+) di

[PATCH v10 0/4] add rte_thread_set_name API for rte_thread_t

2023-01-24 Thread Tyler Retzlaff
v10: * change intended deprecation of rte_thread_setname from 23.03 to 23.07 v9: * fix typo in v8 deprecation notice picked up by ci v8: * document that no implementation or internal implementation failure is a noop for rte_thread_set_name * update commit message to indicate w

Re: [PATCH v9 4/4] eal: deprecation notice for rte thread setname API

2023-01-24 Thread Thomas Monjalon
24/01/2023 19:02, Tyler Retzlaff: > +* eal: The function ``rte_thread_setname`` is planned to be deprecated > + starting with the 23.03 release subject to the replacement API > + rte_thread_set_name being marked as stable and planned to be removed > + by the 23.11 release. You are introducing r

Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-01-24 Thread Ferruh Yigit
On 12/21/2022 2:07 AM, Hanumanth Pothula wrote: > Presently, Rx metadata is sent to PMD by default, leading > to a performance drop as processing for the same in Rx path > takes extra cycles. > > Hence, add new testpmd command, > 'enable port nic_to_pmd_rx_metadata' > > This command helps in s

[PATCH v9 1/4] eal: add thread set name API operating on rte thread

2023-01-24 Thread Tyler Retzlaff
Add a rte_thread_set_name that sets the name of an rte_thread_t thread. This is a replacement for the rte_thread_setname(pthread_t, ...) which exposes platform-specific details. Introduces Windows implementation for rte_thread_set_name not previously available on Windows. Adapt drivers/mlx5 to us

[PATCH v9 4/4] eal: deprecation notice for rte thread setname API

2023-01-24 Thread Tyler Retzlaff
Notify deprecation of rte_thread_setname API, it will be removed as it exposes platform-specific thread details. The functionality it provided is now available via the new rte_lcore_set_name API. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: David Marchand --- doc/guides/rel_

[PATCH v9 3/4] eal: set thread name on Windows worker threads

2023-01-24 Thread Tyler Retzlaff
Bring Windows EAL worker thread initialization in line with linux & freebsd by setting the worker thread name using the new platform agnostic rte_thread_set_name API. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- lib/eal/windows/eal.c | 7 +++ 1 file changed, 7 insertions(+) di

[PATCH v9 2/4] eal: remove thread getname API

2023-01-24 Thread Tyler Retzlaff
Remove the rte_thread_getname API. The API is __rte_experimental and requires no deprecation notice. Fold the platform specific variants into the one place it is used as a special case to retain the functionality for linux only. Adjust the function as follows. * reduce scope where thread_get_nam

[PATCH v9 0/4] add rte_thread_set_name API for rte_thread_t

2023-01-24 Thread Tyler Retzlaff
v9: * fix typo in v8 deprecation notice picked up by ci v8: * document that no implementation or internal implementation failure is a noop for rte_thread_set_name * update commit message to indicate windows now provides an implementation for rte_thread_set_name * remove '_' from th

[RFCv2 2/2] test/mempool: add zero-copy API's

2023-01-24 Thread Kamalakshitha Aligeri
Added mempool test cases with zero-copy get and put API's Signed-off-by: Kamalakshitha Aligeri --- Link: https://patchwork.dpdk.org/project/dpdk/patch/20221227151700.80887-1...@smartsharesystems.com/ 1. Added mempool test cases with zero-copy get and put API's app/test/test_mempool.c | 124 +++

[RFCv2 1/2] net/i40e: replace get and put functions

2023-01-24 Thread Kamalakshitha Aligeri
Integrated zero-copy get and put API's in mempool cache in i40e PMD Signed-off-by: Kamalakshitha Aligeri --- Link: https://patchwork.dpdk.org/project/dpdk/patch/20221227151700.80887-1...@smartsharesystems.com/ 1. Added support for mempools without cache (Morten Brorup) .mailmap

[PATCH v8 4/4] eal: deprecation notice for rte thread setname API

2023-01-24 Thread Tyler Retzlaff
Notify deprecation of rte_thread_setname API, it will be removed as it exposes platform-specific thread details. The functionality it provided is now available via the new rte_lcore_set_name API. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: David Marchand --- doc/guides/rel_

[PATCH v8 3/4] eal: set thread name on Windows worker threads

2023-01-24 Thread Tyler Retzlaff
Bring Windows EAL worker thread initialization in line with linux & freebsd by setting the worker thread name using the new platform agnostic rte_thread_set_name API. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- lib/eal/windows/eal.c | 7 +++ 1 file changed, 7 insertions(+) di

[PATCH v8 2/4] eal: remove thread getname API

2023-01-24 Thread Tyler Retzlaff
Remove the rte_thread_getname API. The API is __rte_experimental and requires no deprecation notice. Fold the platform specific variants into the one place it is used as a special case to retain the functionality for linux only. Adjust the function as follows. * reduce scope where thread_get_nam

[PATCH v8 1/4] eal: add thread set name API operating on rte thread

2023-01-24 Thread Tyler Retzlaff
Add a rte_thread_set_name that sets the name of an rte_thread_t thread. This is a replacement for the rte_thread_setname(pthread_t, ...) which exposes platform-specific details. Introduces Windows implementation for rte_thread_set_name not previously available on Windows. Adapt drivers/mlx5 to us

[PATCH v8 0/4] add rte_thread_set_name API for rte_thread_t

2023-01-24 Thread Tyler Retzlaff
v8: * document that no implementation or internal implementation is a noop for rte_thread_set_name * update commit message to indicate windows now provides an implementation for rte_thread_set_name * remove '_' from thread_name in comment * squish drivers/mlx5 patch into patch 1 as

[PATCH] test/crypto: add missing MAC-I to PDCP vectors

2023-01-24 Thread Volodymyr Fialko
Existing PDCP 12-bit C/U-plane output vectors with NULL encryption + NULL integrity do not contain the MAC-I (32-bit of all zeros according to the specification). Vectors for other SN length (5, 18 bits) have the MAC-I set. Fixes: d883e6e7131b ("test/crypto: add PDCP C-Plane encap cases") Fixes: c

Re: [PATCH 0/8] Add the features for nfp include VLAN strip, QinQ strip, VLAN insert

2023-01-24 Thread Ferruh Yigit
On 11/28/2022 6:53 AM, Chaoyong He wrote: > Add support for QinQ strip > Add support for VLAN strip > Add support for VLAN insert with NFD3 > Add support for VLAN insert with NFDk > > Peng Zhang (8): > net/nfp: break out function to report device information > net/nfp: modify the logic of pars

[PATCH] eventdev/timer: fix overflow issue

2023-01-24 Thread Erik Gabriel Carrillo
The software timer adapter converts event timer timeout ticks to a number of CPU cycles at which an rte_timer should expire. The computation uses integer operations that can result in overflow. Use floating point operations instead to perform the computation, and convert the final result back to a

Re: [PATCH v7 5/5] eal: deprecation notice for rte thread setname API

2023-01-24 Thread Thomas Monjalon
23/01/2023 20:39, Tyler Retzlaff: > Notify deprecation of rte_thread_setname API, it will be removed as it > exposes platform-specific thread details. The functionality it provided > is now available via the new rte_lcore_set_name API. > > Signed-off-by: Tyler Retzlaff > > Acked-by: Morten Brøru

Re: [PATCH v7 4/5] drivers: mlx5 use rte thread set name

2023-01-24 Thread Thomas Monjalon
23/01/2023 20:39, Tyler Retzlaff: > Use the new internal rte_thread_set_name API instead of the now > deprecated rte_thread_setname API. I think it should be squashed with the first patch, while introducing the new function.

Re: [PATCH v7 3/5] eal: set thread name on Windows worker threads

2023-01-24 Thread Thomas Monjalon
24/01/2023 16:33, Tyler Retzlaff: > On Tue, Jan 24, 2023 at 04:25:34PM +0100, Thomas Monjalon wrote: > > 23/01/2023 20:39, Tyler Retzlaff: > > > Bring Windows EAL worker thread initialization in line with linux & > > > freebsd by setting the worker thread name using the new > > > platform agnostic

Re: [PATCH v7 2/5] eal: remove thread getname API

2023-01-24 Thread Tyler Retzlaff
On Tue, Jan 24, 2023 at 04:24:04PM +0100, Thomas Monjalon wrote: > 23/01/2023 20:39, Tyler Retzlaff: > > Remove the rte_thread_getname API. The API is __rte_experimental and > > requires no deprecation notice. > > You should give a justification in this commit log, > and note the removal in the re

Re: [PATCH v7 3/5] eal: set thread name on Windows worker threads

2023-01-24 Thread Tyler Retzlaff
On Tue, Jan 24, 2023 at 04:25:34PM +0100, Thomas Monjalon wrote: > 23/01/2023 20:39, Tyler Retzlaff: > > Bring Windows EAL worker thread initialization in line with linux & > > freebsd by setting the worker thread name using the new > > platform agnostic rte_thread_set_name API. > > > > Signed-off

Re: [PATCH v7 3/5] eal: set thread name on Windows worker threads

2023-01-24 Thread Thomas Monjalon
23/01/2023 20:39, Tyler Retzlaff: > Bring Windows EAL worker thread initialization in line with linux & > freebsd by setting the worker thread name using the new > platform agnostic rte_thread_set_name API. > > Signed-off-by: Tyler Retzlaff > > Acked-by: Morten Brørup > > --- > lib/eal/window

Re: [PATCH v7 2/5] eal: remove thread getname API

2023-01-24 Thread Thomas Monjalon
23/01/2023 20:39, Tyler Retzlaff: > Remove the rte_thread_getname API. The API is __rte_experimental and > requires no deprecation notice. You should give a justification in this commit log, and note the removal in the release notes (removed items). > Fold the platform specific variants into the

Re: [PATCH v7 1/5] eal: add thread set name API operating on rte thread

2023-01-24 Thread Thomas Monjalon
23/01/2023 20:39, Tyler Retzlaff: > Add a rte_thread_set_name that sets the name of an rte_thread_t thread. > This is a replacement for the rte_thread_setname(pthread_t, ...) which > exposes platform-specific details. > > Signed-off-by: Tyler Retzlaff > > Acked-by: Morten Brørup > > --- > lib

Re: [PATCH v2 3/4] net/mlx5: remove weak stub functions

2023-01-24 Thread Thomas Monjalon
23/01/2023 20:42, Dmitry Kozlyuk: > 2023-01-12 21:37 (UTC+0100), Thomas Monjalon: > > The vector Rx functions are conditionally compiled. > > Some stub functions were also always compiled with weak attribute. > > If there is no vector support, the weak functions were linked. > > > > These weak fun

[RFC PATCH 6/6] config/arm: add AMD CDX

2023-01-24 Thread Nipun Gupta
Adding support for AMD CDX devices Signed-off-by: Nipun Gupta --- config/arm/arm64_cdx_linux_gcc | 17 + config/arm/meson.build | 15 +++ 2 files changed, 32 insertions(+) create mode 100644 config/arm/arm64_cdx_linux_gcc diff --git a/config/arm/arm64_cdx_li

[RFC PATCH 5/6] bus: enable cdx bus

2023-01-24 Thread Nipun Gupta
enable compilation of cdx bus Signed-off-by: Nipun Gupta --- drivers/bus/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bus/meson.build b/drivers/bus/meson.build index 45eab5233d..884470234c 100644 --- a/drivers/bus/meson.build +++ b/drivers/bus/meson.build @@ -7,6 +7,7

[RFC PATCH 4/6] bus/cdx: support plug unplug and dev iterator

2023-01-24 Thread Nipun Gupta
Add support for plugging and unplugging CDX devices on the CDX bus. Also, CDX dev iterator support has been added for the CDX bus. Signed-off-by: Nipun Gupta --- drivers/bus/cdx/cdx.c | 142 +++--- drivers/bus/cdx/rte_bus_cdx.h | 1 + 2 files changed, 133 in

[RFC PATCH 3/6] bus/cdx: add support for MSI

2023-01-24 Thread Nipun Gupta
MSI's are exposed to the devices using VFIO (vfio-cdx). This patch uses the same to add support for MSI for the devices on the cdx bus. Signed-off-by: Nipun Gupta --- drivers/bus/cdx/cdx.c | 11 ++ drivers/bus/cdx/cdx_vfio.c | 182 - drivers/

[RFC PATCH 1/6] bus/cdx: introduce cdx bus

2023-01-24 Thread Nipun Gupta
CDX bus supports multiple type of devices, which can be exposed to user-space via vfio-cdx. vfio-cdx provides the MMIO IO_MEMORY regions as well as the DMA interface for the device (IOMMU). This support aims to enable the DPDK to support the cdx devices in user-space using VFIO interface. Signed

[RFC PATCH 2/6] bus/cdx: add dma map and unmap support

2023-01-24 Thread Nipun Gupta
CDX bus can use VFIO interface for mapping and unmapping of DMA addresses in the IOMMU. This change adds the callback support for map and unmap APIs as well as fetching the IOMMU class. Signed-off-by: Nipun Gupta --- drivers/bus/cdx/cdx.c | 40 1 file cha

[RFC PATCH 0/6] add support for CDX bus

2023-01-24 Thread Nipun Gupta
Support AMD CDX bus, for FPGA based CDX devices. The CDX devices are memory mapped on system bus for embedded CPUs. It uses sysfs interface and the vfio-cdx driver to discover and initialize the CDX devices. The patches are intended for DPDK 23.07 release, and have been sent as an RFC as patches

RE: [RFC 1/5] ethdev: add port affinity match item

2023-01-24 Thread Jiawei(Jonny) Wang
Hi, > > > > > > 21/12/2022 11:29, Jiawei Wang: > > > > + /** > > > > +* Matches on the physical port affinity of the received packet. > > > > +* > > > > +* See struct rte_flow_item_port_affinity. > > > > +*/ > > > > + RTE_FLOW_ITEM_TYPE_PORT_AFFINITY, >

[PATCH 1/1] mailmap: update contributor entry

2023-01-24 Thread Ivan Malov
Signed-off-by: Ivan Malov --- .mailmap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index 452267a567..c2b4578ace 100644 --- a/.mailmap +++ b/.mailmap @@ -529,7 +529,7 @@ Itsuro Oda Ivan Boule Ivan Dyukov Ivan Ilchenko -Ivan Malov +Ivan Malov I

RE: [RFC 2/5] ethdev: introduce the affinity field in Tx queue API

2023-01-24 Thread Jiawei(Jonny) Wang
Hi, > 18/01/2023 15:44, Jiawei(Jonny) Wang: > > > 21/12/2022 11:29, Jiawei Wang: > > > > For the multiple hardware ports connect to a single DPDK port > > > > (mhpsdp), the previous patch introduces the new rte flow item to > > > > match the port affinity of the received packets. > > > > > > > > T

RE: [PATCH v2 1/3] eventdev/eth_rx: add params set/get APIs

2023-01-24 Thread Naga Harish K, S V
Hi Jerin, > -Original Message- > From: Jerin Jacob > Sent: Tuesday, January 24, 2023 10:00 AM > To: Naga Harish K, S V > Cc: jer...@marvell.com; Carrillo, Erik G ; Gujjar, > Abhinandan S ; dev@dpdk.org; Jayatheerthan, > Jay > Subject: Re: [PATCH v2 1/3] eventdev/eth_rx: add params set/g

[PATCH v2] mailmap: update contributor entry

2023-01-24 Thread Viacheslav Galaktionov
Signed-off-by: Viacheslav Galaktionov --- v2: Preserve the old email address to keep shortlog -se happy. .mailmap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index 452267a567..ecd7129c1f 100644 --- a/.mailmap +++ b/.mailmap @@ -1376,7 +1376,7 @@ Venka

Re: [EXT] [PATCH] app/testeventdev: add vector worker to perf test

2023-01-24 Thread Jerin Jacob
On Tue, Jan 17, 2023 at 8:59 PM Shijith Thotton wrote: > > > >Add worker for handling vector events to perf tests, vector events could > >be generated by crypto adapter producer. > > > >Example: > >./dpdk-test-eventdev -l 0-2 -a -a -- \ > >--prod_type_cryptodev --crypto_adptr_mode 1 --te

[PATCH v4 3/3] l3fwd-graph: changes to configure pcap capture

2023-01-24 Thread Amit Prakash Shukla
Added support to configure pcap capture. Signed-off-by: Amit Prakash Shukla --- v2: - Fixed code style issue - Fixed CI compilation issue on github-robot v3: - Code review suggestion from Stephen - Fixed potential memory leak v4: - Code review suggestion from Jerin doc/guides/sample_app

[PATCH v4 2/3] graph: pcap capture for graph nodes

2023-01-24 Thread Amit Prakash Shukla
Implementation adds support to capture packets at each node with packet metadata and node name. Signed-off-by: Amit Prakash Shukla --- v2: - Fixed code style issue - Fixed CI compilation issue on github-robot v3: - Code review suggestion from Stephen - Fixed potential memory leak v4: - Co

[PATCH v4 1/3] pcapng: comment option support for epb

2023-01-24 Thread Amit Prakash Shukla
This change enhances rte_pcapng_copy to have comment in enhanced packet block. Signed-off-by: Amit Prakash Shukla --- v2: - Fixed code style issue - Fixed CI compilation issue on github-robot v3: - Code review suggestion from Stephen - Fixed potential memory leak v4: - Code review suggest

[PATCH] mailmap: update contributor entry

2023-01-24 Thread Viacheslav Galaktionov
Signed-off-by: Viacheslav Galaktionov --- .mailmap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index 452267a567..0b0492b22d 100644 --- a/.mailmap +++ b/.mailmap @@ -1376,7 +1376,7 @@ Venkateshwarlu Nalla Venkat Koppula Venky Venkatesan Venky Venka

[PATCH 6/6] app/testpmd: factorize fwd engine Tx

2023-01-24 Thread David Marchand
Reduce code duplication by introducing a helper that takes care of transmitting, retrying if enabled and incrementing tx counter. Signed-off-by: David Marchand --- app/test-pmd/5tswap.c| 22 + app/test-pmd/csumonly.c | 23 +- app/test-pmd/flowgen.c | 22 +--

[PATCH 5/6] app/testpmd: factorize fwd engine Rx

2023-01-24 Thread David Marchand
Reduce code duplication by introducing a helper that takes care of receiving packets and incrementing rx counter. Signed-off-by: David Marchand --- app/test-pmd/5tswap.c | 5 + app/test-pmd/csumonly.c| 5 + app/test-pmd/flowgen.c | 5 + app/test-pmd/icmpecho.c| 5

[PATCH 4/6] app/testpmd: factorize fwd engine init

2023-01-24 Thread David Marchand
Reduce code duplication by introducing a helper that takes care of initialising the fs object. While at it, remove unneeded initialisation of fwd_engine empty fields. Signed-off-by: David Marchand --- app/test-pmd/5tswap.c | 16 +--- app/test-pmd/csumonly.c | 16 +-

[PATCH 3/6] app/testpmd: bulk free mbufs

2023-01-24 Thread David Marchand
Use the bulk free helper. Signed-off-by: David Marchand --- app/test-pmd/5tswap.c | 4 +--- app/test-pmd/csumonly.c | 4 +--- app/test-pmd/flowgen.c| 8 ++-- app/test-pmd/icmpecho.c | 4 +--- app/test-pmd/iofwd.c | 4 +--- app/test-pmd/macfwd.c |

[PATCH 2/6] app/testpmd: don't send unprepared packets

2023-01-24 Thread David Marchand
"unprepared" packets could get to the wire in the retry loop. Split packets freeing in two stages: one for preparation failure, and one for transmission failure. Adjust dropped counter update accordingly. Fixes: 6b520d54ebfe ("app/testpmd: use Tx preparation in checksum engine") Cc: sta...@dpdk.o

[PATCH 0/6] Testpmd code cleanup

2023-01-24 Thread David Marchand
Here is a series to reduce code duplication in testpmd. This work started from looking at Robin series on reporting lcore busy cycles in telemetry, which is then added in testpmd [1]. While looking at the forward engines code, I saw way too much duplicated code. Warning: this is only compile test

[PATCH 1/6] app/testpmd: factorize core cycles record

2023-01-24 Thread David Marchand
Rather than have each forward engines deal with core cycles recording, move this to testpmd common code. fwd engines just need to report that they did some busy work. Signed-off-by: David Marchand --- app/test-pmd/5tswap.c | 11 --- app/test-pmd/csumonly.c | 10 +++---

DPDK Release Status Meeting 2023-01-19

2023-01-24 Thread Mcnamara, John
Release status meeting minutes 2023-01-19 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * AMD * ARM * Debian/Microsoft [No] * Intel * Marvell * Nvidia * Red Hat Release Dates - The following are the pr

[PATCH v7 2/2] ethdev: add quota flow action and item

2023-01-24 Thread Gregory Etelson
Quota action limits traffic according to pre-defined configuration. Quota reflects overall traffic usage regardless bandwidth. Quota flow action initialized with signed tokens number value. Quota flow action updates tokens number according to these rules: 1. if quota was configured to count packet

[PATCH v7 1/2] ethdev: add query_update sync and async function calls

2023-01-24 Thread Gregory Etelson
Current API allows either query or update indirect flow action. If indirect action must be conditionally updated according to it's present state application must first issue action query then analyze returned data and if needed issue update request. When the update will be processed, action state c

RE: [PATCH v6 2/2] ethdev: add quota flow action and item

2023-01-24 Thread Gregory Etelson
Hello Andrew, [] > > + Quota action sets packet metadata according to a number of remaining > > + tokens number: > > + * ``PASS`` - remaining tokens number is non-negative. > > + * ``BLOCK`` - remaining tokens number is negative. > > + > > + Quota flow item matches on that metadata. > > + >

Re: [PATCH] doc: add supported APIs section to nfp guide

2023-01-24 Thread Ferruh Yigit
On 1/24/2023 2:44 AM, Chaoyong He wrote: >> On 12/1/2022 1:38 AM, Chaoyong He wrote: >>> Add a new section 'Supported APIs', inculding the supported >>> APIs/items/actions of rte_flow. >>> >> >> Isn't this information already exists in 'doc/guides/nics/features/nfp.ini'? >> Why to >> duplicate her

Re: [PATCH v2 0/8] start cleanup of rte_flow_item_*

2023-01-24 Thread Ferruh Yigit
On 1/22/2023 10:52 AM, David Marchand wrote: > Hi Ferruh, Thomas, > > On Fri, Jan 20, 2023 at 6:19 PM Ferruh Yigit wrote: >> >> There was a plan to have structures from lib/net/ at the beginning >> of corresponding flow item structures. >> Unfortunately this plan has not been followed up so far.

[PATCH v3 8/8] net: mark all big endian types

2023-01-24 Thread Ferruh Yigit
From: Thomas Monjalon Some protocols (ARP, MPLS and HIGIG2) were using uint16_t and uint32_t types for their 16 and 32-bit fields. It was correct but not conveying the big endian nature of these fields. As for other protocols defined in this directory, all types are explicitly marked as big endi

[PATCH v3 6/8] ethdev: use ARP protocol struct for flow matching

2023-01-24 Thread Ferruh Yigit
From: Thomas Monjalon As announced in the deprecation notice, flow item structures should re-use the protocol header definitions from the directory lib/net/. The protocol struct is added in an unnamed union, keeping old field names. The ARP header struct members are used in testpmd instead of t

[PATCH v3 7/8] doc: fix description of L2TPV2 flow item

2023-01-24 Thread Ferruh Yigit
From: Thomas Monjalon The flow item structure includes the protocol definition from the directory lib/net/, so it is reflected in the guide. Section title underlining is also fixed around. Fixes: 3a929df1f286 ("ethdev: support L2TPv2 and PPP procotol") Cc: sta...@dpdk.org Signed-off-by: Thomas

[PATCH v3 5/8] ethdev: use GTP protocol struct for flow matching

2023-01-24 Thread Ferruh Yigit
From: Thomas Monjalon As announced in the deprecation notice, flow item structures should re-use the protocol header definitions from the directory lib/net/. The protocol struct is added in an unnamed union, keeping old field names. The GTP header struct members are used in apps and drivers ins

[PATCH v3 3/8] ethdev: use VXLAN protocol struct for flow matching

2023-01-24 Thread Ferruh Yigit
From: Thomas Monjalon As announced in the deprecation notice, flow item structures should re-use the protocol header definitions from the directory lib/net/. In the case of VXLAN-GPE, the protocol struct is added in an unnamed union, keeping old field names. The VXLAN headers (including VXLAN-G

[PATCH v3 4/8] ethdev: use GRE protocol struct for flow matching

2023-01-24 Thread Ferruh Yigit
From: Thomas Monjalon As announced in the deprecation notice, flow item structures should re-use the protocol header definitions from the directory lib/net/. The protocol struct is added in an unnamed union, keeping old field names. The GRE header struct members are used in apps and drivers ins

[PATCH v3 1/8] ethdev: use Ethernet protocol struct for flow matching

2023-01-24 Thread Ferruh Yigit
From: Thomas Monjalon As announced in the deprecation notice, flow item structures should re-use the protocol header definitions from the directory lib/net/. The Ethernet headers (including VLAN) structures are used instead of the redundant fields in the flow items. The remaining protocols to cl

[PATCH v3 2/8] net: add smaller fields for VXLAN

2023-01-24 Thread Ferruh Yigit
From: Thomas Monjalon The VXLAN and VXLAN-GPE headers were including reserved fields with other fields in big uint32_t struct members. Some more precise definitions are added as union of the old ones. The new struct members are smaller in size and in names. Signed-off-by: Thomas Monjalon ---

[PATCH v3 0/8] start cleanup of rte_flow_item_*

2023-01-24 Thread Ferruh Yigit
There was a plan to have structures from lib/net/ at the beginning of corresponding flow item structures. Unfortunately this plan has not been followed up so far. This series is a step to make the most used items, compliant with the inheritance design explained above. The old API is kept in anonymo

Re: [PATCH v2] event/cnxk: wait for CPT flow control on WQE path

2023-01-24 Thread Jerin Jacob
On Tue, Jan 24, 2023 at 2:22 PM Jerin Jacob wrote: > > On Thu, Jan 19, 2023 at 11:23 AM Rahul Bhansali wrote: > > > > This is to avoid CPT queue overflow and thereby a CPT misc > > interrupt. > > > > Fixes: 1a7da795f64 ("net/cnxk: support Tx security offload on cn9k") > > > > Signed-off-by: Rahul

Re: [PATCH v2] event/cnxk: wait for CPT flow control on WQE path

2023-01-24 Thread Jerin Jacob
On Thu, Jan 19, 2023 at 11:23 AM Rahul Bhansali wrote: > > This is to avoid CPT queue overflow and thereby a CPT misc > interrupt. > > Fixes: 1a7da795f64 ("net/cnxk: support Tx security offload on cn9k") > > Signed-off-by: Rahul Bhansali Acked-by: Jerin Jacob > --- > Changes in v2: Updated co