RE: [PATCH v2] net/ice: fix ice dcf control thread crash

> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, February 14, 2023 7:03 PM > To: Zhang, Ke1X > Cc: Zhang, Qi Z ; Yang, Qiming > ; dev@dpdk.org; Tyler Retzlaff > > Subject: Re: [PATCH v2] net/ice: fix ice dcf control thread crash > > 13/02/2023 08:16, Ke Zhang: > > --- a/

RE: [PATCH v10 2/4] pmu: support reading ARM PMU events in runtime

> -Original Message- > From: Tomasz Duszynski > Sent: Monday, February 13, 2023 7:32 PM > To: dev@dpdk.org; Tomasz Duszynski ; Ruifeng Wang > > Cc: roret...@linux.microsoft.com; Ruifeng Wang ; > bruce.richard...@intel.com; jer...@marvell.com; mattias.ronnb...@ericsson.com; > m...@smartsha

RE: [PATCH v10 1/4] lib: add generic support for reading PMU events

> -Original Message- > From: Tomasz Duszynski > Sent: Monday, February 13, 2023 7:32 PM > To: dev@dpdk.org; tho...@monjalon.net; Tomasz Duszynski > > Cc: roret...@linux.microsoft.com; Ruifeng Wang ; > bruce.richard...@intel.com; jer...@marvell.com; mattias.ronnb...@ericsson.com; > m...@s

[PATCH 2/2] app/testpmd: add support for bonding port's LACP negotiation

From: Long Wu If bonding port is mode4 with disabling dedicated queue and there are no other packets, forward loop will not call port's TX function and bonding port will not send LACP packets. Add sending LACP packets periodically in forward loop to avoid LACP negotiation failed. Signed-off-by:

[PATCH 1/2] net/bonding: add independent LACP sending function

From: Long Wu Sending LACP control packets depends on calling the bonding port's sending function if we disable dedicated queue. In some cases app would not call the bonding port's sending function if there are only LACP control packets and the negotiation between the two bonding ports will fail.

[PATCH 0/2] enhance bonding PMD to support the LACP negotiation

App may not support the LACP negotiation in some cases. This patch series solves this problem and add logics to testpmd app to support the forward of bonding port in mode 4 with the disabled dedicated queue. Long Wu (2): net/bonding: add independent LACP sending function app/testpmd: add suppo

Re: [PATCH v4 2/3] ring: add telemetry cmd to list rings

在 2023/2/10 10:48, Jie Hai 写道: Add a telemetry command to list the rings used in the system. An example using this command is shown below: --> /ring/list { "/ring/list": [ "HT_:7d:00.2", "MP_mb_pool_0" ] } Signed-off-by: Jie Hai Acked-by: Konstantin Ananyev Reviewed-by:

Re: [PATCH v4 3/3] ring: add telemetry cmd for ring info

在 2023/2/10 10:48, Jie Hai 写道: This patch supports dump of ring information by its name. An example using this command is shown below: --> /ring/info,MP_mb_pool_0 { "/ring/info": { "name": "MP_mb_pool_0", "socket": 0, "flags": "0x0", "producer_type": "MP", "consumer

RE: [RFC] eal: use same atomic intrinsics for gcc and clang

> -Original Message- > From: Honnappa Nagarahalli > Sent: Saturday, February 11, 2023 9:56 AM > To: roret...@linux.microsoft.com; bruce.richard...@intel.com; > m...@smartsharesystems.com > Cc: dev@dpdk.org; Honnappa Nagarahalli ; > Ruifeng Wang > ; jer...@marvell.com; nd ; > sta...@dpdk

[PATCH] net/nfp: only flush specified port flow table

From: Jin Liu The flow flush function will destroy all the flow table on all the port of NFP nic rather than the provide port. Modify logic, only destroy the flow table on the corresponding port. Fixes: 30ecce522732 ("net/nfp: support flow API") Cc: sta...@dpdk.org Signed-off-by: Jin Liu Revie

[PATCH] net/nfp: remove the unneeded check logic

Remove the unneeded check logic of ingress and egress flow attribute. After the OVS commit c7da49bc ("netdev-offload-dpdk: Fix transfer flows"), the flow can not offload anymore if we don't do this modification. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_fl

[PATCH v1] net/mlx5: enable hint in async table

Driver gets the hint value from rte_table_attr for async flow. Parse the value and pass the supported value to hardware accordingly. Signed-off-by: Rongwei Liu Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_hw.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/mlx5/mlx

RE: [PATCH v5 38/39] ml/cnxk: add user guide for marvell cnxk ml driver

> -Original Message- > From: Srikanth Yalavarthi > Sent: Tuesday, February 7, 2023 9:37 PM > To: Thomas Monjalon ; Srikanth Yalavarthi > > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran ; > Anup Prabhu ; Prince Takkar ; > Parijat Shukla > Subject: [P

RE: [PATCH v5 32/39] ml/cnxk: enable support to get xstats in cycles

> -Original Message- > From: Srikanth Yalavarthi > Sent: Tuesday, February 7, 2023 9:37 PM > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran ; > Anup Prabhu ; Prince Takkar ; > Parijat Shukla > Subject: [PATCH v5 32/39] ml/cn

RE: [PATCH v5 39/39] ml/cnxk: enable support for configurable ocm page

> -Original Message- > From: Srikanth Yalavarthi > Sent: Tuesday, February 7, 2023 9:37 PM > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran ; > Anup Prabhu ; Prince Takkar ; > Parijat Shukla > Subject: [PATCH v5 39/39] ml/cn

RE: [PATCH v4 11/12] app/mldev: enable reporting stats in mldev app

> -Original Message- > From: Srikanth Yalavarthi > Sent: Tuesday, February 7, 2023 9:20 PM > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran > ; Anup Prabhu ; Prince Takkar > ; Parijat Shukla > Subject: [PATCH v4 11/12] app/m

Re: [External] Re: [PATCH] malloc: fix malloc performance may becomes worse as the number of malloc increases

Stephen Hemminger 于2023年2月16日周四 01:16写道： > > On Wed, 15 Feb 2023 12:10:23 +0100 > Morten Brørup wrote: > > > Looking isolated at the patch itself... > > > > I agree with the way the patch modifies the ranges of the free list, and > > the consequential removal of the "- 1" from the calculation of

RE: [PATCH v5] enhance NUMA affinity heuristic

> -Original Message- > From: Burakov, Anatoly > Sent: 2023年2月15日 22:23 > To: You, KaisenX ; dev@dpdk.org > Cc: Zhou, YidingX ; tho...@monjalon.net; > david.march...@redhat.com; Matz, Olivier ; > ferruh.yi...@amd.com; zhou...@loongson.cn; sta...@dpdk.org > Subject: Re: [PATCH v5] enhance

[PATCH v7 21/21] net/cpfl: add xstats ops

Add support for these device ops: - dev_xstats_get - dev_xstats_get_names - dev_xstats_reset Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 80 ++ 1 file changed, 80 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpf

Re: [PATCH] eal/bsd: fix spinlock not unlock in alarm callback

add cc maintainer On 2023/2/13 20:44, Chengwen Feng wrote: > The spinlock should unlock when clock_gettime() failed. This patch > fixes it by invoking clock_gettime() before lock. > > Fixes: 26021a715067 ("eal/bsd: support alarm API") > Cc: sta...@dpdk.org > > Signed-off-by: Chengwen Feng > ---

[PATCH v7 20/21] net/cpfl: support scalar scatter Rx datapath for single queue model

This patch add single q recv scatter Rx function. Signed-off-by: Wenjun Wu Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 3 ++- drivers/net/cpfl/cpfl_rxtx.c | 27 +++ drivers/net/cpfl/cpfl_rxtx.h | 2 ++ 3 files changed, 31 insertions(+), 1 deleti

[PATCH v7 19/21] net/cpfl: add RSS set/get ops

Add support for these device ops: - rss_reta_update - rss_reta_query - rss_hash_update - rss_hash_conf_get Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 270 - 1 file changed, 269 insertions(+), 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl_e

[PATCH v7 18/21] net/cpfl: add HW statistics

This patch add hardware packets/bytes statistics. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 86 ++ 1 file changed, 86 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index 1e40f3e55c..0fb9f0455b 100

[PATCH v7 17/21] net/cpfl: add AVX512 data path for split queue model

Add support of AVX512 data path for split queue model. Signed-off-by: Wenjun Wu Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_rxtx.c| 56 +++-- drivers/net/cpfl/cpfl_rxtx_vec_common.h | 20 - drivers/net/cpfl/meson.build| 6 ++- 3 file

[PATCH v7 16/21] net/cpfl: support timestamp offload

Add support for timestamp offload. Signed-off-by: Mingxia Liu --- doc/guides/nics/features/cpfl.ini | 1 + drivers/net/cpfl/cpfl_ethdev.c| 3 ++- drivers/net/cpfl/cpfl_rxtx.c | 7 +++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/features/cpfl.ini b

[PATCH v7 15/21] net/cpfl: add AVX512 data path for single queue model

Add support of AVX512 vector data path for single queue model. Signed-off-by: Wenjun Wu Signed-off-by: Mingxia Liu --- doc/guides/nics/cpfl.rst| 24 +- drivers/net/cpfl/cpfl_ethdev.c | 3 +- drivers/net/cpfl/cpfl_rxtx.c| 94 ++ dr

[PATCH v7 14/21] net/cpfl: support Tx offloading

Add Tx offloading support: - support TSO for single queue model and split queue model. Signed-off-by: Mingxia Liu --- doc/guides/nics/features/cpfl.ini | 1 + drivers/net/cpfl/cpfl_ethdev.c| 8 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/features/c

[PATCH v7 13/21] net/cpfl: support Rx offloading

Add Rx offloading support: - support CHKSUM and RSS offload for split queue model - support CHKSUM offload for single queue model Signed-off-by: Mingxia Liu --- doc/guides/nics/features/cpfl.ini | 2 ++ drivers/net/cpfl/cpfl_ethdev.c| 6 ++ 2 files changed, 8 insertions(+) diff --git

[PATCH v7 12/21] net/cpfl: support RSS

Add RSS support. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 51 ++ drivers/net/cpfl/cpfl_ethdev.h | 15 ++ 2 files changed, 66 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index 7e0630c605

[PATCH v7 11/21] net/cpfl: support write back based on ITR expire

Enable write back on ITR expire, then packets can be received one by Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 45 +- drivers/net/cpfl/cpfl_ethdev.h | 2 ++ 2 files changed, 46 insertions(+), 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl

[PATCH v7 10/21] net/cpfl: support basic Tx data path

Add basic Tx support in split queue mode and single queue mode. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 3 +++ drivers/net/cpfl/cpfl_rxtx.c | 20 drivers/net/cpfl/cpfl_rxtx.h | 1 + 3 files changed, 24 insertions(+) diff --git a/drivers/net/cpf

[PATCH v7 09/21] net/cpfl: support basic Rx data path

Add basic Rx support in split queue mode and single queue mode. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 2 ++ drivers/net/cpfl/cpfl_rxtx.c | 18 ++ drivers/net/cpfl/cpfl_rxtx.h | 1 + 3 files changed, 21 insertions(+) diff --git a/drivers/net/cpfl/c

[PATCH v7 08/21] net/cpfl: support MTU configuration

Add dev ops mtu_set. Signed-off-by: Mingxia Liu --- doc/guides/nics/features/cpfl.ini | 1 + drivers/net/cpfl/cpfl_ethdev.c| 27 +++ 2 files changed, 28 insertions(+) diff --git a/doc/guides/nics/features/cpfl.ini b/doc/guides/nics/features/cpfl.ini index a2d1ca9e1

[PATCH v7 07/21] net/cpfl: support queue release

Add support for queue operations: - rx_queue_release - tx_queue_release Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 2 ++ drivers/net/cpfl/cpfl_rxtx.c | 35 ++ drivers/net/cpfl/cpfl_rxtx.h | 2 ++ 3 files changed, 39 insertions(+) diff

[PATCH v7 06/21] net/cpfl: support queue stop

Add support for these device ops: - rx_queue_stop - tx_queue_stop Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 10 +++- drivers/net/cpfl/cpfl_rxtx.c | 87 ++ drivers/net/cpfl/cpfl_rxtx.h | 3 ++ 3 files changed, 99 insertions(+), 1 deleti

[PATCH v7 05/21] net/cpfl: support queue start

Add support for these device ops: - rx_queue_start - tx_queue_start Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 41 ++ drivers/net/cpfl/cpfl_rxtx.c | 138 + drivers/net/cpfl/cpfl_rxtx.h | 4 + 3 files changed, 183 insertions(+)

[PATCH v7 04/21] net/cpfl: support device start and stop

Add dev ops dev_start, dev_stop and link_update. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 35 ++ 1 file changed, 35 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c index 3029f03d02..d1dfcfff9b 1006

[PATCH v7 03/21] net/cpfl: add Rx queue setup

Add support for rx_queue_setup ops. Signed-off-by: Mingxia Liu --- drivers/net/cpfl/cpfl_ethdev.c | 11 ++ drivers/net/cpfl/cpfl_rxtx.c | 232 + drivers/net/cpfl/cpfl_rxtx.h | 6 + 3 files changed, 249 insertions(+) diff --git a/drivers/net/cpfl/cpfl_ethde

[PATCH v7 02/21] net/cpfl: add Tx queue setup

Add support for tx_queue_setup ops. In the single queue model, the same descriptor queue is used by SW to post buffer descriptors to HW and by HW to post completed descriptors to SW. In the split queue model, "RX buffer queues" are used to pass descriptor buffers from SW to HW while Rx queues are

[PATCH v7 01/21] net/cpfl: support device initialization

Support device init and add the following dev ops: - dev_configure - dev_close - dev_infos_get - link_update - dev_supported_ptypes_get Signed-off-by: Mingxia Liu --- MAINTAINERS| 8 + doc/guides/nics/cpfl.rst | 66 +++ doc/guides/nics/features/c

[PATCH v7 00/21] add support for cpfl PMD in DPDK

The patchset introduced the cpfl (Control Plane Function Library) PMD for Intel?? IPU E2100???s Configure Physical Function (Device ID: 0x1453) The cpfl PMD inherits all the features from idpf PMD which will follow an ongoing standard data plan function spec https://www.oasis-open.org/committees/t

Re: [PATCH v2 6/6] test/dmadev: add tests for stopping and restarting dev

On 2023/2/15 19:57, Bruce Richardson wrote: > On Wed, Feb 15, 2023 at 09:59:06AM +0800, fengchengwen wrote: >> On 2023/1/17 1:37, Bruce Richardson wrote: >>> Validate device operation when a device is stopped or restarted. >>> >>> The only complication - and gap in the dmadev ABI specification - is

RE: [PATCH v7 01/22] gso: don't log message on non TCP/UDP

> -Original Message- > From: Stephen Hemminger > Sent: Thursday, February 16, 2023 1:23 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Hu, Jiayu > ; Mark Kavanagh > Subject: [PATCH v7 01/22] gso: don't log message on non TCP/UDP > > If a large packet is passed into GSO routines of unk

RE: [PATCH v6 00/21] add support for cpfl PMD in DPDK

Yes, this patchset is based on the idpf PMD code: http://patches.dpdk.org/project/dpdk/cover/20230206054618.40975-1-beilei.x...@intel.com/ http://patches.dpdk.org/project/dpdk/cover/20230106090501.9106-1-beilei.x...@intel.com/ http://patches.dpdk.org/project/dpdk/cover/20230207084549.2225214-1-wenj

reminder - DPDK CI Community Testing Meeting - Tomorrow 2/15/23 @ 6am PT/9am ET/15:00h CET

Good evening, Tomorrow, Thu. Feb. 16, 2023, DPDK will hold its biweekly CI Community Testing Meeting at 6am PT/9am ET/15:00h CET. Zoom information to follow. We hope to see you there. Thanks, Nathan Nathan C. Southern, Project Coordinator Data Plane Development Kit The Linux Foundation 248.8

Re: [PATCH v3] hash: add XOR32 hash function

Hi Morten, Thanks for your comments! For endianness conversion, I double-checked my usages. I did use both rte_cpu_to_be_32() and rte_be_to_cpu_32(). I might have missed something but I think I used them (4 occurrences) in a semantically meaningful way. Could you point me to the lines that are co

Re: [PATCH v7 20/22] hash: move rte_thash_gfni stubs out of header file

Hi Stepthen, There is a problem with the build on a machine that supports GFNI: ../lib/hash/rte_thash_gfni.c:15:1: error: redefinition of ‘rte_thash_gfni’    15 | rte_thash_gfni(const uint64_t *mtrx __rte_unused,   | ^~ In file included from ../lib/hash/rte_thash_gfni.h:13,  

Re: [PATCH] net/nfp: support 48-bit DMA address for firmware with NFDk

On 2/15/2023 5:47 PM, Niklas Söderlund wrote: > Hi Ferruh, > > Thanks for your continues effort in dealing with NFP patches. > > On 2023-02-15 13:42:01 +, Ferruh Yigit wrote: >> On 2/8/2023 9:15 AM, Chaoyong He wrote: >>> From: Peng Zhang >>> >>> 48-bit DMA address is supported in the firmwa

Re: [PATCH] doc: update NFP documentation with Corigine information

Hello Ferruh, Thanks for your feedback. On 2023-02-15 13:37:05 +, Ferruh Yigit wrote: > On 2/3/2023 8:08 AM, Chaoyong He wrote: > > From: Walter Heymans > > > > The NFP PMD documentation is updated to include information about > > Corigine and their new vendor device ID. > > > > Outdated i

Re: [PATCH] net/nfp: support 48-bit DMA address for firmware with NFDk

Hi Ferruh, Thanks for your continues effort in dealing with NFP patches. On 2023-02-15 13:42:01 +, Ferruh Yigit wrote: > On 2/8/2023 9:15 AM, Chaoyong He wrote: > > From: Peng Zhang > > > > 48-bit DMA address is supported in the firmware with NFDk, so enable > > this feature in PMD now. But

[PATCH v10 3/3] net/cnxk: skip red drop for ingress policer

Dropping of packets is based on action configured to meter.If both skip_red and drop actions are configured then tail dropping in invoked else if only drop action is configured then RED drop is invoked.This action is supported only when RED is configured using rte_eth_cman_config_set() Signed-off-

[PATCH v10 2/3] app/testpmd: add skip cman support for testpmd

added support for testpmd application to accept skip_cman action while configuring policy action Signed-off-by: Rakesh Kudurumalla --- app/test-pmd/cmdline_flow.c | 9 + 1 file changed, 9 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 63a0b366

[PATCH v10 1/3] ethdev: skip congestion management configuration

Introduce new flow action to skip congestion management configuration This feature helps to skip the congestion management processing based on per flow or the packet color identified by rte_flow meter object. For example, If one Rx queue configured as RED congestion and application wants tobypass t

[PATCH v7 22/22] hash: convert RTE_LOGTYPE_HASH to dynamic type

Use dynamic type for hash and add subtypes for crc and gfni. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/hash/rte_cuckoo_hash.c | 5 + lib/hash/rte_fbk_hash.c | 5 + lib/hash/rte_hash_crc.c |

[PATCH v7 21/22] hash: move rte_hash_set_alg out header

The code for setting algorithm for hash is not at all perf sensitive, and doing it inline has a couple of problems. First, it means that if multiple files include the header, then the initialization gets done multiple times. But also, it makes it harder to fix usage of RTE_LOG(). Despite what the

[PATCH v7 20/22] hash: move rte_thash_gfni stubs out of header file

Having stubs in header file makes it harder to update RTE_LOG(). Also modify to only print warning once. Signed-off-by: Stephen Hemminger --- lib/hash/meson.build | 8 +++- lib/hash/rte_thash_gfni.c | 43 +++ lib/hash/rte_thash_gfni.h | 28 +-

[PATCH v7 19/22] pipeline: replace RTE_LOGTYPE_PIPELINE with dynamic type

Use a dynamically allocated logtype. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/pipeline/rte_pipeline.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b/lib/e

[PATCH v7 18/22] app/test: remove use of RTE_LOGTYPE_PIPELINE

Instead of using static type PIPELINE for logging in test application use stderr instead. If not testing RTE_LOG() better to not use it since log also goes to syslog. Signed-off-by: Stephen Hemminger --- app/test/test_table_acl.c | 50 -- app/test/test_table

[PATCH v7 16/22] port: replace RTE_LOGTYPE_PORT with dynamic type

Split up the single static RTE_LOGTYPE_PORT into separate sub types for each component: port.ethdev, port.evendev, ... Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/port/rte_port_ethdev.c | 3 +++ lib/port/rte_port_ev

[PATCH v7 17/22] table: convert RTE_LOGTYPE_TABLE to dynamic logtype

Use logtype suffixes for various components of this library. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/table/rte_table_acl.c | 3 +++ lib/table/rte_table_array.c | 3 +++ lib/table/rte_table_hash_cuck

[PATCH v7 15/22] examples/ipsecgw: replace RTE_LOGTYPE_PORT

Looks like some code got copy/paste in to the IPSEC gateway example from another place. Shouldn't be using RTE_LOGTYPE_PORT here. Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") Cc: akhil.go...@nxp.com Signed-off-by: Stephen Hemminger --- examples/ipsec-secgw/sa.c | 6 +++-

[PATCH v7 14/22] sched: replace RTE_LOGTYPE_SCHED with dynamic type

Also can remove unused RTE_LOGTYPE_METER Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 2 -- lib/eal/include/rte_log.h | 4 ++-- lib/sched/rte_pie.c | 1 + lib/sched/rte_sched.c | 5 + lib/sched/rte_sched_log.h | 4 5 files chan

[PATCH v7 13/22] kni: replace RTE_LOGTYPE_KNI with dynamic type

Even though KNI will eventually disappear, fix the logtype now. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/kni/rte_kni.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/eal/comm

[PATCH v7 12/22] lpm: replace RTE_LOGTYPE_LPM with dynamic types

Split lpm and lpm6 into separate log types since they are in different files and user may want to change log levels for IPv4 vs IPv6. For rib and fib libraries give them own types as well. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h

[PATCH v7 11/22] mempool: replace RTE_LOGTYPE_MEMPOOL with dynamic type

Convert from RTE_LOGTYPE_MEMPOOL to logtype_mempool. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/mempool/rte_mempool.c | 3 +++ lib/mempool/rte_mempool_log.h | 4 lib/mempool/rte_mempool_ops.c | 1 + 5 fil

[PATCH v7 10/22] ring: replace RTE_LOGTYPE_RING with dynamic type

The logtype for ring only used in library. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/ring/rte_ring.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b

[PATCH v7 09/22] power: replace RTE_LOGTYPE_POWER with dynamic type

Use dynamic log type for power library. Also replace use of RTE_LOGTYPE_USER1 with lib.power.guest. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h| 2 +- lib/power/guest_channel.c| 3 ++- lib/power/power_common.c | 2

[PATCH v7 08/22] examples/l3fwd-power: replace use of RTE_LOGTYPE_POWER

Convert to using a dynamic logtype for the application. Signed-off-by: Stephen Hemminger --- examples/l3fwd-power/main.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index caf26b373e8d..8e094c1bdda5

[PATCH v7 07/22] examples/power: replace use of RTE_LOGTYPE_POWER

Don't use static logtype in sample application. Signed-off-by: Stephen Hemminger --- examples/distributor/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/distributor/main.c b/examples/distributor/main.c index 21304d661873..542f76cf9664 100644 --- a/examples/di

[PATCH v7 06/22] acl: replace LOGTYPE_ACL with dynamic type

Get rid of RTE_LOGTYPE_ACL and RTE_LOGTYPE_MALLOC. For ACL library use a dynamic type. The one message using RTE_LOGTYPE_MALLOC should have been under the ACL logtype anyway. The test code should not have been using fixed log type so just change that to stderr. Signed-off-by: Stephen Hemminger -

[PATCH v7 04/22] efd: replace RTE_LOGTYPE_EFD with dynamic type

Replace all uses of the global logtype with a dynamic log type. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/efd/rte_efd.c | 3 +++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/eal/comm

[PATCH v7 05/22] mbuf: replace RTE_LOGTYPE_MBUF with dynamic type

Introduce a new dynamic logtype for mbuf related messages. Since this is used in multiple files put one macro in mbuf_log.h Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/mbuf/mbuf_log.h | 4 lib/mbuf/rte_m

[PATCH v7 02/22] eal: drop no longer used GSO logtype

The message that used this was replaced in previous patch. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common

[PATCH v7 03/22] log: drop unused RTE_LOGTYPE_TIMER

The timer code does not use rte_log. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common_log.c index 894701e8c

[PATCH v7 01/22] gso: don't log message on non TCP/UDP

If a large packet is passed into GSO routines of unknown protocol then library would log a message. Better to tell the application instead of logging. Fixes: 119583797b6a ("gso: support TCP/IPv4 GSO") Cc: jiayu...@intel.com Signed-off-by: Stephen Hemminger --- lib/gso/rte_gso.c | 5 ++--- lib/gs

[PATCH v7 00/22] Replace use of static logtypes in libraries

This patchset removes the main uses of static LOGTYPE's in DPDK libraries. It starts with the easy one and goes on to the more complex ones. Note: there is one patch in this series that will get flagged incorrectly as an ABI change. v7 - fix commit message typ add error to gso_segment functi

Re: [PATCH 2/2] drivers: replace printf with fprintf for debug functions

On Wed, 15 Feb 2023 15:59:05 +0530 Hemant Agrawal wrote: > diff --git a/drivers/bus/dpaa/base/fman/netcfg_layer.c > b/drivers/bus/dpaa/base/fman/netcfg_layer.c > index 6a405c984d..69cee08fb9 100644 > --- a/drivers/bus/dpaa/base/fman/netcfg_layer.c > +++ b/drivers/bus/dpaa/base/fman/netcfg_layer.

Re: [PATCH] malloc: fix malloc performance may becomes worse as the number of malloc increases

On Wed, 15 Feb 2023 12:10:23 +0100 Morten Brørup wrote: > Looking isolated at the patch itself... > > I agree with the way the patch modifies the ranges of the free list, and the > consequential removal of the "- 1" from the calculation of log2. > > Intuitively, the lists should cover ranges s

[PATCH v2 15/16] test/bbdev: remove max iteration from vectors

Remove iter_max from test vectors as this value is passed as an argument to the test. No functional impact. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 4 app/test-bbdev/test_bbdev_vector.c | 14 -- app/test-bbdev/test_b

[PATCH v2 16/16] test/bbdev: remove iter count from bler test

iter_count doesn't need to be set equal to iter_max for bler tests. This is only needed in throughput and latency tests because early termination is disabled for those tests. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 16 ++-- 1 file changed, 6 insertions(+),

[PATCH v2 13/16] test/bbdev: remove iteration count check

To make the test compatible with devices that do not support early termination, the iteration count assert can be removed. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/app/test-bbde

[PATCH v2 14/16] test/bbdev: use mbuf reset function

Use mbuf_reset function for code consistency. No functional impact. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index 52594

[PATCH v2 12/16] test/bbdev: remove check for invalid opaque data

Assert also if the opaque data is invalid. Fixes: 335c11fd276 ("app/bbdev: support HARQ validation") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c

[PATCH v2 08/16] test/bbdev: add support for BLER for 4G

New feature to add BLER support for 4G in test-bbdev. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 183 ++- 1 file changed, 182 insertions(+), 1 deletion(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index

[PATCH v2 09/16] test/bbdev: extend support for large TB

Add support for large TB when it cannot fit into a true mbuf. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index acf

[PATCH v2 10/16] test/bbdev: adjustment for soft output

Extend test-bbdev for soft output check, notably due to the logic in test-bbdev to enable termination changing. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/app/test-bbdev/test_b

[PATCH v2 07/16] test/bbdev: test start/stop bbdev API

Add a call to queue start and queue stop specifically for testing the bbdev API. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index 0

[PATCH v2 11/16] test/bbdev: expose warning counters

Print warnings reported on queues for offload test. No functional impact. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index 00090f863f..a19eda2de8 1006

[PATCH v2 06/16] test/bbdev: report device status in test-bbdev

No functional impact. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index 8c4b82efca..057fb5ac9e 100644 --- a/app/test-bbdev/test_bbdev_perf.c +++ b/app/t

[PATCH v2 04/16] test/bbdev: add timeout for latency tests

Add a timeout to force exit the latency tests in case dequeue never happens. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbde

[PATCH v2 05/16] test/bbdev: enable early termination for validation

Enhancement to enable early termination for validation tests if the device supports it. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/te

[PATCH v2 03/16] test/bbdev: refactor TB throughput report

Refactor calculation for tb_size. No functional impact. Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 38 ++-- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c ind

[PATCH v2 01/16] test/bbdev: fix seg fault for non supported HARQ len

Fix segmentation fault happening in corner case in test-bbdev. This fault could happen when running some specific vectors which size are not supported by the PMD. Fixes: 335c11fd276 ("app/bbdev: support HARQ validation") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- app/test-bbdev/test_b

[PATCH v2 00/16] test/bbdev: changes for 23.03

v2: Made changes requested during review. Added 3 commits. v1: Upstreaming bbdev-test changes for 23.03. Hernan Vargas (16): test/bbdev: fix seg fault for non supported HARQ len test/bbdev: extend HARQ tolerance test/bbdev: refactor TB throughput report test/bbdev: add timeout for latency

[PATCH v2 02/16] test/bbdev: extend HARQ tolerance

HARQ memory implementation could have different size assumptions. Extending HARQ tolerance to cover different implementations. Fixes: 335c11fd276 ("app/bbdev: support HARQ validation") Cc: sta...@dpdk.org Signed-off-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 11 --- 1 file

Re: [PATCH v6 01/22] gso: don't log message on non TCP/UDP

On Wed, 15 Feb 2023 07:26:22 + "Hu, Jiayu" wrote: > > -Original Message- > > From: Stephen Hemminger > > Sent: Wednesday, February 15, 2023 6:47 AM > > To: dev@dpdk.org > > Cc: Stephen Hemminger ; Hu, Jiayu > > ; Konstantin Ananyev > > ; Mark Kavanagh > > > > Subject: [PATCH v6 01/2

Re: [dpdk-dev] [PATCH v3 00/12] mldev: introduce machine learning device library

On Wed, Feb 15, 2023 at 6:25 PM Ferruh Yigit wrote: > > On 2/7/2023 3:13 PM, jer...@marvell.com wrote: > > From: Jerin Jacob > > > > Hi Jerin, > > Please find some comments/questions gathered with the help of some > collegues. Thanks Ferruh for the review. > > > Machine learning inference lib

[PATCH v6] net/af_xdp: support CNI Integration

Integrate support for the AF_XDP CNI and device plugin [1] so that the DPDK AF_XDP PMD can work in an unprivileged container environment. Part of the AF_XDP PMD initialization process involves loading an eBPF program onto the given netdev. This operation requires privileges, which prevents the PMD

Re: [PATCH V4 1/5] drivers/bus: restore driver assignment at front of probing

On 1/12/2023 2:44 AM, lihuisong (C) wrote: > > 在 2023/1/11 20:51, Ferruh Yigit 写道: >> On 12/6/2022 9:26 AM, Huisong Li wrote: >>> The driver assignment was moved back at the end of the device probing >>> because there is no something to use rte_driver during the phase of >>> probing. See commit 39

Re: [PATCH 2/2] drivers: replace printf with fprintf for debug functions

15/02/2023 11:29, Hemant Agrawal: > This patch replaces simple printf with fprintf for debug dump > related functions for various NXP dpaaX related drivers. Why replacing with fprintf(stdout)? Would it be better to provide a FILE* parameter to the functions?

  1   2   >