RE: [v1, 00/10] fips_validation application improvements

2023-02-27 Thread Akhil Goyal
Hi Gowrishankar, > > > > > Subject: [v1, 00/10] fips_validation application improvements > > > > > > This patch series adds support for SHA3, SHAKE, AES-CCM JSON test vectors > > > and fixes existing algorithms to support NIST test vectors. > > > > > > Gowrishankar Muthukrishnan (10): > > > examp

RE: [EXT] Re: [PATCH v7] mem: telemetry support for memseg and element information

2023-02-27 Thread Amit Prakash Shukla
Hi Thomas, No changes pending from my side. Thanks, Amit Shukla > -Original Message- > From: Thomas Monjalon > Sent: Monday, February 20, 2023 4:41 PM > To: dev@dpdk.org > Cc: Anatoly Burakov ; Jerin Jacob > Kollanukkaran ; david.march...@redhat.com; > bruce.richard...@intel.com; ciara.

回复: 回复: [RFC PATCH v1 0/4] Direct re-arming of buffers on receive side

2023-02-27 Thread Feifei Wang
CC to the right e-mail address. > > I also have some concerns on how useful this API will be in real life, > > and does the use case worth the complexity it brings. > > And it looks too much low level detail for the application. > > Concerns of direct rearm: > 1. Earlier version of the design req

RE: [PATCH v7 18/21] net/cpfl: add HW statistics

2023-02-27 Thread Liu, Mingxia
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, February 28, 2023 5:52 AM > To: Liu, Mingxia ; dev@dpdk.org; Xing, Beilei > ; Zhang, Yuying > Subject: Re: [PATCH v7 18/21] net/cpfl: add HW statistics > > On 2/16/2023 12:30 AM, Mingxia Liu wrote: > > This patch add hardware p

回复: 回复: [RFC PATCH v1 0/4] Direct re-arming of buffers on receive side

2023-02-27 Thread Feifei Wang
Hi, Ferruh This email summarizes our latest improvement work for direct-rearm and hope it can fix some concerns about direct-rearm. Best Regards Feifei > -邮件原件- > 发件人: Ferruh Yigit > 发送时间: Tuesday, January 18, 2022 11:52 PM > 收件人: Feifei Wang ; Morten Brørup > > 抄送: dev@dpdk.org; nd ;

[Bug 1168] [23.03-rc1] dpdk-next-crypto examples/fips_validation meson build error with gcc4.8.5 on Centos7.9

2023-02-27 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1168 Bug ID: 1168 Summary: [23.03-rc1] dpdk-next-crypto examples/fips_validation meson build error with gcc4.8.5 on Centos7.9 Product: DPDK Version: 23.03 Hardware: x86

RE: [PATCH v7 21/21] net/cpfl: add xstats ops

2023-02-27 Thread Liu, Mingxia
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, February 28, 2023 5:53 AM > To: Liu, Mingxia ; dev@dpdk.org; Xing, Beilei > ; Zhang, Yuying > Subject: Re: [PATCH v7 21/21] net/cpfl: add xstats ops > > On 2/16/2023 12:30 AM, Mingxia Liu wrote: > > Add support for these device

RE: [PATCH v7 13/21] net/cpfl: support Rx offloading

2023-02-27 Thread Liu, Mingxia
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, February 28, 2023 5:50 AM > To: Liu, Mingxia ; dev@dpdk.org; Xing, Beilei > ; Zhang, Yuying > Subject: Re: [PATCH v7 13/21] net/cpfl: support Rx offloading > > On 2/16/2023 12:30 AM, Mingxia Liu wrote: > > Add Rx offloading sup

RE: [PATCH v2 05/11] crypto/cnxk: set ctx for AE

2023-02-27 Thread Tejasree Kondoj
Hi Akhil, Patch sets ctx_val to 1 for asymmetric due to cn10k A0 hardware errata and structures are redesigned to satisfy hardware alignment requirements. Thanks Tejasree > -Original Message- > From: Akhil Goyal > Sent: Monday, February 27, 2023 11:09 PM > To: Tejasree Kondoj > Cc: An

RE: [PATCH v7 21/21] net/cpfl: add xstats ops

2023-02-27 Thread Liu, Mingxia
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, February 28, 2023 5:53 AM > To: Liu, Mingxia ; dev@dpdk.org; Xing, Beilei > ; Zhang, Yuying > Subject: Re: [PATCH v7 21/21] net/cpfl: add xstats ops > > On 2/16/2023 12:30 AM, Mingxia Liu wrote: > > Add support for these device

RE: [PATCH v7 05/21] net/cpfl: support queue start

2023-02-27 Thread Liu, Mingxia
If time permits, we will first submit a fixed patch to add a q type member in rx_queue strc. > -Original Message- > From: Liu, Mingxia > Sent: Tuesday, February 28, 2023 11:15 AM > To: Ferruh Yigit ; dev@dpdk.org; Xing, Beilei > ; Zhang, Yuying > Subject: RE: [PATCH v7 05/21] net/cpfl: s

RE: [PATCH v7 15/21] net/cpfl: add AVX512 data path for single queue model

2023-02-27 Thread Liu, Mingxia
Thanks, will delete it. > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, February 28, 2023 5:51 AM > To: Liu, Mingxia ; dev@dpdk.org; Xing, Beilei > ; Zhang, Yuying > Cc: Wu, Wenjun1 > Subject: Re: [PATCH v7 15/21] net/cpfl: add AVX512 data path for single > queue model > > O

RE: [PATCH v7 05/21] net/cpfl: support queue start

2023-02-27 Thread Liu, Mingxia
Thanks, Ferruh ! It's a good idea! As for it involves a wide range of change, including idpf common module and idpf pmd code, So we'd better update it in the later fix patch after rc2. > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, February 28, 2023 5:47 AM > To: Liu, Ming

RE: [PATCH v7 03/21] net/cpfl: add Rx queue setup

2023-02-27 Thread Liu, Mingxia
Thanks or your comments, we will use enums to differentiate queues. As for 'bufq1'&'bufq2', they are members of struct idpf_rx_queue, defined in idpf commen module, And it involves idpf pmd code, so it's better to improve it in the later fixed patch. > -Original Message- > From: Ferruh

RE: [PATCH v2 11/20] net/virtio: annotate lock for guest announce

2023-02-27 Thread Xia, Chenbo
Hi David & Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, February 28, 2023 12:28 AM > To: David Marchand ; Xia, Chenbo > > Cc: dev@dpdk.org; tho...@monjalon.net > Subject: Re: [PATCH v2 11/20] net/virtio: annotate lock for guest announce > > Hi, > > On 2/27/23 0

RE: [PATCH v7 02/21] net/cpfl: add Tx queue setup

2023-02-27 Thread Liu, Mingxia
Ok,thanks! > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, February 28, 2023 5:45 AM > To: Liu, Mingxia ; dev@dpdk.org; Xing, Beilei > ; Zhang, Yuying > Subject: Re: [PATCH v7 02/21] net/cpfl: add Tx queue setup > > On 2/16/2023 12:29 AM, Mingxia Liu wrote: > > Add support fo

Re: [PATCH V4 1/5] drivers/bus: restore driver assignment at front of probing

2023-02-27 Thread lihuisong (C)
在 2023/2/16 0:09, Ferruh Yigit 写道: On 1/12/2023 2:44 AM, lihuisong (C) wrote: 在 2023/1/11 20:51, Ferruh Yigit 写道: On 12/6/2022 9:26 AM, Huisong Li wrote: The driver assignment was moved back at the end of the device probing because there is no something to use rte_driver during the phase of p

回复: [PATCH v3 1/3] ethdev: enable direct rearm with separate API

2023-02-27 Thread Feifei Wang
> -邮件原件- > 发件人: Konstantin Ananyev > 发送时间: Tuesday, February 28, 2023 3:32 AM > 收件人: Feifei Wang ; Konstantin Ananyev > ; tho...@monjalon.net; Ferruh Yigit > ; Andrew Rybchenko > > 抄送: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; Ruifeng Wang > ; nd > 主题: RE: [PATCH v3 1/3] ethdev: enab

回复: [PATCH v3 2/3] net/i40e: enable direct rearm with separate API

2023-02-27 Thread Feifei Wang
> -邮件原件- > 发件人: Konstantin Ananyev > 发送时间: Tuesday, February 28, 2023 3:36 AM > 收件人: Feifei Wang ; Konstantin Ananyev > ; Yuying Zhang > ; Beilei Xing ; Ruifeng > Wang > 抄送: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; nd > 主题: RE: [PATCH v3 2/3] net/i40e: enable direct rearm with separ

RE: [PATCH v7 01/21] net/cpfl: support device initialization

2023-02-27 Thread Liu, Mingxia
Thanks you all! It's a good question, but as it is experimental version and rc2 is approaching, we won't optimize this function now, and will do it at the time of the official product release. > -Original Message- > From: Thomas Monjalon > Sent: Monday, February 27, 2023 11:46 PM > To: A

RE: [PATCH v7 00/21] add support for cpfl PMD in DPDK

2023-02-27 Thread Zhang, Qi Z
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, February 28, 2023 5:44 AM > To: Liu, Mingxia ; Xing, Beilei > ; Zhang, Yuying > Cc: dev@dpdk.org; Mcnamara, John > Subject: Re: [PATCH v7 00/21] add support for cpfl PMD in DPDK > > On 2/16/2023 12:29 AM, Mingxia Liu wrote: >

Re: [RFC PATCH] drivers/net: fix RSS multi-queue mode check

2023-02-27 Thread lihuisong (C)
在 2023/2/27 17:57, Ferruh Yigit 写道: On 2/27/2023 1:34 AM, lihuisong (C) wrote: 在 2023/2/24 0:04, Ferruh Yigit 写道: 'rxmode.mq_mode' is an enum which should be an abstraction over values, instead of mask it with 'RTE_ETH_MQ_RX_RSS_FLAG' to detect if RSS is supported, directly compare with 'RTE_

RE: [PATCH v1] net/idpf: fix datapath function configuration

2023-02-27 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Wenjun1 > Sent: Monday, February 27, 2023 1:37 PM > To: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > ; Zhang, Qi Z > Cc: Wu, Wenjun1 > Subject: [PATCH v1] net/idpf: fix datapath function configuration > > Vector datapath is not support any advanced fea

Re: [PATCH v7 01/21] net/cpfl: support device initialization

2023-02-27 Thread Ferruh Yigit
On 2/27/2023 3:45 PM, Thomas Monjalon wrote: > 27/02/2023 14:46, Ferruh Yigit: >> On 2/16/2023 12:29 AM, Mingxia Liu wrote: >>> +static int >>> +cpfl_dev_configure(struct rte_eth_dev *dev) >>> +{ >>> + struct rte_eth_conf *conf = &dev->data->dev_conf; >>> + >>> + if (conf->link_speeds & RTE_ETH

Re: [PATCH v7 21/21] net/cpfl: add xstats ops

2023-02-27 Thread Ferruh Yigit
On 2/16/2023 12:30 AM, Mingxia Liu wrote: > Add support for these device ops: > - dev_xstats_get > - dev_xstats_get_names > - dev_xstats_reset > > Signed-off-by: Mingxia Liu > --- > drivers/net/cpfl/cpfl_ethdev.c | 80 ++ > 1 file changed, 80 insertions(+) > > di

Re: [PATCH v7 18/21] net/cpfl: add HW statistics

2023-02-27 Thread Ferruh Yigit
On 2/16/2023 12:30 AM, Mingxia Liu wrote: > This patch add hardware packets/bytes statistics. > > Signed-off-by: Mingxia Liu <...> > +static int > +cpfl_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > +{ > + struct idpf_vport *vport = > + (struct idpf_vport

Re: [PATCH v7 17/21] net/cpfl: add AVX512 data path for split queue model

2023-02-27 Thread Ferruh Yigit
On 2/16/2023 12:30 AM, Mingxia Liu wrote: > Add support of AVX512 data path for split queue model. > > Signed-off-by: Wenjun Wu > Signed-off-by: Mingxia Liu <...> > diff --git a/drivers/net/cpfl/meson.build b/drivers/net/cpfl/meson.build > index fbe6500826..2cf69258e2 100644 > --- a/drivers/ne

Re: [PATCH v7 15/21] net/cpfl: add AVX512 data path for single queue model

2023-02-27 Thread Ferruh Yigit
On 2/16/2023 12:30 AM, Mingxia Liu wrote: > Add support of AVX512 vector data path for single queue model. > > Signed-off-by: Wenjun Wu > Signed-off-by: Mingxia Liu <...> > diff --git a/drivers/net/cpfl/cpfl_rxtx.c b/drivers/net/cpfl/cpfl_rxtx.c > index c250642719..cb7bbddb16 100644 > --- a/dr

Re: [PATCH v7 13/21] net/cpfl: support Rx offloading

2023-02-27 Thread Ferruh Yigit
On 2/16/2023 12:30 AM, Mingxia Liu wrote: > Add Rx offloading support: > - support CHKSUM and RSS offload for split queue model > - support CHKSUM offload for single queue model > > Signed-off-by: Mingxia Liu > --- > doc/guides/nics/features/cpfl.ini | 2 ++ > drivers/net/cpfl/cpfl_ethdev.c

Re: [PATCH v7 12/21] net/cpfl: support RSS

2023-02-27 Thread Ferruh Yigit
On 2/16/2023 12:30 AM, Mingxia Liu wrote: > Add RSS support. > > Signed-off-by: Mingxia Liu <...> > static int > cpfl_dev_configure(struct rte_eth_dev *dev) > { > struct idpf_vport *vport = dev->data->dev_private; > struct rte_eth_conf *conf = &dev->data->dev_conf; > + struct

Re: [PATCH v7 11/21] net/cpfl: support write back based on ITR expire

2023-02-27 Thread Ferruh Yigit
On 2/16/2023 12:30 AM, Mingxia Liu wrote: > Enable write back on ITR expire, then packets can be received one by > Can you please describe this commit more? I can see a wrapper to 'idpf_vport_irq_map_config()' is called, what is configured related to the IRQ? What ITR stands for, etc...

Re: [PATCH v7 06/21] net/cpfl: support queue stop

2023-02-27 Thread Ferruh Yigit
On 2/16/2023 12:29 AM, Mingxia Liu wrote: > Add support for these device ops: > - rx_queue_stop > - tx_queue_stop > > Signed-off-by: Mingxia Liu <...> > +int > +cpfl_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id) > +{ > + struct idpf_vport *vport = dev->data->dev_private; >

Re: [PATCH v7 05/21] net/cpfl: support queue start

2023-02-27 Thread Ferruh Yigit
On 2/16/2023 12:29 AM, Mingxia Liu wrote: > Add support for these device ops: > - rx_queue_start > - tx_queue_start > > Signed-off-by: Mingxia Liu <...> > +int > +cpfl_rx_queue_init(struct rte_eth_dev *dev, uint16_t rx_queue_id) > +{ > + struct idpf_rx_queue *rxq; > + int err; > + > +

Re: [PATCH v7 03/21] net/cpfl: add Rx queue setup

2023-02-27 Thread Ferruh Yigit
On 2/16/2023 12:29 AM, Mingxia Liu wrote: > Add support for rx_queue_setup ops. > > Signed-off-by: Mingxia Liu <...> > + > + if (bufq_id == 1) { > + rxq->bufq1 = bufq; > + } else if (bufq_id == 2) { > + rxq->bufq2 = bufq; For readability better to use enums to d

Re: [PATCH v7 02/21] net/cpfl: add Tx queue setup

2023-02-27 Thread Ferruh Yigit
On 2/16/2023 12:29 AM, Mingxia Liu wrote: > Add support for tx_queue_setup ops. > > In the single queue model, the same descriptor queue is used by SW to > post buffer descriptors to HW and by HW to post completed descriptors > to SW. > > In the split queue model, "RX buffer queues" are used to p

Re: [PATCH v7 00/21] add support for cpfl PMD in DPDK

2023-02-27 Thread Ferruh Yigit
On 2/16/2023 12:29 AM, Mingxia Liu wrote: > The patchset introduced the cpfl (Control Plane Function Library) PMD > for Intel® IPU E2100’s Configure Physical Function (Device ID: 0x1453) > > The cpfl PMD inherits all the features from idpf PMD which will follow > an ongoing standard data plan func

Re: [PATCH v7 01/21] net/cpfl: support device initialization

2023-02-27 Thread Ferruh Yigit
On 2/16/2023 12:29 AM, Mingxia Liu wrote: > Support device init and add the following dev ops: > - dev_configure > - dev_close > - dev_infos_get > - link_update > - dev_supported_ptypes_get > > Signed-off-by: Mingxia Liu > --- > MAINTAINERS| 8 + > doc/guides/n

RE: [EXT] Re: [PATCH v11 1/4] lib: add generic support for reading PMU events

2023-02-27 Thread Konstantin Ananyev
> >> Add support for programming PMU counters and reading their values in > >> runtime bypassing kernel completely. > >> > >> This is especially useful in cases where CPU cores are isolated i.e > >> run dedicated tasks. In such cases one cannot use standard perf > >> utility without sacrificing l

RE: [PATCH v3 2/3] net/i40e: enable direct rearm with separate API

2023-02-27 Thread Konstantin Ananyev
> > > +int > > > +i40e_tx_fill_sw_ring(void *tx_queue, > > > + struct rte_eth_rxq_rearm_data *rxq_rearm_data) { > > > + struct i40e_tx_queue *txq = tx_queue; > > > + struct i40e_tx_entry *txep; > > > + void **rxep; > > > + struct rte_mbuf *m; > > > + int i, n; > > > + int nb_rearm = 0; >

RE: [PATCH v3 1/3] ethdev: enable direct rearm with separate API

2023-02-27 Thread Konstantin Ananyev
Hi Feifei , > > > + uint16_t *rearm_start; > > > + uint16_t *rearm_nb; > > > > I know that for Intel NICs uint16_t is sufficient, wonder would it always be > > for other vendors? > > Another thing to consider the case when ring position wrapping? > > Again I know that it is not required for Inte

RE: [PATCH 2/2] ethdev: fix race condition in fast-path ops setup

2023-02-27 Thread Konstantin Ananyev
> > > > > >>> > >>> BTW,  I don't see any implementation for RTE_ETH_EVENT_ERR_RECOVERING > >>> within > >>> either testpmd or any other example apps. > >>> Am I missing something? > >> > >> Currently it just promote the event. > > > > > > Ok, can I suggest then to add a proper usage for into in

RE: [EXT] [PATCH v1] crypto/ccp: bug fixes for ccp device probe flow

2023-02-27 Thread Akhil Goyal
> - Fixed flow for probe and initialization of requested ccp devices > - Removed unnecessary code enumerating for all the PCI devices > available in the system. > - Removed ccp_pmd_init_done flag controlling probe and initialization > of only one CCP device even if other CCP devices available >

RE: [EXT] [PATCH] ipsec_mb: expect ENOTSUP in ipsec_mb_create()

2023-02-27 Thread Akhil Goyal
> Subject: [EXT] [PATCH] ipsec_mb: expect ENOTSUP in ipsec_mb_create() Title should start with crypto/ipsec_mb: Avoid using function names in patch titles. > > Commit b35848bc01f6 ("crypto/ipsec_mb: add multi-process IPC request > handler") is part of DPDK 22.11 release and it enforces usage of

RE: [PATCH] app/test: enable SG tests for cn10k

2023-02-27 Thread Akhil Goyal
> Subject: [PATCH] app/test: enable SG tests for cn10k > test/crypto: enable SG tests for cn10k > Enabling Scatter Gather tests for cn10k. Removed PMD specific check in IPsec SG cases > > Signed-off-by: Tejasree Kondoj Acked-by: Akhil Goyal Applied with above changes on dpdk-next-crypto Tha

RE: [EXT] [PATCH v3 0/8] compress/mlx5: add LZ4 support

2023-02-27 Thread Akhil Goyal
> Add support for LZ4 decompression algorithm for mlx5 compress PMD. > Complete the support of compress PMD for Bluefield-3 smart-nic. > > RFC: > https://patchwork.dpdk.org/project/dpdk/patch/20220410182622.8828-1-rzid...@nvidia.com/ > > v2: > - Rebase. > - Update PRM names. > - Add a new fix

RE: [PATCH v3] examples/ipsec-secgw: set AES-CTR IV length to 16

2023-02-27 Thread Akhil Goyal
> Subject: [PATCH v3] examples/ipsec-secgw: set AES-CTR IV length to 16 > > Set AES-CTR IV length to 16 which includes > 8B per packet IV, 4B nonce and 4B counter > as populated in datapath. > > Signed-off-by: Tejasree Kondoj Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

RE: [PATCH v2 05/11] crypto/cnxk: set ctx for AE

2023-02-27 Thread Akhil Goyal
> Subject: [PATCH v2 05/11] crypto/cnxk: set ctx for AE > > Set ctx_val to 1 for asymmetric ops. > Please justify patch with proper description. > Signed-off-by: Tejasree Kondoj

RE: [PATCH 05/11] crypto/cnxk: set ctx for AE

2023-02-27 Thread Akhil Goyal
> Subject: [PATCH 05/11] crypto/cnxk: set ctx for AE > > Set ctx_val to 1 for asymmetric ops. > Please justify patch with appropriate description. > Signed-off-by: Tejasree Kondoj > ---

RE: [PATCH 1/3] examples/ipsec-secgw: fix auth IV length

2023-02-27 Thread Akhil Goyal
> Acked-by: Kai Ji Please do bottom post in future. Series Applied to dpdk-next-crypto

RE: [v1, 00/10] fips_validation application improvements

2023-02-27 Thread Akhil Goyal
> Hi Gowrishankar, > > Looks good to me. > > > Subject: [v1, 00/10] fips_validation application improvements > > > > This patch series adds support for SHA3, SHAKE, AES-CCM JSON test vectors > > and fixes existing algorithms to support NIST test vectors. > > > > Gowrishankar Muthukrishnan (10): >

[PATCH] eal: fix thread race in control thread creation

2023-02-27 Thread Tyler Retzlaff
When ctrl_thread_init transitions params->ctrl_thread_status from CTRL_THREAD_LAUNCHING the creating thread and new thread may run concurrently leading to unsynchronized access to params. This permits races for both the failure and success paths after ctrl_thread_status is stored. * params->ret

RE: [EXT] [PATCH] app/testeventdev: add cipher alg option for cryptodev

2023-02-27 Thread Akhil Goyal
> Testeventdev crypto adapter symmetric tests are only attempting > NULL cipher algorithm. This limits crypto adapter usage with only > PMDs that can support NULL cipher algorithm. Also, since NULL cipher > algorithm doesn't perform any crypto operation, the performance numbers > reported may not r

Re: [PATCH v6] app/procinfo: display eventdev xstats for PMD data

2023-02-27 Thread Jerin Jacob
On Thu, Feb 23, 2023 at 6:38 AM Abdullah Sevincer wrote: > > This commit extends proc-info application to > display xstats and PMD dump data for the eventdev > devices. > > New command line arguments are introduced to > display stats for eventdev devices. The command > example is like: > > For dis

Re: [PATCH] event/cnxk: add WQE stashing support

2023-02-27 Thread Jerin Jacob
On Tue, Feb 21, 2023 at 2:54 PM wrote: > > From: Pavan Nikhilesh > > CN10K supports stashing the scheduled WQE carried by `rte_event` to the > cores L2 Dcache.The number of cache lines to be stashed and the offset > is configurable per HWGRP i.e. event queue. > > By default, stashing is enabled o

Re: [PATCH v2 11/20] net/virtio: annotate lock for guest announce

2023-02-27 Thread Maxime Coquelin
Hi, On 2/27/23 09:24, David Marchand wrote: Hello Chenbo, Adding Maxime too. On Mon, Feb 27, 2023 at 3:05 AM Xia, Chenbo wrote: @@ -1217,7 +1217,7 @@ virtio_notify_peers(struct rte_eth_dev *dev) } /* If virtio port just stopped, no need to send RARP */ - if (virtio_dev_pau

Re: [PATCH] vhost: fix OOB access for invalid vid

2023-02-27 Thread Maxime Coquelin
On 2/27/23 11:59, David Marchand wrote: The net/vhost pmd currently provides a -1 vid when disabling interrupt after a virtio port got disconnected. This can be caught when running with ASan. First, start dpdk-l3fwd-power in interrupt mode with a net/vhost port. $ ./build-clang/examples/dpd

Re: [PATCH v2 00/20] Enable lock annotations on most libraries and drivers

2023-02-27 Thread Gaëtan Rivet
On Sat, Feb 25, 2023, at 11:16, David Marchand wrote: > Salut Gaëtan, > > On Fri, Feb 24, 2023 at 4:59 PM Gaëtan Rivet wrote: >> > FreeBSD libc pthread API has lock annotations while Linux glibc has >> > none. >> > We could simply disable the check on FreeBSD, but having this check, >> > a few iss

Re: [PATCH] service: split tests to perf and autotest to avoid spurious CI failures

2023-02-27 Thread David Marchand
Hello, On Fri, Feb 24, 2023 at 7:04 PM Harry van Haaren wrote: > > On some CI runs, some service-cores tests spuriously fail as the > service lcore thread is not actually scheduled by the OS in the > given amount of time. > > Increasing timeouts has not resolved the issue in the CI, so the > solu

Re: [PATCH v7 01/21] net/cpfl: support device initialization

2023-02-27 Thread Thomas Monjalon
27/02/2023 14:46, Ferruh Yigit: > On 2/16/2023 12:29 AM, Mingxia Liu wrote: > > +static int > > +cpfl_dev_configure(struct rte_eth_dev *dev) > > +{ > > + struct rte_eth_conf *conf = &dev->data->dev_conf; > > + > > + if (conf->link_speeds & RTE_ETH_LINK_SPEED_FIXED) { > > + PMD_INIT_LO

Re: [PATCH v7 01/21] net/cpfl: support device initialization

2023-02-27 Thread Ferruh Yigit
On 2/16/2023 12:29 AM, Mingxia Liu wrote: > +static int > +cpfl_dev_configure(struct rte_eth_dev *dev) > +{ > + struct rte_eth_conf *conf = &dev->data->dev_conf; > + > + if (conf->link_speeds & RTE_ETH_LINK_SPEED_FIXED) { > + PMD_INIT_LOG(ERR, "Setting link speed is not supporte

[PATCH] vhost: fix OOB access for invalid vid

2023-02-27 Thread David Marchand
The net/vhost pmd currently provides a -1 vid when disabling interrupt after a virtio port got disconnected. This can be caught when running with ASan. First, start dpdk-l3fwd-power in interrupt mode with a net/vhost port. $ ./build-clang/examples/dpdk-l3fwd-power -l0,1 --in-memory \ -a

RE: [PATCH v5 28/39] ml/cnxk: add internal function for sync mode run

2023-02-27 Thread Prince Takkar
> -Original Message- > From: Srikanth Yalavarthi > Sent: Tuesday, February 7, 2023 9:37 PM > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran ; > Anup Prabhu ; Prince Takkar ; > Parijat Shukla > Subject: [PATCH v5 28/39] ml/cn

Re: Bug in rte_mempool_do_generic_get?

2023-02-27 Thread Olivier Matz
On Mon, Feb 27, 2023 at 10:48:09AM +0100, Morten Brørup wrote: > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > Sent: Monday, 27 February 2023 10.10 > > > > Hi, > > > > On Sun, Feb 26, 2023 at 11:45:48AM +0100, Morten Brørup wrote: > > > > From: Harris, James R [mailto:james.r.har...@in

RE: [PATCH v4 0/6] add flex item implementation

2023-02-27 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Rongwei Liu > Sent: Thursday, February 23, 2023 2:49 PM > To: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) > Cc: Raslan Darawsheh > Subject: [PATCH v4 0/6] add flex item implementation > > Implemen

Re: [RFC PATCH] drivers/net: fix RSS multi-queue mode check

2023-02-27 Thread Ferruh Yigit
On 2/27/2023 1:34 AM, lihuisong (C) wrote: > > 在 2023/2/24 0:04, Ferruh Yigit 写道: >> 'rxmode.mq_mode' is an enum which should be an abstraction over values, >> instead of mask it with 'RTE_ETH_MQ_RX_RSS_FLAG' to detect if RSS is >> supported, directly compare with 'RTE_ETH_MQ_RX_RSS' enum element.

RE: Bug in rte_mempool_do_generic_get?

2023-02-27 Thread Morten Brørup
> From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Monday, 27 February 2023 10.10 > > Hi, > > On Sun, Feb 26, 2023 at 11:45:48AM +0100, Morten Brørup wrote: > > > From: Harris, James R [mailto:james.r.har...@intel.com] > > > Sent: Friday, 24 February 2023 17.43 > > > > > > > On Feb 24,

Re: [PATCH v2 04/16] test/bbdev: add timeout for latency tests

2023-02-27 Thread Maxime Coquelin
On 2/24/23 17:59, Vargas, Hernan wrote: Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Thursday, February 23, 2023 2:32 AM To: Vargas, Hernan ; dev@dpdk.org; gak...@marvell.com; Rix, Tom Cc: Chautru, Nicolas ; Zhang, Qi Z Subject: Re: [PATCH v2 04/16] test/bbdev: add ti

RE: [PATCH v11 0/6] add trace points in ethdev library

2023-02-27 Thread Ankur Dwivedi
>> Subject: [PATCH v11 0/6] add trace points in ethdev library >> >> This series adds trace points for functions in the ethdev library. >> The trace points are added in ethdev, flow, mtr and tm files. >> > >Hi Ankur, > >Testpmd segfaults at startup in debug mode on ppc64le, and git-bisect points >t

RE: [v1, 00/10] fips_validation application improvements

2023-02-27 Thread Dooley, Brian
Hi Gowrishankar, Looks good to me. > -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Monday 6 February 2023 14:46 > To: dev@dpdk.org > Cc: Anoob Joseph ; jer...@marvell.com; Akhil Goyal > ; Dooley, Brian ; > Gowrishankar Muthukrishnan > Subject: [v1, 00/10] fips_validation

RE: [v1, 01/10] examples/fips_validation: fix MCT output for SHA

2023-02-27 Thread Dooley, Brian
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Monday 6 February 2023 14:46 > To: dev@dpdk.org > Cc: Anoob Joseph ; jer...@marvell.com; Akhil Goyal > ; Dooley, Brian ; > Gowrishankar Muthukrishnan > Subject: [v1, 01/10] examples/fips_validation: fix MCT output for SHA >

RE: [v1, 02/10] examples/fips_validation: add SHA3 validation

2023-02-27 Thread Dooley, Brian
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Monday 6 February 2023 14:46 > To: dev@dpdk.org > Cc: Anoob Joseph ; jer...@marvell.com; Akhil Goyal > ; Dooley, Brian ; > Gowrishankar Muthukrishnan > Subject: [v1, 02/10] examples/fips_validation: add SHA3 validation > > A

RE: [v1, 03/10] examples/fips_validation: fix integer parse in test case

2023-02-27 Thread Dooley, Brian
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Monday 6 February 2023 14:46 > To: dev@dpdk.org > Cc: Anoob Joseph ; jer...@marvell.com; Akhil Goyal > ; Dooley, Brian ; > Gowrishankar Muthukrishnan > Subject: [v1, 03/10] examples/fips_validation: fix integer parse in test

RE: [v1, 04/10] examples/fips_validation: add SHAKE validation

2023-02-27 Thread Dooley, Brian
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Monday 6 February 2023 14:46 > To: dev@dpdk.org > Cc: Anoob Joseph ; jer...@marvell.com; Akhil Goyal > ; Dooley, Brian ; > Gowrishankar Muthukrishnan > Subject: [v1, 04/10] examples/fips_validation: add SHAKE validation > >

RE: [v1, 05/10] examples/fips_validation: add CCM JSON validation

2023-02-27 Thread Dooley, Brian
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Monday 6 February 2023 14:46 > To: dev@dpdk.org > Cc: Anoob Joseph ; jer...@marvell.com; Akhil Goyal > ; Dooley, Brian ; > Gowrishankar Muthukrishnan > Subject: [v1, 05/10] examples/fips_validation: add CCM JSON validation >

RE: [v1, 06/10] examples/fips_validation: add ECDSA keygen support

2023-02-27 Thread Dooley, Brian
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Monday 6 February 2023 14:46 > To: dev@dpdk.org > Cc: Anoob Joseph ; jer...@marvell.com; Akhil Goyal > ; Dooley, Brian ; > Gowrishankar Muthukrishnan > Subject: [v1, 06/10] examples/fips_validation: add ECDSA keygen support >

RE: [v1, 07/10] examples/fips_validation: add SHA3 algorithms in ECDSA test

2023-02-27 Thread Dooley, Brian
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Monday 6 February 2023 14:46 > To: dev@dpdk.org > Cc: Anoob Joseph ; jer...@marvell.com; Akhil Goyal > ; Dooley, Brian ; > Gowrishankar Muthukrishnan > Subject: [v1, 07/10] examples/fips_validation: add SHA3 algorithms in

RE: [v1, 08/10] examples/fips_validation: fix AES GCM validation tests

2023-02-27 Thread Dooley, Brian
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Monday 6 February 2023 14:46 > To: dev@dpdk.org > Cc: Anoob Joseph ; jer...@marvell.com; Akhil Goyal > ; Dooley, Brian ; > Gowrishankar Muthukrishnan > Subject: [v1, 08/10] examples/fips_validation: fix AES GCM validation tes

RE: [v1, 09/10] examples/fips_validation: fix AES XTS to read seq number

2023-02-27 Thread Dooley, Brian
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Monday 6 February 2023 14:46 > To: dev@dpdk.org > Cc: Anoob Joseph ; jer...@marvell.com; Akhil Goyal > ; Dooley, Brian ; > Gowrishankar Muthukrishnan > Subject: [v1, 09/10] examples/fips_validation: fix AES XTS to read seq >

RE: [v1, 10/10] examples/fips_validation: add extra space in JSON buffer

2023-02-27 Thread Dooley, Brian
Hi Gowrishankar, > -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Monday 6 February 2023 14:46 > To: dev@dpdk.org > Cc: Anoob Joseph ; jer...@marvell.com; Akhil Goyal > ; Dooley, Brian ; Gowrishankar > Muthukrishnan > Subject: [v1, 10/10] examples/fips_validation: add extr

RE: [EXT] Re: [PATCH v11 1/4] lib: add generic support for reading PMU events

2023-02-27 Thread Tomasz Duszynski
>-Original Message- >From: Konstantin Ananyev >Sent: Tuesday, February 21, 2023 3:17 AM >To: dev@dpdk.org >Subject: [EXT] Re: [PATCH v11 1/4] lib: add generic support for reading PMU >events > >External Email > >-- > >>

Re: Bug in rte_mempool_do_generic_get?

2023-02-27 Thread Olivier Matz
Hi, On Sun, Feb 26, 2023 at 11:45:48AM +0100, Morten Brørup wrote: > > From: Harris, James R [mailto:james.r.har...@intel.com] > > Sent: Friday, 24 February 2023 17.43 > > > > > On Feb 24, 2023, at 6:56 AM, Honnappa Nagarahalli > > wrote: > > > > > >> From: Morten Brørup > > >> Sent: Friday, Fe

Re: [PATCH v1 1/1] doc: update to Intel vRAN Boost PMD

2023-02-27 Thread Maxime Coquelin
On 2/24/23 19:20, Nicolas Chautru wrote: Cosmetic change to refer explictly to the full name of the PMD Intel vRAN Boost v1. VRB1 acronym is only used as a prefix within the code. Signed-off-by: Nicolas Chautru --- doc/guides/bbdevs/vrb1.rst | 6 +++--- 1 file changed, 3 insertions(+), 3

DPDK Release Status Meeting 2023-02-23

2023-02-27 Thread Mcnamara, John
Release status meeting minutes 2023-02-23 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * AMD * ARM * Debian/Microsoft * Intel * Marvell * Nvidia * Red Hat Release Dates - The following are the propose

RE: [PATCH v3] test/service: fix spurious failures by extending timeout

2023-02-27 Thread Van Haaren, Harry
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, February 23, 2023 8:15 PM > To: Van Haaren, Harry > Cc: David Marchand ; dev@dpdk.org; > dpdk...@iol.unh.edu; c...@dpdk.org; honnappa.nagaraha...@arm.com; > mattias.ronnblom ; Morten Brørup > ; Tyler Retzlaff ; > Aaron Conole

RE: [PATCH v3] test/service: fix spurious failures by extending timeout

2023-02-27 Thread Van Haaren, Harry
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, February 23, 2023 8:11 PM > To: Van Haaren, Harry ; dev@dpdk.org > Cc: David Marchand ; dev@dpdk.org; > dpdk...@iol.unh.edu; c...@dpdk.org; honnappa.nagaraha...@arm.com; > mattias.ronnblom ; Morten Brørup > ; Tyler Retzlaff ; >

Re: [PATCH v5 00/10] dts: add hello world testcase

2023-02-27 Thread Juraj Linkeš
> Hi Juraj, > Hi Wathsala, thanks for the comments. > Everything looks good except for couple of comments/suggestions. > If I’m not mistaken dpdk tarball is copied to the SUT over scp. However, > scp is already deprecated [1,2]. Is it possible to use rsync over ssh > instead? > We're going to r

Re: [PATCH v2 11/20] net/virtio: annotate lock for guest announce

2023-02-27 Thread David Marchand
Hello Chenbo, Adding Maxime too. On Mon, Feb 27, 2023 at 3:05 AM Xia, Chenbo wrote: > > @@ -1217,7 +1217,7 @@ virtio_notify_peers(struct rte_eth_dev *dev) > > } > > > > /* If virtio port just stopped, no need to send RARP */ > > - if (virtio_dev_pause(dev) < 0) { > > + if (vi

RE: [EXT] Re: [PATCH v11 1/4] lib: add generic support for reading PMU events

2023-02-27 Thread Tomasz Duszynski
>-Original Message- >From: Konstantin Ananyev >Sent: Tuesday, February 21, 2023 1:48 AM >To: Tomasz Duszynski ; Konstantin Ananyev >; >dev@dpdk.org >Subject: Re: [EXT] Re: [PATCH v11 1/4] lib: add generic support for reading >PMU events > > >> diff --git a/lib/pmu/rte_pmu.h b/l