Re: [PATCH] eal: use program_invocation_short_name

2023-03-12 Thread Thomas Monjalon
07/03/2023 17:53, Stephen Hemminger: > Glibc already has a documented variable with the program > name so use it instead of computing the value. > > Signed-off-by: Stephen Hemminger Applied, thanks.

Re: [PATCH v2] mem: fix displaying heap ID failed for heap info command

2023-03-12 Thread Thomas Monjalon
22/02/2023 08:53, Morten Brørup: > > From: Huisong Li [mailto:lihuis...@huawei.com] > > Sent: Wednesday, 22 February 2023 08.50 > o command > > > > The telemetry lib has added a allowed characters set for dictionary names. > > Please see commit 2537fb0c5f34 ("telemetry: limit characters allowed in

Re: [PATCH v4 00/19] Remove repeated words in comments and messages

2023-03-12 Thread Thomas Monjalon
22/02/2023 17:25, Stephen Hemminger: > This is a cleanup of comments and messages. Done by an ugly > pcregrep across sources and skipping lots of false positives > > The idea is based of what some maintainers have been doing in netdev. > > Series-acked-by: Bruce Richardson > > v4 - rebase and

Re: [PATCH v1] maintainers: update dts

2023-03-12 Thread Thomas Monjalon
17/02/2023 23:29, Honnappa Nagarahalli: > > > -Original Message- > > From: Juraj Linkeš > > Sent: Friday, February 17, 2023 9:57 AM > > To: tho...@monjalon.net; Honnappa Nagarahalli > > ; lijuan...@intel.com; > > david.march...@redhat.com > > Cc: dev@dpdk.org; Juraj Linkeš > > Subject: [

Re: [PATCH v2] mailmap: update mailmap entry for second address

2023-03-12 Thread Thomas Monjalon
08/02/2023 22:55, Tyler Retzlaff: > Signed-off-by: Tyler Retzlaff > --- > .mailmap | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > -Tyler Retzlaff > +Tyler Retzlaff Applied

[PATCH v3] net/sfc: stop misuse of Rx ingress m-port metadata on EF100

2023-03-12 Thread Ivan Malov
The driver supports representor functionality. In it, packets coming from VFs to the dedicated back-end Rx queue get demultiplexed into front-end Rx queues of representor ethdevs as per the per-packet metadata indicating logical HW ingress ports. On transmit, packets are provided with symmetrical m

Re: [PATCH v3 0/7] add space after keywords

2023-03-12 Thread Thomas Monjalon
17/01/2023 01:14, Stephen Hemminger: > Stephen Hemminger (7): > test: fix whitespace > testpmd: fix whitespace > net/e1000: fix whitespace > i40e: fix whitespace > examples: fix whitespace > cmdline: fix whitespace > ip_frag: fix whitespace Why these patches are marked as rejected in

[Bug 1179] lib/mldev build failure on aarch64 with gcc 4.8

2023-03-12 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1179 Bug ID: 1179 Summary: lib/mldev build failure on aarch64 with gcc 4.8 Product: DPDK Version: 23.03 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[PATCH] net/e1000: fix saving of stripped VLAN TCI

2023-03-12 Thread Visa Hankala
When receiving a scattered packet, save the stripped VLAN TCI in the first mbuf segment where users expect to find it. Signed-off-by: Visa Hankala diff --git a/drivers/net/e1000/em_rxtx.c b/drivers/net/e1000/em_rxtx.c index d48fd52404..cb5ce2307b 100644 --- a/drivers/net/e1000/em_rxtx.c +++ b/dr

Re: [PATCH v4] lib/bpf: Rename bpf function names to avoid potential conflict with libpcap

2023-03-12 Thread Konstantin Ananyev
12/03/2023 06:20, J.J. Martzki пишет: The library libpcap has their function 'bpf_validate' either so there would be a multiple definition issue when linking with librte_bpf.a and libpcap.a statically (Same as http://dpdk.org/patch/52631). So just rename the function names to avoid such issue. S

Re: [PATCH v3 1/1] app/test-flow-perf: fix division or module by zero

2023-03-12 Thread Thomas Monjalon
24/01/2023 11:38, Mohammad Iqbal Ahmad: > Fix division or module by zero reported by coverity scan. > Updated .mailmap > > Coverity issue: 373870 > Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation") > > Signed-off-by: Mohammad Iqbal Ahmad > --- > if (strc

Re: [PATCH] app/dumpcap: don't pass negative value to strerror() on error

2023-03-12 Thread Thomas Monjalon
07/02/2023 18:00, Stephen Hemminger: > If eth_stats_get fails (for example with -ENOTSUPP) then > dumpcap would pass that to strerror which is incorrect. > > Fixes: 8744f84bb255 ("app/dumpcap: add statistics mode") > Coverity issue: 383136 > Signed-off-by: Stephen Hemminger Changed the title to

Re: [PATCH] examples/ipsec-secgw: fix uninitialized offload variable

2023-03-12 Thread Thomas Monjalon
03/03/2023 09:20, Nithin Dabilpuram: > Fix uninitialized hw_reassembly offload variable. > > Fixes: d8d51d4f9bf5 ("examples/ipsec-secgw: support per SA HW reassembly") > Cc: rbhans...@marvell.com > > Signed-off-by: Nithin Dabilpuram Applied, thanks.

Re: [PATCH] examples/qos_sched: fix buffer overflow on mbuf free

2023-03-12 Thread Thomas Monjalon
> > When running the qos_sched app with separated worker and Tx threads, the > > app would seg-fault after a short time of handling packets. The root > > cause of this turns out to be an incorrect array index when freeing > > unsent packets post-Tx. Rather than freeing packets using the "nb_tx" > >

Re: [PATCH] examples/l3fwd-power: support CPPC cpufreq

2023-03-12 Thread Thomas Monjalon
22/02/2023 10:46, Hunt, David: > > On 22/02/2023 02:13, Jie Hai wrote: > > Hi, David Hunt, > > > > Kindly ping. Could you please take a look at this patch? > > > > Thanks, > > Jie Hai > > > > On 2023/1/31 10:58, Jie Hai wrote: > >> Currently the l3fwd-power only supports ACPI cpufreq and Pstate >

release candidate 23.03-rc2

2023-03-12 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v23.03-rc2 There are 319 new patches in this snapshot. Release notes: https://doc.dpdk.org/guides/rel_notes/release_23_03.html Few major additions arrived in this -rc2: - machine learning

need support with struct rte_eth_fdir_conf fdir_conf

2023-03-12 Thread Ajay Thakur
Hi, I am trying to upgrade vpp20.09 with dpdk 22.11 from vpp20.09 with dpdk 21.11. So it is just DPDK i am trying to upgrade to 22.11. I am encountering an issue with one of the structures. The structure *struct rte_eth_fdir_conf fdir_conf*; /**< FDIR configuration. DEPRECATED */ is deprecated in d

RE: [PATCH v3 0/3] mlx5: fix Windows build with Linux MinGW

2023-03-12 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Thomas Monjalon > Sent: Thursday, March 2, 2023 3:22 PM > To: dev@dpdk.org > Cc: Tal Shnaiderman > Subject: [PATCH v3 0/3] mlx5: fix Windows build with Linux MinGW > > The result is to make possible to compile mlx5 on Linux for Windows. > > v2: improve

[Bug 1180] TestPMD shell get stuck

2023-03-12 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1180 Bug ID: 1180 Summary: TestPMD shell get stuck Product: DPDK Version: unspecified Hardware: x86 OS: Windows Status: UNCONFIRMED Severity: major Priority:

RE: [PATCH v11 0/3] Fix cmdline_poll and testpmd signal handling

2023-03-12 Thread Tal Shnaiderman
> Subject: Re: [PATCH v11 0/3] Fix cmdline_poll and testpmd signal handling > > External email: Use caution opening links or attachments > > > 19/02/2023 18:53, Stephen Hemminger: > > On Fri, 3 Feb 2023 11:14:06 -0800 > > Stephen Hemminger wrote: > > > > > This patchset keeps uncovering b

Re: [Bug 1180] TestPMD shell get stuck

2023-03-12 Thread Stephen Hemminger
On Sun, 12 Mar 2023 17:09:12 + bugzi...@dpdk.org wrote: > https://bugs.dpdk.org/show_bug.cgi?id=1180 > > Bug ID: 1180 >Summary: TestPMD shell get stuck >Product: DPDK >Version: unspecified > Hardware: x86 > OS: Windows

Re: [Bug 1180] TestPMD shell get stuck

2023-03-12 Thread Stephen Hemminger
On Sun, 12 Mar 2023 17:09:12 + bugzi...@dpdk.org wrote: > https://bugs.dpdk.org/show_bug.cgi?id=1180 > > Bug ID: 1180 >Summary: TestPMD shell get stuck >Product: DPDK >Version: unspecified > Hardware: x86 > OS: Windows

RE: [PATCH] net/e1000: fix saving of stripped VLAN TCI

2023-03-12 Thread Wu, Wenjun1
Hi, > -Original Message- > From: Visa Hankala > Sent: Sunday, March 12, 2023 9:45 PM > To: dev@dpdk.org > Cc: Su, Simei ; Wu, Wenjun1 > Subject: [PATCH] net/e1000: fix saving of stripped VLAN TCI > > When receiving a scattered packet, save the stripped VLAN TCI in the first > mbuf segme

Re: [PATCH v4] lib/bpf: Rename bpf function names to avoid potential conflict with libpcap

2023-03-12 Thread J.J. Mars
Actually I'm still hesitating about the 'rte_' prefix either. So I'll try a new prefix in the next version, comments will be added together :) Konstantin Ananyev 于2023年3月12日周日 22:02写道: > > 12/03/2023 06:20, J.J. Martzki пишет: > > The library libpcap has their function 'bpf_validate' either so th

RE: [PATCH 1/2] raw/skeleton: fix selftest

2023-03-12 Thread Jiang, YuX
> -Original Message- > From: David Marchand > Sent: Friday, March 10, 2023 10:26 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Sachin Saxena ; Hemant > Agrawal ; Shreyansh Jain > > Subject: [PATCH 1/2] raw/skeleton: fix selftest > > ASan reported issues in this driver. > > rte_rawdev_obj

RE: [PATCH 3/3] net/vhost: fix Rx interrupt

2023-03-12 Thread Yuan, DukaiX
> -Original Message- > From: David Marchand > Sent: 2023年3月9日 20:38 > To: dev@dpdk.org > Cc: sta...@dpdk.org; Maxime Coquelin ; > Xia, Chenbo ; Jianfeng Tan > ; Junjie Chen ; Hyong > Youb Kim ; Harman Kalra > Subject: [PATCH 3/3] net/vhost: fix Rx interrupt > Tested-by: Dukai Yuan

RE: [PATCH v2 2/2] net/nfp: write link speed to control BAR

2023-03-12 Thread Chaoyong He
> On 3/10/2023 6:25 AM, Chaoyong He wrote: > > + /** > > +* Shift and mask nn_link_status so that it is effectively the value > > +* at offset NFP_NET_CFG_STS_NSP_LINK_RATE. > > +*/ > > + nn_link_status = (nn_link_status >> > NFP_NET_CFG_STS_LINK_RATE_SHIFT) & > > +

[dpdk-dev] [PATCH 1/2] common/cnxk: support SPI to SA translation action

2023-03-12 Thread psatheesh
From: Kiran Kumar K Support SPI to SA index translation action with SPI bits MS_28_25. Signed-off-by: Kiran Kumar K Reviewed-by: Satheesh Paul Reviewed-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_npc.c | 4 drivers/common/cnxk/roc_npc.h | 1 + 2 files changed, 5 insertions(+) dif

[dpdk-dev] [PATCH 2/2] common/cnxk: fix SPI to SA index destroy

2023-03-12 Thread psatheesh
From: Satheesh Paul While destroying SPI to SA index rule, inline device mbox should be used. Adding changes to fix this. Fixes: 04087b781484 ("common/cnxk: support SPI to SA index") Signed-off-by: Kiran Kumar K Signed-off-by: Satheesh Paul --- drivers/common/cnxk/roc_npc.c | 14 +++

RE: [EXT] [PATCH 06/16] net/cnxk: use previous value atomic fetch operations

2023-03-12 Thread Nithin Kumar Dabilpuram
Acked-by: Nithin Dabilpuram > -Original Message- > From: Tyler Retzlaff > Sent: Saturday, March 11, 2023 3:45 AM > To: dev@dpdk.org > Cc: honnappa.nagaraha...@arm.com; ruifeng.w...@arm.com; tho...@monjalon.net; > Tyler Retzlaff > Subject: [EXT] [PATCH 06/16] net/cnxk: use previous valu

RE: [PATCH] net/i40e: avx512 fast-free path bug fix

2023-03-12 Thread Zhang, Qi Z
> -Original Message- > From: Morten Brørup > Sent: Wednesday, March 8, 2023 4:26 AM > To: Kamalakshitha Aligeri ; Zhang, Yuying > ; Xing, Beilei ; Rong, Leyi > ; ruifeng.w...@arm.com; feifei.wa...@arm.com > Cc: n...@arm.com; dev@dpdk.org > Subject: RE: [PATCH] net/i40e: avx512 fast-free