https://bugs.dpdk.org/show_bug.cgi?id=1184
Bug ID: 1184
Summary: [dpdk-23.03] [asan]asan_smoke/rxtx_with_ASan_enable :
launch testpmd as global-buffer-overflow error.
Product: DPDK
Version: 23.03
Hardware: x86
On Tue, Mar 14, 2023 at 12:15 PM Srikanth Yalavarthi
wrote:
>
> Add ML to the list of platform hardware accelerator blocks,
> and added reference to ML device driver.
>
> Fixes: fe83ffd9ec2e ("ml/cnxk: add skeleton")
>
> Signed-off-by: Srikanth Yalavarthi
> Acked-by: Jerin Jacob
Applied to dpd
On Tue, Mar 14, 2023 at 11:29 AM Pavan Nikhilesh Bhagavatula
wrote:
>
>
>
> > -Original Message-
> > From: Shijith Thotton
> > Sent: Tuesday, March 14, 2023 9:17 AM
> > To: Jerin Jacob Kollanukkaran
> > Cc: Shijith Thotton ; dev@dpdk.org; Pavan
> > Nikhilesh Bhagavatula
> > Subject: [PA
On Mon, Mar 13, 2023 at 10:54 AM wrote:
>
> From: Satheesh Paul
>
> While destroying SPI to SA index rule, inline device
> mbox should be used. Adding changes to fix this.
>
> Fixes: 04087b781484 ("common/cnxk: support SPI to SA index")
Merged only 2/2 for rc3 as it is a fix.
Applied to dpdk-nex
> Subject: [PATCH] crypto/cnxk: update number of max capabilities
>
> To ensure that the end marker can fit into the capabilities array, the max
> number of capabilities has been incremented.
> Additionally, throw an error if max length is reached. It's critical because
> `rte_cryptodev_capabiliti
This patch adds dump private info in 'show port info [port_id]' cmd.
Signed-off-by: Chengwen Feng
---
app/test-pmd/config.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 018536f177..ab5199f223 100644
--- a/app/test-pmd/config.c
+++ b
On 2023/3/14 21:45, Ferruh Yigit wrote:
> On 3/14/2023 11:50 AM, Chengwen Feng wrote:
>> This patch adds 'dump_eth_priv [port_id]' which could used to dump
>> the specific ethdev port private info.
>>
>
> We have already "show port ..." commands to display various port related
> information, what
Acked-by: Chengwen Feng
On 2023/3/14 22:29, Thomas Monjalon wrote:
> The impact of the option "enable_iova_as_pa" is explained for users.
>
> Also the code flag "RTE_IOVA_AS_PA" is renamed as "RTE_IOVA_IN_MBUF"
> in order to be more accurate (IOVA mode is decided at runtime),
> and more readable
On Tue, Mar 14, 2023 at 06:20:42PM -0700, Stephen Hemminger wrote:
> On Tue, 14 Mar 2023 15:50:39 -0700
> Tyler Retzlaff wrote:
>
> > + /* Wait for the thread wrapper to initialize thread successfully */
> > + while ((thread_wrapper_status =
> > + __atomic_load_n(&ctx->thread_wrappe
On Tue, 14 Mar 2023 15:50:39 -0700
Tyler Retzlaff wrote:
> + /* Wait for the thread wrapper to initialize thread successfully */
> + while ((thread_wrapper_status =
> + __atomic_load_n(&ctx->thread_wrapper_status,
> + __ATOMIC_ACQUIRE)) == THREAD_WRAPPER_LAUNCHING)
In rte_thread_create setting affinity after pthread_create may fail.
Such a failure should result in the entire rte_thread_create failing
but doesn't.
Additionally if there is a failure to set affinity a race exists where
the creating thread will free ctx and depending on scheduling of the new
thr
v4:
* style fixes reported by CI
v3:
* don't free wrapper context from new thread now that wrapper
completion is complete before returning from creating thread.
v2:
* new approach over v1 of the patch to avoid using pthread np API that
is not available on Alpine Linux.
* to confor
const qualify rte_cpuset_t *cpusetp parameter in the
rte_thread_set_affinity API.
Signed-off-by: Tyler Retzlaff
---
lib/eal/common/eal_common_thread.c | 6 +++---
lib/eal/include/rte_thread.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/eal/common/eal_common_t
In rte_thread_create setting affinity after pthread_create may fail.
Such a failure should result in the entire rte_thread_create failing
but doesn't.
Additionally if there is a failure to set affinity a race exists where
the creating thread will free ctx and depending on scheduling of the new
thr
const qualify rte_cpuset_t *cpusetp parameter in the
rte_thread_set_affinity API.
Signed-off-by: Tyler Retzlaff
---
lib/eal/common/eal_common_thread.c | 6 +++---
lib/eal/include/rte_thread.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/eal/common/eal_common_t
v3:
* don't free wrapper context from new thread now that wrapper
completion is complete before returning from creating thread.
v2:
* new approach over v1 of the patch to avoid using pthread np API that
is not available on Alpine Linux.
* to conform to rte_thread_create parameter con
On Tue, 14 Mar 2023 10:36:45 -0700
Stephen Hemminger wrote:
> Resolve issues around using control-C in testpmd.
> Using cmdline_poll() is broken and won't work right so
> don't use it. Instead use cmdline_interact() and fix
> the signal handling.
>
> Stephen Hemminger (3):
> testpmd: go back t
From: Arkadiusz Kusztal
Added sessionless ECDSA known answer test cases to
QAT asym crypto testsuite.
Signed-off-by: Arkadiusz Kusztal
Signed-off-by: Kai Ji
---
app/test/test_cryptodev_asym.c | 209 +
1 file changed, 209 insertions(+)
diff --git a/app/test/tes
From: Arkadiusz Kusztal
Added Elliptic-Curve Diffie Hellman test cases.
Signed-off-by: Arkadiusz Kusztal
Signed-off-by: Kai Ji
---
app/test/test_cryptodev_asym.c | 366
app/test/test_cryptodev_ecdh_test_vectors.h | 144
2 files changed, 510 insertion
From: Arkadiusz Kusztal
Added Diffie-Hellman tests. This tests adding possibility
to check correctness of particular DH phases, which is not
possible with current tests cases.
Signed-off-by: Arkadiusz Kusztal
Signed-off-by: Kai Ji
---
app/test/test_cryptodev_asym.c| 264 ++
This patch add in the new DH, ECDH and ECDSA asymc test cases.
Arkadiusz Kusztal (3):
app/test: add diffie-hellman test cases
app/test: add ecdh test cases
app/test: add ecdsa kat sessionless tests
app/test/test_cryptodev_asym.c | 839
app/test/test_crypto
On Tue, Mar 14, 2023 at 07:04:19PM +0100, Mattias Rönnblom wrote:
> On 2023-03-14 17:29, Bruce Richardson wrote:
> > On Tue, Mar 14, 2023 at 05:22:02PM +0100, Mattias Rönnblom wrote:
> > > Hi.
> > >
> > > Is the "b_staticpic" meson build option supposed to work with DPDK?
> > >
> > > Setting it t
14/03/2023 19:06, Stephen Hemminger:
> On Sun, 12 Mar 2023 12:28:22 +0100
> Thomas Monjalon wrote:
>
> > 17/01/2023 01:14, Stephen Hemminger:
> > > Stephen Hemminger (7):
> > > test: fix whitespace
> > > testpmd: fix whitespace
> > > net/e1000: fix whitespace
> > > i40e: fix whitespace
>
On Sun, 12 Mar 2023 12:28:22 +0100
Thomas Monjalon wrote:
> 17/01/2023 01:14, Stephen Hemminger:
> > Stephen Hemminger (7):
> > test: fix whitespace
> > testpmd: fix whitespace
> > net/e1000: fix whitespace
> > i40e: fix whitespace
> > examples: fix whitespace
> > cmdline: fix whitesp
On 2023-03-14 17:29, Bruce Richardson wrote:
On Tue, Mar 14, 2023 at 05:22:02PM +0100, Mattias Rönnblom wrote:
Hi.
Is the "b_staticpic" meson build option supposed to work with DPDK?
Setting it to "false" (default is "true") causes link failures on Ubuntu
22.04, with GCC 9 and 11, on v23.03rc1
Standard conforming signal handling in applications should use sig_atomic_t
for flags set by signal handler.
https://www.gnu.org/software/libc/manual/html_node/Atomic-Data-Access.html
This is really just a fancy way of saying ''int'' but adds
to platform portablilty for DPDK.
Signed-off-by: Step
The setting in terminal handling for both Unix style and
Windows was not ensuring that Ctrl-C character would
cause interrupt.
This is a first release bug. Testpmd interactive mode has
always disabled control-c handling on Linux.
Fixes: af75078fece3 ("first public release")
Signed-off-by: Stephen
The cmdline library poll function is broken on Windows
and was never tested, don't use it.
Instead, use sigaction() to cancel read character on Unix OS's
and a new helper to cancel I/O on Windows.
Fixes: 0fd1386c30c3 ("app/testpmd: cleanup cleanly from signal")
Bugzilla ID: 1180
Signed-off-by: St
Resolve issues around using control-C in testpmd.
Using cmdline_poll() is broken and won't work right so
don't use it. Instead use cmdline_interact() and fix
the signal handling.
Stephen Hemminger (3):
testpmd: go back to using cmdline_interact
testpmd: use sig_atomic_t for flag
testpmd: ena
Acked-by: Kai Ji
> -Original Message-
> From: Karas, Krzysztof
> Sent: Monday, March 13, 2023 12:01 PM
> To: Thomas Monjalon ; Ji, Kai ;
> De Lara Guarch, Pablo ; Kusztal,
> ArkadiuszX
> Cc: dev@dpdk.org; Karas, Krzysztof
> Subject: [PATCH v2] crypto/ipsec_mb: expect ENOTSUP
>
> Commi
Function was added by commit 067855e651d6 ("cmdline: add polling mode")
but never tested or used by DPDK applications. Mark it for
future removal.
Signed-off-by: Stephen Hemminger
---
doc/guides/rel_notes/deprecation.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/doc/guides/rel_not
On Tue, Mar 14, 2023 at 05:22:02PM +0100, Mattias Rönnblom wrote:
> Hi.
>
> Is the "b_staticpic" meson build option supposed to work with DPDK?
>
> Setting it to "false" (default is "true") causes link failures on Ubuntu
> 22.04, with GCC 9 and 11, on v23.03rc1 and v22.11:
>
> /usr/bin/ld: lib/l
Hi.
Is the "b_staticpic" meson build option supposed to work with DPDK?
Setting it to "false" (default is "true") causes link failures on Ubuntu
22.04, with GCC 9 and 11, on v23.03rc1 and v22.11:
/usr/bin/ld: lib/librte_eal.a.p/eal_common_eal_common_errno.c.o:
relocation R_X86_64_TPOFF32 aga
Hi Alexander,
Glad to see the response from the community on this thread.
Thanks for the information, I will go through the code that you pointed
out. Does Intel(R) Atom(TM) CPU C37xx support the optimized power state
mode? Is there a chance of losing packets(rx-miss in NIC) in the low power
mode
If IOVA as PA is disabled and the driver requires the IOVA field,
the build of the driver was disabled.
Unfortunately some drivers were building some sub-libraries
(with specific options for vector paths) which were not disabled.
The build parsing of those drivers need to be skipped earlier
to avo
From: Mahipal Challa
Claim octeontx compress, common and mempool drivers
do not require IOVA mbuf field,
so they can build when disabling enable_iova_as_pa.
Signed-off-by: Mahipal Challa
---
drivers/common/octeontx/meson.build | 2 ++
drivers/compress/octeontx/meson.build | 2 ++
drivers/mem
From: Chengwen Feng
Claim PMD does not require IOVA mbuf field,
so it can build when disabling enable_iova_as_pa.
Signed-off-by: Chengwen Feng
---
drivers/dma/hisilicon/meson.build | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/dma/hisilicon/meson.build
b/drivers/dma/hisilicon/
From: Chengwen Feng
Claim PMD does not require IOVA mbuf field,
so it can build when disabling enable_iova_as_pa.
Signed-off-by: Chengwen Feng
Reviewed-by: Ruifeng Wang
Acked-by: Dongdong Liu
---
drivers/net/hns3/hns3_rxtx_vec_neon.h | 2 +-
drivers/net/hns3/hns3_rxtx_vec_sve.c | 13 ++
The impact of the option "enable_iova_as_pa" is explained for users.
Also the code flag "RTE_IOVA_AS_PA" is renamed as "RTE_IOVA_IN_MBUF"
in order to be more accurate (IOVA mode is decided at runtime),
and more readable in the code.
Similarly the drivers are using the variable "require_iova_in_mb
As discussed recently in some email threads,
it looks simpler to reword the feature "enabling IOVA as PA"
to "requiring IOVA in mbuf".
The Meson option name is not changed (compatibility is kept)
but the variables are renamed.
Some patches to allow building of some drivers are integrated.
The las
The library libpcap has their function 'bpf_validate' either so there would
be a multiple definition issue when linking with librte_bpf.a and libpcap.a
statically (Same as http://dpdk.org/patch/52631). So just rename the
function names to avoid such issue.
Signed-off-by: J.J. Martzki
---
v5:
* U
To ensure that the end marker can fit into the capabilities array, the
max number of capabilities has been incremented.
Additionally, throw an error if max length is reached. It's critical
because `rte_cryptodev_capabilities` in dev_info relies on the end marker.
Without it, all capabilities scans
On Tue, Mar 14, 2023 at 12:47:54PM +0100, David Marchand wrote:
> On Tue, Mar 14, 2023 at 12:31 AM Tyler Retzlaff
> wrote:
> >
> > v2:
> > * new approach over v1 of the patch to avoid using pthread np API that
> > is not available on Alpine Linux.
> > * to conform to rte_thread_create para
Add a validation test suite that helps in verifying that the output
generated by two different cryptodevs match for a wide range of input
parameter combinations.
Crypto autotest performs a comprehensive testing of the cryptodev but since
it performs verification by comparing against known vectors,
https://bugs.dpdk.org/show_bug.cgi?id=1183
minglongdai (1071535...@qq.com) changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
Resolution|---
https://bugs.dpdk.org/show_bug.cgi?id=1182
minglongdai (1071535...@qq.com) changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
Resolution|---
On 3/14/2023 11:50 AM, Chengwen Feng wrote:
> This patch adds 'dump_eth_priv [port_id]' which could used to dump
> the specific ethdev port private info.
>
We have already "show port ..." commands to display various port related
information, what do you think to follow same syntax for port privat
https://bugs.dpdk.org/show_bug.cgi?id=1183
Bug ID: 1183
Summary: There should be a NULL pointer check when we merge 2
ACL Trie in lib_rteacl ?
Product: DPDK
Version: 20.11
Hardware: All
OS: All
S
https://bugs.dpdk.org/show_bug.cgi?id=1182
Bug ID: 1182
Summary: There should be a NULL pointer check when we merge 2
ACL Trie in lib_rteacl ?
Product: DPDK
Version: 20.11
Hardware: All
OS: All
S
Hi Ciara,
> -Original Message-
> From: Power, Ciara
> Sent: Wednesday, March 8, 2023 6:31 PM
> To: Volodymyr Fialko ; dev@dpdk.org; Akhil Goyal
> ; Fan
> Zhang
> Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph
> ;
> hemant.agra...@nxp.com; Ji, Kai
> Subject: [EXT] RE: [PATCH v2] test: ad
Add a validation test suite that helps in verifying that the output
generated by two different cryptodevs match for a wide range of input
parameter combinations.
Crypto autotest performs a comprehensive testing of the cryptodev but since
it performs verification by comparing against known vectors,
Hi, David
Thank you for the fix.
I see the quite similar strncpy() usage in mlx5_xstats_get_names() routine.
Does compiler complain about?
With best regards,
Slava
> -Original Message-
> From: David Marchand
> Sent: четверг, 9 марта 2023 г. 11:03
> To: dev@dpdk.org
> Cc: sta...@dpdk.org
The rte_kvargs_process() was used to parse KV pairs, it also supports
to parse 'only keys' (e.g. socket_id) type. And the callback function
parameter 'value' is NULL when parsed 'only keys'.
This patch fixes segment fault when parse input args with 'only keys'.
Fixes: 4c173302c307 ("pcap: add new
The rte_kvargs_process() was used to parse KV pairs, it also supports
to parse 'only keys' (e.g. socket_id) type. And the callback function
parameter 'value' is NULL when parsed 'only keys'.
This patch fixes segment fault when parse input args with 'only keys'.
Fixes: 9e7fc8b8f3be ("net/sfc: add
The rte_kvargs_process() was used to parse KV pairs, it also supports
to parse 'only keys' (e.g. socket_id) type. And the callback function
parameter 'value' is NULL when parsed 'only keys'.
This patch fixes segment fault when parse input args with 'only keys'.
Fixes: 61934c0956d4 ("ring: convert
The rte_kvargs_process() was used to parse KV pairs, it also supports
to parse 'only keys' (e.g. socket_id) type. And the callback function
parameter 'value' is NULL when parsed 'only keys'.
This patch fixes segment fault when parse --pdump args with 'only keys'
(e.g. 'port,queue=*').
Fixes: caa7
The rte_kvargs_process() was used to parse KV pairs, it also supports
to parse 'only keys' (e.g. socket_id) type. And the callback function
parameter 'value' is NULL when parsed 'only keys'.
This patch fixes segment fault when parse input args with 'only keys'.
Fixes: 09c7e63a71f9 ("net/memif: in
The rte_kvargs_process() was used to parse KV pairs, it also supports
to parse 'only keys' (e.g. socket_id) type. And the callback function
parameter 'value' is NULL when parsed 'only keys'.
It may leads to segment fault when parse args with 'only key', this
patchset fixes rest of them.
Chengwe
This patch adds 'dump_eth_priv [port_id]' which could used to dump
the specific ethdev port private info.
Signed-off-by: Chengwen Feng
---
app/test-pmd/cmdline.c | 43 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7
2 files changed, 50 insertions
On Tue, Mar 14, 2023 at 12:31 AM Tyler Retzlaff
wrote:
>
> v2:
> * new approach over v1 of the patch to avoid using pthread np API that
> is not available on Alpine Linux.
> * to conform to rte_thread_create parameter const qualification include
> an additional patch to const qualify r
On 3/14/23 09:59, David Marchand wrote:
On Thu, Mar 9, 2023 at 1:38 PM David Marchand wrote:
In the situation when a port was started while no virtio driver was
connected, Rx interrupts were broken.
They were also broken after a virtio driver reconnects.
There were several issues mixed in:
> From: Arkadiusz Kusztal
>
> Added Diffie-Hellman tests. This tests adding possibility
> to check correctness of particular DH phases, which is not
> possible with current tests cases.
>
> Signed-off-by: Arkadiusz Kusztal
> Signed-off-by: Kai Ji
This series will be deferred for next release
> Subject: RE: [EXT] [PATCH v2] crypto/ccp: bug fixes for ccp device probe flow
>
> > Subject: [EXT] [PATCH v2] crypto/ccp: bug fixes for ccp device probe flow
> > - Rebasing patch([v1] crypto/ccp: bug fixes for ccp device probe flow)
>
> Please write a meaningful patch title and description
> Al
> > Subject: [PATCH v2 0/5] test/crypto: add ZUC256 chained tests
> >
> > This patchset adds chained testcases for each ZUC256 digest size:
> > - cipher-auth
> > - auth-cipher
> > - auth-cipher-verify
> >
> > To add these tests, some improvements were made to the existing code,
> > allowing for
On Thu, Mar 9, 2023 at 10:03 AM David Marchand
wrote:
>
> Building with gcc 12 and ASan raises this warning:
>
> ../drivers/net/mlx5/mlx5_txpp.c: In function ‘mlx5_txpp_xstats_get_names’:
> ../drivers/net/mlx5/mlx5_txpp.c:1066:25: error: ‘strncpy’ specified bound
> 64 equals destination si
On Thu, Mar 9, 2023 at 1:38 PM David Marchand wrote:
>
> In the situation when a port was started while no virtio driver was
> connected, Rx interrupts were broken.
> They were also broken after a virtio driver reconnects.
>
> There were several issues mixed in:
> - this driver was not exposing a
Modern devices don't have the same limitation as legacy devices, because
vring addresses are not configured using a 32-bit register.
Fixes: 6ba1f63b5ab0 ("virtio: support specification 1.0")
Cc: sta...@dpdk.org
Signed-off-by: David Marchand
Reviewed-by: Maxime Coquelin
Acked-by: Andy Pei
Revie
Hi David,
Sorry I miss that email, I will try to fix it ASAP.
Thanks,
Rosen
> -Original Message-
> From: David Marchand
> Sent: Tuesday, March 14, 2023 4:20 PM
> To: Xu, Rosen
> Cc: dev@dpdk.org
> Subject: Re: [Bug 1094] Add FPGA bus cleanup
>
> Hi Rosen,
>
> I don't think you are su
On Fri, Mar 10, 2023 at 3:26 PM David Marchand
wrote:
>
> ASan reported issues in this driver.
>
> rte_rawdev_obj_t context object points at a uint16_t.
> skeleton_rawdev_enqueue_bufs() and skeleton_rawdev_dequeue_bufs() were
> incorrectly casting to an int.
>
> The enqueue/dequeue selftest had a
https://bugs.dpdk.org/show_bug.cgi?id=813
David Marchand (david.march...@redhat.com) changed:
What|Removed |Added
Status|UNCONFIRMED |RESOLVED
Hi Rosen,
I don't think you are subscribed to bugzilla, so pinging here.
On Wed, Oct 5, 2022 at 12:49 PM wrote:
>
> https://bugs.dpdk.org/show_bug.cgi?id=1094
>
> Bug ID: 1094
>Summary: Add FPGA bus cleanup
>Product: DPDK
>Version: unspecified
>
> -Original Message-
> From: Stephen Hemminger
> Sent: Tuesday, March 14, 2023 5:39 AM
> To: dev@dpdk.org
> Cc: Stephen Hemminger
> Subject: [RFT v2] test-pmd: go back to using cmdline_interact
>
> The cmdline library poll function is broken on Windows and was never tested,
> don't use i
> -Original Message-
> From: Stephen Hemminger
> Sent: Monday, March 13, 2023 11:53 PM
> To: Ling, WeiX
> Cc: Tal Shnaiderman ; NBU-Contact-Thomas Monjalon
> (EXTERNAL) ; Pier Damouny
> ; dev@dpdk.org; sta...@dpdk.org;
> ferruh.yi...@amd.com; Singh, Aman Deep ;
> Zhang, Yuying ; Raslan Da
73 matches
Mail list logo
