Re: [PATCH v11 1/5] net/enetfec: introduce NXP ENETFEC driver

2023-03-22 Thread Sachin Saxena (OSS)
On 3/21/2023 11:33 PM, Ferruh Yigit wrote: On 11/15/2021 7:19 AM, Apeksha Gupta wrote: +ENETFEC +--- + +This section provides an overview of the NXP ENETFEC and how it is +integrated into the DPDK. Driver is taken as **experimental** as driver +depends on a Linux kernel module 'enetfec-uio',

[PATCH v1] doc/guides/nics: remove limitation of ipn3ke

2023-03-22 Thread Wei Huang
Now ipn3ke is not evaluation in 19.05 . Signed-off-by: Wei Huang --- doc/guides/nics/ipn3ke.rst | 4 1 file changed, 4 deletions(-) diff --git a/doc/guides/nics/ipn3ke.rst b/doc/guides/nics/ipn3ke.rst index a89e371..d269bbe 100644 --- a/doc/guides/nics/ipn3ke.rst +++ b/doc/guides/nics/ipn3

RE: [EXT] [PATCH 2/4] ml/cnkx: remove unnecessary null checks

2023-03-22 Thread Srikanth Yalavarthi
> -Original Message- > From: Stephen Hemminger > Sent: 23 March 2023 06:34 > To: dev@dpdk.org > Cc: Stephen Hemminger ; Srikanth > Yalavarthi ; Srikanth Yalavarthi > > Subject: [EXT] [PATCH 2/4] ml/cnkx: remove unnecessary null checks > > External Email > > -

RE: [EXT] [PATCH 1/4] mldev: remove unnecessary null free checks

2023-03-22 Thread Srikanth Yalavarthi
> -Original Message- > From: Stephen Hemminger > Sent: 23 March 2023 06:34 > To: dev@dpdk.org > Cc: Stephen Hemminger ; Srikanth > Yalavarthi ; Srikanth Yalavarthi > > Subject: [EXT] [PATCH 1/4] mldev: remove unnecessary null free checks > > External Email > > --

回复: build dpdk error by gcc 8.4.0

2023-03-22 Thread hfli
Hi Bruce, The issue has been fixed after I upgrade binutis to 2.38, thanks a lot. Regards, Haifeng -邮件原件- 发件人: Bruce Richardson 发送时间: 2023年3月21日 19:54 收件人: h...@netitest.com 抄送: dev@dpdk.org 主题: Re: build dpdk error by gcc 8.4.0 On Tue, Mar 21, 2023 at 03:13:14PM +0800, h...@netitest

RE: [PATCH v1] raw/ifpga: remove virtual device unplug operation

2023-03-22 Thread Huang, Wei
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, March 22, 2023 19:54 > To: Huang, Wei > Cc: dev@dpdk.org; david.march...@redhat.com; sta...@dpdk.org; Xu, > Rosen ; Zhang, Tianfei ; > Zhang, Qi Z > Subject: Re: [PATCH v1] raw/ifpga: remove virtual device unplug operatio

[PATCH 4/4] examples/fips_validation: remove unneeded null checks

2023-03-22 Thread Stephen Hemminger
No check for null pointer is necessary before calling free(). Signed-off-by: Stephen Hemminger --- examples/fips_validation/main.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c index 2c4353185edd..4c231

[PATCH 3/4] graph: remove unnicessary null checks

2023-03-22 Thread Stephen Hemminger
Checking for null before calling rte_mempool_free is unnecessary. Signed-off-by: Stephen Hemminger --- lib/graph/graph_pcap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/graph/graph_pcap.c b/lib/graph/graph_pcap.c index 9cbd1b8fdb6c..6c433300290b 100644 --- a/lib/gr

[PATCH 2/4] ml/cnkx: remove unnecessary null checks

2023-03-22 Thread Stephen Hemminger
These are places where null check is not necessary before calling free. Signed-off-by: Stephen Hemminger --- drivers/ml/cnxk/cn10k_ml_dev.c | 9 +++-- drivers/ml/cnxk/cn10k_ml_ops.c | 12 2 files changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/ml/cnxk/cn10k_ml_d

[PATCH 1/4] mldev: remove unnecessary null free checks

2023-03-22 Thread Stephen Hemminger
These are places where mldev is doing unnecessary checks for calling free() style functions. Signed-off-by: Stephen Hemminger --- app/test-mldev/test_device_ops.c | 6 ++ app/test-mldev/test_inference_common.c | 24 app/test-mldev/test_model_ops.c| 6

[PATCH 0/4] Remove unnecessary null free checks

2023-03-22 Thread Stephen Hemminger
These were produced by using coccinelle script. $ ./devtools/cocci.sh ./devtools/cocci/nullfree.cocci Stephen Hemminger (4): mldev: remove unnecessary null free checks ml/cnkx: remove unnecessary null checks graph: remove unnicessary null checks examples/fips_validation: remove unneeded

Re: [PATCH] net/tap: resolve stringop-overflow with gcc 12 on ppc64le

2023-03-22 Thread Stephen Hemminger
On Wed, 22 Mar 2023 17:24:39 -0400 David Christensen wrote: > Building DPDK with gcc 12 on a ppc64le system generates a > stringop-overflow warning. Replace the local MAC address > validation function parse_user_mac() with a call to > rte_ether_unformat_addr() instead. > > Bugzilla ID: 1197 > Cc

RE: [PATCH] devtools: stop compiler atomics with no C11 equivalent

2023-03-22 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 22 March 2023 22.00 > > On Wed, Mar 22, 2023 at 07:25:09PM +0100, Morten Brørup wrote: > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > Sent: Wednesday, 22 March 2023 19.08 > > > > > > adding a fe

[PATCH] net/tap: resolve stringop-overflow with gcc 12 on ppc64le

2023-03-22 Thread David Christensen
Building DPDK with gcc 12 on a ppc64le system generates a stringop-overflow warning. Replace the local MAC address validation function parse_user_mac() with a call to rte_ether_unformat_addr() instead. Bugzilla ID: 1197 Cc: sta...@dpdk.org Signed-off-by: David Christensen --- drivers/net/tap/rt

Re: [PATCH] devtools: stop compiler atomics with no C11 equivalent

2023-03-22 Thread Tyler Retzlaff
On Wed, Mar 22, 2023 at 07:25:09PM +0100, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Wednesday, 22 March 2023 19.08 > > > > adding a few more people to cc for attention > > > > On Mon, Mar 20, 2023 at 09:22:01AM -0700, Tyler Retzlaff wrote: > > >

RE: [PATCH] devtools: stop compiler atomics with no C11 equivalent

2023-03-22 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 22 March 2023 19.08 > > adding a few more people to cc for attention > > On Mon, Mar 20, 2023 at 09:22:01AM -0700, Tyler Retzlaff wrote: > > Refrain from using compiler __atomic_{add,and,nand,or,sub,xor}_fetch() > > t

Re: [PATCH] devtools: stop compiler atomics with no C11 equivalent

2023-03-22 Thread Tyler Retzlaff
adding a few more people to cc for attention On Mon, Mar 20, 2023 at 09:22:01AM -0700, Tyler Retzlaff wrote: > Refrain from using compiler __atomic_{add,and,nand,or,sub,xor}_fetch() > to ease future adoption of C11 standard atomics. > > Signed-off-by: Tyler Retzlaff > --- > devtools/checkpatche

Re: [PATCH 0/7] replace rte atomics with GCC builtin atomics

2023-03-22 Thread Tyler Retzlaff
On Wed, Mar 22, 2023 at 05:38:12PM +, Honnappa Nagarahalli wrote: > > > > -Original Message- > > From: Morten Brørup > > Sent: Wednesday, March 22, 2023 12:08 PM > > To: Honnappa Nagarahalli ; Tyler Retzlaff > > > > Cc: Stephen Hemminger ; dev@dpdk.org; > > Ruifeng Wang ; tho...@mon

RE: [PATCH 0/7] replace rte atomics with GCC builtin atomics

2023-03-22 Thread Honnappa Nagarahalli
> -Original Message- > From: Morten Brørup > Sent: Wednesday, March 22, 2023 12:08 PM > To: Honnappa Nagarahalli ; Tyler Retzlaff > > Cc: Stephen Hemminger ; dev@dpdk.org; > Ruifeng Wang ; tho...@monjalon.net; nd > ; nd > Subject: RE: [PATCH 0/7] replace rte atomics with GCC builtin a

[PATCH] acl: fix autotest failures on ppc64le with gcc 11

2023-03-22 Thread David Christensen
Original acl implementation of Altivec optimized code included an explicit -O2 optimization level for a particular inlined function. When DPDK is built with the default -O3 optimization level on gcc 11.x or later, the resulting code may generate a segmentation fault as observed in acl_autotest. Si

RE: [PATCH 0/7] replace rte atomics with GCC builtin atomics

2023-03-22 Thread Morten Brørup
> From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Wednesday, 22 March 2023 17.40 > > > From: Morten Brørup > > Sent: Wednesday, March 22, 2023 11:14 AM > > > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > Sent: Wednesday, 22 March 2023 16.30 > > > >

[RFC 2/2] doc: add clang-format documentation

2023-03-22 Thread Stephen Hemminger
Modify existing Linux kernel documentation of clang-format to match usage in DPDK. Still waiting for right to reuse acknowledgment for original Linux kernel author of this documentation. If not ok, then can just write a new version. Probably need some wording about applicability to base driver c

[RFC 1/2] Add clang format file

2023-03-22 Thread Stephen Hemminger
Based off of Linux kernel style with some local modifications and DPDK foreach macros. A couple of open questions to be resolved befor merging. Is GPL license ok for config file (inherited from Linux here)? Do we want to have per-driver files for some drivers (like MLX5)? Signed-off-by: Stephen H

[RFC 0/2] add clang-format infrastructure

2023-03-22 Thread Stephen Hemminger
This is first draft of how to use clang format when doing DPDK drivers and libraries. Stephen Hemminger (2): Add clang format file doc: add clang-format documentation .clang-format| 181 ++ doc/guides/contributing/clang-format.rst | 184 +++

[PATCH v2] net/mlx5: fix build with GCC 12 and ASan

2023-03-22 Thread David Marchand
Building with gcc 12 and ASan raises this warning: ../drivers/net/mlx5/mlx5_txpp.c: In function ‘mlx5_txpp_xstats_get_names’: ../drivers/net/mlx5/mlx5_txpp.c:1066:25: error: ‘strncpy’ specified bound 64 equals destination size [-Werror=stringop-truncation] 1066 | s

[PATCH] vhost: avoid sleeping under mutex

2023-03-22 Thread David Marchand
Covscan reported: 2. dpdk-21.11/lib/vhost/socket.c:852: lock_acquire: Calling function "pthread_mutex_lock" acquires lock "vhost_user.mutex". 23. dpdk-21.11/lib/vhost/socket.c:955: sleep: Call to "vhost_user_reconnect_init" might sleep while holding lock "vhost_user.mutex"

Re: [PATCH v6] net/i40e: rework maximum frame size configuration

2023-03-22 Thread Kevin Traynor
On 27/02/2023 00:35, Zhang, Qi Z wrote: Hi Simei/Qi/Yu -Original Message- From: Su, Simei Sent: Monday, February 20, 2023 4:00 PM To: Xing, Beilei ; Zhang, Yuying ; Zhang, Qi Z ; david.march...@redhat.com Cc: dev@dpdk.org; Yang, Qiming ; Su, Simei ; sta...@dpdk.org Subject: [PATCH

[Bug 1197] Segmentation fault running acl_autotest when built with gcc 11 and -O3 on ppc64le

2023-03-22 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1197 Bug ID: 1197 Summary: Segmentation fault running acl_autotest when built with gcc 11 and -O3 on ppc64le Product: DPDK Version: 23.03 Hardware: POWER OS: All

RE: [PATCH 0/7] replace rte atomics with GCC builtin atomics

2023-03-22 Thread Honnappa Nagarahalli
> -Original Message- > From: Morten Brørup > Sent: Wednesday, March 22, 2023 11:14 AM > To: Tyler Retzlaff > Cc: Stephen Hemminger ; dev@dpdk.org; > Honnappa Nagarahalli ; Ruifeng Wang > ; tho...@monjalon.net > Subject: RE: [PATCH 0/7] replace rte atomics with GCC builtin atomics > >

RE: [PATCH 0/7] replace rte atomics with GCC builtin atomics

2023-03-22 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 22 March 2023 16.30 > > On Wed, Mar 22, 2023 at 03:58:07PM +0100, Morten Brørup wrote: > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > Sent: Wednesday, 22 March 2023 15.22 > > > > > > On Wed, Mar

Re: [PATCH 0/7] replace rte atomics with GCC builtin atomics

2023-03-22 Thread Tyler Retzlaff
On Wed, Mar 22, 2023 at 03:58:07PM +0100, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Wednesday, 22 March 2023 15.22 > > > > On Wed, Mar 22, 2023 at 12:28:44PM +0100, Morten Brørup wrote: > > > > From: Tyler Retzlaff [mailto:roret...@linux.microsof

[PATCH] doc: update mlx5 limitations on ESP header match

2023-03-22 Thread Viacheslav Ovsiienko
The match on ESP header is supported over PF only. Signed-off-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 7960a42e9c..1698831c5f 100644 --- a/doc/guides/nics/mlx5.rst +++ b/d

Re: [PATCH v2] common/mlx5: fix the sysfs port name translation

2023-03-22 Thread Stephen Hemminger
On Wed, 22 Mar 2023 13:34:12 +0200 Bing Zhao wrote: > + tail_nl = strchr(port_name, '\r'); > + if (tail_nl) > + *tail_nl = '\0'; This is a file provided by Linux kernel, there is no way it could have a CR character.

Re: [PATCH v2] common/mlx5: fix the sysfs port name translation

2023-03-22 Thread Stephen Hemminger
On Wed, 22 Mar 2023 13:34:12 +0200 Bing Zhao wrote: > + > + port_name = (char *)malloc(IF_NAMESIZE); > + if (port_name == NULL) { > + fclose(file); > + rte_errno = ENOMEM; > + return -rte_errno; > + }

RE: [PATCH 0/7] replace rte atomics with GCC builtin atomics

2023-03-22 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 22 March 2023 15.22 > > On Wed, Mar 22, 2023 at 12:28:44PM +0100, Morten Brørup wrote: > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > Sent: Friday, 17 March 2023 22.49 > > > > > > On Fri, Mar 17

[PATCH v4] net/mlx5/hws: add check for modify-header actions

2023-03-22 Thread Erez Shitrit
Allow only actions that are currently supported. A check for each action in the modify-header list was added to verify that is a know action, otherwise the modify-header is failed. Signed-off-by: Erez Shitrit Reviewed-by: Alex Vesker Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h

[PATCH v4] net/mlx5/hws: fix saving of jumbo tag for deletion

2023-03-22 Thread Erez Shitrit
In cases with more than one STE we didn't update the whole tag of the match jumbo STE, Instead of 11B we kept only 8B like in regular STE. The ste_attr that keeps that indication was not updated at the last iteration. Now we indicate it is a jumbo frame before saving the tag for future deletion o

RE: [PATCH v3 1/3] ethdev: enable direct rearm with separate API

2023-03-22 Thread Honnappa Nagarahalli
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, March 7, 2023 2:41 PM > To: Honnappa Nagarahalli ; Morten Brørup > ; Feifei Wang ; > tho...@monjalon.net; Andrew Rybchenko > ; techbo...@dpdk.org > Cc: dev@dpdk.org; konstantin.v.anan...@yandex.ru; nd ; > Ruifeng Wang > Subject:

[PATCH v4] net/mlx5/hws: fix shared context to use local defaults

2023-03-22 Thread Erez Shitrit
Every Flow-table has a default miss behavior, meaning what action to do in case of miss in that Flow-table. When we are using shared Flow-table we should not use the shared default instead we should use the default of the local Flow-table that pointed by the shared Flow-table. There are two case

[PATCH v4] net/mlx5/hws: fix bug in pattern creation

2023-03-22 Thread Erez Shitrit
When creating a new pattern the data area should be clean, otherwise when the data will come from the arg object it will do OR operation on the data part in the pattern and use the dirty area as is. Now we clean the data area on each pattern creation. Fixes: f8c8a6d8440d ("net/mlx5/hws: add act

Re: [PATCH 0/7] replace rte atomics with GCC builtin atomics

2023-03-22 Thread Tyler Retzlaff
On Wed, Mar 22, 2023 at 12:28:44PM +0100, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Friday, 17 March 2023 22.49 > > > > On Fri, Mar 17, 2023 at 02:42:26PM -0700, Stephen Hemminger wrote: > > > On Fri, 17 Mar 2023 13:19:41 -0700 > > > Tyler Retzla

RE: MLX5 : Having RTE_FLOW_ACTION_TYPE_PORT_ID flow entry and RTE_FLOW_ACTION_TYPE_QUEUE flow entry in same flow group

2023-03-22 Thread Krishna, Parameswaran
Hi Raslan Darawsheh, Thanks for the details. It is very useful. Now I understand that the behavior observed is expected. Best regards, Parameswaran Krishnamurthy Internal Use - Confidential From: Raslan Darawsheh Sent: Monday, March 20, 2023 9:32 PM To: Krishna, Parameswaran; dev@dpdk.org Cc

RE: [PATCH v3 0/3] Direct re-arming of buffers on receive side

2023-03-22 Thread Morten Brørup
> From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Wednesday, 22 March 2023 14.42 > > > From: Morten Brørup > > Sent: Wednesday, March 22, 2023 7:57 AM > > > > > From: Feifei Wang [mailto:feifei.wa...@arm.com] > > > Sent: Wednesday, 4 January 2023 08.31 > > > > > > Current

Re: [PATCH 0/5] fix segment fault when parse args

2023-03-22 Thread Thomas Monjalon
22/03/2023 09:53, Ferruh Yigit: > On 3/22/2023 1:15 AM, fengchengwen wrote: > > On 2023/3/21 21:50, Ferruh Yigit wrote: > >> On 3/17/2023 2:43 AM, fengchengwen wrote: > >>> On 2023/3/17 2:18, Ferruh Yigit wrote: > On 3/14/2023 12:48 PM, Chengwen Feng wrote: > > The rte_kvargs_process() was

RE: [PATCH v3 0/3] Direct re-arming of buffers on receive side

2023-03-22 Thread Honnappa Nagarahalli
> -Original Message- > From: Morten Brørup > Sent: Wednesday, March 22, 2023 7:57 AM > To: Feifei Wang > Cc: dev@dpdk.org; konstantin.v.anan...@yandex.ru; nd ; > konstantin.anan...@huawei.com; Yuying Zhang ; > Beilei Xing ; Ruifeng Wang ; > Honnappa Nagarahalli > Subject: RE: [PATCH v

Re: [PATCH 29/33] doc: update thunderx guide

2023-03-22 Thread Jerin Jacob
On Wed, Mar 22, 2023 at 5:33 AM Ferruh Yigit wrote: > > - Move "Supported ThunderX SoCs" section up > - Rename "Module params" section "Runtime Configuration" > > Signed-off-by: Ferruh Yigit Acked-by: Jerin Jacob > --- > doc/guides/nics/thunderx.rst | 16 > 1 file changed, 8

RE: [PATCH v3 0/3] Direct re-arming of buffers on receive side

2023-03-22 Thread Morten Brørup
> From: Feifei Wang [mailto:feifei.wa...@arm.com] > Sent: Wednesday, 4 January 2023 08.31 > > Currently, the transmit side frees the buffers into the lcore cache and > the receive side allocates buffers from the lcore cache. The transmit > side typically frees 32 buffers resulting in 32*8=256B of

RE: [PATCH 28/33] doc: update softnic guide

2023-03-22 Thread Dumitrescu, Cristian
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, March 22, 2023 12:00 AM > To: Mcnamara, John ; Dumitrescu, Cristian > > Cc: Thomas Monjalon ; Andrew Rybchenko > ; dev@dpdk.org > Subject: [PATCH 28/33] doc: update softnic guide > > - Rename "Soft NIC PMD arguments" section

RE: [PATCH v1 0/2] fix sample ID backward compatibility

2023-03-22 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Rongwei Liu > Sent: Wednesday, March 22, 2023 11:38 AM > To: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) > Subject: [PATCH v1 0/2] fix sample ID backward compatibility > > Rollback flex parser sampl

RE: [PATCH] net/mlx5/hws: fix shared context to use local defaults

2023-03-22 Thread Raslan Darawsheh
Hi Erez, > -Original Message- > From: Erez Shitrit > Sent: Wednesday, March 22, 2023 12:16 PM > To: dev@dpdk.org > Cc: Alex Vesker ; sta...@dpdk.org; Matan Azrad > ; Slava Ovsiienko > Subject: [PATCH] net/mlx5/hws: fix shared context to use local defaults > > Can you describe the probl

[Bug 1196] [pvp] Failed to start a vm with two vhost-user interfaces based on the host dpdk-testpmd

2023-03-22 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1196 Bug ID: 1196 Summary: [pvp] Failed to start a vm with two vhost-user interfaces based on the host dpdk-testpmd Product: DPDK Version: 23.03 Hardware: x86 OS: Linux

RE: [RFC v2 2/2] eal: add high-performance timer facility

2023-03-22 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Wednesday, 15 March 2023 18.04 > +++ b/lib/htimer/rte_htimer.h > @@ -0,0 +1,68 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2023 Ericsson AB > + */ > + > +#ifndef _RTE_HTIMER_H_ > +#define _RTE_HTIMER_H_ >

Re: [PATCH v1] raw/ifpga: remove virtual device unplug operation

2023-03-22 Thread Thomas Monjalon
22/03/2023 02:26, Huang, Wei: > From: Thomas Monjalon > > 21/03/2023 09:41, Huang, Wei: > > > From: Thomas Monjalon > > > > 21/03/2023 01:11, Huang, Wei: > > > > > From: Thomas Monjalon > > > > > > 16/03/2023 21:44, Wei Huang: > > > > > > > VDEV bus has implemented cleanup() function to perform

RE: [EXT] [PATCH 20/33] doc: update mvneta guide

2023-03-22 Thread Liron Himi
Acked-by: Liron Himi -Original Message- From: Ferruh Yigit Sent: Wednesday, 22 March 2023 01:59 To: John McNamara ; Zyta Szpak ; Liron Himi Cc: Thomas Monjalon ; Andrew Rybchenko ; dev@dpdk.org Subject: [EXT] [PATCH 20/33] doc: update mvneta guide External Email ---

[PATCH v2] common/mlx5: fix the sysfs port name translation

2023-03-22 Thread Bing Zhao
With some OFED or upstream kernel of mlx5, the port name fetched from "/sys/class/net/[DEV]/phys_port_name" may have a tailing "\n" as the EOL. The sscanf() will return the scanned items number with this EOL. In such case, the "equal to" condition is considered as false and the function mlx5_trans

RE: [PATCH 0/7] replace rte atomics with GCC builtin atomics

2023-03-22 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Friday, 17 March 2023 22.49 > > On Fri, Mar 17, 2023 at 02:42:26PM -0700, Stephen Hemminger wrote: > > On Fri, 17 Mar 2023 13:19:41 -0700 > > Tyler Retzlaff wrote: > > > > > Replace the use of rte_atomic.h types and functions, i

[PATCH 1/2] net/virtio: propagate return value of called function

2023-03-22 Thread Boleslav Stankevich
rte_intr_vec_list_alloc() may fail because of different reasons which are indicated by different negative errno values. Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle") Cc: sta...@dpdk.org Signed-off-by: Boleslav Stankevich Signed-off-by: Andrew Rybchenko --- drivers/n

[PATCH 2/2] net/virtio: fix device init to return negative errno

2023-03-22 Thread Boleslav Stankevich
virtio_init_device() and called helper functions sometimes return -1 when return code should be negative errno. Fix all such cases to return correct negative errno instead. Fixes: 26b683b4f7d0 ("net/virtio: setup Rx queue interrupts") Fixes: 0c9d66207054 ("net/virtio: support RSS") Fixes: 6ba1f63b

Re: [EXT] [PATCH 01/33] doc: update atlantic guide

2023-03-22 Thread Igor Russkikh
> - Move "Supported Chipsets and NICs" section to top > - Fix section indentation > - Remove empty sections > > Signed-off-by: Ferruh Yigit Thanks for taking care, Ferruh! Reviewed-by: Igor Russkikh

[PATCH] net/mlx5/hws: add check for modify-header actions

2023-03-22 Thread Erez Shitrit
Allow only actions that are currently supported. Signed-off-by: Erez Shitrit Reviewed-by: Alex Vesker Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h| 1 + drivers/net/mlx5/hws/mlx5dr_action.c | 6 ++ drivers/net/mlx5/hws/mlx5dr_pat_arg.c | 16 driver

[PATCH] net/mlx5/hws: fix bug in pattern creation

2023-03-22 Thread Erez Shitrit
When creating a new pattern the data area should be clean, otherwise when the data will come from the arg object it will do OR operation on the data part in the pattern. Fixes: f8c8a6d8440d ("net/mlx5/hws: add action object") Cc: sta...@dpdk.org Signed-off-by: Erez Shitrit Reviewed-by: Alex Ve

[PATCH] net/mlx5/hws: fix saving of jumbo tag for deletion

2023-03-22 Thread Erez Shitrit
In cases with more than one STE we didn't update the whole tag of the match jumbo STE, the ste_attr that keeps that indication was not updated at the last iteration. Now we indicate it is a jumbo frame before saving the tag for coming deletion of it. Fixes: 405242c52dd5 ("net/mlx5/hws: add rule

[PATCH] net/mlx5/hws: fix shared context to use local defaults

2023-03-22 Thread Erez Shitrit
Fix default miss behavior for shared resources, the problem could happen in two cases: When the table created, the default miss should go to the alias ft that will direct it back to local context. When the rule is without specific hit address and we are in a shared RTC from here it should be red

RE: [PATCH v1 1/2] common/mlx5: fix sample ID backward compatibility

2023-03-22 Thread Slava Ovsiienko
> -Original Message- > From: Rongwei Liu > Sent: среда, 22 марта 2023 г. 11:38 > To: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) > Cc: Michael Baum ; Rongwei Liu > > Subject: [PATCH v1 1/2] common/mlx5: fix sample ID backward compat

RE: [PATCH v1 2/2] net/mlx5: adopt new sample ID

2023-03-22 Thread Slava Ovsiienko
> -Original Message- > From: Rongwei Liu > Sent: среда, 22 марта 2023 г. 11:38 > To: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) > Subject: [PATCH v1 2/2] net/mlx5: adopt new sample ID > > Extended sample ID is the behavior of the c

[PATCH v1 2/2] net/mlx5: adopt new sample ID

2023-03-22 Thread Rongwei Liu
Extended sample ID is the behavior of the current firmware and this change was reverted. In Apr GA, the sample ID will be the same as 22.11 DPDK (0-7). Now, the sample ID returned by mlx5_devx_cmd_query_parse_samples() is still 0-7 and can be used directly by legacy SWS logic. For HWS, the applica

[PATCH v1 1/2] common/mlx5: fix sample ID backward compatibility

2023-03-22 Thread Rongwei Liu
From: Michael Baum The sample ID of parse graph should be treated as a single value. Add support for new query operation "QUERY_MATCH_SAMPLE_INFO". This operation provides sample information for parse graph sample. DevX commands are only available when dv_flow_en is not zero. Fixes: f1324a171aac

[PATCH v1 0/2] fix sample ID backward compatibility

2023-03-22 Thread Rongwei Liu
Rollback flex parser sample ID format changes and keep it compatible with previous firmware. Michael Baum (1): common/mlx5: fix sample ID backward compatibility Rongwei Liu (1): net/mlx5: adopt new sample ID drivers/common/mlx5/mlx5_devx_cmds.c | 89 +++- drivers/com

[Bug 1180] TestPMD shell get stuck

2023-03-22 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1180 Pier Damouny (pdamo...@nvidia.com) changed: What|Removed |Added Resolution|--- |FIXED Status|UNC

Re: [PATCH 07/33] doc: update enetfec guide

2023-03-22 Thread Sachin Saxena (OSS)
On 3/22/2023 5:29 AM, Ferruh Yigit wrote: - Move "Supported ENETFEC SoCs" section up Signed-off-by: Ferruh Yigit --- doc/guides/nics/enetfec.rst | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/guides/nics/enetfec.rst b/doc/guides/nics/enetfec.rst index 38

Re: [PATCH 06/33] doc: update enetc guide

2023-03-22 Thread Sachin Saxena (OSS)
On 3/22/2023 5:29 AM, Ferruh Yigit wrote: - Reduce section indentation, 'ENETC' was single top level section - Move "Supported ENETC SoCs" section up Signed-off-by: Ferruh Yigit --- doc/guides/nics/enetc.rst | 25 +++-- 1 file changed, 11 insertions(+), 14 deletions(-) d

Re: [PATCH 04/33] doc: update dpaa guide

2023-03-22 Thread Sachin Saxena (OSS)
On 3/22/2023 5:29 AM, Ferruh Yigit wrote: - Renamed "Pre-Installation Configuration" section to "Configuration" Signed-off-by: Ferruh Yigit --- doc/guides/nics/dpaa.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/doc/guides/nics/dpaa.rst b/doc/guides/nics/dpaa.rs

Re: [PATCH 0/5] fix segment fault when parse args

2023-03-22 Thread Ferruh Yigit
On 3/22/2023 1:15 AM, fengchengwen wrote: > On 2023/3/21 21:50, Ferruh Yigit wrote: >> On 3/17/2023 2:43 AM, fengchengwen wrote: >>> On 2023/3/17 2:18, Ferruh Yigit wrote: On 3/14/2023 12:48 PM, Chengwen Feng wrote: > The rte_kvargs_process() was used to parse KV pairs, it also supports >>

Re: [PATCH 00/33] Update net driver documentation

2023-03-22 Thread Ferruh Yigit
On 3/22/2023 12:48 AM, fengchengwen wrote: > On 2023/3/22 7:59, Ferruh Yigit wrote: >> Some PMDs has "Pre-Installation Configuration" section in their >> documentation, >> although section is not clear I assume that is historical from times compile >> time parameters and 'make' build system used,

[PATCH v3] net/iavf: fix iavf query stats in intr thread

2023-03-22 Thread Kaiwen Deng
When iavf send query-stats command in eal-intr-thread through virtual channel, there will be no response received from iavf_dev_virtchnl_handler for this command during block and wait. Because iavf_dev_virtchnl_handler is also registered in eal-intr-thread. When vf device is bonded as BONDING_MODE

Re: [PATCH 09/33] doc: update hns3 guide

2023-03-22 Thread Dongdong Liu
Hi Ferruh Many thanks for your work. On 2023/3/22 7:59, Ferruh Yigit wrote: - Move "Link status event Pre-conditions" subsection under "Prerequisites" section - Rename "Pre-Installation Configuration" section to "Configuration" - Rename "Config File Options" section to "Compilation Options" -