Re: [PATCH 0/2] cleanup use of rte_strlcpy

2023-06-02 Thread Tyler Retzlaff
On Thu, Jun 01, 2023 at 11:18:52AM +0100, Bruce Richardson wrote: > On Wed, May 31, 2023 at 03:05:31PM -0700, Stephen Hemminger wrote: > > In DPDK API's rte_strlcpy() is not intended to be used directly. > > It was introduced as a replacement for when operating system > > libraries were missing str

Re: [PATCH] net/gve: fix bug in verify driver compatibility

2023-06-02 Thread Rushil Gupta
Thanks for the clarification and for squashing the bug into the main commit. I just tested the net-next branch and it seems to log the right message on the device. On Fri, Jun 2, 2023 at 7:49 AM Ferruh Yigit wrote: > > On 6/1/2023 5:32 PM, Rushil Gupta wrote: > > Thanks for the quick response! >

Re: [PATCH 4/5] app/proc-info: show RSS types with strings

2023-06-02 Thread Ferruh Yigit
On 3/15/2023 11:00 AM, Dongdong Liu wrote: > From: Jie Hai > > show RSS types details and adjust RSS info display format as following: > > - RSS info > -- hf: > ipv4 ipv4-frag ipv4-other ipv6 ipv6-frag ipv6-other > -- key len: 40 > -- key (hex): > 6d

Re: [PATCH 3/5] app/proc-info: fix never show RSS info

2023-06-02 Thread Ferruh Yigit
On 3/15/2023 11:00 AM, Dongdong Liu wrote: > From: Jie Hai > > Command show-port shows rss info only if rss_conf.rss_key > is not null but it will never be true. This patch allocates > memory for rss_conf.rss_key and makes it possible to show > rss info. > Why 'rss_conf.rss_key == NULL' case i

Re: [PATCH 1/5] ethdev: support setting and querying rss algorithm

2023-06-02 Thread Ferruh Yigit
On 3/16/2023 1:16 PM, Dongdong Liu wrote: > Hi Thomas > On 2023/3/15 21:43, Thomas Monjalon wrote: >> 15/03/2023 12:00, Dongdong Liu: >>> From: Jie Hai >>> --- a/doc/guides/rel_notes/release_23_03.rst >>> +++ b/doc/guides/rel_notes/release_23_03.rst >>> -* No ABI change that would break compatibil

Re: [PATCH V2 2/2] app/testpmd: assign custom ID to flow rules

2023-06-02 Thread Ferruh Yigit
On 3/16/2023 2:19 PM, Gregory Etelson wrote: > From: Eli Britstein > > Upon creation of a flow, testpmd assigns it a flow ID. Later, the > flow ID is used for flow operations (query, destroy, dump). > > The testpmd application allows to manage flow rules with its IDs. > The flow ID is known only

Re: [PATCH V2 1/2] app/testpmd: change flow rule type

2023-06-02 Thread Ferruh Yigit
On 3/16/2023 2:19 PM, Gregory Etelson wrote: > From: Eli Britstein > > Change flow rule type to be uint64_t (instead of currently uint32_t) to > be able to accommodate larger IDs, as a pre-step towards allowing user-id > to flows. > > Signed-off-by: Eli Britstein > Acked-by: Ferruh Yigit

Re: [PATCH 00/25] replace snprintf with strlcpy

2023-06-02 Thread Tyler Retzlaff
On Thu, Jun 01, 2023 at 08:00:41AM -0700, Stephen Hemminger wrote: > This patch series was generated by using the existing > Coccinelle script to find where snprintf() is used but > strlcpy() could be used instead. i guess the motivation here is strlcpy is safer to use than the portable snprintf?

Re: [RFC v3 3/3] examples/ptpclient: add frequency adjustment support

2023-06-02 Thread Ferruh Yigit
On 5/22/2023 2:23 PM, Simei Su wrote: > This patch applys PI servo algorithm to leverage frequency adjustment > API to improve PTP timesync accuracy. > > The command for starting ptpclient with PI algorithm is: > ./build/examples/dpdk-ptpclient -a :81:00.0 -c 1 -n 3 -- -T 0 -p 0x1 > --controll

Re: [RFC v3 2/3] examples/ptpclient: refine application

2023-06-02 Thread Ferruh Yigit
On 5/22/2023 2:23 PM, Simei Su wrote: > This patch reworks code to split delay request message parsing > from follow up message parsing which doesn't break original logic. > > Signed-off-by: Simei Su > Signed-off-by: Wenjun Wu > Refactoring looks good to me.

[PATCH v4 6/6] net/ring: replace rte atomics with GCC builtin atomics

2023-06-02 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson --- drivers/net/ring/rte_eth_ring.c | 26 -- 1 file changed, 16 insertions(+), 10

[PATCH v4 4/6] net/ixgbe: replace rte atomics with GCC builtin atomics

2023-06-02 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- drivers/net/ixgbe/ixgbe_bypass.c | 1 - drivers/net/ixgbe/ixgbe_ethdev.c | 18 -- drivers/net/ixgbe/ixgbe_ethdev.

[PATCH v4 5/6] net/null: replace rte atomics with GCC builtin atomics

2023-06-02 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- drivers/net/null/rte_eth_null.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a

[PATCH v4 2/6] dma/idxd: replace rte atomics with GCC builtin atomics

2023-06-02 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Kevin Laatz --- drivers/dma/idxd/idxd_internal.h | 3 +-- drivers/dma/idxd/idxd_pci.c | 1

[PATCH v4 3/6] net/ice: replace rte atomics with GCC builtin atomics

2023-06-02 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- drivers/net/ice/ice_dcf.c| 1 - drivers/net/ice/ice_dcf_ethdev.c | 1 - drivers/net/ice/ice_ethdev.c | 12 --

[PATCH v4 0/6] replace rte atomics with GCC builtin atomics

2023-06-02 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. This series covers the libraries and drivers that are built on Windows. The code has be converted to use the __atomic builtins but there are additional during conversion I notice that there

[PATCH v4 1/6] stack: replace rte atomics with GCC builtin atomics

2023-06-02 Thread Tyler Retzlaff
Replace the use of rte_atomic.h types and functions, instead use GCC supplied C++11 memory model builtins. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- lib/stack/rte_stack_lf_generic.h | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/lib/stack/rt

Re: [RFC v3 0/3] add frequency adjustment support for PTP timesync

2023-06-02 Thread Ferruh Yigit
On 5/22/2023 2:23 PM, Simei Su wrote: > This patchset cover below parts: > (1)Introduce a new timesync API called "rte_eth_timesync_adjust_freq" that >enables frequency adjustment during PTP timesync. This new API aligns with >the kernel PTP which already supports frequency adjustment. It b

[PATCH v4] app/testpmd: expand noisy neighbour forward mode support

2023-06-02 Thread Mike Pattrick
Previously the noisy neighbour vnf simulation would only operate in io mode, forwarding packets as is. However, this limited the usefulness of noisy neighbour simulation. This feature has now been expanded to supporting mac, macswap, and 5tswap modes. To facilitate adding this support, some new he

Re: [PATCH v2] app/testpmd: set srv6 header without any TLV

2023-06-02 Thread Ferruh Yigit
On 5/28/2023 3:39 PM, Ori Kam wrote: >>> >>> When the type field of the IPv6 routing extension is 4, it means segment >>> routing header. >>> >>> In this case, set the last_entry to be segment_left minus 1 if the user >> doesn't >>> specify the header length explicitly. >>> >>> Signed-off-by: Rong

Re: [PATCH] net/bonding: rename bonded to bonding

2023-06-02 Thread Ferruh Yigit
On 5/24/2023 8:12 AM, Chaoyong He wrote: > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index 85439e3a41..e717079dd0 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -2036,12 +2036,13 @@ struct rte_eth_dev_owner { > /** Device supports link state inte

[PATCH v5 2/2] test: add reassembly perf test

2023-06-02 Thread pbhagavatula
From: Pavan Nikhilesh Add reassembly perf autotest for both ipv4 and ipv6 reassembly. Each test is performed with variable number of fragments per flow, either ordered or unordered fragments and interleaved flows. Signed-off-by: Pavan Nikhilesh Reviewed-by: Amit Prakash Shukla Tested-by: Amit

[PATCH v5 1/2] ip_frag: optimize key compare and hash generation

2023-06-02 Thread pbhagavatula
From: Pavan Nikhilesh Use optimized rte_hash_k32_cmp_eq routine for key comparison for x86 and ARM64. Use CRC instructions for hash generation on ARM64. Signed-off-by: Pavan Nikhilesh Reviewed-by: Ruifeng Wang --- On Neoverse-N2, performance improved by 10% when measured with examples/ip_reass

[PATCH v2] node: add IPv4 reassembly node

2023-06-02 Thread pbhagavatula
From: Pavan Nikhilesh Add IPv4 reassembly node. Signed-off-by: Pavan Nikhilesh --- Depends-on: series-28278 v2 Changes: - Fix compilation. doc/guides/prog_guide/graph_lib.rst | 8 ++ lib/node/ethdev_rx.c| 1 + lib/node/ethdev_rx_priv.h | 1 + lib/node/ip4_re

Re: [PATCH 0/2] add support of showing firmware version

2023-06-02 Thread Ferruh Yigit
On 5/22/2023 12:40 PM, Chaoyong He wrote: > This patch series add the support of showing firmware version, > also modify the data structure and logic of reading and store > firmware version, to make it sync with the kernel driver. > > Chaoyong He (2): > net/nfp: align reading of version info wit

Re: [PATCH 0/5] Add support of report packet type

2023-06-02 Thread Ferruh Yigit
On 5/22/2023 9:04 AM, Chaoyong He wrote: > This patch series add the support of report packet type function for > NFP PMD: > - Add a new contributor entry > - Rename one data field of RX descriptor > - Refactor the logic of NFP reconfig > - Add the logic of report packet type > > Qin Ke (5): > m

[PATCH v3 3/3] node/ethdev_rx: remove hardcoded node next details

2023-06-02 Thread Vamsi Attunuru
For ethdev_rx node, node_next details can be populated during node cloning time and same gets assigned to node context structure during node initialization. Patch removes overriding node_next details in node init(). Signed-off-by: Vamsi Attunuru --- lib/node/ethdev_ctrl.c | 1 + lib/node/ethdev

[PATCH v3 2/3] node/kernel_rx: support receiving packets from kernel

2023-06-02 Thread Vamsi Attunuru
Adds a node to receive packets from kernel over a raw socket. Signed-off-by: Vamsi Attunuru --- doc/guides/prog_guide/graph_lib.rst | 8 + lib/node/kernel_rx.c| 276 lib/node/kernel_rx_priv.h | 48 + lib/node/meson.build

[PATCH v3 1/3] node/kernel_tx: support packet transmit to kernel

2023-06-02 Thread Vamsi Attunuru
Patch adds a node to transmit the packets to kernel over a raw socket. Signed-off-by: Vamsi Attunuru --- doc/guides/prog_guide/graph_lib.rst | 9 ++ lib/node/kernel_tx.c| 122 lib/node/kernel_tx_priv.h | 16 lib/node/meson.build

[PATCH v3 0/3] node: Introduce kernel_rx & kernel_tx nodes

2023-06-02 Thread Vamsi Attunuru
This patch set introduces two new nodes to transmit & receive packets from kernel. This nodes can be used for any exception path handling or to forward any control plane traffic to kernel or receive from kernel stack. V3: * Address review comments * Drop test-graph application from the patch set

Re: [PATCH 0/6] windows: remove most pthread lifetime shim functions

2023-06-02 Thread Tyler Retzlaff
On Thu, Jun 01, 2023 at 12:23:39PM +, Zhang, Qi Z wrote: > > > > -Original Message- > > From: David Marchand > > Sent: Thursday, June 1, 2023 4:50 PM > > To: Richardson, Bruce ; Tyler Retzlaff > > > > Cc: dev@dpdk.org; tho...@monjalon.net; Zhang, Qi Z > > > > Subject: Re: [PATCH 0/

[PATCH] doc/guides: fix typo for cnxk platform

2023-06-02 Thread Thierry Herbelot
The Linux kernel option has an added underscore. Fixes: 14ad4f01845331a ('doc: add Marvell OCTEON TX2 platform guide') Signed-off-by: Thierry Herbelot --- doc/guides/platform/cnxk.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/platform/cnxk.rst b/doc/guides/pl

Re: [PATCH] net/bonding: rename bonded to bonding

2023-06-02 Thread Ferruh Yigit
On 5/24/2023 8:12 AM, Chaoyong He wrote: > From: Long Wu > > DPDK bonding PMD mixing use 'bonded' and 'bonding' currently, this > patch replaces the usage of the word 'bonded' with more appropriate > word 'bonding' in bonding PMD and ethdev library as well as in > their docs. Also the test app an

[RFC v3 2/2] dts: added paramiko to dependencies

2023-06-02 Thread jspewock
From: Jeremy Spewock added paramiko to the dependency files Signed-off-by: Jeremy Spewock --- dts/poetry.lock| 160 ++--- dts/pyproject.toml | 1 + 2 files changed, 124 insertions(+), 37 deletions(-) diff --git a/dts/poetry.lock b/dts/poetry.lock

[RFC v3 1/2] dts: add smoke tests

2023-06-02 Thread jspewock
From: Jeremy Spewock Adds a new test suite for running smoke tests that verify general configuration aspects of the system under test. If any of these tests fail, the DTS execution terminates for that build target as part of a "fail-fast" model. Signed-off-by: Jeremy Spewock --- dts/conf.yaml

[RFC v3 0/2] add DTS smoke tests

2023-06-02 Thread jspewock
From: Jeremy Spewock This update to the RFC addresses comments recieved on the previous about formatting and implementation. Things that are new to this patch series are: * New class similar to the RemoteSession that handles interactive remote sessions * A keepalive for the interactive SSH sessi

Re: [PATCH v4] net/bonding: replace master/slave to main/member

2023-06-02 Thread Ferruh Yigit
On 5/18/2023 4:39 PM, Stephen Hemminger wrote: > On Thu, 18 May 2023 16:44:58 +0800 > Chaoyong He wrote: > >> From: Long Wu >> >> This patch replaces the usage of the word 'master/slave' with more >> appropriate word 'main/member' in bonding PMD as well as in its docs >> and examples. Also the t

Re: [PATCH] net/gve: fix bug in verify driver compatibility

2023-06-02 Thread Ferruh Yigit
On 6/1/2023 5:32 PM, Rushil Gupta wrote: > Thanks for the quick response! > Just for my own knowledge, what Junfeng described is the process to > fix the bug if a bug is present in the main dpdk repo? > Correct. As main dpdk repo doesn't rewrite git history, any bug there needs to be fixed with

Re: [PATCH v1 0/2] add IPv6 extension push remove

2023-06-02 Thread Ferruh Yigit
On 5/24/2023 8:39 AM, Rongwei Liu wrote: > Add new rte_actions to push and remove the specific > type of IPv6 extension to and from original packets. > > v1: Split the PMD implementation, add a description into release notes. > > Rongwei Liu (2): > ethdev: add IPv6 extension push remove action

RE: [PATCH v1 1/1] bbdev: extend range of allocation function

2023-06-02 Thread Chautru, Nicolas
Hi Maxime, I don't think it does since no offset position change for the symbol. Also this only extends the type, so still fine if using uin16_t from application. I did not receive an email from CICD related to ABI change when pushing this (unlike the other serie for the MLD/FFT changes pushed e

Re: [PATCH v2 00/11] net/hns3: add some bugfixes for hns3

2023-06-02 Thread Ferruh Yigit
On 6/2/2023 12:41 PM, Dongdong Liu wrote: > This patchset contains some bugfixes for hns3 pmd. > > v1->v2: > - Fix the comments for [PATCH 01/11] suggested by Ferruh. > > Chengwen Feng (3): > net/hns3: fix mbuf leak when start rxq in resetting > net/hns3: fix mbuf leak when start rxq after re

Re: [PATCH] eal/linux: register mp hotplug callback after memory init

2023-06-02 Thread Burakov, Anatoly
On 5/31/2023 7:55 AM, Zhihong Wang wrote: Secondary would crash if it tries to handle mp requests before memory init, since globals such as eth_dev_shared_data_lock are not accessible to it at this moment. --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [External] Re: [PATCH] eal/linux: register mp hotplug callback after memory init

2023-06-02 Thread Burakov, Anatoly
On 6/2/2023 4:33 AM, 王志宏 wrote: Apologize that I have to go directly to function names to explain :)   - rte_eal_intr_init creates eal_intr_thread_main which starts eal_intr_handle_interrupts   - rte_mp_channel_init creates mp_handle which processes messages registered by rte_mp_action_regist

Re: [PATCH v4 2/2] app/testpmd: fix segment fault with invalid queue ID

2023-06-02 Thread Ferruh Yigit
On 6/2/2023 8:52 AM, Dengdui Huang wrote: > When input queue ID is invalid, it will lead to > Segmentation fault, like: > > dpdk-testpmd -a :01:00.0 -- -i > testpmd> show port 0 txq/rxq 99 desc 0 status > Segmentation fault > > dpdk-testpmd -a :01:00.0 -- -i > testpmd> show port 0 rxq 99

Re: [PATCH v4 1/2] ethdev: add API to check if queue is valid

2023-06-02 Thread Ferruh Yigit
On 6/2/2023 8:52 AM, Dengdui Huang wrote: > The API rte_eth_dev_is_valid_rxq/txq which > is used to check if Rx/Tx queue is valid. > If the queue has been setup, it is considered valid. > > Signed-off-by: Dengdui Huang > --- > doc/guides/rel_notes/release_23_07.rst | 6 > lib/ethdev/rte_et

[PATCH v2 11/11] net/hns3: remove log redundant line break

2023-06-02 Thread Dongdong Liu
From: Dengdui Huang This patch remove log redundant line break Fixes: d51867db65c1 ("net/hns3: add initialization") Fixes: c6332c3cf9f0 ("net/hns3: support module EEPROM dump") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.c | 1

[PATCH v2 10/11] net/hns3: fix inaccurate log

2023-06-02 Thread Dongdong Liu
From: Dengdui Huang This patch fix inaccurate log Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") Fixes: a951c1ed3ab5 ("net/hns3: support different numbers of Rx and Tx queues") Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- drivers/ne

[PATCH v2 09/11] net/hns3: make code more clean

2023-06-02 Thread Dongdong Liu
From: Dengdui Huang This patch modify the code that violates the coding standards. Signed-off-by: Dengdui Huang Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_regs.c | 3 +-- drivers/net/hns3/hns3_rxtx.c | 10 +++--- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/d

[PATCH v2 08/11] net/hns3: fix uninitialized variable

2023-06-02 Thread Dongdong Liu
From: Jie Hai This patch fixes possible use of uninitialized variable "old_tuple_fields". Fixes: e3069658da9f ("net/hns3: reimplement hash flow function") Cc: sta...@dpdk.org Signed-off-by: Jie Hai Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_flow.c | 5 +++-- 1 file changed, 3 inse

[PATCH v2 05/11] net/hns3: fix mbuf leak when start rxq in resetting

2023-06-02 Thread Dongdong Liu
From: Chengwen Feng In the reset restore-conf phase, the reset process will allocate for the Rx ring mbufs unconditionlly. And the rte_eth_dev_rx_queue_start() will also allocate for the Rx ring mbufs unconditionlly. So if the rte_eth_dev_rx_queue_start() is invoked before restore-conf phase, t

[PATCH v2 07/11] net/hns3: fix no errcode returned when failed to init queue

2023-06-02 Thread Dongdong Liu
From: Chengwen Feng If hns3_init_queues() return failed, the hns3vf_do_start() should return errcode. This patch fixes it. Fixes: 43d8adf3891c ("net/hns3: fix RSS flow rule restore") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev

[PATCH v2 06/11] net/hns3: fix mbuf leak when start rxq after resetting

2023-06-02 Thread Dongdong Liu
From: Chengwen Feng In the reset restore-conf phase, the reset process will allocate for the Rx ring mbufs unconditionlly. And the rte_eth_dev_rx_queue_start() will also allocate for the Rx ring mbufs unconditionlly. So if the rte_eth_dev_rx_queue_start() is invoked after restore-conf phase, th

[PATCH v2 04/11] net/hns3: extract a PTP header file

2023-06-02 Thread Dongdong Liu
From: Huisong Li This patch extracts a PTP header file to contain PTP registers and external API in order to make PTP code structure more clear. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/h

[PATCH v2 03/11] net/hns3: add the uninitialization process of PTP

2023-06-02 Thread Dongdong Liu
From: Huisong Li This patch adds the uninitialization process of PTP in case of having an impact on PF driver in kernel. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ethdev.c | 2 +

[PATCH v2 02/11] net/hns3: fix unenabled RTC time after reset

2023-06-02 Thread Dongdong Liu
From: Huisong Li The enabled status of RTC time will be cleared after global or IMP reset, which cause the local RTC time doesn't work. So this patch fix it. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu ---

[PATCH v2 00/11] net/hns3: add some bugfixes for hns3

2023-06-02 Thread Dongdong Liu
This patchset contains some bugfixes for hns3 pmd. v1->v2: - Fix the comments for [PATCH 01/11] suggested by Ferruh. Chengwen Feng (3): net/hns3: fix mbuf leak when start rxq in resetting net/hns3: fix mbuf leak when start rxq after resetting net/hns3: fix no errcode returned when failed to

[PATCH v2 01/11] net/hns3: fix uninitialized RTC time

2023-06-02 Thread Dongdong Liu
From: Huisong Li Driver doesn't initialize RTC time during probe phase, which lead to an inaccurate time. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Dongdong Liu --- drivers/net/hns3/hns3_ptp.c | 26 +++

Re: [PATCH] reorder: introduce API to obtain memory footprint

2023-06-02 Thread Thomas Monjalon
02/06/2023 13:30, Volodymyr Fialko: > Hi Thomas and Reshma, > > I would be interested in taking on the role of maintaining the reorder > library. If Reshma accepts, please send a patch to replace Reshma. It will require an ack from Reshma. Thank you both > From: Pattan, Reshma > > > From: Tho

RE: [PATCH] reorder: introduce API to obtain memory footprint

2023-06-02 Thread Volodymyr Fialko
Hi Thomas and Reshma, I would be interested in taking on the role of maintaining the reorder library. > -Original Message- > From: Pattan, Reshma > Sent: Friday, June 2, 2023 1:06 PM > To: Thomas Monjalon ; Volodymyr Fialko > > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Anoob Joseph

RE: [PATCH v4] crypto/qat: default to IPsec MB for computations

2023-06-02 Thread De Lara Guarch, Pablo
Hi Brian, > -Original Message- > From: Brian Dooley > Sent: Friday, May 26, 2023 11:27 AM > To: Ji, Kai > Cc: dev@dpdk.org; gak...@marvell.com; Dooley, Brian > > Subject: [PATCH v4] crypto/qat: default to IPsec MB for computations > > Pre and post computations currently use the OpenSSL

Re: [dpdk-dev] [PATCH v3] doc: remove warning with doxygen 1.9.7

2023-06-02 Thread Bruce Richardson
On Fri, Jun 02, 2023 at 04:36:59PM +0530, jer...@marvell.com wrote: > From: Jerin Jacob > > Since doxygen 1.9.7 version, HTML_TIMESTAMP configuration option > changed to TIMESTAMP [2]. Fixed the following warning[1] by > removing TIMESTAMP options all together as all new versions(since 1.8.9) > o

[dpdk-dev] [PATCH v3] doc: remove warning with doxygen 1.9.7

2023-06-02 Thread jerinj
From: Jerin Jacob Since doxygen 1.9.7 version, HTML_TIMESTAMP configuration option changed to TIMESTAMP [2]. Fixed the following warning[1] by removing TIMESTAMP options all together as all new versions(since 1.8.9) of doxygen this option is disabled by default. Another option was considered to h

RE: [PATCH] reorder: introduce API to obtain memory footprint

2023-06-02 Thread Pattan, Reshma
> -Original Message- > From: Thomas Monjalon > > Like previous patches for the reorder library from Volodymyr, the official > maintainer (Reshma) is not reviewing. > Does it mean Reshma is not interested anymore in this maintenance? Hi Thomas, I would like to drop from the maintainer

Re: [PATCH 01/11] net/hns3: fix uninitialized RTC time

2023-06-02 Thread Dongdong Liu
Hi Ferruh Many thanks for your review. On 2023/6/2 17:00, Ferruh Yigit wrote: On 5/29/2023 2:09 PM, Dongdong Liu wrote: From: Huisong Li Driver doesn't initialize RTC time during probe phase, which lead to an inaccurate time. Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") Cc: sta..

Re: [PATCH 00/11] net/hns3: add some bugfixes for hns3

2023-06-02 Thread Ferruh Yigit
On 5/29/2023 2:09 PM, Dongdong Liu wrote: > This patchset contains some bugfixes for hns3 pmd. > > Chengwen Feng (3): > net/hns3: fix mbuf leak when start rxq in resetting > net/hns3: fix mbuf leak when start rxq after resetting > net/hns3: fix no errcode returned when failed to init queue >

FW: [PATCH v7 1/4] net/bnx2x: fix warnings about rte_memcpy lengths

2023-06-02 Thread Morten Brørup
Julien, welcome aboard as the new bnx2x maintainer. Can you please review this patch? Med venlig hilsen / Kind regards, -Morten Brørup -Original Message- From: Morten Brørup [mailto:m...@smartsharesystems.com] Sent: Monday, 16 January 2023 14.07 To: dev@dpdk.org; roret...@linux.microsof

RE: DPDK Release Status Meeting 2023-06-01

2023-06-02 Thread Ruifeng Wang
From: Mcnamara, John Sent: Thursday, June 1, 2023 11:42 PM To: dev@dpdk.org Cc: tho...@monjalon.net; david.march...@redhat.com Subject: DPDK Release Status Meeting 2023-06-01 Release status meeting minutes 2023-06-01 = * main * Starting to merge patche

Re: [PATCH 1/4] common/sfc_efx/base: NIC Partitioning mode discovery using heuristic approach

2023-06-02 Thread Andrew Rybchenko
Summary must not be a statement. Also summary is too long. On 6/1/23 14:42, Denis Pryazhennikov wrote: NIC Partitioning mode in SFN devices means multiple PFs per network port. When NIC Partitioning is configured, apart from the privileged adapter(s) the other unprivileged adapter(s) will share

Re: [PATCH 3/3] net/sfc: support FEC feature

2023-06-02 Thread Andrew Rybchenko
On 6/2/23 01:23, Denis Pryazhennikov wrote: Support ethdev methods to query and set FEC information. Limitations: ignoring rte_eth_fec_get_capability() results can lead to NOFEC if the device is not strated. Signed-off-by: Denis Pryazhennikov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton

Re: [PATCH 01/11] net/hns3: fix uninitialized RTC time

2023-06-02 Thread Ferruh Yigit
On 5/29/2023 2:09 PM, Dongdong Liu wrote: > From: Huisong Li > > Driver doesn't initialize RTC time during probe phase, which > lead to an inaccurate time. > > Fixes: 38b539d96eb6 ("net/hns3: support IEEE 1588 PTP") > Cc: sta...@dpdk.org > > Signed-off-by: Huisong Li > Signed-off-by: Dongdong

Re: [PATCH 2/3] common/sfc_efx/base: add FEC related macros

2023-06-02 Thread Andrew Rybchenko
On 6/2/23 01:23, Denis Pryazhennikov wrote: Added new macros to simplify working with FEC bits Full stop missing above. Signed-off-by: Denis Pryazhennikov Reviewed-by: Andy Moreton Acked-by: Andrew Rybchenko

Re: [PATCH 1/3] net/sfc: split link update function

2023-06-02 Thread Andrew Rybchenko
On 6/2/23 01:23, Denis Pryazhennikov wrote: Separate the original link update function into two functions: state retrieval and update. This improves code clarity and maintainability. Signed-off-by: Denis Pryazhennikov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton Acked-by: Andrew Rybche

Re: [PATCH v4 3/3] net/sfc: support VLAN stripping offload

2023-06-02 Thread Andrew Rybchenko
On 6/1/23 18:30, Artemii Morozov wrote: Extract vlan tci provided by the HW in the prefix and put it to mbuf. vlan -> VLAN, tci -> TCI VLAN stripping is supported for ef100 datapath only. It should be highlighted that it is device level offload. Signed-off-by: Artemii Morozov Reviewed-b

Re: [dpdk-dev] [PATCH v1] doc: remove warning with doxygen 1.9.7

2023-06-02 Thread Jerin Jacob
On Fri, Jun 2, 2023 at 2:11 PM Bruce Richardson wrote: > > On Fri, Jun 02, 2023 at 02:00:32PM +0530, jer...@marvell.com wrote: > > From: Jerin Jacob > > > > Since doxygen 1.9.7 version, HTML_TIMESTAMP configuration option > > changed to TIMESTAMP [2]. Fixed the following warning[1] by providing >

Re: [dpdk-dev] [PATCH v1] doc: remove warning with doxygen 1.9.7

2023-06-02 Thread Bruce Richardson
On Fri, Jun 02, 2023 at 02:00:32PM +0530, jer...@marvell.com wrote: > From: Jerin Jacob > > Since doxygen 1.9.7 version, HTML_TIMESTAMP configuration option > changed to TIMESTAMP [2]. Fixed the following warning[1] by providing > the correct configuration option based on doxygen version. > > [1

Re: [dpdk-dev] [PATCH v1] doc: remove warning with doxygen 1.9.7

2023-06-02 Thread Bruce Richardson
On Wed, May 31, 2023 at 04:49:04PM +0200, Thomas Monjalon wrote: > 31/05/2023 16:07, Jerin Jacob: > > On Wed, May 31, 2023 at 7:31 PM Thomas Monjalon wrote: > > > > > > 31/05/2023 15:21, Jerin Jacob: > > > > On Wed, May 31, 2023 at 6:17 PM wrote: > > > > > > > > > > From: Jerin Jacob > > > > > >

Re: [PATCH v4 2/3] common/sfc_efx/base: add support to enable VLAN stripping

2023-06-02 Thread Andrew Rybchenko
On 6/1/23 18:30, Artemii Morozov wrote: To enable VLAN stripping, two conditions must be met: the corresponding flag must be set and the appropriate RX prefix should be requested. RX -> Rx VLAN stripping is supported for ef100 datapath only. When you read below notes carefully, you'll under

[dpdk-dev] [PATCH v1] doc: remove warning with doxygen 1.9.7

2023-06-02 Thread jerinj
From: Jerin Jacob Since doxygen 1.9.7 version, HTML_TIMESTAMP configuration option changed to TIMESTAMP [2]. Fixed the following warning[1] by providing the correct configuration option based on doxygen version. [1] Warning: Tag 'HTML_TIMESTAMP' at line 115 of file 'doc/api/doxy-api.conf' has be

[PATCH v4] net/bnx2x: support 2.5Gbps

2023-06-02 Thread Julien Aube
- add support for 2500baseX_Full in addition to 1000baseT_Full. For 2.5Gbps speed, HSGMII mode shall be enabled in serdes. - add the possibility to support SC connectors on SFP (GPON are mostly SC) - change the initialisation time from 60ms to 1800ms (for xPON-Based SFP) This has been tested wit

Re: [PATCH v1 1/1] bbdev: extend range of allocation function

2023-06-02 Thread Maxime Coquelin
On 6/2/23 04:04, Nicolas Chautru wrote: Realigning the argument to unsigned int to align with number support by underlying rte_mempool_get_bulk function. Signed-off-by: Nicolas Chautru --- lib/bbdev/rte_bbdev_op.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/l

[PATCH v3] net/bnx2x: offer maintainership for bnx2x

2023-06-02 Thread Julien Aube
This is an offer to maintain the code for bnx2x-based cards. It may not be possible on the long run due to the old design of this chipset. Note that I'm not affiliated with LSI nor Broadcom and do not have access to documentation or other NDA-based code. Signed-off-by: Julien Aube --- .mailmap

[PATCH v4 1/2] ethdev: add API to check if queue is valid

2023-06-02 Thread Dengdui Huang
The API rte_eth_dev_is_valid_rxq/txq which is used to check if Rx/Tx queue is valid. If the queue has been setup, it is considered valid. Signed-off-by: Dengdui Huang --- doc/guides/rel_notes/release_23_07.rst | 6 lib/ethdev/rte_ethdev.c| 22 +++ lib/ethdev/rte

[PATCH v4 2/2] app/testpmd: fix segment fault with invalid queue ID

2023-06-02 Thread Dengdui Huang
When input queue ID is invalid, it will lead to Segmentation fault, like: dpdk-testpmd -a :01:00.0 -- -i testpmd> show port 0 txq/rxq 99 desc 0 status Segmentation fault dpdk-testpmd -a :01:00.0 -- -i testpmd> show port 0 rxq 99 desc used count Segmentation fault This patch fixes it. Fi

[PATCH v4 0/2] add Rx/Tx queue ID check API and use it to fix a bug

2023-06-02 Thread Dengdui Huang
This series add a commom API to check queue id and use it to fix a bug. v3->v4 update API name and uptate description in the API documentation v2->v3 update API name and use the internal function eth_dev_validate_tx_queue() to check queue id v1->v2 add a commom API to check queue id Dengdui Hua

Re: [PATCH v4 1/3] common/sfc_efx/base: report VLAN stripping capability

2023-06-02 Thread Andrew Rybchenko
On 6/1/23 18:30, Artemii Morozov wrote: These changes are necessary in order to add support for stripping VLAN tags in the future. Signed-off-by: Artemii Morozov Reviewed-by: Ivan Malov Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/ef10_nic.c | 6 ++ drivers/common/sfc_efx