Re: [PATCH] net/cnxk: add atomic fc check in poll mode Tx path

2023-06-12 Thread Jerin Jacob
On Tue, Jun 6, 2023 at 11:43 AM Rahul Bhansali wrote: > > Add a support of atomic fc check in poll mode Tx path. This atomic > check is useful if multiple threads are using the same Tx queue. > This will be enabled when Tx offload RTE_ETH_TX_OFFLOAD_MT_LOCKFREE > is set. > > Signed-off-by: Rahul B

RE: [RFC] lib/ethdev: introduce table driven APIs

2023-06-12 Thread Ivan Malov
Hi, Thanks for responding. Yes, perhaps my thought about being vendor-neutral was a bit ridiculous, taking the P4 part of the problem into account, and yet, this RFC does not use suffix "p4" in API names, that is, it's not confined to just P4. If that is the case, then PMDs that have fixed pipeli

Re: [PATCH v2] net/cnxk: add support for reassembly of multi-seg pkts

2023-06-12 Thread Jerin Jacob
On Mon, Jun 5, 2023 at 5:52 PM Nithin Dabilpuram wrote: > > Add support for HW reassembly of multi-seg pkts. > Also optimize the code for normal reassembly path. > > Signed-off-by: Nithin Dabilpuram Please resend the patch to run through all CI stages. > --- > drivers/event/cnxk/cn10k_worker.h

Re: [PATCH] net/octeon_ep: rework transmit routine

2023-06-12 Thread Jerin Jacob
On Mon, Jun 5, 2023 at 2:56 PM Vamsi Attunuru wrote: > > Patch optimizes transmit path for multi-seg packets > by pre-allocating the gather list memory instead of > allocating it in fast path. > > Signed-off-by: Vamsi Attunuru Updated the git commit as follows and applied to dpdk-next-net-mrvl/f

Re: [PATCH v2] common/cnxk: fix mbox timeout due to deadlock

2023-06-12 Thread Jerin Jacob
On Mon, Jun 5, 2023 at 2:14 PM Harman Kalra wrote: > > PF receives all the VFs mbox/flr messages which it forwards to AF. > This is all handled by interrupt thread. Due to mbox locking in place > a deadlock situation may arise which may lead to mbox timeout. > Say at T1 - PF sends its own mbox to

[PATCH 2/2] net/mlx5: add support for send to kernel over HWS

2023-06-12 Thread Bar Neuman
Added hws send to kernel action and root tbl in mlx5_priv. Initialized in hws configure and used in hws actions translate. Signed-off-by: Bar Neuman --- drivers/net/mlx5/mlx5.h | 2 ++ drivers/net/mlx5/mlx5_flow_hw.c | 59 +++-- 2 files changed, 59 insertions

[PATCH 1/2] net/mlx5/hws: removing the table name from dest root table

2023-06-12 Thread Bar Neuman
From: Itamar Gozlan Jumping to root (group 0) does not behave the same as jumping to groups with level > 0. To better emphasize that it is not the same action, a rename is made to drop the name table. Signed-off-by: Itamar Gozlan --- drivers/net/mlx5/hws/mlx5dr.h| 11 --- drive

[PATCH v6] app/dma-perf: introduce dma-perf application

2023-06-12 Thread Cheng Jiang
There are many high-performance DMA devices supported in DPDK now, and these DMA devices can also be integrated into other modules of DPDK as accelerators, such as Vhost. Before integrating DMA into applications, developers need to know the performance of these DMA devices in various scenarios and

[dpdk-dev] [PATCH v3] net/cnxk: support port ID flow action item

2023-06-12 Thread psatheesh
From: Satheesh Paul Currently PORT_ID action can redirect traffic only between VFs of a PF. This patch extends PORT_ID action to redirect traffic from one PF port to another PF port also. Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- v2: * Updated release notes. v3: * Rebased and

RE: [EXT] [PATCH v5] app/dma-perf: introduce dma-perf application

2023-06-12 Thread Jiang, Cheng1
Hi, Replies are inline. > -Original Message- > From: Jiang, Cheng1 > Sent: Monday, June 12, 2023 4:27 PM > To: Amit Prakash Shukla ; > tho...@monjalon.net; Richardson, Bruce ; > m...@smartsharesystems.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > ; Ma, WenwuX ; Wang, > Yu

[dpdk-dev] [PATCH v2] net/cnxk: support port ID flow action item

2023-06-12 Thread psatheesh
From: Satheesh Paul Currently PORT_ID action can redirect traffic only between VFs of a PF. This patch extends PORT_ID action to redirect traffic from one PF port to another PF port also. Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- v2: * Updated release notes. doc/guides/rel_

RE: [RFC] lib/ethdev: introduce table driven APIs

2023-06-12 Thread Zhang, Qi Z
> -Original Message- > From: Ivan Malov > Sent: Monday, June 12, 2023 11:33 PM > To: Zhang, Qi Z > Cc: tho...@monjalon.net; or...@nvidia.com; david.march...@redhat.com; > Richardson, Bruce ; jer...@marvell.com; > ferruh.yi...@amd.com; Mcnamara, John ; > Zhang, Helin ; techbo...@dpdk.or

Re: [dpdk-dev] [PATCH v2] test/atomic: reduce the number of loops to avoid timeouts

2023-06-12 Thread Stephen Hemminger
On Tue, 28 Jul 2020 11:41:37 +0800 Phil Yang wrote: > Reduce the number of loops to 10K to avoid the meson test timeout > warning. > > For example: > $ sudo meson test -C build --suite DPDK:fast-tests / atomic_autotest -t 50 > [...] > 1/1 DPDK:fast-tests / atomic_autotest OK 187.35s

RE: [PATCH v3] net/ixgbe: add proper memory barriers for some Rx functions

2023-06-12 Thread Jiawen Wu
On Tuesday, June 13, 2023 9:43 AM, zhoumin wrote: > On Mon, June 12, 2023 at 8:44PM, Thomas Monjalon wrote: > > 12/06/2023 13:58, zhoumin: > >> On Mon, June 12, 2023 at 6:26PM, Thomas Monjalon wrote: > >>> 15/05/2023 04:10, Zhang, Qi Z: > From: Ruifeng Wang > > From: Min Zhou > >> --

[PATCH 2/2] net/nfp: fix VNI of IPv6 NVGRE encap action

2023-06-12 Thread Chaoyong He
Complete the missing logic of parse the tunnel id of IPv6 NVGRE tunnel and send it to the firmware by control message. Fixes: fff680eef7f9 ("net/nfp: support IPv6 NVGRE encap flow action") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_flow

[PATCH 0/2] fix VNI of NVGRE encap action

2023-06-12 Thread Chaoyong He
This patch series fix the problem of IPv4/6 NVGRE encap action. Chaoyong He (2): net/nfp: fix VNI of IPv4 NVGRE encap action net/nfp: fix VNI of IPv6 NVGRE encap action drivers/net/nfp/nfp_flow.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) -- 2.39.1

[PATCH 1/2] net/nfp: fix VNI of IPv4 NVGRE encap action

2023-06-12 Thread Chaoyong He
Complete the missing logic of parse the tunnel id of IPv4 NVGRE tunnel and send it to the firmware by control message. Fixes: 88cce0538073 ("net/nfp: support IPv4 NVGRE encap flow action") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_flow

[PATCH] net/nfp: fix VNI of VXLAN encap action

2023-06-12 Thread Chaoyong He
The 'vx_vni' field of VXLAN header is contain 24 bits of VNI and 8 bits of reserved. After convert into CPU endian, the reserved 8 bits should be shifted, or the VNI value will be not correct. Fixes: 861949032d0f ("net/nfp: fix VNI of VXLAN encap action") Cc: sta...@dpdk.org Signed-off-by: Chaoyo

RE: [PATCH v7] gro : ipv6 changes to support GRO for TCP/ipv6

2023-06-12 Thread Hu, Jiayu
Hi Kumara, Overall, the patch looks good to me. But you need to update the doc and there are some minor changes needed to be made. Please see replies inline. After all comments are addressed, you can add "Reviewed-by: Jiayu Hu ". Thanks, Jiayu > -Original Message- > From: Kumara Param

Re: [PATCH v3] net/ixgbe: add proper memory barriers for some Rx functions

2023-06-12 Thread zhoumin
Hi Thomas, On Mon, June 12, 2023 at 8:44PM, Thomas Monjalon wrote: 12/06/2023 13:58, zhoumin: On Mon, June 12, 2023 at 6:26PM, Thomas Monjalon wrote: 15/05/2023 04:10, Zhang, Qi Z: From: Ruifeng Wang From: Min Zhou --- v3: - Use rte_smp_rmb() as the proper memory barrier instead of rte_rm

RE: [PATCH] net/iavf: fix VLAN offload with AVX512

2023-06-12 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, June 13, 2023 2:02 AM > To: Zhang, Qi Z > Cc: Lu, Wenzhuo ; mschmidt > ; dev@dpdk.org; Richardson, Bruce > ; Konstantin Ananyev > ; Wu, Jingjing ; > Xing, Beilei ; Rong, Leyi ; > sta...@dpdk.org; Zhang, Helin ; > david.march

[PATCH] app: do not call printf in signal handlers

2023-06-12 Thread Stephen Hemminger
Using printf is not async-signal safe and worst case may lead to deadlock. Remove printf from signal handlers present in several applications. Testpmd was already fixed by commit 0fd1386c30c3 ("app/testpmd: cleanup cleanly from signal") Signed-off-by: Prateek Agarwal Signed-off-by: Stephen Hemmi

[PATCH] devtools: add cppcheck wrapper

2023-06-12 Thread Stephen Hemminger
From: Ferruh Yigit Adding wrapper script for cppcheck code analysis tool. usage: cppcheck.sh [-h] [cppcheck options] [path] Example: $ ./devtools/cppcheck.sh -q lib/ethdev/ The tool is useful but gets confused by macros in parts of DPDK. It identified some bogus code in netvsc driver, and som

release candidate 23.07-rc1

2023-06-12 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v23.07-rc1 There are 574 new patches in this snapshot. Release notes: https://doc.dpdk.org/guides/rel_notes/release_23_07.html Highlights of 23.07-rc1: - AMD CDX bus - PCI MMIO re

Re: [dpdk-dev] [PATCH 1/2] test/mcslock: move performance test to perf tests

2023-06-12 Thread Stephen Hemminger
On Mon, 23 Mar 2020 12:16:17 +0800 Phil Yang wrote: > The MCS lock performance test takes more than 10 seconds and leads > to meson test timeout on some platforms. Move the performance test > into perf tests. > > Signed-off-by: Phil Yang > Reviewed-by: Gavin Hu > --- No, fix the test. There i

Re: [dpdk-dev] [PATCH v2] examples/l2fwd: free resources in case of error

2023-06-12 Thread Stephen Hemminger
On Tue, 12 May 2020 18:56:37 +0500 Muhammad Bilal wrote: > Bugzilla ID: 437 > Cc: dev@dpdk.org > Cc: sta...@dpdk.org > Cc: bruce.richard...@intel.com > Cc: vipin.vargh...@intel.com > Cc: jgraj...@cisco.com > Signed-off-by: Muhammad Bilal This whole series was just trying to workaround a bug in

[PATCH] app/testpmd: add flow update CLI command

2023-06-12 Thread Alexander Kozyrev
Add testpmd CLI interface for the flow update API. flow queue 1 update 2 rule 3 actions_template 4 postpone yes pattern end actions queue index 3 / end Signed-off-by: Alexander Kozyrev --- app/test-pmd/cmdline_flow.c | 29 app/test-pmd/config.c | 92 +++

Re: [dpdk-dev] [PATCH RFC V2 0/2] TCP flow classification using 4-tuple and flags

2023-06-12 Thread Stephen Hemminger
On Mon, 13 Jan 2020 18:05:28 + Sowmini Varadhan wrote: > V2 updates: checkpatch fixes, revert accidently spelling error > introduced in V1; > > The problem space of TCP flow tracking and classification > based on TCP state requires the ability to classify TCP > flows on more packet propertie

[Bug 802] Need help with ipv4_multicast app in DPDK 20.08

2023-06-12 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=802 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolutio

[Bug 1245] Windows build failure with clang (unresolved external symbol)

2023-06-12 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1245 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Resolution|--- |FIXED Status|

[Bug 1239] VMXNET 3 returned the wrong error code in initializing

2023-06-12 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1239 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Resolution|--- |FIXED Status|

[Bug 1246] [DPDK-23.07] runtime_vf_queue_number_kernel/set_valid_vf_queue_num_command_line: failed information when starting testpmd

2023-06-12 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1246 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resoluti

RE: [PATCH v1 1/1] doc: announce change in bbdev api related to operation extension

2023-06-12 Thread Chautru, Nicolas
Hi Maxime, David, > -Original Message- > From: Maxime Coquelin > > On 6/6/23 23:01, Chautru, Nicolas wrote: > > Hi David, > > > >> -Original Message- > >> From: David Marchand > >> > >> On Mon, Jun 5, 2023 at 10:08 PM Chautru, Nicolas > >> wrote: > >>> Wrt the MLD functions: th

Re: [PATCH] dma/dpaa2: set the vfa bit for rbp with vf

2023-06-12 Thread Thomas Monjalon
> > > Hi, > > > This patch fixed the issue of qdma route by port for PCIe VF. > > > "vfa" bit determines if "vfid" is valid or not. > > > Route by port is a kind of qdam transfer used for PCIe EP to access host > > > by > > PCIe address and PCIe function. Another kind of transfer to access host is

Re: [PATCH v1] raw/ifpga: check afu device before unplug

2023-06-12 Thread Thomas Monjalon
> > AFU device may be already unplugged in IFPGA bus cleanup process, unplug AFU > > device only when it exists. > > > > Signed-off-by: Wei Huang > > It looks good for me. > Acked-by: Tianfei Zhang Applied, thanks.

Re: [EXT] [PATCH v2] graph: fix pcapng file support

2023-06-12 Thread Thomas Monjalon
> > The interface to rte_pcapng changed in last release > > so that the interfaces used need to be added to the pcapng > > file via the API. If this step is missing the pcapng > > file will not be valid and can't be read by wireshark etc. > > > > Fixes: d1da6d0d04c7 ("pcapng: require per-interface

Re: [EXT] Re: [PATCH v3 1/3] lib: add IPv6 lookup node

2023-06-12 Thread Thomas Monjalon
12/06/2023 19:58, Amit Prakash Shukla: > Hi Thomas, > > This series is acked by node maintainer. Please consider merging. > > CI is failing in the doc build, but I believe it is picking up wrong > l3_forward_graph.rst file, as with this latest patch the string "Add route to > ip4 graph infra."

[PATCH 4/4] net/mlx5: implement Flow update API

2023-06-12 Thread Alexander Kozyrev
Add the implementation for the rte_flow_async_actions_update() API. Construct the new actions and replace them for the Flow handle. Old resources are freed during the rte_flow_pull() invocation. Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_f

[PATCH 3/4] net/mlx5/hws: support rule update after its creation

2023-06-12 Thread Alexander Kozyrev
From: Erez Shitrit Add the ability to change rule's actions after the rule already created. The new actions should be one of the action template list. That support is only for matcher that uses the optimization of using rule insertion by index (optimize_using_rule_idx) Signed-off-by: Erez Shitri

[PATCH 2/4] net/mlx5/hws: use union in the wqe-data struct

2023-06-12 Thread Alexander Kozyrev
From: Erez Shitrit To be clear about which field we are going to set. Signed-off-by: Erez Shitrit Reviewed-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_send.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c b/drivers/net/mlx5/hws/mlx5

[PATCH 1/4] net/mlx5/hws: use the same function to check rule

2023-06-12 Thread Alexander Kozyrev
From: Erez Shitrit Before handling it for insert/delete Signed-off-by: Erez Shitrit Reviewed-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_rule.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_rule.c b/driver

[PATCH 0/4] net/mlx5: implement Flow update API

2023-06-12 Thread Alexander Kozyrev
Add the implementation for the rte_flow_async_actions_update() API. Construct the new actions and replace them for the Flow handle. Old resources are freed during the rte_flow_pull() invocation. Alexander Kozyrev (1): net/mlx5: implement Flow update API Erez Shitrit (3): net/mlx5/hws: use the

[RFC] ring: remove unnecessary fences in C11 ring for performance

2023-06-12 Thread Wathsala Vithanage
For improved performance over the current C11 based ring implementation, two ACQUIRE fences between the load of the old_head and the load of the const_tail in __rte_ring_move_prod_head and the load of old_head and load of the prod_tail in __rte_ring_move_cons_head functions have been removed. These

[RFC] ring: remove unnecessary fences in C11 ring for performance

2023-06-12 Thread Wathsala Vithanage
ACQUIRE fence between the two loads established program order to prevent use of an outdated consumer or producer tail values in the computation of free_entries and entries in the two functions respectively. However, (A) the problem described above cannot be solved by establishing the program order

Re: [PATCH v3 1/3] node/kernel_tx: support packet transmit to kernel

2023-06-12 Thread Thomas Monjalon
05/06/2023 14:47, Nithin Dabilpuram: > Acked-by: Nithin Dabilpuram > > On Fri, Jun 2, 2023 at 9:52 PM Vamsi Attunuru wrote: > > > > Patch adds a node to transmit the packets to kernel over > > a raw socket. > > > > Signed-off-by: Vamsi Attunuru > > --- [...] > > +kernel_tx > > +~ > > +T

Re: [PATCH v3 0/3] node: Introduce kernel_rx & kernel_tx nodes

2023-06-12 Thread Thomas Monjalon
02/06/2023 18:22, Vamsi Attunuru: > This patch set introduces two new nodes to transmit & receive packets > from kernel. This nodes can be used for any exception path handling or > to forward any control plane traffic to kernel or receive from kernel stack. > > V3: > * Address review comments > *

Re: [PATCH] net/mlx5: add timestamp ascending order error statistics

2023-06-12 Thread Thomas Monjalon
This patch is marked "Awaiting Upstream" in patchwork, but it doesn't seem merged anywhere. Please check its status. 20/04/2023 10:18, Viacheslav Ovsiienko: > The ConnectX NICs support packet send scheduling on specified > moment of time. Application can set the desired timestamp value > in dynam

Re: [PATCH] net/iavf: fix VLAN offload with AVX512

2023-06-12 Thread Thomas Monjalon
03/04/2023 07:39, Zhang, Qi Z: > > > It has been observed that mbufs of some received VLAN packets had the > > > VLAN tag correctly set in vlan_tci, but ol_flags were missing the > > > VLAN-indicating flags. > > > > > > _mm256_shuffle_epi8 operates as two independent 128-bit operations, > > > not a

[PATCH v1] app/mldev: fix error reporting on IO failure

2023-06-12 Thread Srikanth Yalavarthi
Application is reporting the test output as success when a failure occurs in writing the output. Fix incorrect error reporting on failure to write output files. Fixes: da6793390596 ("app/mldev: support inference validation") Signed-off-by: Srikanth Yalavarthi --- app/test-mldev/test_inference_c

Re: [PATCH v2 2/2] build: prevent accidentally building without NUMA support

2023-06-12 Thread Bruce Richardson
On Mon, Jun 12, 2023 at 06:14:56PM +0100, Bruce Richardson wrote: > When libnuma development package is missing on a system, DPDK can still > be built but will be missing much-needed support for NUMA memory > management. This may later cause issues at runtime if the resulting > binary is run on a N

[PATCH v1] app/mldev: improve checks for invalid options

2023-06-12 Thread Srikanth Yalavarthi
Improve checks for ML application options. Check for negative, non-integral and hexadecimal values. Check for number of entries in filelist option. Improve error reporting for invalid options. Signed-off-by: Srikanth Yalavarthi --- app/test-mldev/ml_options.c| 55

RE: [EXT] Re: [PATCH v3 1/3] lib: add IPv6 lookup node

2023-06-12 Thread Amit Prakash Shukla
Hi Thomas, This series is acked by node maintainer. Please consider merging. CI is failing in the doc build, but I believe it is picking up wrong l3_forward_graph.rst file, as with this latest patch the string "Add route to ip4 graph infra." has been removed. Thanks, Amit Shukla > -Origin

Re: [PATCH v3] eal: choose IOVA mode according to compilation flags

2023-06-12 Thread Thomas Monjalon
08/06/2023 17:45, Viacheslav Ovsiienko: > The DPDK can be compiled to be run in IOVA VA mode with > 'enable_iova_as_pa=false' meson option. If there is no > explicit EAL --iova-mode parameter specified in the command > line the rte_eal_init() tried to deduce VA or PA mode without > taking into acco

Re: [PATCH] eal: add warning for incompatibe requested IOVA mode

2023-06-12 Thread Thomas Monjalon
12/06/2023 11:55, Burakov, Anatoly: > On 6/6/2023 4:39 PM, Viacheslav Ovsiienko wrote: > > The DPDK can be compiled to be run in IOVA VA mode with > > 'enable_iova_as_pa=false' meson option. It disables support > > of the physical address field in the mbufs and application > > can not be run in 'IO

Re: [dpdk-dev] [PATCH v3] doc: remove warning with doxygen 1.9.7

2023-06-12 Thread Thomas Monjalon
02/06/2023 13:16, Bruce Richardson: > On Fri, Jun 02, 2023 at 04:36:59PM +0530, jer...@marvell.com wrote: > > From: Jerin Jacob > > > > Since doxygen 1.9.7 version, HTML_TIMESTAMP configuration option > > changed to TIMESTAMP [2]. Fixed the following warning[1] by > > removing TIMESTAMP options a

RE: [dpdk-dev] [EXT] [PATCH 1/5] examples/l2fwd-event: free resources in case of error

2023-06-12 Thread Sunil Kumar Kori
Previous mail was destined to me which I believe is not correct. Updating "To recipient". Regards Sunil Kumar Kori > -Original Message- > From: Stephen Hemminger > Sent: Monday, June 12, 2023 10:27 PM > To: Sunil Kumar Kori > Cc: Muhammad Bilal ; declan.dohe...@intel.com; > tomasz.kant

[PATCH v2 2/2] build: prevent accidentally building without NUMA support

2023-06-12 Thread Bruce Richardson
When libnuma development package is missing on a system, DPDK can still be built but will be missing much-needed support for NUMA memory management. This may later cause issues at runtime if the resulting binary is run on a NUMA system. We can reduce the incidence of such runtime error by ensuring

[PATCH v2 1/2] build: change flag variable type to boolean

2023-06-12 Thread Bruce Richardson
The has_libnuma flag was using 0 and 1 integer values, instead of the more appropriate boolean type. Change to use true/false instead. Signed-off-by: Bruce Richardson --- config/arm/meson.build| 2 +- config/meson.build| 4 ++-- lib/eal/linux/meson.build | 2 +- lib/vhost/meson.build

Re: [PATCH] doc: fix typo in graph lib doc

2023-06-12 Thread Thomas Monjalon
04/05/2023 06:49, Jerin Jacob: > On Thu, May 4, 2023 at 10:01 AM Ashwin Sekhar T K wrote: > > > > Fix typo in graph lib doc. > > > > Fixes: 4dc6d8e63c168 ("doc: add graph library guide") > > > > Signed-off-by: Ashwin Sekhar T K > > Acked-by: Jerin Jacob Applied, thanks.

Re: [PATCH v2] config/arm: fix Neoverse N2 march flag

2023-06-12 Thread Thomas Monjalon
> > From: Pavan Nikhilesh > > > > The -march flag of Neoverse N2 should be removed with the introduction of > > -mcpu='neoverse- > > n2' as they are incompatible. > > > > Fixes: ea85ed1f6882 ("config/arm: increase nodes and cores for Neoverse N2") > > > > Signed-off-by: Pavan Nikhilesh > > Te

Re: [dpdk-dev] [EXT] [PATCH 1/5] examples/l2fwd-event: free resources in case of error

2023-06-12 Thread Stephen Hemminger
On Tue, 16 Jun 2020 10:38:01 + Sunil Kumar Kori wrote: > >> >> >> > >> >> >> Also I think, it is better to release the relevant resources on > >> >> >> error. > >> >> >Here I'm solving the problem reported in bugzilla id 437. The bug > >> >> >was that if we use --vdev=net_memif with l2fwd

Re: [dpdk-dev] [RFC] hash: introduce resizable hash list

2023-06-12 Thread Stephen Hemminger
On Wed, 28 Aug 2019 14:51:48 +0800 Bing Zhao wrote: > In the current hash library, there are already two hash tables and > several hash calculation functions. > > FBK hash table is very lightweight, but the key length is limited to > 4 bytes and the size of the table is fixed during startup. >

Re: [dpdk-dev] [PATCH 2/2] doc: announce new mbuf field for LRO

2023-06-12 Thread Stephen Hemminger
On Tue, 6 Aug 2019 14:56:23 + Matan Azrad wrote: > The API breakage is because the ``tso_segsz`` field was documented for > LRO. > > The ``tso_segsz`` field in mbuf indicates the size of each segment in > the LRO packet in Rx path and should be provided by the LRO packet > port. > > While

Re: [PATCH] bus/pci: fix return value check of device FD

2023-06-12 Thread Thomas Monjalon
12/06/2023 11:47, Burakov, Anatoly: > On 6/12/2023 6:11 AM, Chenbo Xia wrote: > > Fixing return value check of rte_intr_dev_fd_get() to make sure > > negative device FD will not be used later. > > > > Coverity issue: 385380, 385373 > > Fixes: 095cf6e68b28 ("bus/pci: introduce MMIO read/write") > >

Re: [PATCH v1] ml/cnxk: enable support for scratch relocation

2023-06-12 Thread Thomas Monjalon
07/06/2023 13:43, Srikanth Yalavarthi: > Enabled support for relocation of scratch memory. Added > support for extended arguments in load job descriptor to > handle scratch range start, end and base address. > > Signed-off-by: Srikanth Yalavarthi Applied, thanks.

Re: [Bug 1249] [dpdk-23.07] ixgbe port stop failed after launch testpmd

2023-06-12 Thread Tyler Retzlaff
Hi David, I'm out of office until Thursday so I am not able to properly look right now. If there has been a broad regression here could I ask for your help in either reverting it until I can look at it properly or if you see the obvious problem fixing it. There were multiple instances of flags b

Re: [dpdk-dev] [PATCH v3] doc/testpmd: update compile steps for bpf examples

2023-06-12 Thread Stephen Hemminger
On Mon, 10 Jun 2019 11:11:21 +0530 Vipin Varghese wrote: > Add note in the missing arguments for compiling BPF examples. > > Signed-off-by: Vipin Varghese > Acked-by: John McNamara > > --- > > V3: > - update the dependency for DPDK and others - Thomas Monjalon > > V2: > - ACK for document

Re: [PATCH v1 0/3] Add support for 32 I/O per model

2023-06-12 Thread Thomas Monjalon
23/04/2023 07:08, Srikanth Yalavarthi: > This patch series adds support for 32 inputs / outputs per each > model. Changes required to enable the required support include: > > 1. Splitiing model metadata fields into structures. > 2. Update model metadata to v2301 which supports 32 I/O. > 3. Update

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2023-06-12 Thread Stephen Hemminger
On Mon, 20 Apr 2020 19:34:43 +0200 Lukasz Wojciechowski wrote: > > Note, this means that you need to ensure all debug printouts from libs and > > drivers are using the RTE_LOG macros so can be runtime controlled. I think > > that may be some distance from reality right now. > > > > Even if we do

[PATCH 2/2] build: prevent accidentally building without NUMA support

2023-06-12 Thread Bruce Richardson
When libnuma development package is missing on a system, DPDK can still be built but will be missing much-needed support for NUMA memory management. This may later cause issues at runtime if the resulting binary is run on a NUMA system. We can reduce the incidence of such runtime error by ensuring

[PATCH 1/2] build: change flag variable type to boolean

2023-06-12 Thread Bruce Richardson
The has_libnuma flag was using 0 and 1 integer values, instead of the more appropriate boolean type. Change to use true/false instead. Signed-off-by: Bruce Richardson --- config/arm/meson.build| 2 +- config/meson.build| 4 ++-- lib/eal/linux/meson.build | 2 +- lib/vhost/meson.build

RE: [PATCH v3 0/3] node: Introduce kernel_rx & kernel_tx nodes

2023-06-12 Thread Vamsi Krishna Attunuru
Hi Thomas, This series is acked by node maintainer. Please consider merging. > -Original Message- > From: Vamsi Attunuru > Sent: Friday, June 2, 2023 9:52 PM > To: dev@dpdk.org; tho...@monjalon.net; Jerin Jacob Kollanukkaran > > Cc: Vamsi Krishna Attunuru ; Nithin Kumar > Dabilpuram ; z

Re: [dpdk-dev] [PATCH v4 0/4] add new kv hash table

2023-06-12 Thread Stephen Hemminger
On Thu, 25 Mar 2021 15:03:24 +0300 "Medvedkin, Vladimir" wrote: > Hi Thomas, > > On 25/03/2021 00:28, Thomas Monjalon wrote: > > 08/05/2020 21:58, Vladimir Medvedkin: > >> Currently DPDK has a special implementation of a hash table for > >> 4 byte keys which is called FBK hash. Unfortunately i

[dpdk-dev] [PATCH v2] drivers/cnxk: improve the build time for non arm64 build

2023-06-12 Thread jerinj
From: Jerin Jacob Specialized fast path routines are not applicable to non arm64 build, removing those function contained files to improve the build time on non arm64 build. Signed-off-by: Jerin Jacob Acked-by: Nithin Dabilpuram --- v2: - Just resending to go through CI again. drivers/event/

Re: [dpdk-dev] [PATCH] doc: clarify spaces for alignment note

2023-06-12 Thread Stephen Hemminger
On Mon, 11 Mar 2019 18:39:39 + Kevin Traynor wrote: > Make clear that spaces are only for alignments less than tab size. > > Signed-off-by: Kevin Traynor > --- > doc/guides/contributing/coding_style.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/guides/co

Re: [dpdk-dev] [PATCH 2/2] eal: resolve getentropy at run time for random seed

2023-06-12 Thread Stephen Hemminger
On Wed, 10 Jun 2020 09:33:04 +0100 Luca Boccassi wrote: > > It seems there is a communication issue in this thread. > > Some maintainers look to be against the solution, > > and you seem frustrated because of a blocked usage issue. > > > > Please could you explain what is the initial user proble

Re: [PATCH 1/3] event/cnxk: align TX queue buffer adjustment

2023-06-12 Thread Jerin Jacob
On Tue, May 16, 2023 at 8:08 PM wrote: > > From: Pavan Nikhilesh > > Remove recalculating SQB thresholds in Tx queue buffer adjustment. > The adjustment is already done during Tx queue setup. > > Signed-off-by: Pavan Nikhilesh > --- > Depends-on: series-27660 Depend patches merged to main tree.

Re: [PATCH v2 01/15] common/cnxk: add ROC MACsec initialization

2023-06-12 Thread Jerin Jacob
On Wed, Jun 7, 2023 at 8:58 PM Akhil Goyal wrote: > > Added ROC init and fini APIs for supporting MACsec. > > Signed-off-by: Ankur Dwivedi > Signed-off-by: Vamsi Attunuru > Signed-off-by: Akhil Goyal Please update the release note in the last patch. > --- > drivers/common/cnxk/meson.build

Re: [dpdk-dev] [PATCH] net/cnxk: support port ID flow action item

2023-06-12 Thread Jerin Jacob
On Fri, Jun 9, 2023 at 4:48 PM wrote: > > From: Satheesh Paul > > Currently PORT_ID action can redirect traffic only between > VFs of a PF. This patch extends PORT_ID action to redirect > traffic from one PF port to another PF port also. > > Signed-off-by: Satheesh Paul > Reviewed-by: Kiran Kuma

Re: [RFC] lib/ethdev: introduce table driven APIs

2023-06-12 Thread Ivan Malov
Hi, Thanks for sending the RFC. Sounds interesting. My impression is that this API is rather low-level, so the question is how does the application find a vendor-neutral approach to discover and use specific table to do some job? For example, the application needs to do some tunnel match and de

RE: [PATCH v2] net/iavf: fix compilation warnings

2023-06-12 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon > Sent: Monday, June 12, 2023 10:15 PM > To: Zhang, Qi Z > Cc: Zeng, ZhichaoX ; dev@dpdk.org; Richardson, > Bruce ; Konstantin Ananyev > ; Wu, Jingjing ; > Xing, Beilei ; Wu, Wenjun1 ; > Gao, DaxueX ; david.march...@redhat.com; > Mcnamara, J

Re: [PATCH v1] ml/cnxk: fix xstat type names in documentation

2023-06-12 Thread Thomas Monjalon
23/04/2023 07:01, Srikanth Yalavarthi: > Fix incorrect type names for xstats in ML cnxk driver documentation. > > Fixes: 4ff4ab8e1a20 ("ml/cnxk: support extended statistics") > > Signed-off-by: Srikanth Yalavarthi Applied, thanks.

Re: [PATCH v6] hash: add XOR32 hash function

2023-06-12 Thread Thomas Monjalon
Any review please? This patch is dying... 21/02/2023 20:37, Bili Dong: > An XOR32 hash is needed in the Software Switch (SWX) Pipeline for its > use case in P4. We implement it in this patch so it could be easily > registered in the pipeline later. > > Signed-off-by: Bili Dong > --- > .mailmap

Re: [PATCH v11 00/16] graph enhancement for multi-core dispatch

2023-06-12 Thread David Marchand
On Fri, Jun 9, 2023 at 5:48 PM Yan, Zhirun wrote: > > > Compilation is broken at patch 1 because of the file rename... > > > I hope I won't find anything else broken. > > > > Afaics, header exports are incorrect. I did not look further. > > > > About headers exports: if a public header (declared i

Re: [PATCH v6 0/3] add telemetry cmds for ring

2023-06-12 Thread Thomas Monjalon
30/05/2023 11:27, Jie Hai: > Hi, Thomas and all maintainers, > Kindly ping for comments, thanks. You didn't reply to the question from David, suggesting that GDB would be better used for debugging than telemetry.

RE: [PATCH] config/arm: add Ampere Altra/AltraMax/AmpereOne platform

2023-06-12 Thread Yutang Jiang
Hi Ruifeng, Please help me review this patch. Thank you very much. Best Regards, Yutang Jiang -Original Message- From: Yutang Jiang OS Sent: Sunday, June 11, 2023 1:03 PM To: dev@dpdk.org Cc: Open Source Submission ; Yutang Jiang ; Yutang Jiang OS Subject: [PATCH] config/arm: ad

Re: [PATCH] test/mbuf: fix the forked process segment fault

2023-06-12 Thread Thomas Monjalon
23/05/2023 12:12, Burakov, Anatoly: > On 5/23/2023 4:45 AM, Ruifeng Wang wrote: > >> -Original Message- > >> From: Burakov, Anatoly > >> Sent: Monday, May 22, 2023 6:19 PM > >> To: Ruifeng Wang ; olivier.m...@6wind.com > >> Cc: dev@dpdk.org; sta...@dpdk.org; tho...@monjalon.net; > >> step

Re: [PATCH v2] net/iavf: fix compilation warnings

2023-06-12 Thread Thomas Monjalon
12/06/2023 14:29, Zhang, Qi Z: > From: Thomas Monjalon > > 12/06/2023 10:32, Gao, DaxueX: > > > From: Zeng, ZhichaoX > > > > Use fallthrough comments to ignore compilation warnings instead of > > > > diagnostic pragmas, which are not recognized by old GCC(below GCC7). > > > > > > > > Fixes: 95a1b

Re: [PATCH v14 0/6] introduce memarea library

2023-06-12 Thread Ferruh Yigit
On 2/9/2023 6:36 AM, Chengwen Feng wrote: > The memarea library is an allocator of variable-size object which based > on a memory region. The main features are as follows: > > - The memory region can be initialized from the following memory > sources: > 1. HEAP: e.g. invoke rte_malloc_socket.

Re: [PATCH] eal: fix prompt info when remap_segment failed

2023-06-12 Thread David Marchand
On Mon, May 29, 2023 at 1:22 PM Fengnan Chang wrote: > > when there is enough space for memseg, we should pormpt which > config to modify, not just print numbers. I think you want to explain the case when there is *not* enough objects declared in the static configuration. Could you rephrase and f

RE: [PATCH v2] net/ice:fix tunnel packet TX descriptor error

2023-06-12 Thread Zhang, Qi Z
> -Original Message- > From: He, ShiyangX > Sent: Thursday, June 8, 2023 6:19 PM > To: dev@dpdk.org > Cc: Zhou, YidingX ; He, ShiyangX > ; sta...@dpdk.org; Yang, Qiming > ; Zhang, Qi Z ; Xing, Beilei > > Subject: [PATCH v2] net/ice:fix tunnel packet TX descriptor error Please check th

Re: [PATCH v3] net/ixgbe: add proper memory barriers for some Rx functions

2023-06-12 Thread Thomas Monjalon
12/06/2023 13:58, zhoumin: > On Mon, June 12, 2023 at 6:26PM, Thomas Monjalon wrote: > > 15/05/2023 04:10, Zhang, Qi Z: > >> From: Ruifeng Wang > >>> From: Min Zhou > --- > v3: > - Use rte_smp_rmb() as the proper memory barrier instead of rte_rmb() > --- > v2: > - Ma

RE: [PATCH] net/iavf: fix abnormal disable HW interrupt

2023-06-12 Thread Zhang, Qi Z
> -Original Message- > From: Ye, MingjinX > Sent: Friday, June 9, 2023 11:20 AM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: Yang, Qiming ; Zhou, YidingX > ; sta...@dpdk.org; Wu, Jingjing > ; Xing, Beilei > Subject: RE: [PATCH] net/iavf: fix abnormal disable HW interrupt > > > > > -Or

RE: [PATCH v2] net/iavf: fix compilation warnings

2023-06-12 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon > Sent: Monday, June 12, 2023 5:02 PM > To: Zeng, ZhichaoX ; Zhang, Qi Z > > Cc: dev@dpdk.org; Richardson, Bruce ; > Konstantin Ananyev ; Wu, Jingjing > ; Xing, Beilei ; Wu, Wenjun1 > ; Gao, DaxueX ; > david.march...@redhat.com; Mcnamara, Jo

Re: [PATCH v3] net/ixgbe: add proper memory barriers for some Rx functions

2023-06-12 Thread zhoumin
Hi Thomas, On Mon, June 12, 2023 at 6:26PM, Thomas Monjalon wrote: 15/05/2023 04:10, Zhang, Qi Z: From: Ruifeng Wang From: Min Zhou Segmentation fault has been observed while running the ixgbe_recv_pkts_lro() function to receive packets on the Loongson 3C5000 processor which has 64 cores an

[PATCH v7] gro : ipv6 changes to support GRO for TCP/ipv6

2023-06-12 Thread Kumara Parameshwaran
The patch adds GRO support for TCP/ipv6 packets. This does not include the support for vxlan, udp ipv6 packets. Signed-off-by: Kumara Parameshwaran --- v1: * Changes to support GRO for TCP/ipv6 packets. This does not include vxlan changes. * The GRO is performed only fo

[PATCH v6] gro : ipv6 changes to support GRO for TCP/ipv6

2023-06-12 Thread Kumara Parameshwaran
The patch adds GRO support for TCP/ipv6 packets. This does not include the support for vxlan, udp ipv6 packets. Signed-off-by: Kumara Parameshwaran --- v1: * Changes to support GRO for TCP/ipv6 packets. This does not include vxlan changes. * The GRO is performed only fo

[PATCH v5] gro : ipv6 changes to support GRO for TCP/ipv6

2023-06-12 Thread Kumara Parameshwaran
The patch adds GRO support for TCP/ipv6 packets. This does not include the support for vxlan, udp ipv6 packets. Signed-off-by: Kumara Parameshwaran --- v1: * Changes to support GRO for TCP/ipv6 packets. This does not include vxlan changes. * The GRO is performed only fo

RE: [PATCH] bitmap: add scan init at given position

2023-06-12 Thread Volodymyr Fialko
Hi Cristian, > > My understanding is your proposed procedure for scanning starting at an > offset is: > 1. Call the new function: __rte_bitmap_scan_init_at() 2. Call the regular > function: rte_bitmap_scan() > > I think this procedure is not ideal, therefore I suggest we create a new API > f

Re: [PATCH] net/nfp: fix the new solution for tunnel decap action

2023-06-12 Thread Ferruh Yigit
On 6/12/2023 4:18 AM, Chaoyong He wrote: > Add the missing data endian convert operations, the former logic of > processing the 'vlan_tpid' field will cause the tunnel decap action > don't work as expect in some case. > > Fixes: 9082336048e8 ("net/nfp: support new solution for tunnel decap action"

  1   2   >