From: Long Wu
The whole PCI name is too long and we remove the part before
the first colon.
For example:
old: :af:00.0_ctrlmp
new: af:00.0_ctrlmp
Signed-off-by: Long Wu
Reviewed-by: Chaoyong He
---
drivers/net/nfp/flower/nfp_flower.c | 2 +-
drivers/net/nfp/nfp_flow.c | 10
From: Long Wu
The length of representor name may exceed the limit when we use
it to create rte_ring, so we reduce the length of its name.
For example:
old: :af:00.0_fl_repr_p1
new: af:00.0_repr_p1
Fixes: 2003cb447aa5 ("net/nfp: fix representor creation")
Cc: sta...@dpdk.org
Signed-off-by:
Use the complete PCI name as the part of representor port name cause the
app crash, because the name is too long.
Fix this by reduce the length, using only the parts after the first ':'.
To keep unification, also use the same approach for the name of hash
parameters.
Long Wu (2):
net/nfp: fix
Burakov, Anatoly 于2023年6月13日周二 19:00写道：
>
> On 5/29/2023 12:21 PM, Fengnan Chang wrote:
> > when there is enough space for memseg, we should pormpt which
> > config to modify, not just print numbers.
> >
> > Signed-off-by: Fengnan Chang
> > ---
> > lib/eal/linux/eal_memory.c | 5 ++---
> > 1 f
David Marchand 于2023年6月12日周一 21:09写道：
>
> On Mon, May 29, 2023 at 1:22 PM Fengnan Chang
> wrote:
> >
> > when there is enough space for memseg, we should pormpt which
> > config to modify, not just print numbers.
>
> I think you want to explain the case when there is *not* enough
> objects declar
> -Original Message-
> From: Shiyang He
> Sent: Wednesday, June 14, 2023 5:59 PM
> To: dev@dpdk.org
> Cc: Zhou, YidingX ; He, ShiyangX
> ; sta...@dpdk.org; Zhang, Yuying
> ; Xing, Beilei ; Zhe Tao
> ; Jianfeng Tan
> Subject: [PATCH] net/i40e: fix tunnel packet TX descriptor error
>
>
From: Satha Rao
Removed condition that doesn't have any effect on code flow.
Coverity issue: 385405
Fixes: 4d00b8c6a331 ("common/cnxk: allocate dynamic BPIDs")
Signed-off-by: Satha Rao
---
drivers/common/cnxk/roc_nix_fc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/common/cnx
> -Original Message-
> From: Mingjin Ye
> Sent: Wednesday, June 14, 2023 5:53 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming ; Zhou, YidingX
> ; Ye, MingjinX ;
> sta...@dpdk.org; Wu, Jingjing ; Xing, Beilei
>
> Subject: [PATCH v2] net/iavf: fix abnormal disable HW interrupt
>
> For command
On Thu, Jun 15, 2023 at 11:33 AM Zhang, Qi Z wrote:
>
> Hi Jerin:
Hi Qi
>
> > -Original Message-
> > From: Jerin Jacob
> > Sent: Thursday, June 15, 2023 12:58 PM
> > To: Zhang, Qi Z
> > Cc: Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL)
> > ; david.march...@redhat.com; Richardson, Br
The patch adds GRO support for TCP/ipv6 packets. This does not
include the support for vxlan, udp ipv6 packets.
Signed-off-by: Kumara Parameshwaran
---
v1:
* Changes to support GRO for TCP/ipv6 packets. This does not include
vxlan changes.
* The GRO is performed only fo
On 2023-06-14 20:13, Stephen Hemminger wrote:
On Wed, 14 Jun 2023 19:25:25 +0200
Mattias Rönnblom wrote:
static struct rte_event_dispatcher_handler*
+evd_lcore_get_handler_by_id(struct rte_event_dispatcher_lcore *lcore,
+ int handler_id)
+{
+ int i
in other pl
Hi Jerin:
> -Original Message-
> From: Jerin Jacob
> Sent: Thursday, June 15, 2023 12:58 PM
> To: Zhang, Qi Z
> Cc: Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL)
> ; david.march...@redhat.com; Richardson, Bruce
> ; jer...@marvell.com; ferruh.yi...@amd.com;
> Mcnamara, John ; Zhang, He
On Thu, Jun 15, 2023 at 1:51 AM wrote:
>
> From: Pavan Nikhilesh
>
> Disable -Wasm-operand-widths when using clang.
>
> Fixes: 1c80eb7a3ccc ("event/cnxk: use WFE in Tx flow control wait")
>
> Signed-off-by: Pavan Nikhilesh
> ---
> Jerin, Please squash this to 1c80eb7a3ccc.
Squashed.
>
> driv
Fix merged.
From: Patrick Robb
Sent: Wednesday, June 14, 2023 11:57 PM
To: Jerin Jacob
Cc: Pavan Nikhilesh Bhagavatula ; Jerin Jacob
Kollanukkaran ; Shijith Thotton ;
Nithin Kumar Dabilpuram ; Kiran Kumar Kokkilagadda
; Sunil Kumar Kori ; Satha
Koteswara Rao K
The patch adds GRO support for TCP/ipv6 packets. This does not
include the support for vxlan, udp ipv6 packets.
Signed-off-by: Kumara Parameshwaran
---
v1:
* Changes to support GRO for TCP/ipv6 packets. This does not include
vxlan changes.
* The GRO is performed only fo
> -Original Message-
> From: Guo, Junfeng
> Sent: Thursday, June 15, 2023 1:17 PM
> To: Zhang, Qi Z ; Yang, Qiming
>
> Cc: dev@dpdk.org; sta...@dpdk.org; Xu, Ting ; Guo,
> Junfeng
> Subject: [PATCH 0/2] fix variable type in pattern parsing for raw flow
>
> In current pattern parsing fun
Hi,
Thanks for working on the comments. Few more top level comment inline.
Thanks,
Anoob
> -Original Message-
> From: Cheng Jiang
> Sent: Tuesday, June 13, 2023 10:02 AM
> To: tho...@monjalon.net; bruce.richard...@intel.com;
> m...@smartsharesystems.com; chenbo@intel.com; Amit Praka
In current pattern parsing function for protocol agnostic flow
offloading (raw flow), some of the variables of packet length are
defined as uint8_t, which are too small for some large-size packets,
such as srv6 (Segment Routing over IPv6 dataplane) type. Change the
type to uint16_t.
Fixes: bc0e855
In current pattern parsing function for protocol agnostic flow
offloading (raw flow), some of the variables of packet length are
defined as uint8_t, which are too small for some large-size packets,
such as srv6 (Segment Routing over IPv6 dataplane) type. Change the
type to uint16_t.
For example, t
In current pattern parsing function for protocol agnostic flow
offloading (raw flow), some of the variables of packet length are
defined as uint8_t, which are too small for some large-size packets,
such as srv6 (Segment Routing over IPv6 dataplane) type. Change the
type to uint16_t.
Fixes: 25be39c
From: Satha Rao
When try to configure MTU for lower value causes run time failure
due to old bigger packets enqueued. To avoid error interrupts better
to flush the all SQs of this port before configuring new MTU.
Signed-off-by: Satha Rao
---
drivers/net/cnxk/cnxk_ethdev.h | 1 +
drivers/n
On Thu, Jun 15, 2023 at 7:55 AM Zhang, Qi Z wrote:
>
> Hi Ori:
>
> Thank you for your review!
> Comment inline.
> Please let me know if anything I missed.
>
> Thanks
> Qi
>
> > -Original Message-
> > From: Ori Kam
> > Sent: Thursday, June 15, 2023 2:31 AM
> > To: Z
> -Original Message-
> From: Fangming Fang
> Sent: Thursday, June 15, 2023 8:16 AM
> To: Akhil Goyal ; tho...@monjalon.net; Ciara Power
> ; Honnappa Nagarahalli
> ; kai...@intel.com; Pablo de Lara
> ; Ruifeng Wang ;
> john.mcnam...@intel.com
> Cc: dev@dpdk.org; david.march...@redhat.com
> -Original Message-
> From: Vamsi Attunuru
> Sent: Tuesday, June 13, 2023 9:28 PM
> To: dev@dpdk.org; tho...@monjalon.net
> Cc: Radha Chintakuntla ; Veerasenareddy Burru
> ; Sathesh B Edara ; Jerin Jacob
> Kollanukkaran ; Vamsi Krishna Attunuru
>
> Subject: [PATCH] maintainers: update fo
From: James Hershaw
The NFP PMD driver retrieves the linkspeed by reading the
NFP_NET_CFG_STS_LINK register. This register is not set by all versions
of the firmware. Changes in this patch include:
Addition of listener function to deal with control messages of type
NFP_FLOWER_CMSG_TYPE_PORT_MOD
The VF PMD can not get a valid 'cpp' data filed in the 'struct
nfp_net_hw', the value of which will be NULL always. This cause any
logic which use of 'cpp' will make the app crash.
Fix this by delete the support of getting firmware version of VF.
Fixes: 128c8ad951bf ("net/nfp: support getting fir
On Fri, 27 Nov 2020 19:09:20 +
Ferruh Yigit wrote:
> Other protocol structs are in the host byte order, having eCPRI in
> network byte order is insistent and error prone.
>
> Making eCPRI protocol header host byte order.
>
> Signed-off-by: Haiyue Wang
> Signed-off-by: Ferruh Yigit
The di
Thanks Patrick,
I have sent out a fix.
https://mails.dpdk.org/archives/dev/2023-June/271209.html
Pavan.
From: Patrick Robb
Sent: Wednesday, June 14, 2023 11:57 PM
To: Jerin Jacob
Cc: Pavan Nikhilesh Bhagavatula ; Jerin Jacob
Kollanukkaran ; Shijith Thotton ;
Nithin Kumar Dabilpuram ; Kira
From: Pavan Nikhilesh
Disable -Wasm-operand-widths when using clang.
Fixes: 1c80eb7a3ccc ("event/cnxk: use WFE in Tx flow control wait")
Signed-off-by: Pavan Nikhilesh
---
Jerin, Please squash this to 1c80eb7a3ccc.
drivers/event/cnxk/meson.build | 4
drivers/net/cnxk/meson.build | 3
On Fri, 18 Dec 2020 15:47:28 +0800
Chenbo Xia wrote:
> This series introduces a new device abstraction called emudev for emulated
> devices. A new library (librte_emudev) is implemented. The first emudev
> driver is also introduced, which emulates Intel Adaptive Virtual Function
> (iavf) as a sof
On Sat, 2 Mar 2019 03:42:50 +0100
Thomas Monjalon wrote:
> While working on multi-process support of failsafe with Raslan,
> some issues have been discovered on probing failures.
>
> Thomas Monjalon (3):
> eal: remove useless checks for already probed device
> eal: remove error logs for alr
On Wed, 4 Sep 2019 13:04:38 +0100
Chaitanya Babu Talluri wrote:
> 1/4: fix vfio unmap that fails unexpectedly
> 2/4: fix vfio unmap that succeeds unexpectedly
> 3/4: add API to check iommu type is set
> 4/4: add unit tests for eal vfio
>
> Patch 4/4 depends on 1/4,2/4,3/4
>
> Signed-off-by: Ch
On Thu, 23 Jan 2020 10:58:13 +0100
Gaetan Rivet wrote:
> Add a new EAL option enabling manual probing in the EAL.
> This command line option will configure the EAL so that buses
> will not trigger their probe step on their own.
>
> Applications are then expected to hotplug devices as they see fi
On Thu, 24 Sep 2020 12:41:01 +0100
John Alexander wrote:
> The Windows EAL build now pulls in the pthreads4w project as an external
> subproject. The pthreads4w subproject does not currently provide a
> meson build so the project has been patched with one.
>
> Removed the placeholder librte_eal
> By default, uadk only alloc two queues for each algorithm, which
> will impact performance.
> Set queue pair number as required in dev_configure.
> The default max queue pair number is 8, which can be modified
> via para: max_nb_queue_pairs
>
> Example:
> sudo dpdk-test-crypto-perf -l 0-10 --vde
On Fri, 18 Sep 2020 14:57:50 +0100
Bruce Richardson wrote:
> On Fri, Sep 18, 2020 at 02:54:21PM +0200, Mohammed Hawari wrote:
> > Hello Bruce,
> >
> > Thanks for the quick response, see inline
> >
> > Best regards,
> >
> > Mohammed
> >
> > > On 18 Sep 2020, at 13:43, Bruce Richardson
> >
++Kai for review.
> -Original Message-
> From: Akhil Goyal
> Sent: Thursday, June 15, 2023 12:21 AM
> To: Michael Leung ; dev@dpdk.org
> Subject: RE: [EXT] [PATCH] crypto/openssl: add aes-xts support
>
> > Add aes-128-xts and aes-256-xts support for crypto openssl pmd. As xts mode
> > we
> Add aes-128-xts and aes-256-xts support for crypto openssl pmd. As xts mode
> we got 2 key, the key length is multiplied by two, i.e. 32 and 64.
>
> Signed-off-by: Michael Leung
> ---
Fix checkpatch issues
Also update doc/guides/cryptodevs/features/openssl.ini
> All the insecure algorithms are default disable from
> cryptodev Gen 1,2,3 and 4.
> use qat_legacy_capa to enable all the legacy
> algorithms.
> These change effects both sym and asym insecure crypto
> algorithms.
>
> Signed-off-by: Vikash Poddar
> ---
> Depends-on: patch-28182 ("[v2] common/qa
Hi Qi,
1. it may be useful to get some general calling flow what comes from the
application,
what comes from the compiler.
Simple example will be good.
2. I gave some comments about names but those are in low priority,
first, we need to understand what is the basic flow.
3. in your suggested A
Hello Pavan and Jerin,
The Community Lab's CI testing failed this patchseries on clang compile on
ARM systems. That wasn't properly reported to Patchwork due to issues with
our reporting process, which we are resolving currently. This updated
report show the failed compile. Apologies for the incom
> -IMB_required_ver = '1.2.0'
> +IMB_required_ver = '1.4.0'
> IMB_header = '#include'
> if arch_subdir == 'arm'
> IMB_header = '#include'
> endif
I believe there are compilation issues with arm repo for 1.4 version.
It is better to fix that first before making this to default.
> libipsec
Hi Maxime,
> -Original Message-
> From: Maxime Coquelin
> Hi,
>
> On 6/13/23 19:16, Chautru, Nicolas wrote:
> > Hi Maxime,
> >
> >> -Original Message-
> >> From: Maxime Coquelin
> >
> >>
> >> On 6/12/23 22:53, Chautru, Nicolas wrote:
> >>> Hi Maxime, David,
> >>>
> -Or
> This small series cleans-up some crypto PMD drivers.
>
Please rebase.
On Wed, 14 Jun 2023 19:25:25 +0200
Mattias Rönnblom wrote:
> static struct rte_event_dispatcher_handler*
> +evd_lcore_get_handler_by_id(struct rte_event_dispatcher_lcore *lcore,
> + int handler_id)
> +{
> + int i
in other places you used uint16_t for iterating over ha
> AES-GCM provides both authenticated encryption and the ability to check
> the integrity and authentication of additional authenticated data (AAD)
> that is sent in the clear.
>
> The crypto operations are performed with crypto WQE. If the input
> buffers(AAD, mbuf, digest) are not contiguous and
This commit adds SM3 HMAC to Intel QuickAssist Technology PMD
generation 3 and 4 devices.
Signed-off-by: Arek Kusztal
---
v2:
- Fixed problem with chaining operations
- Added implementation of prefix tables
v3:
- Added support for gen3 devices
doc/guides/cryptodevs/features/qat.ini | 1
Provide programming guide the for the event dispatcher.
Signed-off-by: Mattias Rönnblom
--
PATCH:
o Improve grammar and spelling.
RFC v4:
o Extend event matching section of the programming guide.
o Improve grammar and spelling.
---
doc/api/doxy-api-index.md | 1 +
doc/gui
Add unit tests for the event dispatcher.
--
PATCH:
o Extend test to cover often-used handler optimization feature.
RFC v4:
o Adapt to non-const events in process function prototype.
Signed-off-by: Mattias Rönnblom
---
app/test/meson.build | 1 +
app/test/test_event_dispatcher.c
The purpose of the event dispatcher is to help reduce coupling in an
Eventdev-based DPDK application.
In addition, the event dispatcher also provides a convenient and
flexible way for the application to use service cores for
application-level processing.
Signed-off-by: Mattias Rönnblom
Tested-by
The purpose of the event dispatcher is to decouple different parts of
an application (e.g., processing pipeline stages), sharing the same
underlying event device.
The event dispatcher replaces the conditional logic (often, a switch
statement) that typically follows an event device dequeue operatio
Hi
> -Original Message-
> From: Alexander Kozyrev
> Sent: Tuesday, June 13, 2023 12:14 AM
>
> Add testpmd CLI interface for the flow update API.
> flow queue 1 update 2 rule 3 actions_template 4 postpone yes
> pattern end actions queue index 3 / end
>
> Signed-off-by: Alexan
> -Original Message-
> From: Alexander Kozyrev
> Sent: Monday, June 12, 2023 11:06 PM
>
> From: Erez Shitrit
>
> Add the ability to change rule's actions after the rule already created.
> The new actions should be one of the action template list.
> That support is only for matcher tha
> -Original Message-
> From: Alexander Kozyrev
> Sent: Monday, June 12, 2023 11:06 PM
>
> From: Erez Shitrit
>
> To be clear about which field we are going to set.
>
> Signed-off-by: Erez Shitrit
> Reviewed-by: Alex Vesker
> ---
> drivers/net/mlx5/hws/mlx5dr_send.c | 2 +-
> 1 fil
> -Original Message-
> From: Alexander Kozyrev
> Sent: Monday, June 12, 2023 11:06 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh ; Matan Azrad
> ; Slava Ovsiienko ; Ori Kam
> ; Erez Shitrit
> Subject: [PATCH 1/4] net/mlx5/hws: use the same function to check rule
>
> From: Erez Shitrit
Good morning DPDK Community,
Summer is upon us, and within a few months we will hold our DPDK Summit
2023 in Dublin, Ireland. September 12-13, 2023, at the Gibson Hotel in
Point Square. Registration and attendance for this event are *free!*
We've put out a CFP now for talks, to be presented to at
Hi, David
It looks like a good application datapath optimization, as for me.
But I see some concerns:
1. Are we sure the PMD should register the flag, not application?
IIRC, usually application registers needed flags/fields and PMDs just follow.
+ if (!sh->tunnel_hub && sh->config.dv_miss_
On Wed, 14 Jun 2023 17:20:59 +0200
Thomas Monjalon wrote:
> Two functions helping to check Rx/Tx queues validity
> were added in DPDK 23.07-rc1.
> As the release is not closed, it is still time to rename.
>
> The name proposed originally
> rte_eth_dev_is_valid_*xq
> is consistent with this
Add new parameter "model" to choose mcore dispatch or rtc model.
And in dispatch model, the node will affinity to worker core successively.
RTE_GRAPH_MODEL_SELECT is set to RTE_GRAPH_MODEL_RTC by default. Must set
model the same as RTE_GRAPH_MODEL_SELECT if set it as rtc or mcore
dispatch explicit
Add functional test for mcore dispatch model including graph clone,
graph model set/get, node worker affinity, graph worker binding/unbinding.
Signed-off-by: Haiyue Wang
Signed-off-by: Cunming Liang
Signed-off-by: Zhirun Yan
Acked-by: Pavan Nikhilesh
---
app/test/test_graph.c | 130 ++
Add stats for mcore dispatch model if stats collection is
enabled.
Signed-off-by: Haiyue Wang
Signed-off-by: Cunming Liang
Signed-off-by: Zhirun Yan
Acked-by: Jerin Jacob
Acked-by: Pavan Nikhilesh
---
lib/graph/graph_debug.c| 6 ++
lib/graph/graph_stats.c
This patch enables to chose new scheduler model. Must define
RTE_GRAPH_MODEL_SELECT before including rte_graph_worker.h
to enable specific model choosing.
Signed-off-by: Haiyue Wang
Signed-off-by: Cunming Liang
Signed-off-by: Zhirun Yan
Acked-by: Jerin Jacob
Acked-by: Pavan Nikhilesh
---
doc
This patch introduces the task scheduler mechanism to enable dispatching
tasks to another worker cores. Currently, there is only a local work
queue for one graph to walk. We introduce a scheduler worker queue in
each worker core for dispatching tasks. It will perform the walk on
scheduler work queu
This patch enables to create and destroy scheduling workqueue into
common graph operations.
Signed-off-by: Haiyue Wang
Signed-off-by: Cunming Liang
Signed-off-by: Zhirun Yan
Acked-by: Pavan Nikhilesh
---
lib/graph/graph.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff
This patch introduces key functions to allow a worker thread to
enable enqueue and move streams of objects to the next nodes over
different cores for mcore dispatch model.
Signed-off-by: Haiyue Wang
Signed-off-by: Cunming Liang
Signed-off-by: Zhirun Yan
Acked-by: Pavan Nikhilesh
---
lib/graph
Add graph_mcore_dispatch_wq_node to hold graph scheduling workqueue
node.
Signed-off-by: Haiyue Wang
Signed-off-by: Cunming Liang
Signed-off-by: Zhirun Yan
---
lib/graph/graph.c | 2 ++
lib/graph/graph_populate.c | 1 +
lib/graph/graph_private.h | 12
This patch adds graph API for supporting to clone the graph object for
a specified worker core. The new graph will also clone all nodes.
Signed-off-by: Haiyue Wang
Signed-off-by: Cunming Liang
Signed-off-by: Zhirun Yan
Acked-by: Jerin Jacob
---
lib/graph/graph.c | 89 +
Move clone_name() into graph_private.h as a common function for both node
and graph to naming a new cloned object.
Signed-off-by: Haiyue Wang
Signed-off-by: Cunming Liang
Signed-off-by: Zhirun Yan
Acked-by: Jerin Jacob
---
lib/graph/graph_private.h | 41 +++
Add lcore_id for graph to hold affinity core id where graph would run on.
Add bind/unbind API to set/unset graph affinity attribute. lcore_id will
be set as MAX by default, it means not enable this attribute.
Signed-off-by: Haiyue Wang
Signed-off-by: Cunming Liang
Signed-off-by: Zhirun Yan
Acke
Add lcore_id for node to hold affinity core id and impl
rte_graph_model_mcore_dispatch_lcore_affinity_set to set node affinity
with specific lcore.
Signed-off-by: Haiyue Wang
Signed-off-by: Cunming Liang
Signed-off-by: Zhirun Yan
Acked-by: Jerin Jacob
---
lib/graph/graph_private.h
Add new get/set APIs to configure graph worker model which is used to
determine which model will be chosen.
Signed-off-by: Haiyue Wang
Signed-off-by: Cunming Liang
Signed-off-by: Zhirun Yan
Acked-by: Jerin Jacob
---
lib/graph/meson.build | 1 +
lib/graph/rte_graph_worker.c
Node process is a single and reusable block, move the code into an inline
function.
Signed-off-by: Haiyue Wang
Signed-off-by: Cunming Liang
Signed-off-by: Zhirun Yan
Acked-by: Jerin Jacob
---
lib/graph/rte_graph_model_rtc.h | 20 ++---
lib/graph/rte_graph_worker_common.h | 33
To support multiple graph worker model, split graph into common
and default. Naming the current walk function as rte_graph_model_rtc
cause the default model is RTC(Run-to-completion).
Signed-off-by: Haiyue Wang
Signed-off-by: Cunming Liang
Signed-off-by: Zhirun Yan
Acked-by: Jerin Jacob
---
a
Rename rte_graph_work.h to rte_graph_work_common.h for supporting
multiple graph worker model.
Signed-off-by: Haiyue Wang
Signed-off-by: Cunming Liang
Signed-off-by: Zhirun Yan
Acked-by: Jerin Jacob
---
MAINTAINERS | 3 ++-
app/test/test_graph.c
V15:
Fix build issues. (add unused macro in patch 10 then remove in patch 11,
fix log message format in patch 01, rm wrong assert in dispatch_walk in patch
12)
V14:
Rebase to main and fix build issues.(align header name in patch 01,02)
V13:
Add sub header into meson indirect_headers list to expo
14/06/2023 17:08, David Marchand:
> On Wed, Jun 14, 2023 at 4:42 PM Jerin Jacob wrote:
> >
> > On Wed, Jun 14, 2023 at 8:01 PM Thomas Monjalon wrote:
> > >
> > > While pulling some trees for DPDK 23.07-rc1,
> > > I've seen that some wrong coding style for comments
> > > were copied over and over.
On 6/14/2023 4:20 PM, Thomas Monjalon wrote:
> Two functions helping to check Rx/Tx queues validity
> were added in DPDK 23.07-rc1.
> As the release is not closed, it is still time to rename.
>
> The name proposed originally
> rte_eth_dev_is_valid_*xq
> is consistent with this function:
>
Two functions helping to check Rx/Tx queues validity
were added in DPDK 23.07-rc1.
As the release is not closed, it is still time to rename.
The name proposed originally
rte_eth_dev_is_valid_*xq
is consistent with this function:
rte_eth_dev_is_valid_port()
However, the suffixes "rx
On Wed, Jun 14, 2023 at 4:42 PM Jerin Jacob wrote:
>
> On Wed, Jun 14, 2023 at 8:01 PM Thomas Monjalon wrote:
> >
> > While pulling some trees for DPDK 23.07-rc1,
> > I've seen that some wrong coding style for comments
> > were copied over and over.
> >
> > In order to avoid copying wrong comment
According to meson documentation, we should not make any assumptions as
to what directory a script is called from[1]. The use of "relpath" when
processing the output of directory globbing is therefore unsafe, as it
was stripping off paths relative to the current directory - which just
happened to b
On Wed, Jun 14, 2023 at 04:26:46PM +0200, Thomas Monjalon wrote:
> While pulling some trees for DPDK 23.07-rc1,
> I've seen that some wrong coding style for comments
> were copied over and over.
>
> In order to avoid copying wrong comment style,
> the three first patches are fixing a lot of commen
On Wed, Jun 14, 2023 at 8:01 PM Thomas Monjalon wrote:
>
> While pulling some trees for DPDK 23.07-rc1,
> I've seen that some wrong coding style for comments
> were copied over and over.
>
> In order to avoid copying wrong comment style,
> the three first patches are fixing a lot of comments.
> As
The Doxygen comments are made after the struct field,
but were missing the Doxygen syntax /**<.
Fixes: 518a974bfecc ("cryptodev: reorganize asymmetric structs")
Cc: sta...@dpdk.org
Signed-off-by: Thomas Monjalon
---
lib/cryptodev/rte_crypto_asym.h | 4 ++--
1 file changed, 2 insertions(+), 2 de
Variable declarations in header files are using extern, it is valid.
But function declarations do not need the keyword extern.
Also, extern "C" should have a space after the keyword extern.
Signed-off-by: Thomas Monjalon
---
lib/acl/acl.h | 2 +-
lib/bpf/bpf_impl.h|
Some comment blocks were missing a space or had too many spaces
at the beginning of the lines, resulting in misalignment of asterisks.
Such mistakes were found with this kind of commands:
git grep '^\*' lib
git grep '^ *\*' lib
Signed-off-by: Thomas Monjalon
---
lib/acl/acl_ge
A comment should always be terminated with */
Extra asterisks were found with this kind of command:
git grep '\* *\*/' lib
Signed-off-by: Thomas Monjalon
---
lib/cfgfile/rte_cfgfile.h | 2 +-
lib/cryptodev/rte_crypto_sym.h | 2 +-
lib/cryptodev/rte_cryptodev.h | 4 ++--
At the end of a comment, no need for an extra line.
This pattern was fixed with the following command:
git ls lib | xargs sed -i '/^ *\* *$/{N;/ *\*\/ *$/D;}'
Signed-off-by: Thomas Monjalon
---
lib/bbdev/rte_bbdev.h | 2 --
lib/bbdev/rte_bbdev_op.h| 1 -
lib/
While pulling some trees for DPDK 23.07-rc1,
I've seen that some wrong coding style for comments
were copied over and over.
In order to avoid copying wrong comment style,
the three first patches are fixing a lot of comments.
As it is not critical, they are not marked for backport.
While looking t
14/06/2023 12:48, Ferruh Yigit:
> Should we document preferred tool and usage in DPDK, if so where is good
> location for it?
I think it should be in the user guide.
We are starting to merge the 3 user guides in 1.
You can add it to the Linux guide only for now.
Some drivers and devices(ex: igc + i225/i226) use
RTE_INTR_HANDLE_UIO handler when captured under igb_uio
so just let them use it.
Signed-off-by: Vladimir Ratnikov
---
lib/eal/linux/eal_interrupts.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/eal/linux/eal_interrupts.c b/lib/eal/
Fix interrupt mode initialization for X550EM_a revision
Signed-off-by: Vladimir Ratnikov
---
drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 43aea2e16f..d44ef37a7a 100644
--- a/drivers/
On 4/18/2023 9:25 AM, Sivaprasad Tummala wrote:
Add a new CPUID flag to indicate support for monitorx instruction
on AMD EPYC processors.
Signed-off-by: Sivaprasad Tummala
---
Acked-by: Anatoly Burakov
--
Thanks,
Anatoly
On 4/18/2023 9:25 AM, Sivaprasad Tummala wrote:
mwaitx allows EPYC processors to enter a implementation dependent
power/performance optimized state (C1 state) for a specific period
or until a store to the monitored address range.
Signed-off-by: Sivaprasad Tummala
---
Bar one fix below,
Acked
On 4/18/2023 9:25 AM, Sivaprasad Tummala wrote:
current x86 power monitor implementation fails on platforms
with only monitor supported and not power_pause.
Signed-off-by: Sivaprasad Tummala
---
Acked-by: Anatoly Burakov
--
Thanks,
Anatoly
Added support for MACsec session/flow create/destroy.
Signed-off-by: Akhil Goyal
---
drivers/net/cnxk/cn10k_ethdev_sec.c | 11 +-
drivers/net/cnxk/cn10k_flow.c | 23 ++-
drivers/net/cnxk/cnxk_ethdev.c | 2 +
drivers/net/cnxk/cnxk_ethdev.h | 16 ++
drivers/net/cnxk/cnxk_ethde
Added support for MACsec SC/flow/session stats.
Signed-off-by: Akhil Goyal
---
doc/guides/rel_notes/release_23_07.rst | 10 ++--
drivers/net/cnxk/cn10k_ethdev_sec.c| 11 +++--
drivers/net/cnxk/cnxk_ethdev_mcs.c | 64 ++
drivers/net/cnxk/cnxk_ethdev_mcs.h | 9
Added initialization routines for MACsec for
cn10kb platform.
Signed-off-by: Akhil Goyal
---
drivers/net/cnxk/cn10k_ethdev_sec.c | 6 ++
drivers/net/cnxk/cnxk_ethdev.c | 13 +++
drivers/net/cnxk/cnxk_ethdev.h | 14 +++
drivers/net/cnxk/cnxk_ethdev_mcs.c | 151 +
Added support to create/destroy MACsec SA and SC.
Signed-off-by: Akhil Goyal
---
drivers/net/cnxk/cn10k_ethdev_sec.c | 9 +-
drivers/net/cnxk/cnxk_ethdev_mcs.c | 253
drivers/net/cnxk/cnxk_ethdev_mcs.h | 16 ++
3 files changed, 274 insertions(+), 4 deletions(-)
MACsec hardware configuration need hash key to be generated
from the cipher key of AES-GCM-128/256.
Added an ROC API to derive the hash key and extend the case
for AES-256 as well.
Signed-off-by: Akhil Goyal
---
drivers/common/cnxk/roc_aes.c | 86 ++---
drivers/comm
Added ROC APIs to configure MACsec control port.
Signed-off-by: Ankur Dwivedi
Signed-off-by: Vamsi Attunuru
Signed-off-by: Akhil Goyal
---
drivers/common/cnxk/roc_mbox.h | 72
drivers/common/cnxk/roc_mcs.c | 117
drivers/common/cnxk/roc
1 - 100 of 126 matches
Mail list logo
