RE: [EXT] Re: [PATCH v1 1/7] eventdev: introduce DMA event adapter library

2023-09-20 Thread Amit Prakash Shukla
Hi Jerin, Thanks for the review and feedback. I will make all suggested changes in next version of patch. Thanks, Amit Shukla > -Original Message- > From: Jerin Jacob > Sent: Thursday, September 21, 2023 8:11 AM > To: Amit Prakash Shukla > Cc: Jerin Jacob Kollanukkaran ; dev@dpdk.org;

RE: [PATCH 2/4] dumpcap: allow multiple invocations

2023-09-20 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, 21 September 2023 06.24 > > If dumpcap is run twice with each instance pointing a different > interface, it would fail because of overlap in ring a pool names. > Fix by putting process id in the name. > > Fixes: cbb44

RE: [PATCH v3 1/3] lib: introduce dispatcher library

2023-09-20 Thread Naga Harish K, S V
> -Original Message- > From: Jerin Jacob > Sent: Wednesday, September 20, 2023 3:02 PM > To: Naga Harish K, S V > Cc: mattias.ronnblom ; dev@dpdk.org; > Jerin Jacob ; techbo...@dpdk.org; Van Haaren, Harry > ; hof...@lysator.liu.se; Nilsson, Peter > ; Heng Wang ; > Pavan Nikhilesh ; Gujj

Re: [PATCH 2/2] net/ice: fix TSO with big segments

2023-09-20 Thread David Marchand
On Thu, Sep 21, 2023 at 7:48 AM Zhang, Qi Z wrote: > > > > > -Original Message- > > From: David Marchand > > Sent: Tuesday, September 19, 2023 10:05 PM > > To: dev@dpdk.org > > Cc: ktray...@redhat.com; m...@redhat.com; dexia...@jaguarmicro.com; > > sta...@dpdk.org; Yang, Qiming ; Zhang, Q

RE: [PATCH 2/2] net/ice: fix TSO with big segments

2023-09-20 Thread Zhang, Qi Z
> -Original Message- > From: David Marchand > Sent: Tuesday, September 19, 2023 10:05 PM > To: dev@dpdk.org > Cc: ktray...@redhat.com; m...@redhat.com; dexia...@jaguarmicro.com; > sta...@dpdk.org; Yang, Qiming ; Zhang, Qi Z > ; Kevin Liu > Subject: [PATCH 2/2] net/ice: fix TSO with big

[Bug 1291] Invalid pcapng timestamp

2023-09-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1291 Bug ID: 1291 Summary: Invalid pcapng timestamp Product: DPDK Version: 23.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal

RE: [EXT] [RFC] cryptodev: refactor sm2, add plain message flag

2023-09-20 Thread Gowrishankar Muthukrishnan
Hi, > Actually hash should be moved outside of xform, we do not want to have a > session per hash I think. > Session should be per key, eventually per private key only. > > If a hardware does not support hashing plain input before any SM2 op, It has to be first hashed in a separate session (based

[PATCH 4/4] pcapng: move timestamp calculation into pdump

2023-09-20 Thread Stephen Hemminger
The computation of timestamp is more easily done in pdump than pcapng. The initialization is easier and makes the pcapng library have no global state. It also makes it easier to add HW timestamp support later. Simplify the computation of nanoseconds from TSC to a two step process which avoids num

[PATCH 3/4] pcapng: change timestamp argument to write_stats

2023-09-20 Thread Stephen Hemminger
In order to cleanup the management of time base calculation, later patch will move the calculation from pcapng to the pdump library. One of the changes necessary is to move the timestamp calculation in the write_stats call from the pcapng library into the caller. Since dumpcap already does this for

[PATCH 2/4] dumpcap: allow multiple invocations

2023-09-20 Thread Stephen Hemminger
If dumpcap is run twice with each instance pointing a different interface, it would fail because of overlap in ring a pool names. Fix by putting process id in the name. Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") Reported-by: Isaac Boukris Signed-off-by: Stephen Hemmin

[PATCH 1/4] pdump: fix setting rte_errno on mp error

2023-09-20 Thread Stephen Hemminger
The response from MP server sets err_value to negative on error. The convention for rte_errno is to use a positive value on error. This makes errors like duplicate registration show up with the correct error value. Fixes: 660098d61f57 ("pdump: use generic multi-process channel") Signed-off-by: Ste

[PATCH 0/4] pcapng fixes

2023-09-20 Thread Stephen Hemminger
There were a couple of reported bugs in dumpcap around timestamps and multiple invocations. This patchset does some refactoring to fix them in a simpler way. Stephen Hemminger (4): pdump: fix setting rte_errno on mp error dumpcap: allow multiple invocations pcapng: change timestamp argument

RE: [PATCH v3 0/2] app/dma-perf: add SG copy support

2023-09-20 Thread Jiang, Cheng1
Hi, Sorry for the late reply. Generally I like your idea. But I might not be able to review in a timely manner, as I'm leaving Intel. If you're in a hurry, you might need to find someone else to help with the review. Thanks for your work, Cheng > -Original Message- > From: Gowrishankar

RE: [PATCH 2/2] app/dma-perf: add PCI device support

2023-09-20 Thread Jiang, Cheng1
Hi, > -Original Message- > From: Amit Prakash Shukla > Sent: Monday, August 7, 2023 9:06 PM > To: Jiang, Cheng1 > Cc: dev@dpdk.org; jer...@marvell.com; Amit Prakash Shukla > > Subject: [PATCH 2/2] app/dma-perf: add PCI device support > > Add support to test performance for "device to m

RE: [PATCH 1/2] app/dma-perf: skip support in dma-perf application

2023-09-20 Thread Jiang, Cheng1
Hi, > -Original Message- > From: Amit Prakash Shukla > Sent: Monday, August 7, 2023 9:06 PM > To: Jiang, Cheng1 > Cc: dev@dpdk.org; jer...@marvell.com; Amit Prakash Shukla > > Subject: [PATCH 1/2] app/dma-perf: skip support in dma-perf application > > Add support to skip running a dma-

Re: [PATCH 2/2] net/cnxk: separate callback for Rx flush on CN10k

2023-09-20 Thread Jerin Jacob
On Wed, Sep 20, 2023 at 5:01 PM Rahul Bhansali wrote: > > In dev stop case, Rx packet flush callback uses LMT lines to bulk free > of the meta buffers. If dev stop is called from non EAL core then LMT > address will not be valid. > To avoid this, A separate callback for Rx packets flush is added,

Re: [PATCH v1 1/7] eventdev: introduce DMA event adapter library

2023-09-20 Thread Jerin Jacob
On Tue, Sep 19, 2023 at 7:12 PM Amit Prakash Shukla wrote: > > Introduce event DMA adapter APIs. The change provides information > on adapter modes and usage. Application can use this event adapter > interface to transfer packets between DMA device and event device. > > Signed-off-by: Amit Prakash

RE: [PATCH v2] app/dma-perf: fix physical address seg-fault

2023-09-20 Thread Jiang, Cheng1
Hi, > -Original Message- > From: Vipin Varghese > Sent: Wednesday, August 16, 2023 5:42 PM > To: tho...@monjalon.net; dev@dpdk.org; ano...@marvell.com > Cc: ferruh.yi...@amd.com; Jiang, Cheng1 ; > sta...@dpdk.org > Subject: [PATCH v2] app/dma-perf: fix physical address seg-fault > > do_c

[PATCH v2 3/3] test/security: add unittest for inline ingress oop

2023-09-20 Thread Nithin Dabilpuram
Add unittest for inline ingress out-of-place processing. Signed-off-by: Nithin Dabilpuram --- app/test/test_cryptodev_security_ipsec.c | 8 +++ app/test/test_cryptodev_security_ipsec.h | 1 + app/test/test_security_inline_proto.c| 85 3 files changed, 94 insertions

[PATCH v2 2/3] net/cnxk: support inline ingress out of place session

2023-09-20 Thread Nithin Dabilpuram
Add support for inline ingress session with out-of-place support. Signed-off-by: Nithin Dabilpuram --- drivers/event/cnxk/cn10k_worker.h | 12 +- drivers/net/cnxk/cn10k_ethdev.c | 13 +- drivers/net/cnxk/cn10k_ethdev_sec.c | 43 +++ drivers/net/cnxk/cn10k_rx.h | 181

[PATCH v2 1/3] security: introduce out of place support for inline ingress

2023-09-20 Thread Nithin Dabilpuram
Similar to out of place(OOP) processing support that exists for Lookaside crypto/security sessions, Inline ingress security sessions may also need out of place processing in usecases where original encrypted packet needs to be retained for post processing. So for NIC's which have such a kind of HW

RE: [PATCH v5 00/11] update idpf base code

2023-09-20 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Wednesday, September 20, 2023 2:22 PM > To: Wu, Jingjing ; Xing, Beilei > ; > Zhang, Qi Z > Cc: dev@dpdk.org; Wu, Wenjun1 ; Liu, Mingxia > ; Qiao, Wenjing ; Su, Simei > > Subject: [PATCH v5 00/11] update idpf base code > > Currently, si

RE: [PATCH 1/1] net/mana: add 32 bit short doorbell

2023-09-20 Thread Long Li
> > Subject: RE: [PATCH 1/1] net/mana: add 32 bit short doorbell > > > > > > > +#ifdef RTE_ARCH_32 > > > > > + uint16_t cqe_incr = > > > > > +(uint16_t)rxq->gdma_cq.head_incr_to_short_db; > > > > > > > > How do you make sure head_incr_to_short_db doesn't overflow? > > > > > > > > > > I have che

Re: [PATCH v4 2/7] ethdev: support setting and querying RSS algorithm

2023-09-20 Thread Ajit Khaparde
On Wed, Sep 20, 2023 at 9:39 AM Ferruh Yigit wrote: > > On 9/8/2023 9:00 AM, Jie Hai wrote: > > Currently, rte_eth_rss_conf supports configuring and querying > > RSS hash functions, rss key and it's length, but not RSS hash > > algorithm. > > > > The structure ``rte_eth_rss_conf`` is extended by a

[PATCH v3] eventdev/eth_rx: fix timestamp field register in mbuf

2023-09-20 Thread Rahul Bhansali
For eventdev internal port, timestamp dynamic field registration in mbuf is not required as that will be done from net device. For SW eventdev, Rx timestamp field registration will be done during Rxa service initialization. Fixes: 83ab470d1259 ("eventdev/eth_rx: use timestamp as dynamic mbuf field

Re: [PATCH v4 2/7] ethdev: support setting and querying RSS algorithm

2023-09-20 Thread Ferruh Yigit
On 9/8/2023 9:00 AM, Jie Hai wrote: > Currently, rte_eth_rss_conf supports configuring and querying > RSS hash functions, rss key and it's length, but not RSS hash > algorithm. > > The structure ``rte_eth_rss_conf`` is extended by adding a new > field "func". This represents the RSS algorithms to

Re: [PATCH v4 1/7] ethdev: recomment some definitions related to RSS

2023-09-20 Thread Ferruh Yigit
On 9/8/2023 9:00 AM, Jie Hai wrote: > 1. Recomment fields of 'rte_eth_rss_conf'. > 2. Add comments for RTE_ETH_HASH_FUNCTION_DEFAULT. > > Signed-off-by: Jie Hai > --- > lib/ethdev/rte_ethdev.h | 28 +--- > lib/ethdev/rte_flow.h | 4 > 2 files changed, 17 insertion

[PATCH v2] eventdev/eth_rx: fix timestamp field register in mbuf

2023-09-20 Thread Rahul Bhansali
For eventdev internal port, timestamp dynamic field registration in mbuf is not required as that will be done from net device. For SW eventdev, Rx timestamp field registration will be done during Rxa service initialization. Fixes: 83ab470d1259 ("eventdev/eth_rx: use timestamp as dynamic mbuf field

RE: [PATCH] eventdev/eth_rx: fix timestamp field register in mbuf

2023-09-20 Thread Rahul Bhansali
> -Original Message- > From: Naga Harish K, S V > Sent: Wednesday, September 20, 2023 6:03 PM > To: Rahul Bhansali ; dev@dpdk.org; Jerin Jacob > Kollanukkaran ; Kundapura, Ganapati > > Cc: sta...@dpdk.org > Subject: [EXT] RE: [PATCH] eventdev/eth_rx: fix timestamp field register in >

[PATCH 6/6] Section 6: Glossary

2023-09-20 Thread David Young
--- doc/guides/getting_started_guide/glossary.rst | 75 +++ 1 file changed, 75 insertions(+) create mode 100644 doc/guides/getting_started_guide/glossary.rst diff --git a/doc/guides/getting_started_guide/glossary.rst b/doc/guides/getting_started_guide/glossary.rst new file mode

[PATCH 5/6] Section 5: Appendix

2023-09-20 Thread David Young
--- .../appendix/cross_compile_dpdk.rst | 37 +++ .../appendix/dpdk_meson_build_options.rst | 57 .../getting_started_guide/appendix/index.rst | 17 + .../running_dpdk_apps_without_root.rst| 36 +++ .../appendix/vfio_advanced.rst| 295 +++

[PATCH 4/6] Section 4: Running Applications

2023-09-20 Thread David Young
--- .../getting_started_guide/run_apps/index.rst | 10 ++ .../run_apps/run_apps.rst | 118 ++ 2 files changed, 128 insertions(+) create mode 100644 doc/guides/getting_started_guide/run_apps/index.rst create mode 100644 doc/guides/getting_started_guide/run_ap

[PATCH 3/6] Section 3: Setting up a System to Run DPDK Applications

2023-09-20 Thread David Young
--- .../getting_started_guide/system_setup.rst| 195 ++ 1 file changed, 195 insertions(+) create mode 100644 doc/guides/getting_started_guide/system_setup.rst diff --git a/doc/guides/getting_started_guide/system_setup.rst b/doc/guides/getting_started_guide/system_setup.rst n

[PATCH 2/6] Section 2: Install and Build DPDK

2023-09-20 Thread David Young
--- .../building_from_sources.rst | 108 ++ .../install_and_build/index.rst | 15 +++ .../installing_prebuilt_packages.rst | 54 + .../windows_install_build.rst | 93 +++ 4 files changed, 270 insertions(+

[PATCH 1/6] Section 1: Introduction

2023-09-20 Thread David Young
--- doc/guides/getting_started_guide/intro.rst | 16 1 file changed, 16 insertions(+) create mode 100644 doc/guides/getting_started_guide/intro.rst diff --git a/doc/guides/getting_started_guide/intro.rst b/doc/guides/getting_started_guide/intro.rst new file mode 100644 index 00

[PATCH 0/6] docs: Unify Getting Started Guides

2023-09-20 Thread David Young
The separate Getting Started Guides for Linux, FreeBSD, and Windows have been consolidated into a single, streamlined guide to simplify the user experience and facilitate easier maintenance. David Young (6): Section 1: Introduction Section 2: Install and Build DPDK Section 3: Setting up a

Re: [PATCH] maintainers: update email address

2023-09-20 Thread Patrick Robb
Recheck-request: iol-unit-amd64-testing A maintainers file change should not cause eal_flags_misc_autotest to fail, so I'm queuing a retest for this series.

Re: [PATCH v2 1/2] build: fix list_dir_globs failure in MSYS2

2023-09-20 Thread Bruce Richardson
On Wed, Sep 20, 2023 at 10:18:45PM +0800, Ric Li wrote: > When running 'meson setup' on Windows with MSYS2, > "list-dir-globs.py * failed with status 1". > > Avoid using globbing to get components for app build > since they are already listed in the meson file. > > Signed-off-by: Ric Li > --- A

[PATCH v2 2/2] doc: add MSYS2 building guide

2023-09-20 Thread Ric Li
Introduce guide for using MSYS2 to build DPDK on Windows. MSYS2 provides a Unix-like environment on Windows and its package manager simplifies tool and dependency installation, aiding Linux program migration. Signed-off-by: Ric Li --- doc/guides/windows_gsg/build_dpdk.rst | 36 ++

[PATCH v2 1/2] build: fix list_dir_globs failure in MSYS2

2023-09-20 Thread Ric Li
When running 'meson setup' on Windows with MSYS2, "list-dir-globs.py * failed with status 1". Avoid using globbing to get components for app build since they are already listed in the meson file. Signed-off-by: Ric Li --- app/meson.build | 18 +- 1 file changed, 9 insertions(+),

Re: [PATCH v5 0/2] replace master/slave to main/member

2023-09-20 Thread Ferruh Yigit
On 8/16/2023 7:27 AM, Chaoyong He wrote: > This patch series aims to replace all the master/slave to main/member > in the bonding PMD. > > --- > v5: > * Rebase to DPDK v23.11. > v4: > * Fix the doc compile problem. > v3: > * Fix the check warning about 'CamelCase'. > v2: > * Modify related doc. >

Re: [PATCH] net/virtio: fix descriptors buffer addresses on 32 bits builds

2023-09-20 Thread David Marchand
On Wed, Sep 20, 2023 at 3:02 PM Maxime Coquelin wrote: > > With Virtio-user, the Virtio descriptor buffer address is the > virtual address of the mbuf's buffer. On 32 bits builds, it is > expected to be 32 bits. > > With Virtio-PCI, the Virtio descriptor buffer address is the > physical address of

[PATCH v2 07/13] crypto/dpaa2_sec: enhance dpaa FD FL FMT offset set

2023-09-20 Thread Hemant Agrawal
From: Apeksha Gupta The macro DPAA2_SET_FLE_OFFSET(fle, offset) only works for masking the offset upto with 12 bits. When the offset value is more that 12 bits, this macro may over writing the FMT/SL/F bits which are beyond the offset bits. The FLE_ADDR is modified to FLE_ADDR + OFFSET, and the F

[PATCH v2 13/13] crypto/dpaax_sec: enable sha224-hmac support for IPsec

2023-09-20 Thread Hemant Agrawal
Enabling the SHA224 support in ipsec proto mode for dpaax drivers. Signed-off-by: Hemant Agrawal --- drivers/common/dpaax/caamflib/desc.h | 5 - drivers/common/dpaax/caamflib/desc/ipsec.h | 5 + drivers/common/dpaax/caamflib/rta/protocol_cmd.h | 5 - drivers/cryp

[PATCH v2 11/13] crypto/dpaa2_sec: add NAT-T support in IPsec offload

2023-09-20 Thread Hemant Agrawal
This patch adds supports for UDP encapsulation in NAT-T for IPSEC security protocol offload case. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 101 ++-- drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 3 + 2 files changed, 75 insertions(+), 29 d

[PATCH v2 12/13] crypto/dpaa2_sec: add support to set df and diffserv

2023-09-20 Thread Hemant Agrawal
This patch enables the ipsec protocol offload to copy DF and diffserv Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 32 + drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 2 ++ 2 files changed, 22 insertions(+), 12 deletions(-) diff --git a/dr

[PATCH v2 10/13] crypto/dpaa2_sec: enable esn support

2023-09-20 Thread Hemant Agrawal
LX216x suppots ESN. Also enable to correctly print the SEC era. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +- drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_s

[PATCH v2 09/13] crypto/dpaa2_sec: increase the anti replay window size

2023-09-20 Thread Hemant Agrawal
LX216x can support upto 1024 anti replay window size. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h index 0

[PATCH v2 08/13] crypto/dpaa2_sec: support copy df and dscp in proto offload

2023-09-20 Thread Hemant Agrawal
This patch adds support for enabling capability to copy dscp and df bits from inner to outer header and vice-versa. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 18 ++ drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 10 -- 2 files changed,

[PATCH v2 06/13] crypto/dpaax_sec: set the authdata in non-auth case

2023-09-20 Thread Hemant Agrawal
From: Gagandeep Singh The descriptors refers to auth data as well, so initializing it properly for the non-auth cases. Signed-off-by: Gagandeep Singh --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 16 drivers/crypto/dpaa_sec/dpaa_sec.c | 5 + 2 files changed,

[PATCH v2 05/13] crypto/dpaa_sec: supporting null cipher and auth

2023-09-20 Thread Hemant Agrawal
Adding NULL cipher and auth in capabilities. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa_sec/dpaa_sec.h | 42 +- 1 file changed, 41 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.h b/drivers/crypto/dpaa_sec/dpaa_sec.h index 412a

[PATCH v2 04/13] crypto/dpaa2_sec: supporting null cipher and auth

2023-09-20 Thread Hemant Agrawal
IPSEC proto offload support NULL in combo cases, thus adding NULL cipher and auth in security capabilities. Non-supported cases are already protected in the code. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 43 +-- 1 file changed, 41 insertio

[PATCH v2 02/13] common/dpaax: change mode to wait in shared desc

2023-09-20 Thread Hemant Agrawal
From: Gagandeep Singh In case of protocol based offload, it is better to wait before the share descriptor complete the execution. Simultaneous sharing may cause issues. Signed-off-by: Gagandeep Singh --- drivers/common/dpaax/caamflib/desc/pdcp.h | 82 +++ 1 file changed, 41

[PATCH v2 03/13] crypto/dpaa2_sec: initialize the pdcp alg to null

2023-09-20 Thread Hemant Agrawal
From: Vanshika Shukla This patch initializes the pdcp alg to null. Signed-off-by: Vanshika Shukla --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_

[PATCH v2 01/13] common/dpaax: update IPsec base descriptor length

2023-09-20 Thread Hemant Agrawal
From: Gagandeep Singh If all the keys are inlined, the descriptor would be 32 + 20 = 52 which is the size of the CURRENT shared descriptor created. So 32 * CAAM_CMD_SZ is the value that must be passed to rta_inline_query() for its "sd_base_len" parameter and drivers are using IPSEC_AUTH_VAR_AES_

[PATCH v2 00/13] crypto/dpaax_sec: misc enhancements

2023-09-20 Thread Hemant Agrawal
v2: compilation fixes This series include misc enhancements in dpaax_sec drivers. - improving the IPsec protocol offload features - enhancing PDCP protocol processing - code optimization and cleanup Apeksha Gupta (1): crypto/dpaa2_sec: enhance dpaa FD FL FMT offset set Gagandeep Singh (3):

Re: [PATCH v16 1/8] net/ntnic: initial commit which adds register defines

2023-09-20 Thread Thomas Monjalon
Hello, 19/09/2023 11:06, Christian Koue Muf: > On 9/18/23 10:34 AM, Ferruh Yigit wrote: > >On 9/15/2023 7:37 PM, Morten Brørup wrote: > >>> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > >>> Sent: Friday, 15 September 2023 17.55 > >>> > >>> On 9/8/2023 5:07 PM, Mykola Kostenok wrote: > Fr

Re: [PATCH v12 0/4] Recycle mbufs from Tx queue into Rx queue

2023-09-20 Thread Ferruh Yigit
On 8/24/2023 8:36 AM, Feifei Wang wrote: > Currently, the transmit side frees the buffers into the lcore cache and > the receive side allocates buffers from the lcore cache. The transmit > side typically frees 32 buffers resulting in 32*8=256B of stores to > lcore cache. The receive side allocates

Re: [PATCH v12 4/4] app/testpmd: add recycle mbufs engine

2023-09-20 Thread Ferruh Yigit
On 8/24/2023 8:36 AM, Feifei Wang wrote: > Add recycle mbufs engine for testpmd. This engine forward pkts with > I/O forward mode. But enable mbufs recycle feature to recycle used > txq mbufs for rxq mbuf ring, which can bypass mempool path and save > CPU cycles. > > Suggested-by: Jerin Jacob >

Re: [PATCH v12 1/4] ethdev: add API for mbufs recycle mode

2023-09-20 Thread Ferruh Yigit
On 8/24/2023 8:36 AM, Feifei Wang wrote: > Add 'rte_eth_recycle_rx_queue_info_get' and 'rte_eth_recycle_mbufs' > APIs to recycle used mbufs from a transmit queue of an Ethernet device, > and move these mbufs into a mbuf ring for a receive queue of an Ethernet > device. This can bypass mempool 'put/

Re: Commit broke 32-bit testpmd app

2023-09-20 Thread Maxime Coquelin
On 9/20/23 09:35, Maxime Coquelin wrote: Hi, I tried to reproduce without success(see attached log). I fail to reproduce because buf_iova fits into 32 bits in my case: (gdb) p /x *tx_pkts[0] $4 = {   cacheline0 = 0x77b19ec0,   buf_addr = 0x77b19f40,   buf_iova = 0x49519f40,   rearm_data

[PATCH] net/virtio: fix descriptors buffer addresses on 32 bits builds

2023-09-20 Thread Maxime Coquelin
With Virtio-user, the Virtio descriptor buffer address is the virtual address of the mbuf's buffer. On 32 bits builds, it is expected to be 32 bits. With Virtio-PCI, the Virtio descriptor buffer address is the physical address of the mbuf's buffer. On 32 bits builds running on 64 bits kernel, it i

[PATCH 1/2] ethdev: add group set miss actions API

2023-09-20 Thread Tomer Shmilovich
Introduce new group set miss actions API: rte_flow_group_set_miss_actions(). A group's miss actions are a set of actions to be performed in case of a miss on a group, meaning a packet didn't hit any rules in the group. This API function allows a user to set a group's miss actions. Signed-off-by:

[PATCH 2/2] app/testpmd: add group set miss actions CLI commands

2023-09-20 Thread Tomer Shmilovich
Add testpmd CLI interface for the group set miss actions API: flow group 0 group_id 1 ingress set_miss_actions jump group 3 / end flow group 0 group_id 1 ingress set_miss_actions end Signed-off-by: Tomer Shmilovich Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 112 +++

[PATCH 0/2] ethdev: add group set miss actions API

2023-09-20 Thread Tomer Shmilovich
Introduce new group set miss actions API: rte_flow_group_set_miss_actions(). A group's miss actions are a set of actions to be performed in case of a miss on a group, i.e. when a packet didn't hit any flow rules in the group. Currently, the expected behavior in this case is undefined. In order to

Re: [PATCH] net/nfp: fix invalid control message packets

2023-09-20 Thread Ferruh Yigit
On 7/13/2023 4:02 AM, Chaoyong He wrote: > From: Long Wu > > If we add two cards that uses flower firmware into one dpdk-testpmd, > NFP PMD will printf error log. The reason is that the second card > uses the control VNIC Rx queue of the first card. > > Because rte_eth_dma_zone_reserve() will re

RE: [PATCH] eventdev/eth_rx: fix timestamp field register in mbuf

2023-09-20 Thread Naga Harish K, S V
> -Original Message- > From: Rahul Bhansali > Sent: Monday, September 18, 2023 1:56 PM > To: dev@dpdk.org; Naga Harish K, S V ; Jerin > Jacob ; Kundapura, Ganapati > > Cc: Rahul Bhansali ; sta...@dpdk.org > Subject: [PATCH] eventdev/eth_rx: fix timestamp field register in mbuf > > For

[PATCH v2] testpmd: add hairpin-map parameter

2023-09-20 Thread Gregory Etelson
Testpmd hairpin implementation always sets the next valid port to complete hairpin binding. That limits hairpin configuration options. The new parameter allows explicit selection of Rx and Tx ports and queues in hairpin configuration. The new `hairpin-map` parameter is provided with 5 parameters,

Re:Re:Re: [PATCH v1] examples/l3fwd: relax the RSS/Offload requirement

2023-09-20 Thread taozj888
Hi Konstantin, Please see my comments inline Thanks. Trevor At 2023-09-20 16:04:41, "Konstantin Ananyev" wrote: > >Hi Trevor, > > >> >> At 2023-09-18 02:04:19, "Konstantin Ananyev" >> wrote: >>>03/09/2023 05:01, Trevor Tao пишет: Now the port Rx mq_mode had been set to RTE_ETH_MQ

RE: [RFC PATCH 2/3] security: add TLS record processing

2023-09-20 Thread Anoob Joseph
Hi Harry, Thanks for the review. Please see inline. Thanks, Anoob > -Original Message- > From: Van Haaren, Harry > Sent: Wednesday, September 20, 2023 2:53 PM > To: Anoob Joseph ; Thomas Monjalon > ; Akhil Goyal ; Jerin Jacob > Kollanukkaran ; Konstantin Ananyev > > Cc: Hemant Agrawal

[PATCH 13/13] net/nfp: cleanup the include statement of PMD

2023-09-20 Thread Chaoyong He
Remove the unneeded header file include statement of PMD source files, also adjust the include statement of 'nfp_rxtx' and 'nfp_flower_cmsg' module. Signed-off-by: Chaoyong He --- drivers/net/nfp/flower/nfp_flower.c | 2 -- drivers/net/nfp/flower/nfp_flower_cmsg.c | 1 - drivers

[PATCH 12/13] net/nfp: improve modularazation of CPP bridge module

2023-09-20 Thread Chaoyong He
Try to keep the API small by move the logic which need not expose from header file to source file verbatim. Also remove the unneeded header file include statement of source file. Signed-off-by: Chaoyong He --- drivers/net/nfp/nfp_cpp_bridge.c | 14 ++ drivers/net/nfp/nfp_cpp_bridge.h

[PATCH 10/13] net/nfp: improve modularazation of flow module

2023-09-20 Thread Chaoyong He
Make the header file self-containing by adding the correct include statement. Try to keep the API small by move the logic which need not expose from header file to source file verbatim and remove the unused macro. Also remove the unneeded header file include statement of source file. Signed-off-by

[PATCH 11/13] net/nfp: improve modularazation of meter module

2023-09-20 Thread Chaoyong He
Try to keep the API small by move the logic which need not expose from header file to source file verbatim. Also remove the unneeded header file include statement of source file. Signed-off-by: Chaoyong He --- drivers/net/nfp/nfp_mtr.c | 16 drivers/net/nfp/nfp_mtr.h | 2 -- 2

[PATCH 09/13] net/nfp: improve modularazation of flower cmsg module

2023-09-20 Thread Chaoyong He
Make the header file self-containing by adding the correct include statement. Try to keep the API small by move the logic which need not expose from header file to source file verbatim and remove the unused macro. Also remove the unneeded header file include statement of source file. Signed-off-by

[PATCH 08/13] net/nfp: improve modularazation of flower ctrl module

2023-09-20 Thread Chaoyong He
Make the header file self-containing by adding the correct include statement. Also remove the unneeded header file include statement of source file. Signed-off-by: Chaoyong He --- drivers/net/nfp/flower/nfp_flower_ctrl.c | 13 + drivers/net/nfp/flower/nfp_flower_ctrl.h | 2 ++ 2 fil

[PATCH 07/13] net/nfp: improve modularazation of flower representor module

2023-09-20 Thread Chaoyong He
Try to keep the API small by move the logic which need not expose from header file to source file verbatim. Also remove the unneeded header file include statement of source file. Signed-off-by: Chaoyong He --- .../net/nfp/flower/nfp_flower_representor.c | 29 --- .../net/nfp/fl

[PATCH 02/13] net/nfp: improve modularazation of rxtx module

2023-09-20 Thread Chaoyong He
Make the header file self-containing by adding the correct include statement. Try to keep the API small by move the logic which need not expose from header file to source file verbatim and move the macro to the right header file. Also remove the unneeded header file include statement of source file

[PATCH 06/13] net/nfp: improve modularazation of flower module

2023-09-20 Thread Chaoyong He
Make the header file self-containing by adding the correct include statement. Also remove the unneeded header file include statement of source file. Signed-off-by: Chaoyong He --- drivers/net/nfp/flower/nfp_flower.c | 24 ++-- drivers/net/nfp/flower/nfp_flower.h | 2 ++ 2 fi

[PATCH 05/13] net/nfp: improve modularazation of common module

2023-09-20 Thread Chaoyong He
Make the header file self-containing by adding the correct include statement. Try to keep the API small by move the logic which need not expose from header file to source file verbatim and remove the unused macro. Also remove the unneeded header file include statement of source file. Signed-off-by

[PATCH 03/13] net/nfp: improve modularazation of nfd3 module

2023-09-20 Thread Chaoyong He
Make the header file self-containing by adding the correct include statement. Try to keep the API small by move the logic which need not expose from header file to source file verbatim. Also remove the unneeded header file include statement of source file. Signed-off-by: Chaoyong He --- drivers/

[PATCH 04/13] net/nfp: improve modularazation of nfdk module

2023-09-20 Thread Chaoyong He
Make the header file self-containing by adding the correct include statement. Try to keep the API small by move the logic which need not expose from header file to source file verbatim. Also remove the unneeded header file include statement of source file. Signed-off-by: Chaoyong He --- drivers/

[PATCH 00/13] improve the modularization of NFP PMD

2023-09-20 Thread Chaoyong He
This patch series aims to improve the modularization of NFP PMD through: * Make the header files self-containing by adding the correct include statement. * Try to keep the interface of modules as small as possible. * Remove the unneeded include statements to make sure a clean dependent relation

[PATCH 01/13] net/nfp: make sure header file is self-containing

2023-09-20 Thread Chaoyong He
Make sure the header file 'nfp_ctrl.h' is self-containing by including 'stdint.h' header files to access the size specific integer types. Signed-off-by: Chaoyong He --- drivers/net/nfp/nfp_ctrl.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/nfp/nfp_ctrl.h b/drivers/net/nfp/n

Re: [PATCH v2 1/1] net/mana: enable 32 bit build for mana driver

2023-09-20 Thread Kevin Traynor
On 20/09/2023 11:03, Ferruh Yigit wrote: On 9/20/2023 4:06 AM, Wei Hu wrote: -Original Message- From: Ferruh Yigit Sent: Tuesday, September 19, 2023 7:05 PM To: Wei Hu ; dev@dpdk.org; Long Li Cc: sta...@dpdk.org; Kevin Traynor ; Luca Boccassi Subject: Re: [PATCH v2 1/1] net/mana: enab

RE: [PATCH 1/4] security: remove redundant cast

2023-09-20 Thread Akhil Goyal
> Subject: [PATCH 1/4] security: remove redundant cast > > The API 'rte_cryptodev_get_sec_ctx' returns void *. Type cast is not > required. > > Signed-off-by: Anoob Joseph > --- The changes in the series are part of https://patches.dpdk.org/project/dpdk/patch/20230920104000.2868230-1-gak...@mar

[PATCH v2] security: hide security context

2023-09-20 Thread Akhil Goyal
rte_security_ctx is used by all security APIs to identify which device security_op it need to call and hence it should be opaque to the application. Hence, it is now moved to internal header file and all APIs will now take an opaque pointer for it. The fast path inline APIs like set metadata need t

[PATCH 2/2] net/cnxk: separate callback for Rx flush on CN10k

2023-09-20 Thread Rahul Bhansali
In dev stop case, Rx packet flush callback uses LMT lines to bulk free of the meta buffers. If dev stop is called from non EAL core then LMT address will not be valid. To avoid this, A separate callback for Rx packets flush is added, which will use NPA aura free API on individual meta packets. Sig

[PATCH 1/2] common/cnxk: reserve last LMT line for control ops

2023-09-20 Thread Rahul Bhansali
As rte_eth_dev_configure() can be called from any EAL or non-EAL cores. And in case of non-EAL core, LMT address will not be a valid. So, reserving last LMT line 2047 for control path specific functionality. Signed-off-by: Rahul Bhansali --- drivers/common/cnxk/roc_dev.c | 5 + drivers

Re: [PATCH 0/1] make file prefix unit test more resilient

2023-09-20 Thread Bruce Richardson
On Wed, Sep 20, 2023 at 12:00:08PM +0200, David Marchand wrote: > On Thu, Sep 14, 2023 at 12:42 PM Bruce Richardson > wrote: > > > > When examining the IOL testing failures for patch series [1], I observed > > that the failures reported were in the eal_flags_file_prefix unit test. > > I was able t

Re: [PATCH v2 1/1] net/mana: enable 32 bit build for mana driver

2023-09-20 Thread Ferruh Yigit
On 9/20/2023 4:06 AM, Wei Hu wrote: >> -Original Message- >> From: Ferruh Yigit >> Sent: Tuesday, September 19, 2023 7:05 PM >> To: Wei Hu ; dev@dpdk.org; Long Li >> >> Cc: sta...@dpdk.org; Kevin Traynor ; Luca Boccassi >> >> Subject: Re: [PATCH v2 1/1] net/mana: enable 32 bit build for

Re: [PATCH v3] mbuf: add ESP packet type

2023-09-20 Thread Nithin Dabilpuram
On Mon, Aug 28, 2023 at 11:53 PM Alexander Kozyrev wrote: > > Support the IP Encapsulating Security Payload (ESP) in transport mode. As per IPSEC ESP RFC 4303, for both tunnel mode or transport mode, next proto 50, so we cannot identify a packet is for tunnel mode or transport mode by just packet

Re: [PATCH 0/1] make file prefix unit test more resilient

2023-09-20 Thread David Marchand
On Thu, Sep 14, 2023 at 12:42 PM Bruce Richardson wrote: > > When examining the IOL testing failures for patch series [1], I observed > that the failures reported were in the eal_flags_file_prefix unit test. > I was able to reproduce this on my system by passing an additional > "--on-pci" flag to

Re: [PATCH v5 00/26] refact the nfpcore module

2023-09-20 Thread Ferruh Yigit
On 9/19/2023 10:54 AM, Chaoyong He wrote: > This patch series aims to: > - Make the coding style satisfy with DPDK. > - Sync the logic with kernel driver. > - Make the sub-module more modular. > - Extend the nfp configure BAR from 8 to 24. > > --- > v5: > * Fix one bug in the logic of VF using dev

Re: [ADDENDUM] Technical board meeting agenda for 2023-09-20

2023-09-20 Thread Ferruh Yigit
On 9/19/2023 2:53 PM, Morten Brørup wrote: >> From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] >> Sent: Tuesday, 19 September 2023 11.51 >> >> Dear community, >> >> One topic was missed to be added to tomorrow's meeting agenda: >> >> On 9/18/23 22:20, Maxime Coquelin wrote: >>> Dear DPDK c

Re: [PATCH v16 1/8] net/ntnic: initial commit which adds register defines

2023-09-20 Thread Ferruh Yigit
On 9/19/2023 10:06 AM, Christian Koue Muf wrote: > On 9/18/23 10:34 AM, Ferruh Yigit wrote: >> On 9/15/2023 7:37 PM, Morten Brørup wrote: From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] Sent: Friday, 15 September 2023 17.55 On 9/8/2023 5:07 PM, Mykola Kostenok wrote: > From

Re: [PATCH v3 1/3] lib: introduce dispatcher library

2023-09-20 Thread Jerin Jacob
On Mon, Sep 18, 2023 at 5:26 AM Naga Harish K, S V wrote: > > > > > -Original Message- > > From: Mattias Rönnblom > > Sent: Monday, September 4, 2023 6:33 PM > > To: dev@dpdk.org > > Cc: Jerin Jacob ; techbo...@dpdk.org; Van Haaren, > > Harry ; hof...@lysator.liu.se; Nilsson, Peter > > ;

RE: [RFC PATCH 3/3] cryptodev: add details of datapath handling of TLS records

2023-09-20 Thread Van Haaren, Harry
> -Original Message- > From: Anoob Joseph > Sent: Friday, August 11, 2023 8:17 AM > To: Thomas Monjalon ; Akhil Goyal > ; Jerin Jacob ; Konstantin Ananyev > > Cc: Hemant Agrawal ; dev@dpdk.org; Matz, > Olivier ; Vidya Sagar Velumuri > > Subject: [RFC PATCH 3/3] cryptodev: add details of

RE: [RFC PATCH 2/3] security: add TLS record processing

2023-09-20 Thread Van Haaren, Harry
> -Original Message- > From: Anoob Joseph > Sent: Friday, August 11, 2023 8:17 AM > To: Thomas Monjalon ; Akhil Goyal > ; Jerin Jacob ; Konstantin Ananyev > > Cc: Hemant Agrawal ; dev@dpdk.org; Matz, > Olivier ; Vidya Sagar Velumuri > > Subject: [RFC PATCH 2/3] security: add TLS record p

RE: [RFC PATCH 1/3] net: add headers for TLS/DTLS packets

2023-09-20 Thread Van Haaren, Harry
> -Original Message- > From: Anoob Joseph > Sent: Friday, August 11, 2023 8:17 AM > To: Thomas Monjalon ; Akhil Goyal > ; Jerin Jacob ; Konstantin Ananyev > > Cc: Hemant Agrawal ; dev@dpdk.org; Matz, > Olivier ; Vidya Sagar Velumuri > > Subject: [RFC PATCH 1/3] net: add headers for TLS/D

  1   2   >