RE: [PATCH v11 16/16] eal: define priority based ctor dtor for MSVC

2023-09-24 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Friday, 11 August 2023 21.21 > > Provide RTE_INIT_PRIO and RTE_FINI_PRIO for MSVC allowing priority > based equivalents to __attribute__(({constructor,destructor}) > > Signed-off-by: Tyler Retzlaff > --- Acked-by: Morten Brøru

RE: [PATCH v11 15/16] eal: use standard ternary operator instead of GCC extension

2023-09-24 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Friday, 11 August 2023 21.21 > > Use standard ternary operator instead of gcc extension. There is > no concern of side-effects for this evaluation so allow the code > to be portable. > > While here update the condition to compar

RE: [PATCH v11 14/16] log: use standard ternary operator instead of GCC extension

2023-09-24 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Friday, 11 August 2023 21.21 > > Use standard ternary operator instead of gcc extension. There is > no concern of side-effects for this evaluation so allow the code > to be portable. > > While here update the condition to compar

[PATCH 10/10] net/nfp: destroy security session

2023-09-24 Thread Chaoyong He
From: Shihong Wang Delete SA from NIC and destroy security session. Signed-off-by: Shihong Wang Reviewed-by: Chaoyong He --- drivers/net/nfp/nfp_ipsec.c | 53 + 1 file changed, 53 insertions(+) diff --git a/drivers/net/nfp/nfp_ipsec.c b/drivers/net/nfp/nfp

[PATCH 09/10] net/nfp: support IPsec Rx and Tx offload

2023-09-24 Thread Chaoyong He
From: Shihong Wang The Rx path checks the ipsec metadata and base on the crypto status sets ol_flags in the rte_mbuf. The Tx path write IPsec message to mbuf metadata based on mbuf dynamic field. Signed-off-by: Shihong Wang Signed-off-by: Chang Miao Reviewed-by: Chaoyong He --- doc/guides/n

[PATCH 08/10] net/nfp: update security session

2023-09-24 Thread Chaoyong He
From: Shihong Wang Update the configuration information in priv_session when the configuration parameters of sess_conf change. Signed-off-by: Shihong Wang Reviewed-by: Chaoyong He --- drivers/net/nfp/nfp_ipsec.c | 25 + 1 file changed, 25 insertions(+) diff --git a/dr

[PATCH 07/10] net/nfp: create security session

2023-09-24 Thread Chaoyong He
From: Chang Miao Create security session to manage IPsec protocol specific message and crypto parameters. This session support full protocol offload and inline crypto operation with NIC devices. Signed-off-by: Chang Miao Signed-off-by: Shihong Wang Reviewed-by: Chaoyong He --- drivers/net/nf

[PATCH 06/10] net/nfp: get IPsec Rx/Tx packet statistics

2023-09-24 Thread Chaoyong He
From: Shihong Wang IPsec packet processing is mostly carried out in hardware. The hardware statistics on successful packets and discarded packets. The driver can obtain these statistics by Mailbox. Signed-off-by: Shihong Wang Reviewed-by: Chaoyong He --- drivers/net/nfp/nfp_ipsec.c | 149

[PATCH 05/10] net/nfp: get security capabilities and session size

2023-09-24 Thread Chaoyong He
From: Shihong Wang Add full protocol offload as well as inline crypto IPsec capabilities and return these for rte_security. Return size of security session for rte_security. Signed-off-by: Shihong Wang Reviewed-by: Chaoyong He --- drivers/net/nfp/nfp_ipsec.c | 357 +++

[PATCH 04/10] net/nfp: initialize IPsec related content

2023-09-24 Thread Chaoyong He
From: Chang Miao If enable IPsec capability bit, driver need to Initialize IPsec. Set security context and security offload capabilities in datapath. Define private session and add SA array for each PF to save all SA data in driver. Add internal mbuf dynamic flag and field to save IPsec related d

[PATCH 03/10] net/nfp: add mailbox to support IPsec offload

2023-09-24 Thread Chaoyong He
From: Shihong Wang Add general use per-vNIC mailbox area and use it for IPsec SA offload support and get Rx/Tx packet statistics. Signed-off-by: Shihong Wang Signed-off-by: Chang Miao Reviewed-by: Chaoyong He --- drivers/net/nfp/nfp_common.c | 41 drivers

[PATCH 02/10] net/nfp: add TLVs capability parsing

2023-09-24 Thread Chaoyong He
From: Shihong Wang Add TLV capabilities to the BAR, TLVs is fit for expressing capabilities of applications running on programmable hardware. Declares a TLV capability start at offset 0x58, up to 0x0d90. The used space can be wrapped with RESERVED. Signed-off-by: Shihong Wang Signed-off-by: Cha

[PATCH 01/10] mailmap: update contributor entry

2023-09-24 Thread Chaoyong He
From: Shihong Wang Add contributor entries to .mailmap file. Signed-off-by: Shihong Wang Reviewed-by: Chaoyong He --- .mailmap | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.mailmap b/.mailmap index 276325211c..5abd5810e2 100644 --- a/.mailmap +++ b/.mailmap @@ -200,6 +200,7 @@ Caroly

[PATCH 00/10] add the support of ipsec offload

2023-09-24 Thread Chaoyong He
This patch series add the support of ipsec offload feature, includes: * Implement the communication channel between PMD and firmware through mailbox. * Implement the ipsec offload related APIs based the security framework. * Implement the ipsec packets process logics in the data path. Chang Miao

Re: [PATCH v13 1/4] ethdev: add API for mbufs recycle mode

2023-09-24 Thread Ajit Khaparde
On Sun, Sep 24, 2023 at 8:19 PM Feifei Wang wrote: > > Add 'rte_eth_recycle_rx_queue_info_get' and 'rte_eth_recycle_mbufs' > APIs to recycle used mbufs from a transmit queue of an Ethernet device, > and move these mbufs into a mbuf ring for a receive queue of an Ethernet > device. This can bypass

RE: [PATCH v11 2/4] net/i40e: implement mbufs recycle mode

2023-09-24 Thread Feifei Wang
For Konstantin > -Original Message- > From: Feifei Wang > Sent: Saturday, September 23, 2023 1:52 PM > To: Konstantin Ananyev ; Konstantin > Ananyev > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; Ruifeng Wang > ; Yuying Zhang ; Beilei > Xing ; nd ; nd ; nd > ; nd ; nd ; nd ; > nd ; nd

[PATCH v13 4/4] app/testpmd: add recycle mbufs engine

2023-09-24 Thread Feifei Wang
Add recycle mbufs engine for testpmd. This engine forward pkts with I/O forward mode. But enable mbufs recycle feature to recycle used txq mbufs for rxq mbuf ring, which can bypass mempool path and save CPU cycles. Suggested-by: Jerin Jacob Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang -

[PATCH v13 3/4] net/ixgbe: implement mbufs recycle mode

2023-09-24 Thread Feifei Wang
Define specific function implementation for ixgbe driver. Currently, recycle buffer mode can support 128bit vector path. And can be enabled both in fast free and no fast free mode. Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Naga

[PATCH v13 2/4] net/i40e: implement mbufs recycle mode

2023-09-24 Thread Feifei Wang
Define specific function implementation for i40e driver. Currently, mbufs recycle mode can support 128bit vector path and avx2 path. And can be enabled both in fast free and no fast free mode. Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: H

[PATCH v13 1/4] ethdev: add API for mbufs recycle mode

2023-09-24 Thread Feifei Wang
Add 'rte_eth_recycle_rx_queue_info_get' and 'rte_eth_recycle_mbufs' APIs to recycle used mbufs from a transmit queue of an Ethernet device, and move these mbufs into a mbuf ring for a receive queue of an Ethernet device. This can bypass mempool 'put/get' operations hence saving CPU cycles. For eac

[PATCH v13 0/4] Recycle mbufs from Tx queue into Rx queue

2023-09-24 Thread Feifei Wang
Currently, the transmit side frees the buffers into the lcore cache and the receive side allocates buffers from the lcore cache. The transmit side typically frees 32 buffers resulting in 32*8=256B of stores to lcore cache. The receive side allocates 32 buffers and stores them in the receive side so

Re: [PATCH 0/5] net/hns3: some performance optimizations

2023-09-24 Thread Jie Hai
Hi, all maintainers, Kindly ping for patch 2/5-5/5. Best regards, Jie Hai On 2023/7/11 18:24, Dongdong Liu wrote: This patchset is to do some performance optimizations for hns3. Huisong Li (5): net/hns3: fix incorrect index to look up table in NEON Rx net/hns3: fix the order of NEON Rx

[PATCH v4 4/5] net/ice: refine supported flow pattern name

2023-09-24 Thread Qi Zhang
Unified the supported pattern array name as ice__supported_pattern. Signed-off-by: Qi Zhang --- drivers/net/ice/ice_acl_filter.c| 6 +++--- drivers/net/ice/ice_fdir_filter.c | 6 +++--- drivers/net/ice/ice_switch_filter.c | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff -

[PATCH v4 5/5] doc: add generic flow doc for ice PMD

2023-09-24 Thread Qi Zhang
Add some document about how to use rte_flow on ice PMD. Signed-off-by: Qi Zhang --- doc/guides/nics/ice.rst | 45 + 1 file changed, 45 insertions(+) diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index 5a47109c3f..b36a4c260a 100644 --- a/d

[PATCH v4 3/5] net/ice: map group to pipeline stage

2023-09-24 Thread Qi Zhang
Mapping rte_flow_attr->group to a specific hardware stage. Group 0 -> switch filter Group 1 -> acl filter (dcf mode only) Group 2 -> fdir filter (pf mode only) For RSS, it will only be selected if there is a RTE_FLOW_ACTION_RSS action target no queue group and the group ID is ignored. Since each

[PATCH v4 2/5] net/ice: refine flow engine disabling

2023-09-24 Thread Qi Zhang
Only "disable_engine_mask" for flow engine disabling In PF mode, only ACL engine will be disabled. In DCF mode, FDIR and HASH engine will be disabled. In DCF mode with "acl=off", ACL engine will also be disabled. Signed-off-by: Qi Zhang --- drivers/net/ice/ice_acl_filter.c | 3 --- drivers/net

[PATCH v4 1/5] net/ice: remove pipeline mode

2023-09-24 Thread Qi Zhang
This marks the initial phase of refactoring the ice rte_flow implementation. The combination of switch and fdir rules within the same syntax has led to inconvenient user experiences. Naturally, the switch filter and fdir filter represent distinct pipeline stages with differing hardware capabilitie

[PATCH v4 0/5] net/ice: refactor rte_flow

2023-09-24 Thread Qi Zhang
1. remove pipeline mode 2. apply group to hardware pipeline stage static mapping 3. add genenic flow document v4: - fix error handling when target engine was disabled. v3: - fix the issue when acl=off on dcf mode - refine the disabled engine handling - unified the supported pattern variable name

[PATCH v2 5/5] net/mlx5: add support for item NSH

2023-09-24 Thread Haifei Luo
1. Add validation for item NSH. It will fail if HCA cap for NSH is false. 2. Add item_flags for NSH. 3. For vxlan-gpe if next header is NSH, set next_protocol as NSH. Signed-off-by: Haifei Luo Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow.c| 39 ++

[PATCH v2 4/5] app/testpmd: support for NSH flow item

2023-09-24 Thread Haifei Luo
Add support for item NSH. The CLI is: nsh Example: flow create 0 transfer group 1 pattern eth / ipv6 / udp dst is 4790 / vxlan-gpe / nsh / eth / ipv4 / tcp / end actions port_id id 1 / end Signed-off-by: Haifei Luo Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow

[PATCH v2 3/5] net/mlx5: enhance the validation for item VXLAN-GPE

2023-09-24 Thread Haifei Luo
Enhance the validation so that configuring vxlan-gpe's next protocol as NSH is supported. 1. The spec's protocol can have value and nic_mask's protocol is 0xff. Signed-off-by: Haifei Luo Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow.c | 13 ++--- 1 file changed, 6 insertio

[PATCH v2 2/5] common/mlx5: extend HCA attribute query for NSH

2023-09-24 Thread Haifei Luo
Add NSH supporting field in two places: 1. New HCA capability indicating NSH is supported 2. New field in "mlx5_ifc_per_protocol_networking_offload_caps_bits" structure Signed-off-by: Haifei Luo Acked-by: Dariusz Sosnowski --- drivers/common/mlx5/mlx5_devx_cmds.c | 3 +++ drivers/common/mlx5

[PATCH v2 1/5] app/testpmd: support for VXLAN-GPE's next protocol

2023-09-24 Thread Haifei Luo
Add support for configuring VXLAN-GPE's next protocol. The CLI is: vxlan-gpe protocol is . Example: flow create 0 transfer group 1 pattern eth / ipv6 / udp dst is 4790 / vxlan-gpe protocol is 0x04 / eth / ipv4 / tcp / end actions port_id id 1 / end Signed-off-by: Jiawei Wang Signed-off-by: Haif

[PATCH v2 0/5] support item NSH matching

2023-09-24 Thread Haifei Luo
NSH can be matched using the existed item: RTE_FLOW_ITEM_TYPE_NSH. NSH fields matching is not supported. Add support for configuring VXLAN-GPE's next protocol. The CLI is: vxlan-gpe protocol is . Add support for matching item NSH. The CLI is: nsh Add support for HCA attribute query of NSH. Enh

RE: [PATCH 00/13] improve the modularization of NFP PMD

2023-09-24 Thread Chaoyong He
> On 9/20/2023 12:34 PM, Chaoyong He wrote: > > This patch series aims to improve the modularization of NFP PMD through: > > * Make the header files self-containing by adding the correct include > > statement. > > * Try to keep the interface of modules as small as possible. > > * Remove the unnee

Re: [PATCH v4 4/7] app/proc-info: fix never show RSS info

2023-09-24 Thread Jie Hai
On 2023/9/13 19:48, Pattan, Reshma wrote: -Original Message- From: Jie Hai Sent: Friday, September 8, 2023 9:00 AM To: dev@dpdk.org; Pattan, Reshma ; Vipin Varghese ; Mcnamara, John Cc: haij...@huawei.com; lihuis...@huawei.com Subject: [PATCH v4 4/7] app/proc-info: fix never show RSS

[PATCH v3] net/mlx5: reuse reformat and modify header actions in a table

2023-09-24 Thread Gregory Etelson
If application defined several actions templates with non-shared reformat or modify headers actions AND used these templates to create a table, HWS could share reformat or modify headers resources, instead of creating a resource for each action template. The patch activates HWS code in a way that

[PATCH v4 2/2] app/dma-perf: add SG copy support

2023-09-24 Thread Gowrishankar Muthukrishnan
Add SG copy support. Signed-off-by: Gowrishankar Muthukrishnan --- app/test-dma-perf/benchmark.c | 243 +- app/test-dma-perf/config.ini | 17 +++ app/test-dma-perf/main.c | 34 - app/test-dma-perf/main.h | 5 +- 4 files changed, 260 insertions(+

[PATCH v4 1/2] app/dma-perf: validate copied memory

2023-09-24 Thread Gowrishankar Muthukrishnan
Validate copied memory to ensure DMA copy did not fail. Fixes: 623dc9364dc ("app/dma-perf: introduce DMA performance test") Signed-off-by: Gowrishankar Muthukrishnan --- app/test-dma-perf/benchmark.c | 24 ++-- app/test-dma-perf/main.c | 16 +++- app/test-dm

[PATCH v4 0/2] app/dma-perf: add SG copy support

2023-09-24 Thread Gowrishankar Muthukrishnan
Add SG copy support in dma-perf application. v4: - improvement in buffer allocation for perf validation. Gowrishankar Muthukrishnan (2): app/dma-perf: validate copied memory app/dma-perf: add SG copy support app/test-dma-perf/benchmark.c | 251 ++ app/test-d

RE: [PATCH 04/15] crypto/cnxk: fix private key length in ECDSA param

2023-09-24 Thread Akhil Goyal
> Subject: [PATCH 04/15] crypto/cnxk: fix private key length in ECDSA param > > From: Gowrishankar Muthukrishnan > > Fix private key length in ECDSA op param to include alignment, > for new microcode. > > Signed-off-by: Gowrishankar Muthukrishnan Add fixes tag.

RE: [PATCH 13/15] crypto/cnxk: add support for raw APIs

2023-09-24 Thread Akhil Goyal
> Subject: [PATCH 13/15] crypto/cnxk: add support for raw APIs > > From: Anoob Joseph > > Add crypto RAW API support in cnxk PMD > Enable the flag to allow execution of raw test suite. > > Signed-off-by: Vidya Sagar Velumuri > Signed-off-by: Anoob Joseph > --- > drivers/crypto/cnxk/cn10k_cry