[PATCH v3 25/25] doc: add a entry in the release notes

2023-10-25 Thread Chaoyong He
Add a entry for the NFP vDPA PMD in the release notes. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- doc/guides/rel_notes/release_23_11.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/rele

[PATCH v3 24/25] vdpa/nfp: add nfp vDPA device operations

2023-10-25 Thread Chaoyong He
Implement the corresponding nfp vDPA operation functions. Signed-off-by: Shujing Dong Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/vdpa/nfp/nfp_vdpa.c | 213 1 file changed, 213 insertions(+) diff --git a/drivers/vdp

[PATCH v3 23/25] vdpa/nfp: add the notify related logic

2023-10-25 Thread Chaoyong He
Add the logic to process vDPA notify relay. Signed-off-by: Chaoyong He Signed-off-by: Shujing Dong Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/vdpa/nfp/nfp_vdpa.c | 155 +++ drivers/vdpa/nfp/nfp_vdpa_core.c | 61 drivers/vdpa/nfp/nfp

[PATCH v3 22/25] drivers: add the datapath update logic

2023-10-25 Thread Chaoyong He
Add the vDPA datapath update logic. Signed-off-by: Chaoyong He Signed-off-by: Shujing Dong Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/nfp_common_ctrl.h | 1 + drivers/vdpa/nfp/nfp_vdpa.c | 318 +++ drivers/vdpa/nfp/nfp_vdpa_core.c

[PATCH v3 21/25] vdpa/nfp: add the hardware init logic

2023-10-25 Thread Chaoyong He
Add the hardware initialize logic. Signed-off-by: Chaoyong He Signed-off-by: Shujing Dong Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/vdpa/nfp/meson.build | 1 + drivers/vdpa/nfp/nfp_vdpa.c | 10 ++ drivers/vdpa/nfp/nfp_vdpa_core.c | 54 +

[PATCH v3 20/25] vdpa/nfp: add the logic of remap PCI memory

2023-10-25 Thread Chaoyong He
Add the logic of remap PCI memory. Signed-off-by: Chaoyong He Signed-off-by: Shujing Dong Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/vdpa/nfp/nfp_vdpa.c | 65 - 1 file changed, 64 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/nfp/nfp

[PATCH v3 19/25] drivers: add the basic framework of vDPA PMD

2023-10-25 Thread Chaoyong He
Add the basic framework of vDPA PMD. Signed-off-by: Chaoyong He Signed-off-by: Shujing Dong Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/nfp_common_pci.c | 1 + drivers/common/nfp/nfp_common_pci.h | 1 + drivers/vdpa/nfp/meson.build| 3 +- drivers/vdpa/nfp

[PATCH v3 18/25] drivers/vdpa: introduce the NFP vDPA library

2023-10-25 Thread Chaoyong He
Introduce the very basic NFP vDPA library. Signed-off-by: Shujing Dong Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- MAINTAINERS | 6 doc/guides/vdpadevs/features/nfp.ini | 8 + doc/guides/vdpadevs/index.rst| 1 + doc/

[PATCH v3 17/25] drivers: move device module to common library

2023-10-25 Thread Chaoyong He
Move the device module to the common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/meson.build| 1 + drivers/{net/nfp/nfpcore => common/nfp}/nfp_dev.c | 0 drivers/{net/nfp/nfpcore => common/nfp}/nfp_dev.h | 3 +++ d

[PATCH v3 16/25] drivers: move platform module to common library

2023-10-25 Thread Chaoyong He
Move the platform module to the common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/{net/nfp/nfpcore => common/nfp}/nfp_platform.h | 0 drivers/net/nfp/nfdk/nfp_nfdk_dp.c | 2 +- drivers/net/nfp/nfp_net_ctrl.c

[PATCH v3 15/25] drivers: move queue logic to common module

2023-10-25 Thread Chaoyong He
Move the queue enable/disable logic to the common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/nfp_common.c | 49 drivers/common/nfp/nfp_common.h | 7 + drivers/common/nfp/version.map | 2 ++

[PATCH v3 13/25] drivers: add the common ctrl module

2023-10-25 Thread Chaoyong He
Add the common ctrl module. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/nfp_common_ctrl.h | 374 +++ drivers/net/nfp/nfp_net_ctrl.h | 365 +- 2 files changed, 375 insertions(+), 364 deletio

[PATCH v3 14/25] drivers: add the nfp common module

2023-10-25 Thread Chaoyong He
Add the nfp common module in the nfp common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/meson.build | 3 +- drivers/common/nfp/nfp_common.c | 177 +++ drivers/common/nfp/nfp_common.h | 232 +++

[PATCH v3 12/25] net/nfp: rename parameter in related logic

2023-10-25 Thread Chaoyong He
Rename parameter 'hw' into 'net_hw' in the related logic, to make the name more accurate. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 8 +-- drivers/net/nfp/nfp_ethdev.c| 86 +++ drivers/net/nf

[PATCH v3 11/25] net/nfp: extract the MAC address data field

2023-10-25 Thread Chaoyong He
Extract the 'mac_addr' data filed into the super class, prepare for the upcoming common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_ethdev.c | 14 +++--- drivers/net/nfp/nfp_ethdev_vf.c | 18 +- drivers/n

[PATCH v3 10/25] net/nfp: change the parameter of reconfig

2023-10-25 Thread Chaoyong He
Extract the 'reconfig_lock' data field into the super class, also change the parameter of the related APIs, prepare for the upcoming common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 50 + drivers/net/nfp/

[PATCH v3 09/25] net/nfp: change the parameter of APIs

2023-10-25 Thread Chaoyong He
Change the parameter of some APIs from 'struct nfp_net_hw' into the super class 'struct nfp_hw', prepare for the upcoming common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 24 ++-- .../net/nfp/flower/nfp

[PATCH v3 08/25] net/nfp: extract the ctrl data field

2023-10-25 Thread Chaoyong He
Extract the 'ctrl' data filed into the super class, prepare for the upcoming common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 8 ++--- drivers/net/nfp/nfd3/nfp_nfd3_dp.c | 2 +- drivers/net/nfp/nfdk/nfp_nfdk_dp

[PATCH v3 07/25] net/nfp: extract the ctrl BAR data field

2023-10-25 Thread Chaoyong He
Extract the 'ctrl_bar' data filed into the super class, prepare for the upcoming common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 8 drivers/net/nfp/nfp_ethdev.c| 14 +++--- drivers/net/n

[PATCH v3 06/25] net/nfp: extract the qcp data field

2023-10-25 Thread Chaoyong He
Extract the 'qcp_cfg' data field into the super class, prepare for the upcoming common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_net_common.c | 8 drivers/net/nfp/nfp_net_common.h | 2 +- 2 files changed, 5 insertions(+),

[PATCH v3 05/25] net/nfp: extract the cap data field

2023-10-25 Thread Chaoyong He
Extract the 'cap' and 'cap_ext' data field into the super class, ready for the upcoming common library. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 6 +- drivers/net/nfp/nfd3/nfp_nfd3_dp.c | 12 ++-- drivers/net/nfp/nfdk/n

[PATCH v3 04/25] net/nfp: rename ctrl module name

2023-10-25 Thread Chaoyong He
Rename the 'nfp_ctrl' module into 'nfp_net_ctrl' module, because which is more suitable and we will add 'nfp_common_ctrl' module in the 'drivers/common/nfp' directory. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/meson.build| 2

[PATCH v3 03/25] net/nfp: rename common module name

2023-10-25 Thread Chaoyong He
Rename the 'nfp_common' module into 'nfp_net_common' module, because which is more suitable and we will add 'nfp_common' module in the 'drivers/common/nfp' directory. Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.h

[PATCH v3 02/25] net/nfp: make VF PMD using of NFP common module

2023-10-25 Thread Chaoyong He
Modify the logic of NFP VF PMD, make it using of the NFP common module and link into the 'nfp_drivers_list'. Signed-off-by: Chaoyong He Signed-off-by: Shujing Dong Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/meson.build | 2 +- drivers/net/nfp/nfp_ethdev_vf.c | 14 ++

[PATCH v3 01/25] drivers: introduce the NFP common library

2023-10-25 Thread Chaoyong He
A new NFP vdpa PMD will be added to support vdpa operations by NFP adapters. This vdpa PMD share some logic with the net/nfp PMD. So create a new common library in drivers/common for NFP PMDs. We import a 'nfp_class_driver' layer and which can support various device type in addition to the ethern

[PATCH v3 00/25] add the NFP vDPA PMD

2023-10-25 Thread Chaoyong He
This patch series aims to add the NFP vDPA PMD, we also grab the common logic into the `drivers/common/nfp` directory. --- v3: * Replace 'pthread_xxx' API with 'rte_thread_xxx' API. * Replace '__atomic_xxx' built-ins with 'rte_atomic_xxx'. * Drop the check statement in meson.build file which preve

RE: [PATCH] ethdev: fix ESP packet type description

2023-10-25 Thread Morten Brørup
> From: Alexander Kozyrev [mailto:akozy...@nvidia.com] > Sent: Wednesday, 25 October 2023 22.32 > > The correct protocol number for ESP (IP Encapsulating Security Payload) > packet type is 50. 51 is IPSec AH (Authentication Header). > > Fixes: 1e84afd3906b ("mbuf: add security crypto flags and fi

RE: [PATCH v2 09/19] rcu: use rte optional stdatomic API

2023-10-25 Thread Ruifeng Wang
> -Original Message- > From: Tyler Retzlaff > Sent: Thursday, October 26, 2023 6:38 AM > To: Ruifeng Wang > Cc: dev@dpdk.org; Akhil Goyal ; Anatoly Burakov > ; Andrew Rybchenko > ; Bruce > Richardson ; Chenbo Xia ; > Ciara Power > ; David Christensen ; David > Hunt > ; Dmitry Kozlyuk ;

[PATCH v2] test/cryptodev: add modexp group tests

2023-10-25 Thread Gowrishankar Muthukrishnan
Add modexp tests for groups 5, 14, 15, 16, 17 and 18. Signed-off-by: Gowrishankar Muthukrishnan --- v2: - rebase on main --- app/test/test_cryptodev_asym.c | 48 + app/test/test_cryptodev_mod_test_vectors.h | 989 - 2 files changed, 1036 insertions(+), 1 deletio

RE: [PATCH v2 00/25] add the NFP vDPA PMD

2023-10-25 Thread Chaoyong He
> > On 10/24/2023 3:28 AM, Chaoyong He wrote: > > > This patch series aims to add the NFP vDPA PMD, we also grab the > > > common logic into the `drivers/common/nfp` directory. > > > > > > --- > > > v2: > > > * Grab more logic into the `drivers/common/nfp` directory. > > > * Delete some logic which

RE: [PATCH v2 25/25] doc: add the common and vDPA document

2023-10-25 Thread Chaoyong He
> On 10/24/2023 3:28 AM, Chaoyong He wrote: > > Add the document for nfp common library and vDPA PMD. > > > > Can you please distribute this patch to other patches in set, details below. > > > Signed-off-by: Chaoyong He > > Reviewed-by: Long Wu > > Reviewed-by: Peng Zhang > > --- > > MAINTAIN

RE: [PATCH v2 19/25] drivers: add the basic framework of vDPA PMD

2023-10-25 Thread Chaoyong He
> On 10/24/2023 3:28 AM, Chaoyong He wrote: > > Add the basic framework of vDPA PMD. > > > > Signed-off-by: Chaoyong He > > Signed-off-by: Shujing Dong > > Reviewed-by: Long Wu > > Reviewed-by: Peng Zhang > > <...> > > > @@ -12,5 +12,12 @@ if not dpdk_conf.has('RTE_LIB_VHOST') endif > > > >

RE: [PATCH v2 18/25] drivers/vdpa: introduce the NFP vDPA library

2023-10-25 Thread Chaoyong He
> On 10/24/2023 3:28 AM, Chaoyong He wrote: > > Introduce the very basic NFP vDPA library. > > > > Signed-off-by: Shujing Dong > > Signed-off-by: Chaoyong He > > Reviewed-by: Long Wu > > Reviewed-by: Peng Zhang > > <...> > > > --- /dev/null > > +++ b/drivers/vdpa/nfp/meson.build > > @@ -0,0 +

RE: [PATCH v2 02/25] net/nfp: make VF PMD using of NFP common module

2023-10-25 Thread Chaoyong He
> On 10/24/2023 3:28 AM, Chaoyong He wrote: > > Modify the logic of NFP VF PMD, make it using of the NFP common module > > and link into the 'nfp_drivers_list'. > > > > Signed-off-by: Chaoyong He > > Signed-off-by: Shujing Dong > > Reviewed-by: Long Wu > > Reviewed-by: Peng Zhang > > --- > > d

RE: [PATCH v2 00/25] add the NFP vDPA PMD

2023-10-25 Thread Chaoyong He
> On 10/24/2023 3:28 AM, Chaoyong He wrote: > > This patch series aims to add the NFP vDPA PMD, we also grab the > > common logic into the `drivers/common/nfp` directory. > > > > --- > > v2: > > * Grab more logic into the `drivers/common/nfp` directory. > > * Delete some logic which should be when

[PATCH v3 19/19] ring: use rte optional stdatomic API

2023-10-25 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- drivers/net/mlx5/mlx5_hws_cnt.h | 4 ++-- lib/ring/rte_ring_c11_pvt.h | 47 +-- lib/ring/rte_ring_core.h

[PATCH v3 13/19] vhost: use rte optional stdatomic API

2023-10-25 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/vhost/vdpa.c| 3 ++- lib/vhost/vhost.c | 42 lib/vhost/vhost.h | 39

[PATCH v3 18/19] timer: use rte optional stdatomic API

2023-10-25 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/timer/rte_timer.c | 50 +- lib/timer/rte_timer.h | 6 +++--- 2 files changed, 28 insertions(+), 2

[PATCH v3 16/19] ethdev: use rte optional stdatomic API

2023-10-25 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/ethdev/ethdev_driver.h | 16 lib/ethdev/ethdev_private.c | 6 +++--- lib/ethdev/rte_ethdev.c | 24 --

[PATCH v3 14/19] cryptodev: use rte optional stdatomic API

2023-10-25 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/cryptodev/rte_cryptodev.c | 22 -- lib/cryptodev/rte_cryptodev.h | 16 2 files changed, 20 insertions(+), 18

[PATCH v3 12/19] telemetry: use rte optional stdatomic API

2023-10-25 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/telemetry/telemetry.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/telemetry/telemetry.c b/lib/telem

[PATCH v3 11/19] stack: use rte optional stdatomic API

2023-10-25 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/stack/rte_stack.h| 2 +- lib/stack/rte_stack_lf_c11.h | 24 lib/stack/rte_stack_lf_generic.h | 18 ++

[PATCH v3 17/19] hash: use rte optional stdatomic API

2023-10-25 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/hash/rte_cuckoo_hash.c | 116 ++--- lib/hash/rte_cuckoo_hash.h | 6 +-- 2 files changed, 61 insertions(+

[PATCH v3 10/19] pdump: use rte optional stdatomic API

2023-10-25 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/pdump/rte_pdump.c | 14 +++--- lib/pdump/rte_pdump.h | 8 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/lib/p

[PATCH v3 09/19] rcu: use rte optional stdatomic API

2023-10-25 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/rcu/rte_rcu_qsbr.c | 48 +-- lib/rcu/rte_rcu_qsbr.h | 68 +- 2 fil

[PATCH v3 15/19] distributor: use rte optional stdatomic API

2023-10-25 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/distributor/distributor_private.h | 4 +-- lib/distributor/rte_distributor.c | 54 +-- 2 files changed, 29 in

[PATCH v3 07/19] mbuf: use rte optional stdatomic API

2023-10-25 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/mbuf/rte_mbuf.h | 20 ++-- lib/mbuf/rte_mbuf_core.h | 5 +++-- 2 files changed, 13 insertions(+), 12 deletions(-) diff --gi

[PATCH v3 08/19] mempool: use rte optional stdatomic API

2023-10-25 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/mempool/rte_mempool.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.

[PATCH v3 05/19] gpudev: use rte optional stdatomic API

2023-10-25 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/gpudev/gpudev.c| 6 +++--- lib/gpudev/gpudev_driver.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/gpudev/gp

[PATCH v3 06/19] ipsec: use rte optional stdatomic API

2023-10-25 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/ipsec/ipsec_sqn.h | 2 +- lib/ipsec/sa.h| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ipsec/ipsec_sqn.h b/lib

[PATCH v3 03/19] eal: use rte optional stdatomic API

2023-10-25 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/eal/common/eal_common_launch.c| 10 +-- lib/eal/common/eal_common_mcfg.c | 2 +- lib/eal/common/eal_common_proc.c | 14 ++-- lib

[PATCH v3 04/19] eventdev: use rte optional stdatomic API

2023-10-25 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- drivers/event/cnxk/cnxk_tim_worker.h | 4 +-- lib/eventdev/rte_event_timer_adapter.c | 66 +- lib/eventdev/rte_even

[PATCH v3 01/19] power: use rte optional stdatomic API

2023-10-25 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/power/power_acpi_cpufreq.c | 33 + lib/power/power_cppc_cpufreq.c | 25 + lib/power/po

[PATCH v3 02/19] bbdev: use rte optional stdatomic API

2023-10-25 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API Signed-off-by: Tyler Retzlaff --- lib/bbdev/rte_bbdev.c | 6 +++--- lib/bbdev/rte_bbdev.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/bbdev/rte_bbdev.c b

[PATCH v3 00/19] use rte optional stdatomic API

2023-10-25 Thread Tyler Retzlaff
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API. v3: * add missing atomic specification on head variable in struct rte_ring_headtail * adapt to use rte_atomic_xxx stdatomic API in rte_ring_c11_pvt.h * split comma operator st

Re: [PATCH v2] eal/unix: allow creating thread with real-time priority

2023-10-25 Thread Stephen Hemminger
On Wed, 25 Oct 2023 19:54:06 +0200 Morten Brørup wrote: > Someone might build a kernel with options to keep non-dataplane threads off > some dedicated CPU cores, so they can be used for guaranteed low-latency > dataplane threads. We do. We don't use real-time priority, though. > > For referenc

Re: [PATCH v2 19/19] ring: use rte optional stdatomic API

2023-10-25 Thread Tyler Retzlaff
On Wed, Oct 25, 2023 at 03:49:50PM -0700, Tyler Retzlaff wrote: > On Wed, Oct 25, 2023 at 10:06:23AM +, Konstantin Ananyev wrote: > > > > > > > > > > On Tue, Oct 24, 2023 at 09:43:13AM +0100, Konstantin Ananyev wrote: > > > > 17.10.2023 21:31, Tyler Retzlaff пишет: > > > > >Replace the use o

Re: [PATCH v2 19/19] ring: use rte optional stdatomic API

2023-10-25 Thread Tyler Retzlaff
On Wed, Oct 25, 2023 at 10:06:23AM +, Konstantin Ananyev wrote: > > > > > > On Tue, Oct 24, 2023 at 09:43:13AM +0100, Konstantin Ananyev wrote: > > > 17.10.2023 21:31, Tyler Retzlaff пишет: > > > >Replace the use of gcc builtin __atomic_xxx intrinsics with > > > >corresponding rte_atomic_xxx

Re: [PATCH v2 09/19] rcu: use rte optional stdatomic API

2023-10-25 Thread Tyler Retzlaff
On Wed, Oct 25, 2023 at 09:41:22AM +, Ruifeng Wang wrote: > > -Original Message- > > From: Tyler Retzlaff > > Sent: Wednesday, October 18, 2023 4:31 AM > > To: dev@dpdk.org > > Cc: Akhil Goyal ; Anatoly Burakov > > ; Andrew > > Rybchenko ; Bruce Richardson > > ; > > Chenbo Xia ; Ciar

Re: [PATCH v2] eal/unix: allow creating thread with real-time priority

2023-10-25 Thread Stephen Hemminger
On Wed, 25 Oct 2023 19:54:06 +0200 Morten Brørup wrote: > I agree with Thomas on this. > > If you want the log message, please degrade it to INFO or DEBUG level. It is > only relevant when chasing problems, not for normal production - and thus > NOTICE is too high. I don't want the message to

Re: [PATCH v2 1/5] net/ena: hal upgrade

2023-10-25 Thread Ferruh Yigit
On 10/25/2023 2:36 PM, shaib...@amazon.com wrote: > From: Shai Brandes > > ENA maintains a HAL that is shared by all supported host drivers. > Main features introduced to the HAL: > [1] Reworked the mechanism that queries the performance metrics > from the device. > [2] Added support for a ne

[PATCH v4 4/4] doc: add packet type matching item to release notes

2023-10-25 Thread Alexander Kozyrev
Document new RTE_FLOW_ITEM_TYPE_PTYPE in the release notes. Signed-off-by: Alexander Kozyrev --- doc/guides/rel_notes/release_23_11.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst index 0a6fc76a9d..b943

[PATCH v4 3/4] doc: add PMD ptype item limitations

2023-10-25 Thread Alexander Kozyrev
From: Michael Baum Add limitations for ptype item support in "mlx5.rst" file. Signed-off-by: Michael Baum --- doc/guides/nics/features/mlx5.ini | 1 + doc/guides/nics/mlx5.rst | 15 +++ 2 files changed, 16 insertions(+) diff --git a/doc/guides/nics/features/mlx5.ini b/d

[PATCH v4 2/4] net/mlx5/hws: add support for fragmented ptype match

2023-10-25 Thread Alexander Kozyrev
Expand packet type matching with support of the Fragmented IP (Internet Protocol) packet type. Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/hws/mlx5dr_definer.c | 54 ++- drivers/net/mlx5/hws/mlx5dr_definer.h | 2 + 2 files changed, 46 insertions(+), 10 deletion

[PATCH v4 0/4] ptype matching support in mlx5

2023-10-25 Thread Alexander Kozyrev
Add support for RTE_FLOW_ITEM_TYPE_PTYPE in mlx5 PMD. Alexander Kozyrev (3): net/mlx5: add support for ptype match in hardware steering net/mlx5/hws: add support for fragmented ptype match doc: add packet type matching item to release notes Michael Baum (1): doc: add PMD ptype item limita

[PATCH v4 1/4] net/mlx5: add support for ptype match in hardware steering

2023-10-25 Thread Alexander Kozyrev
The packet type matching provides quick way of finding out L2/L3/L4 protocols in a given packet. That helps with optimized flow rules matching, eliminating the need of stacking all the packet headers in the matching criteria. Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/hws/mlx5dr_defin

[PATCH] net/mlx5/hws: fix integrity bits level

2023-10-25 Thread Alexander Kozyrev
The level field in the integrity item is not taken into account in the current implementation of hardware steering. Use this value instead of trying to find out the encapsulation level according to the protocol items involved. Fixes: c55c2bf35333 ("net/mlx5/hws: add definer layer") Signed-off-by:

[PATCH] net/mlx5/hws: remove csum check from L3 ok check

2023-10-25 Thread Alexander Kozyrev
From: Michael Baum This patch changes the integrity item behavior for HW steering. Old behavior: the "ipv4_csum_ok" checks only IPv4 checksum and "l3_ok" checks everything is ok including IPv4 checksum. New behavior: the "l3_ok" checks everything is ok excluding IPv4 checksum. This change enab

[PATCH] ethdev: fix ESP packet type description

2023-10-25 Thread Alexander Kozyrev
The correct protocol number for ESP (IP Encapsulating Security Payload) packet type is 50. 51 is IPSec AH (Authentication Header). Fixes: 1e84afd3906b ("mbuf: add security crypto flags and fields") Signed-off-by: Alexander Kozyrev --- lib/mbuf/rte_mbuf_ptype.h | 4 ++-- 1 file changed, 2 inserti

RE: [PATCH v3 1/2] eal: add thread yield functions

2023-10-25 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, 25 October 2023 18.31 > > When running real-time threads, we may need to force scheduling > kernel threads or other real-time threads. > New functions are added to address these cases. > > The yield functions should not have

RE: [PATCH v2] eal/unix: allow creating thread with real-time priority

2023-10-25 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, 25 October 2023 18.46 > > 25/10/2023 17:37, Stephen Hemminger: > > On Wed, 25 Oct 2023 17:13:14 +0200 > > Thomas Monjalon wrote: > > > > > case RTE_THREAD_PRIORITY_REALTIME_CRITICAL: > > > + /* > > > + * WA

Re: [PATCH v3 1/2] eal: add thread yield functions

2023-10-25 Thread Thomas Monjalon
25/10/2023 18:40, Bruce Richardson: > On Wed, Oct 25, 2023 at 06:31:10PM +0200, Thomas Monjalon wrote: > > When running real-time threads, we may need to force scheduling > > kernel threads or other real-time threads. > > New functions are added to address these cases. > > > > The yield functions

Re: [PATCH v2] eal/unix: allow creating thread with real-time priority

2023-10-25 Thread Thomas Monjalon
25/10/2023 17:37, Stephen Hemminger: > On Wed, 25 Oct 2023 17:13:14 +0200 > Thomas Monjalon wrote: > > > case RTE_THREAD_PRIORITY_REALTIME_CRITICAL: > > + /* > > +* WARNING: Real-time busy loop takes priority on kernel > > threads, > > +* making the

Re: [PATCH v3 1/2] eal: add thread yield functions

2023-10-25 Thread Bruce Richardson
On Wed, Oct 25, 2023 at 06:31:10PM +0200, Thomas Monjalon wrote: > When running real-time threads, we may need to force scheduling > kernel threads or other real-time threads. > New functions are added to address these cases. > > The yield functions should not have any interest for normal threads.

[PATCH v3 2/2] eal/unix: allow creating thread with real-time priority

2023-10-25 Thread Thomas Monjalon
When adding an API for creating threads, the real-time priority has been forbidden on Unix. There is a known issue with ring behaviour, but it should not be completely forbidden. Real-time thread can block some kernel threads on the same core, making the system unstable. That's why a pause is add

[PATCH v3 1/2] eal: add thread yield functions

2023-10-25 Thread Thomas Monjalon
When running real-time threads, we may need to force scheduling kernel threads or other real-time threads. New functions are added to address these cases. The yield functions should not have any interest for normal threads. Note: other purposes may be addressed with rte_pause() or rte_delay_*().

[PATCH v3 0/2] allow creating thread with real-time priority

2023-10-25 Thread Thomas Monjalon
Real-time thread priority was been forbidden on Unix because of problems they can cause. Warnings and helpers are added to avoid deadlocks, so real-time can be allowed on all systems. Thomas Monjalon (2): eal: add thread yield functions eal/unix: allow creating thread with real-time priority

Re: [PATCH v2 25/25] doc: add the common and vDPA document

2023-10-25 Thread Ferruh Yigit
On 10/24/2023 3:28 AM, Chaoyong He wrote: > Add the document for nfp common library and vDPA PMD. > Can you please distribute this patch to other patches in set, details below. > Signed-off-by: Chaoyong He > Reviewed-by: Long Wu > Reviewed-by: Peng Zhang > --- > MAINTAINERS

Re: [PATCH v2 19/25] drivers: add the basic framework of vDPA PMD

2023-10-25 Thread Ferruh Yigit
On 10/24/2023 3:28 AM, Chaoyong He wrote: > Add the basic framework of vDPA PMD. > > Signed-off-by: Chaoyong He > Signed-off-by: Shujing Dong > Reviewed-by: Long Wu > Reviewed-by: Peng Zhang <...> > @@ -12,5 +12,12 @@ if not dpdk_conf.has('RTE_LIB_VHOST') > endif > > sources = files( > +

Re: [PATCH v2 18/25] drivers/vdpa: introduce the NFP vDPA library

2023-10-25 Thread Ferruh Yigit
On 10/24/2023 3:28 AM, Chaoyong He wrote: > Introduce the very basic NFP vDPA library. > > Signed-off-by: Shujing Dong > Signed-off-by: Chaoyong He > Reviewed-by: Long Wu > Reviewed-by: Peng Zhang <...> > --- /dev/null > +++ b/drivers/vdpa/nfp/meson.build > @@ -0,0 +1,16 @@ > +# SPDX-License

Re: [PATCH v2 02/25] net/nfp: make VF PMD using of NFP common module

2023-10-25 Thread Ferruh Yigit
On 10/24/2023 3:28 AM, Chaoyong He wrote: > Modify the logic of NFP VF PMD, make it using of the NFP common module > and link into the 'nfp_drivers_list'. > > Signed-off-by: Chaoyong He > Signed-off-by: Shujing Dong > Reviewed-by: Long Wu > Reviewed-by: Peng Zhang > --- > drivers/net/nfp/meso

Re: [PATCH v2 00/25] add the NFP vDPA PMD

2023-10-25 Thread Ferruh Yigit
On 10/24/2023 3:28 AM, Chaoyong He wrote: > This patch series aims to add the NFP vDPA PMD, we also grab the common > logic into the `drivers/common/nfp` directory. > > --- > v2: > * Grab more logic into the `drivers/common/nfp` directory. > * Delete some logic which should be when moving logic. >

Re: [External] Re: [PATCH] eal: fix modify data area after memset

2023-10-25 Thread Stephen Hemminger
On Mon, 23 Oct 2023 17:07:21 +0800 Fengnan Chang wrote: > Dmitry Kozlyuk 于2023年10月23日周一 04:22写道: > > > > 2023-09-22 16:12 (UTC+0800), Fengnan Chang: > > > ping > > > > > > Fengnan Chang 于2023年9月12日周二 17:05写道: > > > > > > > > Let's look at this path: > > > > malloc_elem_free > > > >->m

Re: [PATCH v2] eal/unix: allow creating thread with real-time priority

2023-10-25 Thread Stephen Hemminger
On Wed, 25 Oct 2023 17:13:14 +0200 Thomas Monjalon wrote: > case RTE_THREAD_PRIORITY_REALTIME_CRITICAL: > + /* > + * WARNING: Real-time busy loop takes priority on kernel > threads, > + * making the system unstable. > + *

Re: [PATCH] eal/unix: allow creating thread with real-time priority

2023-10-25 Thread Thomas Monjalon
25/10/2023 17:18, Thomas Monjalon: > 25/10/2023 17:14, Bruce Richardson: > > On Wed, Oct 25, 2023 at 08:08:52AM -0700, Stephen Hemminger wrote: > > > On Wed, 25 Oct 2023 15:44:25 +0200 > > > Thomas Monjalon wrote: > > > > > > > > > > > > > > > I'll try to pass the test by adding a sleep in the t

Re: Series for 23.11

2023-10-25 Thread Maxime Coquelin
Hi Nicolas; On 10/16/23 16:49, Chautru, Nicolas wrote: Hi Maxime, Just a heads up that Hernan is going on paternity leave, I will be covering for his series pending for 23.11. Ping me if there is any update required from review that I may have missed. Pending series in patchwork: * SDK +

Re: [PATCH] eal/unix: allow creating thread with real-time priority

2023-10-25 Thread Thomas Monjalon
25/10/2023 17:14, Bruce Richardson: > On Wed, Oct 25, 2023 at 08:08:52AM -0700, Stephen Hemminger wrote: > > On Wed, 25 Oct 2023 15:44:25 +0200 > > Thomas Monjalon wrote: > > > > > > > > > > > > I'll try to pass the test by adding a sleep in the test thread. > > > > > > > > > > > > > "sched_

Re: [PATCH] eal/unix: allow creating thread with real-time priority

2023-10-25 Thread Bruce Richardson
On Wed, Oct 25, 2023 at 08:08:52AM -0700, Stephen Hemminger wrote: > On Wed, 25 Oct 2023 15:44:25 +0200 > Thomas Monjalon wrote: > > > > > > > > > I'll try to pass the test by adding a sleep in the test thread. > > > > > > > > > > "sched_yield()" rather than sleep perhaps? Might better conve

[PATCH v2] eal/unix: allow creating thread with real-time priority

2023-10-25 Thread Thomas Monjalon
When adding an API for creating threads, the real-time priority has been forbidden on Unix. There is a known issue with ring behaviour, but it should not be completely forbidden. Real-time thread can block some kernel threads on the same core, making the system unstable. That's why a pause is add

Re: [PATCH] eal/unix: allow creating thread with real-time priority

2023-10-25 Thread Stephen Hemminger
On Wed, 25 Oct 2023 15:44:25 +0200 Thomas Monjalon wrote: > > > > > > I'll try to pass the test by adding a sleep in the test thread. > > > > > > > "sched_yield()" rather than sleep perhaps? Might better convey the > > intention of the call. > > Do we have sched_yield on Windows? Windows

Re: [PATCH] config: compiler support check for machine arch flags

2023-10-25 Thread Bruce Richardson
On Wed, Oct 25, 2023 at 07:17:09AM -0700, Sivaprasad Tummala wrote: > Added additional checks for compiler support of specific cpu arch > flags to fix incorrect error reporting. > > Without this patch, meson build reports '__SSE4_2__' not defined > error for x86 builds when the compiler does not s

[PATCH] config: compiler support check for machine arch flags

2023-10-25 Thread Sivaprasad Tummala
Added additional checks for compiler support of specific cpu arch flags to fix incorrect error reporting. Without this patch, meson build reports '__SSE4_2__' not defined error for x86 builds when the compiler does not support the specified cpu_instruction_set (or) machine argument. Signed-off-by

Re: [PATCH] eal/unix: allow creating thread with real-time priority

2023-10-25 Thread Thomas Monjalon
25/10/2023 15:34, Bruce Richardson: > On Wed, Oct 25, 2023 at 03:15:49PM +0200, Thomas Monjalon wrote: > > 24/10/2023 18:04, Stephen Hemminger: > > > On Tue, 24 Oct 2023 15:55:13 +0200 > > > Morten Brørup wrote: > > > > > > > > > > > > >4. It MAY be used by preemptible multi-producer and/or

[PATCH v2 5/5] net/ena: update ena version to 2.8.0

2023-10-25 Thread shaibran
From: Shai Brandes This release introduces: * Upgraded ENA HAL. * Support for connection tracking allowance utilization metric. * Support for reporting rx overrun errors in xstats. * Support for ENA-express metrics. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein --- drivers/net/ena/e

[PATCH v2 3/5] net/ena: report Rx overrun errors in xstats

2023-10-25 Thread shaibran
From: Shai Brandes RX overrun error occur when a packet arrives but there are not enough free buffers in the RX ring to receive it. The driver publishes the extended statistics with the RX buffer overrun errors as reported by the device. Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein

[PATCH v2 2/5] net/ena: add support for connection tracking metric

2023-10-25 Thread shaibran
From: Shai Brandes The driver publishes network performance metrics that the application can use to troubleshoot performance issues, monitor the workload, and benchmark applications to determine whether they maximize the performance. This patch adds support for the connection tracking allowance

[PATCH v2 4/5] net/ena: add support for ena-express metrics

2023-10-25 Thread shaibran
From: Shai Brandes ENA-express is powered by AWS scalable reliable datagram (SRD) technology. SRD is a high performance network transport protocol that uses dynamic routing to increase throughput and minimize tail latency. The driver expose the following ENA-express metrics via xstats: * ena_srd

[PATCH v2 1/5] net/ena: hal upgrade

2023-10-25 Thread shaibran
From: Shai Brandes ENA maintains a HAL that is shared by all supported host drivers. Main features introduced to the HAL: [1] Reworked the mechanism that queries the performance metrics from the device. [2] Added support for a new metric that allows monitoring the available tracked connec

[PATCH v2 0/5] net/ena: v2.8.0 driver release

2023-10-25 Thread shaibran
From: Shai Brandes Hi, This patchset contains alignment of the driver to the latest HAL version which adds support for retrieving new metrics from the device and opens a path to use additional device features that are not yet supported by the driver. The new driver features are mostly about add

Re: [PATCH] eal/unix: allow creating thread with real-time priority

2023-10-25 Thread Bruce Richardson
On Wed, Oct 25, 2023 at 03:15:49PM +0200, Thomas Monjalon wrote: > 24/10/2023 18:04, Stephen Hemminger: > > On Tue, 24 Oct 2023 15:55:13 +0200 > > Morten Brørup wrote: > > > > > > > > > >4. It MAY be used by preemptible multi-producer and/or preemptible > > > > multi- > > > > consumer pthre

  1   2   >