The 'need_lock' parameter controls whether the function acquires and
releases the spinlock, but the first unlock operation occurs regardless
of the 'need_lock' parameter.
To fix this issue, the spin unlock operation should be invoked within
an 'if (need_lock)' block, ensuring that the function onl
The function 'ulp_ha_mgr_timer_cb' acquires a lock on the context
entry at the beginning with bnxt_ulp_cntxt_entry_acquire(). This lock
is expected to be released by bnxt_ulp_cntxt_entry_release() at the
end of the function.
However, the second early return statement in the function could
potentia
Pointer 'txq_ctrl' was dereferenced and then compared to NULL.
Change the order to keep the logic consistent.
Fixes: f49f44839df3 ("net/mlx5: share Tx control code")
Cc: sta...@dpdk.org
Signed-off-by: Weiguo Li
---
drivers/net/mlx5/mlx5_trigger.c | 5 -
1 file changed, 4 insertions(+), 1 de
I have for a long time now wondered why the ring functions for enqueue/dequeue
of 64-bit objects supports unaligned addresses, and now I finally found the
patch introducing it.
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Phil Yang
> Sent: Monday, 9 March 2020 18.20
>
> The 32-bit arm
Fix bug for the VRB1 PMD in LDPC Encoder TB mode.
Targeting the rc3 if possible.
Nicolas Chautru (1):
baseband/acc: fix for TB mode on VRB1
drivers/baseband/acc/rte_vrb_pmd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
2.34.1
The input size is computed incorrectly for the
LDPC encoder TB processing.
Fixes: e640f6cdfa84 ("baseband/acc200: add LDPC processing")
Cc: sta...@dpdk.org
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc/rte_vrb_pmd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a
Update the timeout argument and default values.
Update EAL help message and default value.
Add iter_max and snr arguments.
Until next release we keep -t as a possible command-line argument
for time-out, until -t becomes the argument for iter-max
so that to match the binary command-line argument.
S
From: Hernan Vargas
Adding support to test new FFT capabilities.
Optional frequency domain dewindowing, frequency resampling,
timing error correction and time offset per CS.
Signed-off-by: Hernan Vargas
Reviewed-by: Maxime Coquelin
---
app/test-bbdev/test_bbdev_perf.c | 26 ++---
ap
From: Hernan Vargas
Add support to test LDPC UL operation for new capability.
Option to compress HARQ memory to 4 bits per LLR.
Signed-off-by: Hernan Vargas
Reviewed-by: Maxime Coquelin
---
app/test-bbdev/test_bbdev_perf.c | 3 ++-
app/test-bbdev/test_bbdev_vector.c | 2 ++
2 files changed,
From: Hernan Vargas
Adding test-bbdev support for the MLD-TS processing specific to the VRB2
variant.
Signed-off-by: Hernan Vargas
Reviewed-by: Maxime Coquelin
---
app/test-bbdev/test_bbdev_perf.c | 519 +
app/test-bbdev/test_bbdev_vector.c | 132
app/te
From: Hernan Vargas
Add support for LDPC encoder concatenation configuration from the test
vector.
Signed-off-by: Hernan Vargas
Reviewed-by: Maxime Coquelin
---
app/test-bbdev/test_bbdev_vector.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/app/test-bbdev/test_bbdev_
From: Hernan Vargas
Stop test if rte_bbdev_queue_configure fails to configure queue.
Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev")
Cc: sta...@dpdk.org
Signed-off-by: Hernan Vargas
Reviewed-by: Maxime Coquelin
---
app/test-bbdev/test_bbdev.c | 3 ++-
1 file changed, 2
From: Hernan Vargas
Add a print message for failure to retrieve stats on bbdev.
Add vector name in logs.
Remove unnecessary prints.
Update code comments and cosmetic changes.
No functional impact.
Signed-off-by: Hernan Vargas
Reviewed-by: Maxime Coquelin
---
app/test-bbdev/main.c|
From: Hernan Vargas
Add range limit to prevent LLR generation greater than the data buffer
size.
Fixes: 7831a9684356 ("test/bbdev: support BLER for 4G")
Cc: sta...@dpdk.org
Signed-off-by: Hernan Vargas
---
app/test-bbdev/test_bbdev_perf.c | 6 ++
1 file changed, 6 insertions(+)
diff --gi
Renaming ACC200 macros to use generic intel vRAN Boost (VRB).
No functional impact.
Fixes: 69a9d9e139d2 ("baseband/acc: rename files from acc200 to vrb")
Cc: sta...@dpdk.org
Signed-off-by: Hernan Vargas
Signed-off-by: Nicolas Chautru
---
app/test-bbdev/test_bbdev_perf.c | 91 --
From: Hernan Vargas
test-bbdev.py relying on non-recommended subprocess Popen.
This can lead to instabilities where the process cannot be stopped with a
sig TERM.
Use subprocess run with proper timeout argument.
Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev")
Cc: sta...@dpd
v3: python script argument fix marked as deprecation first, with
formal fix in following release.
Maxime let me know if you want to something more formal in the
release notes to call it out, currently embedded in script and
commit message.
typo correction.
v2: adding fixes for s
Dynamically allocated log type is a standard approach among all drivers.
Switch to it.
Signed-off-by: Tomasz Duszynski
---
drivers/raw/cnxk_gpio/cnxk_gpio.c | 22 --
drivers/raw/cnxk_gpio/cnxk_gpio.h | 7 +++
drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c |
> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> Sent: Friday, 3 November 2023 19.09
>
> On Fri, Nov 03, 2023 at 06:31:30PM +0100, Morten Brørup wrote:
> > > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > > Sent: Friday, 3 November 2023 17.52
> > >
> > > DPDK now has
Buffer auto free test failed for more than 1 dma device as the device
initialization for the test was been done only for the first dma
device. This changeset fixes the same and also fixes the freeing of
the uninitialised source buffer in error condition.
Fixes: 877cb3e37426 ("dmadev: add buffer au
In vfio-pci driver when PASID is enabled by default DLB hardware puts
DLB in SIOV mode. This breaks DLB PF-PMD mode. For DLB PF-PMD mode to
function properly PASID needs to be disabled.
In this commit this issue is addressed and PASID is disabled by writing
a zero to PASID control register.
Fixes
This commit implements an internal api to enable and disable PASID for
a device e.g. device driver event/dlb2.
For kernels when PASID enabled by default it breaks DLB functionality,
hence disabling PASID is required for DLB to function properly.
PASID capability is not exposed to users hence offs
*** BLURB HERE ***
Abdullah Sevincer (2):
bus/pci: add function to enable/disable PASID
event/dlb2: fix disable PASID
drivers/bus/pci/pci_common.c | 7 +++
drivers/bus/pci/rte_bus_pci.h | 13 +
drivers/bus/pci/version.map | 1 +
drivers/event/dlb2/pf/dlb2_mai
On Fri, Nov 03, 2023 at 06:31:30PM +0100, Morten Brørup wrote:
> > From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> > Sent: Friday, 3 November 2023 17.52
> >
> > DPDK now has more optional libraries than mandatory ones, so invert the
> > list stored in the meson.build file from the opt
>+Looks like you missed my comments at
>+https://patches.dpdk.org/project/dpdk/patch/20231103170347.2790525-1-abdullah.sevin...@intel.com/
Yes, all comments, upstream happened at the same time 😊 will address them and
push another patch.
On Fri, Nov 3, 2023 at 11:23 PM Abdullah Sevincer
wrote:
>
> This commit implements an internal api to enable and disable PASID for
> a device e.g. device driver event/dlb2.
>
> For kernels when PASID enabled by default it breaks DLB functionality,
> hence disabling PASID is required for DLB to fu
In vfio-pci driver when PASID is enabled by default DLB hardware puts
DLB in SIOV mode. This breaks DLB PF-PMD mode. For DLB PF-PMD mode to
function properly PASID needs to be disabled.
In this commit this issue is addressed and PASID is disabled by writing
a zero to PASID control register.
Fixes
This commit implements an internal api to enable and disable PASID for
a device e.g. device driver event/dlb2.
For kernels when PASID enabled by default it breaks DLB functionality,
hence disabling PASID is required for DLB to function properly.
PASID capability is not exposed to users hence offs
*** BLURB HERE ***
Abdullah Sevincer (2):
bus/pci: add function to enable/disable PASID
event/dlb2: fix disable PASID
drivers/bus/pci/pci_common.c | 7 +++
drivers/bus/pci/rte_bus_pci.h | 13 +
drivers/bus/pci/version.map | 1 +
drivers/event/dlb2/pf/dlb2_mai
> From: Bruce Richardson [mailto:bruce.richard...@intel.com]
> Sent: Friday, 3 November 2023 17.52
>
> DPDK now has more optional libraries than mandatory ones, so invert the
> list stored in the meson.build file from the optional ones to the
> "always_enable" ones. As well as being a shorter list
> -Original Message-
> From: Abdullah Sevincer
> Sent: Friday, November 3, 2023 10:34 PM
> To: dev@dpdk.org
> Cc: Jerin Jacob Kollanukkaran ;
> mike.ximing.c...@intel.com; bruce.richard...@intel.com;
> tho...@monjalon.net; Abdullah Sevincer
> Subject: [EXT] [PATCH v1] bus/pci: add funct
On Fri, Nov 03, 2023 at 12:14:36PM -0500, Abdullah Sevincer wrote:
> In vfio-pci driver when PASID is enabled by default
> DLB hardware puts DLB in SIOV mode. This breaks
> DLB PF-PMD mode. For DLB PF-PMD mode to function properly
> PASID needs to be disabled.
>
> In this commit this issue is addr
On Fri, Nov 03, 2023 at 12:03:47PM -0500, Abdullah Sevincer wrote:
> This commit implements an internal api to enable
> and disable PASID for a device e.g. DLB Device.
>
> For kernels when PASID enabled by default it breaks
> DLB functionality, hence disabling PASID is required
> for DLB to functi
In vfio-pci driver when PASID is enabled by default
DLB hardware puts DLB in SIOV mode. This breaks
DLB PF-PMD mode. For DLB PF-PMD mode to function properly
PASID needs to be disabled.
In this commit this issue is addressed and PASID is disabled
by writing a zero to PASID control register.
Fixes
This commit implements an internal api to enable
and disable PASID for a device e.g. DLB Device.
For kernels when PASID enabled by default it breaks
DLB functionality, hence disabling PASID is required
for DLB to function properly.
PASID capability is not exposed to users hence offset
can not be
On 11/3/2023 6:25 AM, Chaoyong He wrote:
> Add the very basic rte_flow support for corenic firmware.
>
> Chaoyong He (11):
> net/nfp: move some source files
> drivers: add the structures and functions for flow offload
> net/nfp: add the control message channel
> net/nfp: support flow API f
DPDK now has more optional libraries than mandatory ones, so invert the
list stored in the meson.build file from the optional ones to the
"always_enable" ones. As well as being a shorter list:
* we can remove the loop building up the "always_enable" list
dynamically from the optional list
* it b
On Fri, Nov 03, 2023 at 09:38:53AM -0700, Srikanth Yalavarthi wrote:
> In order to avoid linking with Libs.private, libarchive
> is not added to ext_deps during the meson setup stage.
>
> Since libarchive is not added to ext_deps, cross-compilation
> or native compilation with libarchive installed
19/10/2023 19:29, sk...@marvell.com:
> From: Sunil Kumar Kori
>
> In the continuation of following feedback
> https://patches.dpdk.org/project/dpdk/patch/20230425131516.3308612-5-vattun...@marvell.com/
> this patch series adds dpdk-graph application to exercise various
> usecases using graph.
I'
Update scale factor in IO info of TVM models from metadata.
Fixes: 35c3e790b4a0 ("ml/cnxk: update internal info for TVM model")
Signed-off-by: Srikanth Yalavarthi
---
v2:
- Rebase over latest main
v1:
- Initial PATCH
drivers/ml/cnxk/mvtvm_ml_model.c | 2 ++
1 file changed, 2 insertions(+)
In order to avoid linking with Libs.private, libarchive
is not added to ext_deps during the meson setup stage.
Since libarchive is not added to ext_deps, cross-compilation
or native compilation with libarchive installed in non-standard
location fails with errors related to "cannot find -larchive"
DPDK now has more optional libraries than mandatory ones, so invert the
list stored in the meson.build file from the optional ones to the
"always_enable" ones. As well as being a shorter list:
* we can remove the loop building up the "always_enable" list
dynamically from the optional list
* it b
On 11/3/2023 6:25 AM, Chaoyong He wrote:
> Add the very basic rte_flow support for corenic firmware.
>
> Chaoyong He (11):
> net/nfp: move some source files
> drivers: add the structures and functions for flow offload
> net/nfp: add the control message channel
> net/nfp: support flow API f
> -Original Message-
> From: Ferruh Yigit
> Sent: Friday, November 3, 2023 2:36 AM
> To: Sachin Saxena (OSS) ; Hemant Agrawal
> ; Sachin Saxena
> Cc: dev@dpdk.org; Tianli Lai
> Subject: Re: [PATCH] net/dpaa2: change threshold value
> Importance: High
>
> On 9/29/2023 2:50 PM, Ferruh Y
On 11/2/2023 8:20 AM, Jie Hai wrote:
> Currently, rte_eth_rss_conf supports configuring and querying
> RSS hash functions, rss key and it's length, but not RSS hash
> algorithm.
>
> The structure ``rte_eth_dev_info`` is extended by adding a new
> field "rss_algo_capa". Drivers are responsible for
Numerous memory leaks were detected by ASAN
in the OpenSSL PMD asymmetric code path.
These are now fixed to free all variables allocated
by OpenSSL functions such as BN_bin2bn and
OSSL_PARAM_BLD_new.
Some need to exist until the op is processed,
for example the BIGNUMs associated with DSA.
The po
> -Original Message-
> From: Gowrishankar Muthukrishnan
> Sent: Friday, November 3, 2023 3:15 PM
> To: dev@dpdk.org
> Cc: ano...@marvell.com; Akhil Goyal ; Ji, Kai
> ; Power, Ciara ; Gowrishankar
> Muthukrishnan
> Subject: [PATCH v3] crypto/openssl: fix memory leaks in asym ops
>
> Fi
Add scatter-gather copy tests.
Signed-off-by: Vidya Sagar Velumuri
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_dmadev.c | 132 +-
app/test/test_dmadev_api.c | 163 ++---
app/test/test_dmadev_api.h | 2 +
3 files c
Reconfigure vchan count and validate if new count is effective.
Signed-off-by: Gowrishankar Muthukrishnan
---
app/test/test_dmadev_api.c | 63 +-
1 file changed, 55 insertions(+), 8 deletions(-)
diff --git a/app/test/test_dmadev_api.c b/app/test/test_dmadev_a
Use unit test framework to execute DMA tests.
Signed-off-by: Gowrishankar Muthukrishnan
Suggested-by: Chengwen Feng
---
app/test/test_dmadev.c | 240 -
app/test/test_dmadev_api.c | 89 --
2 files changed, 212 insertions(+), 117 deletions(-)
This patch series reworks DMA tests to follow unit test framework
followed by new vchan reconfig and SG tests.
v3:
- followed unit test framework.
Gowrishankar Muthukrishnan (3):
test/dma: use unit test framework
test/dma: test vchan reconfiguration
test/dma: add SG copy tests
app/test/t
This patch adds the checking to avoid creating send_to_kernel
action on the FDB table if eswitch disabled.
Fixes: 033e826f680b ("net/mlx5: fix device checking for send to kernel action")
Signed-off-by: Jiawei Wang
Acked-by: Suanming Mou
---
drivers/net/mlx5/mlx5_flow_hw.c | 3 ++-
1 file chang
On Fri, Nov 03, 2023 at 12:01:53AM -0400, David Young wrote:
> ---
> doc/guides/getting_started_guide/glossary.rst | 75 +++
> 1 file changed, 75 insertions(+)
> create mode 100644 doc/guides/getting_started_guide/glossary.rst
>
> diff --git a/doc/guides/getting_started_guide/glo
I haven't reviewed this whole file in detail, as I assume most content is
copy-pasted from existing docs and so is correct. One comment inline below,
though.
/Bruce
On Fri, Nov 03, 2023 at 12:01:51AM -0400, David Young wrote:
> ---
> .../appendix/cross_compile_dpdk.rst | 37 +++
> ...
> All these checks for null are unnecessary:
>
>EVP_PKEY_free() decrements the reference count of key and, if the
> reference count is zero,
>frees it up. If key is NULL, nothing is done.
>
>
> Let me add those functions to cocci nullfree script as well.
Ack.
Fix memory leaks in Asymmetric ops, as reported by valgrind.
Signed-off-by: Gowrishankar Muthukrishnan
---
v3:
- changes as suggested in v2.
---
drivers/crypto/openssl/rte_openssl_pmd.c | 30 +---
drivers/crypto/openssl/rte_openssl_pmd_ops.c | 16 +++
2 files changed
On Fri, Nov 03, 2023 at 12:01:50AM -0400, David Young wrote:
> ---
> .../getting_started_guide/run_apps/index.rst | 10 ++
> .../run_apps/run_apps.rst | 118 ++
> 2 files changed, 128 insertions(+)
> create mode 100644 doc/guides/getting_started_guide/run_app
On 11/3/2023 6:19 AM, Chaoyong He wrote:
> Add quick exit logic for parse packet type function, when the control
> switch for this feature is off, the function can return quickly.
>
> Signed-off-by: Chaoyong He
> Reviewed-by: Long Wu
> Reviewed-by: Peng Zhang
>
Applied to dpdk-next-net/main, t
On Fri, Nov 03, 2023 at 12:01:52AM -0400, David Young wrote:
> ---
> doc/guides/index.rst | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/doc/guides/index.rst b/doc/guides/index.rst
> index 244b99624c..51a47d3a51 100644
> --- a/doc/guides/index.rst
> +++ b/doc/guides/index.rst
> @@ -7,6
As before, comments inline.
On Fri, Nov 03, 2023 at 12:01:49AM -0400, David Young wrote:
> ---
> .../getting_started_guide/system_setup.rst| 195 ++
> 1 file changed, 195 insertions(+)
> create mode 100644 doc/guides/getting_started_guide/system_setup.rst
>
> diff --git a/do
Thanks, David. More comments inline below.
/Bruce
On Fri, Nov 03, 2023 at 12:01:48AM -0400, David Young wrote:
> Section 2: Install and Build DPDK - Updated based on feedback; Merged
> windows_install_build.rst into building_from_sources.rst; Updated Meson
> 0.57.x to be required for Windows.
On 11/3/2023 1:29 PM, Bruce Richardson wrote:
> Update and clarify the guidelines on how to wrap lines in our RST docs.
> We no longer limit lines to just 80 characters, and what is more
> important that line length is the wrapping of sentences, starting a new
> sentence on a new line, and wrapping
On 11/3/2023 7:38 AM, Chengwen Feng wrote:
> The rte_kvargs_process() was used to parse key-value (e.g. socket_id=0),
> it also supports to parse only-key (e.g. socket_id). But many drivers's
> callback can only handle key-value, it will segment fault if handles
> only-key. so the patchset [1] was
On 11/3/2023 7:38 AM, Chengwen Feng wrote:
> The mvneta_ifnames_get() function will save 'iface' value to ifnames,
> it will out-of-bounds write if passed many iface pairs (e.g.
> 'iface=xxx,iface=xxx,...').
>
> Fixes: 4ccc8d770d3b ("net/mvneta: add PMD skeleton")
> Cc: sta...@dpdk.org
>
> Signed
On 11/3/2023 7:38 AM, Chengwen Feng wrote:
> This driver could handles both key=value and only-key kvargs, so it
> should use rte_kvargs_process_opt() instead of rte_kvargs_process() to
> parse.
>
> Signed-off-by: Chengwen Feng
> ---
> drivers/net/tap/rte_eth_tap.c | 26 +
On Fri, Nov 03, 2023 at 12:01:52AM -0400, David Young wrote:
> ---
> doc/guides/index.rst | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/doc/guides/index.rst b/doc/guides/index.rst
> index 244b99624c..51a47d3a51 100644
> --- a/doc/guides/index.rst
> +++ b/doc/guides/index.rst
> @@ -7,6
Update and clarify the guidelines on how to wrap lines in our RST docs.
We no longer limit lines to just 80 characters, and what is more
important that line length is the wrapping of sentences, starting a new
sentence on a new line, and wrapping at punctuation.
Signed-off-by: Bruce Richardson
---
On 11/3/2023 7:38 AM, Chengwen Feng wrote:
> The sfc_kvargs_process() and sfc_efx_dev_class_get() function could
> handle both key=value and only-key, so they should use
> rte_kvargs_process_opt() instead of rte_kvargs_process() to parse.
>
> Signed-off-by: Chengwen Feng
> ---
> drivers/common/s
On 11/3/2023 7:38 AM, Chengwen Feng wrote:
> This driver don't care about the 'iface' value, it should use
> rte_kvargs_process_opt() instead of rte_kvargs_process() to parse.
>
> Signed-off-by: Chengwen Feng
> ---
> drivers/net/af_packet/rte_eth_af_packet.c | 4 ++--
> 1 file changed, 2 inserti
On Fri, Nov 03, 2023 at 12:01:47AM -0400, David Young wrote:
> Edited copy to be simpler based on feedback.
Thanks David,
some small comments inline below.
> ---
> doc/guides/getting_started_guide/intro.rst | 13 +
> 1 file changed, 13 insertions(+)
> create mode 100644 doc/guides/g
On 11/3/2023 7:38 AM, Chengwen Feng wrote:
> The rte_kvargs_process() was used to parse key-value (e.g. socket_id=0),
> it also supports to parse only-key (e.g. socket_id). But many drivers's
> callback can only handle key-value, it will segment fault if handles
> only-key. so the patchset [1] was
On Fri, Nov 03, 2023 at 10:17:49AM +, Bruce Richardson wrote:
> On Thu, Nov 02, 2023 at 11:55:41AM -0700, Stephen Hemminger wrote:
> > On Thu, 2 Nov 2023 18:11:48 + Bruce Richardson
> > wrote:
> >
> > > From: Bruce Richardson To: dev@dpdk.org
> > > Cc: step...@networkplumber.org, Bruce
Hi,
(minor notes below)
On Fri, 3 Nov 2023, Huisong Li wrote:
The "min_rx_bufsize" in struct rte_eth_dev_info stands for the minimum
Rx buffer size supported by hardware. Actually, some engines also have
the maximum Rx buffer specification, like, hns3, i40e and so on. If mbuf
data room size in
On 11/3/2023 10:27 AM, Huisong Li wrote:
> The "min_rx_bufsize" in struct rte_eth_dev_info stands for the minimum
> Rx buffer size supported by hardware. Actually, some engines also have
> the maximum Rx buffer specification, like, hns3.
>
> If mbuf data room size in mempool is greater then the ma
> -Original Message-
> From: Power, Ciara
> Sent: Friday, November 3, 2023 10:18 AM
> To: Gowrishankar Muthukrishnan ;
> dev@dpdk.org
> Cc: ano...@marvell.com; Akhil Goyal ; Ji, Kai
>
> Subject: RE: [PATCH v2] crypto/openssl: fix memory leaks in asym ops
>
> Hi Gowrishankar,
>
> > ---
Define rte_cdx_vfio_bm_enable and rte_cdx_vfio_bm_disable to
enable or disable bus master functionality for cdx devices.
Signed-off-by: Shubham Rohila
---
v2
- Fix indentations and alphabetical orderings.
- Wrap checks in parenthesis for readability
- Assign argsz before using in rte_cdx_vfio
From: Nikhil Agarwal
Update the cleanup routine for cdx device to support
device without MSI. Also, set vfio_dev_fd for such devices
This fd can be used for BME reload operations.
Signed-off-by: Nikhil Agarwal
Signed-off-by: Shubham Rohila
---
v2
- New patch in the series
drivers/bus/cdx/cd
On 11/3/2023 9:09 AM, lihuisong (C) wrote:
> Hi Ferruh,
>
> Thanks for you review.
>
>
> 在 2023/11/3 9:31, Ferruh Yigit 写道:
>> On 8/2/2023 3:55 AM, Huisong Li wrote:
>>> The command "tso set " is used to enable UFO,
>>> please
>>> see commit ce8e6e742807 ("app/testpmd: support UFO in checksum e
The "min_rx_bufsize" in struct rte_eth_dev_info stands for the minimum
Rx buffer size supported by hardware. Actually, some engines also have
the maximum Rx buffer specification, like, hns3, i40e and so on. If mbuf
data room size in mempool is greater then the maximum Rx buffer size
per descriptor
Add maximum Rx buffer size display.
Signed-off-by: Huisong Li
Acked-by: Chengwen Feng
---
app/test-pmd/config.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index b9fdb7e8f1..2ac6f15773 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/
This patch reports the maximum buffer size hardware supported.
Signed-off-by: Huisong Li
Acked-by: Chengwen Feng
---
drivers/net/hns3/hns3_common.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/hns3/hns3_common.c b/drivers/net/hns3/hns3_common.c
index 9327adbdc1..4b0e38cf67 10
The "min_rx_bufsize" in struct rte_eth_dev_info stands for the minimum
Rx buffer size supported by hardware. Actually, some engines also have
the maximum Rx buffer specification, like, hns3.
If mbuf data room size in mempool is greater then the maximum Rx buffer
size supported by HW, the data size
Hi Gowrishankar,
> -Original Message-
> From: Gowrishankar Muthukrishnan
> Sent: Thursday, November 2, 2023 10:04 AM
> To: dev@dpdk.org
> Cc: ano...@marvell.com; Akhil Goyal ; Ji, Kai
> ; Power, Ciara ; Gowrishankar
> Muthukrishnan
> Subject: [PATCH v2] crypto/openssl: fix memory leaks i
On Thu, Nov 02, 2023 at 11:55:41AM -0700, Stephen Hemminger wrote:
> On Thu, 2 Nov 2023 18:11:48 +
> Bruce Richardson wrote:
>
> > From: Bruce Richardson
> > To: dev@dpdk.org
> > Cc: step...@networkplumber.org, Bruce Richardson
> >
> > Subject: [PATCH] eal: add const to init function par
On Fri, Nov 03, 2023 at 10:11:08AM +, Konstantin Ananyev wrote:
>
> > Hi all,
> >
> > looking to start a discussion and get some input here.
> >
> > There are a number of our examples in DPDK which still track core usage via
> > a 64-bit bitmask, and, as such, cannot run on cores between 64
> Hi all,
>
> looking to start a discussion and get some input here.
>
> There are a number of our examples in DPDK which still track core usage via
> a 64-bit bitmask, and, as such, cannot run on cores between 64 and
> RTE_MAX_LCORE. Two examples I have recently come across with this issue are
Add myself for voluntary maintenance of the kvargs library.
Signed-off-by: Chengwen Feng
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4083658697..81f97a5e1e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1651,6 +1651,7 @@ F: examples/cmdline
Extract parse empty elements test as one stand-alone testcase. And
also fix the kvlist was not released when the branch fails.
Signed-off-by: Chengwen Feng
---
app/test/test_kvargs.c | 68 ++
1 file changed, 29 insertions(+), 39 deletions(-)
diff --git a/
The test_valid_kvargs() function is too long to understand, extract
the with keys tests as one stand-alone testcase.
Signed-off-by: Chengwen Feng
---
app/test/test_kvargs.c | 59 +-
1 file changed, 35 insertions(+), 24 deletions(-)
diff --git a/app/test/t
The test_valid_kvargs() function is too long to understand, extract
the basic token count tests as one stand-alone testcase.
Signed-off-by: Chengwen Feng
---
app/test/test_kvargs.c | 120 -
1 file changed, 45 insertions(+), 75 deletions(-)
diff --git a/ap
Introduce unit test suite framework for test_kvargs.c.
Signed-off-by: Chengwen Feng
---
app/test/test_kvargs.c | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/app/test/test_kvargs.c b/app/test/test_kvargs.c
index 7a60cac4c1..9aeb9aa0aa 100644
--- a/app/t
The test_valid_kvargs() function is too long to understand, extract
the without keys tests as one stand-alone testcase.
Signed-off-by: Chengwen Feng
---
app/test/test_kvargs.c | 115 ++---
1 file changed, 63 insertions(+), 52 deletions(-)
diff --git a/app/tes
Extract parse list value test as one stand-alone testcase.
Signed-off-by: Chengwen Feng
---
app/test/test_kvargs.c | 54 +-
1 file changed, 32 insertions(+), 22 deletions(-)
diff --git a/app/test/test_kvargs.c b/app/test/test_kvargs.c
index 28b93680f0..f4
When developing patchset [1], I found the kvargs test is hard to
understand when tried to add some testcase.
So refactor kvargs by:
1. introduce UT suite framework.
2. extract big test_valid_kvargs() to five part.
And add myself for voluntary maintenance of the kvargs library.
Note: to ensure p
On 11/2/23 19:18, Chautru, Nicolas wrote:
Hi Maxime,
-Original Message-
From: Maxime Coquelin
Sent: Thursday, November 2, 2023 10:00 AM
To: Chautru, Nicolas ; Vargas, Hernan
; dev@dpdk.org; gak...@marvell.com; Rix, Tom
; Hemant Agrawal
Cc: Zhang, Qi Z
Subject: Re: [PATCH v1 02/11]
Hi Ferruh,
Thanks for you review.
在 2023/11/3 9:31, Ferruh Yigit 写道:
On 8/2/2023 3:55 AM, Huisong Li wrote:
The command "tso set " is used to enable UFO, please
see commit ce8e6e742807 ("app/testpmd: support UFO in checksum engine")
The above patch configures the RTE_MBUF_F_TX_UDP_SEG to en
This driver could handles both key=value and only-key kvargs, so it
should use rte_kvargs_process_opt() instead of rte_kvargs_process() to
parse.
Signed-off-by: Chengwen Feng
---
drivers/net/tap/rte_eth_tap.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
dif
The mvneta_ifnames_get() function will save 'iface' value to ifnames,
it will out-of-bounds write if passed many iface pairs (e.g.
'iface=xxx,iface=xxx,...').
Fixes: 4ccc8d770d3b ("net/mvneta: add PMD skeleton")
Cc: sta...@dpdk.org
Signed-off-by: Chengwen Feng
---
drivers/net/mvneta/mvneta_ethd
The rte_kvargs_process() was used to parse key-value (e.g. socket_id=0),
it also supports to parse only-key (e.g. socket_id). But many drivers's
callback can only handle key-value, it will segment fault if handles
only-key. so the patchset [1] was introduced.
Because the patchset [1] modified too
This driver don't care about the 'iface' value, it should use
rte_kvargs_process_opt() instead of rte_kvargs_process() to parse.
Signed-off-by: Chengwen Feng
---
drivers/net/af_packet/rte_eth_af_packet.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/af_packe
1 - 100 of 105 matches
Mail list logo
