RE: [PATCH] vfio: add get device info API

2023-11-14 Thread Ye, MingjinX
Hi Nipun and all, Introducing new rte_vfio_get_device_info api in EAL to support getting information about devices. Could you provide some suggestions? Thanks, Mingjin > -Original Message- > From: Stephen Hemminger > Sent: Wednesday, November 15, 2023 8:12 AM > To: Ye, MingjinX > Cc:

Re: [PATCH v5 01/23] dts: code adjustments for doc generation

2023-11-14 Thread Juraj Linkeš
On Wed, Nov 8, 2023 at 2:35 PM Yoan Picchi wrote: > > On 11/6/23 17:15, Juraj Linkeš wrote: > > The standard Python tool for generating API documentation, Sphinx, > > imports modules one-by-one when generating the documentation. This > > requires code changes: > > * properly guarding argument pars

RE: [EXT] [PATCH v3 10/22] eal: replace strtok with reentrant version

2023-11-14 Thread Amit Prakash Shukla
> -Original Message- > From: Jie Hai > Sent: Tuesday, November 14, 2023 4:30 PM > To: dev@dpdk.org; Anatoly Burakov ; Amit > Prakash Shukla > Cc: haij...@huawei.com; lihuis...@huawei.com; > fengcheng...@huawei.com > Subject: [EXT] [PATCH v3 10/22] eal: replace strtok with reentrant versio

Re: [PATCH v3 1/7] dts: Add scatter test suite

2023-11-14 Thread Patrick Robb
On Mon, Nov 13, 2023 at 3:28 PM wrote: > From: Jeremy Spewock > > This test suite provides testing the support of scattered packets by > Poll Mode Drivers using testpmd. It incorporates 5 different test cases > which test the sending and receiving of packets with lengths that are > less than the

Re: [PATCH] vfio: add get device info API

2023-11-14 Thread Chenbo Xia
> On Nov 14, 2023, at 18:23, Mingjin Ye wrote: > > External email: Use caution opening links or attachments > > > This patch adds an API to support getting device information. > > The driver can use the "rte_vfio_get_device_info" helper to get > device information from EAL. > > Cc: sta...@d

[PATCH v3] net/axgbe: invoke correct API when offloads enabled

2023-11-14 Thread Jesna K E
A bug was introduced with the recent fix that when an offload feature is enabled axgbe_xmit_pkts_vec API is called rather than axgbe_xmit_pkts API.This patch fixes it. Fixes: 9963b5131af8 ("net/axgbe: support multi-process") Signed-off-by: Jesna K E --- drivers/net/axgbe/axgbe_ethdev.c | 6

Re: Reminder - DPDK Tech Board Meeting Tomorrow - Wed. 11/15/23 - 8am Pacific/10am Central/11am Eastern/1600h UTC

2023-11-14 Thread Nathan Southern
And I just realized that in my haste I forgot to change the header on that message - I should have said "Good evening DPDK *Community." *That's what I get for working 14 hours. See you tomorrow! Thanks! -Nathan On Tue, Nov 14, 2023 at 10:23 PM Nathan Southern < nsouth...@linuxfoundation.org> wrote

Reminder - DPDK Tech Board Meeting Tomorrow - Wed. 11/15/23 - 8am Pacific/10am Central/11am Eastern/1600h UTC

2023-11-14 Thread Nathan Southern
Good evening DPDK Tech Board Members, Our next meeting is tomorrow, Wed. November 15th - 8am Pacific/10am Central/11am Eastern/1600h UTC. As always, our read only agenda will be posted here. https://annuel.framapad.org/p/r.0c3cc4d1e011214183872a98f6b5c7db And zoom information to follow. We loo

[PATCH 5/5] net/nfp: fix null pointer dereferences

2023-11-14 Thread Chaoyong He
CI found null pointer dereferences problem. Coverity issue: 385406 Fixes: d7f6d9b21ffa ("net/nfp: adjust coding style for NFDk") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfdk/nfp_nfdk_dp.c | 3 +++ 1 file changed, 3 insert

[PATCH 4/5] net/nfp: fix integer shift problem

2023-11-14 Thread Chaoyong He
CI found integer handling issues, bad shift. Coverity issue: 385412 Fixes: e6858e7e7cd3 ("net/nfp: move shared target logic to own file") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfpcore/nfp_target.c | 2 +- 1 file changed

[PATCH 3/5] common/nfp: fix integer handling issues

2023-11-14 Thread Chaoyong He
CI found integer handling issues, overflow before widen. Coverity issue: 405351 Fixes: 87f5b35ba4e8 ("common/nfp: move queue logic") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/common/nfp/nfp_common.c | 4 ++-- 1 file changed, 2 inse

[PATCH 2/5] vdpa/nfp: fix integer handling issues

2023-11-14 Thread Chaoyong He
CI found integer handling issues, overflow before widen. Coverity issue: 405352 Fixes: 76ea5ebef08e ("vdpa/nfp: add notify related logic") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/vdpa/nfp/nfp_vdpa_core.c | 2 +- 1 file changed, 1

[PATCH 1/5] vdpa/nfp: fix checking return value

2023-11-14 Thread Chaoyong He
CI found calling 'rte_vfio_get_group_num()' without checking return value. Coverity issue: 405356 Fixes: 7b2a1228c59d ("vdpa/nfp: add remap PCI memory") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/vdpa/nfp/nfp_vdpa.c | 4 +++- 1 file

[PATCH 0/5] fix coverity issues

2023-11-14 Thread Chaoyong He
This patch series aims to fix some coverity issues: - Coverity issue 385406 - Coverity issue 385412 - Coverity issue 405351 - Coverity issue 405352 - Coverity issue 405356 Chaoyong He (5): vdpa/nfp: fix checking return value vdpa/nfp: fix integer handling issues common/nfp: fix integer handl

Re: [PATCH 00/21] replace strtok with strtok_r

2023-11-14 Thread fengchengwen
On 2023/11/15 1:49, Tyler Retzlaff wrote: > On Tue, Nov 14, 2023 at 09:34:33AM -0800, Tyler Retzlaff wrote: >> On Tue, Nov 14, 2023 at 09:32:48AM -0800, Tyler Retzlaff wrote: >>> On Tue, Nov 14, 2023 at 08:50:17PM +0800, Jie Hai wrote: On 2023/11/14 1:09, Tyler Retzlaff wrote: > On Mon, No

Re: [PATCH] vfio: add get device info API

2023-11-14 Thread Stephen Hemminger
On Tue, 14 Nov 2023 10:48:16 + Mingjin Ye wrote: > +/** > + * Get device information > + * > + * This function is only relevant to linux and will return > + * an error on BSD. > + * > + * @param sysfs_base > + * sysfs path prefix. > + * > + * @param dev_addr > + * device location. > + * >

Re: [PATCH v1] bus/pci: revise support PASID control

2023-11-14 Thread Chenbo Xia
On Nov 15, 2023, at 01:39, Sevincer, Abdullah wrote: > > External email: Use caution opening links or attachments > > >> +I don’t know about the details, so it means for different devices that >> support PASID, they have different offsets? > >> +Btw, Is this cap still not exposed to user spa

Re: [PATCH 00/43] replace strerror

2023-11-14 Thread Stephen Hemminger
On Tue, 14 Nov 2023 16:24:56 +0800 Dengdui Huang wrote: > The function strerror() is insecure in a multi-thread environment. > This series of patches fix it. In this patchset, only the libs and > drivers are modified. Doing such a global replace seems like a lot of changes for many cases that ar

Re: [PATCH] raw/cnxk_bphy: switch to dynamic logging

2023-11-14 Thread Stephen Hemminger
On Tue, 14 Nov 2023 09:04:46 +0100 Tomasz Duszynski wrote: > Dynamically allocated log type is a standard approach among all drivers. > Switch to it. > > Signed-off-by: Tomasz Duszynski > --- > drivers/raw/cnxk_bphy/cnxk_bphy.c | 32 +- > drivers/raw/cnxk_bphy/cnxk

Re: [PATCH v3 02/22] app/bbdev: replace strtok with reentrant version

2023-11-14 Thread Stephen Hemminger
On Tue, 14 Nov 2023 18:59:46 +0800 Jie Hai wrote: > Multiple threads calling the same function may cause condition > race issues, which often leads to abnormal behavior and can cause > more serious vulnerabilities such as abnormal termination, denial > of service, and compromised data integrity.

Re: [PATCH v3 01/22] app/graph: replace strtok with reentrant version

2023-11-14 Thread Stephen Hemminger
On Tue, 14 Nov 2023 18:59:45 +0800 Jie Hai wrote: > Multiple threads calling the same function may cause condition > race issues, which often leads to abnormal behavior and can cause > more serious vulnerabilities such as abnormal termination, denial > of service, and compromised data integrity.

Re: [PATCH v3 1/1] dts: bind to DPDK driver before running test suites

2023-11-14 Thread Jeremy Spewock
On Tue, Nov 14, 2023 at 4:49 PM Thomas Monjalon wrote: > 13/11/2023 18:56, Patrick Robb: > > On Thu, Nov 9, 2023 at 6:17 PM wrote: > > > > > From: Jeremy Spewock > > > > > > Modifies the current process so that we bind to os_driver_for_dpdk from > > > the configuration file before running test

release candidate 23.11-rc3

2023-11-14 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v23.11-rc3 There are 129 new patches in this snapshot. Release notes: https://doc.dpdk.org/guides/rel_notes/release_23_11.html Please test and report issues on bugs.dpdk.org. Only doc, tools, an

Re: [PATCH v3 1/1] dts: bind to DPDK driver before running test suites

2023-11-14 Thread Thomas Monjalon
13/11/2023 18:56, Patrick Robb: > On Thu, Nov 9, 2023 at 6:17 PM wrote: > > > From: Jeremy Spewock > > > > Modifies the current process so that we bind to os_driver_for_dpdk from > > the configuration file before running test suites and bind back to the > > os_driver afterwards. This allows test

Re: [PATCH v1 1/1] app/mldev: updates to device ops test

2023-11-14 Thread Thomas Monjalon
03/10/2023 17:47, Anup Prabhu: > From: Srikanth Yalavarthi > > Updated device_ops test to configure the device with user specific > > arguments. Fix handling unsupported values for queue_pairs and > > queue_size > > > > Fixes: c0e871657d6a ("app/mldev: support queue pairs and size") > > Cc: sta..

Re: [PATCH v2] vhost: make experimental API's stable

2023-11-14 Thread Maxime Coquelin
On 11/10/23 09:52, Maxime Coquelin wrote: From: Stephen Hemminger Transistion API's added from 2008 to 2022 to stable, except Vhost-async's which are likely to require changes to be adopted. Signed-off-by: Stephen Hemminger Signed-off-by: Maxime Coquelin --- lib/vhost/rte_vhost.h

Re: [PATCH v1 1/1] app/mldev: report device not found as error

2023-11-14 Thread Thomas Monjalon
05/10/2023 16:21, Shivah Shankar Shankar Narayan Rao: > From: Srikanth Yalavarthi > > > > Report ML device not found as error, instead of panic. > > > > Signed-off-by: Srikanth Yalavarthi > Acked-by: Shivah Shankar S Applied, thanks.

Re: [PATCH v2 1/1] app/mldev: fix check for filelist and models count

2023-11-14 Thread Thomas Monjalon
05/10/2023 11:14, Shivah Shankar Shankar Narayan Rao: > From: Srikanth Yalavarthi > > Fix incorrect check for filelist and models count. > > > > Fixes: bbd272edcb14 ("app/mldev: add ordered inferences") > > Fixes: f6661e6d9a3a ("app/mldev: validate model operations") > > Cc: sta...@dpdk.org > >

Re: [PATCH v1 1/1] app/mldev: fix file and buffer handling

2023-11-14 Thread Thomas Monjalon
04/10/2023 13:08, Anup Prabhu: > From: Srikanth Yalavarthi > > > > Addressed issues reported by klocwork static analysis tool. > > > > Fixes: fccf444cfe05 ("app/mldev: add function for file read") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Srikanth Yalavarthi > Acked-by: Anup Prabhu Appl

Re: [PATCH] eal/windows: fix memory management macros usage

2023-11-14 Thread Dmitry Kozlyuk
2023-11-14 19:05 (UTC+0200), Gregory Etelson: > Windows compilation with cross-mingw on Fedora 39 failed > because MEM_REPLACE_PLACEHOLDER and MEM_RESERVE_PLACEHOLDER were > already defined in the compiler environment: > > eal_memory.c:77: error: "MEM_REPLACE_PLACEHOLDER" redefined > /usr/x86_64-w

Re: [PATCH] eal/windows: fix memory management macros usage

2023-11-14 Thread Dmitry Kozlyuk
2023-11-14 10:22 (UTC-0800), Tyler Retzlaff: > On Tue, Nov 14, 2023 at 08:16:22PM +0200, Etelson, Gregory wrote: > > Hello Tyler, > > > > > > > >since we are duplicating something that comes from something else that > > >has been duplicated out of windows WDK here it might be a reasonable > > >s

Re: [PATCH] eal/windows: fix memory management macros usage

2023-11-14 Thread Etelson, Gregory
Hello Tyler, since we are duplicating something that comes from something else that has been duplicated out of windows WDK here it might be a reasonable safety check to verify that our duplicated values match our expectations? MEM_COALESCE_PLACEHOLDERS, MEM_PRESERVE_PLACEHOLDER, MEM_REPLACE_P

Re: [PATCH] app/test-pmd: fix L4 checksum with padding data

2023-11-14 Thread Ferruh Yigit
On 11/14/2023 2:19 AM, Deng, KaiwenX wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Friday, November 3, 2023 12:03 PM >> To: Deng, KaiwenX ; dev@dpdk.org >> Cc: sta...@dpdk.org; Yang, Qiming ; Zhou, YidingX >> ; Singh, Aman Deep ; >> Zhang, Yuying ; Matz, Olivier >> ; De

Re: [PATCH] eal/windows: fix memory management macros usage

2023-11-14 Thread Tyler Retzlaff
On Tue, Nov 14, 2023 at 08:16:22PM +0200, Etelson, Gregory wrote: > Hello Tyler, > > > > >since we are duplicating something that comes from something else that > >has been duplicated out of windows WDK here it might be a reasonable > >safety check to verify that our duplicated values match our >

Re: [PATCH] eal/windows: fix memory management macros usage

2023-11-14 Thread Etelson, Gregory
Hello Tyler, since we are duplicating something that comes from something else that has been duplicated out of windows WDK here it might be a reasonable safety check to verify that our duplicated values match our expectations? MEM_COALESCE_PLACEHOLDERS, MEM_PRESERVE_PLACEHOLDER, MEM_REPLACE_P

Re: [PATCH 00/21] replace strtok with strtok_r

2023-11-14 Thread Tyler Retzlaff
On Tue, Nov 14, 2023 at 09:34:33AM -0800, Tyler Retzlaff wrote: > On Tue, Nov 14, 2023 at 09:32:48AM -0800, Tyler Retzlaff wrote: > > On Tue, Nov 14, 2023 at 08:50:17PM +0800, Jie Hai wrote: > > > On 2023/11/14 1:09, Tyler Retzlaff wrote: > > > >On Mon, Nov 13, 2023 at 06:45:29PM +0800, Jie Hai wro

Re: [PATCH] eal/windows: fix memory management macros usage

2023-11-14 Thread Tyler Retzlaff
On Tue, Nov 14, 2023 at 07:05:29PM +0200, Gregory Etelson wrote: > Windows compilation with cross-mingw on Fedora 39 failed > because MEM_REPLACE_PLACEHOLDER and MEM_RESERVE_PLACEHOLDER were > already defined in the compiler environment: > > eal_memory.c:77: error: "MEM_REPLACE_PLACEHOLDER" redefi

RE: [PATCH v1] bus/pci: revise support PASID control

2023-11-14 Thread Sevincer, Abdullah
>+I don’t know about the details, so it means for different devices that >support PASID, they have different offsets? >+Btw, Is this cap still not exposed to user space in latest kernel? Yes, may be different offsets for different devices. As of now it is not exposed to user. Bruce's test was o

[PATCH v2] bus/pci: revise support PASID control

2023-11-14 Thread Abdullah Sevincer
This commit revises PASID control function to accept PASID offset to pasid *structure* instead of taking exact register for controlling the feature. PASID control function was introduced in earlier commit. Please see commit 5a6878335b81 ("event/dlb2: disable PASID") and commit 60ea19609aec ("bus/p

Re: [PATCH 00/21] replace strtok with strtok_r

2023-11-14 Thread Tyler Retzlaff
On Tue, Nov 14, 2023 at 09:32:48AM -0800, Tyler Retzlaff wrote: > On Tue, Nov 14, 2023 at 08:50:17PM +0800, Jie Hai wrote: > > On 2023/11/14 1:09, Tyler Retzlaff wrote: > > >On Mon, Nov 13, 2023 at 06:45:29PM +0800, Jie Hai wrote: > > >>Multiple threads calling the same function may cause condition

Re: [PATCH 00/21] replace strtok with strtok_r

2023-11-14 Thread Tyler Retzlaff
On Tue, Nov 14, 2023 at 08:50:17PM +0800, Jie Hai wrote: > On 2023/11/14 1:09, Tyler Retzlaff wrote: > >On Mon, Nov 13, 2023 at 06:45:29PM +0800, Jie Hai wrote: > >>Multiple threads calling the same function may cause condition > >>race issues, which often leads to abnormal behavior and can cause >

[Bug 1323] NIC RSS Symmetric hash is not working on Marvell OcteonTx2 (otx2) platform when configuring 4 tuple

2023-11-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1323 Bug ID: 1323 Summary: NIC RSS Symmetric hash is not working on Marvell OcteonTx2 (otx2) platform when configuring 4 tuple Product: DPDK Version: 20.11 Hardware: All

[PATCH] eal/windows: fix memory management macros usage

2023-11-14 Thread Gregory Etelson
Windows compilation with cross-mingw on Fedora 39 failed because MEM_REPLACE_PLACEHOLDER and MEM_RESERVE_PLACEHOLDER were already defined in the compiler environment: eal_memory.c:77: error: "MEM_REPLACE_PLACEHOLDER" redefined /usr/x86_64-w64-mingw32/sys-root/mingw/include/winnt.h:5710: note: this

Re: release candidate 23.11-rc2

2023-11-14 Thread Thinh Tran
IBM - Power Systems DPDK v23.11-rc2-3-gde0ec3c245 * Build CI on Fedora 30,31,34,36,37,38 for ppc64le * Basic PF on Mellanox: No issue found * Performance: not tested. * OS: RHEL 9.2 kernel: 5.14.0-284.25.1.el9_2.ppc64le with gcc version 11.3.1 20221121 (Red Hat 11.3.1-4) (GCC) R

Re: [PATCH v2] test/dma: fix for buffer auto free

2023-11-14 Thread Thomas Monjalon
06/11/2023 02:08, fengchengwen: > On 2023/11/4 2:30, Amit Prakash Shukla wrote: > > Buffer auto free test failed for more than 1 dma device as the device > > initialization for the test was been done only for the first dma > > device. This changeset fixes the same and also fixes the freeing of > >

Re: [PATCH] ethdev: add extension keyword to statement expression macro

2023-11-14 Thread Ferruh Yigit
On 11/11/2023 10:26 AM, Thomas Monjalon wrote: > 11/11/2023 00:25, Ferruh Yigit: >> On 11/10/2023 8:49 PM, Tyler Retzlaff wrote: >>> On Fri, Nov 10, 2023 at 05:22:52PM +, Ferruh Yigit wrote: On 11/9/2023 8:13 PM, Tyler Retzlaff wrote: > add missing __extension__ keyword to macros using

Re: [PATCH v2] app/dma-perf: fix lcores array out of bounds access

2023-11-14 Thread Thomas Monjalon
26/10/2023 11:53, Mingjin Ye: > The default size of the lcores array in the lcore dma map > is MAX_WORKER_NB. However, when parsing configuration > parameters, MAX_LCORE_NB is used as a constraint. > Since MAX_LCORE_NB is greater than MAX_WORKER_NB, this > causes array access to go out of bounds wh

Re: [PATCH v3] app/dma-perf: fix physical address seg-fault

2023-11-14 Thread Thomas Monjalon
24/10/2023 04:16, lihuisong (C): > > 在 2023/10/19 12:19, Vipin Varghese 写道: > > do_cpu_mem_copy uses DPDK API rte_mbuf_data_iova to return > > the start of the virtual address for both src and dst. > > But in case of iova mode set as PA, this results in seg-fault. > > This is because rte_memcpy us

Re: [PATCH v2 1/1] app/mldev: enable support for pre-quantized I/O

2023-11-14 Thread Thomas Monjalon
30/10/2023 06:15, Shivah Shankar Shankar Narayan Rao: > From: Srikanth Yalavarthi > > From: Anup Prabhu > > > > Enabled support for pre-quantized input and output in ML test application. > > > > Signed-off-by: Anup Prabhu > Acked-by: Shivah Shankar S Applied, thanks.

Re: [PATCH v1] bus/pci: revise support PASID control

2023-11-14 Thread Chenbo Xia
+Nipun Please cc me and Nipun if there is a new version. > On Nov 14, 2023, at 01:27, Abdullah Sevincer > wrote: > > External email: Use caution opening links or attachments > > > This commit revises PASID control function to accept PASID offset to > pasid *structure* instead of taking exact

[Bug 1320] ContourCafe

2023-11-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1320 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Resolution|--- |INVALID C

[Bug 1321] Tattoomagz

2023-11-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1321 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added CC||tho...@monjalon.net

[Bug 1322] Sharetok

2023-11-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1322 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Resolution|--- |INVALID C

RE: [EXT] Re: [PATCH v5 1/1] devtools: add tracepoint check in checkpatch

2023-11-14 Thread Ankur Dwivedi
>-Original Message- >From: Thomas Monjalon >Sent: Friday, September 1, 2023 12:59 PM >To: Morten Brørup ; Jerin Jacob > >Cc: Ankur Dwivedi ; Stephen Hemminger >; Jerin Jacob Kollanukkaran >; dev@dpdk.org; techbo...@dpdk.org >Subject: Re: [EXT] Re: [PATCH v5 1/1] devtools: add tracepoint

Re: [PATCH v2 00/14] eal: mark older API's as stable

2023-11-14 Thread David Marchand
On Fri, Oct 20, 2023 at 11:41 PM Stephen Hemminger wrote: > > About 80 function in EAL were marked experimental > and should have been made stable by now. > > v2 - rebase and fix some bits in wrong patch > > Stephen Hemminger (14): > eal: make bitops a stable API > eal: mark rte_dev API's as s

Re: [PATCH v2] net/gve: fix RX buffer size alignment

2023-11-14 Thread Ferruh Yigit
On 11/14/2023 2:41 AM, Guo, Junfeng wrote: > > >> -Original Message- >> From: Joshua Washington >> Sent: Tuesday, November 14, 2023 07:12 >> To: Guo, Junfeng ; Jeroen de Borst >> ; Rushil Gupta ; Joshua >> Washington ; Li, Xiaoyun >> Cc: dev@dpdk.org; sta...@dpdk.org; Ferruh Yigit >> S

Re: [PATCH 00/21] replace strtok with strtok_r

2023-11-14 Thread Jie Hai
On 2023/11/14 1:09, Tyler Retzlaff wrote: On Mon, Nov 13, 2023 at 06:45:29PM +0800, Jie Hai wrote: Multiple threads calling the same function may cause condition race issues, which often leads to abnormal behavior and can cause more serious vulnerabilities such as abnormal termination, denial of

[PATCH v3 41/42] vdpa/mlx5: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH v3 39/42] raw/ifpga: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/raw/ifpga/afu_pmd_n3000.c | 5 +++-- drivers/raw/ifpga/base/ifpga_fme_rsu.c | 12 +++--

[PATCH v3 40/42] vdpa/ifc: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/vdpa/ifc/ifcvf_vdpa.c | 23 --- 1 file changed, 12 insertions(+), 11 deletio

[PATCH v3 38/42] net/virtio: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/net/virtio/virtio_user/vhost_kernel.c | 8 +++--- .../net/virtio/virtio_user/vhost_kernel_tap.c

[PATCH v3 42/42] vdpa/sfc: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/vdpa/sfc/sfc_vdpa_ops.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v3 32/42] net/mlx4: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/net/mlx4/mlx4.c| 14 +++--- drivers/net/mlx4/mlx4_ethdev.c | 18 +---

[PATCH v3 36/42] net/tap: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/net/tap/rte_eth_tap.c | 26 +- drivers/net/tap/tap_flow.c| 18 ++

[PATCH v3 33/42] net/mlx5: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/net/mlx5/hws/mlx5dr_matcher.c | 2 +- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 20 ++

[PATCH v3 37/42] net/vhost: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/net/vhost/rte_eth_vhost.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --gi

[PATCH v3 28/42] net/i40e: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/net/i40e/i40e_testpmd.c | 42 - 1 file changed, 21 insertions(+)

[PATCH v3 21/42] net/bnxt: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/net/bnxt/bnxt_stats.c | 2 +- drivers/net/bnxt/rte_pmd_bnxt.c |

[PATCH v3 35/42] net/sfc: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/net/sfc/sfc_flow.c| 2 +- drivers/net/sfc/sfc_flow_tunnel.c | 2 +- drivers/net/sfc/sf

[PATCH v3 27/42] net/failsafe: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/net/failsafe/failsafe.c | 8 drivers/net/failsafe/failsafe_args.c| 4 ++--

[PATCH v3 31/42] net/memif: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/net/memif/memif_socket.c | 4 ++-- drivers/net/memif/rte_eth_memif.c | 20 ++--

[PATCH v3 34/42] net/qede: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/net/qede/qede_regs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dri

[PATCH v3 30/42] net/ixgbe: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/net/ixgbe/ixgbe_testpmd.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) di

[PATCH v3 29/42] net/ice: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/net/ice/ice_testpmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dr

[PATCH v3 25/42] net/dpaa2: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/net/dpaa2/dpaa2_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH v3 26/42] net/enetfec: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/net/enetfec/enet_uio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCH v3 24/42] net/dpaa: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/net/dpaa/dpaa_ethdev.c | 4 ++-- drivers/net/dpaa/fmlib/fm_lib.c | 6 +++--- 2 files changed, 5

[PATCH v3 23/42] net/bonding: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/net/bonding/bonding_testpmd.c | 4 ++-- drivers/net/bonding/rte_eth_bond_api.c | 2 +- driver

[PATCH v3 18/42] crypto/caam_jr: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/crypto/caam_jr/caam_jr_uio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --

[PATCH v3 22/42] net/af_xdp: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/net/af_xdp/rte_eth_af_xdp.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[PATCH v3 20/42] net/af_packet: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/net/af_packet/rte_eth_af_packet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[PATCH v3 15/42] bus/vmbus: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/bus/vmbus/linux/vmbus_bus.c | 7 --- drivers/bus/vmbus/linux/vmbus_uio.c | 21 +++

[PATCH v3 02/42] eal: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- lib/eal/common/eal_common_fbarray.c | 2 +- lib/eal/common/eal_common_options.c | 7 ++-- lib/

[PATCH v3 17/42] common/mlx5: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/common/mlx5/linux/mlx5_nl.c | 12 ++-- drivers/common/mlx5/mlx5_common.c| 6 +++---

[PATCH v3 19/42] dma/idxd: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/dma/idxd/idxd_bus.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff

[PATCH v3 13/42] bus/pci: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/bus/pci/bsd/pci.c| 8 drivers/bus/pci/linux/pci.c | 7 --- drivers/b

[PATCH v3 16/42] common/cnxk: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/common/cnxk/roc_dev.c | 4 +++- drivers/common/cnxk/roc_model.c | 4 +++- drivers/common/cnxk/

[PATCH v3 05/42] node: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- lib/node/kernel_tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/node/kernel

[PATCH v3 08/42] vhost: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- lib/vhost/socket.c | 13 +++-- lib/vhost/vduse.c | 31 ---

[PATCH v3 14/42] bus/vdev: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/bus/vdev/vdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/

[PATCH v3 00/42] replace strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This series of patches fix it. In this patchset, only the libs and drivers are modified. chang log: v2->v3 drop patch "telemetry: replace strerror" due to compile fail v1-v2 fix ci error Dengdui Huang (42): devtools: forbid use

[PATCH v3 10/42] bus/cdx: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/bus/cdx/cdx.c | 2 +- drivers/bus/cdx/cdx_vfio.c | 13 +++-- 2 files changed, 8 in

[PATCH v3 07/42] power: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- lib/power/guest_channel.c| 7 --- lib/power/power_kvm_vm.c | 3 ++- lib/power/power_

[PATCH v3 09/42] bpf: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- lib/bpf/bpf_load_elf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bpf/bpf_l

[PATCH v3 06/42] pdump: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- lib/pdump/rte_pdump.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/pdum

[PATCH v3 12/42] bus/fslmc: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/bus/fslmc/fslmc_vfio.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

[PATCH v3 01/42] devtools: forbid use of strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. rte_strerror() has been provided in DPDK to replace it. Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- devtools/checkpatches.sh | 8 1 file changed, 8 insertions(+) diff --git a/devtools/checkpatches.sh b/dev

[PATCH v3 04/42] latency: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- lib/latencystats/rte_latencystats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --gi

[PATCH v3 11/42] bus/dpaa: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- drivers/bus/dpaa/base/fman/fman.c | 2 +- drivers/bus/dpaa/dpaa_bus.c | 2 +- 2 files changed, 2 i

[PATCH v3 03/42] eventdev: use rte strerror

2023-11-14 Thread Dengdui Huang
The function strerror() is insecure in a multi-thread environment. This patch uses rte_strerror() to replace it. Cc: sta...@dpdk.org Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- lib/eventdev/rte_event_eth_rx_adapter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

  1   2   3   >