[V1 2/2] net/mlx5: use traffic class PRM field for IPv6 modification

2024-01-11 Thread Gavin Li
New PRM defined new field OUT_IPV6_TRAFFIC_CLASS for IPv6 which will be used by both IPv6 ECN and DSCP. A new cap bit modify_out_ipv6_traffic_class is added. It can be used to check if the new field is supported by FW. However, IPv6 ECN and DSCP starts from different offset in the same byte. Updat

[V1 1/2] net/mlx5: discover IPv6 traffic class support in RDMA core

2024-01-11 Thread Gavin Li
Previously, IPv6 traffic class used the same ids of IPv4 DSCP and ECN by rdam core and firmware. New FW support new IPv6 traffic class id which is recommended to be used though the old way is still working. FW exposed a new cap bit to indicate the supporting of the new id while RDMA core does not

[V1 0/2] use traffic class PRM field for IPv6 modification

2024-01-11 Thread Gavin Li
New field ID OUT_IPV6_TRAFFIC_CLASS for IPv6 was defined and will be used by both IPv6 ECN and DSCP. To apply the new ID and keep backward compatibility with different RDMA core and FW releases 1) detect the support of the new ID in RDMA core and FW. 2) apply the new ID if possible otherwise, keep

Re: [RFC] ethdev: introduce entropy calculation

2024-01-11 Thread Andrew Rybchenko
Hi Ori, sorry for delay with reply. On 12/17/23 13:07, Ori Kam wrote: Hi Andrew, -Original Message- From: Andrew Rybchenko Sent: Saturday, December 16, 2023 11:19 AM On 12/10/23 11:30, Ori Kam wrote: When offloading rules with the encap action, the HW may calculate entropy based o

Re: [PATCH 2/2] doc: multiple representors in one device

2024-01-11 Thread Andrew Rybchenko
On 1/11/24 09:44, Harman Kalra wrote: Updating the documentation with the pattern format for enabling multiple representors in one device Signed-off-by: Harman Kalra IMHO it should be squashed into previous patch.

Re: [PATCH 1/2] ethdev: parsing multiple representor devargs string

2024-01-11 Thread Andrew Rybchenko
On 1/11/24 09:44, Harman Kalra wrote: Adding support for parsing multiple representor devargs strings passed to a PCI BDF. There may be scenario where port representors for various PFs or VFs under PFs are required and all these are representor ports shall be backed by single pci device. In such

Re: [dpdk-dev] [v1] ethdev: support Tx queue used count

2024-01-11 Thread Jerin Jacob
On Thu, Jan 11, 2024 at 10:30 PM Stephen Hemminger wrote: > > On Thu, 11 Jan 2024 20:47:44 +0530 > wrote: > > > From: Jerin Jacob > > > > Introduce a new API to retrieve the number of used descriptors > > in a Tx queue. Applications can leverage this API in the fast path to > > inspect the Tx qu

Re: [dpdk-dev] [v1] ethdev: support Tx queue used count

2024-01-11 Thread Jerin Jacob
On Thu, Jan 11, 2024 at 9:50 PM Morten Brørup wrote: > > > From: jer...@marvell.com [mailto:jer...@marvell.com] > > Sent: Thursday, 11 January 2024 16.18 > > > > From: Jerin Jacob > > > > Introduce a new API to retrieve the number of used descriptors > > in a Tx queue. Applications can leverage

Re: [dpdk-dev] [v1] ethdev: support Tx queue used count

2024-01-11 Thread Jerin Jacob
On Thu, Jan 11, 2024 at 9:47 PM Andrew Rybchenko wrote: > > On 1/11/24 18:17, jer...@marvell.com wrote: > > From: Jerin Jacob > > > > Introduce a new API to retrieve the number of used descriptors > > in a Tx queue. Applications can leverage this API in the fast path to > > inspect the Tx queue o

RE: [PATCH 2/3] net/nfp: fix free resource problem

2024-01-11 Thread Chaoyong He
> On 1/11/2024 2:02 AM, Chaoyong He wrote: > >> On 1/9/2024 7:56 AM, Chaoyong He wrote: > On 12/18/2023 1:50 AM, Chaoyong He wrote: > >> On 12/14/2023 10:24 AM, Chaoyong He wrote: > >>> From: Long Wu > >>> > >>> Set the representor array to NULL to avoid that close interface >

RE: [PATCH] doc: update minimum Linux kernel version

2024-01-11 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, 11 January 2024 20.55 > > On Thu, 11 Jan 2024 20:26:56 +0100 > Morten Brørup wrote: > > > > > > > When the documentation specifies a minimum required kernel version, > it implicitly claims that DPDK works with that k

[PATCH v3] dts: add Dockerfile

2024-01-11 Thread jspewock
From: Juraj Linkeš The Dockerfile defines development and CI runner images. Signed-off-by: Juraj Linkeš Signed-off-by: Jeremy Spewock --- v3: Remove pexpect. v2: This verson updates the dockerfile to instead install poetry using pipx due to the version of poetry installed using the package

[PATCH v2] dts: add Dockerfile

2024-01-11 Thread jspewock
From: Juraj Linkeš The Dockerfile defines development and CI runner images. Signed-off-by: Juraj Linkeš Signed-off-by: Jeremy Spewock --- v2: This verson updates the dockerfile to instead install poetry using pipx due to the version of poetry installed using the package repositories of the di

gve: mixes DPDK and Linux versions in compatibility check

2024-01-11 Thread Stephen Hemminger
This seems wrong: *driver_info = (struct gve_driver_info) { .os_type = 5, /* DPDK */ .driver_major = GVE_VERSION_MAJOR, .driver_minor = GVE_VERSION_MINOR, .driver_sub = GVE_VERSION_SUB, .os_version_major = cpu_t

Re: [PATCH] doc: update minimum Linux kernel version

2024-01-11 Thread Patrick Robb
On Thu, Jan 11, 2024 at 2:27 PM Morten Brørup wrote: > *From:* Patrick Robb [mailto:pr...@iol.unh.edu] > *Sent:* Thursday, 11 January 2024 20.02 > > > > On Thu, Jan 11, 2024 at 4:18 AM Morten Brørup > wrote: > > > I wonder if any automated tests are using this specific kernel version, or > if we

RE: [PATCH] doc: update minimum Linux kernel version

2024-01-11 Thread Morten Brørup
From: Patrick Robb [mailto:pr...@iol.unh.edu] Sent: Thursday, 11 January 2024 20.02 On Thu, Jan 11, 2024 at 4:18 AM Morten Brørup wrote: I wonder if any automated tests are using this specific kernel version, or if we are only testing using the distros' native kernels. @

Re: [PATCH] doc: update minimum Linux kernel version

2024-01-11 Thread Patrick Robb
On Thu, Jan 11, 2024 at 4:18 AM Morten Brørup wrote: > > I wonder if any automated tests are using this specific kernel version, or > if we are only testing using the distros' native kernels. @Aaron? > For UNH, we generally run from the distros' native kernels. Any exceptions are not for testing

Re: [PATCH] doc: update minimum Linux kernel version

2024-01-11 Thread Aaron Conole
Morten Brørup writes: >> From: Stephen Hemminger [mailto:step...@networkplumber.org] >> Sent: Wednesday, 10 January 2024 17.58 >> >> The last version of 4.14 kernel was just released (4.14.336), >> and it is now end of life. Update the DPDK kernel minimum version >> to the next LTS kernel versio

RE: [PATCH v2 14/22] telemetry: replace strtok with reentrant version

2024-01-11 Thread Power, Ciara
> -Original Message- > From: Jie Hai > Sent: Tuesday, November 14, 2023 8:41 AM > To: dev@dpdk.org; Power, Ciara ; Wiles, Keith > ; Richardson, Bruce > Cc: haij...@huawei.com; lihuis...@huawei.com; > fengcheng...@huawei.com > Subject: [PATCH v2 14/22] telemetry: replace strtok with ree

RE: [PATCH v2 04/22] app/crypto-perf: replace strtok with reentrant version

2024-01-11 Thread Power, Ciara
Hi Jie Hai, > -Original Message- > From: Jie Hai > Sent: Tuesday, November 14, 2023 8:41 AM > To: dev@dpdk.org; Power, Ciara ; Sergio Gonzalez > Monroy ; De Lara Guarch, Pablo > ; Piotr Azarewicz > ; Kobylinski, Michal > ; Mrozowicz, SlawomirX > ; Kerlin, Marcin ; > Doherty, Declan > Cc:

Re: [PATCH v2] app/testpmd: use Tx preparation in txonly engine

2024-01-11 Thread Stephen Hemminger
On Thu, 11 Jan 2024 13:25:55 +0800 Kaiwen Deng wrote: > Txonly forwarding engine does not call the Tx preparation API > before transmitting packets. This may cause some problems. > > TSO breaks when MSS spans more than 8 data fragments. Those > packets will be dropped by Tx preparation API, but

Re: [dpdk-dev v4 2/2] net/tap: fix buffer overflow for ptypes list through driver API update

2024-01-11 Thread Andrew Rybchenko
On 1/4/24 20:51, Sivaramakrishnan Venkat wrote: Incorrect ptypes list causes buffer overflow for Address Sanitizer run. Previously, the last element in the ptypes lists to be "RTE_PTYPE_UNKNOWN" for rte_eth_dev_get_supported_ptypes(), but this was not clearly documented and many PMDs did not foll

RE: [dpdk-dev] [v1] ethdev: support Tx queue used count

2024-01-11 Thread Morten Brørup
> From: jer...@marvell.com [mailto:jer...@marvell.com] > Sent: Thursday, 11 January 2024 16.18 > > From: Jerin Jacob > > Introduce a new API to retrieve the number of used descriptors > in a Tx queue. Applications can leverage this API in the fast path to > inspect the Tx queue occupancy and tak

Re: [dpdk-dev] [v1] ethdev: support Tx queue used count

2024-01-11 Thread Andrew Rybchenko
On 1/11/24 18:17, jer...@marvell.com wrote: From: Jerin Jacob Introduce a new API to retrieve the number of used descriptors in a Tx queue. Applications can leverage this API in the fast path to inspect the Tx queue occupancy and take appropriate actions based on the available free descriptors.

[dpdk-dev] [v1] ethdev: support Tx queue used count

2024-01-11 Thread jerinj
From: Jerin Jacob Introduce a new API to retrieve the number of used descriptors in a Tx queue. Applications can leverage this API in the fast path to inspect the Tx queue occupancy and take appropriate actions based on the available free descriptors. A notable use case could be implementing Ran

Re: [dpdk-dev v4 2/2] net/tap: fix buffer overflow for ptypes list through driver API update

2024-01-11 Thread Ferruh Yigit
On 1/4/2024 5:51 PM, Sivaramakrishnan Venkat wrote: > Incorrect ptypes list causes buffer overflow for Address Sanitizer > run. Previously, the last element in the ptypes lists to be > "RTE_PTYPE_UNKNOWN" for rte_eth_dev_get_supported_ptypes(), but this was > not clearly documented and many PMDs di

Re: [dpdk-dev v4 1/2] net/tap: fix buffer overflow for ptypes list through updation of last element.

2024-01-11 Thread Ferruh Yigit
On 1/4/2024 5:51 PM, Sivaramakrishnan Venkat wrote: > Incorrect ptypes list causes buffer overflow for Address Sanitizer > run. > I think it cause buffer overflow anyway, but detected with Address Sanitizer, so perhaps we can say: "Address Sanitizer detected buffer overflow caused by incorrect pt

Re: [v7 1/1] net/af_xdp: fix multi interface support for K8s

2024-01-11 Thread Ferruh Yigit
On 1/11/2024 12:21 PM, Maryam Tahhan wrote: > On 11/01/2024 11:35, Ferruh Yigit wrote: >> Devarg is user interface, changing it impacts the user. >> >> Assume that user of '22.11.3' using 'use_cni' dev_arg, it will be broken >> when user upgrades DPDK to '22.11.4', which is not expected. >> >> dev_

Re: [PATCH 2/2] net/virtio-user: add VIRTIO_NET_F_RSS to supported features

2024-01-11 Thread Maxime Coquelin
Hi, On 12/8/23 06:31, Srujana Challa wrote: This patch introduces new function to get rss device config and adds code to forward the RSS control command to backend through hw control queue if RSS feature is negotiated. This patch will help to negotiate VIRTIO_NET_F_RSS feature if vhost-vdpa back

Re: [PATCH 1/2] net/virtio-user: improve kick performance with notification area mapping

2024-01-11 Thread Maxime Coquelin
Hi Srujana, Thanks for your contribution! Is it possible to provide information on which hardware it can be tested on? On 12/8/23 06:31, Srujana Challa wrote: This patch introduces new virtio-user callback to map the vq notification area and implements it for the vhost-vDPA backend. This is sim

Re: [v7 1/1] net/af_xdp: fix multi interface support for K8s

2024-01-11 Thread Kevin Traynor
On 11/01/2024 12:21, Maryam Tahhan wrote: > On 11/01/2024 11:35, Ferruh Yigit wrote: >> Devarg is user interface, changing it impacts the user. >> >> Assume that user of '22.11.3' using 'use_cni' dev_arg, it will be broken >> when user upgrades DPDK to '22.11.4', which is not expected. >> >> dev_ar

Re: [PATCH] ethdev: add dump regs for telemetry

2024-01-11 Thread fengchengwen
Hi Ferruh, On 2024/1/11 19:11, Ferruh Yigit wrote: > On 1/11/2024 1:55 AM, fengchengwen wrote: >> Hi Ferruh, >> >> On 2024/1/10 20:15, Ferruh Yigit wrote: >>> On 1/10/2024 1:38 AM, fengchengwen wrote: Hi Ferruh, On 2024/1/10 2:06, Ferruh Yigit wrote: > On 1/9/2024 2:19 AM, Jie H

Re: [PATCH 2/3] net/nfp: fix free resource problem

2024-01-11 Thread Ferruh Yigit
On 1/11/2024 2:02 AM, Chaoyong He wrote: >> On 1/9/2024 7:56 AM, Chaoyong He wrote: On 12/18/2023 1:50 AM, Chaoyong He wrote: >> On 12/14/2023 10:24 AM, Chaoyong He wrote: >>> From: Long Wu >>> >>> Set the representor array to NULL to avoid that close interface >>> does no

Re: [v7 1/1] net/af_xdp: fix multi interface support for K8s

2024-01-11 Thread Maryam Tahhan
On 11/01/2024 11:35, Ferruh Yigit wrote: Devarg is user interface, changing it impacts the user. Assume that user of '22.11.3' using 'use_cni' dev_arg, it will be broken when user upgrades DPDK to '22.11.4', which is not expected. dev_arg is not API/ABI but as it impacts the user, it is in the

Re: [PATCH] net/vmxnet3: fix use of interrupts on FreeBSD

2024-01-11 Thread Ferruh Yigit
On 1/9/2024 4:00 PM, Lewis Donzis wrote: > > > - On Jan 9, 2024, at 8:23 AM, Bruce Richardson bruce.richard...@intel.com > wrote: > >> DPDK does not support interrupts on FreeBSD, so the vmxnet3 driver >> returns error when enabling interrupts as it initializes. We can fix >> this by #ifdef

Re: [v7 1/1] net/af_xdp: fix multi interface support for K8s

2024-01-11 Thread Ferruh Yigit
On 1/11/2024 9:01 AM, Maryam Tahhan wrote: > On 10/01/2024 15:21, Ferruh Yigit wrote: >> On 1/10/2024 2:58 PM, Maryam Tahhan wrote: >>> Hi folks >>> >>> Just wondering if there's any other comments re this patch after all the >>> review comments were addressed? >>> >> Hi Maryam, >> >> There was a r

Re: [PATCH] ethdev: add dump regs for telemetry

2024-01-11 Thread Ferruh Yigit
On 1/11/2024 1:55 AM, fengchengwen wrote: > Hi Ferruh, > > On 2024/1/10 20:15, Ferruh Yigit wrote: >> On 1/10/2024 1:38 AM, fengchengwen wrote: >>> Hi Ferruh, >>> >>> On 2024/1/10 2:06, Ferruh Yigit wrote: On 1/9/2024 2:19 AM, Jie Hai wrote: > On 2023/12/14 20:49, Ferruh Yigit wrote:

Re: [PATCH v8 0/7] dts: Port scatter suite over

2024-01-11 Thread Juraj Linkeš
Luca, Yoan or Paul, could please have a look at this patch? I don't have any more comments, but I'd like to have someone else have a look at this. For the whole series: Reviewed-by: Juraj Linkeš On Wed, Jan 10, 2024 at 3:43 PM wrote: > > From: Jeremy Spewock > > v8: > > Address comments by mak

Re: [PATCH] build: fix linker warnings about undefined symbols

2024-01-11 Thread Bruce Richardson
On Thu, Jan 11, 2024 at 10:38:05AM +0100, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Wednesday, 10 January 2024 17.58 > > > > On Wed, Jan 10, 2024 at 03:01:03PM +, Bruce Richardson wrote: > > > The default behaviour of "ld.lld" has changed, so

RE: [PATCH] build: fix linker warnings about undefined symbols

2024-01-11 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 10 January 2024 17.58 > > On Wed, Jan 10, 2024 at 03:01:03PM +, Bruce Richardson wrote: > > The default behaviour of "ld.lld" has changed, so it now prints out > > warnings about entries in the version.map file whi

RE: [PATCH] doc: update minimum Linux kernel version

2024-01-11 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 10 January 2024 17.58 > > The last version of 4.14 kernel was just released (4.14.336), > and it is now end of life. Update the DPDK kernel minimum version > to the next LTS kernel version. > > Signed-off-by: Stephen

Re: vmxnet3 no longer functional on DPDK 21.11

2024-01-11 Thread Lewis Donzis
- On Jan 9, 2024, at 5:55 PM, Stephen Hemminger step...@networkplumber.org wrote: > Probably need to go further with this. > - what about unreigster in vmxnet3_dev_stop > - vmxnet3_interrupt_handler is then dead code, should it be #ifdef guarded? > - and vmxnet3_dev_rx_queue_intr_enable/dis

Re: [v7 1/1] net/af_xdp: fix multi interface support for K8s

2024-01-11 Thread Maryam Tahhan
On 10/01/2024 15:21, Ferruh Yigit wrote: On 1/10/2024 2:58 PM, Maryam Tahhan wrote: Hi folks Just wondering if there's any other comments re this patch after all the review comments were addressed? Hi Maryam, There was a request from David, to the previous version, that fixes (either to code

Re: 22.11.4 patches review and test

2024-01-11 Thread Maxime Coquelin
On 1/11/24 09:44, Xueming(Steven) Li wrote: -Original Message- From: Maxime Coquelin Sent: 1/11/2024 16:27 To: Xueming(Steven) Li ; Xu, HailinX Cc: dev@dpdk.org; Abhishek Marathe ; Ali Alnubani ; benjamin.wal...@intel.com; sta...@dpdk.org; David Christensen ; Hemant Agrawal ; Stok

RE: 22.11.4 patches review and test

2024-01-11 Thread Xueming(Steven) Li
> -Original Message- > From: Maxime Coquelin > Sent: 1/11/2024 16:27 > To: Xueming(Steven) Li ; Xu, HailinX > > Cc: dev@dpdk.org; Abhishek Marathe ; Ali > Alnubani ; benjamin.wal...@intel.com; sta...@dpdk.org; > David Christensen ; Hemant Agrawal > ; Stokes, Ian ; Jerin Jacob > ; Mcnama

Re: 22.11.4 patches review and test

2024-01-11 Thread Maxime Coquelin
Hi, On 1/11/24 07:32, Xueming(Steven) Li wrote: Hi Hainlin, Thanks very much for test test and report! Let me know once any progress with the known issue. Thanks, Xueming. -Original Message- From: Xu, HailinX Sent: 1/11/2024 9:42 To: Xueming(Steven) Li ; sta...@dpdk.org Cc: dev@dpdk