RE: [PATCH v3 2/3] ethdev: add compare item

2024-01-31 Thread Ori Kam
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, January 31, 2024 7:54 PM > > On 1/31/2024 5:43 PM, Ori Kam wrote: > > > > > >> -Original Message- > >> From: Ferruh Yigit > >> Sent: Wednesday, January 31, 2024 6:46 PM > >> Subject: Re: [PATCH v3 2/3] ethdev: add com

RE: [Patch v2] net/mana: use rte_pktmbuf_alloc_bulk for allocating RX WQEs

2024-01-31 Thread Long Li
> >> 'mbufs' is temporarily storage for allocated mbuf pointers, why not > >> allocate if from stack instead, can be faster and easier to manage: > >> "struct rte_mbuf *mbufs[count]" > > > > That would introduce a variable length array. > > VLA's should be removed, they are not supported on Windows

[Patch v3] net/mana: use rte_pktmbuf_alloc_bulk for allocating RX WQEs

2024-01-31 Thread longli
From: Long Li Instead of allocating mbufs one by one during RX, use rte_pktmbuf_alloc_bulk() to allocate them in a batch. There are no measurable performance improvements in benchmarks. However, this patch should improve CPU cycles and reduce potential locking conflicts in real-world application

[PATCH 2/2] net/ngbe: add vectorized functions for Rx/Tx

2024-01-31 Thread Jiawen Wu
To optimize Rx/Tx burst process, add SSE/NEON vector instructions on x86/arm architecture. Signed-off-by: Jiawen Wu --- drivers/net/ngbe/meson.build| 6 + drivers/net/ngbe/ngbe_ethdev.c | 6 + drivers/net/ngbe/ngbe_ethdev.h | 1 + drivers/net/ngbe/ngbe_rxtx.c

[PATCH 1/2] net/txgbe: add vectorized functions for Rx/Tx

2024-01-31 Thread Jiawen Wu
To optimize Rx/Tx burst process, add SSE/NEON vector instructions on x86/arm architecture. Signed-off-by: Jiawen Wu --- drivers/net/txgbe/meson.build | 6 + drivers/net/txgbe/txgbe_ethdev.c | 6 + drivers/net/txgbe/txgbe_ethdev.h | 1 + drivers/net/txgbe/txgbe

[PATCH 0/2] Wangxun support vector Rx/Tx

2024-01-31 Thread Jiawen Wu
Add SSE/NEON vector instructions for TXGBE and NGBE driver to process packets. Jiawen Wu (2): net/txgbe: add vectorized functions for Rx/Tx net/ngbe: add vectorized functions for Rx/Tx drivers/net/ngbe/meson.build | 6 + drivers/net/ngbe/ngbe_ethdev.c| 6 + drive

Re: [PATCH 2/2] app/graph: fix build reason

2024-01-31 Thread fengchengwen
Acked-by: Chengwen Feng On 2024/2/1 1:45, David Marchand wrote: > When a component is disabled, the reason meson variable must be set to > provide an explanation why. > > Since epoll is a Linux thing, report that the graph application is only > supported on Linux. > > Fixes: 5b21ffb23308 ("app/

[PATCH v4 3/3] net/mlx5: add compare item support

2024-01-31 Thread Suanming Mou
The compare item allows adding flow match with comparison result. This commit adds compare item support to the PMD code. Due to HW limitation: - Only HWS supported. - Only 32-bit comparison is supported. - Only single compare flow is supported in the flow table. - Only match with compare resul

[PATCH v4 2/3] ethdev: add compare item

2024-01-31 Thread Suanming Mou
The new item type is added for the case user wants to match traffic based on packet field compare result with other fields or immediate value. e.g. take advantage the compare item user will be able to accumulate a IPv4/TCP packet's TCP data_offset and IPv4 IHL field to a tag register, then compare

[PATCH v4 1/3] ethdev: rename action modify field data structure

2024-01-31 Thread Suanming Mou
Current rte_flow_action_modify_data struct describes the pkt field perfectly and is used only in action. It is planned to be used for item as well. This commit renames it to "rte_flow_field_data" making it compatible to be used by item. Signed-off-by: Suanming Mou Acked-by: Ori Kam Acked-by: An

[PATCH v4 0/3] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE

2024-01-31 Thread Suanming Mou
The new item type is added for the case user wants to match traffic based on packet field compare result with other fields or immediate value. e.g. take advantage the compare item user will be able to accumulate a IPv4/TCP packet's TCP data_offset and IPv4 IHL field to a tag register, then compare

RE: [PATCH v3 2/3] ethdev: add compare item

2024-01-31 Thread Suanming Mou
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, February 1, 2024 12:46 AM > To: Ori Kam ; Suanming Mou ; > Aman Singh ; Yuying Zhang > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Andrew Rybchenko > > Cc: dev@dpdk.org > Subject: Re: [PATCH v3 2/3] ethdev: add compare item >

RE: [PATCH] mbuf: replace GCC marker extension with C11 anonymous unions

2024-01-31 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 31 January 2024 21.46 > > On Wed, Jan 31, 2024 at 01:49:34PM +, Bruce Richardson wrote: > > On Tue, Jan 30, 2024 at 03:26:13PM -0800, Tyler Retzlaff wrote: > > > Replace the use of RTE_MARKER with C11 anonymous uni

RE: [PATCH] mbuf: replace GCC marker extension with C11 anonymous unions

2024-01-31 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 31 January 2024 22.09 > > On Wed, Jan 31, 2024 at 10:18:37AM +0100, Morten Brørup wrote: > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > Sent: Wednesday, 31 January 2024 00.26 > > > [...] > > >

[PATCH v5 5/5] net/gve: add RSS redirection table update support

2024-01-31 Thread Joshua Washington
This patch introduces support for updating the RSS redirection table in the GVE PMD through the implementation of rss_reta_update and rss_reta_query. Due to an infrastructure limitation, the RSS hash key must be manually configured before the redirection table can be updated or queried. The redire

[PATCH v5 4/5] net/gve: add RSS configuration update support

2024-01-31 Thread Joshua Washington
This patch adds support for updating the RSS hash key and hash fields in the GVE PMD through the implementation of rss_hash_update and rss_hash_conf_get. The RSS hash key for gVNIC is required to be 40 bytes. On initial configuration of the RSS hash key, the RSS redirection table will be set to a

[PATCH v5 3/5] net/gve: add gve RSS library

2024-01-31 Thread Joshua Washington
This change includes a number of helper functions to facilitate RSS configuration on the GVE DPDK driver. These methods are declared in gve_rss.h. Signed-off-by: Joshua Washington Reviewed-by: Rushil Gupta Reviewed-by: Jeroen de Borst --- drivers/net/gve/base/gve_adminq.h | 10 +- drivers/net

[PATCH v5 2/5] net/gve: add RSS adminq command

2024-01-31 Thread Joshua Washington
This change introduces admin queue changes that enable the configuration of RSS parameters for the GVE driver. Signed-off-by: Joshua Washington Reviewed-by: Rushil Gupta Reviewed-by: Jeroen de Borst --- drivers/net/gve/base/gve.h| 15 drivers/net/gve/base/gve_adminq.c | 58 +++

[PATCH v5 1/5] net/gve: expose RSS offload support in dev info

2024-01-31 Thread Joshua Washington
This patch communicates that the GVE driver supports RSS, along with the RSS offloads supported by the driver. Signed-off-by: Joshua Washington Reviewed-by: Rushil Gupta Reviewed-by: Jeroen de Borst --- drivers/net/gve/gve_ethdev.c | 4 +++- drivers/net/gve/gve_ethdev.h | 8 2 files c

[PATCH v5 0/5] net/gve: RSS Support for GVE Driver

2024-01-31 Thread Joshua Washington
This patch series introduces RSS support for the GVE poll-mode driver. This series includes implementations of the following eth_dev_ops: 1) rss_hash_update 2) rss_hash_conf_get 3) reta_query 4) reta_update In rss_hash_update, the GVE driver supports the following RSS hash types: * RTE_ETH_RSS_I

Re: [PATCH] mbuf: replace GCC marker extension with C11 anonymous unions

2024-01-31 Thread Tyler Retzlaff
On Wed, Jan 31, 2024 at 10:18:37AM +0100, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Wednesday, 31 January 2024 00.26 > > > > Replace the use of RTE_MARKER with C11 anonymous unions to improve > > code portability between toolchains. > > > > Upda

Re: [PATCH] mbuf: replace GCC marker extension with C11 anonymous unions

2024-01-31 Thread Tyler Retzlaff
On Wed, Jan 31, 2024 at 01:49:34PM +, Bruce Richardson wrote: > On Tue, Jan 30, 2024 at 03:26:13PM -0800, Tyler Retzlaff wrote: > > Replace the use of RTE_MARKER with C11 anonymous unions to improve > > code portability between toolchains. > > > > Update use of rte_mbuf rearm_data field in net

Re: [PATCH 2/2] app/graph: fix build reason

2024-01-31 Thread Tyler Retzlaff
On Wed, Jan 31, 2024 at 06:45:52PM +0100, David Marchand wrote: > When a component is disabled, the reason meson variable must be set to > provide an explanation why. > > Since epoll is a Linux thing, report that the graph application is only > supported on Linux. > > Fixes: 5b21ffb23308 ("app/gr

Re: [PATCH 1/2] build: fix reasons conflict

2024-01-31 Thread Tyler Retzlaff
On Wed, Jan 31, 2024 at 06:02:49PM +, Bruce Richardson wrote: > On Wed, Jan 31, 2024 at 06:45:51PM +0100, David Marchand wrote: > > The "_disable_reason" variables are subject to naming conflicts. > > > > This has been caught while looking at mingw builds where the graph > > application was sk

[PATCH v2 2/2] vhost: add new mbuf allocation failure statistic

2024-01-31 Thread Maxime Coquelin
This patch introduces a new, per virtqueue, mbuf allocation failure statistic. It can be useful to troubleshoot packets drops due to insufficient mempool size or memory leaks. Signed-off-by: Maxime Coquelin --- lib/vhost/vhost.c | 1 + lib/vhost/vhost.h | 1 + lib/vhost/virtio_net.c

[PATCH v2 1/2] vhost: fix memory leak in Virtio Tx split path

2024-01-31 Thread Maxime Coquelin
When vIOMMU is enabled and Virtio device is bound to kernel driver in guest, rte_vhost_dequeue_burst() will often return early because of IOTLB misses. This patch fixes a mbuf leak occurring in this case. Fixes: 242695f6122a ("vhost: allocate and free packets in bulk in Tx split") Cc: sta...@dpdk

Re: [RFC v3] eal: add bitset type

2024-01-31 Thread Mattias Rönnblom
On 2024-01-31 17:06, Stephen Hemminger wrote: On Wed, 31 Jan 2024 14:13:01 +0100 Mattias Rönnblom wrote: +/** + * @file + * RTE Bitset + * + * This file provides functions and macros for querying and + * manipulating sets of bits kept in arrays of @c uint64_t-sized + * elements. + * + * The bi

RE: [PATCH 0/4] introduce encap hash calculation

2024-01-31 Thread Dariusz Sosnowski
> -Original Message- > From: Ori Kam > Sent: Sunday, January 28, 2024 10:40 > To: Dariusz Sosnowski ; ferruh.yi...@amd.com; > cristian.dumitre...@intel.com; andrew.rybche...@oktetlabs.ru; > step...@networkplumber.org > Cc: dev@dpdk.org; Ori Kam ; Raslan Darawsheh > > Subject: [PATCH 0/4]

Re: [PATCH 1/2] build: fix reasons conflict

2024-01-31 Thread Bruce Richardson
On Wed, Jan 31, 2024 at 06:45:51PM +0100, David Marchand wrote: > The "_disable_reason" variables are subject to naming conflicts. > > This has been caught while looking at mingw builds where the graph > application was skipped with an (which is caused by a > missing reason variable set in app/gr

Re: [PATCH v2 10/11] eventdev: RFC clarify comments on scheduling types

2024-01-31 Thread Bruce Richardson
On Tue, Jan 23, 2024 at 05:19:18PM +0100, Mattias Rönnblom wrote: > On 2024-01-19 18:43, Bruce Richardson wrote: > > The description of ordered and atomic scheduling given in the eventdev > > doxygen documentation was not always clear. Try and simplify this so > > that it is clearer for the end-use

Re: [PATCH v3 2/3] ethdev: add compare item

2024-01-31 Thread Ferruh Yigit
On 1/31/2024 5:43 PM, Ori Kam wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Wednesday, January 31, 2024 6:46 PM >> Subject: Re: [PATCH v3 2/3] ethdev: add compare item >> >> On 1/31/2024 3:56 PM, Ori Kam wrote: >>> Hi >>> -Original Message- From: Suanm

[PATCH 1/2] build: fix reasons conflict

2024-01-31 Thread David Marchand
The "_disable_reason" variables are subject to naming conflicts. This has been caught while looking at mingw builds where the graph application was skipped with an (which is caused by a missing reason variable set in app/graph/meson.build) and the graph library was skipped with the same too, eve

[PATCH 2/2] app/graph: fix build reason

2024-01-31 Thread David Marchand
When a component is disabled, the reason meson variable must be set to provide an explanation why. Since epoll is a Linux thing, report that the graph application is only supported on Linux. Fixes: 5b21ffb23308 ("app/graph: add CLI framework") Cc: sta...@dpdk.org Signed-off-by: David Marchand -

[PATCH 2/2] ci: update versions of actions in GHA

2024-01-31 Thread David Marchand
GitHub started deprecating GHA actions based on Node 16 [1]. For now, only warnings are raised, but we might as well switch to v4 versions of the common actions, now. Link: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ Cc: sta...@dpdk.org Signed-

[PATCH 1/2] ci: bump tested distributions in GHA

2024-01-31 Thread David Marchand
Fedora 37 has reached end of life in December 2023. Ubuntu 20.04 is getting quite old. Switch to more recent versions. With this move, some packages provided by those distributions are now recent enough to extend our build coverage. Install additional dependencies like ipsec-mb, isal and other li

RE: [PATCH v3 2/3] ethdev: add compare item

2024-01-31 Thread Ori Kam
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, January 31, 2024 6:46 PM > Subject: Re: [PATCH v3 2/3] ethdev: add compare item > > On 1/31/2024 3:56 PM, Ori Kam wrote: > > Hi > > > >> -Original Message- > >> From: Suanming Mou > >> Sent: Wednesday, January 31, 202

RE: rte_atomic_*_explicit

2024-01-31 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Wednesday, 31 January 2024 16.53 > > On 2024-01-30 19:36, Tyler Retzlaff wrote: > > On Sat, Jan 27, 2024 at 09:34:24PM +0100, Mattias Rönnblom wrote: > >> On 2024-01-26 22:35, Tyler Retzlaff wrote: > >>> On Fri, Jan 26, 2024 at 11:52:

DTS WG Meeting Minutes - January 31, 2024

2024-01-31 Thread Patrick Robb
January 31, 2024 # Attendees * Patrick Robb * Juraj Linkeš * Paul Szczepanek * Jeremy Spewock * Luca Vizzarro * Thomas Monjalon # Agenda * Additions to the agend

Re: [PATCH v3 2/3] ethdev: add compare item

2024-01-31 Thread Ferruh Yigit
On 1/31/2024 3:56 PM, Ori Kam wrote: > Hi > >> -Original Message- >> From: Suanming Mou >> Sent: Wednesday, January 31, 2024 4:48 AM >> >> Hi, >> >>> -Original Message- >>> From: Ferruh Yigit >>> Sent: Wednesday, January 31, 2024 1:34 AM >>> To: Suanming Mou ; Ori Kam >> ; >>> Am

Re: [RFC v3] eal: add bitset type

2024-01-31 Thread Mattias Rönnblom
On 2024-01-31 17:02, Stephen Hemminger wrote: On Wed, 31 Jan 2024 14:13:01 +0100 Mattias Rönnblom wrote: Introduce a set of functions and macros that operate on sets of bits, kept in arrays of 64-bit elements. RTE bitset is designed for bitsets which are larger than what fits in a single mach

Re: [PATCH v2 07/11] eventdev: fix documentation for counting single-link ports

2024-01-31 Thread Bruce Richardson
On Tue, Jan 23, 2024 at 09:56:23AM +, Bruce Richardson wrote: > On Tue, Jan 23, 2024 at 10:48:47AM +0100, Mattias Rönnblom wrote: > > On 2024-01-19 18:43, Bruce Richardson wrote: > > > The documentation of how single-link port-queue pairs were counted in > > > the rte_event_dev_config structure

Re: [PATCH v2 06/11] eventdev: improve doxygen comments on configure struct

2024-01-31 Thread Bruce Richardson
On Tue, Jan 23, 2024 at 10:46:00AM +0100, Mattias Rönnblom wrote: > On 2024-01-19 18:43, Bruce Richardson wrote: > > General rewording and cleanup on the rte_event_dev_config structure. > > Improved the wording of some sentences and created linked > > cross-references out of the existing references

Re: [RFC v3] eal: add bitset type

2024-01-31 Thread Stephen Hemminger
On Wed, 31 Jan 2024 14:13:01 +0100 Mattias Rönnblom wrote: > +/** > + * @file > + * RTE Bitset > + * > + * This file provides functions and macros for querying and > + * manipulating sets of bits kept in arrays of @c uint64_t-sized > + * elements. > + * > + * The bits in a bitset are numbered fro

Re: [PATCH] RFC: use C11 alignas instead of GCC attribute aligned

2024-01-31 Thread Mattias Rönnblom
On 2024-01-30 18:39, Tyler Retzlaff wrote: On Tue, Jan 30, 2024 at 09:08:21AM +0100, Mattias Rönnblom wrote: On 2024-01-29 20:43, Tyler Retzlaff wrote: On Sun, Jan 28, 2024 at 11:00:31AM +0100, Mattias Rönnblom wrote: On 2024-01-28 09:57, Morten Brørup wrote: From: Mattias Rönnblom [mailto:ho

RE: [PATCH v3 2/3] ethdev: add compare item

2024-01-31 Thread Ori Kam
Hi > -Original Message- > From: Suanming Mou > Sent: Wednesday, January 31, 2024 4:48 AM > > Hi, > > > -Original Message- > > From: Ferruh Yigit > > Sent: Wednesday, January 31, 2024 1:34 AM > > To: Suanming Mou ; Ori Kam > ; > > Aman Singh ; Yuying Zhang > > ; NBU-Contact-Thom

Re: rte_atomic_*_explicit

2024-01-31 Thread Mattias Rönnblom
On 2024-01-30 19:36, Tyler Retzlaff wrote: On Sat, Jan 27, 2024 at 09:34:24PM +0100, Mattias Rönnblom wrote: On 2024-01-26 22:35, Tyler Retzlaff wrote: On Fri, Jan 26, 2024 at 11:52:11AM +0100, Morten Brørup wrote: From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] Sent: Friday, 26 January

Re:

2024-01-31 Thread Ferruh Yigit
On 1/26/2024 5:33 PM, Joshua Washington wrote: > Subject: [PATCH v4 0/7] net/gve: RSS Support for GVE Driver > > This patch series introduces RSS support for the GVE poll-mode driver. > This series includes implementations of the following eth_dev_ops: > > 1) rss_hash_update > 2) rss_hash_conf_ge

Re: [PATCH v4 6/7] net/gve: update gve.ini with RSS capabilities

2024-01-31 Thread Ferruh Yigit
On 1/31/2024 2:48 PM, Ferruh Yigit wrote: > On 1/26/2024 5:33 PM, Joshua Washington wrote: >> This patch updates the DPDK feature matrix to expose that the GVE driver >> supports RSS hash, RSS key update, and RSS reta update. >> >> Signed-off-by: Joshua Washington >> --- >> doc/guides/nics/featur

Re: [PATCH v4 7/7] net/gve: update GVE documentation with RSS support

2024-01-31 Thread Ferruh Yigit
On 1/26/2024 5:33 PM, Joshua Washington wrote: > This patch updates the GVE doc page to communicate that GVE now supports > RSS configuration and explains the limitations. > > Signed-off-by: Joshua Washington > --- > doc/guides/nics/gve.rst | 16 ++-- > 1 file changed, 10 insertions(

Re: [PATCH v4 6/7] net/gve: update gve.ini with RSS capabilities

2024-01-31 Thread Ferruh Yigit
On 1/26/2024 5:33 PM, Joshua Washington wrote: > This patch updates the DPDK feature matrix to expose that the GVE driver > supports RSS hash, RSS key update, and RSS reta update. > > Signed-off-by: Joshua Washington > --- > doc/guides/nics/features/gve.ini | 3 +++ > 1 file changed, 3 insertion

Re: [PATCH v2 04/11] eventdev: cleanup doxygen comments on info structure

2024-01-31 Thread Bruce Richardson
On Wed, Jan 24, 2024 at 12:51:03PM +0100, Mattias Rönnblom wrote: > On 2024-01-23 10:43, Bruce Richardson wrote: > > On Tue, Jan 23, 2024 at 10:35:02AM +0100, Mattias Rönnblom wrote: > > > On 2024-01-19 18:43, Bruce Richardson wrote: > > > > Some small rewording changes to the doxygen comments on s

Re: [PATCH v2 03/11] eventdev: update documentation on device capability flags

2024-01-31 Thread Bruce Richardson
On Tue, Jan 23, 2024 at 10:18:53AM +0100, Mattias Rönnblom wrote: > On 2024-01-19 18:43, Bruce Richardson wrote: > > Update the device capability docs, to: > > > > * include more cross-references > > * split longer text into paragraphs, in most cases with each flag having > >a single-line summ

Re: [PATCH] mbuf: replace GCC marker extension with C11 anonymous unions

2024-01-31 Thread Bruce Richardson
On Tue, Jan 30, 2024 at 03:26:13PM -0800, Tyler Retzlaff wrote: > Replace the use of RTE_MARKER with C11 anonymous unions to improve > code portability between toolchains. > > Update use of rte_mbuf rearm_data field in net/ionic, net/sfc and > net/virtio which were accessing field as a zero-length

Re: [PATCH v2 01/11] eventdev: improve doxygen introduction text

2024-01-31 Thread Bruce Richardson
On Tue, Jan 23, 2024 at 09:57:58AM +0100, Mattias Rönnblom wrote: > On 2024-01-19 18:43, Bruce Richardson wrote: > > Make some textual improvements to the introduction to eventdev and event > > devices in the eventdev header file. This text appears in the doxygen > > output for the header file, and

Re: [PATCH 1/2] vhost: fix memory leak in Virtio Tx split path

2024-01-31 Thread Maxime Coquelin
Hi David, On 1/31/24 14:19, David Marchand wrote: On Wed, Jan 31, 2024 at 10:31 AM Maxime Coquelin wrote: When vIOMMU is enabled and Virtio device is bound to kernel driver in guest, rte_vhost_dequeue_burst() will often return early because of IOTLB misses. This patch fixes a mbuf leak occur

[RFC v3] eal: add bitset type

2024-01-31 Thread Mattias Rönnblom
Introduce a set of functions and macros that operate on sets of bits, kept in arrays of 64-bit elements. RTE bitset is designed for bitsets which are larger than what fits in a single machine word (i.e., 64 bits). For very large bitsets, the API may be a more appropriate choice. RFC v3: * Split

RE: [PATCH v2] ethdev: fast path async flow API

2024-01-31 Thread Ori Kam
Hi Draiusz, > -Original Message- > From: Dariusz Sosnowski > Sent: Wednesday, January 31, 2024 11:35 AM > > This patch reworks the async flow API functions called in data path, > to reduce the overhead during flow operations at the library level. > Main source of the overhead was indirec

Re: [PATCH 1/2] vhost: fix memory leak in Virtio Tx split path

2024-01-31 Thread David Marchand
On Wed, Jan 31, 2024 at 10:31 AM Maxime Coquelin wrote: > > When vIOMMU is enabled and Virtio device is bound to kernel > driver in guest, rte_vhost_dequeue_burst() will often return > early because of IOTLB misses. > > This patch fixes a mbuf leak occurring in this case. > > Fixes: 242695f6122a (

[PATCH v2] ethdev: add template table resize API

2024-01-31 Thread Gregory Etelson
Template table creation API sets table flows capacity. If application needs more flows then the table was designed for, the following procedures must be completed: 1. Create a new template table with larger flows capacity. 2. Re-create existing flows in the new table and delete flows from the or

[PATCH] maintainers: update for fm10k/ifc drivers

2024-01-31 Thread Xiao Wang
Remove my name from maintainers. Signed-off-by: Xiao Wang --- MAINTAINERS | 2 -- 1 file changed, 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 5fb3a73f84..b9d258e627 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -759,7 +759,6 @@ F: doc/guides/nics/intel_vf.rst F: doc/guides/nics

Re: [PATCH] kernel/freebsd: fix module build on FreeBSD 14

2024-01-31 Thread Thomas Monjalon
> > When building nic_uio module on FreeBSD 14, a build error is given in the > > DRIVER_MODULE macro: > > > > .../nic_uio.c:84:81: error: too many arguments provided to function-like > > macro invocation DRIVER_MODULE(nic_uio, pci, nic_uio_driver, > > nic_uio_devclass, nic_uio_modevent, 0); > >

[PATCH v2 2/2] app/testpmd: add support for NAT64 in the command line

2024-01-31 Thread Bing Zhao
The type of NAT64 action will be parsed. Usage example with template API: ... flow actions_template 0 create ingress actions_template_id 1 \ template count / nat64 / jump / end mask count / nat64 / \ jump / end flow template_table 0 create group 1 priority 0 ingress table_id \ 0x

[PATCH v2 1/2] ethdev: introduce NAT64 action

2024-01-31 Thread Bing Zhao
In order to support the communication between IPv4 and IPv6 nodes in the network, different technologies are used, like dual-stacks, tunneling and NAT64. In some IPv4-only clients, it is hard to deploy new software and(or) hardware to support IPv6 protocol. NAT64 is a choice and it will also reduc

[PATCH v2 0/2] support NAT64 action

2024-01-31 Thread Bing Zhao
This patchset introduce the NAT64 action support for rte_flow. --- v2: split the common part and PMD part. --- Bing Zhao (2): ethdev: introduce NAT64 action app/testpmd: add support for NAT64 in the command line app/test-pmd/cmdline_flow.c | 23 ++ doc/guides

[PATCH v2] ethdev: fast path async flow API

2024-01-31 Thread Dariusz Sosnowski
This patch reworks the async flow API functions called in data path, to reduce the overhead during flow operations at the library level. Main source of the overhead was indirection and checks done while ethdev library was fetching rte_flow_ops from a given driver. This patch introduces rte_flow_fp

[PATCH 2/2] vhost: add new mbuf allocation failure statistic

2024-01-31 Thread Maxime Coquelin
This patch introduces a new, per virtqueue, mbuf allocation failure statistic. It can be useful to troubleshoot packets drops due to insufficient mempool size or memory leaks. Signed-off-by: Maxime Coquelin --- lib/vhost/vhost.c | 1 + lib/vhost/vhost.h | 1 + lib/vhost/virtio_net.c

[PATCH 1/2] vhost: fix memory leak in Virtio Tx split path

2024-01-31 Thread Maxime Coquelin
When vIOMMU is enabled and Virtio device is bound to kernel driver in guest, rte_vhost_dequeue_burst() will often return early because of IOTLB misses. This patch fixes a mbuf leak occurring in this case. Fixes: 242695f6122a ("vhost: allocate and free packets in bulk in Tx split") Cc: sta...@dpdk

RE: [PATCH] mbuf: replace GCC marker extension with C11 anonymous unions

2024-01-31 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 31 January 2024 00.26 > > Replace the use of RTE_MARKER with C11 anonymous unions to improve > code portability between toolchains. > > Update use of rte_mbuf rearm_data field in net/ionic, net/sfc and > net/virtio wh

Re: [EXT] Re: [PATCH 1/2] config/arm: avoid mcpu and march conflicts

2024-01-31 Thread Juraj Linkeš
On Tue, Jan 30, 2024 at 5:16 PM Pavan Nikhilesh Bhagavatula wrote: > > > > > -Original Message- > > From: Juraj Linkeš > > Sent: Monday, January 29, 2024 2:15 PM > > To: Pavan Nikhilesh Bhagavatula > > Cc: Jerin Jacob ; ruifeng.w...@arm.com; > > n...@arm.com; Bruce Richardson ; > > dev@d