release candidate 24.03-rc1

2024-02-21 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v24.03-rc1 There are 521 new patches in this snapshot. Release notes: https://doc.dpdk.org/guides/rel_notes/release_24_03.html Highlights of 24.03-rc1: - argument parsing library

Re: [PATCH v2 2/4] config/arm: add generic V2 SoC

2024-02-21 Thread Thomas Monjalon
20/02/2024 02:45, Honnappa Nagarahalli: > Add generic V2 CPU SoC. This will allow for compiling a binary > that will run on any SoC that uses V2 CPU. [...] > +soc_v2 = { > +'description': 'Arm Neoverse V2', > +'implementer': '0x41', > +'part_number': '0xd4f', > +'numa': true > +} [.

RE: [EXT] [PATCH v2] cryptodev: speed up ops pool create

2024-02-21 Thread Akhil Goyal
> Use rte_mempool_virt2iova(), which uses arithmetic based on the mempool > state, rather than rte_mem_virt2iova(), which uses syscalls to look at > the proc filesystem. This speeds up pool create by more than 90%. > > Signed-off-by: Andrew Boyer > --- Acked-by: Akhil Goyal Applied to dpdk-next

Re: [PATCH] dispatcher: add cache guard to per-lcore struct

2024-02-21 Thread Thomas Monjalon
20/02/2024 09:46, Morten Brørup: > > From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > > Sent: Tuesday, 20 February 2024 09.35 > > > > Add cache guard to per-lcore data structures to prevent false sharing > > in scenarios where a next-N-lines (or similar) hardware prefetcher is > > u

Re: rss calculation as the nic

2024-02-21 Thread Pavel Vazharov
On Wed, Feb 21, 2024 at 9:40 PM Yaron Illouz wrote: > Hi Ori > > Thank you for your answer it helped me > > But I can see the load balancing is not done to the same instance for > both directions > I would like to have ip + port pairs arrive to same instance > > Now ip1+port1 -> ip2+port2 arrive

Re: [PATCH v4 01/39] eal: use C11 alignas

2024-02-21 Thread Thomas Monjalon
14/02/2024 17:35, Tyler Retzlaff: > * Expand __rte_aligned(a) to __declspec(align(a)) when building > with MSVC. > > * Move __rte_aligned from the end of {struct,union} definitions to > be between {struct,union} and tag. > > The placement between {struct,union} and the tag allows the desire

[24.11 PATCH v2 4/5] node: add error stats for ip4 lookup node

2024-02-21 Thread pbhagavatula
From: Pavan Nikhilesh Add error counters for ip4 LPM lookup failures in ip4_lookup node. Signed-off-by: Pavan Nikhilesh --- lib/node/ip4_lookup.c | 9 + lib/node/ip4_lookup_neon.h | 5 + lib/node/ip4_lookup_sse.h | 6 ++ lib/node/node_private.h| 8 4 files ch

[24.11 PATCH v2 5/5] node: add error stats for ip4 reassembly node

2024-02-21 Thread pbhagavatula
From: Pavan Nikhilesh Add reassembly failure error counter for ip4 reassembly node. Signed-off-by: Pavan Nikhilesh --- lib/node/ip4_reassembly.c | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/node/ip4_reassembly.c b/lib/node/ip4_reassembly.c index 04823cc596..ab71ef1331 10064

[24.11 PATCH v2 3/5] graph: add stats for node specific errors

2024-02-21 Thread pbhagavatula
From: Pavan Nikhilesh Add support for retrieving/printing stats for node specific errors using rte_graph_cluster_stats_get(). Signed-off-by: Pavan Nikhilesh --- lib/graph/graph_stats.c | 81 - lib/graph/rte_graph.h | 4 ++ 2 files changed, 84 insertio

[24.11 PATCH v2 2/5] graph: add node fastpath error counters

2024-02-21 Thread pbhagavatula
From: Pavan Nikhilesh Add node fastpath error counters advertised during node registration. Signed-off-by: Pavan Nikhilesh --- lib/graph/graph_populate.c | 22 +++--- lib/graph/graph_private.h | 2 ++ lib/graph/rte_graph_worker_common.h | 1 + 3 files chang

Re: [PATCH 0/7] bnxt bug fixes

2024-02-21 Thread Ajit Khaparde
On Wed, Feb 21, 2024 at 6:50 PM Patrick Robb wrote: > > https://patchwork.dpdk.org/project/dpdk/patch/20240208171330.31139-8-ajit.khapa...@broadcom.com/ > > Hi Ajit, > > So you know, this series did fail in CI testing, and now that it is merged to > main, all patchseries are failing DTS at EAL. P

[PATCH] net/af_xdp: fix resources leak when xsk configure fails

2024-02-21 Thread Yunjian Wang
In xdp_umem_configure() allocated some resources for the xsk umem, we should delete them when xsk configure fails, otherwise it will lead to resources leak. Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/af_xdp/rte_eth_af

Re: [PATCH v1 1/2] app/testpmd: fix modify tag typo

2024-02-21 Thread rongwei liu
I am using the master-net-mlx branch as base to verify. And cross-checked the main and master-net-mlx branch diverage now. Patch 1 was good and patch 2 failed to apply on the main branch. [rongweil@gen-l-vrt-290 mlnx_dpdk]$ patch -d ./ -p 1 < 1.patch patching file app/test-pmd/cmdline_flow.c Hunk

Re: [PATCH 0/7] bnxt bug fixes

2024-02-21 Thread Patrick Robb
https://patchwork.dpdk.org/project/dpdk/patch/20240208171330.31139-8-ajit.khapa...@broadcom.com/ Hi Ajit, So you know, this series did fail in CI testing, and now that it is merged to main, all patchseries are failing DTS at EAL. Performance testing is also offline for the same reason. I will ru

Re: [PATCH] lib/hash,lib/rcu: feature hidden key count in hash

2024-02-21 Thread Honnappa Nagarahalli
> On Feb 21, 2024, at 3:51 PM, Abdullah Ömer Yamaç wrote: > > > > On Wed, Feb 21, 2024 at 6:24 AM Honnappa Nagarahalli > wrote: > > > > On Feb 20, 2024, at 12:58 PM, Abdullah Ömer Yamaç > > wrote: > > > > I appreciate that you gave me suggestions and comments. I will make changes > >

RE: [EXT] Re: [PATCH v2 8/8] crypto/ipsec_mb: set and use session ID

2024-02-21 Thread Wathsala Wathawana Vithanage
I tried mainline earlier today it compiles and links fine. However, build failed on v1.4. We are working on tagging the mainline, until then please continue working on mainline. > -Original Message- > From: Patrick Robb > Sent: Tuesday, February 20, 2024 11:01 PM > To: Fangming Fang > C

Re: [PATCH] lib/hash,lib/rcu: feature hidden key count in hash

2024-02-21 Thread Abdullah Ömer Yamaç
On Wed, Feb 21, 2024 at 6:24 AM Honnappa Nagarahalli < honnappa.nagaraha...@arm.com> wrote: > > > > On Feb 20, 2024, at 12:58 PM, Abdullah Ömer Yamaç > wrote: > > > > I appreciate that you gave me suggestions and comments. I will make > changes according to all your recommendations, but before th

[PATCH 10/10] doc: update release notes for bnxt

2024-02-21 Thread Ajit Khaparde
Update release notes indicating support in bnxt PMD for 5760X device family. Signed-off-by: Ajit Khaparde --- doc/guides/rel_notes/release_24_03.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_24_03.rst b/doc/guides/rel_notes/release_24_03.rst index 32d0

[PATCH 09/10] net/bnxt: fix compressed Rx CQE handling

2024-02-21 Thread Ajit Khaparde
We were trying to reuse 32-byte CQE macros for compressed CQE handling. And that was causing the packet error bits to be misinterpreted. Fix it by using appropriate macros. Fixes: d58c6c077cc2 ("net/bnxt: add AVX2 Rx for compressed CQE") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_r

[PATCH 08/10] net/bnxt: fix compressed CQE handling

2024-02-21 Thread Ajit Khaparde
We were trying to reuse parts of 32-byte CQE handling for compressed CQE handling. And that was causing the packet errors to be misinterpreted. Fix it by using separate code for the compressed CQE handling. Fixes: 812fd99f8c4e ("net/bnxt: add SSE Rx for compressed CQE") Signed-off-by: Ajit Khapa

[PATCH 07/10] net/bnxt: add IPv6 flow label based RSS support

2024-02-21 Thread Ajit Khaparde
P7 hardware family can support IPv6 flow label based RSS. Check if the firmware indicates capability bit to support IPv6 flow label based RSS and parse the RSS hash types appropriately. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 1 + drivers/net/bnxt/bnxt_ethdev.c | 2 ++

[PATCH 06/10] net/bnxt: handle UDP GSO Tx

2024-02-21 Thread Ajit Khaparde
The UDP GSO capability is not being detected and reported correctly. This is causing UDP GSO to not happen in some cases. This patch fixes the issue. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 3 ++- drivers/net/bnxt/bnxt_txr.c | 3 ++- 2 files changed, 4 insertions(+), 2 d

[PATCH 05/10] net/bnxt: fix a null pointer dereference

2024-02-21 Thread Ajit Khaparde
From: Kalesh AP In the recent changes to rte_eth_dev_release_port() the library sets eth_dev->data to NULL at the end of the routine. This causes a NULL pointer dereference in the bnxt_rep_dev_info_get_op() and bnxt_representor_uninit() routines when it tries to validate parent dev. Add code to

[PATCH 04/10] net/bnxt: fix AGG ID computation

2024-02-21 Thread Ajit Khaparde
Fix the computation of AGG ID for P5 and P7 device families. The AGG ID for TPA completions for P7 device family is being incorrectly obtained. Fix the code to handle it. Fixes: 3b56c3ffc182 ("net/bnxt: refactor code to support P7 devices") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt

[PATCH 03/10] net/bnxt: increase queue size for async handling

2024-02-21 Thread Ajit Khaparde
Increase the default NQ/CQ depth for async handling. In some cases the hardware can generate a high number of async notifications. Increase the notification/completion queue size to accommodate them. Signed-off-by: Ajit Khaparde Reviewed-by: Damodharam Ammepalli --- drivers/net/bnxt/bnxt_ring.h

[PATCH 02/10] net/bnxt: add dual rate module detection log

2024-02-21 Thread Ajit Khaparde
From: Kalesh AP Firmware sends an async notification to the driver when it detects a Dual rate module. Display below warning message: "Speed change not supported with dual rate transceivers on this board" Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_cpr.c

[PATCH 01/10] net/bnxt: extend long bd check for VXLAN GPE

2024-02-21 Thread Ajit Khaparde
Extend long Tx BD check for VXLAN GPE packets. This will allow the long BD to be selected for Tx with VXLAN GPE frames. Signed-off-by: Ajit Khaparde Reviewed-by: Kalesh AP --- drivers/net/bnxt/bnxt_txr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_t

[PATCH 00/10] patchset for bnxt

2024-02-21 Thread Ajit Khaparde
Apart from some fixes, this patchset adds support for RSS based on IPV6 flow label. This set also updates the 24.03 release notes. Ajit Khaparde (8): net/bnxt: extend long bd check for VXLAN GPE net/bnxt: increase queue size for async handling net/bnxt: fix AGG ID computation net/bnxt: han

[PATCH v4 3/3] config/arm: allow WFE to be enabled config time

2024-02-21 Thread pbhagavatula
From: Pavan Nikhilesh Allow RTE_ARM_USE_WFE to be enabled at meson configuration time by passing it via c_args instead of modifying `config/arm/meson.build`. Example usage: meson build -Dc_args='-DRTE_ARM_USE_WFE' \ --cross-file config/arm/arm64_cn10k_linux_gcc Signed-off-by: Pavan Nik

[PATCH v4 2/3] config/arm: add support for fallback march

2024-02-21 Thread pbhagavatula
From: Pavan Nikhilesh Some ARM CPUs have specific march requirements and are not compatible with the supported march list. Add fallback march in case the mcpu and the march advertised in the part_number_config are not supported by the compiler. Example mcpu = neoverse-n2 march =

[PATCH v4 1/3] config/arm: avoid mcpu and march conflicts

2024-02-21 Thread pbhagavatula
From: Pavan Nikhilesh The compiler options march and mtune are a subset of mcpu and will lead to conflicts if improper march is chosen for a given mcpu. To avoid conflicts, discard part number march when mcpu is available and is supported by the compiler. Example: march = armv9-a

Re: [EXT] [PATCH v2 8/8] crypto/ipsec_mb: set and use session ID

2024-02-21 Thread Patrick Robb
On Wed, Feb 21, 2024 at 4:50 AM Power, Ciara wrote: > > Hi folks, > > We had based the ipsec-mb version bump to 1.4 on both intel ipsec-mb and > arm ipsec-mb supporting that version, so both could still use the Ipsec-mb > SW PMDs. > I based the arm support from the repo main branch ( > https://gi

Re: [PATCH v8] app/testpmd : fix packets not getting flushed in heavy-weight mode API

2024-02-21 Thread Ferruh Yigit
On 2/16/2024 1:56 PM, Ferruh Yigit wrote: > On 2/16/2024 3:47 AM, Kumara Parameshwaran wrote: >> In heavy-weight mode GRO which is based on timer, the GRO packets >> will not be flushed in spite of timer expiry if there is no packet >> in the current poll. If timer mode GRO is enabled the >> rte_gr

RE: rss calculation as the nic

2024-02-21 Thread Yaron Illouz
Hi Ori Thank you for your answer it helped me But I can see the load balancing is not done to the same instance for both directions I would like to have ip + port pairs arrive to same instance Now ip1+port1 -> ip2+port2 arrive to instance x and ip2+port2 -> ip1+port1 arrive to another instance

Re: [PATCH 0/2] fix meta data process problem

2024-02-21 Thread Ferruh Yigit
On 2/20/2024 8:14 AM, Chaoyong He wrote: > The Tx function can not check if the meta data process success for > the process function with void return type. This problem exist for > both NFD3 and NFDk logic. > > Chaoyong He (2): > net/nfp: fix meta data process problem of NFD3 > net/nfp: fix me

Re: [PATCH v1 1/2] app/testpmd: fix modify tag typo

2024-02-21 Thread Ferruh Yigit
On 2/21/2024 4:33 PM, Ferruh Yigit wrote: > On 2/21/2024 7:10 AM, Rongwei Liu wrote: >> Update the name to the right one: "src_tag_index" >> >> Fixes: 7ea38955b ("ethdev: update MPLS header modification API") >> Cc: sta...@dpdk.org >> >> Signed-off-by: Rongwei Liu >> Acked-by: Dariusz Sosnowski >

Re: [PATCH v2 0/3] net/ionic, common/ionic: add vdev support

2024-02-21 Thread Ferruh Yigit
On 2/20/2024 8:42 PM, Andrew Boyer wrote: > This patch series adds support to net/ionic for using UIO platform devices > as DPDK vdevs. This is used by client applications which run directly on > the AMD Pensando family of devices. > > The UIO code is implemented in a new common code library so th

Re: [PATCH v1 2/2] net/mlx5: fix modify flex item error

2024-02-21 Thread Ferruh Yigit
On 2/21/2024 7:10 AM, Rongwei Liu wrote: > In the rte_flow_field_data structure, the flex item handle is part > of union with other members like level/tag_index. > > If the user wants to modify the flex item as source or destination, > there should not be any checking against zero. > > Signed-off

Re: [PATCH v1 1/2] app/testpmd: fix modify tag typo

2024-02-21 Thread Ferruh Yigit
On 2/21/2024 7:10 AM, Rongwei Liu wrote: > Update the name to the right one: "src_tag_index" > > Fixes: 7ea38955b ("ethdev: update MPLS header modification API") > Cc: sta...@dpdk.org > > Signed-off-by: Rongwei Liu > Acked-by: Dariusz Sosnowski > Acked-by: Ferruh Yigit

[PATCH 5/5] node: add error stats for ip4 reassembly node

2024-02-21 Thread pbhagavatula
From: Pavan Nikhilesh Add reassembly failure error counter for ip4 reassembly node. Signed-off-by: Pavan Nikhilesh --- lib/node/ip4_reassembly.c | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/node/ip4_reassembly.c b/lib/node/ip4_reassembly.c index 04823cc596..ab71ef1331 10064

[PATCH 4/5] node: add error stats for ip4 lookup node

2024-02-21 Thread pbhagavatula
From: Pavan Nikhilesh Add error counters for ip4 LPM lookup failures in ip4_lookup node. Signed-off-by: Pavan Nikhilesh --- lib/node/ip4_lookup.c | 9 + lib/node/ip4_lookup_neon.h | 5 + lib/node/ip4_lookup_sse.h | 6 ++ lib/node/node_private.h| 8 4 files ch

[PATCH 3/5] graph: add stats for node specific errors

2024-02-21 Thread pbhagavatula
From: Pavan Nikhilesh Add support for retrieving/printing stats for node specific errors using rte_graph_cluster_stats_get(). Signed-off-by: Pavan Nikhilesh --- lib/graph/graph_stats.c | 81 - lib/graph/rte_graph.h | 4 ++ 2 files changed, 84 insertio

[PATCH 2/5] graph: add node fastpath error counters

2024-02-21 Thread pbhagavatula
From: Pavan Nikhilesh Add node fastpath error counters advertised during node registration. Signed-off-by: Pavan Nikhilesh --- lib/graph/graph_populate.c | 22 +++--- lib/graph/graph_private.h | 2 ++ lib/graph/rte_graph_worker_common.h | 1 + 3 files chang

[PATCH] doc: deprecate graph data structures

2024-02-21 Thread pbhagavatula
From: Pavan Nikhilesh Deprecate rte_node, rte_node_register and rte_graph_cluster_node_stats structures as will be extended to include node specific error counters and error description. Signed-off-by: Pavan Nikhilesh --- doc/guides/rel_notes/deprecation.rst | 5 + 1 file changed, 5 insert

[DPDK/DTS Bug 1383] DTS: clean up old tarball before copying a new one over

2024-02-21 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1383 Bug ID: 1383 Summary: DTS: clean up old tarball before copying a new one over Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRM

RE: [v9 1/3] docs: AF_XDP Device Plugin

2024-02-21 Thread Koikkara Reeny, Shibin
Hi Maryam, I have added a small nitpick. Regards, Shibin > -Original Message- > From: Maryam Tahhan > Sent: Wednesday, February 14, 2024 5:04 PM > To: ferruh.yi...@amd.com; step...@networkplumber.org; > lihuis...@huawei.com; fengcheng...@huawei.com; > liuyongl...@huawei.com; Marchand, D

Re: [RFC v3 1/6] eal: add static per-lcore memory allocation facility

2024-02-21 Thread Mattias Rönnblom
On 2024-02-21 10:43, Jerin Jacob wrote: On Tue, Feb 20, 2024 at 2:35 PM Mattias Rönnblom wrote: Introduce DPDK per-lcore id variables, or lcore variables for short. An lcore variable has one value for every current and future lcore id-equipped thread. The primary use case is for statically

RE: [PATCH v3 0/5] NAT64 support in mlx5 PMD

2024-02-21 Thread Ori Kam
> -Original Message- > From: Bing Zhao > Sent: Tuesday, February 20, 2024 4:37 PM > > This patch set contains the mlx5 PMD implementation for NAT64. > > Update in v3: > 1. code style and typo. > > Update in v2: > 1. separate from the RTE and testpmd common part. > 2. reorder the

RE: [RFC PATCH] app/test: allow passing a parameter string to autotests

2024-02-21 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Friday, 15 December 2023 14.07 > > Sometimes it can be nice to have autotests which can take a parameter, > or can be tweaked in some ways, e.g. adjust the number of iterations, > or > the burst size used in the test. Currently t

Re: [PATCH v5] mempool: test performance with larger bursts

2024-02-21 Thread Bruce Richardson
On Wed, Feb 21, 2024 at 11:38:34AM +0100, Morten Brørup wrote: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Wednesday, 21 February 2024 11.23 > > > > 20/02/2024 14:49, Morten Brørup: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > > > > > How the test duration

RE: [PATCH v5] mempool: test performance with larger bursts

2024-02-21 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, 21 February 2024 11.23 > > 20/02/2024 14:49, Morten Brørup: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > > > How the test duration is changed after this patch? > > > > On my test machine, the expanded test pa

[PATCH v4 12/12] eventdev: fix doxygen processing of event vector struct

2024-02-21 Thread Bruce Richardson
The event vector struct was missing comments on two members, and also was inadvertently creating a local variable called "__rte_aligned" in the doxygen output. Correct the comment markers to fix the former issue, and fix the latter by putting "#ifdef __DOXYGEN" around the alignment constraint. Fi

[PATCH v4 11/12] eventdev: drop comment for anon union from doxygen

2024-02-21 Thread Bruce Richardson
Make the comments on the unnamed unions in the rte_event structure regular comments rather than doxygen ones. The comments do not add anything meaningful to the doxygen output. Signed-off-by: Bruce Richardson --- lib/eventdev/rte_eventdev.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

[PATCH v4 10/12] eventdev: clarify docs on event object fields and op types

2024-02-21 Thread Bruce Richardson
Clarify the meaning of the NEW, FORWARD and RELEASE event types. For the fields in "rte_event" struct, enhance the comments on each to clarify the field's use, and whether it is preserved between enqueue and dequeue, and it's role, if any, in scheduling. Signed-off-by: Bruce Richardson --- V4: re

[PATCH v4 09/12] eventdev: improve comments on scheduling types

2024-02-21 Thread Bruce Richardson
The description of ordered and atomic scheduling given in the eventdev doxygen documentation was not always clear. Try and simplify this so that it is clearer for the end-user of the application Signed-off-by: Bruce Richardson --- V4: reworked following review by Jerin V3: extensive rework follo

[PATCH v4 08/12] eventdev: improve doxygen comments for control APIs

2024-02-21 Thread Bruce Richardson
The doxygen comments for the port attributes, start and stop (and related functions) are improved. Signed-off-by: Bruce Richardson --- V3: add missing "." on end of sentences/lines. --- lib/eventdev/rte_eventdev.h | 47 +++-- 1 file changed, 29 insertions(+), 18

[PATCH v4 07/12] eventdev: improve doxygen comments on config fns

2024-02-21 Thread Bruce Richardson
Improve the documentation text for the configuration functions and structures for configuring an eventdev, as well as ports and queues. Clarify text where possible, and ensure references come through as links in the html output. Signed-off-by: Bruce Richardson --- V3: Update following review, ma

[PATCH v4 06/12] eventdev: improve doxygen comments on configure struct

2024-02-21 Thread Bruce Richardson
General rewording and cleanup on the rte_event_dev_config structure. Improved the wording of some sentences and created linked cross-references out of the existing references to the dev_info structure. As part of the rework, fix issue with how single-link port-queue pairs were counted in the rte_e

[PATCH v4 05/12] eventdev: improve function documentation for query fns

2024-02-21 Thread Bruce Richardson
General improvements to the doxygen docs for eventdev functions for querying basic information: * number of devices * id for a particular device * socket id of device * capability information for a device Signed-off-by: Bruce Richardson --- V3: minor changes following review --- lib/eventdev/rt

[PATCH v4 04/12] eventdev: cleanup doxygen comments on info structure

2024-02-21 Thread Bruce Richardson
Some small rewording changes to the doxygen comments on struct rte_event_dev_info. Signed-off-by: Bruce Richardson --- V3: reworked following feedback - added closing "." on comments - added more cross-reference links - reworded priority level comments --- lib/eventdev/rte_eventdev.h | 85 +

[PATCH v4 03/12] eventdev: update documentation on device capability flags

2024-02-21 Thread Bruce Richardson
Update the device capability docs, to: * include more cross-references * split longer text into paragraphs, in most cases with each flag having a single-line summary at the start of the doc block * general comment rewording and clarification as appropriate Signed-off-by: Bruce Richardson --- V

[PATCH v4 02/12] eventdev: move text on driver internals to proper section

2024-02-21 Thread Bruce Richardson
Inside the doxygen introduction text, some internal details of how eventdev works was mixed in with application-relevant details. Move these details on probing etc. to the driver-relevant section. Signed-off-by: Bruce Richardson --- lib/eventdev/rte_eventdev.h | 32 --

[PATCH v4 01/12] eventdev: improve doxygen introduction text

2024-02-21 Thread Bruce Richardson
Make some textual improvements to the introduction to eventdev and event devices in the eventdev header file. This text appears in the doxygen output for the header file, and introduces the key concepts, for example: events, event devices, queues, ports and scheduling. This patch makes the followi

[PATCH v4 00/12] improve eventdev API specification/documentation

2024-02-21 Thread Bruce Richardson
This patchset makes rewording improvements to the eventdev doxygen documentation to try and ensure that it is as clear as possible, describes the implementation as accurately as possible, and is consistent within itself. Most changes are just minor rewordings, along with plenty of changes to chang

Re: [PATCH v2] app/testpmd: support updating flow rule actions

2024-02-21 Thread Thomas Monjalon
12/02/2024 09:37, Oleksandr Kolomeiets: > From: Dariusz Sosnowski > > From: Thomas Monjalon > > > 01/02/2024 10:59, Oleksandr Kolomeiets: > > > > "flow actions_update" updates a flow rule specified by a rule ID with > > > > > > > > a new action list by making a call to "rte_flow_actions_update()

RE: [RFC v3 1/6] eal: add static per-lcore memory allocation facility

2024-02-21 Thread Morten Brørup
> From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Wednesday, 21 February 2024 10.44 > > On Tue, Feb 20, 2024 at 2:35 PM Mattias Rönnblom > wrote: > > > > Introduce DPDK per-lcore id variables, or lcore variables for short. > > > > An lcore variable has one value for every current and fut

Re: [PATCH v3 10/11] eventdev: clarify docs on event object fields and op types

2024-02-21 Thread Bruce Richardson
On Wed, Feb 21, 2024 at 03:01:06PM +0530, Jerin Jacob wrote: > On Tue, Feb 20, 2024 at 11:09 PM Bruce Richardson > wrote: > > > > On Fri, Feb 09, 2024 at 02:44:04PM +0530, Jerin Jacob wrote: > > > On Fri, Feb 2, 2024 at 6:11 PM Bruce Richardson > > > wrote: > > > > > > > > Clarify the meaning of

Re: [PATCH] net/mlx5: fix use after free when releasing tx queues

2024-02-21 Thread Thomas Monjalon
20/02/2024 14:55, Dariusz Sosnowski: > Hi, > > > -Original Message- > > From: Yunjian Wang > > Sent: Tuesday, February 20, 2024 10:32 > > To: dev@dpdk.org > > Cc: Dariusz Sosnowski ; Ori Kam > > ; Matan Azrad ; Slava Ovsiienko > > ; Suanming Mou ; > > luyi...@huawei.com; Pengfei Sun ; > >

Re: [PATCH v5] mempool: test performance with larger bursts

2024-02-21 Thread Thomas Monjalon
20/02/2024 14:49, Morten Brørup: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 24/01/2024 12:21, Morten Brørup: > > > REGISTER_PERF_TEST(mempool_perf_autotest, test_mempool_perf); > > > +REGISTER_PERF_TEST(mempool_perf_autotest_1core, > > test_mempool_perf_1core); > > > +REGISTER_PERF_T

[PATCH v2 2/2] net/mlx5: add cross port meter mark action sharing

2024-02-21 Thread Dariusz Sosnowski
This patch adds support for sharing meter mark actions between multiple ports of the same physical NIC. Meter objects pool, meter mark actions and meter profiles can be created only on the host port. Guest ports are allowed to use meter objects created on the host port through indirect actions. Di

[PATCH v2 1/2] net/mlx5: move meter init functions

2024-02-21 Thread Dariusz Sosnowski
Move mlx5_flow_meter_init() and mlx5_flow_meter_uinit() to module for meter operations. Signed-off-by: Dariusz Sosnowski Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_hw.c| 203 drivers/net/mlx5/mlx5_flow_meter.c | 207 + 2 files c

[PATCH v2 0/2] net/mlx5: add cross port meter mark action sharing

2024-02-21 Thread Dariusz Sosnowski
This patchset adds support for sharing indirect METER_MARK flow actions between ports, when flow engine is configured with RTE_FLOW_PORT_FLAG_SHARE_INDIRECT. v2: - Updated release notes. Dariusz Sosnowski (2): net/mlx5: move meter init functions net/mlx5: add cross port meter mark action shar

[PATCH 2/2] net/mlx5: add cross port meter mark action sharing

2024-02-21 Thread Dariusz Sosnowski
This patch adds support for sharing meter mark actions between multiple ports of the same physical NIC. Meter objects pool, meter mark actions and meter profiles can be created only on the host port. Guest ports are allowed to use meter objects created on the host port through indirect actions. Di

[PATCH 1/2] net/mlx5: move meter init functions

2024-02-21 Thread Dariusz Sosnowski
Move mlx5_flow_meter_init() and mlx5_flow_meter_uinit() to module for meter operations. Signed-off-by: Dariusz Sosnowski Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_hw.c| 203 drivers/net/mlx5/mlx5_flow_meter.c | 207 + 2 files c

[PATCH 0/2] net/mlx5: add cross port meter mark action sharing

2024-02-21 Thread Dariusz Sosnowski
This patchset adds support for sharing indirect METER_MARK flow actions between ports, when flow engine is configured with RTE_FLOW_PORT_FLAG_SHARE_INDIRECT. Dariusz Sosnowski (2): net/mlx5: move meter init functions net/mlx5: add cross port meter mark action sharing drivers/net/mlx5/mlx5_fl

[PATCH 4/4] net/mlx5: remove port from conntrack handle representation

2024-02-21 Thread Dariusz Sosnowski
This patch removes the owner port index from integer representation of indirect action handle in mlx5 PMD for conntrack flow actions. This index is not needed when HW Steering flow engine is enabled, because either: - port references its own indirect actions or, - port references indirect actions

[PATCH 3/4] net/mlx5: add cross port CT object sharing

2024-02-21 Thread Dariusz Sosnowski
From: Suanming Mou This commit adds cross port CT object sharing. Shared CT object shares the same DevX objects, but allocate port's own action locally. Once the CT object is shared between two flows in different ports, the two flows use their own local action with the same offset index. The sh

[PATCH 2/4] net/mlx5: fix connection tracking action validation

2024-02-21 Thread Dariusz Sosnowski
In mlx5 PMD, handles to indirect connection tracking flow actions are encoded as 32-bit unsigned integers, where port ID is stored in bits 28-25. Because of this, connection tracking flow actions cannot be created on ports with IDs higher than 15. This patch adds missing validation. Fixes: 463170a

[PATCH 1/4] net/mlx5: fix conntrack action handle representation

2024-02-21 Thread Dariusz Sosnowski
In mlx5 PMD, handles to indirect connection tracking flow actions are encoded in 32-bit unsigned integers as follows: - Bits 31-29 - indirect action type. - Bits 28-25 - port on which connection tracking action was created. - Bits 24-0 - index of connection tracking object. Macro defining a bit s

[PATCH 0/4] net/mlx5: connection tracking changes

2024-02-21 Thread Dariusz Sosnowski
Patches 1 and 2 contain fixes for existing implementation of connection tracking flow actions. Patch 3 adds support for sharing connection tracking flow actions between ports when ports' flow engines are configured with RTE_FLOW_PORT_FLAG_SHARE_INDIRECT flag set. Patch 4 is based on the previous

RE: [EXT] [PATCH v2 8/8] crypto/ipsec_mb: set and use session ID

2024-02-21 Thread Power, Ciara
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, February 21, 2024 5:10 AM > To: Patrick Robb > Cc: Fangming Fang ; Akhil Goyal > ; De Lara Guarch, Pablo > ; tho...@monjalon.net; Power, Ciara > ; Ji, Kai ; Ruifeng Wang > ; Mcnamara, John ; > dev@dpdk.org; Marchand, D

Re: [RFC v3 1/6] eal: add static per-lcore memory allocation facility

2024-02-21 Thread Jerin Jacob
On Tue, Feb 20, 2024 at 2:35 PM Mattias Rönnblom wrote: > > Introduce DPDK per-lcore id variables, or lcore variables for short. > > An lcore variable has one value for every current and future lcore > id-equipped thread. > > The primary use case is for statically allocating > small chunks of oft

Re: [PATCH v3 10/11] eventdev: clarify docs on event object fields and op types

2024-02-21 Thread Jerin Jacob
On Tue, Feb 20, 2024 at 11:09 PM Bruce Richardson wrote: > > On Fri, Feb 09, 2024 at 02:44:04PM +0530, Jerin Jacob wrote: > > On Fri, Feb 2, 2024 at 6:11 PM Bruce Richardson > > wrote: > > > > > > Clarify the meaning of the NEW, FORWARD and RELEASE event types. > > > For the fields in "rte_event"

RE: [EXT] Re: [PATCH v2] raw/cnxk_bphy: switch to dynamic logging

2024-02-21 Thread Tomasz Duszynski
>-Original Message- >From: Thomas Monjalon >Sent: Wednesday, February 21, 2024 3:00 AM >To: Tomasz Duszynski >Cc: dev@dpdk.org; Jakub Palider ; Jerin Jacob >; >david.march...@redhat.com; step...@networkplumber.org; Jerin Jacob > >Subject: [EXT] Re: [PATCH v2] raw/cnxk_bphy: switch to