[PATCH v2] graph: fix does not return the unique id when create graph

2024-05-09 Thread Gongming Chen
From: Gongming Chen When the order of graph destroy is not the reverse order of create, that is, when it is destroyed at will, the newly created graph id will be the same as the existing graph id, which is not the expected unique graph id. This graph id incorrectly corresponds to multiple graphs.

[PATCH v2] graph: fix does not return the unique id when create graph

2024-05-09 Thread Gongming Chen
From: Gongming Chen When the order of graph destroy is not the reverse order of create, that is, when it is destroyed at will, the newly created graph id will be the same as the existing graph id, which is not the expected unique graph id. This graph id incorrectly corresponds to multiple graphs.

[PATCH v1] graph: fix does not return the unique id when create graph

2024-05-09 Thread Gongming Chen
From: Gongming Chen When the order of graph destroy is not the reverse order of create, that is, when it is destroyed at will, the newly created graph id will be the same as the existing graph id, which is not the expected unique graph id. This graph id incorrectly corresponds to multiple graphs.

[PATCH] graph: fix does not return the unique id when create graph

2024-05-09 Thread Gongming Chen
From: Gongming Chen When the order of graph destroy is not the reverse order of create, that is, when it is destroyed at will, the newly created graph id will be the same as the existing graph id, which is not the expected unique graph id. This graph id incorrectly corresponds to multiple graphs.

[RFC 3/3] net/tap: use generic SW stats

2024-05-09 Thread Stephen Hemminger
Use new common sw statistics. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 100 ++ drivers/net/tap/rte_eth_tap.h | 17 ++ 2 files changed, 21 insertions(+), 96 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/

[RFC 2/3] net/af_packet: use SW stats helper

2024-05-09 Thread Stephen Hemminger
Use the new generic SW stats. Signed-off-by: Stephen Hemminger --- drivers/net/af_packet/rte_eth_af_packet.c | 97 --- 1 file changed, 16 insertions(+), 81 deletions(-) diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c index

[RFC 1/3] ethdev: add internal helper of SW driver statistics

2024-05-09 Thread Stephen Hemminger
This clones the staistic update code from virtio for use by other drivers. It also uses native uint64_t on 64 bit platform but atomic operations on 32 bit platforms. Signed-off-by: Stephen Hemminger ethdev: use atomic on 32 --- lib/ethdev/ethdev_swstats.c | 294 +

[RFC 0/3] generic sw counters

2024-05-09 Thread Stephen Hemminger
This is my attempt to demonstrate: - generic counters for SW drivers, the example does af_packet and tap but same should be applied to af_xdp, virtio, etc. - counters are safe against 64 bit tearing on 32 bit platform The naming and organization could be improved: - should this be in rt

Re: [RFC v3] net/af_packet: make stats reset reliable

2024-05-09 Thread Stephen Hemminger
On Thu, 9 May 2024 16:19:08 +0200 Morten Brørup wrote: > > From: Morten Brørup [mailto:m...@smartsharesystems.com] > > Sent: Thursday, 9 May 2024 13.37 > > > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Thursday, 9 May 2024 11.30 > > > > > > On Thu, May 09, 2024 a

Re: [PATCH] lib/hash: setting the maximum reclamation size

2024-05-09 Thread Abdullah Ömer Yamaç
Hello, Is there any comment on this patch? On Tue, Apr 23, 2024 at 4:51 PM Abdullah Ömer Yamaç wrote: > Hello, > Any comment on this patch? > > On Wed, Apr 17, 2024 at 4:39 PM Abdullah Ömer Yamaç > wrote: > >> In the previous implementation, the maximum reclamation size was set >> to RTE_HASH_R

Re: [PATCH v5] lib/hash: add defer queue reclaim API

2024-05-09 Thread Abdullah Ömer Yamaç
Hello, Any other comments? On Sat, Apr 27, 2024 at 10:54 PM Abdullah Ömer Yamaç wrote: > This patch adds a new feature to the hash library to allow the user to > reclaim the defer queue. This is useful when the user wants to force > reclaim resources that are not being used. This API is only av

Re: [PATCH] eal/arm: replace RTE_BUILD_BUG on non-constant

2024-05-09 Thread Tyler Retzlaff
On Thu, May 09, 2024 at 12:11:50PM +0100, Daniel Gregory wrote: > On Fri, May 03, 2024 at 06:02:36PM -0700, Stephen Hemminger wrote: > > On Thu, 2 May 2024 15:21:16 +0100 > > Daniel Gregory wrote: > > > > > The ARM implementation of rte_pause uses RTE_BUILD_BUG_ON to check > > > memorder, which

RE: [RFC v3] net/af_packet: make stats reset reliable

2024-05-09 Thread Morten Brørup
> From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Thursday, 9 May 2024 13.37 > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > Sent: Thursday, 9 May 2024 11.30 > > > > On Thu, May 09, 2024 at 09:43:16AM +0200, Morten Brørup wrote: > > > > From: Stephen Hemminger

[PATCH] net/mlx5: fix HWS support for item NSH

2024-05-09 Thread Gavin Li
Allow item NSH in HWS and set item_flags. Fixes: f6164649a8 ("net/mlx5/hws: support VXLAN-GPE matching") Signed-off-by: Gavin Li Reviewed-by: Bing Zhao --- drivers/net/mlx5/hws/mlx5dr_definer.c | 3 +++ drivers/net/mlx5/mlx5_flow_hw.c | 13 + 2 files changed, 16 insertions(+)

RE: [RFC v3] net/af_packet: make stats reset reliable

2024-05-09 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Thursday, 9 May 2024 11.30 > > On Thu, May 09, 2024 at 09:43:16AM +0200, Morten Brørup wrote: > > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > > Sent: Wednesday, 8 May 2024 22.54 > > > > > > On Wed, 8 May 202

[PATCH v2 5/5] dts: add `show port stats` command to TestPmdShell

2024-05-09 Thread Luca Vizzarro
Add a new TestPmdPortStats data structure to represent the output returned by `show port stats`, which is implemented as part of TestPmdShell. Bugzilla ID: 1407 Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/remote_session/testpmd_shell.py | 68 +++

[PATCH v2 4/5] dts: add `show port info` command to TestPmdShell

2024-05-09 Thread Luca Vizzarro
Add a new TestPmdPort data structure to represent the output returned by `show port info`, which is implemented as part of TestPmdShell. The TestPmdPort data structure and its derived classes are modelled based on the relevant testpmd source code. This implementation makes extensive use of regula

[PATCH v2 3/5] dts: add parsing utility module

2024-05-09 Thread Luca Vizzarro
Adds parsing text into a custom dataclass. It provides a new `TextParser` dataclass to be inherited. This implements the `parse` method, which combined with the parser functions, it can automatically parse the value for each field. This new utility will facilitate and simplify the parsing of compl

[PATCH v2 2/5] dts: skip first line of send command output

2024-05-09 Thread Luca Vizzarro
The first line of the InteractiveShell send_command method is generally the command input field. This sometimes is unwanted, therefore this commit enables the possibility of omitting the first line from the returned output. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/frame

[PATCH v2 1/5] dts: fix InteractiveShell command prompt filtering

2024-05-09 Thread Luca Vizzarro
When sending a command using an instance of InteractiveShell the output should filter out the trailing shell prompt when returning it. After every command two shell prompts are summoned. One is consumed as it is used as a delimiter for the command output. The second one is not consumed and left for

[PATCH v2 0/5] dts: testpmd show port info/stats

2024-05-09 Thread Luca Vizzarro
Hello, sending in v2: - refactored parsing utility - changed functionality of the parser for conciseness - added a usage example to the parsing module Best, Luca --- Depends-on: series-31896 ("dts: update mypy and clean up") --- Luca Vizzarro (5): dts: fix InteractiveShell command prompt filt

Re: DPDK Release Status Meeting 2024-05-09

2024-05-09 Thread lihuisong (C)
Hi John and all, 在 2024/5/9 16:46, Mcnamara, John 写道: Release status meeting minutes 2024-05-09 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * AMD * ARM * Intel * Marvell * Nvidia * Red Hat Release

[PATCH v2 8/8] dts: use Unpack for type checking and hinting

2024-05-09 Thread Luca Vizzarro
Interactive shells that inherit DPDKShell initialise their params classes from a kwargs dict. Therefore, static type checking is disabled. This change uses the functionality of Unpack added in PEP 692 to re-enable it. The disadvantage is that this functionality has been implemented only with TypedD

[PATCH v2 7/8] dts: rework interactive shells

2024-05-09 Thread Luca Vizzarro
The way nodes and interactive shells interact makes it difficult to develop for static type checking and hinting. The current system relies on a top-down approach, attempting to give a generic interface to the test developer, hiding the interaction of concrete shell classes as much as possible. Whe

[PATCH v2 6/8] dts: use testpmd params for scatter test suite

2024-05-09 Thread Luca Vizzarro
Update the buffer scatter test suite to use TestPmdParameters instead of the StrParams implementation. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/tests/TestSuite_pmd_buffer_scatter.py | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/d

[PATCH v2 5/8] dts: add testpmd shell params

2024-05-09 Thread Luca Vizzarro
Implement all the testpmd shell parameters into a data structure. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/params/testpmd.py | 608 ++ dts/framework/remote_session/testpmd_shell.py | 42 +- dts/tests/TestSuite_pmd_buffer_scatter.

[PATCH v2 4/8] dts: remove module-wide imports

2024-05-09 Thread Luca Vizzarro
Remove the imports in the testbed_model and remote_session modules init file, to avoid the initialisation of unneeded modules, thus removing or limiting the risk of circular dependencies. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/remote_session/__init__.py

[PATCH v2 3/8] dts: refactor EalParams

2024-05-09 Thread Luca Vizzarro
Move EalParams to its own module to avoid circular dependencies. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/params/eal.py | 50 +++ dts/framework/remote_session/testpmd_shell.py | 2 +- dts/framework/testbed_model/sut_node.py

[PATCH v2 2/8] dts: use Params for interactive shells

2024-05-09 Thread Luca Vizzarro
Make it so that interactive shells accept an implementation of `Params` for app arguments. Convert EalParameters to use `Params` instead. String command line parameters can still be supplied by using the `Params.from_str()` method. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek ---

[PATCH v2 1/8] dts: add params manipulation module

2024-05-09 Thread Luca Vizzarro
This commit introduces a new "params" module, which adds a new way to manage command line parameters. The provided Params dataclass is able to read the fields of its child class and produce a string representation to supply to the command line. Any data structure that is intended to represent comma

[PATCH v2 0/8] dts: add testpmd params

2024-05-09 Thread Luca Vizzarro
Hello, sending in v2: - refactored the params module - strengthened typing of the params module - moved the params module into its own package - refactored EalParams and TestPmdParams and moved under the params package - reworked interactions between nodes and shells - refactored imports leading

Re: [PATCH] eal/arm: replace RTE_BUILD_BUG on non-constant

2024-05-09 Thread Daniel Gregory
On Fri, May 03, 2024 at 06:02:36PM -0700, Stephen Hemminger wrote: > On Thu, 2 May 2024 15:21:16 +0100 > Daniel Gregory wrote: > > > The ARM implementation of rte_pause uses RTE_BUILD_BUG_ON to check > > memorder, which is not constant. This causes compile errors when it is > > enabled with RTE_

Re: [PATCH] eal/arm: replace RTE_BUILD_BUG on non-constant

2024-05-09 Thread Daniel Gregory
On Fri, May 03, 2024 at 05:56:24PM -0700, Stephen Hemminger wrote: > On Fri, 3 May 2024 10:46:05 +0100 > Daniel Gregory wrote: > > > On Thu, May 02, 2024 at 02:48:26PM -0700, Stephen Hemminger wrote: > > > There are already constant checks like this elsewhere in the file. > > > > Yes, but they

[PATCH 1/2] dts: update mypy static checker

2024-05-09 Thread Luca Vizzarro
Update the mypy static checker to the latest version and fix all the reported errors. Bugzilla ID: 1433 Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/config/__init__.py | 2 +- dts/framework/logger.py | 4 +- .../interactive_re

[PATCH 2/2] dts: clean up config types

2024-05-09 Thread Luca Vizzarro
Clean up types used with the configuration classes, and use Self from the newly added typing_extensions module. Methods that instantiate their own class should be @classmethod instead of @staticmethod. Bugzilla ID: 1433 Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framewo

[PATCH 0/2] dts: update mypy and clean up

2024-05-09 Thread Luca Vizzarro
Hello, sending in a couple of patches which: - update mypy version & clears all the new warnings - use the new Self type (backported through typing_extensions) which is now supported by mypy updated version Best, Luca Luca Vizzarro (2): dts: update mypy static checker dts: clean up config

Re: [PATCH v2 0/3] Improve interactive shell output gathering and logging

2024-05-09 Thread Luca Vizzarro
On 01/05/2024 17:16, jspew...@iol.unh.edu wrote: This version addresses comments from the last and adds an additional improvement to the logging output that comes from interactive shells. The new way of handling logging allows for not only specification of the host that the command is being sent

Re: [PATCH v2 3/3] dts: Improve logging for interactive shells

2024-05-09 Thread Luca Vizzarro
Reviewed-by: Luca Vizzarro

Re: [PATCH v2 1/3] dts: Improve output gathering in interactive shells

2024-05-09 Thread Luca Vizzarro
Reviewed-by: Luca Vizzarro

Re: [PATCH v2 2/3] dts: Add missing docstring from XML-RPC server

2024-05-09 Thread Luca Vizzarro
Reviewed-by: Luca Vizzarro

Re: [RFC v3] net/af_packet: make stats reset reliable

2024-05-09 Thread Bruce Richardson
On Thu, May 09, 2024 at 09:43:16AM +0200, Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Wednesday, 8 May 2024 22.54 > > > > On Wed, 8 May 2024 20:48:06 +0100 > > Ferruh Yigit wrote: > > > > > > > > > > The idea of load tearing is crazy talk of int

DPDK Release Status Meeting 2024-05-09

2024-05-09 Thread Mcnamara, John
Release status meeting minutes 2024-05-09 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * AMD * ARM * Intel * Marvell * Nvidia * Red Hat Release Dates - The following are the current/updated working date

Re: [RFC] graph/node: feedback and future improvements

2024-05-09 Thread Jerin Jacob
On Thu, May 9, 2024 at 3:34 AM Robin Jarry wrote: > > Hi Jerin, > > Jerin Jacob, May 04, 2024 at 12:03: > > 2) Control plane code: IMO, if you are willing, I will be glad to see > >it is hosted at https://www.dpdk.org/hosted-projects/ like pktgen. > >This may attract more developers for co

RE: [RFC v3] net/af_packet: make stats reset reliable

2024-05-09 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, 8 May 2024 22.54 > > On Wed, 8 May 2024 20:48:06 +0100 > Ferruh Yigit wrote: > > > > > > > The idea of load tearing is crazy talk of integral types. It would > break so many things. > > > It is the kind of stupid co