On Tue, May 28, 2024 at 3:31 PM Pavan Nikhilesh Bhagavatula
wrote:
>
>
>
> > -Original Message-
> > From: Bruce Richardson
> > Sent: Tuesday, May 28, 2024 3:10 PM
> > To: Pavan Nikhilesh Bhagavatula
> > Cc: Jerin Jacob ; Nithin Kumar Dabilpuram
> > ; Kiran Kumar Kokkilagadda
> > ; Sunil
Dear Lincoln,
Thank you very much for providing this reference.
I've to admit that I didn't know about this library but I'm looking into it
but I have some questions/concerns.
This library seems to be abandoned since 2 years, at least this is what I
see from both the documentation and also thei
> Crypto callbacks macro is defined with value 1 and being used with ifdef,
> on config value is changed to 0 to disable, crypto callback changes
> still being compiled.
I believe we can use #if instead of ifdefs.
It seems convenient to enable/disable in my opinion.
We can use both, but whatever w
On Wed, May 29, 2024 at 01:31:39PM +0530, Jerin Jacob wrote:
> On Tue, May 28, 2024 at 3:31 PM Pavan Nikhilesh Bhagavatula
> wrote:
> >
> >
> >
> > > -Original Message-
> > > From: Bruce Richardson
> > > Sent: Tuesday, May 28, 2024 3:10 PM
> > > To: Pavan Nikhilesh Bhagavatula
> > > Cc:
> -Original Message-
> From: Akhil Goyal
> Sent: Wednesday, May 29, 2024 2:05 PM
> To: Kundapura, Ganapati ; dev@dpdk.org;
> Ferruh Yigit ; tho...@monjalon.net; Richardson,
> Bruce
> Cc: Gujjar, Abhinandan S ;
> ciara.po...@intel.com; fanzhang@gmail.com
> Subject: RE: [EXTERNAL] [P
Allow header only libraries.
Signed-off-by: Paul Szczepanek
Reviewed-by: Honnappa Nagarahalli
Acked-by: Bruce Richardson
---
lib/meson.build | 16
1 file changed, 16 insertions(+)
diff --git a/lib/meson.build b/lib/meson.build
index 179a272932..7c90602bf5 100644
--- a/lib/mes
Add two functions:
- rte_mempool_get_mem_range - get virtual memory range
of the objects in the mempool,
- rte_mempool_get_obj_alignment - get alignment of
objects in the mempool.
Add two tests that test these new functions.
Signed-off-by: Paul Szczepanek
Reviewed-by: Jack Bond-Preston
Reviewed
This patchset is proposing adding a new header only library
with utility functions that allow compression of arrays of pointers.
Since this is a header only library a patch needed to be added to amend
the build system to allow adding libraries without source files.
When passing caches full of poi
Add a test that runs a zero copy burst enqueue and dequeue on a ring
of raw pointers and compressed pointers at different burst sizes to
showcase performance benefits of newly added pointer compression APIs.
Refactored threading code to pass more parameters to threads to
reuse existing code. Added
Add a new utility header for compressing pointers. The provided
functions can store pointers as 32-bit or 16-bit offsets.
The compression takes advantage of the fact that pointers are
usually located in a limited memory region (like a mempool).
We can compress them by converting them to offsets fr
Test compresses and decompresses pointers with various combinations
of memory regions and alignments and verifies the pointers are
recovered correctly. Additionally tests helper macros perform
calculations correctly.
Signed-off-by: Paul Szczepanek
Reviewed-by: Honnappa Nagarahalli
Reviewed-by: N
Documentation added in the prog guide for the new
utility functions for pointer compression
showing example code and potential usecases.
Signed-off-by: Paul Szczepanek
Reviewed-by: Honnappa Nagarahalli
Reviewed-by: Nathan Brown
Reviewed-by: Jack Bond-Preston
---
MAINTAINERS
On 28/05/2024 20:29, Paul Szczepanek wrote:
>
>
> On 24/05/2024 10:09, Konstantin Ananyev wrote:
>>
>>
>>> I have added macros to help find the parameters and I have added mempool
>>> functions that allow you to determine if you can use the mempool and
>>> what params it needs. The new mempool
On Wed, May 15, 2024 at 4:50 PM Nicholas Pratte wrote:
>
> >What's the difference between this version and v4?
>
> Version 5 was a response to your suggestions regarding the semantics
> of the hugepage variable names as it relates to countable or
> uncountable nouns. This patch, which was original
>
> Added a new fast path API to get the number of used crypto device queue pair
> depth at any given point.
>
> An implementation in cnxk crypto driver is also added along with a test case
> in
> test app.
>
> The addition of new API causes an ABI warning.
> This is suppressed as the updated s
On Tue, May 28, 2024 at 2:05 PM Luca Vizzarro wrote:
>
> On 24/05/2024 17:17, Patrick Robb wrote:
> > Luca, I assume what you had in mind was we will run
> > dts-check-format.sh, so including isort and pylama, as opposed to just
> > mypy? Thanks.
> I originally thought of mypy only, Juraj suggeste
On Tue, May 28, 2024 at 2:00 PM Luca Vizzarro wrote:
>
> On 24/05/2024 15:51, Patrick Robb wrote:
> > I think this is fine. Another option would be to move sut_nodes and
> > tg_nodes up as DTSRunner attributes.
This is a good suggestion. Everything in DTSRunner is tied to a
particular execution/b
Adding Bing Zhao as NVIDIA mlx5 maintainer.
Signed-off-by: Dariusz Sosnowski
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index c9adff9846..af22c2c9fb 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -868,6 +868,7 @@ F: doc/guides/nics/features/mlx4.
On Tue, May 14, 2024 at 1:30 PM Luca Vizzarro wrote:
>
> On 13/05/2024 17:02, Juraj Linkeš wrote:
> >> def _filter_test_cases(
> >> self, test_suite_class: type[TestSuite], test_cases_to_run:
> >> Sequence[str]
> >> -) -> tuple[list[MethodType], list[MethodType]]:
> >> +)
> diff --git a/dts/poetry.lock b/dts/poetry.lock
> index a734fa71f0..df9cecb7e0 100644
> --- a/dts/poetry.lock
> +++ b/dts/poetry.lock
> @@ -1,4 +1,4 @@
> -# This file is automatically @generated by Poetry 1.5.1 and should not be
> changed by hand.
> +# This file is automatically @generated by Poe
> > Subject: RE: [EXTERNAL] [PATCH v1] crypto: fix build issues on crypto
> > callbacks
> > macro undefined
> >
> > > Crypto callbacks macro is defined with value 1 and being used with
> > > ifdef, on config value is changed to 0 to disable, crypto callback
> > > changes still being compiled.
> >
On Thu, May 9, 2024 at 12:57 PM Luca Vizzarro wrote:
>
> Clean up types used with the configuration classes, and use Self from
> the newly added typing_extensions module.
>
> Methods that instantiate their own class should be @classmethod instead
> of @staticmethod.
>
> Bugzilla ID: 1433
>
> Signe
On 4/1/24 11:34, Morten Brørup wrote:
From: Stephen Hemminger [mailto:step...@networkplumber.org]
Sent: Monday, 1 April 2024 00.03
On Wed, 20 Mar 2024 14:33:35 -0700
Tyler Retzlaff wrote:
+#ifdef RTE_TOOLCHAIN_MSVC
+#define __rte_constant(e) 0
+#else
+#define __rte_constant(e) __extension__(_
On 5/27/24 15:00, Bruce Richardson wrote:
On Wed, Mar 20, 2024 at 02:33:35PM -0700, Tyler Retzlaff wrote:
MSVC does not have a __builtin_constant_p intrinsic so provide
__rte_constant(e) that expands false for MSVC and to the intrinsic for
GCC.
Signed-off-by: Tyler Retzlaff
---
lib/eal/inclu
On 3/26/24 12:57, Morten Brørup wrote:
From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
Sent: Wednesday, 20 March 2024 22.34
Use newly introduced __rte_constant(e) macro instead of directly using
__builtin_constant_p() allowing mempool to be built by MSVC.
Signed-off-by: Tyler Retzlaf
> From: Paul Szczepanek [mailto:paul.szczepa...@arm.com]
> Sent: Wednesday, 29 May 2024 12.23
>
> Add two functions:
> - rte_mempool_get_mem_range - get virtual memory range
> of the objects in the mempool,
> - rte_mempool_get_obj_alignment - get alignment of
> objects in the mempool.
>
> Add two
> From: Paul Szczepanek [mailto:paul.szczepa...@arm.com]
> Sent: Wednesday, 29 May 2024 12.23
>
> Add a new utility header for compressing pointers. The provided
> functions can store pointers as 32-bit or 16-bit offsets.
>
> The compression takes advantage of the fact that pointers are
> usually
On Tue, May 28, 2024 at 07:28:31AM +, Soumyadeep Hore wrote:
> The aim of the changes is to remove NVME dependency on
Hi,
The intro words "The aim of the changes" is unnecessary. Just shorten the
commit log by stating what the patch is for without any intro:
"Remove NVME dependency on memory
On Tue, May 28, 2024 at 07:28:33AM +, Soumyadeep Hore wrote:
> Some compilers will use 64-bit addressing and compiler will detect
> such loss of data
>
> virtchnl2.h(1890,40): warning C4244: '=': conversion from '__int64' to
> '__le32', possible loss of data
>
> on line 1890
> offset = (u8 *)
On 16/05/2024 09:59, Morten Brørup wrote:
> Added information about the memory chunks holding the objects in the
> mempool when dumping the status of the mempool to a file.
>
> Signed-off-by: Morten Brørup
> ---
> lib/mempool/rte_mempool.c | 10 ++
> 1 file changed, 10 insertions(+)
>
> -Original Message-
> From: Du, Frank
> Sent: Thursday, May 23, 2024 8:56 AM
> To: Morten Brørup ; Ferruh Yigit
> ; dev@dpdk.org; Andrew Rybchenko
> ; Burakov, Anatoly
>
> Cc: Loftus, Ciara
> Subject: RE: [PATCH v2] net/af_xdp: fix umem map size for zero copy
>
> > -Original Mess
On Tue, May 28, 2024 at 07:28:34AM +, Soumyadeep Hore wrote:
> When the message for getting timestamp latches is sent by the driver,
> number of latches is equal to 0. Current implementation of message
> validation function incorrectly notifies this kind of message length as
> invalid.
>
This
12/03/2024 18:54, Tyler Retzlaff:
> rte_os.h includes sched.h so install sched.h to allow DPDK installed to
> DESTDIR to be usable.
>
> Fixes: e8428a9d89f1 ("eal/windows: add some basic functions and macros")
> Cc: sta...@dpdk.org
> Cc: pallavi.ka...@intel.com
>
> Signed-off-by: Tyler Retzlaff
>
On Tue, May 28, 2024 at 07:35:50AM +, Soumyadeep Hore wrote:
> Dont initialize the variables if not needed.
>
> Also use 'err' instead of 'status', 'ret_code', 'ret' etc.
> for consistency and change the return label 'sq_send_command_out'
> to 'err_unlock'.
This is consistency of naming withi
On Tue, May 14, 2024 at 04:17:16PM +0100, Anatoly Burakov wrote:
> Current code is a result of work to reduce duplication between various
> device models. However, the logic that was replaced did not exactly
> match the new logic, and as a result the link power down was not
> working correctly for
On Wed, May 29, 2024 at 02:34:16PM +0100, Bruce Richardson wrote:
> On Tue, May 14, 2024 at 04:17:16PM +0100, Anatoly Burakov wrote:
> > Current code is a result of work to reduce duplication between various
> > device models. However, the logic that was replaced did not exactly
> > match the new l
> From: Paul Szczepanek [mailto:paul.szczepa...@arm.com]
> Sent: Wednesday, 29 May 2024 12.23
>
> Add two functions:
> - rte_mempool_get_mem_range - get virtual memory range
> of the objects in the mempool,
> - rte_mempool_get_obj_alignment - get alignment of
> objects in the mempool.
>
> Add two
> From: Paul Szczepanek [mailto:paul.szczepa...@arm.com]
> Sent: Wednesday, 29 May 2024 14.55
>
> On 16/05/2024 09:59, Morten Brørup wrote:
> > Added information about the memory chunks holding the objects in the
> > mempool when dumping the status of the mempool to a file.
> >
> > Signed-off-by:
> From: Loftus, Ciara [mailto:ciara.lof...@intel.com]
> Sent: Wednesday, 29 May 2024 14.58
>
> > From: Du, Frank
> > Sent: Thursday, May 23, 2024 8:56 AM
> >
> > > From: Morten Brørup
> > > Sent: Thursday, May 23, 2024 3:41 PM
> > >
> > > > From: Du, Frank [mailto:frank...@intel.com]
> > > > Sen
12/03/2024 17:52, Tyler Retzlaff:
> When EAL is built with MSVC it is possible to dynamically load plugins
> on Windows. Hook eal_plugins_init into rte_eal_init if built with MSVC
> and provide code to load plugins on Windows.
>
> Signed-off-by: Tyler Retzlaff
> Acked-by: Dmitry Kozlyuk
> ---
>
Morten Brørup writes:
> Aaron,
>
> I have been trying to submit a patch with a dependency on another
> patch, but it keeps failing, and the error message "Apply patch set
> 140352 failed: 404 Not Found" isn't very helpful.
>
> Could you please take a look at it and let me know what's going on:
>
16/04/2024 01:14, Tyler Retzlaff:
> On Mon, Apr 15, 2024 at 03:17:38PM -0700, Stephen Hemminger wrote:
> > On Mon, 15 Apr 2024 14:32:26 -0700
> > Tyler Retzlaff wrote:
> >
> > > Add missing f suffix to floating point literal to avoid warning about
> > > truncation from double to float.
> > >
> >
> From: Aaron Conole [mailto:acon...@redhat.com]
> Sent: Wednesday, 29 May 2024 16.34
>
> Morten Brørup writes:
>
> > Aaron,
> >
> > I have been trying to submit a patch with a dependency on another
> > patch, but it keeps failing, and the error message "Apply patch set
> > 140352 failed: 404 No
Crypto callbacks are invoked on checking from head node
which is always valid pointer.
This patch checks next node from the head node if callbacks
registered before invoking callbacks.
Fixes: 1c3ffb95595e ("cryptodev: add enqueue and dequeue callbacks")
Signed-off-by: Ganapati Kundapura
---
v2:
Crypto callbacks macro is defined with value 1 and being used with ifdef,
on config value is changed to 0 to disable, crypto callback changes
still being compiled.
Used #if instead of #ifdef and also wrapped crypto callback changes
under RTE_CRYPTO_CALLBACKS macro to fix build issues when macro is
03/04/2024 20:50, Morten Brørup:
> > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com]
> > Sent: Wednesday, 3 April 2024 20.23
> >
> > Some libraries that could be built with MSVC were not being built.
> >
> > Switch from explicit include to exclude of libs to get immediate CI
> > covera
20/03/2024 22:33, Tyler Retzlaff:
> Use newly introduced __rte_constant(e) macro instead of directly using
> __builtin_constant_p() allowing mempool to be built by MSVC.
Does it mean we should enable mempool build?
If yes, please send a v2.
On 29/05/2024 12:39, Juraj Linkeš wrote:
diff --git a/dts/poetry.lock b/dts/poetry.lock
index a734fa71f0..df9cecb7e0 100644
--- a/dts/poetry.lock
+++ b/dts/poetry.lock
@@ -1,4 +1,4 @@
-# This file is automatically @generated by Poetry 1.5.1 and should not be
changed by hand.
+# This file is auto
The existing hash functions in DPDK are not cryptographically
secure and can be subject to carefully crafted packets causing
DoS attack.
Add SipHash which is a fast and cryptographicly sound hash
created by Jean-Philippe Aumasson and Daniel J. Bernstein.
Siphash is widely used by Linux, FreeBSD, O
On 28/05/2024 22:07, Jeremy Spewock wrote:
+if start_on_init:
+self.start_application()
What's the reason for including start_on_init? Is there a time when
someone would create an application but not want to start it when they
create it? It seems like it is always true curre
On 28/05/2024 22:05, Jeremy Spewock wrote:
This looks good, the only comment I had was in some classes the
docstrings didn't get updated to what was discussed previously in the
comments (making sure the comments are included in the class'
docstring). I tried to point out a few places where I noti
Fix bug where dumpcap and pdump programs would leave resources
if killed with SIGTERM (or if file gets full).
v2 - rebase and rewording
Stephen Hemminger (2):
app/dumpcap: handle SIGTERM and SIGHUP
app/pdump: handle SIGTERM and SIGHUP
app/dumpcap/main.c | 14 --
app/pdump/main.c
If the dumpcap is killed it does not cleanup which leaves
the ring buffer and the memory pool behind.
Until resource are exhausted devices will continue to fill the ring.
Fix by having the application handle SIGTERM, SIGHUP, and SIGPIPE.
These are the same signals handled in same way by the wiresh
The pdump application will leak ring and memory pool if killed
by SIGTERM. Like dumpcap, the pdump process should cleanup
if process terminates due to being killed or hangup.
Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing")
Signed-off-by: Stephen Hemminger
---
app/pdump/main.c
On 29/05/2024 14:56, Morten Brørup wrote:
>> From: Paul Szczepanek [mailto:paul.szczepa...@arm.com]
>> Sent: Wednesday, 29 May 2024 12.23
>>
>> Add two functions:
>> - rte_mempool_get_mem_range - get virtual memory range
>> of the objects in the mempool,
>> - rte_mempool_get_obj_alignment - get
On Wed, May 29, 2024 at 11:59 AM Luca Vizzarro wrote:
>
> On 28/05/2024 22:05, Jeremy Spewock wrote:
> > This looks good, the only comment I had was in some classes the
> > docstrings didn't get updated to what was discussed previously in the
> > comments (making sure the comments are included in
Acked-by: Nithin Dabilpuram
On Wed, Mar 27, 2024 at 2:47 PM Robin Jarry wrote:
>
> In some cases, the node context data is used to store two pointers
> because the data is larger than the reserved 16 bytes. Having to define
> intermediate structures just to be able to cast is tedious. And withou
On Wed, May 29, 2024 at 04:29:29PM +0200, Thomas Monjalon wrote:
> 12/03/2024 17:52, Tyler Retzlaff:
> > When EAL is built with MSVC it is possible to dynamically load plugins
> > on Windows. Hook eal_plugins_init into rte_eal_init if built with MSVC
> > and provide code to load plugins on Windows.
From: Jeremy Spewock
This version addresses the small comments that were on the previous
version such as documentation of variable name changes.
Jeremy Spewock (3):
dts: Improve output gathering in interactive shells
dts: Add missing docstring from XML-RPC server
dts: Improve logging for i
From: Jeremy Spewock
The current implementation of consuming output from interactive shells
relies on being able to find an expected prompt somewhere within the
output buffer after sending the command. This is useful in situations
where the prompt does not appear in the output itself, but in some
From: Jeremy Spewock
When this XML-RPC server implementation was added, the docstring had to
be shortened in order to reduce the chances of this race condition being
encountered. Now that this race condition issue is resolved, the full
docstring can be restored.
Signed-off-by: Jeremy Spewock
--
From: Jeremy Spewock
The messages being logged by interactive shells currently are using the
same logger as the node they were created from. Because of this, when
sending interactive commands, the logs make no distinction between when
you are sending a command directly to the host and when you ar
On Mon, May 20, 2024 at 1:31 PM Luca Vizzarro wrote:
>
> On 14/05/2024 21:14, jspew...@iol.unh.edu wrote:
> > +class CriticalInteractiveShell(InteractiveShell):
>
> > +_get_priviledged_command: Callable[[str], str] | None
> typo: privileged
Ack.
> > +
> > +def __init__(
> > +sel
On Wed, May 22, 2024 at 9:53 AM Patrick Robb wrote:
>
> Reviewed-by: Patrick Robb
>
> I don't have any comments beyond Luca's suggestions, but saw the typo below.
>
> On Tue, May 14, 2024 at 4:15 PM wrote:
> > +def __exit__(self, type: BaseException, value: BaseException,
> > traceback: Tra
On Mon, May 20, 2024 at 1:35 PM Luca Vizzarro wrote:
>
> On 14/05/2024 21:14, jspew...@iol.unh.edu wrote:
> > diff --git a/dts/framework/remote_session/testpmd_shell.py
> > b/dts/framework/remote_session/testpmd_shell.py
> > index 33b3e7c5a3..4e608998f9 100644
> > --- a/dts/framework/remote_sessi
On Mon, May 20, 2024 at 1:56 PM Luca Vizzarro wrote:
>
> On 14/05/2024 21:14, jspew...@iol.unh.edu wrote:
> > +# adjust the MTU of the SUT ports
> > +testpmd.set_port_mtu(0, 9000)
> > +testpmd.set_port_mtu(1, 9000)
>
> should you perhaps do this for every port i
There is a loop inside the flow_hw_resource_release() function
that tries to free all the template patterns and tables until they
are successfully released. But some of the tables may be still in use
in case of the ungraceful application termination. Which causes the
forever loop in the app on the
Latencystats uses unnecessary floating point and is inaccurate if the number
of cycles per ns is not an integral value. Cleanup the code and add
more tests as well.
v6 - rebase and combine updates to test
Stephen Hemminger (8):
latencystats: replace use of VLA
latencystats: handle fractional
The temporary array latencystats is not needed if the algorithm
is converted into one pass.
Signed-off-by: Stephen Hemminger
Acked-by: Morten Brørup
Acked-by: Tyler Retzlaff
---
lib/latencystats/rte_latencystats.c | 31 +++--
1 file changed, 16 insertions(+), 15 deletio
The TSC frequency is not always an integral number of nanoseconds.
For examples, cycles per nanoseconds on my test system is 2.8.
Fix by using floating point where needed and calculate value once.
Signed-off-by: Stephen Hemminger
---
lib/latencystats/rte_latencystats.c | 17 ++---
1
The cycle counts do not need to be stored as floating point.
Instead keep track of latency in cycles, and convert to
nanoseconds when read.
Use scaled math with exponential Weighted Moving Average weight
of .25 to avoid use of floating point for that.
The average latency took too long to "warm up
All messages that because of an error should be at log level
NOTICE or above. Do not break log messages across lines.
Reword message for the case where getting info about a port
fails and it is skipped.
Signed-off-by: Stephen Hemminger
Acked-by: Tyler Retzlaff
---
lib/latencystats/rte_latencyst
Include what is used here.
Signed-off-by: Stephen Hemminger
---
lib/latencystats/rte_latencystats.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/lib/latencystats/rte_latencystats.c
b/lib/latencystats/rte_latencystats.c
index c0ac60134f..bd8fde2f0c 100
ISO C does not allow casting function pointer to void *.
Resolve by enforcing the reserved argument.
The user_cb argument for rte_latencystats_init() was not
implemented, and had to be NULL anyway.
The log type is local to this function and therefore
can be local to this file.
Signed-off-by: Step
Keeping track of the number of samples is useful when doing
debug and testing to make sure that samples are actually happening.
Signed-off-by: Stephen Hemminger
---
lib/latencystats/rte_latencystats.c | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/lib/l
No need for loop and memset() here. Just use structure
initialization. Remove unnecessary initializations.
Look at the number of samples, min, max and average
numbers to make sure they look correct.
Forward for longer to make sure multiple samples are taken.
Signed-off-by: Stephen Hemminger
---
This is a subset of earlier larger set of changes to fix non inclusive
terms in the DPDK.
The term sanity-check is on the Tier 2 word list from the Inclusive
Naming project.
https://inclusivenaming.org/word-lists/tier-2/sanity-check/
Rationale
This term might be derogatory to neurodive
Replace rte_mbuf_sanity_check() with rte_mbuf_verify()
to match the similar macro RTE_VERIFY() in rte_debug.h
The term sanity check is on the Tier 2 list of words
that should be replaced.
Signed-off-by: Stephen Hemminger
Acked-by: Andrew Rybchenko
Acked-by: Morten Brørup
---
app/test/test_mbu
Sanity check is on the Tier 2 non-inclusive list.
Replace or remove it.
Signed-off-by: Stephen Hemminger
Acked-by: Anatoly Burakov
---
lib/eal/common/eal_common_memory.c | 2 +-
lib/eal/common/eal_common_proc.c | 3 ++-
lib/eal/common/eal_common_trace.c | 2 +-
lib/eal/common/eal_memcfg.h
The word "sanity" is on the not-allowed inclusive naming
list. Replace the unnecessary usage in tests.
Signed-off-by: Stephen Hemminger
---
app/test/test_bitmap.c | 4 +--
app/test/test_bpf.c| 6 ++--
app/test/test_common.c | 2 +-
app/test/test_distrib
Do not use non-inclusive terms.
Signed-off-by: Stephen Hemminger
---
examples/ipsec-secgw/event_helper.c | 2 +-
examples/qos_sched/args.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/examples/ipsec-secgw/event_helper.c
b/examples/ipsec-secgw/event_helper.c
i
Sanity check is on the Tier 2 non-inclusive list.
Replace or remove it.
Signed-off-by: Stephen Hemminger
---
lib/graph/graph.c | 2 +-
lib/graph/graph_stats.c | 2 +-
lib/graph/node.c| 2 +-
lib/jobstats/rte_jobstats.c | 6 +++---
lib/metrics/rte_metrics.c | 2 +-
lib
The word sanity check is unnecessary here.
Signed-off-by: Stephen Hemminger
---
doc/guides/gpus/cuda.rst | 2 +-
doc/guides/sample_app_ug/eventdev_pipeline.rst | 2 +-
doc/guides/tools/testbbdev.rst | 8
3 files changed, 6 insertions(+), 6 deletions
Don't use term sanity check
Signed-off-by: Stephen Hemminger
---
drivers/net/ring/rte_eth_ring.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index b16f5d55f2..1788e68cf3 100644
--- a/drivers/net/ring
Remove non-inclusive term sanity from these Intel drivers.
Signed-off-by: Stephen Hemminger
---
drivers/net/fm10k/fm10k_ethdev.c | 2 +-
drivers/net/fm10k/fm10k_rxtx.c | 2 +-
drivers/net/ixgbe/ixgbe_fdir.c | 2 +-
drivers/net/ixgbe/ixgbe_ipsec.c | 2 +-
drivers/net/ixgbe/ixgbe_rxtx.c | 2
The term "sanity" is on non-inclusive naming list.
Remove it from the Nvidia drivers.
Signed-off-by: Stephen Hemminger
---
drivers/common/mlx5/linux/mlx5_common_os.c | 2 +-
drivers/net/mlx4/mlx4.c| 2 +-
drivers/net/mlx4/mlx4_flow.c | 6 +++---
drivers/net/mlx5
Remove term sanity check in comment.
Signed-off-by: Stephen Hemminger
Acked-by: Andrew Rybchenko
---
drivers/net/sfc/sfc_dp_rx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/sfc/sfc_dp_rx.h b/drivers/net/sfc/sfc_dp_rx.h
index ed667c68d1..17ab10616b 100644
---
Do not use non inclusive terms.
Signed-off-by: Stephen Hemminger
---
drivers/net/ark/ark_ethdev.c| 8
drivers/net/ark/ark_ethdev_rx.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c
index c029dc46b3..
Do not use non-inclusive terms.
Signed-off-by: Stephen Hemminger
---
drivers/net/bnxt/bnxt_hwrm.c | 2 +-
drivers/net/bnxt/hsi_struct_def_dpdk.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index 6ea7
Replace "sanity check"
Signed-off-by: Stephen Hemminger
---
drivers/net/bnx2x/bnx2x.c | 2 +-
drivers/net/bnx2x/bnx2x_stats.c | 8
drivers/net/bnx2x/ecore_sp.c| 2 +-
drivers/net/bnx2x/elink.c | 4 ++--
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drive
Replace "sanity check"
Signed-off-by: Stephen Hemminger
---
drivers/net/nfp/nfp_net_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/nfp/nfp_net_flow.c b/drivers/net/nfp/nfp_net_flow.c
index ea743eed73..2d443bbcfc 100644
--- a/drivers/net/nfp/nfp_net_flow.c
Don't use term sanity.
Signed-off-by: Stephen Hemminger
---
drivers/net/txgbe/txgbe_ipsec.c | 2 +-
drivers/net/txgbe/txgbe_rxtx.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/txgbe/txgbe_ipsec.c b/drivers/net/txgbe/txgbe_ipsec.c
index f9f8108fb8..cadb0943c
Remove non-inclusive terminolgy.
Signed-off-by: Stephen Hemminger
---
drivers/net/cxgbe/cxgbe_ethdev.c | 10 ++
drivers/net/cxgbe/cxgbevf_main.c | 4 ++--
2 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c
Do not use non-inclusive naming.
Signed-off-by: Stephen Hemminger
---
drivers/common/cnxk/roc_nix_tm_ops.c | 2 +-
drivers/common/cnxk/roc_npa.c| 4 ++--
drivers/net/cnxk/cnxk_ethdev.c | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/common/cnxk/roc_
Don't use non-inclusive term.
Signed-off-by: Stephen Hemminger
---
drivers/event/opdl/opdl_evdev.c | 2 +-
drivers/event/opdl/opdl_evdev_init.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/event/opdl/opdl_evdev.c b/drivers/event/opdl/opdl_evdev.c
index b34a
Do not use non-inclusive naming here.
Signed-off-by: Stephen Hemminger
---
drivers/crypto/bcmfs/hw/bcmfs4_rm.c | 6 +++---
drivers/crypto/bcmfs/hw/bcmfs5_rm.c | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/crypto/bcmfs/hw/bcmfs4_rm.c
b/drivers/crypto/bcmfs/hw
Replace non-inclusive language with better comments.
Covers multiple drivers
Signed-off-by: Stephen Hemminger
Acked-by: Hemant Agrawal
---
drivers/bus/fslmc/qbman/qbman_sys_decl.h | 2 +-
drivers/common/cnxk/roc_npa.c | 2 +-
drivers/common/dpaax/caamflib/desc.h | 2 +-
driver
> -Original Message-
> From: Paul Szczepanek
> Sent: Thursday, May 30, 2024 12:18 AM
> To: Morten Brørup ; dev@dpdk.org; Du, Frank
>
> Cc: n...@arm.com; Ferruh Yigit ; Andrew Rybchenko
> ; Burakov, Anatoly
> ; Loftus, Ciara
> Subject: Re: [PATCH v12 2/6] mempool: add functions to get ext
ipv6_tc_fallback will be checked in calling
mlx5_flow_discover_ipv6_tc_support. It should be set "supported" before
checking so that the workaround to use old value would not be used. The
corrected result could be gotten only in this case.
Fixes: edc80bbfcf54 ("net/mlx5: store IPv6 TC detection re
99 matches
Mail list logo
